wine-devel

wine-devel@winehq.org

2 participants
84470 discussions

Re: shlwapi: Finnish translation (resent)
by Alexandre Julliard 09 Jan '06

09 Jan '06

"Ge van Geldorp" <gvg(a)reactos.org> writes: > Previously sent > http://www.winehq.org/pipermail/wine-patches/2005-December/023112.html > > (shlwapi_Fi.rc sent as attachment instead of inline in the hope it won't get > mangled then) Could you please send it as a proper patch? It makes things a lot easier for me (you can still send the whole patch as an attachment if you think it will get mangled). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cabinet: Implement Extract on top of FDI
by Alexandre Julliard 09 Jan '06

09 Jan '06

James Hawkins <truiken(a)gmail.com> writes: > @@ -30,6 +30,7 @@ > #define NO_SHLWAPI_REG > #include "shlwapi.h" > #undef NO_SHLWAPI_REG > +#include "msvcrt/fcntl.h" You shouldn't use msvcrt headers if you are not importing msvcrt, this will cause trouble. Simply copy the definitions you need, like we already do for S_IREAD/IWRITE. -- Alexandre Julliard julliard(a)winehq.org

1 0

Implementing SYS-files for Wine
by Anton Litvinov (wine_user) 09 Jan '06

09 Jan '06

I want to run a proprietary program which does the following things: ... fh = CreateFileA("C:\WINDOWS\system32\DRIVERS\BIOSMAP.SYS", ...); ... dh = CreateFileA("\\.\BIOSMAP", ...); ... r = DeviceIoControl(dh, 0x10000000, ...); ... On recieving 0x10000000 code BIOSMAP maps BIOS content (brand, creation date, etc) to some area and returns address of one null-terminated string from it to main program. Is there a way to re-implement a SYS-file (so that main program would run w/o any change) like it's done with some VXD's in Wine-tree? Can I get some examples? Hope to get your answer, Anton Litvinov

2 1

Re: user: Fix dropdown combo creation when there is no space for an edit control
by Phil Krylov 09 Jan '06

09 Jan '06

Hi, Sorry, I meant: ChangeLog: Fixed dropdown combo creation when there is NO space for an edit control. -- Ph.

1 0

Re: shell32: fix folder icon index when read from registry
by Vitaliy Margolen 09 Jan '06

09 Jan '06

Saturday, January 7, 2006, 9:30:34 AM, Martin Fuchs wrote: > Changelog: > - fix folder icon index when read from registry > - change "DWORD dwNr" into "int icon_idx" at several places Any reason you using int* instead of LPINT? > Index: shell32_main.h > =================================================================== > RCS file: /home/wine/wine/dlls/shell32/shell32_main.h,v > retrieving revision 1.110 > diff -u -p -d -r1.110 shell32_main.h > --- shell32_main.h 28 Nov 2005 11:04:35 -0000 1.110 > +++ shell32_main.h 7 Jan 2006 16:19:07 -0000 Please rediff from the top of the tree.

3 2

Re: Question regarding the Wine Vs WineLib performance
by wine-devel-bounces＠winehq.org 09 Jan '06

09 Jan '06

{\rtf1\ansi\ansicpg1252\fromtext \deff0{\fonttbl {\f0\fswiss Arial;} {\f1\fmodern Courier New;} {\f2\fnil\fcharset2 Symbol;} {\f3\fmodern\fcharset0 Courier New;}} {\colortbl\red0\green0\blue0;\red0\green0\blue255;} \uc1\pard\plain\deftab360 \f0\fs20 On 1/3/06, Ananth M <mekaananth(a)gmail.com> wrote:\par > Then I converted the dll into .so and compiled and linked this .so\par > with win32 program using WineLib and Wineg++\par > The timing that was taken to execute the function exported by the\par > dll ( through .so ) is almost two times, compread with executing using wine.\par >\par > Does any one has any reference for further investigation on this\par > problem or any information\par \par I'm not sure if this is the reason or not, but we discussed this a bit\par at WineConf last year. The concensus was that MSVC produces much\par faster code compared to GCC. Maybe try compiling with MinGW on\par Windows and see what happens with the DLL in Windows?\par \par -Brian\par \par }

4 3

Need help in debugging a stack corruption
by Stefan Dösinger 07 Jan '06

07 Jan '06

Hello, I am working on a DDraw rewrite with WineD3D, and I've hit a problem with Half-Life, which looks like a stack corruption. HL makes a ret from a function which leads into sensless code, and I wasn't able to debug it. That's what happens: From 0x00428a35 there's a call to a function at 0x00408b70. This function calls a lot of DDraw calls, which seem to work fine, but on return, it doesn't return to 0x00428a3a, as it should, but to 0x7fbcd888, which is valid, but contains only garbage code. I assumed that some call runs amok on the stack, and I've set tried setting breakpoints at 0x00428a35, 0x00408b70 and some other addresses. Oddly, this doesn't work(winedbg disables them when continuing), although I can access the code right after start. I can set a DebugBreak() in the last called function(IDirectDraw::FlipToGDISurface), but there it is too late. Are there any other ways to debug this? Does anyone know why setting the breakpoints fails? Well, that's my suspicion for the problem: (an any COM expert comment on this?) To create interfaces for IDirectDraw1 to 7, I created 4 lpVtbl structures for each version, and I cast most DD7 funtions info the older versions. Only where the type or the number of parameters is different, I use a wrapper function. At DD creation, I use whatever version was requested by the app for the new object. The old dd version used a number of macros to cast the various interfaces(defined in ddcomimpl.h). I don't use them. Might this cause the problem? Thanks for your help, Stefan

4 7

Re: Rein Klazes : user32: Separate menu bitmaps and strings.
by paul 07 Jan '06

07 Jan '06

Alexandre Julliard wrote: > Module: wine > Branch: refs/heads/master > Commit: b34868dffa0df144ea9d6e1586a67cff70ae9c4e > URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=b34868dffa0df144ea9d6e1… > > Author: Rein Klazes <wijn(a)wanadoo.nl> > Date: Tue Jan 3 13:23:28 2006 +0100 > > user32: Separate menu bitmaps and strings. > Store bitmaps and bitmaps always in separate fields in the internal > menu structure. Get rid of a lot of assumptions in the code that the > menu can have strings only when it is not some other type and that > bitmaps come in two flavors. > Add a lot of conformance tests, including some submitted by Jason > Edmeades. > > --- > > dlls/user/menu.c | 317 ++++++++++++++++---------- > dlls/user/tests/menu.c | 593 ++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 785 insertions(+), 125 deletions(-) > > > > Regression see http://bugs.winehq.org/show_bug.cgi?id=4250 The set last error function added to GetMenuStringA and GetMenuStringW removed this check which seems to be still needed. if (!IS_STRING_ITEM(item->fType)) return 0; I have tried several times to make a patch of the changes required but I get a lot of white space changes. Paul R.

3 2

Microsoft Office on FreeBSD
by Tom Wickline 07 Jan '06

07 Jan '06

Hello, I've put together a little Microsoft Office on BSD howto on the Wiki, If anyone here uses OpenBSD, NetBSD or DragonFlyBSD I would be interested to know if you can get Office 2000 to install and run with Wine out of the box or with my cheats. :D So others who read the howto in the future will know the status of there distro. http://wiki.winehq.org/Office-BSD?action=show Tom

1 0

Re: shell32: Reimplement a factored SHFileOperation [RESEND 2]
by Mike McCormack 07 Jan '06

07 Jan '06

James Hawkins wrote: > Haven't received any comments yet. Is there anything wrong with this > patch? I know it's large, but it can't be sent in pieces. The new > implementation passes all the tests. > > Changelog: > * Reimplement a factored SHFileOperation. > > dlls/shell32/shlfileop.c | 1131 +++++++++++++++++++--------------------- > dlls/shell32/tests/shlfileop.c | 242 ++------- Hi James, That's a lot of great work! Try submit the tests first with todo_wine {} blocks around the stuff that fails now, then submit a further change with your main patch that shows with tests now pass. That should reduce the size of your patch a little, and show how messed up the old implementation of SHFileOperation is. thanks, Mike

1 0

Re: commit 15667b36e43a571f6bb8726b9dec4f1099d2b4f9 (_fullpath)
by Detlef Riekenberg 06 Jan '06

06 Jan '06

Am Freitag, den 06.01.2006, 10:01 -0600 schrieb Aric Stewart: > ChangeLog: > Additional add a regression test for _fullpath > > dlls/msvcrt/tests/dir.c | 58 + + SetCurrentDirectory("C:\\Windows\\System\\"); + Please do not use a fixed Path. This will not work on many Systems: nt351: "c:\winnt351" nt4.0 + w2k: "c:\winnt" and every windows with a custom Install-Directory. + + ok(_fullpath(full,"test", MAX_PATH)>0,"_fullpath failed\n"); + ">0" is not correct for "char *". The Text in your Tests are useless. Please print error-values and received buffer-content. -- By By ... ... Detlef

1 0

Re: winspool: Printing-Environment-Support for GetPrinterDriverDirectory
by Detlef Riekenberg 06 Jan '06

06 Jan '06

Am Dienstag, den 03.01.2006, 00:51 +0100 schrieb Detlef Riekenberg: What can I do with this Patch ? > Changelog: > - Add Function "validate_envW" to validate the user-supplied > Printing Environment (respect "Windows Version" - Setting) > - Change GetPrinterDriverDirectoryW on top of "validate_envW" > to Report the native Path for NT and Win9x > - 2 Tests are now working in Wine > > > Synced to current git-version with suggestions from Alexandre: > Use a struct to handle the environment-specific parts > > > "validate_envW" / printenv_t will be used by more Functions later. > (WINSPOOL_OpenDriverReg as Example) > -- By By ... ... Detlef

1 0

Re: shell32: fix folder icon index when read from registry
by Martin Fuchs 06 Jan '06

06 Jan '06

Any thing wrong with this patch? On 31.12.2005 21:31:25 Martin Fuchs wrote: > Changelog: > fix folder icon index when read from registry > Index: folders.c > =================================================================== > RCS file: /home/wine/wine/dlls/shell32/folders.c,v > retrieving revision 1.66 > diff -u -p -d -r1.66 folders.c > --- folders.c 26 Aug 2005 10:05:35 -0000 1.66 > +++ folders.c 31 Dec 2005 20:29:30 -0000 > @@ -166,7 +166,7 @@ static HRESULT getIconLocationForFolder( > LPWSTR szIconFile, UINT cchMax, int *piIndex, UINT *pwFlags) > { > IExtractIconWImpl *This = (IExtractIconWImpl *)iface; > - DWORD dwNr; > + DWORD dwNr; /*TODO: change to int type */ > WCHAR wszPath[MAX_PATH]; > WCHAR wszCLSIDValue[CHARS_IN_GUID]; > static const WCHAR shellClassInfo[] = { > '.','S','h','e','l','l','C','l','a','s','s','I','n','f','o',0 }; > @@ -202,9 +202,13 @@ static HRESULT getIconLocationForFolder( > if (!HCR_GetDefaultIconW(folder, szIconFile, cchMax, &dwNr)) > { > lstrcpynW(szIconFile, swShell32Name, cchMax); > - dwNr = IDI_SHELL_FOLDER; > + dwNr = (DWORD)-IDI_SHELL_FOLDER; > } > - *piIndex = -((uFlags & GIL_OPENICON) ? dwNr + 1 : dwNr); > + > + if (uFlags & GIL_OPENICON) > + *piIndex = (int)dwNr<0? (int)dwNr-1: dwNr+1; > + else > + *piIndex = dwNr; > } > return S_OK; > }

2 1

Re: commctl32 datetime fields mad editable with keyboard
by Robert Shearman 06 Jan '06

06 Jan '06

Siim Karus wrote: >@@ -962,6 +1037,33 @@ > DATETIME_IncreaseField (infoPtr, fieldNum, INT_MAX); > DATETIME_SendDateTimeChangeNotify (infoPtr); > break; >+ case VK_NUMPAD0: >+ case VK_NUMPAD1: >+ case VK_NUMPAD2: >+ case VK_NUMPAD3: >+ case VK_NUMPAD4: >+ case VK_NUMPAD5: >+ case VK_NUMPAD6: >+ case VK_NUMPAD7: >+ case VK_NUMPAD8: >+ case VK_NUMPAD9: >+ DATETIME_EditField (infoPtr, fieldNum, vkCode-VK_NUMPAD0); >+ DATETIME_SendDateTimeChangeNotify (infoPtr); >+ break; >+ case (WORD)'0': >+ case (WORD)'1': >+ case (WORD)'2': >+ case (WORD)'3': >+ case (WORD)'4': >+ case (WORD)'5': >+ case (WORD)'6': >+ case (WORD)'7': >+ case (WORD)'8': >+ case (WORD)'9': >+ DATETIME_EditField (infoPtr, fieldNum, vkCode-(WORD)('0')); >+ DATETIME_SendDateTimeChangeNotify (infoPtr); >+ break; >+ > case VK_LEFT: > do { > if (infoPtr->select == 0) { > > I think this would be better done in the processing for the WM_CHAR message instead. Then you wouldn't have the mess of having to handle the numpad keys as well. -- Rob Shearman

1 0

bug in dlls/wined3d/device.c?
by Daniel Skorka 06 Jan '06

06 Jan '06

Hi, I have a question regarding the function IWineD3DDeviceImpl_ActiveRender at lines 5806-5807 (that is in wine 0.9.5). If I read [1] correctly, these two lines: PUSH2(GLX_DRAWABLE_TYPE, GLX_PBUFFER_BIT); PUSH2(GLX_X_RENDERABLE, TRUE); are illegal, as GLX_X_RENDERABLE must be FALSE when GLX_PBUFFER_BIT is set. Comments? Daniel [1] http://publib.boulder.ibm.com/infocenter/pseries/v5r3/index.jsp?topic=/com.…

1 0

WINE 0.9.3 and Photoshop 7 & CS
by Aleksey 06 Jan '06

06 Jan '06

Yesterday I upgraded to WINE 0.9.3, and then tried running Photoshop 7. Photoshop gave me a hardware error. I thought, no problem, I'll just reinstall it, same result. Then I reconfigured WINE using winetools and tried again, same thing. Here is what I got in the Terminal when running Photoshop 7: fixme:actctx:QueryActCtxW stub! fixme:font:WineEngRemoveFontResourceEx :stub fixme:win:EnumDisplayDevicesW ((null),0,0x7fa7de2c,0x00000000), stub! fixme:win:EnumDisplayDevicesW (L"\\\\.\\DISPLAY1",0,0x7fa7de2c,0x00000000), stub! fixme:mscms:EnumColorProfilesA ( (nil), 0x7fa7e694, 0x7fa7e1ac, 0x7fa7e6f4, 0x7fa7e704 ) stub fixme:win:EnumDisplayDevicesW ((null),0,0x7fa7de34,0x00000000), stub! fixme:win:EnumDisplayDevicesW (L"\\\\.\\DISPLAY1",0,0x7fa7de34,0x00000000), stub! fixme:mscms:EnumColorProfilesA ( (nil), 0x7fa7e69c, 0x7fa7e1b4, 0x7fa7e6fc, 0x7fa7e70c ) stub err:shell:HCR_GetFolderAttributes HCR_GetFolderAttributes should be called for simple PIDL's only! fixme:font:WineEngRemoveFontResourceEx :stub fixme:font:WineEngRemoveFontResourceEx :stub Then I tried installing Photoshop CS, knowing that it worked fine with 0.9.2. Photoshop CS told me that certain required files was missing, but I forgot to get down the results from the Terminal. After that I downgraded to WINE 0.9.2 and both versions of Photoshop work great. A little side note: ImageReady 7 works great under 0.9.3, I did not test ImageReady CS. ImageReady 7 works great under 0.9.2 also, but ImageReady CS crashes. God Bless. - Aleksey

6 8

Re: commctl32 datetime fix for certain VC++ AppWizard generated applications
by Robert Shearman 06 Jan '06

06 Jan '06

Siim Karus wrote: > As requested, I split my patches as I could. > > This patch causes Datetime and Calendar to be registered in DllMain > (as the tested applications never called InitCommonControls or > InitCommonControlsEx). I don't think this change is correct for ComCtl32 v5 or below. I am not sure about v6. I am pretty sure all that are registered are the ICC_WIN95_CLASSES as listed on MSDN. Please check your test applications. -- Rob Shearman

1 0

Labels on rotated display not drawing in 0.9 release
by Phil Lodwick 06 Jan '06

06 Jan '06

Hi, I have a display in the portrait position. I am using Option "Rotate" "90" in my XF86Config-4 file. When I rotate the screen like this, labels on Menus, Buttons, Dialog Boxes, etc do not display until after an expose event (eg. running a cursor over them). I have tried Wine 0.9, Wine 0.9.4 and CrossOver 5.0. I use winemine to test Wine, and NotePad in the CrossOver Office distribution to test that configuration -- all fail. If I don't rotate OR if I revert to the 20050524 release of Wine, the problem goes away. Any suggestions on where to start the hunt? Thanks, Phil

1 0

Re: Wine 0.9.5 no longer runs Dragon Naturally Speaking
by Scott Ritchie 06 Jan '06

06 Jan '06

There's no apt repository for old packages, however old debs are available here: http://sourceforge.net/project/showfiles.php?group_id=6241&package_id=174803 I'll put a link to there on the download-deb page at winehq soon. I've forwarded this message to wine-devel as that's the proper place to report regressions, rather than emailing me. Thanks, Scott Ritchie On Fri, 2006-01-06 at 07:36 +0100, Emmanuel Charpentier wrote: > Dear Scott, > > As stated in the title, Wine 0.9.5 no longer runs Dragon Naturally > Speaking (voice recognition). I Cc this mail to peter(a)piments.com, > because he's seriously interested with this program (he published the > how-to-install document...). The program stops early in the setup > process (an error dialog box pops up *behind* DNS' flash screen) : the > error message refers to an "Access violation" error and points to > Dragon's own log (which reports a segment violation and barfs a somewhat > largish stack dump). > > Using DNS on a daily basis, I wish to revert to wine 0.9.4 or 0.9.3, but > I am unable to find a repository for the older Debian packages. Is there > a repository for these packages ? > > Sincerely yours, > > Emmanuel Charpentier

2 1

Re: OLEAUT32: Output a FIXME message only once.
by Cihan Altinay 06 Jan '06

06 Jan '06

Hi, Mike McCormack wrote: > > Unless somebody is planning to fix this soon, it would be nice to just > output it once to remind us that it needs to be fixed later. It's a > memory leak, so it's not worth frightening our users more than once over. > > Mike > > > ChangeLog: > Output a FIXME message only once. > > dlls/oleaut32/typelib.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > a06a1b1d8dbb246eede84fd894e273641477d1fc > diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c > index 4ef590e..70c1d1f 100644 > --- a/dlls/oleaut32/typelib.c > +++ b/dlls/oleaut32/typelib.c > @@ -4287,7 +4287,12 @@ static ULONG WINAPI ITypeInfo_fnRelease( > it means that function is called by ITypeLib2_Release */ > ITypeLib2_Release((ITypeLib2*)This->pTypeLib); > } else { > - FIXME("destroy child objects\n"); > + static int once = 0; > + if (once) I think it should read if (!once) :-) > + { > + once = 1; > + FIXME("destroy child objects\n"); > + } > > TRACE("destroying ITypeInfo(%p)\n",This); > if (This->Name) Cihan

1 0

Re: commctl32 datetime usability fixes
by James Hawkins 06 Jan '06

06 Jan '06

On 1/4/06, Siim Karus <siim04(a)ut.ee> wrote: > Hi! > > I modified datetime control to work with some Visual C++ wizard > generated applications. Also some usability fixes were made (typable > time, updown control notifications processing, calendar popup without > dropdown button disabled, style information synchronisation improved). Please send one fix/modification per patch and one patch per email. -- James Hawkins

1 0

wcmd & start
by Stefan Leichter 06 Jan '06

06 Jan '06

Hello, i found a problem during running a batch file. The problem is the start command. Win9x has it as separate comand (as we currently have it in wine). The Nt based Windows Versions have it as builtin comand in cmd. Wcmd does not know the start command because the start command ist installed in windows/comand directory, but the directory ist not in the path known by wcmd. An easy fix might be to add the windows/comand directory to the path variable on startup of wcmd. Is the fine for everyone? If not please suggest a better solution. Bye Stefan

5 4

Re: [comctl32] Reduce memory usage of the syslink control (Take 5)
by Robert Shearman 05 Jan '06

05 Jan '06

Thomas Weidenmueller wrote: >Reduce memory usage of the syslink control and fix dependent code. > > > Alexandre has already said what he doesn't like about the patch, but I'll be a bit more specific. Put the below changes into a separate patch plus the moving around of the LIF_STATE case in SYSLINK_SetItem, because they are really separate changes. >@@ -878,7 +879,7 @@ > if((Current->Type == slLink) && (Current->u.Link.state & LIS_FOCUSED) && infoPtr->HasFocus) > { > COLORREF PrevColor; >- PrevColor = SetBkColor(hdc, OldBkColor); >+ PrevColor = SetTextColor(hdc, OldBkColor); > DrawFocusRect(hdc, &bl->rc); > SetBkColor(hdc, PrevColor); > } >@@ -972,8 +973,7 @@ > /* clear the document */ > SYSLINK_ClearDoc(infoPtr); > >- textlen = lstrlenW(Text); >- if(Text == NULL || textlen == 0) >+ if(Text == NULL || (textlen = lstrlenW(Text)) == 0) > { > return TRUE; > } >@@ -984,8 +984,9 @@ > /* Render text position and word wrapping in memory */ > HDC hdc = GetDC(infoPtr->Self); > SYSLINK_Render(infoPtr, hdc); >- SYSLINK_Draw(infoPtr, hdc); > ReleaseDC(infoPtr->Self, hdc); >+ >+ InvalidateRect(infoPtr->Self, NULL, TRUE); > } > > return TRUE; >@@ -1531,11 +1553,8 @@ > case WM_SIZE: > { > HDC hdc = GetDC(infoPtr->Self); >- if(hdc != NULL) >- { >- SYSLINK_Render(infoPtr, hdc); >- ReleaseDC(infoPtr->Self, hdc); >- } >+ SYSLINK_Render(infoPtr, hdc); >+ ReleaseDC(infoPtr->Self, hdc); > return 0; > } > > > -- Rob Shearman

1 0

Re: gdi32 test
by Dmitry Timoshkov 05 Jan '06

05 Jan '06

"Stefan Leichter" <Stefan.Leichter(a)camLine.com> wrote: > ChangeLog > --------------- > add a test for CreateDCW 1. there is no need to import CreateDCW dynamically, it always exists 2. dlls/user/tests/monitor.c,test_enumdisplaydevices() test already does this, so your test is redundant. -- Dmitry.

3 3

Question regarding the Wine Vs WineLib performance
by Ananth M 05 Jan '06

05 Jan '06

Hi All, This question is related to the performance of wine using wine and WineLib I have a win32 program that uses a dll. I am checking the timing to execute a function that is exported by the dll I wanted to execute this program in Linux (using wine and WineLib) and check the performance. When I executed the win32 program in Linux using wine <win32program> The execution time of the function exported by the dll is as same as in direct execution of the program in windows Then I converted the dll into .so and compiled and linked this .so with win32 program using WineLib and Wineg++ The timing that was taken to execute the function exported by the dll ( through .so ) is almost two times, compread with executing using wine. Does any one has any reference for further investigation on this problem or any information Thank you Ajay

4 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel