wine-devel

wine-devel@winehq.org

2 participants
84470 discussions

PATCH: assembler _invoke
by Marcus Meissner 05 Jan '06

05 Jan '06

On Wed, Jan 04, 2006 at 09:14:18PM -0800, Dan Kegel wrote: > This would definitely be better handled in assembly... Here is the first try. It leaves the old version for non-intel and non-gcc compilers. Ciao, Marcus Index: typelib.c =================================================================== RCS file: /home/wine/wine/dlls/oleaut32/typelib.c,v retrieving revision 1.200 diff -u -r1.200 typelib.c --- typelib.c 3 Jan 2006 12:42:34 -0000 1.200 +++ typelib.c 5 Jan 2006 09:07:25 -0000 @@ -4843,7 +4843,33 @@ switch (callconv) { case CC_STDCALL: +#if defined(__i386__) && defined(__GNUC__) + __asm__( + /* store all stuff into registers now, since we modify the stack */ + " mov %1, %%ecx\n" + " mov %2, %%edx\n" + " mov %3, %%esi\n" + " test %%ecx, %%ecx\n" + " jz 1f\n" /* no args, nothing to push */ + /* + * Arguments are pushed from right to left. + * We use intel memory move operations. + */ + " std\n" /* direction: backward */ + "2: lodsl\n" /* moves *esi -> eax, esi-= 4 */ + " pushl %%eax\n" + " dec %%ecx\n" + " jnz 2b\n" + "1: cld\n" /* direction: forward (default) */ + " call *%%edx\n" + " mov %%eax, %0\n" + : "=g" (res) + : "g" (nrargs), "g" (func), "g" (args + (nrargs-1)) + : "memory", "cc", "ax", "si", "cx", "dx" + ); + break; +#else switch (nrargs) { case 0: res = func(); @@ -4905,6 +4931,7 @@ break; } break; +#endif default: FIXME("unsupported calling convention %d\n",callconv); res = -1;

1 0

New, flex-related warnings
by Gerald Pfeifer 05 Jan '06

05 Jan '06

Using flex 2.5.4 and GCC 3.4, I started getting the following new warnings for my Wine builds about two days ago (which I never got before): ./ppl.l:176:1: warning: "YY_NO_UNPUT" redefined ./ppl.l:129:1: warning: this is the location of the previous definition ./parser.l:57:1: warning: "YY_NO_UNPUT" redefined warning: this is the location of the previous definition ./parser.l:58:1: warning: "YY_NO_TOP_STATE" redefined ./parser.l:23:1: warning: this is the location of the previous definition ./parser.l:116:1: warning: "YY_NO_UNPUT" redefined ./parser.l:100:1: warning: this is the location of the previous definition ./parser.l:117:1: warning: "YY_NO_TOP_STATE" redefined ./parser.l:101:1: warning: this is the location of the previous definition ./debug.l:73:1: warning: "YY_NO_UNPUT" redefined ./debug.l:22:1: warning: this is the location of the previous definition ./macro.lex.l:42:1: warning: "YY_NO_UNPUT" redefined ./macro.lex.l:22:1: warning: this is the location of the previous definition I'm afraid, this is caused by the following patchset: date: 2006-01-03 12:43:14 +0000; author: julliard; state: Exp; lines: +4 -2 Alexandre Julliard <julliard(a)winehq.org> Added some flex options to avoid compiler warnings. Moved options from the Makefile into the source. Gerald

1 0

Licensing question
by Dominic Wise 05 Jan '06

05 Jan '06

I have a question regarding the use of portions of Wine in a commercial application. Sorry if this is not the right place to post but I am not sure who I can directly address this to. The application my employer develops is a financial application designed to work on Win 2K and Win XP, but we have a need for a Win32 function that is only supported in XP (TzSpecificLocalTimeToSystemTime). We could write an implementation of this function ourselves for Win 2K but I have noticed that there is a full implementation in Wine. Is it permissible to use the source for this function in our application? If so, what provisions do we need to make with regard to recognition of Wine and supply of source code to our customers ? I am currently trying to demonstrate the benefits of Open Source technology to my employer (I have already replaced one proprietary third-party component in our application with a better Open Source implementation) and this could really help to move this process along. Longer-term, I want to try and get the application running on Wine, but that's another story. Regards, Dominic

5 6

Re: PATCH: winspool.spec adjustments
by Detlef Riekenberg 04 Jan '06

04 Jan '06

Am Mittwoch, den 04.01.2006, 18:40 +0100 schrieb Marcus Meissner: -noname is wrong here: > +202 stub -noname SetDefaultPrinterA@4 > +204 stub -noname SetDefaultPrinterW@4 winspool.drv from w2k export this Functions by name. (The Ordinal-Numbers are correct) -- By By ... ... Detlef

1 0

Re: RpcRT4: Implement NdrClientCall2 and NdrServerCall2
by Roderick Colenbrander 04 Jan '06

04 Jan '06

+ * Copyright 2003-5 Robert Shearman (for CodeWeavers) * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public It is 2006 now ;) Roderick

1 0

Re: CRYPTUI: Add an empty cryptui implementation.
by Juan Lang 04 Jan '06

04 Jan '06

> May not want this empty dll in WineHQ, but it makes SmartFTP > start up I don't see any reason not to include it. It is always available, as far as I know, when crypt32.dll is available. Programs that need a real one probably also need native crypt32.dll for now, so people already have to mess with their dll overrides for apps that might get broken by its presence. --Juan __________________________________________ Yahoo! DSL Something to write home about. Just $16.99/mo. or less. dsl.yahoo.com

1 0

Re: PATCH: winspool ordinal export
by Robert Shearman 04 Jan '06

04 Jan '06

Hi Marcus, Thanks for submitting a patch for this. I also have an application that depends on one of the exports to have a specific ordinal (203 - GetDefaultPrinterW). Marcus Meissner wrote: >-100 stub @ >+100 stub EnumPrinterPropertySheets@16 > > This should be --noname. >+# 101 ClusterSplOpen@20 >+# 102 ClusterSplClose@4 >+# 103 ClusterSplIsAlive@4 >+201 stdcall GetDefaultPrinterA(ptr ptr) >+# 202 _SetDefaultPrinterA@4 >+203 stdcall GetDefaultPrinterW(ptr ptr) >+# 204 _SetDefaultPrinterW@4 >+# 205 _SplReadPrinter@12 >+# 206 _AddPerMachineConnectionA@16 >+# 207 _AddPerMachineConnectionW@16 >+# 208 _DeletePerMachineConnectionA@8 >+# 209 _DeletePerMachineConnectionW@8 >+# 210 _EnumPerMachineConnectionsA@20 >+# 211 _EnumPerMachineConnectionsW@20 >+# 212 _LoadPrinterDriver@4 >+# 213 _RefCntLoadDriver@16 >+# 214 _RefCntUnloadDriver@8 >+# 215 _ForceUnloadDriver@4 >+# 216 _PublishPrinterA@24 >+# 217 _PublishPrinterW@24 >+# 218 _CallCommonPropertySheetUI@16 >+# 219 _PrintUIQueueCreate@16 >+# 220 _PrintUIPrinterPropPages@16 >+# 221 _PrintUIDocumentDefaults@16 >+# 222 _SendRecvBidiData@16 >+# 223 _RouterFreeBidiResponseContainer@4 >+# 224 _ExternalConnectToLd64In32Server@4 >+# 226 _PrintUIWebPnpEntry@4 >+# 227 _PrintUIWebPnpPostEntry@16 >+# 228 _PrintUICreateInstance@8 >+# 229 _PrintUIDocumentPropertiesWrap@28 >+# 230 _PrintUIPrinterSetup@24 >+# 231 _PrintUIServerPropPages@16 >+# 232 _AddDriverCatalog@16 >+ > > We should add this ordinals, not just comment them out. Why? Because they are exported by ordinal only and so if an application (or more likely a Microsoft DLL) tries to use one of them it will end up with the wrong function, rather than just failing to import it and most likely will result in stack corruption. All of these should also be exported with --noname as they are ordinal-only exports. > @ stub ADVANCEDSETUPDIALOG > @ stdcall AbortPrinter(long) > @ stdcall AddFormA(long long ptr) >@@ -89,8 +124,6 @@ > @ stdcall FindFirstPrinterChangeNotification(long long long ptr) > @ stdcall FindNextPrinterChangeNotification(long ptr ptr ptr) > @ stdcall FreePrinterNotifyInfo(ptr) >-@ stdcall GetDefaultPrinterA(ptr ptr) >-@ stdcall GetDefaultPrinterW(ptr ptr) > @ stdcall GetFormA(long str long ptr long ptr) > @ stdcall GetFormW(long wstr long ptr long ptr) > @ stdcall GetJobA(long long long ptr long ptr) > -- Rob Shearman

1 0

winecfg: Problems with audio configuration
by Vitaliy Margolen 04 Jan '06

04 Jan '06

I have noticed significant increase in crashes and lockups in winecfg's audio page. Could we do something about that before the next release? This makes it hard for any first timer to configure wine. Especially knowing that most people will have to change hardware acceleration to "emulation" and they will not be able to do so. -- Best regards, Vitaliy

11 22

re: Licensing question
by Dan Kegel 04 Jan '06

04 Jan '06

dominic.wise(a)ukonline.co.uk wrote: > The application my employer develops is a financial > application designed to work on Win 2K and Win XP, but we > have a need for a Win32 function that is only supported in > XP (TzSpecificLocalTimeToSystemTime). We could write an > implementation of this function ourselves for Win 2K but > I have noticed that there is a full implementation in Wine. > > Is it permissible to use the source for this function in > our application? That function, along with all of Wine, is LGPL'd. Thus to use it in a proprietary app, you just have to put it in its own DLL. > If so, what provisions do we need to make > with regard to recognition of Wine and supply of source > code to our customers ? You need to provide the source code for the LGPL'd DLL you ship. Have a look at the terms of the LGPL for details: http://www.gnu.org/copyleft/lesser.txt Good luck with your project! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

safedisc
by Ivan Leo Puoti 04 Jan '06

04 Jan '06

Raphael Junqueira asked on bugzilla what the safedisc status is. Currently it works fine, and I believe what we have is more or less ready for CVS. However Vitaly told me Alexandre didn't like the object manager Vitaly wrote, mostly he didn't like permanent objects, that drivers depend on. I haven't talked to Alexandre about this but hopefully some reasonable solution can be found so we can get Vitaly's OM into wineserver (I mean my original implementation that uses pointers as handles also works, but things look better with a real OM). So let's try and trigger some community discussion, we are talking about the guts of wine after all. Vitaly, what's the OM status currently? Alexandre, what didn't you like about it? Ivan.

4 3

Re: PATCH: winspool ordinal export
by Dmitry Timoshkov 04 Jan '06

04 Jan '06

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: > SecureCRT from bug 4225 imports GetDefaultPrinterA() by > using the ordinal 201. > > Not sure if this fix is correct or if this is even the > correct approach. But it helps SecureCRT. The other > winspool functions are imported by name. This time I ran 'dumpbin /exports' on winspool.lib provided with PSDK and got interesting result: only some APIs are exported by ordinal, here they are sorted by ordinal, I skipped all APIs without ordinals: 100 _EnumPrinterPropertySheets@16 101 _ClusterSplOpen@20 102 _ClusterSplClose@4 103 _ClusterSplIsAlive@4 201 _GetDefaultPrinterA@8 202 _SetDefaultPrinterA@4 203 _GetDefaultPrinterW@8 204 _SetDefaultPrinterW@4 205 _SplReadPrinter@12 206 _AddPerMachineConnectionA@16 207 _AddPerMachineConnectionW@16 208 _DeletePerMachineConnectionA@8 209 _DeletePerMachineConnectionW@8 210 _EnumPerMachineConnectionsA@20 211 _EnumPerMachineConnectionsW@20 212 _LoadPrinterDriver@4 213 _RefCntLoadDriver@16 214 _RefCntUnloadDriver@8 215 _ForceUnloadDriver@4 216 _PublishPrinterA@24 217 _PublishPrinterW@24 218 _CallCommonPropertySheetUI@16 219 _PrintUIQueueCreate@16 220 _PrintUIPrinterPropPages@16 221 _PrintUIDocumentDefaults@16 222 _SendRecvBidiData@16 223 _RouterFreeBidiResponseContainer@4 224 _ExternalConnectToLd64In32Server@4 226 _PrintUIWebPnpEntry@4 227 _PrintUIWebPnpPostEntry@16 228 _PrintUICreateInstance@8 229 _PrintUIDocumentPropertiesWrap@28 230 _PrintUIPrinterSetup@24 231 _PrintUIServerPropPages@16 232 _AddDriverCatalog@16 -- Dmitry.

1 0

CVS build failure
by Robert Reif 04 Jan '06

04 Jan '06

I am getting the following build error on RH9 with todays CVS: make[2]: Entering directory `/home/wine/wine/tools/widl' gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o client.o client.c gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o hash.o hash.c gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o header.o header.c gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o proxy.o proxy.c gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o server.o server.c gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o typegen.o typegen.c gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o typelib.o typelib.c gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o utils.o utils.c gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o widl.o widl.c gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o write_msft.o write_msft.c bison -d -t ./parser.y -o parser.tab.c ./parser.y contains 12 shift/reduce conflicts. gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o parser.tab.o parser.tab.c flex ./parser.l gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o lex.yy.o lex.yy.c ./parser.l:57:1: warning: "YY_NO_UNPUT" redefined ./parser.l:22:1: warning: this is the location of the previous definition ./parser.l:58:1: warning: "YY_NO_TOP_STATE" redefined ./parser.l:23:1: warning: this is the location of the previous definition gcc -g -O2 -o widl client.o hash.o header.o proxy.o server.o typegen.o typelib.o utils.o widl.o write_msft.o parser.tab.o lex.yy.o -L../../libs -lwpp -lwine_port -lfl widl.o(.text+0x2af): In function `main': /home/wine/wine/tools/widl/widl.c:228: undefined reference to `yy_flex_debug' ../../libs/libwpp.a(preproc.o)(.text+0x8b4): In function `pp_push_if': /home/wine/wine/libs/wpp/preproc.c:505: undefined reference to `pp_flex_debug' ../../libs/libwpp.a(preproc.o)(.text+0x976): In function `pp_pop_if': /home/wine/wine/libs/wpp/preproc.c:542: undefined reference to `pp_flex_debug' ../../libs/libwpp.a(wpp.o)(.text+0x223): In function `wpp_set_debug': /home/wine/wine/libs/wpp/wpp.c:128: undefined reference to `pp_flex_debug' ../../libs/libwpp.a(lex.yy.o)(.text+0x2881): In function `expand_special': /home/wine/wine/libs/wpp/./ppl.l:879: undefined reference to `pp_flex_debug' ../../libs/libwpp.a(lex.yy.o)(.text+0x296e): In function `expand_define': /home/wine/wine/libs/wpp/./ppl.l:898: undefined reference to `pp_flex_debug' ../../libs/libwpp.a(lex.yy.o)(.text+0x2b7b):/home/wine/wine/libs/wpp/./ppl.l:1018: more undefined references to `pp_flex_debug' follow collect2: ld returned 1 exit status make[2]: *** [widl] Error 1 make[2]: Leaving directory `/home/wine/wine/tools/widl' make[1]: *** [widl] Error 2

3 2

Unloading implicitly loaded DLLs
by Michael Ost 04 Jan '06

04 Jan '06

I am looking for some expert advice in how to handle unloading "implicitly loaded DLLs". I have found two issues. (1) The first is a crash that happens in dlls/ntdll/loader.c MODULE_FlushModrefs. wine_unload_dll() is called for such a DLL, but SectionHandle is NULL so the call crashes. My solution was to turn off the LDR_WINE_INTERNAL flag in attach_implicitly_loaded_dlls() but I am not real clear what that flag is or whether that approach is good. An alternative is to add a check for a null SectionHeader before calling wine_unload_dll(). (2) Second is that these DLLs are DLL_PROCESS_DETACHED in process_detach() every time _any_ DLL is unloaded. This happens because the LoadCount is 0. I set it to -1 in attach_implicitly_loaded_dlls() which does the trick. But again I don't know what the heck I am messing with. Is that OK? Attached is a diff of the two changes. I'm not looking for points for style. But just a check on the approach for now. Thanks ... mo

2 1

re: Wine on AIX 5.2 (PowerPC)
by Dan Kegel 04 Jan '06

04 Jan '06

ghart(a)siemens-emis.com wrote: > My goal is to port some Windows apps to AIX, so I decided to take as > much Wine (winelib) as I could to help me. Initially I thought only > a small portion would be suitable, but after a few weeks of work I have > all the dlls/libs compiled (as simple AIX .so's) Cool! > My first question is: has anyone tried this before? I don't know about AIX; somebody from CA asked about it last year. But there are a few folks using Winelib with alternate OS's and CPUs. Perhaps some of them would be able to help you past some of the rough spots. A few links from a quick google search: Robert Lunnon got a Solaris/X86 port working; see http://members.optusnet.com.au/bobl/ http://www.blastwave.org/wine/ http://wiki.jswindle.com/index.php/Installing_Wine#Solaris And various people are using Winelib on Solaris/Sparc; see http://www.winehq.org/?issue=302#Building%20Wine%20on%20Sparcs And then there are the folks building Wine for Darwin. http://darwine.opendarwin.org Good luck, and do keep us posted! I bet you're not the only one who wants this. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: ntdll: Implement few Dbg* functions.
by Eric Pouech 03 Jan '06

03 Jan '06

Vitaliy Margolen wrote: > ChangeLog: > ntdll: Implement few Dbg* functions. > kernel32: Use new Dbg* functions instead of server calls. > + status = DbgUiDebugActiveProcess( hProc ); > + status = DbgUiStopDebugging( hProc ); > - if (self) DbgBreakPoint(); I wonder if we shouldn't use NtDbgActiveProcess, NtRemoveProcessDebug instead. A+ -- Eric Pouech

2 6

Re: MSACM: initialize some ACMSTREAMHEADER fields for the sake of native codecs
by Eric Pouech 03 Jan '06

03 Jan '06

Alex Villacís Lasso wrote: > The ACMAPP sample application from MSDN reveals this annoying bug in > playback: with a native ACM codec (such as the Ogg Vorbis one bundled > with some Japanese RPGs), builtin msacm will successfully tell the codec > to decode the first two frames of compressed audio, and then the sound > will loop on these two frames. What is really happening is that winmm is > using double-buffering, and reusing the ACMSTREAMHEADER structures for > playback, and acmStreamConvert simply passes the structures into the > codec, without clearing cb[Src|Dst]LengthUsed (here is the bug) which > was set in the previous call to acmStreamConvert on that > ACMSTREAMHEADER. The native codec *expects* these fields to be set to 0, > and refuses to decode otherwise. well, you should check who is supposed to clear those flags between msacm or winmm (I suppose wavemap). A+ -- Eric Pouech

2 2

MIDI to MP3 Converter
by Andrew Neil Ramage 03 Jan '06

03 Jan '06

Trying to run this program under Wine, I get the following results. The initial screen appears asking for the name of the MIDI file, but when I try to enter any text I get a crash. A listing of the output follows. andrew@apollo:~/.wine/drive_c/Program Files/MIDI to MP3 Converter> wine mid2mp3.exe fixme:ole:CoRegisterMessageFilter stub fixme:ole:OleLoadPictureEx (0x4213f904,11182,0,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=0,y=0,f=0,0x406bfb00), partially implemented. fixme:mci:mciSendStringW 'new': NIY as device name fixme:mci:MCI_LoadMciDriver Couldn't load driver for type L"CAPTURE". If you don't have a windows installation accessible from Wine, you perhaps forgot to create a [mci] section in system.ini fixme:mci:MCI_LoadMciDriver Couldn't load driver for type L"CAPTURE". If you don't have a windows installation accessible from Wine, you perhaps forgot to create a [mci] section in system.ini fixme:ole:OLEPictureImpl_SaveAsFile (0x403d1dd8)->(0x404022b0, 0, (nil)), hacked stub. X Error of failed request: RenderBadPicture (invalid Picture parameter) Major opcode of failed request: 153 (RENDER) Minor opcode of failed request: 7 (RenderFreePicture) Picture id in failed request: 0x3a00695 Serial number of failed request: 9517 Current serial number in output stream: 10170 andrew@apollo:~/.wine/drive_c/Program Files/MIDI to MP3 Converter> cat ../../system.ini cat: ../../system.ini: No such file or directory andrew@apollo:~/.wine/drive_c/Program Files/MIDI to MP3 Converter> cat ../../windows/system.ini [mci] MPEGVideo=mciqtz.drv MPEGVideo2=mciqtz.drv avivideo=mciavi.drv cdaudio=mcicda.drv sequencer=mciseq.drv vcr=mcivisca.drv ; videodisc=mcipionr.drv waveaudio=mciwave.drv [drivers32] MSACM.imaadpcm=imaadp32.acm MSACM.msadpcm=msadp32.acm MSACM.msg711=msg711.acm MSACM.winemp3=winemp3.acm VIDC.MRLE=msrle32.dll VIDC.MSVC=msvidc32.dll VIDC.CVID=iccvid.dll ; VIDC.IV50=ir50_32.dll ; VIDC.IV31=ir32_32.dll ; VIDC.IV32=ir32_32.dll andrew@apollo:~/.wine/drive_c/Program Files/MIDI to MP3 Converter> wine mid2mp3.exe fixme:ole:CoRegisterMessageFilter stub fixme:ole:OleLoadPictureEx (0x4213f904,11182,0,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=0,y=0,f=0,0x406bfb00), partially implemented. fixme:mci:mciSendStringW 'new': NIY as device name fixme:mci:MCI_LoadMciDriver Couldn't load driver for type L"CAPTURE". If you don't have a windows installation accessible from Wine, you perhaps forgot to create a [mci] section in system.ini fixme:mci:MCI_LoadMciDriver Couldn't load driver for type L"CAPTURE". If you don't have a windows installation accessible from Wine, you perhaps forgot to create a [mci] section in system.ini fixme:ole:OLEPictureImpl_SaveAsFile (0x403d1dd8)->(0x404022b0, 0, (nil)), hacked stub. X Error of failed request: RenderBadPicture (invalid Picture parameter) Major opcode of failed request: 153 (RENDER) Minor opcode of failed request: 7 (RenderFreePicture) Picture id in failed request: 0x3a00645 Serial number of failed request: 9157 Current serial number in output stream: 9834 andrew@apollo:~/.wine/drive_c/Program Files/MIDI to MP3 Converter> : -- Andrew "Someone set a bad example makes surrender seem alright; The act of a noble warrior who's lost the will to fight And now you're trembling on a rocky ledge Staring out into a heartless sea Facing life on a razor's edge Nothing's what you thought it would be." ----------- Rush, The Pass (Presto, 1989)

3 2

Re: Fix some type definitions for the WORDS_BIGENDIAN case
by Alexandre Julliard 03 Jan '06

03 Jan '06

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > diff -up cvs/hq/wine/include/winnt.h wine/include/winnt.h > --- cvs/hq/wine/include/winnt.h 2005-11-30 23:19:48.000000000 +0800 > +++ wine/include/winnt.h 2006-01-02 15:08:41.000000000 +0800 > @@ -1743,12 +1743,21 @@ typedef struct _IMAGE_DOS_HEADER { > } IMAGE_DOS_HEADER, *PIMAGE_DOS_HEADER; > #include <poppack.h> > > +#ifdef WORDS_BIGENDIAN > +#define IMAGE_DOS_SIGNATURE 0x4D5A /* MZ */ > +#define IMAGE_OS2_SIGNATURE 0x4E45 /* NE */ > +#define IMAGE_OS2_SIGNATURE_LE 0x4C45 /* LE */ > +#define IMAGE_OS2_SIGNATURE_LX 0x4C58 /* LX */ > +#define IMAGE_VXD_SIGNATURE 0x4C45 /* LE */ > +#define IMAGE_NT_SIGNATURE 0x50450000 /* PE00 */ > +#else > #define IMAGE_DOS_SIGNATURE 0x5A4D /* MZ */ > #define IMAGE_OS2_SIGNATURE 0x454E /* NE */ > #define IMAGE_OS2_SIGNATURE_LE 0x454C /* LE */ > #define IMAGE_OS2_SIGNATURE_LX 0x584C /* LX */ > #define IMAGE_VXD_SIGNATURE 0x454C /* LE */ > #define IMAGE_NT_SIGNATURE 0x00004550 /* PE00 */ > +#endif I'm not sure what you are trying to achieve here. If you want to load little-endian files on big-endian machines, you need to swap everything; swapping only the signature is not going to do any good. -- Alexandre Julliard julliard(a)winehq.org

2 4

run jboss with a mde file as source
by Curro Amores 03 Jan '06

03 Jan '06

hi: i want to run jboss in linux and connect to an Ms Access odbc source. I think it doesnt exist odbc driver for Access in Linux. I Have read something about ODBC-ODBC but i think it is for accessing a mde file in a windows machine from linux. I have created the bridge with ODBC in wine (using the control pane with winetools) Then i have tried to run jboss windows version (run.bat) with wcmd but i got a message that run.jar file cant not be found. Do i have to install java windows version with wine? I have tried as well but the installation crashes Any idea? thanks

2 1

Re: opengl: Add support for rendering on bitmaps
by Tomas Carnecky 03 Jan '06

03 Jan '06

Huw D M Davies wrote: > Huw Davies <huw(a)codeweavers.com> > Add support for rendering on bitmaps This patch breaks World of Warcraft, reverting this patch makes WoW work again. This is the error: X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 142 (GLX) Minor opcode of failed request: 13 (X_GLXCreateGLXPixmap) Serial number of failed request: 410 Current serial number in output stream: 411 tom

3 4

Re: [comctl32] Reduce memory usage of the syslink control (Take 4)
by Alexandre Julliard 03 Jan '06

03 Jan '06

Thomas Weidenmueller <wine-patches(a)reactsoft.com> writes: > @@ -1062,35 +1063,41 @@ > > if(Item->mask & LIF_ITEMID) > { > - if(!di->u.Link.szID) > + if(di->u.Link.szID) > { > - di->u.Link.szID = Alloc((MAX_LINKID_TEXT + 1) * sizeof(WCHAR)); > - if(!Item->szID) > - { > - ERR("Unable to allocate memory for link id\n"); > - Ret = FALSE; > - } > + Free(di->u.Link.szID); > } > + > + nc = min(lstrlenW(Item->szID), MAX_LINKID_TEXT - 1); > + di->u.Link.szID = Alloc((nc + 1) * sizeof(WCHAR)); > if(di->u.Link.szID) > { > - lstrcpynW(di->u.Link.szID, Item->szID, MAX_LINKID_TEXT + 1); > + lstrcpynW(di->u.Link.szID, Item->szID, nc + 1); > + } > + else > + { > + ERR("Unable to allocate memory for link id\n"); > + Ret = FALSE; > } > } You should probably make sure that the new text has been allocated properly before freeing the old one, so that allocation errors don't cause the current contents to be lost. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: RESEND: [comctl32] Reduce memory usage of the syslink control
by Alexandre Julliard 03 Jan '06

03 Jan '06

Thomas Weidenmueller <wine-patches(a)reactsoft.com> writes: > Reduce memory usage of the syslink control. > > Please let me know if there's something wrong with this patch. There are many unrelated changes in there. Please send separate changes as separate patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

Some patch statistics
by Hans Leidekker 03 Jan '06

03 Jan '06

I was curious how we did last year so I dug up some numbers with the help of git. I counted patches applied to the tree starting from 1999: year # patches 1999 2656 2000 2722 2001 1885 2002 3094 2003 3283 2004 3851 2005 6037 Total: 23528 This is almost too good to be true isn't it? I worried for a while that these figures might be influenced by the switch from cvs to git, e.g. that cvs history somehow shows up compressed in git. On second look though it really seems that the past year has seen an impressive increase in productivity, compared to the previous years. -Hans

2 1

RFC/PATCH: avoid metafilevirus problems
by Marcus Meissner 03 Jan '06

03 Jan '06

Hi, requesting comments... This patch reduces the attack vector on metafiles. I originally wanted to filter only SETABORTPROC, but there are a lot of things that might be used to inject code. Comments? Ciao, Marcus Changelog: Only allow whitelisted escape codes when playing metafiles. Index: dlls/gdi/metafile.c =================================================================== RCS file: /home/wine/wine/dlls/gdi/metafile.c,v retrieving revision 1.10 diff -u -r1.10 metafile.c --- dlls/gdi/metafile.c 5 Nov 2005 10:45:02 -0000 1.10 +++ dlls/gdi/metafile.c 2 Jan 2006 20:52:42 -0000 @@ -1121,10 +1121,57 @@ GDIRealizePalette(hdc); break; - case META_ESCAPE: + case META_ESCAPE: { + BOOL passdown = FALSE; + + switch (mr->rdParm[0]) { + case SETABORTPROC: + FIXME("NOTE: Suppressing SETABORTPROC in metafile, possible exploit.\n"); + break; + case STARTDOC: + case ABORTDOC: + case ENDDOC: + case NEWFRAME: + case NEXTBAND: + case SETCOPYCOUNT: + case SETCOLORTABLE: + case FLUSHOUTPUT: + case DRAFTMODE: + case SELECTPAPERSOURCE: + case SETLINECAP: + case SETLINEJOIN: + case SETMITERLIMIT: + case DRAWPATTERNRECT: + case ENABLEDUPLEX: + case EPSPRINTING: + case SETDIBSCALING: + case EXTTEXTOUT: + case ENABLEPAIRKERNING: + case SETCHARSET: + case SETKERNTRACK: + case SETALLJUSTVALUES: + case STRETCHBLT: + case BEGIN_PATH: + case CLIP_TO_PATH: + case END_PATH: + case SET_ARC_DIRECTION: + case SET_BACKGROUND_COLOR: + case SET_POLY_MODE: + case SET_SCREEN_ANGLE: + case SET_SPREAD: + case TRANSFORM_CTM: + case SET_CLIP_BOX: + case SET_BOUNDS: + case SET_MIRROR_MODE: + passdown = TRUE; + break; + default: + FIXME("Ignoring strange Escape code %d in Metafile.\n"); + break; + } Escape(hdc, mr->rdParm[0], mr->rdParm[1], (LPCSTR)&mr->rdParm[2], NULL); break; - + } case META_EXTTEXTOUT: MF_Play_MetaExtTextOut( hdc, mr ); break;

3 2

Re: OLEAUT32: Revert back to an older more informative error message.
by Marcus Meissner 03 Jan '06

03 Jan '06

On Tue, Jan 03, 2006 at 07:00:15PM +0900, Mike McCormack wrote: > > Many installers cause Wine's oleaut32 to output alot of FIXME messages > like this: > > fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion > from 0x4003 -> 0xb) 0000ffff > > This message is somewhat frustrating, as although it warns of a > potential problem, it provides no insight into the solution. > > I found the patch that introduced the problem (using git): > > git-whatchanged -p -C -S'Should not use VariantChangeType' > commit hash -> 49eaa0db2b3f7443ead40ef4a5d5b3d650c11384 > > It removed an (IMO) slightly more useful message: > > "argument was coerced in-place (0x%x -> 0x%x); source data has been > modified!!!\n" > > Can anybody help suggest the real way to fix the problem? Is it that we > have to make a copy of the args array before modifying it? Maybe we can > put a comment in the code about how to fix it, some somebody looking at > it in the future will know how to solve it right? I was not fully sure what problems might arise out of just copying the variant as I wrote this code. Its a pretty messy approach. It should work fine when the variant is self contained at least. I think Rob wants to get rid of this function anyway. Ciao, Marcus

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel