wine-devel

wine-devel@winehq.org

2 participants
84470 discussions

Re: OLE32: Allow _invoke to handle up to 17 parameters.
by Robert Shearman 03 Jan '06

03 Jan '06

Mike McCormack wrote: > > This looks like it might be better handled in assembly... I agree. We can let these patches go in until it is written in assembly though. -- Rob Shearman

1 0

Re: OLEAUT32: Revert back to an older more informative error message.
by Robert Shearman 03 Jan '06

03 Jan '06

Mike McCormack wrote: > Many installers cause Wine's oleaut32 to output alot of FIXME messages > like this: > > fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion > from 0x4003 -> 0xb) 0000ffff > ... > Can anybody help suggest the real way to fix the problem? Is it that > we have to make a copy of the args array before modifying it? Maybe > we can put a comment in the code about how to fix it, some somebody > looking at it in the future will know how to solve it right? Yes. I have a patch that fixes this and several other problems with the function and I've been sending patches in the last week preparing for this. -- Rob Shearman

1 0

issues compiling ReactOS newdev on wine
by Damjan Jovanovic 03 Jan '06

03 Jan '06

I tried to get the ReactOS NEWDEV.DLL to compile on wine, and there were many problems. Firstly, why can't winelibs include <windows.h> and <tchar.h>? Are TCHARs even usable in winelibs? Secondly, what the whole story with WCHARs? Why do L"Unicode string" type strings work in wine apps but not in winelibs? And NEWDEV.DLL needs GWL_USERDATA, DWL_MSGRESULT and PSH_WIZARD97, all of which are within "#ifndef __WINESRC__" sections. Does wine assume DLLs never do user-interface stuff? __________________________________________ Yahoo! DSL Something to write home about. Just $16.99/mo. or less. dsl.yahoo.com

3 2

help with bug
by Curro Amores 03 Jan '06

03 Jan '06

hi everbody, i have posted my bug in bugzilla. I know that the process is a bit slow but i would like somebody help me. There you have the links for downloading the standalone application and the process to get the bug. If you have any doubt you can email me. Thanks all Happy new Year! BUG IS 4126

1 0

Success running VistaTask!
by Dan Kegel 03 Jan '06

03 Jan '06

The fourth "automate other windows apps" app I tried, VistaTask, passed the "can control notepad" test with flying colors! A free trial is available at http://www.vista-software.com/ I don't know how close that tool is to being useful for software testing -- it's not specifically aimed at it -- but it's nice to see at least one such app actually working on Wine. Again, kudos to the Wine developers for getting Wine to this point! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 1

Error running app delphi based.
by Fernando - SuporteInfo 02 Jan '06

02 Jan '06

Hi, I'm trying run an application developed in delphi and receive the follow errors: err:shell:HCR_GetFolderAttributes HCR_GetFolderAttributes should be called for simple PIDL's only! err:syslevel:_CheckNotSysLevel Holding lock 0x7fa4dba0 level 2 wine: Unhandled exception 0x80000003 at address 0x0000:0x7fc5fd60 (thread 0009), starting debugger... WineDbg starting on pid 0x8 In 32 bit mode. 0x00000000: addb %al,0x0(%eax) Modules: Module Address Debug info Name (87 modules) PE 0x00400000-00f3e000 Deferred at PE 0x10000000-10018000 Deferred hhctrlui PE 0x1f430000-1f4a7000 Deferred msado15 PE 0x1f660000-1f67f000 Deferred msdart PE 0x5d300000-5d37f000 Deferred hhctrl PE 0x5f300000-5f329000 Deferred olepro32 PE 0x65340000-653d2000 Deferred oleaut32 PE 0x65f00000-65fc2000 Deferred ole32 PE 0x70100000-70153000 Deferred rpcrt4 PE 0x70bd0000-70c35000 Deferred shlwapi PE 0x78000000-78044000 Deferred msvcrt ELF 0x7bf00000-7bf03000 Deferred <wine-loader> ELF 0x7ddcc000-7dde0000 Deferred msimg32<elf> \-PE 0x7ddd0000-7dde0000 \ msimg32 ELF 0x7e47b000-7e490000 Deferred midimap<elf> \-PE 0x7e480000-7e490000 \ midimap ELF 0x7e5b0000-7e5d2000 Deferred msacm32<elf> \-PE 0x7e5c0000-7e5d2000 \ msacm32 ELF 0x7e5d2000-7e5e9000 Deferred msacm<elf> \-PE 0x7e5e0000-7e5e9000 \ msacm ELF 0x7e5e9000-7e630000 Deferred wineoss<elf> \-PE 0x7e600000-7e630000 \ wineoss ELF 0x7ec4f000-7ec80000 Deferred uxtheme<elf> \-PE 0x7ec60000-7ec80000 \ uxtheme ELF 0x7f1ef000-7f1f7000 Deferred libxrender.so.1 ELF 0x7f20a000-7f226000 Deferred imm32<elf> \-PE 0x7f210000-7f226000 \ imm32 ELF 0x7f226000-7f243000 Deferred ximcp.so.2 ELF 0x7f243000-7f246000 Deferred xlcdef.so.2 ELF 0x7f246000-7f2aa000 Deferred libgl.so.1 ELF 0x7f2bd000-7f388000 Deferred libx11.so.6 ELF 0x7f388000-7f39f000 Deferred libice.so.6 ELF 0x7f39f000-7f423000 Deferred winex11<elf> \-PE 0x7f3b0000-7f423000 \ winex11 ELF 0x7f423000-7f443000 Deferred libexpat.so.1 ELF 0x7f443000-7f472000 Deferred libfontconfig.so.1 ELF 0x7f477000-7f485000 Deferred libxext.so.6 ELF 0x7f485000-7f499000 Deferred libz.so.1 ELF 0x7f499000-7f506000 Deferred libfreetype.so.6 ELF 0x7f519000-7f537000 Deferred iphlpapi<elf> \-PE 0x7f520000-7f537000 \ iphlpapi ELF 0x7f537000-7f561000 Deferred ws2_32<elf> \-PE 0x7f540000-7f561000 \ ws2_32 ELF 0x7f561000-7f57b000 Deferred wsock32<elf> \-PE 0x7f570000-7f57b000 \ wsock32 ELF 0x7f57b000-7f5fc000 Deferred winmm<elf> \-PE 0x7f590000-7f5fc000 \ winmm ELF 0x7f5fc000-7f696000 Deferred comdlg32<elf> \-PE 0x7f610000-7f696000 \ comdlg32 ELF 0x7f696000-7f763000 Deferred shell32<elf> \-PE 0x7f6b0000-7f763000 \ shell32 ELF 0x7f763000-7f78e000 Deferred winspool<elf> \-PE 0x7f770000-7f78e000 \ winspool ELF 0x7f78e000-7f843000 Deferred comctl32<elf> \-PE 0x7f7a0000-7f843000 \ comctl32 ELF 0x7f843000-7f857000 Deferred lz32<elf> \-PE 0x7f850000-7f857000 \ lz32 ELF 0x7f857000-7f870000 Deferred version<elf> \-PE 0x7f860000-7f870000 \ version ELF 0x7f870000-7f88d000 Deferred mpr<elf> \-PE 0x7f880000-7f88d000 \ mpr ELF 0x7f88d000-7f8cb000 Deferred advapi32<elf> \-PE 0x7f8a0000-7f8cb000 \ advapi32 ELF 0x7f8cb000-7f958000 Deferred gdi32<elf> \-PE 0x7f8e0000-7f958000 \ gdi32 ELF 0x7f958000-7fa80000 Deferred user32<elf> \-PE 0x7f970000-7fa80000 \ user32 ELF 0x7fbd8000-7fce0000 Deferred kernel32<elf> \-PE 0x7fbf0000-7fce0000 \ kernel32 ELF 0x7fdf2000-7fdfb000 Deferred libxcursor.so.1 ELF 0x7fdfb000-7fe00000 Deferred libxxf86vm.so.1 ELF 0x7fe00000-7fe0c000 Deferred libnss_files.so.2 ELF 0x7fe0c000-7fe16000 Deferred libnss_nis.so.2 ELF 0x7fe16000-7fe2c000 Deferred libnsl.so.1 ELF 0x7fe2c000-7fe35000 Deferred libnss_compat.so.2 ELF 0x7fe37000-7fe40000 Deferred libsm.so.6 ELF 0x7fe42000-7fe48000 Deferred libxxf86dga.so.1 ELF 0x7fe4b000-7fe70000 Deferred libm.so.6 ELF 0x7fe70000-7ff67000 Deferred libwine_unicode.so.1 ELF 0x7ff67000-7ffe0000 Deferred ntdll<elf> \-PE 0x7ff80000-7ffe0000 \ ntdll ELF 0xb7db3000-b7db7000 Deferred libdl.so.2 ELF 0xb7db7000-b7eee000 Deferred libc.so.6 ELF 0xb7eee000-b7f00000 Deferred libpthread.so.0 ELF 0xb7f00000-b7f1a000 Deferred libwine.so.1 ELF 0xb7f1a000-b7f1d000 Deferred iso8859-1.so ELF 0xb7f2e000-b7f45000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 00000008 (D) C:\callisto\at.exe 0000000a 0 00000009 0 <== WineDbg terminated on pid 0x8 Excuse my english. []'s Fernando.

1 0

What is the proper value for ACM_DRIVERADDF_NAME?
by Alex Villacís Lasso 02 Jan '06

02 Jan '06

I am working on a set of patches for msacm, and I want to add support for ACM_DRIVERADDF_NAME. The problem is that Wine does not have a definition for this value, which is supposed to be used in acmDriverAdd[AW]. It does not appear in any header of MSVC either. I searched MSDN and Google, and it does not appear either. MSDN mentions its use, but does not mention its specific value. Has anybody seen the value for this definition, and if so, can you please forward it to me? Thanks in advance. BTW, what happened to the two MSACM patches sent in December 28? Alex Villacís Lasso

2 2

Re: There is no point to specify both MEM_RESERVE and MEM_COMMIT for VirtualAlloc
by Vitaliy Margolen 02 Jan '06

02 Jan '06

Monday, January 2, 2006, 1:23:22 AM, Dmitry Timoshkov wrote: > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > There is no point to specify both MEM_RESERVE and MEM_COMMIT for > VirtualAlloc. According to MSDN: "To reserve and commit pages in one step, call VirtualAlloc with MEM_COMMIT | MEM_RESERVED. The function fails if you attempt to commit a page that has not been reserved. The resulting error code is ERROR_INVALID_ADDRESS." Why do you want to do something that _should_ fail? Vitaliy Margolen

2 1

Self-extracting zips do not extract themselves
by Ivan Gyurdiev 02 Jan '06

02 Jan '06

> err:virtual:map_image Image was mapped at 0x49910000: standard load address for a Win32 program (0x00400000) not available > err:virtual:map_image Do you have exec-shield or prelink active? > wine: could not load L"H:\\nfsmw\\nfsmwdemo.exe" as Win32 binary Yes I do, is that bad? Should I file a bugzilla (or do something else to help resolve this issue)?

1 0

D3DX9 SDK releases, DLL support (CIV4)
by Andrei Barbu 02 Jan '06

02 Jan '06

Hi, I've been playing with getting CIV4 to run on wine. http://appdb.winehq.org/appview.php?versionId=3632&iTestingId=125 I'm left with just one issue. D3DX9_26.DLL is missing. This is a D3D9 SDK release (they put one out every month or so from what I've seen, with a new DLL that has the number incremented). It's mostly like the original with some minor changes. How would I support this in wine? I don't know the wine build system enough to extend it to do this. Is there a nice way to generate these DLLs and to include the d3dx9 dll so I just have to add in/fix missing calls? This may not be an issue now, but as more and more games get released more will depend on these dlls. Thanks, Andrei

5 5

Running GUI test automation tools with Wine?
by Dan Kegel 02 Jan '06

02 Jan '06

Do any Windows GUI test automation tools run under Wine yet? I've tried two from the list at http://tejasconsulting.com/open-testware/feature/gui-test-driver-survey.html so far, but they both had issues: http://bugs.winehq.org/show_bug.cgi?id=4209 (tester 3 can't record) http://bugs.winehq.org/show_bug.cgi?id=4211 (autoit3 can't play back) It's kind of demanding to expect this kind of application to work properly, since it really gets under the hood of Windows, but Wine has progressed to the point where maybe it's not unrealistic. And I can think of no better way to help ISVs get their apps running on Wine than to get their regression test runner working on Wine! <insert obligatory monkeyboy reference here> - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 1

Question about X11DRV_ChoosePixelFormat glXChooseFBConfig returns NULL (glError: 0)
by L. Lenders 02 Jan '06

02 Jan '06

Just for the info: after some digging i found a quick hack to get rid of the error: comment line 208 in dlls/x11drv/opengl.c: //TEST_AND_ADD1(ppfd->dwFlags & PFD_STEREO, GLX_STEREO); Somehow setting the PFD_STEREO flag makes doom3 crash and triggers the error mentioned in the subject. After commenting line 208 doom3 starts up just fine. Digging further..... :) (any help appreciated) Louis ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com

5 6

Registry entries for serial ports not created
by Pavel Troller 02 Jan '06

02 Jan '06

Hi! I was trying to utilize a program for updating mobile phone's firmware (for Siemens/Benq mobiles, just an original app with encapsulated firmware image). This program immediately told that there are no serial ports present in my machine and terminated. After a bit of seeking in my own memory and wine list mail archive I remembered that there should be some registry entries which a program can examine and get some basic info about the ports. In an old mail I found something, which I converted to the following registry entry and put to system.reg file: [Hardware\\Devicemap\\Serialcomm] 1015709345 "Serial0"="COM1" "Serial1"="COM2" "Serial2"="COM3" "Serial3"="COM4" I think this should go to the standard system.reg by default, maybe in the reduced form with just the first two ports. Together with correct links in .wine/dosdevices, it makes that the program can really find the port. And at the end: How to create such a registry entry by wine's regedit ? I've spent about 15 minutes trying to do so but I've failed and then edited the file manually. Any attempt to create a "folder" called Serialcomm in Hardware\\Devicemap was unsuccessfull; I didn't find how to create a "folder" for keys, and using "Add key" menu entry I always got an error dialog saying "A subkey must be volatile". What does it mean ? With regards, Pavel Troller

2 2

MSVC compilation of DLLs
by Rolf Kalbermatter 01 Jan '06

01 Jan '06

I was just looking to get some of the Wine DLLs compiled under Visual C and run into a number of problems. First msvcmaker seems to only create a wine.dsp file in the loader directory but rather should do that in the libs/wine directory instead it would seem to me. Second it also should create a wine_unicode.dsp project in libs/unicode which it doesn't do at all. I created my own wine.dsp file to create a wine.lib file but run into new problems. First the DECLSPEC_NORETURN position in following declaration does not work with Visual C. It does want the DECLSPEC_NORETURN before the entire function declaration and not before the function pointer name. This: struct wine_pthread_functions { void (*init_process)( const struct wine_pthread_callbacks *callbacks, size_t size ); void (*init_thread)( struct wine_pthread_thread_info *info ); int (*create_thread)( struct wine_pthread_thread_info *info ); void (*init_current_teb)( struct wine_pthread_thread_info *info ); void * (*get_current_teb)(void); void (* DECLSPEC_NORETURN exit_thread)( struct wine_pthread_thread_info *info ); void (* DECLSPEC_NORETURN abort_thread)( long status ); }; should get: struct wine_pthread_functions { void (*init_process)( const struct wine_pthread_callbacks *callbacks, size_t size ); void (*init_thread)( struct wine_pthread_thread_info *info ); int (*create_thread)( struct wine_pthread_thread_info *info ); void (*init_current_teb)( struct wine_pthread_thread_info *info ); void * (*get_current_teb)(void); DECLSPEC_NORETURN void (* exit_thread)( struct wine_pthread_thread_info *info ); DECLSPEC_NORETURN void (* abort_thread)( long status ); }; to compile, but probably won't work for the GNU_C declaration of this macro, or does it? The next problem are the use of BINDIR and DLLDIR in config.c and loader.c respectively. What are those and do they have any function under a Windows compile of these files? Should those parts of the files simply be excluded for such a compile, or are they not necessary at all? Rolf Kalbermatter

1 0

Compiling test application (Notepad) with winelib - executeable segfaults
by Richard Wild 01 Jan '06

01 Jan '06

Hi all, I was trying to compile the test application (Notepad) with winelib to get a feel for how to use it. I followed the instructions in your docs, but ended up with a target file notepad2.exe.so. The instructions imply that I should end up with an executable called notepad2, since they tell me to run it. If I run the .so file it segfaults, so I assume it really is a shared library and not just an executable with a funny name. I want to understand what I've done wrong here, because if I can't get this right I certainly won't be able to port anything complicated. I'm sorry if this has been asked often before, but I couldn't find an easy way of searching the mailing list. I am using WINE-0.9.4 built by Adam Schreiber for Slackware 10.2. Regards, Rich. P.S. Here is my output (so you can see exactly what I did): rich@radhagovinda:/usr/local/src/wine-0.9.4/programs/notepad2$ winemaker --lower-uppercase . Winemaker 0.6.0 Copyright 2000 Francois Gouget <fgouget(a)codeweavers.com> for CodeWeavers Scanning the source directories... Fixing the source files... License_En.c dialog.c license.c main.c Bg.rc Cs.rc Da.rc De.rc En.rc Es.rc Fi.rc Fr.rc Hu.rc It.rc Ja.rc Ko.rc Nl.rc No.rc Pl.rc Pt.rc Ru.rc Si.rc Sk.rc Sw.rc Th.rc Wa.rc Zh.rc rsrc.rc dialog.h license.h main.h notepad_res.h Generating project files... . rich@radhagovinda:/usr/local/src/wine-0.9.4/programs/notepad2$ make winegcc -c -mno-cygwin -I. -o License_En.o License_En.c winegcc -c -mno-cygwin -I. -o dialog.o dialog.c winegcc -c -mno-cygwin -I. -o license.o license.c winegcc -c -mno-cygwin -I. -o main.o main.c wrc -I. -foBg.res Bg.rc Bg.rc:21:24: Error: parse error make: *** [Bg.res] Error 1 rich@radhagovinda:/usr/local/src/wine-0.9.4/programs/notepad2$ vi Makefile reading Makefile wrote Makefile, 110 lines, 2368 chars rich@radhagovinda:/usr/local/src/wine-0.9.4/programs/notepad2$ make wrc -I. -forsrc.res rsrc.rc winegcc -mwindows -mno-cygwin -o notepad2.exe.so License_En.o dialog.o license.o main.o rsrc.res -lodbc32 -lole32 -loleaut32 -lwinspool -luuid rich@radhagovinda:/usr/local/src/wine-0.9.4/programs/notepad2$ ll total 520 -rw-r--r-- 1 rich users 5303 2006-01-01 21:02 Bg.rc -rw-r--r-- 1 rich users 5257 2006-01-01 21:02 Cs.rc -rw-r--r-- 1 rich users 5228 2006-01-01 21:02 Da.rc -rw-r--r-- 1 rich users 5495 2006-01-01 21:02 De.rc -rw-r--r-- 1 rich users 5282 2006-01-01 21:02 En.rc -rw-r--r-- 1 rich users 5625 2006-01-01 21:02 Es.rc -rw-r--r-- 1 rich users 4693 2006-01-01 21:02 Fi.rc -rw-r--r-- 1 rich users 5369 2006-01-01 21:02 Fr.rc -rw-r--r-- 1 rich users 5388 2006-01-01 21:02 Hu.rc -rw-r--r-- 1 rich users 5513 2006-01-01 21:02 It.rc -rw-r--r-- 1 rich users 5431 2006-01-01 21:02 Ja.rc -rw-r--r-- 1 rich users 5396 2006-01-01 21:02 Ko.rc -rw-r--r-- 1 rich users 1331 2006-01-01 21:02 License_En.c -rw-r--r-- 1 rich users 2040 2006-01-01 21:02 License_En.o -rw-r--r-- 1 rich users 2368 2006-01-01 21:03 Makefile -rw-r--r-- 1 rich users 5268 2006-01-01 21:02 Nl.rc -rw-r--r-- 1 rich users 5170 2006-01-01 21:02 No.rc -rw-r--r-- 1 rich users 5398 2006-01-01 21:02 Pl.rc -rw-r--r-- 1 rich users 7642 2006-01-01 21:02 Pt.rc -rw-r--r-- 1 rich users 5288 2006-01-01 21:02 Ru.rc -rw-r--r-- 1 rich users 5230 2006-01-01 21:02 Si.rc -rw-r--r-- 1 rich users 4676 2006-01-01 21:02 Sk.rc -rw-r--r-- 1 rich users 5251 2006-01-01 21:02 Sw.rc -rw-r--r-- 1 rich users 4517 2006-01-01 21:02 Th.rc -rw-r--r-- 1 rich users 5256 2006-01-01 21:02 Wa.rc -rw-r--r-- 1 rich users 5179 2006-01-01 21:02 Zh.rc -rw-r--r-- 1 rich users 22737 2006-01-01 21:02 dialog.c -rw-r--r-- 1 rich users 1754 2006-01-01 21:02 dialog.h -rw-r--r-- 1 rich users 14472 2006-01-01 21:02 dialog.o -rw-r--r-- 1 rich users 1321 2006-01-01 21:02 license.c -rw-r--r-- 1 rich users 1528 2006-01-01 21:02 license.h -rw-r--r-- 1 rich users 984 2006-01-01 21:02 license.o -rw-r--r-- 1 rich users 12222 2006-01-01 21:02 main.c -rw-r--r-- 1 rich users 1722 2006-01-01 21:02 main.h -rw-r--r-- 1 rich users 9388 2006-01-01 21:02 main.o -rwxr-xr-x 1 rich users 165396 2006-01-01 21:03 notepad2.exe.so -rw-r--r-- 1 rich users 2629 2006-01-01 21:02 notepad_res.h -rw-r--r-- 1 rich users 1813 2006-01-01 21:02 rsrc.rc -rw-r--r-- 1 rich users 65612 2006-01-01 21:03 rsrc.res rich@radhagovinda:/usr/local/src/wine-0.9.4/programs/notepad2$ ./notepad2.exe.so Segmentation fault

2 2

SPARC assembly won't compile, problems with NT headers
by Troy Rollo 01 Jan '06

01 Jan '06

winegcc from the current WineHQ produces assembly output for SPARC systems that cannot be processed by the assembler. 1. "operation combines symbols in different segments" error. This problem arises because the imports code attempts to generate a relocation involving symbols in different segments (one in the text segment and one in the data segment). SPARC assemblers (including gas on a SPARC) cannot deal with relocations involving symbols in different segments. This only affects position independent code and can be avoided by changing the assembly code output in imports.c to something simpler. 2. "can't resolve `_end' {*UND* section} - `.L__wine_spec_rva_base' {.data section}" This problem is more sinister. It arises from the same limitation as the first problem, but is not susceptible to being worked around. The offending code is the code that attempts to generate the NT header of the executable - specifically the SizeOfImage element. I can't see any way at this point to provide for this calculation to be done until after the linker output is generated. I suspect the solution to this problem is to just output a zero in this location and have winegcc modify the executable image to insert the correct values after the linker has created it. Does anybody have any objections to this solution or another approach to suggest? -- Troy Rollo - wine(a)troy.rollo.name

7 13

Re: winecfg: Added "Use PRIMARY selection" option
by Stefan Dösinger 01 Jan '06

01 Jan '06

> ChangeLog: > > Added support for "Use PRIMARY selection" clipboard option. One question: Why not make this the default? This would be the unix way to use the clipboard. Or use the primary selection on a middle mouse button click, and the other clipboard value on paste / CTRL-V? This is the behavior I'm used to from native apps. Is this possible?

2 2

Re: On creating 16bit windows convert null instances to current process
by Dmitry Timoshkov 01 Jan '06

01 Jan '06

"Joseph Garvin" <k04jg02(a)kzoo.edu> wrote: > + /* Correct if instance is null now, because later we won't > + be able to tell the difference between a 16-bit NULL and > + a 32-bit NULL */ > + > + if (!instance) > + { > + HTASK16 hTask = GetCurrentTask(); > + TDB *tdb = GlobalLock16(x); > + instance = tdb->hInstance; > + GlobalUnlock(tdb); > + } Did you ever test it? GlobalLock16 on x coordinate won't return you anything useful, not mentioning a TDB pointer. Probably you meant GlobalLock(hTask)? And GlobalUnlock(tdb) is not right at all, you want GlobalUnlock16(hTask). -- Dmitry.

3 4

re: ole db conformance tests
by Dan Kegel 01 Jan '06

01 Jan '06

About three years ago, I wrote in http://www.winehq.org/hypermail/wine-devel/2003/01/0208.html : > Say, how close are these kinds of things to being able to run under wine? > http://msdn.microsoft.com/library/en-us/oledb/htm/testtoolsov.asp The MDAC SDK, downloadable from http://msdn.microsoft.com/data/mdac/downloads/ , contains conformance tests for ole db data sources. Seems like we ought to try running them. I just verified that LTM, the test runner app, from MDAC 2.6 SDK, runs under Wine. I haven't tried running any tests, as it looks a bit involved (you have to have visual C++ installed, and you have to build the tests, it seems). Anyway, it seems like MDAC is something we really want to start supporting better, so maybe it's time to start looking into those conformance tests. Even if they only test data sources, heck, that's pretty good right there. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: WININET: lpvStatusInfo in INTERNET_STATUS_NAME_RESOLVED, INTERNET_STATUS_CONNECTING_TO_SERVER, and INTERNET_STATUS_CONNECTED_TO_SERVER should be strings, not sockaddr_in.
by Robert Shearman 31 Dec '05

31 Dec '05

Jacek Caban wrote: >+ /* FIXME: inet_ntoa is not thread safe. */ >+ szaddr = WININET_strdup_AtoW(inet_ntoa(lpwhs->socketAddress.sin_addr)); > INTERNET_SendCallback(&lpwhr->hdr, lpwhr->hdr.dwContext, > INTERNET_STATUS_NAME_RESOLVED, >- &(lpwhs->socketAddress), >- sizeof(struct sockaddr_in)); >+ szaddr, strlenW(szaddr)); >+ HeapFree(GetProcessHeap(), 0, szaddr); > > Like the comment says, it is not thread-safe. I don't think it is wise to delibrately introduce race conditions like this and it tends to cause problems with applications that rely heavily on multiple threads (such as iTunes). It would be better to use the thread-safe inet_ntop (which also has the bonus of supporting IPv6) or the ws2_32 version of inet_ntoa. -- Rob Shearman

1 0

Finding patches in wine-cvs mailing list for regression tests using CVS dates
by Daniel Calviño Sánchez 31 Dec '05

31 Dec '05

Hello. First of all, I'm not sure if this message should be posted here, so sorry if it isn't the correct place. I found a regression and made some test to find the patch that caused the problem. I followed the "How to do regression testing using CVS" section in Wine documentation http://winehq.org/site/docs/winedev-guide/x1344, but I think it's outdated. The wine-cvs archive mailing list linked in the documentation is http://www.winehq.org/hypermail/wine-cvs This archive ends in August 2005. I think the archive linked should be http://www.winehq.org/pipermail/wine-cvs/ But the main problem comes now. I used CVS to make the regression test. But when looking in the mailing list messages, the date in them isn't the CVS commit date. Instead, it is the Git commit date (or at least I think so). The Git to CVS gateway seems to get some time to commit the changes to the CVS. So I don't know how can I get the exact patch that caused the problem. I'll try to explain it with my problem. When I update the CVS to "2005-12-21 21:29:02 +0100", the game runs perfectly. However, if I update the CVS to "2005-12-21 21:29:03 +0100", it crashes. However, looking in the mailing list, there are no commits at "2005-12-21 21:29:03 +0100" (the previous was made at "2005-12-21 21:19:47 +0100"). Is there something I'm missing? How could I proceed? Thanks. P.D: I didn't give more information about the crash because the message was mainly focused to the dates in the mailing list question. Of course, I'll fill a bug report when I find the patch that caused the problem.

3 5

Re: Preliminary CD-Rom support on MacOS X #2
by Robert Shearman 31 Dec '05

31 Dec '05

emmanuel maillard wrote: > Changelog : > kernel/proces.c : Initialize darwin removable devices I appreciate you splitting up your patches for easier review, but patches are meant to be independent atomic changes that improve the code. However, if Alexandre applied this patch alone then Wine wouldn't compile any more and this isn't acceptable. -- Rob Shearman

3 3

Re: OLEAUT32: Use the FAILED macro to check for failure of interface methods.
by Robert Shearman 31 Dec '05

31 Dec '05

Mike McCormack wrote: > } > hr=IStream_Read(pStm,header,8,&xread); >- if (hr || xread!=8) { >+ if (FAILED(hr) || xread!=8) { > FIXME("Failure while reading picture header (hr is %lx, nread is %ld).\n",hr,xread); > return hr; > } >@@ -1128,10 +1128,10 @@ static HRESULT WINAPI OLEPictureImpl_Loa > while (xread < origsize) { > hr = IStream_Read(pStm,xbuf+xread,origsize-xread,&nread); > xread+=nread; >- if (hr || !nread) >+ if (FAILED(hr) || !nread) > break; > } >- if (!nread || hr) /* done, or error */ >+ if (!nread || FAILED(hr)) /* done, or error */ > break; > if (xread == origsize) { > origsize += sizeinc; >@@ -1139,7 +1139,7 @@ static HRESULT WINAPI OLEPictureImpl_Loa > xbuf = HeapReAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, xbuf, origsize); > } > } >- if (hr) >+ if (FAILED(hr)) > TRACE("hr in no-stat loader case is %08lx\n", hr); > TRACE("loaded %ld bytes.\n", xread); > This->datalen = xread; >@@ -1155,7 +1155,7 @@ static HRESULT WINAPI OLEPictureImpl_Loa > ULONG nread; > hr = IStream_Read(pStm,xbuf+xread,This->datalen-xread,&nread); > xread+=nread; >- if (hr || !nread) >+ if (FAILED(hr) || !nread) > break; > } > if (xread != This->datalen) > > > These changes are wrong. IStream_Read can return S_FALSE, which means that the call was successful, but didn't do what was intended. From MSDN: S_FALSE The data cannot be read from the stream object. Depending on the implementation, either S_FALSE or an error code could be returned when reading past the end of the stream. -- Rob Shearman

3 3

Finding patches in wine-cvs mailing list for regression tests using CVS dates
by Daniel Calviño Sánchez 31 Dec '05

31 Dec '05

1 0

Re: MSI: Change some FIXME messages to comments.
by Robert Shearman 31 Dec '05

31 Dec '05

Mike McCormack wrote: > ChangeLog: > Change some FIXME messages to comments. How hard would it be to do the work to really fix these FIXMEs? By changing these to comments I think they are going to be forgotten. -- Rob Shearman

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel