wine-devel

wine-devel@winehq.org

2 participants
84470 discussions

Re: PATCH: handle NULL XImage in GetBitmapBits
by Alexandre Julliard 13 Dec '05

13 Dec '05

Marcus Meissner <marcus(a)jet.franken.de> writes: > Changelog: > In GetBitmapBits() handle the correct bitmap information > when a DIB is used. I think for a DIB we want to copy the bits directly, like we already do in SetBitmapBits. Does this work for you? diff --git a/dlls/gdi/bitmap.c b/dlls/gdi/bitmap.c index a0c6b25..5c2b6c3 100644 --- a/dlls/gdi/bitmap.c +++ b/dlls/gdi/bitmap.c @@ -307,6 +307,30 @@ LONG WINAPI GetBitmapBits( if (!bmp) return 0; + if (bmp->dib) /* simply copy the bits from the DIB */ + { + DIBSECTION *dib = bmp->dib; + const char *src = dib->dsBm.bmBits; + DWORD max = dib->dsBm.bmWidthBytes * dib->dsBm.bmHeight; + if (count > max) count = max; + ret = count; + if (!bits) goto done; + + if (bmp->dib->dsBmih.biHeight >= 0) /* not top-down, need to flip contents vertically */ + { + src += dib->dsBm.bmWidthBytes * dib->dsBm.bmHeight; + while (count > 0) + { + src -= dib->dsBm.bmWidthBytes; + memcpy( bits, src, min( count, dib->dsBm.bmWidthBytes ) ); + bits = (char *)bits + dib->dsBm.bmWidthBytes; + count -= dib->dsBm.bmWidthBytes; + } + } + else memcpy( bits, src, count ); + goto done; + } + /* If the bits vector is null, the function should return the read size */ if(bits == NULL) { -- Alexandre Julliard julliard(a)winehq.org

3 2

Can Wine run "sv.net classic"? Not at the moment :-(
by Dan Kegel 13 Dec '05

13 Dec '05

http://www.heise.de/newsticker/meldung/67265 describes what looks like a nice opportunity for wine to prove itself. German employers are required to send insurance information online. There are two allowed methods: either a web page (which apparantly sucks), or a windows app called sv.net classic, available as a free download at http://www.itsg.de/svnet/ I tried installing it, but I didn't get past square one because the mdac installer is more busted than it used to be, at least on my machine. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 4

Re: gethostbyname(my_name) and IL2-Sturmovik
by Juan Lang 13 Dec '05

13 Dec '05

Hi Pavel, > And on the other side, try to query a DNS server for "localhost". > Every DNS server should immediately return 127.0.0.1, it's RFC > compliance requirement. Just to be clear, we're not talking about gethostbyname("localhost"). We're talking about gethostbyname(the_name_of_my_machine). In Windows, this returns your external address. See the following sample code which demonstrates this: http://tangentsoft.net/wskfaq/examples/ipaddr.html On Linux, at least for me, I get only 127.0.0.1 for my hostname (juandell, when I'm running on this laptop.) If I were to have this name registered with DNS, and if I were to ask a DNS server for the address of it, I wouldn't get 127.0.0.1, of course. But we're not talking about DNS anyway. We're talking about winsock's gethostbyname function. Wine's implementation isn't correct, since it doesn't match Windows. I still think David's patch could use some work, but let's not argue about whether its behaviour is correct: matching Windows is what we're obliged to do. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

A DirectX ToDo
by Tom Wickline 13 Dec '05

13 Dec '05

Hello Everyone, I've just posted a first draft of a DirectX ToDo on the Wiki : http://wiki.winehq.org/DirectX-ToDo?action=show Feedback, Comments, Suggestions are welcome. Cheers, Tom

1 0

Re: WINE-NB.BLOCK
by Rüdiger Koerschulte 13 Dec '05

13 Dec '05

> Hello, > > I`m sorry, but my English is not so good, but I`m trying to get an answer > about: > > I have installed SUSE 10.0, then WINE and then WINETOOLS. and the IE6. Now, > when I press the key comma, on the numeric-block, I get the remove > function. When I press die remove function an the cursor-block, I get a > comma. > > The function is always the same. It is the same when I put the > numeric-block on or off. > > How I can get a comma on the right key? > > Thank you for your understanding for my schoolenglish! > > Rüdiger

1 0

cross-compile error
by Steven Edwards 13 Dec '05

13 Dec '05

Hi, When doing Cross-Compiles I am seeing this error ../../include/wine/exception.h:142: error: parse error before "sigjmp_buf" ../../include/wine/exception.h:142: warning: no semicolon at end of struct or union ../../include/wine/exception.h:146: error: parse error before '}' token ../../include/wine/exception.h:146: warning: type defaults to `int' in declaration of `__WINE_FRAME' ../../include/wine/exception.h:146: warning: data definition has no type or storage class It seems the detection of sigjmp longjmp is busted for cross-compiling. I am using this patch locally but don't know how to properly fix it. Index: include/wine/exception.h =================================================================== RCS file: /home/wine/wine/include/wine/exception.h,v retrieving revision 1.26 diff -u -r1.26 exception.h --- include/wine/exception.h 1 Sep 2004 17:36:04 -0000 1.26 +++ include/wine/exception.h 13 Dec 2005 18:03:58 -0000 @@ -139,7 +139,7 @@ /* finally data */ __WINE_FINALLY finally_func; } u; - sigjmp_buf jmp; + jmp_buf jmp; /* hack to make GetExceptionCode() work in handler */ DWORD ExceptionCode; const struct __tagWINE_FRAME *ExceptionRecord; -- Steven Edwards - ReactOS and Wine developer "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: gethostbyname(my_name) and IL2-Sturmovik
by David Nolden 13 Dec '05

13 Dec '05

@Pavel Troller I've checkt the /etc/hosts now. You were right, it says 127.0.0.1 localhost.localdomain localhost Zwirch (With Zwirch the Name of this Computer) But I can't just statically rewrite it, because I use DHCP. Also this is a fresh Ubuntu-Install, so I'm surely not the only Wine-User with such an /etc/hosts.. @Juan You're right, I've checked the patch and it indeed was ugly! But when I sent it I hadn't done the check under Windows, so I didn't know if the patch was generally useful, so I mainly ment it as a piece for discussion.(Also I didn't notice how ugly it really was ;) I've cleaned it up a bit, closed the leak, and did a few other small tweaks so now the patch itself might be acceptable. greetings, David Am Dienstag, 13. Dezember 2005 07:04 schrieb Pavel Troller: > > Ok, I've just checked doing the same thing under windows. > > > > The test(ripdaveno is the name of the Computer I tested on): > > > > { > > ... > > hostent* h = gethostbyname("ripdaveno"); > > char* str = inet_ntoa(*((in_addr*)h->h_addr_list[0])); > > ... > > } > > > > The string in str was "192.168.2.75" which is my Network IP-Adress. With > > wine(under Linux), as far as I've tested it, exactly the same code always > > generates "127.0.0.1". > > > > Since Wine tries to simulate Windows as exactly as possible, this is > > wrong. So, in my opinion this Patch is necessary. :-) > > Hi! > It's strange but there is no patch in this mail I can look at... > However, even more strange is that wine returns localhost address to > you... Why ? I just tested Your testing code (just slightly modified to get > it to compile) on both plain linux as well as in wine and in both cases it > returns my real public IP. Isn't your Linux networking setup (/etc/hosts > table) a bit wrong ? My one contains (arcus is my machine name) > > 127.0.0.1 localhost > 195.39.17.7 arcus.sinus.cz arcus > > I have already seen broken setups containing things like > > 127.0.0.1 localhost arcus > > which is of course wrong. > > Regards, Pavel Troller

4 6

Latest winetest (20051212) issue on WinXP
by Paul Vriens 13 Dec '05

13 Dec '05

Hi, I've just noticed that during the running of winetest.exe windows creates a nice desktop stating that 'Active Desktop' is stopped because an unexpected error occurred. Anyone? Paul.

2 1

Re: WINED3D / D3D9: SetVertexShader & SetPixelShader should not change the shader's refcount
by Oliver Stieber 13 Dec '05

13 Dec '05

--- "H. Verbeet" <hverbeet(a)gmail.com> wrote: > SetVertexShader & SetPixelShader should not change the shader's > refcount. Verified on win2k, DirectX 9.0c. > > Changelog: > - Don't change the shader's refcount in SetVertexShader & SetPixelShader > > 26c6ae144caaaa6f7e40f7a7c6e3059851819ecf > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index c3a7f9c..a9c253f 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -3761,7 +3761,6 @@ HRESULT WINAPI IWineD3DDeviceImpl_GetVer > > HRESULT WINAPI IWineD3DDeviceImpl_SetVertexShader(IWineD3DDevice *iface, IWineD3DVertexShader* > pShader) { > IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; > - IWineD3DVertexShader *oldShader = This->updateStateBlock->vertexShader; > > This->updateStateBlock->vertexShader = pShader; > This->updateStateBlock->changed.vertexShader = TRUE; > @@ -3772,20 +3771,7 @@ HRESULT WINAPI IWineD3DDeviceImpl_SetVer > return D3D_OK; > } > > - if (pShader != NULL) { > - IUnknown *newVertexShaderParent; > - /* GetParent will add a ref, so leave it hanging until the vertex buffer is cleared */ > - TRACE("(%p) : setting pShader(%p)\n", This, pShader); > - IWineD3DVertexShader_GetParent(pShader, &newVertexShaderParent); > - } else { > - TRACE("Clear down the shader\n"); > - } > - if (oldShader != NULL) { > - IUnknown *oldVertexShaderParent; > - IWineD3DVertexShader_GetParent(oldShader, &oldVertexShaderParent); > - IUnknown_Release(oldVertexShaderParent); > - IUnknown_Release(oldVertexShaderParent); > - } > + TRACE("(%p) : setting pShader(%p)\n", This, pShader); The best thing to do is add an internal reference instead of referencing the parent. e.g. if (pShader != NULL) { IWineD3DVertexShader_AddRef(pShader); } if (oldShader != NULL) { IWineD3DVertexShader_Release(oldShader); } ___________________________________________________________ NEW Yahoo! Cars - sell your car and browse thousands of new and used cars online! http://uk.cars.yahoo.com/

2 1

Re: WINED3D / D3D9: SetVertexShader & SetPixelShader should not change the shader's refcount
by Oliver Stieber 13 Dec '05

13 Dec '05

--- "H. Verbeet" <hverbeet(a)gmail.com> wrote: > SetVertexShader & SetPixelShader should not change the shader's > refcount. Verified on win2k, DirectX 9.0c. > > Changelog: > - Don't change the shader's refcount in SetVertexShader & SetPixelShader > > 26c6ae144caaaa6f7e40f7a7c6e3059851819ecf > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index c3a7f9c..a9c253f 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -3761,7 +3761,6 @@ HRESULT WINAPI IWineD3DDeviceImpl_GetVer > > HRESULT WINAPI IWineD3DDeviceImpl_SetVertexShader(IWineD3DDevice *iface, IWineD3DVertexShader* > pShader) { > IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; > - IWineD3DVertexShader *oldShader = This->updateStateBlock->vertexShader; > > This->updateStateBlock->vertexShader = pShader; > This->updateStateBlock->changed.vertexShader = TRUE; > @@ -3772,20 +3771,7 @@ HRESULT WINAPI IWineD3DDeviceImpl_SetVer > return D3D_OK; > } > > - if (pShader != NULL) { > - IUnknown *newVertexShaderParent; > - /* GetParent will add a ref, so leave it hanging until the vertex buffer is cleared */ > - TRACE("(%p) : setting pShader(%p)\n", This, pShader); > - IWineD3DVertexShader_GetParent(pShader, &newVertexShaderParent); > - } else { > - TRACE("Clear down the shader\n"); > - } > - if (oldShader != NULL) { > - IUnknown *oldVertexShaderParent; > - IWineD3DVertexShader_GetParent(oldShader, &oldVertexShaderParent); > - IUnknown_Release(oldVertexShaderParent); > - IUnknown_Release(oldVertexShaderParent); > - } > + TRACE("(%p) : setting pShader(%p)\n", This, pShader); The best thing to do is add an internal reference e.g. if (pShader != NULL) { IWineD3DVertexShader_AddRef(pShader) IWineD3DVertexShader_Release(oldShader) ___________________________________________________________ NEW Yahoo! Cars - sell your car and browse thousands of new and used cars online! http://uk.cars.yahoo.com/

1 0

BUG (3920) + sync between DIBs and X Server optimisation. (please help)
by Marinescu-Ghetau Iulian 13 Dec '05

13 Dec '05

I came to the conclusion that the slowness in "Heroes IV" it has to do with sync'ing lage bitmaps between application DIBs and X Server(see the log: http://bugs.winehq.org/attachment.cgi?id=1470&action=view ). Also, a complete description of the bug is here: http://bugs.winehq.org/show_bug.cgi?id=3902 So i had this ideea that every GDI function could memorise the rectangle that is modifying, so each time a sync between DIB and X Server is needed, only a small part from the bitmap will get copied! I also made some changes to dib.c, bitblt.c and x11drv.h in "wine-0.9.2\dlls\x11drv" folder to implement my ideea, keeping backwards compatibility (if a DIB function doesn't set a valid rectangle for the bitmap that its modifying, the default values are taken - which is the entire bitmap) The changes i was talking about are listed below! My free time is very limited and i would strongly appreciate some help, moustly because something is not working ;( and i didn't manage to figure out what... -added member to X_PHYSBITMAP: XRectangle modified_rect; -added 2 functions: /*********************************************************************** * X11DRV_SetBoundRect */ void X11DRV_SetBoundRect(X_PHYSBITMAP *physBitmap, INT x, INT y, INT width, INT height) { XRectangle *t; INT xMin,yMin,xMax,yMax; if (!physBitmap) return; t = &(physBitmap->modified_rect); if ( t->width && t->height && /*already a valid rect inside*/ width && height ) /*not trying to invalidate rect*/ { //calculate the union of the two rectangles xMin = ((t->x < x)?t->x:x); yMin = ((t->y < y)?t->y:y); xMax = ((t->x + t->width > x + width)?(t->x + t->width):(x + width)); yMax = ((t->y + t->height > y + height)?(t->y + t->height):(y + height)); t->x = xMin; t->y = yMin; t->width = xMax - xMin; t->height = yMax - yMin; } else { t->x = x; t->y = y; t->width = width; t->height = height; } TRACE("(%p,%d,%d,%d,%d)\n", physBitmap->hbitmap, t->x, t->y, t->width, t->height); } /*********************************************************************** * X11DRV_GetBoundRect */ UINT X11DRV_GetBoundRect(X_PHYSBITMAP *physBitmap, INT *x, INT *y, INT *width, INT *height) { DIBSECTION dib; XRectangle *t; if (!physBitmap || GetObjectW( physBitmap->hbitmap, sizeof(dib), &dib ) != sizeof(dib)) { ERR("called for non-DIBSection!?\n"); return 1; } t = &(physBitmap->modified_rect); /* we should check for oversize values */ if ( (t->width > 0) && (t->height > 0) && (t->x < dib.dsBm.bmWidth) && (t->y < dib.dsBm.bmHeight) ) { *x = t->x; *y = t->y; if (t->x + t->width > dib.dsBm.bmWidth) *width = dib.dsBm.bmWidth - t->x; else *width = t->width; if (t->y + t->height > dib.dsBm.bmHeight) *height = dib.dsBm.bmHeight - t->y; else *height = t->height; } else { *x = 0; *y = 0; *width = dib.dsBm.bmWidth; *height = dib.dsBm.bmHeight; } TRACE("(%p,%d,%d,%d,%d)\n", physBitmap->hbitmap, *x, *y, *width, *height); return 0; } -changed X11DRV_DIB_DoUpdateDIBSection like this: static void X11DRV_DIB_DoUpdateDIBSection(X_PHYSBITMAP *physBitmap, BOOL toDIB) { INT x,y,width,height; if ( X11DRV_GetBoundRect(physBitmap,&x,&y,&width,&height) ) return; /*invalidate bound rect*/ X11DRV_SetBoundRect(physBitmap,0,0,0,0); X11DRV_DIB_DoCopyDIBSection(physBitmap, toDIB, physBitmap->colorMap, physBitmap->nColorMap, physBitmap->pixmap, x, y, x, y, // i think something is wrong here (help?) width, height); } - and finally, a GDI function calls it like this (for example bitblt): X11DRV_SetBoundRect(physDevDst->bitmap,xDst,yDst,width,height); X11DRV_CoerceDIBSection( physDevDst, DIB_Status_GdiMod, FALSE ); if (physDevDst != physDevSrc) { X11DRV_SetBoundRect(physDevSrc->bitmap,xSrc,ySrc,width,height); X11DRV_CoerceDIBSection( physDevSrc, DIB_Status_GdiMod, FALSE ); } result = BITBLT_InternalStretchBlt( physDevDst, xDst, yDst, width, height, physDevSrc, xSrc, ySrc, width, height, rop ); END: if (physDevDst != physDevSrc) X11DRV_UnlockDIBSection( physDevSrc, FALSE ); X11DRV_UnlockDIBSection( physDevDst, TRUE );

2 2

Re: http headers reworking
by Alexandre Julliard 13 Dec '05

13 Dec '05

Aric Stewart <aric(a)codeweavers.com> writes: > Redo how headers are handled. > eliminating the concept of Standard Headers and allow all headers to be > added multiple times. > Allow querying of headers with an index to get the multiple headers. > Respect response vs request headers in HttpQueryInfo. > Add a number of tests to extensively test header adding and replacing. > All fixes for Picasa. The tests don't work here: http.c:1152: Test failed: Index was not incremented http.c:1156: Test failed: Second Index Should Not Exist http.c:1167: Test failed: Index was not incremented http.c:1168: Test failed: incorrect string was returned(test2) http.c:1173: Test failed: Index was not incremented http.c:1177: Test failed: Third Header Should Not Exist http.c:1187: Test failed: Index was not incremented http.c:1188: Test failed: incorrect string was returned(test3) http.c:1193: Test failed: Index was not incremented http.c:1197: Test failed: Third Header Should Not Exist http.c:1207: Test failed: Index was not incremented http.c:1208: Test failed: incorrect string was returned(test3) http.c:1213: Test failed: Index was not incremented http.c:1217: Test failed: Third Header Should Not Exist http.c:1227: Test failed: Index was not incremented http.c:1228: Test failed: incorrect string was returned(test4) http.c:1232: Test failed: Index was not incremented http.c:1233: Test failed: incorrect string was returned(test4) http.c:1236: Test failed: Third Header Should Not Exist http.c:1244: Test failed: Index was not incremented http.c:1245: Test failed: incorrect string was returned(test5) http.c:1249: Test failed: Index was not incremented http.c:1250: Test failed: incorrect string was returned(test5) http.c:1253: Test failed: Third Header Should Not Exist http.c:1261: Test failed: Index was not incremented http.c:1262: Test failed: incorrect string was returned(test6) http.c:1266: Test failed: Index was not incremented http.c:1267: Test failed: incorrect string was returned(test6) http.c:1270: Test failed: Third Header Should Not Exist http.c:1278: Test failed: Index was not incremented http.c:1279: Test failed: incorrect string was returned(test7) http.c:1283: Test failed: Index was not incremented http.c:1287: Test failed: Third Header Should Not Exist -- Alexandre Julliard julliard(a)winehq.org

2 1

Can't install mdac at all now
by Dan Kegel 13 Dec '05

13 Dec '05

Bug 3636 is worse now. http://bugs.winehq.org/show_bug.cgi?id=3636 A few weeks ago, after mdac installer finished, I could go and unpack the installed cabs by hand. Now the installer aborts before it even copies the cabs. Bleah. -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 3

freetype and wine
by Curro Amores 13 Dec '05

13 Dec '05

Hi: I get everytime i want to display a report on my access97 app this error: fixme:font:load_VDMX Failed to retreive vTable Then the fonts of the report are displayed separated and bigger than on windows. Somebody told me to install freetype new version. I have installed the last version of freetype2 (9.8.3) and it keeps on the same. Do i have to do something for telling wine to use the new version of freetype? Im using windows98 emulation in wine for this app. Has it something to do that i have moved all windows xp ttf files to fonts fake directory?? Thanks all!

1 0

Re: gethostbyname(my_name) and IL2-Sturmovik
by Juan Lang 13 Dec '05

13 Dec '05

Hi David, > The string in str was "192.168.2.75" which is my Network IP-Adress. > With wine(under Linux), as far as I've tested it, exactly the same > code always generates "127.0.0.1". > Since Wine tries to simulate Windows as exactly as possible, > this is wrong. > So, in my opinion this Patch is necessary. :-) You're right that Wine doesn't behave correctly in this case. The trouble is your patch is rather ugly. First, the style isn't correct--no C++-style comments, please, and make the indenting consistent. Second, there's a leak in the code you wrote, the socket you open to do SIOCGIFCONF on is never closed. It would be cleaner, in my opinion, to use iphlpapi's GetAdaptersInfo, which already enumerates the public (non-loopback) interfaces available on the system. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

RFC: D3D7 and WineD3D
by Stefan Dösinger 12 Dec '05

12 Dec '05

Hello, In the past weeks, I've worked on a re-write of the Direct3D7 implementation with WineD3D. Well, I've managed to get some games running, but I have also encountered a few problems. Before I continue with this, I'd like to ask for your opinions. I have uploaded a patch to http://doesi.gmxhome.de/d3d7.patch.bz2, it's a diff against Wine CVS from December, 11th 2005. It's not really meant to be used, but rather to have something to look at. I don't know how long I can keep the patch there, because I am limited in space. I've sent the patch to Oliver some days ago to upload it to his sourceforge website, it will be available there when he uploads it. So what's the point of this mail? While a D3D7->WineD3D wrapping can be done by wrapping D3D7 only and leave DirectDraw in ddraw.dll, it has a few ugly drawbacks: -> Device initalisation: In D3D7, the first step is to create a IDirectDraw Device, set up the device, create a surface and then create a Direct3D Device. When creating the WineD3DDevice in the last step, I have to do some ugly things to wrap the allready existing Surface to a newly created WineD3DSurface. The same applies in reverse order for the device removal. I also don't know what to do if a game changes the screen setup after D3DDevice creation. -> Surfaces: In D3D7 surfaces are children of IDirectDraw, while in WineD3D they are children of WineD3DDevice. Because the D3D7Device can be created and destroyed without modifying surfaces, I have to manage the surface's properties and memory areas for both DirectDraw and WineD3D. Overrides for the Lock() and Unlock() functions are used to access the WineD3D surface if it exists. I think that everything would be much cleaner if the DirectDraw functionality was also moved to WineD3D. My suggestion is the follwing. -> WineD3D would be initialised in the D3D7 way, using a new interface WineDDrawDevice. D3D8 and D3D9 could easily manage this in their create functions -> Surfaces are created with WineDDrawDevice, and they survive the release of WineD3DDevice. This makes surface creation easier for D3D7, and it's easy to adopt it for D3D9 and D3D8. -> The IWineD3DSurface interface gets additional functionality for DirectDraw operations. I'd suggest 3 versions of the 2D functions: One based on plain X11(for compatiblity) calls, one that uses DGA(speed without 3D acceleration), and one that uses OpenGL(For fast rendering without /dev/mem access). For DXVersion > 7 the OpenGL version is used, and for DX7 it can be decided when the primary surface is created. What's the drawback? First, it's much more work, and it's a really invasive change to WineD3D, which becomes more complex. Because of this I'd like to know your opinion before I spend a lot of time for this. Stefan

1 1

gethostbyname(my_name) and IL2-Sturmovik
by David Nolden 12 Dec '05

12 Dec '05

Ok, I've just checked doing the same thing under windows. The test(ripdaveno is the name of the Computer I tested on): { ... hostent* h = gethostbyname("ripdaveno"); char* str = inet_ntoa(*((in_addr*)h->h_addr_list[0])); ... } The string in str was "192.168.2.75" which is my Network IP-Adress. With wine(under Linux), as far as I've tested it, exactly the same code always generates "127.0.0.1". Since Wine tries to simulate Windows as exactly as possible, this is wrong. So, in my opinion this Patch is necessary. :-) greetings, David Nolden

1 0

gethostbyname(my_name) and IL2-Sturmovik
by David Nolden 12 Dec '05

12 Dec '05

I've just checked the registry-accesses. It only seems to take the own name from there(which it later uses to get the IP-Adress). It doesn't try to read anything in the area mentioned on the microsoft-site you sent me. greetings, David Nolden

1 0

Re: Robert Reif : winecfg: Added support for auto detecting all drivers by attempting to
by Eric Pouech 12 Dec '05

12 Dec '05

I do think all the recent changes to winecfg are going into the wrong direction. First of all, allowing the devices to be opened more than once without having the devices ready for that is a ready bad idea. Basically, windows drivers come in two flavors: - single instance (they can be loaded only once in memory) - multiple instance (they can be loaded several times in memory) For the second type, a specific init string (gotten from the registry, and usually dealing with the HZ resources involved) is passed to the driver. In the wine implementation, we don't get anything from the registry, we just let the device (from the unix interface it uses) return as many audio/midi... ports it finds. This is typically the behavior expected from single instance drivers. Among the issues we'll face here are dual open of the same unix resource (contention) for several instances, overwriting of internal data and structures (they are not prepared for that). Therefore, the multiple open patch has to be reverted. Secondly, I do think it's a bad idea to reconstruct in winecfg most the driver management. It's not done correctly (the DRV_INIT, DRV_ENABLE and DRV_LOAD messages are not correctly passed). If it works today, it's by chance as the configure message is never handled (we just put out a message box), but it doesn't access the internal structures. To do it, we need the DRV_ messages sent. Finally, I'm not sure that presenting all the drivers, and the ports available is really meaningful for most users. Some drivers return just potential entries (esound for example). Even with the caps, most users won't tell the difference between alsa and oss entries. Lately, the available drivers button is not really useful. We shouldn't present non available drivers to the users, and just let him/her choose among the available ones (or just to mark the ones which are not available). -- Eric Pouech

2 6

Re: WIDL: Zero Initialize Server Parameters
by Robert Shearman 12 Dec '05

12 Dec '05

Robert Shearman wrote: > ChangeLog: > Zero initialize parameters in the generated code. Based on a patch by > Eric Kohl. Oops. Looks like this patch was already accepted and the patch I just sent was a merge conflict. Please ignore. -- Rob Shearman

1 0

Re: [NDR] Implement NdrClientCall2 and NdrServerCall2
by Detlef Riekenberg 12 Dec '05

12 Dec '05

Am Donnerstag, den 01.12.2005, 00:39 -0600 schrieb Robert Shearman: > [NDR] Implement NdrClientCall2 and NdrServerCall2 > [NDR] Fix handle support for stubless objects > [NDR] Fix Accessing Arguments in NdrClientCall2 Hi Rob. I tested your Patches with printui.dll and winspool.drv (from w2k) and got only "RPC_X_WRONG_STUB_VERSION" --- cut --- trace:rpc:NdrClientCall2 MIDL stub version = 0x5030117 fixme:rpc:NdrClientCall2 RPC_FC_BIND_GENERIC --- cut --- Then i commented out the RpcRaiseException() after the fixme and run: wine rundll32 printui.dll,PrintUIEntry /s The Server-Properties-Window opens and react on the Mouse, but the Fields are Empty or filled with Garbage. (same garbage as buildin winspool.drv with my patch for OpenPrinter) I attached an updated log to bug 3105 Thanks for your work on RPC. -- By By ... ... Detlef

2 1

Re: Alexandre Julliard : server: Added access rights mapping to synchronization objects.
by Robert Shearman 12 Dec '05

12 Dec '05

Alexandre Julliard wrote: >@@ -132,6 +133,15 @@ static int event_satisfied( struct objec > return 0; /* Not abandoned */ > } > >+static unsigned int event_map_access( struct object *obj, unsigned int access ) >+{ >+ if (access & GENERIC_READ) access |= STANDARD_RIGHTS_READ | SYNCHRONIZE | EVENT_QUERY_STATE; >+ if (access & GENERIC_WRITE) access |= STANDARD_RIGHTS_WRITE; >+ if (access & GENERIC_EXECUTE) access |= STANDARD_RIGHTS_EXECUTE; >+ if (access & GENERIC_ALL) access |= STANDARD_RIGHTS_ALL | EVENT_ALL_ACCESS; >+ return access & ~(GENERIC_READ | GENERIC_WRITE | GENERIC_EXECUTE | GENERIC_ALL); >+} >+ > static int event_signal( struct object *obj, unsigned int access ) > { > struct event *event = (struct event *)obj; > Why did you decide to rely on another function to map the access rights? It seems that none of the objects' mappings depend on any state in the object, so couldn't you have just put the access rights that GENERIC_READ, GENERIC_WRITE, GENERIC_EXECUTE and GENERIC_ALL map to somewhere associated with the object and have just one mapping function. -- Rob Shearman

2 3

gethostbyname(my_name) and IL2-Sturmovik
by David Nolden 12 Dec '05

12 Dec '05

Hi everybody. Currently, my favorite Game is "IL2-Sturmovik Forgotten Battles", especially it's online-mode. The Game itself is running nearly flawless and at good performance, but I encountered a network-problem which didn't allow the game to connect to any remote server, so I've analyzed and solved the problem. This is what the game does: 1. Create a Datagram-socket 2. Call gethostbyname(own_name) to find out the current IP-Adress 3. Bind the socket to that IP-Adress 4. Try connecting to the remote game using exactly that socket The Problem: gethostbyname(own_name) always returns 127.0.0.1. I've searched a bit on the internet, and this seems always to be the case, not just on my computer. The socket is then bound to the ip-adress 127.0.0.1, and to it's corresponding loopback-interface, so it's unusable. Any connection-request times out. I don't really know much about Networking itself, I just know how to use IP-Networking, but I think it's pretty boring(especially the way it all is implemented) so I don't even know what IPV6 is, and I don't know if my patch is compatible with it(although I think so). Also I don't know if returning 127.0.0.1 is in fact not a bug but desired, and the game is doing something wrong here. But if it is desired that gethostbyname(own_name) preferrably returns the public IP-Adress, then this code should solve the problem, although maybe a bit more checking should be done which IP-Adress should be chosen as the public one for cases with multiple non-loopback-interfaces. I submit this patch to the wine-devel-list so people who know more about all the network-handling can discuss about it, and decide whether it should be put to cvs, or whether there is a better Solution for this problem. The Code enumerates all available Interfaces through the kernel, and decides which one should be used in a very naive way. greetings, David Nolden (btw. my subscription to the list doesn't seem to be complete yet, I'm sending this anyway)

2 1

Re: crypt32: decode cleanups
by Alexandre Julliard 12 Dec '05

12 Dec '05

Juan Lang <juan_lang(a)yahoo.com> writes: > ChangeLog: > - implement a helper to decode sequences of like types > - use helper functions wherever applicable when decoding > - fix a few other small bugs This breaks the test: encode.c:790: Test failed: Expected OID Juan Lang, got NULL encode.c:790: Test failed: Expected OID Juan Lang, got NULL encode.c:790: Test failed: Expected OID Juan Lang, got NULL -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: PATCH: handle redirect to https
by Robert Shearman 12 Dec '05

12 Dec '05

Marcus Meissner wrote: >Hi, > >Redirect from http to https currently segfaults our >wininet implementation. > >Exposed by the Google Earth update check. > >Ciao, Marcus > >Changelog: > When redirecting, do not forget to reinit NETCON. > > This shouldn't be necessary. The NETCONNECTION structure should have been re-initialized to its post-NETCON_init state after calling NETCON_close. There are two possible reasons I can think of that would cause a crash. The first is the NETCONNECTION stuff not being thread-safe. The second is possible ref-counting issues on the SSL method object "meth". Can you show me the backtrace? -- Rob Shearman

2 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel