wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: [wininet]add implementation of few more options - try6
by Juan Lang 10 Nov '05

10 Nov '05

Hi Vijay, sorry I wasn't more explicit. This is what I mean: + hurl = InternetConnectA(hinet,"www.winehq.com",INTERNET_DEFAULT_HTTP_PORT,NULL,NULL,INTERNET_SERVICE_HTTP,0,0); This could fail for many reasons other than that InternetConnectA has a flaw (the test machine may be offline, winehq.com may be down, etc.) Therefore you must deal with the failure, but using ok() is not correct--a failure doesn't necessarily indicate a failure in the test. So you must something like the following: if (hurl) { /* do tests that depend on hurl here */ InternetCloseHandle(hurl); } --Juan __________________________________ Yahoo! FareChase: Search multiple travel sites in one click. http://farechase.yahoo.com

1 0

Re: [wininet]add implementation of few more options - try6
by Dmitry Timoshkov 10 Nov '05

10 Nov '05

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > I hope this is the last try Sorry, but it is not. Do you ever read the suggestions? -- Dmitry.

1 0

[Fwd: joystickinput fixes (attempt number 4)]
by Jakob Eriksson 10 Nov '05

10 Nov '05

1 0

Re: [wininet]add implementation of few more options - try5
by Dmitry Timoshkov 10 Nov '05

10 Nov '05

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > as previous implementation had some bugs use this version and > implements some suggestions > more tests to come > > ChangeLog > ---------------- > Added implementation for INTERNET_OPTION_VERSION > Added implementation for INTERNET_OPTION_USER_AGENT > Fixed behavior for INTERNET_OPTION_HTTP_VERSION > Added implementation for unsupported options > Added some minimalist testcases You could send your patch billion times, but there is no point in that if you don't fix the pointed out problems. -- Dmitry.

4 3

Re: XEmbed Systray Support
by James Liggett 10 Nov '05

10 Nov '05

On Wed, 2005-11-09 at 15:26 +0530, Vijay Kiran Kamuju wrote: > I have tested googletalk with the patch of yours, i am attaching the > screenshot of it. > whenever i ve closed an googletalk instance its present on the screen > (in the picture i have labelled it as zombie), in ps -ef its not > killing the wine-pthread process. even if i kill that process > manually, i see some artifacts of it left on the screen see to top > most marking. Yeah I get that with Steam and Hotsync as well, in addition to a test program that I slapped together. This sort of behavior only shows itself in GNOME, not in other XEmbed compliant desktops i tested. (I tried XFce and IceWM, in those environments the patches don't show this behavior) It's been suggested that this is some sort of bug in GNOME's implementation of the spec, and I have to agree. So I don't think there's much I can do on the Wine side of this. But I'm not sure about zombie processes though. I'll take a look at that. Thanks for the feedback. James

2 3

compile error: server/event.c
by Sütő Gergely 09 Nov '05

09 Nov '05

Hello! (Sorry for my bad English.) I have problem with compiling after cvs update. Please help! $ tar xvjf wine-0.9.tar.bz2 $ mv wine-0.9 wine $ tar xvzf wine-cvsdirs-0.9.tar.gz $ cd wine $ export CVSROOT=:pserver:cvs@cvs.winehq.org:/home/wine $ cvs login $ cvs update -PAd $ ./configure $ make depend $ make make[1]: Entering directory `/home/geri/src/wine/server' gcc -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -mpreferred-stack-boundary=2 \ -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o event.o event.c In file included from event.c:29: ../include/winternl.h:2040: error: parse error before "va_list" ../include/winternl.h:2211: error: parse error before "va_list" ../include/winternl.h:2212: error: parse error before "va_list" make[1]: *** [event.o] Error 1 make[1]: Leaving directory `/home/geri/src/wine/server' make: *** [server] Error 2 $ Linux: 2.6.19 glibc: 2.3.3 gcc: 3.3.4 Before cvs update the compiling it's right! THX: Geri_

3 4

Re: [user] static.c: PaintIcon fix background colour
by Michael Kaufmann 09 Nov '05

09 Nov '05

Hi Kieran, Icons can have transparent and inverted pixels! This patch is not correct, the background has to be painted always. * dlls/user/static.c: Kieran Clancy <n0dalus+wine at gmail.com <http://www.winehq.org/mailman/listinfo/wine-patches>> Only set background for icon control when the icon is invalid. Regards, Michael

2 3

Wine API Documentation
by Robert Shearman 09 Nov '05

09 Nov '05

Hi, At the moment we have a very outdated version of the auto-generated "make htmlpages" Wine API documentation at http://source.winehq.org/WineAPI/ I want to fix this. * *I believe that the API documentation is important for a number of reasons: 1. It might provide info to ISVs that might think about porting an app to Wine as to whether the APIs that they use are implemented or not. 2. It provides info about undocumented functions. 3. It provides an alternative source to MSDN in case it becomes unavailable for whatever reason. 4. It spreads the word about Wine through high search engine rankings, making it more likely that someone will stumble upon Wine and start coding for fun. * *It appears that this was previously generated at release time by the wine_release script (http://cvs.winehq.org/cvsweb/tools/wine_release), but was disabled over 2 years ago. I was wondering what the reason was, but I guess it is that it takes a long time to build and a lot of CPU time. We don't really want the WineHQ web server to be running at 100% CPU for ~20 minutes while it builds the API documentation. Therefore I propose that I could send a tarball of the documentation to Newman every release, every month, or after a major update of the documentation (whichever is sooner) and he can put it up in the appropriate location. Alternatively, we could also put the auto-generated docs in cvs and generate diffs. Alexandre, any comments about how the release process should work with regard to the Wine API documentation? Newman, which method of updating would you prefer? Any one else have any comments at all about this? Thanks, -- Rob Shearman

7 6

msvcrt _tempnam and tests
by Phil Lodwick 09 Nov '05

09 Nov '05

I submitted a patch yesterday for the implementation of _tempnam in msvcrt. Today I started to write a conformance test which has led to several questions. 1) What action should we take if MS documentation and the implementation do not agree? a) leave out the test b) test to implementation 2) If a function takes several parameters, do you test all permutations, or just the ones you feel are important? 3) This question is specific to the implementation of _tempnam. The current implementation just calls GetTempFileNameA. My first attempt at a patch made things better by calling GetTempFileNameA with better parameters. After writing the conformance test, however, I see that calling GetTempFileNameA is just plain wrong -- for at least two reasons: a) GetTempFileNameA truncates prefix to 3 characters, _tempnam does not b) GetTempFileNameA adds a ".tmp" extension, _tempnam does not. Do we just duplicate and modify the kernel TempFileNameA code in msvcrt? Thanks, Phil

3 2

MindManager Viewer
by Nardmann, Heiko 09 Nov '05

09 Nov '05

Hi! I have tried to get the MindManager Viewer installed but without success. I have used version 0.9 of wine (self-compiled) which results in the following messages (calling /opt/wine-0.9/bin/wine M60-G-643_Viewer.exe): fixme:win:SetWindowTextA cannot set text ": Setup.INI" of other process window (nil) fixme:win:SetWindowTextA cannot set text ": 0x0407.ini" of other process window (nil) fixme:msi:MsiGetProductInfoA "{EC16B2EF-A202-4FA0-B34B-593D4A7388DD}" "PackageCode" 0x406fdaa8 0x406fdb18 fixme:msi:MsiGetProductInfoW L"{EC16B2EF-A202-4FA0-B34B-593D4A7388DD}" L"PackageCode" 0x403de1a0 0x406fdb18 fixme:win:SetWindowTextA cannot set text "Entpackung l\xe4uft: GER_Viewer_Splash.bmp" of other process window (nil) fixme:msi:MsiInstallProductW L"C:\\windows\\temp\\_is830\\ISScript1050.Msi" L"REBOOT=ReallySuppress ADDLOCAL=All" fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action L"SelfUnregModules" fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action L"RemoveFiles" fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action L"MoveFiles" err:msi:ACTION_InstallFiles Unable to move file (L"C: \\windows\\temp\\_is830\\id" -> L"c:\\Programme\\Gemeinsame Dateien\\InstallShield\\Driver\\1050\\Intel 32\\ID") (error 2) err:msi:ACTION_InstallFiles Source File Not Found! Continueing err:msi:ACTION_InstallFiles Unable to move file (L"C: \\windows\\temp\\_is830\\ISRT.dll" -> L"c:\\Programme\\Gemeinsame Dateien\\InstallShield\\Driver\\1050\\Intel 32\\ISRT.dll") (error 2) err:msi:ACTION_InstallFiles Source File Not Found! Continueing err:msi:ACTION_InstallFiles Unable to move file (L"C: \\windows\\temp\\_is830\\F1324_ISRES.dll" -> L"c:\\Programme\\Gemeinsame Dateien\\InstallShield\\Driver\\1050\\Intel 32\\_ISRES1033.dll") (error 2) err:msi:ACTION_InstallFiles Source File Not Found! Continueing err:msi:ACTION_InstallFiles Unable to move file (L"C: \\windows\\temp\\_is830\\IDriver.exe" -> L"c:\\Programme\\Gemeinsame Dateien\\InstallShield\\Driver\\1050\\Intel 32\\IDriver.exe") (error 2) err:msi:ACTION_InstallFiles Source File Not Found! Continueing err:msi:ACTION_InstallFiles Unable to move file (L"C: \\windows\\temp\\_is830\\iGdiCnv.dll" -> L"c:\\Programme\\Gemeinsame Dateien\\InstallShield\\Driver\\1050\\Intel 32\\iGdiCnv.dll") (error 2) err:msi:ACTION_InstallFiles Source File Not Found! Continueing err:msi:ACTION_InstallFiles Unable to move file (L"C: \\windows\\temp\\_is830\\IUserCnv.dll" -> L"c:\\Programme\\Gemeinsame Dateien\\InstallShield\\Driver\\1050\\Intel 32\\IUserCnv.dll") (error 2) err:msi:ACTION_InstallFiles Source File Not Found! Continueing err:msi:ACTION_InstallFiles Unable to move file (L"C: \\windows\\temp\\_is830\\IScrCnv.dll" -> L"c:\\Programme\\Gemeinsame Dateien\\InstallShield\\Driver\\1050\\Intel 32\\IScrCnv.dll") (error 2) err:msi:ACTION_InstallFiles Source File Not Found! Continueing err:msi:ACTION_InstallFiles Unable to move file (L"C: \\windows\\temp\\_is830\\objpscnv.dll" -> L"c:\\Programme\\Gemeinsame Dateien\\InstallShield\\Driver\\1050\\Intel 32\\objpscnv.dll") (error 2) err:msi:ACTION_InstallFiles Source File Not Found! Continueing err:msi:ACTION_DuplicateFiles Original file unknown L"IDriver.exe" fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action L"RemoveRegistryValues" fixme:msi:ACTION_HandleStandardAction UNHANDLED Standard Action L"RemoveFolders" err:msi:MsiGetSummaryInformationW IStorage -> IPropertySetStorage failed fixme:msi:MsiInstallProductW L"c:\\windows\\Downloaded Installations\\Mindjet MindManager Viewer 6.msi" L" SETUPEXEDIR=Y:\\Documents\\MindManager" err:msi:ACTION_ProcessUISequence Execution halted due to error (1603) I have downloaded the Viewer from the MindManager web site (executable is M60-G-643_Viewer.exe as stated above). Any hints? -- Heiko Nardmann

1 0

Wine Conf 2004
by Dimi Paun 09 Nov '05

09 Nov '05

Hi folks, I've added a stub page for Wine Conf 2004: http://wiki.winehq.org/WineConf2004 It would be nice if somebody spends some time to document what we did there before we completely forget (similar to the other WineConf200[25] pages). It is part of our history, and would be a pitty to not capture it somewhere... -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: [wininet]add implementation of few more options - try5
by Juan Lang 09 Nov '05

09 Nov '05

Hi Vijay, + hurl = InternetConnectA(hinet,"www.winehq.com",INTERNET_DEFAULT_HTTP_PORT,NULL,NULL,INTERNET_SERVICE_HTTP,0,0); + ok((hurl != 0x0),"InternetConnect Failed\n"); + + if( hurl == 0x0) + { + InternetCloseHandle(hurl); + InternetCloseHandle(hinet); + return; + } The ok after InternetConnectA shouldn't be there. You don't want the test to fail if it couldn't connect; as I said before, there are many reasons the connection could fail. Also, in the if block below, there's no reason to call InternetCloseHandle when hurl is 0. Thanks, --Juan __________________________________ Start your day with Yahoo! - Make it your home page! http://www.yahoo.com/r/hs

1 0

Re: RESEND [wininet]add implementation of few more options
by Robert Shearman 09 Nov '05

09 Nov '05

Vijay Kiran Kamuju wrote: >+ case INTERNET_OPTION_ASYNC: >+ case INTERNET_OPTION_ASYNC_ID: >+ case INTERNET_OPTION_ASYNC_PRIORITY: >+ case INTERNET_OPTION_CALLBACK_FILTER: >+ case INTERNET_OPTION_CODEPAGE: >+ case INTERNET_OPTION_CONNECT_BACKOFF: >+ case INTERNET_OPTION_CONNECT_TIME: >+ case INTERNET_OPTION_DATA_RECEIVE_TIMEOUT: >+ case INTERNET_OPTION_DATA_SEND_TIMEOUT: >+ case INTERNET_OPTION_DISABLE_AUTODIAL: >+ case INTERNET_OPTION_DISCONNECTED_TIMEOUT: >+ case INTERNET_OPTION_IDLE_STATE: >+ case INTERNET_OPTION_KEEP_CONNECTION: >+ case INTERNET_OPTION_LISTEN_TIMEOUT: >+ case INTERNET_OPTION_OFFLINE_MODE: >+ case INTERNET_OPTION_OFFLINE_SEMANTICS: >+ case INTERNET_OPTION_POLICY: >+ case INTERNET_OPTION_RECEIVE_THROUGHPUT: >+ case INTERNET_OPTION_SEND_THROUGHPUT: >+ WARN("This request is not supported by native either\n"); > You should print out the option being requested, otherwise the "This" in "This request" is meaningless. Just printing the option number is fine. -- Rob Shearman

4 7

Re: [wined3d] GL_EXT_framebuffer_object and Mesa detection
by Alexandre Julliard 09 Nov '05

09 Nov '05

Raphael <fenix(a)club-internet.fr> writes: > Index: ../../include/wine/wined3d_gl.h > RCS file: /home/wine/wine/include/wine/wined3d_gl.h,v > retrieving revision 1.11 > diff -u -r1.11 wined3d_gl.h > -- ../../include/wine/wined3d_gl.h 28 Sep 2005 18:12:00 -0000 1.11 > +++ ../../include/wine/wined3d_gl.h 9 Nov 2005 08:43:36 -0000 Could you please generate patches from the top-level directory? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: XEmbed Systray Support
by James Liggett 09 Nov '05

09 Nov '05

Anything wrong with this patch? (Resent version) James Liggett On Tue, 2005-10-11 at 17:07 -0700, James Liggett wrote: > Hi, > This patch implements XEmbed system tray support for recent non-KDE > desktops. This is a modified version of a patch originally submitted by > Rob Shearman, <rob(a)codeweavers.com> which was based on work originally > done by Mike Hearn <mh(a)codeweavers.com> > > Changelog: > Support XEmbed system tray protocol for tray icons > > James Liggett

6 12

Re: added implementation of some more options - try3
by Juan Lang 09 Nov '05

09 Nov '05

Hi Vijay, thanks for adding test cases this time. + hurl = InternetConnectA(hinet,"www.winehq.com",INTERNET_DEFAULT_HTTP_PORT, NULL,NULL,INTERNET_SERVICE_HTTP,0,0); + ok((hurl != 0x0),"InternetConnect Failed\n"); You should just clean up if this fails, there are many reasons a connect to winehq.com could fail. --Juan __________________________________ Yahoo! FareChase: Search multiple travel sites in one click. http://farechase.yahoo.com

1 0

Re: Needs some guidance (aclui/netapi32)
by Juan Lang 09 Nov '05

09 Nov '05

Hi Paul, > I'm trying to add some extra functions to our netapi32 (domain service > related stuff) as this is needed by Process Explorer (or actually by > native aclui.dll). Cool. I'd just try to stub out the missing functions for now if I were you. Maybe this is what you're already trying. > I prefer not to go the way of adding loads of native dll's, but if so > what versions of dll's should I use? Before the move to win2k as the > default we were advised to use win98 dll's, but now? Last time I looked (though it has been a while) native netapi32 depended on way too much stuff to have a chance. The WinXP version at least depends on all sorts of SID/Lsa stuff that aren't around. The win98 version doesn't implement the same set of functions, and functions with the same names sometimes have different arguments, so I suspect you won't have much luck there either. Your best bet is what you're doing: work on our netapi32 to get aclui not to crash. Fortunately it's only a few functions, and you can hardcode values until you figure out what it needs. Good luck, --Juan __________________________________ Yahoo! Mail - PC Magazine Editors' Choice 2005 http://mail.yahoo.com

1 0

Re: added implementation of some more options - try3
by Dmitry Timoshkov 09 Nov '05

09 Nov '05

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > Added implementation for INTERNET_OPTION_VERSION > Added implementation for INTERNET_OPTION_USER_AGENT > Fixed behavior for INTERNET_OPTION_HTTP_VERSION > Added implementation for unsupported options > Added some minimalist testcases In this version there are still the same problems mentioned before. Notably: in the tests last error is not set to a bogus value before an API call while it's tested afterwards, buffer length is not initialized before the API calls. > + FIXME("This request %ld is not supported by native as of now\n",dwOption); This message is misleading, I'd suggest something like the following: FIXME("Request %ld is not supported\n", dwOption); -- Dmitry.

1 0

Re: crypt32: plug memory leaks
by Robert Shearman 09 Nov '05

09 Nov '05

Juan Lang wrote: >Hope you don't mind the memory function changes, they helped me debug the >leaks. > >ChangeLog: >- use macros for memory allocation for easier debugging >- plug memory leaks > I'm not sure why you need to use these extra macros for memory allocation. Can't you simply replace the CryptMem* functions during debugging with a macro? -- Rob Shearman

3 3

Re: KERNEL: GetTempFileNameW should not require prefix
by Dimi Paun 08 Nov '05

08 Nov '05

> Index: path.c > =================================================================== > RCS file: /home/wine/wine/dlls/kernel/path.c,v > retrieving revision 1.26 > diff -u -r1.26 path.c > --- path.c 8 Nov 2005 11:01:03 -0000 1.26 > +++ path.c 8 Nov 2005 19:54:35 -0000 Please create the diff from the root of th project: $ cvs diff -u dlls/kernel/path.c -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

kernel32/tests thread.ok fails
by Paul Vriens 08 Nov '05

08 Nov '05

Hi, the traces are my doing, but: thread.c:660:test_CreateThread_basic() thread.c:662:test_CreateThread_suspended() thread.c:664:test_SuspendThread() thread.c:666:test_TerminateThread() thread.c:668:test_CreateThread_stack() thread.c:670:test_thread_priority() thread.c:672:test_GetThreadTimes() fixme:thread:NtQueryInformationThread Cannot get kerneltime or usertime of other threads thread.c:674:test_thread_processor() fixme:thread:SetThreadIdealProcessor (0xfffffffe): stub thread.c:676:test_GetThreadExitCode() thread.c:679:test_SetThreadContext() err:seh:EXC_DefaultHandling Unhandled exception code c00000fd flags 0 addr 0xa make: *** [thread.ok] Error 1 this doesn't seem right. Anyone? Cheers, Paul.

1 1

Re: KERNEL: GetTempFileNameW should not require prefix
by James Hawkins 08 Nov '05

08 Nov '05

On 11/8/05, Phil Lodwick <Phil.Lodwick(a)efi.com> wrote: > Hi, > > _tempnam(".", NULL) fails when using the builtin msvcrt.dll. > This is because GetTempFileNameW was requiring a non-NULL prefix. > > This is my first patch submission. Please let me know if I am doing it wrong > as I have more to come. > A test case showing this behavior would be nice. For a small change like this, it's best to send the test case and the fix in one patch. -- James Hawkins

1 0

cvswine can't find files
by Coleman Jeremy D SrA 50 OSS/OSOT1 08 Nov '05

08 Nov '05

I have been trying to use cvswine because it has the d3d9 patches merged. The problem I run into is that for some reason it is unable to find required files (particularly dlls) even when run from within the same directory. I have seen this happen with the following programs so far. Warcraft 3: Can't find Game.dll NFSU Demo: Can't find d3d9.dll Warhammer 40000 Dawn of War Demo: Can't find spd3d9.dll All of these files are present... Warcraft works fine in cedega and wine 0.9. NFSU Demo works in Cedega. Warhammer DoW runs with Cedega. Any help would be greatly appreciated. If I can get cvswine with d3d9 to work, then my $5/mo for Cedega is likely to become a WineHQ paypal donation.

1 0

Regression with icons being black?
by Paul Vriens 08 Nov '05

08 Nov '05

Hi, just started Process Explorer with latest CVS and the icons for the processes are black instead of colorful. I will do some regression testing. Anyone experiencing the same? Cheers, Paul.

3 3

[PATCH] variable number of arguments in macro __ONLY_IN_WINELIB()
by Berend Reitsma 08 Nov '05

08 Nov '05

Hi, With gcc 2.95.4 I am getting a compile error when compiling dlls/mapi32/tests/prop.c because of the use of the FAR keyword: gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o prop.o prop.c prop.c:54: macro `__ONLY_IN_WINELIB' used without args prop.c:55: macro `__ONLY_IN_WINELIB' used without args prop.c:1158: macro `__ONLY_IN_WINELIB' used without args prop.c:1158: macro `__ONLY_IN_WINELIB' used without args prop.c:1159: macro `__ONLY_IN_WINELIB' used without args make: *** [prop.o] Error 1 In include/windef.h the definition of FAR is a call to the macro __ONLY_IN_WINELIB with no arguments. The attached patch changes the definition of the macro to use variable arguments According to some documentation I found on the web this version with __VA_ARGS__ should be compatible with other compilers as well... Regards, Berend Reitsma.

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel