wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: RESEND [wininet]add implementation of few more options
by Dmitry Timoshkov 08 Nov '05

08 Nov '05

"Vijay Kiran Kamuju" infyquest(a)gmail.com wrote: > as previous implementation had some bugs use this version > + case INTERNET_OPTION_VERSION: > { > - if (*lpdwBufferLength < sizeof(HTTP_VERSION_INFO)) > - INTERNET_SetLastError(ERROR_INSUFFICIENT_BUFFER); > + /* > + * Presently hardcoded to 1.2 > + */ > + if(lpBuffer != NULL) > + { > + ((INTERNET_VERSION_INFO*)lpBuffer)->dwMajorVersion = 1; > + ((INTERNET_VERSION_INFO*)lpBuffer)->dwMinorVersion = 2; You still need to check buffer size before filling the buffer. Also using a new variable instead of casting lpBuffer would be much cleaner. Same applies to all cases. > + case INTERNET_OPTION_OFFLINE_MODE: > + case INTERNET_OPTION_OFFLINE_SEMANTICS: > + case INTERNET_OPTION_POLICY: > + case INTERNET_OPTION_RECEIVE_THROUGHPUT: > + case INTERNET_OPTION_SEND_THROUGHPUT: > + WARN("This request is not supported by native either\n"); > + SetLastError(ERROR_NOT_SUPPORTED); > + break; I'd suggest to use FIXME instead of WARN here. It doesn't really matter that current version of miscrosoft's implementation doesn't support them, they may add support for them later, and the apps will start to use them. > + char useragent[] = {'W','i','n','i','n','e','t',' ','T','e','s','t',0 }; char useragent[] = "Wininet Test"; works just fine. > + retval=InternetQueryOptionA(hinet,INTERNET_OPTION_USER_AGENT,NULL,&len); > + err=GetLastError(); Again, checking last error without setting it first to a bogus value. + SetLastError(0); + buffer=HeapAlloc(GetProcessHeap(),0,len+1); + retval=InternetQueryOptionA(hinet,INTERNET_OPTION_USER_AGENT,buffer,&len); + err=GetLastError(); Do not set last error to 0, you then miss the case when API sets it to 0. You don't initialize length variable before calling InternetQueryOption. -- Dmitry.

2 1

Re: [wininet] Add InternetReadFileEx*
by Dmitry Timoshkov 08 Nov '05

08 Nov '05

"Brian Gerst" <bgerst(a)didntduck.org> wrote: > This patch implements the InternetReadFileExA and InternetReadFileExW > functions. I don't know if this completely implements it to MSDN specs > (which are fairly vague), but it is enough to allow World of Warcraft to > read and display the server status message. It would be much better instead of duplicating code implement InternetReadFile via InternetReadFileEx. -- Dmitry.

1 0

Re: [wininet]add implementation of few more options
by Dmitry Timoshkov 08 Nov '05

08 Nov '05

"Vijay Kiran Kamuju" infyquest(a)gmail.com wrote: > + retval=InternetQueryOptionA(hinet,INTERNET_OPTION_USER_AGENT,NULL,&len); > + err=GetLastError(); > + ok(len == strlen(useragent)+1,"Got wrong user agent length %ld len instead of %d\n",len,strlen(useragent)); > + ok(retval == 0,"Got wrong return value %d\n",retval); > + ok(err == ERROR_INSUFFICIENT_BUFFER, "Got wrong error code%ld\n",err); You need to set last error to some bogus value before calling an API in order to make sure that the API really changes it. Usually setting last error to 0xdeadbeef works fine for that purpose. -- Dmitry.

1 0

Re: reenable SPI_{GET,SET}BORDER tests and make them pass on wine
by Alexandre Julliard 08 Nov '05

08 Nov '05

Rein Klazes <wijn(a)wanadoo.nl> writes: > source file; > - made the tests pass on wine: > - - non client metric value of iBorderWidth initialized correctly; > - - SPI_SETBORDER updates non client metrics; > - - SPI_SETNONCLIENTMETRICS may save border width value to registry; > - - borderwidth has a minimum value of 1. The tests fail here: sysparams.c:157: Test failed: Missed a message: change_counter=0 sysparams.c:160: Test failed: Wrong action got 0 expected 47 sysparams.c:157: Test failed: Missed a message: change_counter=0 sysparams.c:160: Test failed: Wrong action got 0 expected 47 -- Alexandre Julliard julliard(a)winehq.org

1 0

Help exterminate Solaris issues
by Robert Lunnon 08 Nov '05

08 Nov '05

Could I suggest where someone adds #ifdefs for linux, bsd, etc such as in the recent GlobalMemoryStatusEx issue I just fixed, that the original authors include an #else clause which raises a warning to alert us poor Solaris (and other OS) maintainers to the fact we have to do something. In the meantime I might have to search for OS specific things not flagged with warnings or fixmes.. Thanks Bob

1 0

DirectDrawEnumerateExW calls DirectDrawEnumerateExA
by Saulius Krasuckas 08 Nov '05

08 Nov '05

DirectDrawEnumerateExW (dlls/ddraw/main.c) calls DirectDrawEnumerateExA, which uses ddraw_driver struct (dlls/ddraw/ddraw_private.h), which has a member DDDEVICEIDENTIFIER2 struct (include/ddraw.h), which is defined this way: typedef struct tagDDDEVICEIDENTIFIER2 { char szDriver[MAX_DDDEVICEID_STRING]; char szDescription[MAX_DDDEVICEID_STRING]; LARGE_INTEGER liDriverVersion; DWORD dwVendorId; DWORD dwDeviceId; DWORD dwSubSysId; DWORD dwRevision; GUID guidDeviceIdentifier; DWORD dwWHQLLevel; } DDDEVICEIDENTIFIER2, * LPDDDEVICEIDENTIFIER2; As this struct keeps base information about a driver and it uses char strings, I guess %Subject% cross call should be marked invalid in the wiki. Right?

5 9

Regression in patch 21129
by Michael Jung 08 Nov '05

08 Nov '05

Hi, The patch http://cvs.winehq.org/patch.py?id=21129 caused a regression, which shows in emule's options dialog (v0.46c). I've attached screenshots. A number of "err:imagelist:ImageList_ReplaceIcon no color!" messages are given on the console. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Question about contents of STARTUPINFO structure and non WinMain entry points
by James Liggett 08 Nov '05

08 Nov '05

Hi, First, apologies for the length. It's quite a complex issue: A few days ago someone sent to the list asking why a program he'd written on WinXP runs under WineDbg but not under plain wine. Over the weekend I debugged the program and found out that his program doesn't use the standard WinMain entrypoint function. As such, he was using GetStartupInfo to get startup flags. He uses the wShowWindow flag to control the showing of the program's main window. Trouble is, this value is zero unless the program is started as a child process using CreateProcess, given a STARTUPINFO with wShowWindow set to something other than 0 (usually SW_SHOWNORMAL or SW_SHOW.) So my question is, how does the information in STARTUPINFO get set initially? I looked through the code for winecrt0 and found that before WinMain is called, the wShowWindow flag is set to SW_SHOWNORMAL. But because this program does not use WinMain, this value doesn't get set. However, the program works fine on native Windows XP. I looked at ntdll and kernel32 dll code, but I'm not sure I'm looking in the right place. Can someone give me some hints as to how to attack this problem? Thanks a lot, James

1 0

Re: [wininet]add implementation of few more options
by Dmitry Timoshkov 08 Nov '05

08 Nov '05

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > ChangeLog > ---------------- > Added implementation for INTERNET_OPTION_VERSION > Added implementation for INTERNET_OPTION_USER_AGENT > Fixed behavior for INTERNET_OPTION_HTTP_VERSION > Added implementation for unsupported options Look like it lacks a test case. -- Dmitry.

2 1

kernel/comm.c - page fault in thread
by Mr Cihan ALTINAY 08 Nov '05

08 Nov '05

Hi, I finally got G-Ware to work flawlessly under wine after some tweaks in the comm.c file. One problem was in the (thread) function COMM_WaitCommEventService(). When I 'disconnect' in the client program it calls purge and sets the event mask to 0 (ie. it is no longer interested in events from the port). But there are still threads running that poll the port. The program crashes when the thread exits the loop (with abort!=0) and tries to set *commio->buffer = rc; (line 2010) but this buffer is already freed by the client. Replacing if (abort) rc = 0; *commio->buffer = rc; by if (!abort) *commio->buffer = rc; fixes this problem. There were other communication errors which I managed to fix but I have to find out first which changes are really necessary to make things work because I tried a lot of things in comm.c. It looks as if there are race conditions when more than one polling thread is running. Currently I check if a thread is already running and don't start a second one if so. But I will find out if that is responsible for the errors or something else and report it on the list. Cheers, Cihan

1 0

DirectX 8 wrapper for wined3d
by Oliver Stieber 07 Nov '05

07 Nov '05

Hi, I've put together a Direct3D 8 wrapper for wined3d which should hopefully replace the current Direct3D 8 code. The patch needs a little bit of tidying, some work of vertex declarations and a hell of a lot of testing before it can go into Wine. So far I've tested Rail Road Tycoon 3, Celebrity Death match, Madden NFL 2004 all the d3d8 demos from http://www.codesampler.com, a few more games I can't remember at the moment and everything's seems to be working as good as or better than the current Direct3D 8 code. I would be greatfull if anyone with DirectX 8 games or applications that currently work or they would like to get working could test the patch and report back any errors they come across. The patch is against Wine cvs 2005-11-05 and can be downloaded from https://sourceforge.net/project/shownotes.php?release_id=368929 for the time being. Oliver. ___________________________________________________________ How much free photo storage do you get? Store your holiday snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com

7 13

DirectSound, new patch available for testing
by Juergen Wieczorek 07 Nov '05

07 Nov '05

Dear Davin, in the past days I have been testing your 'old' patch with wine-0.9 on my Fedora Core 3 system (kernel-2.6.12-.1381_FC3, alsa-lib-1.0.6-8.FC3, Soundblaster Live PCI = emu10k1), using Diablo2-LoD (patch 1.11b - 3DSound = no) Now I have also tried your new patch. Outcome in short : sound output got worse for me with the new patch. Outcome in detail (for ALSA): A)Old patch - DirectSound settings: 1)EmulDriver=N, HardwareAcceleration=Emulation Blizzard Intro = flawless Game Intro = flawless Game Sound = altogether fluently, some sounds start to miss when in thick melee 2)EmulDriver=N, HardwareAcceleration=Basic/Standard/Full Blizzard Intro = completely jarred Game Intro = with jerks Game Sound = jarred and jerky with large sound holes(dead sound) B)New patch - DirectSound settings: 1)EmulDriver=N, HardwareAcceleration=Emulation Blizzard Intro = flawless Game Intro = flawless Game Sound = persistent audible crackling 2)EmulDriver=N, HardwareAcceleration=Basic/Standard/Full Blizzard Intro = some audible jerks Game Intro = flawless Game Sound = persistent audible crackling The new patch seems to produce less console output of "err:dsound:DSOUND_PhaseCancel length not a multiple of block size" than the old patch and "len" seems to be of shorter size. I have counterchecked with the unpatched wine-0.9 and it is almost the same performance as with the 'new' patch, only that the Blizzard Intro runs flawlessly all the time, no matter what setting I choose for HardwareAcceleration. Hope this helps. -- Juergen Wieczorek Hamburg / Germany

2 1

Error in wine's implementation of msvcrt
by David D. Hagood 07 Nov '05

07 Nov '05

There seems to be some form of error in the Wine implementation of MSVCRT - with three separate programs (Delorme MapNGo 6.0, Delorme Street Atlas 5, Microsoft Trip Planner 5), if I use Wine's builtin MSVCRT, the programs do not work, but if I use the version of MSVCRT the program supplies, they work. I don't know much about what is going on, but I do know this: With the Wine MSVCRT, the Delorme packages err trying to load a "vector font" file that is supplied with the Delorme programs. This font file is read by a DLL supplied by Delorme, and is a simple text file describing some of the icons they use in their program (like a house, or a car, etc.). Tracing the operation of the Wine MSVCRT shows that the whole file is read by the DLL, and the DLL does not throw the error until EOF. I conjecture that there is some difference in behavior between the Wine MSVCRT on EOF and Microsoft's MSVCRT - what I have no idea. OK, so anybody have any good idea on how I can get more information on this?

4 6

Segmentation Fault in wine cvs after 0.9
by zhilla 07 Nov '05

07 Nov '05

before submitting this as bug, some advice please... on slackware 10.2 (gcc 3.3.6) i compile wine cvs, and it has worked so far. last version working is around or exactly 0.9. now, it compiles/installs fine, but any program, including starting just "wine", "notepad" or anything else, ends up quickly with "Segmentation fault". this is my simple custom buildscript... PKGDATE=`date +%Y%m%d` && CHOST="i686-pc-linux-gnu" \ CFLAGS="-march=athlon-xp -O2 -pipe -fomit-frame-pointer -m3dnow -msse -mmmx" \ CXXFLAGS=$CFLAGS \ ./configure \ --disable-debug && \ make && make depend && \ checkinstall -S --pkgname=wine --pkgarch=athlonxp --pkgversion=$PKGDATE -y also, tried removing ~/.wine and creating new one, it starts automatic configure but compiled wine also segfaults. then, changed processor optimizations to much more conservative "-O2 -march=i486 -mcpu=i686" and it it works like a charm. athlon-xp optimizatins used in the first place are from http://gentoo-wiki.com/Safe_Cflags . if gentoo people claim these are safe cflags, and it worked until couple days ago, then something is definetly wrong, right?

7 15

Re: [d3d9] allow NULL ppQuery to be passed to CreateQuery
by Alexandre Julliard 07 Nov '05

07 Nov '05

Oliver Stieber <oliver_stieber(a)yahoo.co.uk> writes: > @@ -142,9 +142,10 @@ > FIXME("(%p) call to IWineD3DDevice_CreateQuery failed\n", This); > HeapFree(GetProcessHeap(), 0, object); > *ppQuery = NULL; > - } else { > + } else if (ppQuery != NULL) { > *ppQuery = (LPDIRECT3DQUERY9) object; > } That doesn't look right. Who's going to free the object if you don't return it? -- Alexandre Julliard julliard(a)winehq.org

1 0

The time of miracles...
by Molle Bestefich 07 Nov '05

07 Nov '05

... has not yet passed, it seems! Lo and behold, I managed to get Trillian to work past the splash screen. A bit early for a christmas miracle, but there it is :-). This is, as far as I know, the first time anyone has gotten Trillian to run with Wine CVS since late 2004. That's about two years for you. It also marks another historic event: This is the first time in my life that I've ever rejoiced upon hearing one of those lame application startup sounds ;-). This is the diff against wine 0.9: Index: dlls/user/winpos.c =================================================================== --- dlls/user/winpos.c (revision 23257) +++ dlls/user/winpos.c (working copy) @@ -808,9 +808,14 @@ MinMax.ptMaxTrackSize.y = max( MinMax.ptMaxTrackSize.y, MinMax.ptMinTrackSize.y ); + return; + // commenting next line out WILL fix Trillian. if (maxSize) *maxSize = MinMax.ptMaxSize; + // commenting next line out doesn't fix. if (maxPos) *maxPos = MinMax.ptMaxPosition; + // commenting next line out WILL fix Trillian. if (minTrack) *minTrack = MinMax.ptMinTrackSize; + // commenting next line out doesn't fix. if (maxTrack) *maxTrack = MinMax.ptMaxTrackSize; } The patch (also attached btw) should be self explanatory. Basically it just returns a bit earlier in WINPOS_GetMinMaxInfo. Obviously, WINPOS_GetMinMaxInfo is fucked, but I'm not sure how or why. I'd like it if any of the experts could step in here, so we can: * close bug 2658 and * open a new one about why the contact list window stays hidden ;). Questions (please help!): 1. Is it correct to just stop mucking about with the application's 4 variables as done above? Will that break other things? 2. How can I test the behaviour on Windows? (I've finally gotten VMWare to run on 2.6.14 - joy =))

2 3

Re: msxml: remove a few guids
by Huw D M Davies 07 Nov '05

07 Nov '05

On Mon, Nov 07, 2005 at 12:31:32PM +0000, Huw D M Davies wrote: > Huw Davies <huw(a)codeweavers.com> > Remove a couple of unnecessary guids. Actually could you ignore this for the time being. The guids are needed to get the crosstests to build as mingw lacks these in its libuuid.a Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Bugzilla
by Molle Bestefich 07 Nov '05

07 Nov '05

=============== Not allowed You tried to change the short_desc field from err:clipping:CLIPPING_UpdateGCRegion hVisRgn is zero. Please report this. to Trillian loops infinitely in splash screen, but only the owner or submitter of the bug, or a sufficiently empowered user, may change that field. Please press Back and try again. =============== Could I please be granted privileges to change the subject line on that bug (2658)? The current one: * doesn't describe the problem very well * doesn't relate to the original description

2 2

DirectSound, new patch available for testing
by Davin McCall 07 Nov '05

07 Nov '05

To all those who tested my previous patch, thanks. I have a new patch which may help to resolve some of the (few) issues which cropped up. The "length not a multiple of block size" issue has been partially addressed. Also, buffer underruns should be far less frequent than the previous patch if direct hardware access is used (set registry key \\HKEY_CURRENT_USER\Software\Wine\Alsa Driver\UseDirectHW to "y"). I'll leave this for a few days and if there are no reports of breakages I'll send it (as two seperate patches) to wine-patches. Davin

3 9

Re: Korean resource files
by Mike McCormack 07 Nov '05

07 Nov '05

황윤성 wrote: > ./wine/ > ./wine/programs/ > ./wine/programs/wcmd/ > ./wine/programs/wcmd/Ko.rc 황윤성씨, 안녕하세요! Thanks for the contribution. Please only add Korean resource files when you have translated the contents into Korean. Wine will fall back to using the English resources by default. When you submit a new translation, please use diff -u /dev/null to generate the diff, something like this: diff -u /dev/null programs/wcmd/Ko.rc > wcmd-ko.diff thanks, Mike

1 0

[wined3d] prevent outof range lookup in DrawStridedSlow - 2
by Oliver Stieber 07 Nov '05

07 Nov '05

--- Oliver Stieber <oliver_stieber(a)yahoo.co.uk> wrote: The if (coordIdx > 15) warning is incorrect as generated coordinates can have coordIdx > s that are much higher, this can be verified by running the fr-025-final2 demo (http://www.scene.org/file.php?file=/demos/groups/farb-rausch/fr-025-final2.…) The attached patch has the (coordIdx > 15) removed. Oliver. > Hi. > > This patch verify that the texture coordinate used in DrawStridedSlow is in > range before trying to referencing the associated data. > > > Oliver. > > > > ___________________________________________________________ > How much free photo storage do you get? Store your holiday > snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com> Files clean/wine/dlls/wined3d/.device.c.swp and smallpatches/wine/dlls/wined3d/.device.c.swp > differ > diff -X ignore -Nru clean/wine/dlls/wined3d/drawprim.c smallpatches/wine/dlls/wined3d/drawprim.c > --- clean/wine/dlls/wined3d/drawprim.c 2005-10-12 14:14:29.524975000 +0100 > +++ smallpatches/wine/dlls/wined3d/drawprim.c 2005-11-06 23:51:35.664707408 +0000 > @@ -1317,13 +1317,22 @@ > if (This->stateBlock->textures[textureNo] != NULL) { > > int coordIdx = > This->stateBlock->textureState[textureNo][D3DTSS_TEXCOORDINDEX]; > - float *ptrToCoords = (float *)(sd->u.s.texCoords[coordIdx].lpData + > (SkipnStrides * sd->u.s.texCoords[coordIdx].dwStride)); > + float *ptrToCoords = NULL; > float s = 0.0, t = 0.0, r = 0.0, q = 0.0; > > if (coordIdx > 7) { > VTRACE(("tex: %d - Skip tex coords, as being system generated\n", > textureNo)); > + if (coordIdx > 15) { > + FIXME("tex: %d - Unexpectdly high texture coord index %d, expect a > crash.\n", textureNo, coordIdx); > + } > + continue; > + } else if (coordIdx < 0) { > + FIXME("tex: %d - Coord index %d is less than zero, expect a crash.\n", > textureNo, coordIdx); > continue; > - } else if (sd->u.s.texCoords[coordIdx].lpData == NULL) { > + } > + > + ptrToCoords = (float *)(sd->u.s.texCoords[coordIdx].lpData + (SkipnStrides * > sd->u.s.texCoords[coordIdx].dwStride)); > + if (sd->u.s.texCoords[coordIdx].lpData == NULL) { > TRACE("tex: %d - Skipping tex coords, as no data supplied\n", textureNo); > continue; > } else { > > > ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com

1 0

WINE Regression due to patch 18110: Font size issues in MS Word dropdowns
by Arren Lex 07 Nov '05

07 Nov '05

This is a NON-FATAL, merely cosmetic regression. The application in question still functions. I have just finished regression testing WINE according to these instructions: http://www.winehq.com/site/docs/winedev-guide/x1344 In Microsoft Word 2000, in WINE prior to Monday, June 13, 2005, 05:01:32 CDT, when you moved your mouse over the dropdown boxes in the standard toolbar which allow you to select font size, font face, etc. the boxes become embossed like they're supposed to. However, after patch 18110 was applied, all that happens when you mouse over these boxes is that the text suddenly gains several sizes and cuts off at the first letter, makes the box either inconvenient or entirely unusable. The patch that caused this problem is the following: http://cvs.winehq.org/patch.py?id=18110 An image illustrating this process is below: http://img.photobucket.com/albums/v11/arrenlex/wineexamples.png Is it possible to fix this annoying regression? Thank you for your time! _________________________________________________________________ Designer Mail isn't just fun to send, it's fun to receive. Use special stationery, fonts and colors. http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht… Start enjoying all the benefits of MSN® Premium right now and get the first two months FREE*.

3 3

winedbg and ddd/kdbg problem...
by Markus G�mmel 06 Nov '05

06 Nov '05

Hi, I'm coming from Windows, so a graphical debugging system is needed :-) I'm trying to connect winedbg to ddd as described in the docu, but the following error occured during startup: wine-pthread: gdbproxy.c:1984: extract_packets: Assertion 'i == gdbctx->out_len' failed. Same happens when I try to connect to kdbg... Any ideas? Thanks Markus Goemmel m.goemmel(a)compulab.de

3 5

What to do when X11DRV_DIB_BuildColorMap is called with more than 256 colors?
by David D. Hagood 06 Nov '05

06 Nov '05

I have an old copy of Microsoft's Trip Planner 5 software that I was trying to get to run. When I try to plan a trip, the program will draw the map fine, then it attempts to draw the dialog for setting up the trip data. At this point, the app calls X11DRV_DIB_BuildColorMap with a bmiHeader.biClrUsed count of 257. Now, if I remove the code within X11DRV_DIB_BuildColorMap that checks for colors > 256, the code makes it past this point. It dies much later, after I have entered the start point of the journey. So, now what? Is there a shortcoming within BuildColorMap, or is some other code misleading the app? How do I go about debugging this?

1 0

New call needed in netapi32 (DsRoleGetPrimaryDomainInformation)
by Paul Vriens 06 Nov '05

06 Nov '05

Hi, one of the crashes I have in Process Explorer is due to a unimplemented function DsRoleGetPrimaryDomainInformation. There is no Ds-related stuff yet in netapi32. I assume a new file is needed, but how do I name it: - ds.c - ads.c - ? do we have any name-convention for new files ? I guess a new debug-channel is needed as well with the same question about naming. Cheers, Paul.

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel