wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: [wined3d] D3DCOLOR fixup begin
by Oliver Stieber 03 Nov '05

03 Nov '05

--- Raphael <fenix(a)club-internet.fr> wrote: > Hi, > > Changelog: > - defined D3DCOLOR_B macros to access byte values of D3DCOLOR > - use D3DCOLOR macros instead of using shift + masks > - fix a bug where diffuse.lpData checked instead of specular.lpData > - implement color fixup on ARB VShader compilation code: > -> on input parameters using swizzle > -> add is_color parameter on vshader_program_add_param > The input swizzel needs to be an output swizzel because it should be possible to use anything to generate a colour for output and not just the input colours, that should also get around the is_colour problem. > Todo: > - check shader declaration while compiling VShader to value is_color > parameter (Oliver have you an idea how to do that ?) > - implement a fixup code for drawPrimitiveSlow and VBO unlock I've got some fixup code to go in so that drawStridedSlow doesn't have to be used. Oliver. > > Regards, > Raphael > > ? wined3d.dll.dbg.c > ? wined3d.spec.def > Index: device.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/device.c,v > retrieving revision 1.91 > diff -u -r1.91 device.c > --- device.c 2 Nov 2005 20:01:54 -0000 1.91 > +++ device.c 2 Nov 2005 23:11:55 -0000 > @@ -4598,10 +4598,10 @@ > if (Flags & D3DCLEAR_TARGET) { > TRACE("Clearing screen with glClear to color %lx\n", Color); > glGetFloatv(GL_COLOR_CLEAR_VALUE, old_color_clear_value); > - glClearColor(((Color >> 16) & 0xFF) / 255.0f, > - ((Color >> 8) & 0xFF) / 255.0f, > - ((Color >> 0) & 0xFF) / 255.0f, > - ((Color >> 24) & 0xFF) / 255.0f); > + glClearColor(D3DCOLOR_R(Color), > + D3DCOLOR_G(Color), > + D3DCOLOR_B(Color), > + D3DCOLOR_A(Color)); > checkGLcall("glClearColor"); > > /* Clear ALL colors! */ > Index: drawprim.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/drawprim.c,v > retrieving revision 1.31 > diff -u -r1.31 drawprim.c > --- drawprim.c 11 Oct 2005 20:27:54 -0000 1.31 > +++ drawprim.c 2 Nov 2005 23:11:56 -0000 > @@ -1410,30 +1410,30 @@ > > /* Diffuse -------------------------------- */ > if (sd->u.s.diffuse.lpData != NULL) { > - glColor4ub((diffuseColor >> 16) & 0xFF, > - (diffuseColor >> 8) & 0xFF, > - (diffuseColor >> 0) & 0xFF, > - (diffuseColor >> 24) & 0xFF); > - VTRACE(("glColor4f: r,g,b,a=%f,%f,%f,%f\n", > - ((diffuseColor >> 16) & 0xFF) / 255.0f, > - ((diffuseColor >> 8) & 0xFF) / 255.0f, > - ((diffuseColor >> 0) & 0xFF) / 255.0f, > - ((diffuseColor >> 24) & 0xFF) / 255.0f)); > + glColor4ub(D3DCOLOR_B_R(diffuseColor), > + D3DCOLOR_B_G(diffuseColor), > + D3DCOLOR_B_B(diffuseColor), > + D3DCOLOR_B_A(diffuseColor)); > + VTRACE(("glColor4ub: r,g,b,a=%u,%u,%u,%u\n", > + D3DCOLOR_B_R(diffuseColor), > + D3DCOLOR_B_G(diffuseColor), > + D3DCOLOR_B_B(diffuseColor), > + D3DCOLOR_B_A(diffuseColor))); > } else { > if (vx_index == 0) glColor4f(1.0f, 1.0f, 1.0f, 1.0f); > } > > /* Specular ------------------------------- */ > - if (sd->u.s.diffuse.lpData != NULL) { > - VTRACE(("glSecondaryColor4ub: r,g,b=%f,%f,%f\n", > - ((specularColor >> 16) & 0xFF) / 255.0f, > - ((specularColor >> 8) & 0xFF) / 255.0f, > - ((specularColor >> 0) & 0xFF) / 255.0f)); > + if (sd->u.s.specular.lpData != NULL) { > + VTRACE(("glSecondaryColor4ub: r,g,b=%u,%u,%u\n", > + D3DCOLOR_B_R(specularColor), > + D3DCOLOR_B_G(specularColor), > + D3DCOLOR_B_B(specularColor))); > if (GL_SUPPORT(EXT_SECONDARY_COLOR)) { > GL_EXTCALL(glSecondaryColor3ubEXT)( > - (specularColor >> 16) & 0xFF, > - (specularColor >> 8) & 0xFF, > - (specularColor >> 0) & 0xFF); > + D3DCOLOR_B_R(specularColor), > + D3DCOLOR_B_G(specularColor), > + D3DCOLOR_B_B(specularColor)); > } else { > /* Do not worry if specular colour missing and disable request */ > VTRACE(("Specular color extensions not supplied\n")); > Index: vertexshader.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/vertexshader.c,v > retrieving revision 1.14 > diff -u -r1.14 vertexshader.c > --- vertexshader.c 27 Oct 2005 10:23:53 -0000 1.14 > +++ vertexshader.c 2 Nov 2005 23:11:57 -0000 > @@ -887,10 +887,70 @@ > return D3DSIO_COMMENT == (token & D3DSI_OPCODE_MASK); > } > > -inline static void vshader_program_add_param(const DWORD param, int input, char *hwLine, BOOL > namedArrays, CHAR constantsUsedBitmap[]) { > +inline static void vshader_program_add_output_param_swizzle(const DWORD param, int is_color, > char *hwLine) { > + /** operand output */ > + if ((param & D3DSP_WRITEMASK_ALL) != D3DSP_WRITEMASK_ALL) { > + strcat(hwLine, "."); > + if (param & D3DSP_WRITEMASK_0) { strcat(hwLine, "x"); } > + if (param & D3DSP_WRITEMASK_1) { strcat(hwLine, "y"); } > + if (param & D3DSP_WRITEMASK_2) { strcat(hwLine, "z"); } > + if (param & D3DSP_WRITEMASK_3) { strcat(hwLine, "w"); } > + } > +} > + > +inline static void vshader_program_add_input_param_swizzle(const DWORD param, int is_color, > char *hwLine) { > + static const char swizzle_reg_chars_color_fix[] = "zyxw"; > + static const char swizzle_reg_chars[] = "xyzw"; > + const char* swizzle_regs = NULL; > + char tmpReg[255]; > + > + /** operand input */ > + DWORD swizzle = (param & D3DVS_SWIZZLE_MASK) >> D3DVS_SWIZZLE_SHIFT; > + DWORD swizzle_x = swizzle & 0x03; > + DWORD swizzle_y = (swizzle >> 2) & 0x03; > + DWORD swizzle_z = (swizzle >> 4) & 0x03; > + DWORD swizzle_w = (swizzle >> 6) & 0x03; > + > + if (is_color) { > + swizzle_regs = swizzle_reg_chars_color_fix; > + } else { > + swizzle_regs = swizzle_reg_chars; > + } > + > + /** > + * swizzle bits fields: > + * WWZZYYXX > + */ > + if ((D3DVS_NOSWIZZLE >> D3DVS_SWIZZLE_SHIFT) == swizzle) { /* D3DVS_NOSWIZZLE == 0xE4 << > D3DVS_SWIZZLE_SHIFT */ > + if (is_color) { > + sprintf(tmpReg, ".%c%c%c%c", > + swizzle_regs[swizzle_x], > + swizzle_regs[swizzle_y], > + swizzle_regs[swizzle_z], > + swizzle_regs[swizzle_w]); > + strcat(hwLine, tmpReg); > + } > + return ; > + } > + if (swizzle_x == swizzle_y && > + swizzle_x == swizzle_z && > + swizzle_x == swizzle_w) > + { > + sprintf(tmpReg, ".%c", swizzle_regs[swizzle_x]); > + strcat(hwLine, tmpReg); > + } else { > + sprintf(tmpReg, ".%c%c%c%c", > + swizzle_regs[swizzle_x], > + swizzle_regs[swizzle_y], > + swizzle_regs[swizzle_z], > + swizzle_regs[swizzle_w]); > + strcat(hwLine, tmpReg); > + } > +} > + > +inline static void vshader_program_add_param(const DWORD param, int input, int is_color, char > *hwLine, BOOL namedArrays, CHAR constantsUsedBitmap[]) { > /*static const char* rastout_reg_names[] = { "oPos", "oFog", "oPts" }; */ > static const char* hwrastout_reg_names[] = { "result.position", "result.fogcoord", > "result.pointsize" }; > - static const char swizzle_reg_chars[] = "xyzw"; > > DWORD reg = param & 0x00001FFF; > DWORD regtype = ((param & D3DSP_REGTYPE_MASK) >> D3DSP_REGTYPE_SHIFT); > @@ -954,49 +1014,9 @@ > } > > if (!input) { > - /** operand output */ > - if ((param & D3DSP_WRITEMASK_ALL) != D3DSP_WRITEMASK_ALL) { > - strcat(hwLine, "."); > - if (param & D3DSP_WRITEMASK_0) { > - strcat(hwLine, "x"); > - } > - if (param & D3DSP_WRITEMASK_1) { > - strcat(hwLine, "y"); > - } > - if (param & D3DSP_WRITEMASK_2) { > - strcat(hwLine, "z"); > - } > - if (param & D3DSP_WRITEMASK_3) { > - strcat(hwLine, "w"); > - } > - } > + vshader_program_add_output_param_swizzle(param, is_color, hwLine); > } else { > - /** operand input */ > - DWORD swizzle = (param & D3DVS_SWIZZLE_MASK) >> D3DVS_SWIZZLE_SHIFT; > - DWORD swizzle_x = swizzle & 0x03; > - DWORD swizzle_y = (swizzle >> 2) & 0x03; > - DWORD swizzle_z = (swizzle >> 4) & 0x03; > - DWORD swizzle_w = (swizzle >> 6) & 0x03; > - /** > - * swizzle bits fields: > - * WWZZYYXX > - */ > - if ((D3DVS_NOSWIZZLE >> D3DVS_SWIZZLE_SHIFT) != swizzle) { /* ! D3DVS_NOSWIZZLE == 0xE4 << > D3DVS_SWIZZLE_SHIFT */ > - if (swizzle_x == swizzle_y && > - swizzle_x == swizzle_z && > - swizzle_x == swizzle_w) > - { > - sprintf(tmpReg, ".%c", swizzle_reg_chars[swizzle_x]); > - strcat(hwLine, tmpReg); > - } else { > - sprintf(tmpReg, ".%c%c%c%c", > - swizzle_reg_chars[swizzle_x], > - swizzle_reg_chars[swizzle_y], > - swizzle_reg_chars[swizzle_z], > - swizzle_reg_chars[swizzle_w]); > - strcat(hwLine, tmpReg); > - } > - } > + vshader_program_add_input_param_swizzle(param, is_color, hwLine); > } > } > > @@ -1540,7 +1560,7 @@ > char tmpChar[80]; > ++pToken; > sprintf(tmpLine, "ATTRIB "); > - vshader_program_add_param(*pToken, 0, tmpLine, This->namedArrays, > This->constantsUsedBitmap); > + vshader_program_add_param(*pToken, 0, 0, tmpLine, This->namedArrays, > This->constantsUsedBitmap); > sprintf(tmpChar," = %s", attribName); > strcat(tmpLine, tmpChar); > strcat(tmpLine,";\n"); > @@ -1592,12 +1612,12 @@ > } > } > if (curOpcode->num_params > 0) { > - vshader_program_add_param(*pToken, 0, tmpLine, This->namedArrays, > This->constantsUsedBitmap); > + vshader_program_add_param(*pToken, 0, 0, tmpLine, This->namedArrays, > This->constantsUsedBitmap); > > ++pToken; > for (i = 1; i < curOpcode->num_params; ++i) { > strcat(tmpLine, ","); > - vshader_program_add_param(*pToken, 1, tmpLine, This->namedArrays, > This->constantsUsedBitmap); > + vshader_program_add_param(*pToken, 1, 0, tmpLine, This->namedArrays, > This->constantsUsedBitmap); > ++pToken; > } > } > Index: wined3d_private.h > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/wined3d_private.h,v > retrieving revision 1.67 > diff -u -r1.67 wined3d_private.h > --- wined3d_private.h 29 Oct 2005 10:30:36 -0000 1.67 > +++ wined3d_private.h 2 Nov 2005 23:11:57 -0000 > @@ -161,6 +161,11 @@ > #define GL_EXTCALL(FuncName) (GLINFO_LOCATION.FuncName) > #define GL_VEND(_VendName) (GLINFO_LOCATION.gl_vendor == VENDOR_##_VendName ? TRUE : > FALSE) > > +#define D3DCOLOR_B_R(dw) (((dw) >> 16) & 0xFF) > +#define D3DCOLOR_B_G(dw) (((dw) >> 8) & 0xFF) > +#define D3DCOLOR_B_B(dw) (((dw) >> 0) & 0xFF) > +#define D3DCOLOR_B_A(dw) (((dw) >> 24) & 0xFF) > + > #define D3DCOLOR_R(dw) (((float) (((dw) >> 16) & 0xFF)) / 255.0f) > #define D3DCOLOR_G(dw) (((float) (((dw) >> 8) & 0xFF)) / 255.0f) > #define D3DCOLOR_B(dw) (((float) (((dw) >> 0) & 0xFF)) / 255.0f) > > > ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com

1 0

Re: [Resend] printer dialog fixes part1 + french + other rcs
by Andreas Mohr 03 Nov '05

03 Nov '05

Hi, On Thu, Nov 03, 2005 at 12:02:21PM +0100, Jonathan Ernst wrote: > Try2:This time, we just tell the user he needs to install a printer (we don't let him install one from Wine as it is not (won't ever?) be implemented). You really should have written: ...install a printer... *on your system.* Otherwise many of such people will fiddle with Windows printer drivers for hours completely in vain. Andreas

3 5

Re: kernel/comm.c: Don't leak file handles
by Paul Vriens 03 Nov '05

03 Nov '05

On Thu, 2005-11-03 at 10:55 +0100, Uwe Bonnes wrote: > Changelog: > dlls/kernel/comm.c: COMM_WaitCommEvent > Release the file handle when creating thread > > Spotted by Cihan Altinay, also fixes then problem with pending characters in > our comm-test when TXD-RXD loopback is enabled. Hi Uwe, you forgot the patch :-). Cheers, Paul.

1 0

dlls/kernel/comm.c: not releasing file descriptors?
by Cihan Altinay 03 Nov '05

03 Nov '05

Hi, I am trying to get G-Ware[1] to run under wine which provides a user interface to set up Echo Canceller Units made by ClearOne. The unit is connected to the serial port (com1 = ttyS0). The only way I can start the program at all is by configuring wine to act as Windows 95/98 and using native COM dll's. Furthermore, 'GWare.exe' starts 'PSRServe.exe' under native Windows but not under wine so I do the following in a bash file: wine C:\\Program\ Files\\G-Ware\\PSRServe.exe & wine C:\\Program\ Files\\G-Ware\\GWare.exe When I connect to the device I get endless fixme:comm:COMM_WaitCommEvent EV_RXFLAG not handled messages before communication breaks with this: wine client error:3bc: pipe: Too many open files After investigating I found out that indeed the number of open pipes to ttyS0 increases statically so I tried to find the reason and suspect the following (using the CVS checkout from 20051102): In the function COMM_WaitCommEvent in /dlls/kernel/comm.c line 2106 a thread is created for WaitCommEventService. However, in this branch of the if-statement fd is not released (using release_comm_fd). Releasing fd seems to work and the number of open pipes don't get past 200-300. I am new to wine development and this is just a guess and I might be totally wrong. Unfortunately this does not fix the communication with the device (It reports timeouts and errors retrieving values etc). I guess this has to do with the first fixme messages I mentioned. Can anybody tell me what EV_RXFLAG is used for? Using WINEDEBUG=+tid,+comm I compared the output to what Sysinternals PortMon[2] gives me on native Windows and it really looks promising. Is there a way to display the actual data that was sent/received through the serial port? I tried WINEDEBUG=+io which does not work. The program uses threads so there might as well be other issues. Cheers, Cihan --- [1] http://www.clearone.com/docs/downloads/G-Ware5.0.6.zip (20MB) [2] http://www.sysinternals.com/Utilities/Portmon.html

2 1

Re:DirectSound, new patch available for testing
by Robbert Xerox 03 Nov '05

03 Nov '05

Hi Davin,Two questions about this: the patch fails here at hunk 5 with current cvs. 2nd question: is creating the key \HKEY_CURRENT_USER\Software\Wine\Alsa Driver\UseDirectHW necessary? If so, i'll have to do that manually (in regedit) i guess, as winecfg does not create such a key anywhere. And is this some undocumented key that also has some effects without your patch? thanks in advance for your answer. ___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

4 3

Re: SHELL32: some fixes for shelllink's IContextMenu::InvokeCommand method
by Martin Fuchs 03 Nov '05

03 Nov '05

Hello Mike, On 03.11.2005 07:24:42 Mike McCormack wrote: > ChangeLog: > Pass the correct verb. > Add a space between extra parameters. > Wait for ShellExecute to complete. [...] > if( ShellExecuteExW( &sei ) ) >+ { >+ if (sei.hProcess) >+ WaitForSingleObject(sei.hProcess, 10000); > r = S_OK; >+ } > else > r = E_FAIL; You should add an "CloseHandle(sei.hProcess);" after the wait call to avoid the handle leak. Regards, Martin

1 0

RE: alt-tab task switching form a wine app
by Anthony R. Tuel 03 Nov '05

03 Nov '05

-----Original Message----- From: Robert Shearman [mailto:rob@codeweavers.com] Sent: Wed 11/2/2005 12:43 PM To: Anthony R. Tuel Cc: wine-devel(a)winehq.org Subject: Re: alt-tab task switching form a wine app Anthony R. Tuel wrote: > It seems when I have an app up running under wine (lotus notes 6.5.4 > in my case) and I switch to another app (using a gaim messaging window > in my case) using alt tab, when I come back to my notes window its as > if I'm still holding the alt key. Not sure if this happens in other > apps, but its really noticible in notes since it uses the alt key for > all sorts of keyboard shortcuts. So if i'm writing a new email in > notes, someone sends me an IM, I alt-tab switch over to gaim, when I > switch back to notes and want to hit enter for a new line, it brings > up the font properties windows (alt+enter being the font properties > shortcut). This seems to happen with both 20050930 and the .9 > releases at least. Has anyone else seen this issue? > Yes. It is a known bug when using the Metacity WM. We have a hack in CrossOver that works around it based on a patch somebody sent to wine-patches within the last year. -- Rob Shearman ------------------------------------------------------------------------------ Is there a bug open on this? I would hvae thought that a patch put forth like a year ago would have made it into the official wine builds by now.

1 0

Re: [LOSTWAGES] fix .htaccess
by Jeremy Newman 03 Nov '05

03 Nov '05

I've run into this before. Problem is that if I use a local URL it breaks the website images for the 404 page. This is due to the local path not matching what the URL reads. I get around it by using the redirect. I did fix the code in the website so when the 404 page is loaded, it correctly sends the 404 header. Let me know if that works better for you. On Wed, 2005-11-02 at 11:26 +0100, Jonathan Ernst wrote: > http://httpd.apache.org/docs/1.3/mod/core.html#errordocument > > Note that when you specify an ErrorDocument that points to a remote URL > (ie. anything with a method such as "http" in front of it), Apache *will > send a redirect to the client to tell it where to find the document, > even if the document ends up being on the same server*. This has several > implications, the most important being *that the client will not receive > the original error status code*, but instead will receive a redirect > status code. This in turn can confuse web robots and other clients > which try to determine if a URL is valid using the status code. > > I was using linkchecker (http://linkchecker.sourceforge.net/) to check > for deadlinks and wondered why some people could still find some > deadlinks on winehq. That's because our 404 handler doesn't send an > Error 404 message to the user agent. > > This change will make apache send a 404 instead of a redirect and will > let the original address in the browser's address bar instead of > changing it to the /site/404 file. It will also make it easier to check > for deadlinks as the error code will be correct now.

2 1

[d3d8] D3DCOLOR fixup + bug fix
by Raphael 02 Nov '05

02 Nov '05

Hi, Same as the previous wined3d patch + minor fix on UBYTE4 handling Regards, Raphael

1 0

Re: DirectSound problems - dlls/dsound/mixer.c
by Jesse Allen 02 Nov '05

02 Nov '05

Hi Davin, Juergen and I have tested Diablo 2 with your patch and found it has improved the sound. But there is still more to do: ---------- Forwarded message ---------- From: Juergen Wieczorek <juergenw_(a)web.de> Date: Oct 31, 2005 3:58 PM Subject: Re: Fwd: DirectSound problems - dlls/dsound/mixer.c To: Jesse Allen <the3dfxdude(a)gmail.com> Sorry, but things are a bit weird with the supplied wine-0.9 for FC3. In order to counter-proof, I did a rpmbuild -bb ... with the *unpatched* sources from wine-0.9-1fc3-winehq and also ended up with dead sound, until I set winecfg to "OSS"! Then sound worked with patched or unpatched mixer.c source. Strangely, when I installed the provided binary FC3.rpm, winecfg works only with "ALSA" sound setting. Obviously there is something wrong with the build specs of this package, I have to check later. As for the patched mixer.c source: Sound is now much more fluid and not crackling perpetually, but some long drawn sounds like power-ups have a jarring note to them. Also walking around on the map with the mouse button pressed down produces a jarring noise when in the vicinity of moving flames like those at waypoints or near any sort of open fire. Ths stops when you're at some distance from the flames. Here is my resp. console output for reference: err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 2454, block size = 4 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 2482, block size = 4 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 2498, block size = 4 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 2550, block size = 4 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 3966, block size = 4 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 3026, block size = 4 fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ff007c,0x70ee3bec,0x70ff00 58): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed007c,0x721000f4,0x70ed00 58): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed01b4,0x70ee508c,0x70ed01 90): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed02ec,0x70ed03dc,0x70ed02 c8): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed047c,0x70ed058c,0x70ed04 58): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed062c,0x70ed073c,0x70ed06 08): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed07dc,0x70ed08ec,0x70ed07 b8): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed098c,0x70ed0a9c,0x70ed09 68): stub All in all, much better now, but still a way from being nice. -- Juergen Wieczorek Hamburg / Germany

3 5

Re: [d3d8] FillVertexShaderInputARBHW wrong color order for D3DCOLOR?
by Raphael 02 Nov '05

02 Nov '05

On Wednesday 02 November 2005 11:46, Christoph Frick wrote: > On Wed, Nov 02, 2005 at 11:39:17AM +0100, fenix(a)club-internet.fr wrote: > > You are right, it's a known problem. > > See DirectDraw7 to Wined3d recent thread, it's related about > > drawPrimitiveStriddedSlow. We have 3 solutions: > > - when app use VertexBuffer: precompilation of VB to be OpenGL compliant > > on unlock - using vertex/pixel shaders to do the needed tricks > > - for each frame transform all colors in software before rendering > > (yuckk) > > would you enlighten my, why i was not able to write my own data in the > glVertex... method? because this is something precompiled and "source" > is already somewhere in the graphics hardware and i can not write data > from the heap into it? because, as you said, it doesn't have the good format. D3D format isn't supported by OpenGL (it's ARGB and we need it to be in RGBA, see D3DCOLOR_* macros on d3d8_private.h) Ex of msdn: http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dx81_c/dir… http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dx81_c/dir… Regards, Raphael

1 0

alt-tab task switching form a wine app
by Anthony R. Tuel 02 Nov '05

02 Nov '05

It seems when I have an app up running under wine (lotus notes 6.5.4 in my case) and I switch to another app (using a gaim messaging window in my case) using alt tab, when I come back to my notes window its as if I'm still holding the alt key. Not sure if this happens in other apps, but its really noticible in notes since it uses the alt key for all sorts of keyboard shortcuts. So if i'm writing a new email in notes, someone sends me an IM, I alt-tab switch over to gaim, when I switch back to notes and want to hit enter for a new line, it brings up the font properties windows (alt+enter being the font properties shortcut). This seems to happen with both 20050930 and the .9 releases at least. Has anyone else seen this issue?

4 3

Calling PE DLLs
by Daniel Stodden 02 Nov '05

02 Nov '05

hi all. sorry in case this email will get delivered twice to the list. i subscribed yesterday an promptly used the wrong mail address to post. so here i post again. i'm stuck at the process of loading PE dlls. like some others before me, i've got a native w32 dll which i would like to hook into on a linux box. no source code available. the case is almost identical to http://www.winehq.com/hypermail/wine-devel/2003/12/index.html#231 though, there's not much application code yet, except a small test program written by myself, currently only meant to call a single function on the dll. so, using winemaker does not seem to spit out anything usable, and there seems to be no official documentation on how to use winebuild here. the program is called test.c, calling symbols from a vendor-supplied header file. created test.o through winegcc: winegcc -Wall -O2 -I. -c -o test.o test.c let's call the library vendor.dll again. i've played with winedump, finally got a vendor.dll.spec. i'm calling winebuild to get a .def as follows: winebuild --def -E vendor.dll.spec -o libvendor.def then, one of my better guesses on how to proceed seemed to be: winebuild --dll -fPIC -E vendor.dll.spec -L. -lvendor test.o -o libvendor.dll.s the assembler code looks reasonable. though, linking fails with duplicate symbols: winegcc test.o libvendor.dll.o -o test [..] : multiple definition of `__wine_spec_nt_header' : multiple definition of `__wine_spec_file_name' i'm aware that i could probably avoid all of this by just using LoadLibrary() and resolving the symbols at runtime. otoh, the approach above is potentially simpler, if i just knew how. :) could someone please enlighten me? what am i doing wrong? thanks, daniel -- Daniel Stodden LRR - Lehrstuhl für Rechnertechnik und Rechnerorganisation Institut für Informatik der TU München D-85748 Garching http://www.lrr.in.tum.de/~stodden mailto:stodden@cs.tum.edu PGP Fingerprint: F5A4 1575 4C56 E26A 0B33 3D80 457E 82AE B0D8 735B

3 4

[d3d8] FillVertexShaderInputARBHW wrong color order for D3DCOLOR?
by Christoph Frick 02 Nov '05

02 Nov '05

hiho, i encountered the following problem with Live For Speed [1]: once i setup my car and choose a color for it red and blue are swaped. also i got a FIXME there from: dlls/d3d8/vshaderdeclaration.c:675 (the case for D3DVSDT_D3DCOLOR). so i tried various things to put data in the hardware, but none worked - most of the time the car/game had simply extreme strange colors. so my approach (the obvious: get data from curPos, honouring skip and put it in my own 4 byte array, then call the glVertexAttribPointerARB with my array and skip=0) does not work at all - especially because i really dont have any clue about vertex shading at all, i guess. my assumtion: opengl takes for the 4 bytes RGBA->XYZW and D3DCOLOR is BGRA->XYZW (thats also what the software branch of this method wants). any ideas? -- cu

2 1

Re: Need some help debugging listview (Process Explorer)
by Dimi Paun 02 Nov '05

02 Nov '05

On Wed, 2005-11-02 at 08:26 +0100, Paul Vriens wrote: > Ok, there we go (i've started winedbg or I'm not getting to the wine > debugger, the bt is however the same as already printed): Good. Can you also send me your version of listview.c and the output of a run with +listview? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 3

Re: Shell32 File Property Dialog
by Andreas Mohr 02 Nov '05

02 Nov '05

Hi, On Sat, Oct 29, 2005 at 08:59:51PM +0200, Johannes Anderwald wrote: > This patch adds file property dialog to shell32 > + LTEXT "Type of file:", 14004, 10, 30, 50, 10 Space missing?? > + LTEXT "Modied: ", 14016, 10, 90, 45, 10 "Modified: " > FIXME("Unhandled Verb %xl\n",LOWORD(lpcmi->lpVerb)); What kind of format specifier is that supposed to be? I don't know that one... Maybe use %p instead? (or %lx??) > HWND hDlgCtrl = GetDlgItem(hwndDlg, 14005); > > if (filext == NULL || hDlgCtrl == NULL) > return FALSE; Wasteful invocation of GetDlgItem() here, although the failure check is a bit "prettier" that way... > result = RegEnumValueW(hKey,0, name, &lname, NULL, NULL, (LPBYTE)value, &lvalue); space missing after hkey ;) > BOOL > SHFileGeneralGetFileTimeString(LPFILETIME lpFileTime, WCHAR * lpResult) > { > FILETIME ft; > SYSTEMTIME dt; > WORD wYear; > WCHAR wFormat[] = {'%','0','2','d','/','%','0','2','d','/','%','0','4','d',' ',' ','%','0','2','d',':','%','0','2','u',0}; static const WCHAR > TRACE("result %s \n",debug_strw(lpResult)); Superfluous space. > WARN("failed to open file \n"); > WARN("GetFileTime failed \n"); > TRACE("hDlgCtrl %x text %s \n",hDlgCtrl, debug_strw(resultstr)); > WARN("failed to open file \n"); > WARN("GetFileSize failed \n"); Dito (I prefer Wine to be smaller rather than the error message to be a bit "more readable" ;). (and probably more instances of superfluous space in this patch) > if (GetFileSize(hFile, NULL) == 0xFFFFFFFF) > { > CloseHandle(hFile); > return FALSE; > } > > dwFileLo = GetFileSize(hFile, &dwFileHi); > CloseHandle(hFile); > > if (dwFileLo == 0xFFFFFFFF && GetLastError() != NO_ERROR) > return FALSE; This whole check sounds very weird. Why are you checking with NULL hiword when there might be a > 4GB file? (and to make it worse, even one with e.g. a size of 0x12345678FFFFFFFF !!!!!!) And directly after that even doing a full large file check **again**? Not to mention that you're not using the INVALID_FILE_SIZE macro that I really, really think should be used since it's been created *exactly* for this purpose (and for the even better purpose of *never* managing to write/edit/delete a 0xFFFFFF or 0xFFFFFFF instead...) > FIXME("directory / drive resources dont exist yet \n"); ' missing ;) Sorry for this VERY anal review (it's got to be my most thorough WP review), and thanks very much for this large patch :) Andreas -- GNU/Linux. It's not the software that's free, it's you.

2 2

Resource file and linking C++ project using winelib
by Brenda y Sergio 02 Nov '05

02 Nov '05

Hi all, I am porting an application from windows to linux (Miranda IM, a multiprotocol IM program). I have just run into one problem: the file gets compiled and runs, but the resources (icons, dialogs, images) do not seem to be working (i.e.: they are simply not shown). Sometimes, I am getting this message in the console each time I try to open certain dialogs: err:win:CreateWindowExA bad class name "??????ly t\x10" Other, a different dialog (and not present in my plugin, just one from the main application) gets opened. What I am doing in fact is making some of the application's plugins and I am getting this problem only with two plugins that were developed in C++. I have succesfully compiled and made work the ones that were written in C. My question: is this problem related to generating / linking to the .res file? Is there a way of solving it? Did anyone here have the same problem and manage to make it work? Has anyone here tried to link a C++ project using winelib and did not experience this problem? Thank you very much. I am really lost and your help will be highly appreciated. Sergio.

4 3

Re: [User] Fix clip cursor handling on resolution change
by Alexandre Julliard 02 Nov '05

02 Nov '05

Lionel Ulmer <lionel.ulmer(a)free.fr> writes: > @@ -173,6 +174,13 @@ > /* Initialize system colors and metrics */ > SYSPARAMS_Init(); > > + /* Now that system metrics are set-up, we can initialize the clip rectangle */ > + rect.left = 0; > + rect.right = GetSystemMetrics(SM_CXSCREEN); > + rect.top = 0; > + rect.bottom = GetSystemMetrics(SM_CYSCREEN); > + ClipCursor(&rect); > + Please don't add more init code that requires the graphics driver, I've been trying hard to get rid of these. I think it would be a lot cleaner to simply store a 'no clip cursor' state that would return the full resolution, then you could simply do a ClipCursor(NULL) on resolution changes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Make LdrAccessResource Call an Internal Function to Satisfy Shrinker
by Dmitry Timoshkov 02 Nov '05

02 Nov '05

"Robert Shearman" <rob(a)codeweavers.com> wrote: > -/********************************************************************** > - * LdrAccessResource (NTDLL.@) > - */ > -NTSTATUS WINAPI LdrAccessResource( HMODULE hmod, const IMAGE_RESOURCE_DATA_ENTRY *entry, > - void **ptr, ULONG *size ) > +/* don't penalize other platforms stuff needed on i386 for compatibility */ > +#ifdef __i386__ > +NTSTATUS WINAPI access_resource( HMODULE hmod, const IMAGE_RESOURCE_DATA_ENTRY *entry, > + void **ptr, ULONG *size ) > +#else > +static inline NTSTATUS access_resource( HMODULE hmod, const IMAGE_RESOURCE_DATA_ENTRY *entry, > + void **ptr, ULONG *size ) > +#endif > { > NTSTATUS status; > > @@ -355,6 +358,30 @@ NTSTATUS WINAPI LdrAccessResource( HMODU > return status; > } > > +/********************************************************************** > + * LdrAccessResource (NTDLL.@) > + */ > +#ifdef __i386__ > +/* Shrinker depends on the "call access_resource" instruction being there */ > +__ASM_GLOBAL_FUNC( LdrAccessResource, > + "pushl %ebp\n" > + "movl %esp, %ebp\n" > + "pushl 24(%ebp)\n" > + "pushl 20(%ebp)\n" > + "pushl 16(%ebp)\n" > + "pushl 12(%ebp)\n" > + "pushl 8(%ebp)\n" > + "call access_resource\n" > + "leave\n" > + "ret\n" > +); > +#else > +NTSTATUS WINAPI LdrAccessResource( HMODULE hmod, const IMAGE_RESOURCE_DATA_ENTRY *entry, > + void **ptr, ULONG *size ) > +{ > + return access_resource( hmod, entry, ptr, size ); > +} > +#endif Shouldn't be enough for the __i386__ case just omitting 'inline' in access_resource definition? -- Dmitry.

2 1

Queries about some 'usability' points
by Lionel Ulmer 02 Nov '05

02 Nov '05

Hi all, There are just two (unrelated) points that I would like to discuss: = the possibility to add a 'wine' launcher. Basically what happens is that some (maybe only one :-) ) application takes as an assumption that it is started via 'double clicking' on the .EXE file or via the installed link. From what I know, both these actions will start the game from its .EXE directory and with the full qualified path as the exe name. So the application crashes if you start it with 'wine foo.exe', you need to type 'wine D:\\Foo\\foo.exe' to get it running. One could then imagine having either 'wine' be a launcher that qualifies the name, changes to the good directory and just start the 'real' wine or do the reverse: publicize to new users that they should use 'winelaunch' to start applications and keep 'wine' how it is now. = in the current Wine tree, if Wine crashes, some persistant X settings are changed (for example desktop resolution for people using XRandR)... And as most people do not know the 'xrandr' command line tool, they tend to kill X to restore their resolution (which tends to annoy them :-) ). In the same vein, I would like to disable mouse acceleration when DInput mode is entered but actually fear to do so for the above-mentionned reasons (I fear gettint these kind of lines in the IRC channels: 'Wine is crap, when it exits, I need to restart X to get my mouse acceleration back'). Well, there is 'xset' but most 'normal' users have no idea that it even exists... For that one, the most robust way would be at the X level (basically having 'connection-linked' configurations - i.e. the settings has changed up until the point in time that the client quits) but if we do not want to change X, the most robust way would be to do it at the wineserver level (I often get Wine crashing, it's more rare to get the server to crash). Of course, injecting X code in the server is maybe not to AJ's liking :-) So the other solution would be to be able to hook somehow some 'clean-up' functions from DLLs to the Wine process that could be called when Wine exits (whether normally or when crashing). Of course, people 'kill-9'ing their Wine would get nothing but I do not think it's really a problem. Lionel (in rant mode :-) ) -- Lionel Ulmer - http://www.bbrox.org/

7 25

Unix Path APIs implementation available
by Troy Rollo 02 Nov '05

02 Nov '05

An implementation of UNIX path APIs is available from: svn://troy.wine-branches.troy.rollo.name/troy/branches/unix-path-apis This is an SVK branch, so if you use SVK you will be able to merge it into your own branch. The implementation is also merged into the following trunks: svn://troy.wine-branches.troy.rollo.name/troy/trunk svn://wine-branch.corvu.com/corvu/trunk Not all APIs are implemented, rather a mechanism has been provided for specifying the interface of an entry point that is used by a tool that generates the UNIX path name entry points (it can also generate the 'A' versions of non-UNIX path name entry points). I will put some documentation on the Wiki.

1 0

Lockbox IPC implementation available - may be useful for wineserver "kernel" handles
by Troy Rollo 02 Nov '05

02 Nov '05

A couple of years back I described an IPC mechanism called "Lock boxes" that might be useful for creating a faster wineserver. An implementation of this for Linux is now available: <http://lockboxes.berlios.de/>

1 0

hid.dll support
by Phil Lodwick 02 Nov '05

02 Nov '05

Greetings, I was introduced to Wine a few months ago and ran into a problem with an application I wanted to use. This application makes use of setupapi.dll and hid.dll to communicate with a USB HID class device. I quickly determined that in this case using native dlls was not an option and created an implementation of hid.dll. This solution has worked fine for me. >From what I have gathered from monitoring the Wine community, making something work for yourself is easy -- getting a general fix into Wine for everybody to use, not so easy :-) There is much work that needs to be done before I attempt to submit my first patch. Please bear with me as I no doubt ask newbie/dumb questions. I would like to start with what I consider my most troubling solution. My gut tells me there must be a better way, but if there is, it is not obvious to me. >From MSDN: "To communicate with the device, call the SetupDiGetDeviceInterfaceDetail function. This function returns device information in an SP_DEVICE_INTERFACE_DETAIL_DATA structure. The DevicePath member provides the symbolic link name, which can be used in the CreateFile function to access the device." On Windows this DevicePath takes the form: \\?\hid#vid_0c27&pid_3bfa#6&11440ca5&0&0000#{4d1e55b2-f16f-11cf-88cb-00111100 0030} Obviously, if we were to call Wine's implementation of CreateFile with this path, we would not be opening the correct file to communicate with the device. My solution is to have SetupDiGetDeivceInterfaceDetail return a special escape string that we can escape in CreateFile to indicate we are really talking about getting a file descriptor for an open USB HID device. There already seems to be precedence in CreateFile for this type of escape mechanism. Currently it appears to be checking for: \\??\\pipe\\ \\??\\MAILSLOT\\ Does my solution for adding a third special escape sequence (\\??\\HID\\) seem acceptable? If this is the wrong approach, has there been anybody who has thought about this problem and what the correct approach would be? Thanks, Phil

2 1

Re: comctl32: MSVC portability fix
by Steven Edwards 02 Nov '05

02 Nov '05

Hi Martin, On 11/1/05, Martin Fuchs <martin-fuchs(a)gmx.net> wrote: > +#include "config.h" > +#include "wine/port.h" /* strncasecmp */ Please don't add the comment after the include statement here. Its really not needed and I doubt Alexandre will merge it. Thanks Steven

1 0

wine for two, please.
by wino＠piments.com 02 Nov '05

02 Nov '05

Hi, I dont know much about the message queue works on Wine but wondered if there was means of running two progams in the same context on wine in such a way that they use the same message queue and can therefore potencially interact. As I understand it, running two instance of command line wine is more analogous to having two different computers running each app under windows. My goal is getting NatSpeak dictated text messages freed from the confines of the wine instance of the app. This would seem to be one approach if wine can run more than one process at a time. TIA.

4 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel