wine-devel

wine-devel@winehq.org

84463 discussions

Start a nNew thread

[PATCH 0/4] MR388: d2d1: Introduce D2DERR_NOT_FOUND.
by Ziqing Hui (＠zhui) 07 Jul '22

07 Jul '22

Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/388

3 5

[PATCH 0/2] MR396: dinput/tests: Fix reported test failures.
by Rémi Bernon (＠rbernon) 07 Jul '22

07 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/396

2 2

[PATCH vkd3d] tests: Test float4 UAV buffer store.
by Conor McCarthy 07 Jul '22

07 Jul '22

Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> --- tests/d3d12.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/tests/d3d12.c b/tests/d3d12.c index ec5cfb20..e12c3e62 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -20947,6 +20947,27 @@ static void test_typed_buffer_uav(void) 0x00000000, 0x0002100a, 0x00004001, 0x00000020, 0x0002400a, 0x0a0000a4, 0x0011e0f2, 0x00000000, 0x00100006, 0x00000000, 0x00004002, … [View More]0x3f000000, 0x3f000000, 0x3f000000, 0x3f000000, 0x0100003e, }; + static const DWORD cs_vec4_code[] = + { +#if 0 + RWBuffer<float4> buffer; + + [numthreads(8, 1, 1)] + void main(uint3 group_id : SV_groupID, uint group_index : SV_GroupIndex) + { + uint global_index = 8 * group_id.x + group_index; + buffer[global_index] = float4(0.5f, 0.625f, 0.75f, 1.0f); + } +#endif + 0x43425844, 0x37e9fa91, 0x11ca38f4, 0x9d4a70b7, 0x4fd05c45, 0x00000001, 0x000000e0, 0x00000003, + 0x0000002c, 0x0000003c, 0x0000004c, 0x4e475349, 0x00000008, 0x00000000, 0x00000008, 0x4e47534f, + 0x00000008, 0x00000000, 0x00000008, 0x58454853, 0x0000008c, 0x00050050, 0x00000023, 0x0100086a, + 0x0400089c, 0x0011e000, 0x00000000, 0x00005555, 0x0200005f, 0x00024000, 0x0200005f, 0x00021012, + 0x02000068, 0x00000001, 0x0400009b, 0x00000008, 0x00000001, 0x00000001, 0x07000023, 0x00100012, + 0x00000000, 0x0002100a, 0x00004001, 0x00000008, 0x0002400a, 0x0a0000a4, 0x0011e0f2, 0x00000000, + 0x00100006, 0x00000000, 0x00004002, 0x3f000000, 0x3f200000, 0x3f400000, 0x3f800000, 0x0100003e, + }; + static const struct vec4 expected = {0.5f, 0.625f, 0.75f, 1.0f}; if (!init_compute_test_context(&context)) return; @@ -21004,6 +21025,28 @@ static void test_typed_buffer_uav(void) check_readback_data_float(&rb.rb, NULL, 0.5f, 0); release_resource_readback(&rb); + reset_command_list(command_list, context.allocator); + transition_sub_resource_state(command_list, resource, 0, + D3D12_RESOURCE_STATE_COPY_SOURCE, D3D12_RESOURCE_STATE_UNORDERED_ACCESS); + ID3D12PipelineState_Release(pipeline_state); + pipeline_state = create_compute_pipeline_state(device, root_signature, + shader_bytecode(cs_vec4_code, sizeof(cs_vec4_code))); + + uav_desc.Format = DXGI_FORMAT_R32G32B32A32_FLOAT; + ID3D12Device_CreateUnorderedAccessView(device, resource, NULL, &uav_desc, cpu_descriptor_handle); + + ID3D12GraphicsCommandList_SetPipelineState(command_list, pipeline_state); + ID3D12GraphicsCommandList_SetComputeRootSignature(command_list, root_signature); + ID3D12GraphicsCommandList_SetComputeRootDescriptorTable(command_list, 0, gpu_descriptor_handle); + ID3D12GraphicsCommandList_Dispatch(command_list, 2, 1, 1); + + transition_sub_resource_state(command_list, resource, 0, + D3D12_RESOURCE_STATE_UNORDERED_ACCESS, D3D12_RESOURCE_STATE_COPY_SOURCE); + + get_buffer_readback_with_command_list(resource, uav_desc.Format, &rb, queue, command_list); + check_readback_data_vec4(&rb.rb, NULL, &expected, 0); + release_resource_readback(&rb); + ID3D12Resource_Release(resource); ID3D12RootSignature_Release(root_signature); ID3D12PipelineState_Release(pipeline_state); -- 2.36.1 [View Less]

1 0

[PATCH 0/3] MR393: wmvcore: Asynchronous reader state transitions.
by Rémi Bernon (＠rbernon) 07 Jul '22

07 Jul '22

Before https://gitlab.winehq.org/wine/wine/-/merge_requests/140, and to avoid a situation in the future where we might decide to implement this, and where the callback would be called asynchronously as they are supposed to, without the ASF reader filter supporting it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/393

3 6

[PATCH 0/2] MR394: d3d8/tests: Build without -DWINE_NO_LONG_TYPES.
by Zebediah Figura (＠zfigura) 07 Jul '22

07 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/394

3 4

[PATCH v2 0/4] MR375: ntdll: Fixes for runtime 64-bit shift functions.
by Zebediah Figura (＠zfigura) 07 Jul '22

07 Jul '22

Based on <https://source.winehq.org/patches/data/238821> by Zhao Yi. -- v2: ntdll: Correctly handle shift greater than the type width in 64-bit shift functions. ntdll: Avoid depending on compiler support for 64-bit shift functions. ntdll/tests: Add tests for runtime 64-bit shift functions. ntdll: Fix the calling convention for runtime 64-bit shift functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/375

5 19

Re: [PATCH v3 0/1] MR367: oleaut32 fix - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/367

1 0

[PATCH v3 0/3] MR392: regedit: Code clean-up and invalid read fix
by Hugh McMaster (＠hmc) 06 Jul '22

06 Jul '22

-- v3: regedit: Directly use RegQueryValueExW() instead of a helper function. regedit: Correctly calculate REG_MULTI_SZ size before reading from the buffer. regedit: Remove unneeded valueDataLen override for DWORD values. https://gitlab.winehq.org/wine/wine/-/merge_requests/392

3 4

Re: [PATCH v8 0/3] MR355: win32u: Move more display mode logic out of graphics drivers. - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/355

1 0

Re: [PATCH v15 0/8] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/337

1 0

Re: [PATCH v2 0/2] MR387: uxtheme/tests: Add more GetThemePartSize() tests in different DPI. - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/387

1 0

Re: [PATCH v2 0/1] MR390: secur32: Validate input buffers in schan_InitializeSecurityContextW(). - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/390

1 0

Re: [PATCH v2 0/2] MR386: d3d9/tests: Build without -DWINE_NO_LONG_TYPES. - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/386

1 0

Re: [PATCH v2 0/2] MR389: Reset input buffer - approved
by Alexandre Julliard (＠julliard) 06 Jul '22

06 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/389

1 0

[PATCH v2] wpcap: Implement pcap_dispatch.
by Roman Pišl 06 Jul '22

06 Jul '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53104 Signed-off-by: Roman Pišl <rpisl(a)seznam.cz> --- dlls/wpcap/wpcap.c | 41 ++++++++++++++++++++++++++++++++--------- 1 file changed, 32 insertions(+), 9 deletions(-) diff --git a/dlls/wpcap/wpcap.c b/dlls/wpcap/wpcap.c index a295819f7fe..1a245ab4917 100644 --- a/dlls/wpcap/wpcap.c +++ b/dlls/wpcap/wpcap.c @@ -99,15 +99,6 @@ const char * CDECL pcap_datalink_val_to_name( int link ) return ret; } -int CDECL pcap_dispatch( … [View More]

2 1

[PATCH v6 0/7] MR140: qasf: More ASF reader filter implementation.
by Rémi Bernon (＠rbernon) 06 Jul '22

06 Jul '22

-- v6: qasf: Configure WMReader stream selection in asf_reader_init_stream. qasf: Configure WMReader stream format in asf_reader_init_stream. winegstreamer: Implement IWMOutputMediaProps_SetMediaType. wmvcore/tests: Add some IWMOutputMediaProps_SetMediaType tests. qasf: Implement ASF Reader filter init_stream and cleanup_stream. qasf: Implement ASF Reader filter pin DecideBufferSize. qasf: Implement ASF Reader filter pin_get_media_type. https://gitlab.winehq.org/wine/wine/-/merge_requests/140

3 13

[PATCH v3] sechost: Support decimal or octal access rights in ConvertStringSecurityDescriptorToSecurityDescriptor.
by Dmitry Timoshkov 06 Jul '22

06 Jul '22

v3: Add more tests with leading zero. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/advapi32/tests/security.c | 22 +++++++++++++++++++--- dlls/sechost/security.c | 3 +++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index ed91ccc39d3..a47c4b2d529 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -4219,6 +4219,7 @@ static void … [View More]test_ConvertStringSecurityDescriptor(void) BOOL ret; DWORD GLE; DWORD altGLE; + DWORD ace_Mask; } cssd[] = { { "D:(A;;GA;;;WD)", 0xdeadbeef, FALSE, ERROR_UNKNOWN_REVISION }, @@ -4239,9 +4240,11 @@ static void test_ConvertStringSecurityDescriptor(void) { "D:(D;;GA;;; WD)", SDDL_REVISION_1, TRUE }, { "D:(D;;GA;;;WD )", SDDL_REVISION_1, TRUE }, /* test ACE string access rights */ - { "D:(A;;GA;;;WD)", SDDL_REVISION_1, TRUE }, - { "D:(A;;GRGWGX;;;WD)", SDDL_REVISION_1, TRUE }, - { "D:(A;;RCSDWDWO;;;WD)", SDDL_REVISION_1, TRUE }, + { "D:(A;;GA;;;WD)", SDDL_REVISION_1, TRUE, 0, 0, GENERIC_ALL }, + { "D:(A;;1;;;WD)", SDDL_REVISION_1, TRUE, 0, 0, 1 }, + { "D:(A;;020000000000;;;WD)", SDDL_REVISION_1, TRUE, 0, 0, GENERIC_READ }, + { "D:(A;;GRGWGX;;;WD)", SDDL_REVISION_1, TRUE, 0, 0, GENERIC_READ | GENERIC_WRITE | GENERIC_EXECUTE }, + { "D:(A;;RCSDWDWO;;;WD)", SDDL_REVISION_1, TRUE, 0, 0, READ_CONTROL | DELETE | WRITE_DAC | WRITE_OWNER }, { "D:(A;;RPWPCCDCLCSWLODTCR;;;WD)", SDDL_REVISION_1, TRUE }, { "D:(A;;FAFRFWFX;;;WD)", SDDL_REVISION_1, TRUE }, { "D:(A;;KAKRKWKX;;;WD)", SDDL_REVISION_1, TRUE }, @@ -4275,7 +4278,20 @@ static void test_ConvertStringSecurityDescriptor(void) (cssd[i].altGLE && GLE == cssd[i].altGLE), "(%02u) Unexpected last error %ld\n", i, GLE); if (ret) + { + if (cssd[i].ace_Mask) + { + ACCESS_ALLOWED_ACE *ace; + + acl = (ACL *)((char *)pSD + sizeof(SECURITY_DESCRIPTOR_RELATIVE)); + ok(acl->AclRevision == ACL_REVISION, "(%02u) Got %u\n", i, acl->AclRevision); + + ace = (ACCESS_ALLOWED_ACE *)(acl + 1); + ok(ace->Mask == cssd[i].ace_Mask, "(%02u) Expected %08lx, got %08lx\n", + i, cssd[i].ace_Mask, ace->Mask); + } LocalFree(pSD); + } } /* test behaviour with NULL parameters */ diff --git a/dlls/sechost/security.c b/dlls/sechost/security.c index 6916b3ad662..8a8ca0f051a 100644 --- a/dlls/sechost/security.c +++ b/dlls/sechost/security.c @@ -903,6 +903,9 @@ static DWORD parse_ace_right( const WCHAR **string_ptr ) if (string[0] == '0' && string[1] == 'x') return wcstoul( string, (WCHAR **)string_ptr, 16 ); + if (iswdigit( string[0] )) + return wcstoul( string, (WCHAR **)string_ptr, 0 ); + for (i = 0; i < ARRAY_SIZE(ace_rights); ++i) { if (!wcsncmp( string, ace_rights[i].str, 2 )) -- 2.36.1 [View Less]

2 2

[PATCH 0/1] MR352: cmd: Don't loop infinitely on NUL.
by Arek Hiler (＠ivyl) 06 Jul '22

06 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/352

3 8

[tools] testbot/cgi: Allow calling AddError() without an error.
by Francois Gouget 06 Jul '22

06 Jul '22

This simplifies error handling for APIs that just return an error message. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/ObjectModel/CGI/Page.pm | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/testbot/lib/ObjectModel/CGI/Page.pm b/testbot/lib/ObjectModel/CGI/Page.pm index 1df5392930..a8268754ac 100644 --- a/testbot/lib/ObjectModel/CGI/Page.pm +++ b/testbot/lib/ObjectModel/CGI/Page.pm @@ -356,6 +356,7 @@ Sets the error … [View More]

1 0

[tools] testbot/web: Use AddError() on the special jobs page.
by Francois Gouget 06 Jul '22

06 Jul '22

This is better than direct field access. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/web/admin/SpecialJobs.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/web/admin/SpecialJobs.pl b/testbot/web/admin/SpecialJobs.pl index 2c0bbd1105..d8294c1aaf 100644 --- a/testbot/web/admin/SpecialJobs.pl +++ b/testbot/web/admin/SpecialJobs.pl @@ -234,7 +234,7 @@ sub OnSubmit($) if (@Errors) { - $self->{ErrMessage} = join("\n", @… [View More]

1 0

[tools] testbot/cgi: Use AddError() instead of direct field access in ItemPage.
by Francois Gouget 06 Jul '22

06 Jul '22

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/ObjectModel/CGI/ItemPage.pm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/testbot/lib/ObjectModel/CGI/ItemPage.pm b/testbot/lib/ObjectModel/CGI/ItemPage.pm index cd40ba2e4b..3ec201d99c 100644 --- a/testbot/lib/ObjectModel/CGI/ItemPage.pm +++ b/testbot/lib/ObjectModel/CGI/ItemPage.pm @@ -176,8 +176,13 @@ sub Save($) return !1 if (!$self->SUPER::Save()); - (my $_ErrKey, $… [View More]

1 0

[tools] testbot/web: Use AddError() in the failure details page.
by Francois Gouget 06 Jul '22

06 Jul '22

This is better than direct field access. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/web/FailureDetails.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/web/FailureDetails.pl b/testbot/web/FailureDetails.pl index 02803ed27a..b4226f60c5 100644 --- a/testbot/web/FailureDetails.pl +++ b/testbot/web/FailureDetails.pl @@ -203,7 +203,7 @@ sub OnAction($$) { if (!$self->{RW}) { - $self->{ErrMessage} = "Only admin … [View More]

1 0

[tools] testbot/web: Use AddError() to set the item list action error.
by Francois Gouget 06 Jul '22

06 Jul '22

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/web/FailuresList.pl | 4 ++-- testbot/web/admin/UsersList.pl | 4 ++-- testbot/web/admin/VMsList.pl | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/testbot/web/FailuresList.pl b/testbot/web/FailuresList.pl index 2cb40c482e..d1f8de6d8e 100644 --- a/testbot/web/FailuresList.pl +++ b/testbot/web/FailuresList.pl @@ -138,8 +138,8 @@ sub OnItemAction($$$) my ($_ErrProperty, $ErrMessage) =… [View More]

1 0

[tools] testbot/cgi: Highlight the name of the invalid field(s) on form errors.
by Francois Gouget 06 Jul '22

06 Jul '22

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/ObjectModel/CGI/FormPage.pm | 4 +++- testbot/web/WineTestBot.css | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm index f2fd0f09cd..67b3fa00d3 100644 --- a/testbot/lib/ObjectModel/CGI/FormPage.pm +++ b/testbot/lib/ObjectModel/CGI/FormPage.pm @@ -432,7 +432,9 @@ sub GenerateField($$$$) { my ($self, … [View More]

1 0

[tools] testbot/web: Highlight the submit page's File and Branch fields if invalid.
by Francois Gouget 06 Jul '22

06 Jul '22

Unlike the other fields, these two fields are generated by the submit page itself. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/web/Submit.pl | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl index ca225b615d..c5423c7951 100644 --- a/testbot/web/Submit.pl +++ b/testbot/web/Submit.pl @@ -77,7 +77,7 @@ sub _Upload($) { umask($OldUMask); delete $self->{FileName}… [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel