wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: [d3d8] use wined3dformat when calling wined3d
by Juan Lang 26 Aug '05

26 Aug '05

Hi again Oliver, > Common subdirectories: clean/wine/CVS and small-patches/wine/CVS Wrong patch I think. --Juan ____________________________________________________ Start your day with Yahoo! - make it your home page http://www.yahoo.com/r/hs

1 0

Re: [wined3d] dxt2 and dxt4 texture support
by Juan Lang 26 Aug '05

26 Aug '05

Hi Oliver, diff -Nru -x ignore clean/wine/dlls/Makeimplib.rules small-patches/wine/dlls/Makeimplib.rules --- clean/wine/dlls/Makeimplib.rules 1970-01-01 01:00:00.000000000 +0100 +++ small-patches/wine/dlls/Makeimplib.rules 2005-08-26 15:53:11.888455392 +0100 @ This shows up in a couple of your patches and is noise. @@ -334,7 +335,9 @@ TRACE("(%p) glGetTexImage level(%d), fmt(%d), typ(%d), mem(%p) \n" , This, This->glDescription.level, This->glDescription.glFormat, This->glDescription.glType, This->resource.allocatedMemory); /* TODO: DXT2 and DXT4 formats */ if (This->resource.format == WINED3DFMT_DXT1 || + This->resource.format == WINED3DFMT_DXT2 || This->resource.format == WINED3DFMT_DXT3 || + This->resource.format == WINED3DFMT_DXT4 || This->resource.format == WINED3DFMT_DXT5) { TRACE("Locking a compressed texture\n"); if (GL_SUPPORT(EXT_TEXTURE_COMPRESSION_S3TC)) { /* we can assume this as the texture would not have been created otherwise */ Shouldn't that TODO be removed? --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

The recent include/wine/wined3d_types.h changes
by Gerald Pfeifer 26 Aug '05

26 Aug '05

The following patch to include/wine/wined3d_types.h revision 1.8 date: 2005/08/23 09:34:57; author: julliard; state: Exp; lines: +2 -2 Oliver Stieber <oliver_stieber(a)yahoo.co.uk> Tidy up d3d9 and finalize passing d3d9 calls to wined3d for now. @@ -401,7 +401,7 @@ typedef struct _WINED3DADAPTER_IDENTIFIE typedef struct _WINED3DPRESENT_PARAMETERS { UINT *BackBufferWidth; UINT *BackBufferHeight; - D3DFORMAT *BackBufferFormat; + WINED3DFORMAT *BackBufferFormat; UINT *BackBufferCount; D3DMULTISAMPLE_TYPE *MultiSampleType; DWORD *MultiSampleQuality; @@ -409,7 +409,7 @@ typedef struct _WINED3DPRESENT_PARAMETER HWND *hDeviceWindow; BOOL *Windowed; BOOL *EnableAutoDepthStencil; - D3DFORMAT *AutoDepthStencilFormat; + WINED3DFORMAT *AutoDepthStencilFormat; DWORD *Flags; UINT *FullScreen_RefreshRateInHz; UINT *PresentationInterval; triggers the following warning in IDirect3D8Impl_CreateDevice(): directx.c:670: warning: assignment from incompatible pointer type directx.c:678: warning: assignment from incompatible pointer type These two lines are localParameters.BackBufferFormat = &pPresentationParameters->BackBufferFormat; localParameters.AutoDepthStencilFormat = &pPresentationParameters->AutoDepthStencilFormat; and the two variables have the following types D3DPRESENT_PARAMETERS* pPresentationParameters (from include/wine/wined3d_types.h WINED3DPRESENT_PARAMETERS localParameters; (from include/d3d8types.h) Interestingly, I did not see this on SUSE Linux 9.3, but FreeBSD 4.11 (XFree86) and 5.4 (X.org). Both D3DFORMAT and WINED3DFORMAT are enums, so indeed assigning one to the other seems a bit strange, if not dangerous. Is the change as such really correct? Gerald

2 1

OpenGL windowing and wglMakeCurrent
by Russ 26 Aug '05

26 Aug '05

Trying to get my 3-D app to run under WINE using the same binary with the odd workaround or two. It uses OpenGL in various subwindows of the main window as needed. Under WINE, the subwindow graphics all get drawn in the lower left corner of the overall X11 window, and the entire X11 window's redraw is mangled---OpenGL is affecting the entire X11 Window. In Win32, when you call wglMakeCurrent, the opengl context is configured to match the size/position of the HWND for the HDC, even if it is only a small child window, so drawing openGL goes just into the desired subwindow. However, the WINE implementation of wglMakeCurrent just calls glXMakeCurrent (and glXCreateContext), which produces the entire size of the X11 window, resulting in the incorrect behavior observed. In my Mac OS X port, I have a similar issue, resolved by calling aglSetInteger(glContext, AGL_BUFFER_RECT,... I'm not sure what a glX equivalent would be to try. It is possible that glScissor might be used. A more accurate wglMakeCurrent emulation is necessary for a usable port. Suggestions welcome. Thanks, Russ __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

4 3

Re: Loading resources from wine dlls
by Michael Jung 26 Aug '05

26 Aug '05

Hi Rob, On Thursday 25 August 2005 06:50, you wrote: > Anything that uses SearchPath is similarly broken when needing to find a > builtin dll or exe. We should add a hack^H^H^H^Hextension to that > function to make it be able to find installed .so files with a similar > name. I think that's just part of the problem. If I create a symbolic link from .wine/drive_c/windows/system32/shell32.dll to /usr/local/lib/wine/shell32.dll.so SearchPath succeeds. But then USER32_GetResourceTable (dlls/user/exticon.c, line 128) fails (I guess it can't handle ELF wrapped PEs?). Would it be ok to look for an ELF header and then for an enclosed PE header in USER32_GetResourceTable (and then return IMAGE_NT_SIGNATURE and the correct pointer)? Where can I find informations about the format of ELF wrapped PEs? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

2 2

Re: wine/dlls/commdlg printdlg.c
by Vitaly Lipatov 26 Aug '05

26 Aug '05

В сообщении от 25 Август 2005 23:23 Alexandre Julliard написал(a): > Log message: > Vitaly Lipatov <lav(a)etersoft.ru> > Restore paper orientation when pagesetupdlg is initializing. > > Patch: http://cvs.winehq.org/patch.py?id=19818 Dear Alexandre! You are removed dm checking for NULL... But it can be NULL in some cases... <<<<<<< printdlg.c /* Set orientation radiobutton properly */ dm = GlobalLock(pda->dlga->hDevMode); if (dm && dm->u1.s1.dmOrientation == DMORIENT_LANDSCAPE) ======= /* Set orientation radiobutton properly */ dm = GlobalLock(pda->dlga->hDevMode); if (dm->u1.s1.dmOrientation == DMORIENT_LANDSCAPE) >>>>>>> 1.93 -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

DLL loading
by Bojan �ffff8aernek 26 Aug '05

26 Aug '05

hello, I'd like to load a DLL from a memory buffer. The regular Win32 API function to load DLLs, however, takes a path name. So, I'm looking for resources about this kind of thing, but it has to work both under win32 and unix+wine. There used to be a web page about just this thing, but I lost the link. Any ideas? Thanks. ____________________________________________________ Start your day with Yahoo! - make it your home page http://www.yahoo.com/r/hs

2 1

undocumented shell32 stuff
by Saulius Krasuckas 26 Aug '05

26 Aug '05

I have stumbled upon a unimplemented function shell32.dll.SHLocalAlloc . OpenRCE page says it is related to kernel32.dll.LocalAlloc [1], and authors of the NSElib (The NameSpace Extension Library) defines it taking two int-params [2]. They define the function in ShlExt.h file which says: // This file can be considered to be in the public domain. // The latest version can normally be found here: // http://www.whirlingdervishes.com/nselib/public // The file is based on various sources, and includes definitions // that were taken over from various places, including // Microsoft documentation and header files. It also contains // many definitions that were introduced by Whirling Dervishes // Software. OTOH, there is one page on the web [3], which declares itself as a homepage of the ShlExt.h and which describes history of the file. It seems as prototype which was extended by Whirling Dervishes Software and based on which their NSElib was built. Earlier ShlExt.h was beeing included in the PSDK, but now it isn't AFAICS. And this is another quote from [2]: // februari 2003: Henk Devos: Made compatible with the // october 2003 Platform SDK // januari 2003: Henk Devos: added some more undefined flags, // including the ones for CDefFolderMenu_Create2. // september 2002: Henk Devos: Made compatible with new Platform SDK // januari 2002: Henk Devos: Added comments with ordinals of // all exports in Windows 2000 version of shell32.dll // 24/06/99 Some changes made by Henk Devos It stays above the changelog of the old file [4]. What developers think about this story? Can we start importing it into our tree? If not, should I declare SHLocalAlloc() somewhere? And where should I put it's code, maybe dlls/shell32/utility.c ? [1] http://www.openrce.org/reference_library/win32_call_chains/2000SP4/SHLWAPI/… [2] http://www.whirlingdervishes.com/nselib/mfc/samples/source.php [3] http://www.mvps.org/user32/shlext.html#shlext [4] http://www.mvps.org/user32/shlext.zip

2 2

Help with debugging needed
by Stefan Dösinger 26 Aug '05

26 Aug '05

Hello, I am trying(once again) to get Empire Earth [1] running with wine. After solving a few problems[2], I've run into a strange access violation crash. It looks like a buffer overrun, followed by a return to an invalid adress. A +relay,+snoop trace gives this: ... 0009:CALL Low-Level Engine.?Deactivate@GERasterizer@@UAEJXZ() ret=7e2b9a14 0009:CALL Low-Level Engine.?Dereference@UReferenceCounter@@QAEXXZ() ret=7e2bd6c5 0009:RET Low-Level Engine.?Dereference@UReferenceCounter@@QAEXXZ() retval=7f24fa70 ret=7e2bd6c5 0009:Call ntdll.RtlEnterCriticalSection(7f074a40) ret=7f0294c5 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=7f0294c5 0009:Call ntdll.RtlLeaveCriticalSection(7f074a40) ret=7f029506 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=7f029506 0009:CALL MSVCRT._except_handler3(<unknown, check return>) ret=7beb649b 0009:CALL MSVCRT._XcptFilter(<unknown, check return>) ret=00665947 0009:Call kernel32.GetLastError() ret=7800385f 0009:Ret kernel32.GetLastError() retval=000005b4 ret=7800385f 0009:Call kernel32.TlsGetValue(00000000) ret=7800386d 0009:Ret kernel32.TlsGetValue() retval=7f180f80 ret=7800386d 0009:Call kernel32.SetLastError(000005b4) ret=7800387e 0009:Ret kernel32.SetLastError() retval=000005b4 ret=7800387e 0009:Call kernel32.UnhandledExceptionFilter(7fc2f81c) ret=7800ed71 0009:Call ntdll.NtQueryVirtualMemory(ffffffff,9803a11c,00000000,7fc2f6e8,0000001c,7fc2f6a8) ret=7fd1aae1 0009:Ret ntdll.NtQueryVirtualMemory() retval=00000000 ret=7fd1aae1 0009:Call kernel32.IsBadCodePtr(7800add3) ret=22d2b743 0009:Ret kernel32.IsBadCodePtr() retval=00000000 ret=22d2b743 0009:Call ntdll.NtCreateEvent(7fc2f6e8,001f0003,7fc2f6ec,00000001,00000000) ret=7fccb9b9 0009:Ret ntdll.NtCreateEvent() retval=00000000 ret=7fccb9b9 wine: Unhandled exception (thread 0009), starting debugger... ... The crash messages look a little bit different every time, with illegal instructions / access violations or even a Segmentation Fault without starting winedbg at various addreses(Attached file crashes). On very rare occasions, this crash doesn't occur, and the game continues to load and crashes later in some ddraw function. Instead of crashing it complains about a corrupted heap: err:heap:HEAP_ValidateInUseArena Heap 0x7fd80000: prev arena 0x7fe01640 is not prev for in-use 0x7fe01cb0 I've looked at a +heap trace, but I couldn't find anything usefull. (See ee-nocrash for a log). I've also attached a normal log without any special debug flags set(ee-normal.log.gz). I've added a few ERR statements for testing in some functions. So my questions are: *Am I right with my suspection that the problems are caused by a incorrect return? *How can I get a disassembly of Low-Level Engine.?Deactivate@GERasterizer@@UAEJXZ or simmilar functions. I didn't find this symbol. Thanks for your help, Stefan Dösinger [1] A demo is available at http://www.vugames.de/scripts/download.aspx?content=4&id=53721&nf=21&url=ft…, but I haven't checked wheter it produces the same results. [2] Other users reported a msvc runtime error, apparently caused by an error returned by Main_DirectDraw_SetCooperativeLevel. EE calls this function with cooplevel == DDSCL_SETFOCUSWINDOW. I made the function simply return DD_OK in this case. Furthermore it checks for sound support and the OS version(setting it to Win98 or WinME is recommended) and it needs native msvcrt(It even seems to ship it's own version)

5 20

Re: PATCH: sensap IsNetworkAlive
by Vijay Kiran Kamuju 26 Aug '05

26 Aug '05

Hi, According to MSDN, >+#define NETWORK_ALIVE_RAS 2 must be #define NETWORK_ALIVE_WAN 2 I think so, see http://msdn.microsoft.com/library/default.asp?url=/library/en-us/syncmgr/sy… Thanks, Vijay

1 0

More compatible memory arrangement ?: dlls/winsock.c: WS_dup_pe()
by Krzysztof C. 26 Aug '05

26 Aug '05

Hi, I was having a problem with a game, it couldn't connect to the server, so I started debugging things, and it ofcourse brought me to dlls/winsock.c but the problem seems to be on the game side ( unfortunately its closed-source, so I can only guess what's happening ). The debugging showed that when the game was getting server's ip from DNS (WS_gethostbyname()), it was getting wrong values. Then I started looking for the cause, and I found out that the game was incorrectly reading the hostent/WS_hostent structure. It was assuming that the ip address was at particular offset from the beginning of the structure, it didn't follow the pointers and thus it was getting wrong data. Then I rewrote few lines of the code and now it looks like: "pointer | pointer | pointer | ... data | data | data | .... " and everything works fine. So I assume that Microsoft's winsock arrange this structure this way, but I am not sure if it is 100% compatible way solving "one application problem", although few other programs dependent on this function worked fine with this change. Anyway I left the topic with question mark because I would like to know someone else's opinion on that. ( btw. I am new to mailing lists and it is my first post, so please don't be too rough on me in your responses : ) Index: dlls/winsock/socket.c =================================================================== RCS file: /home/wine/wine/dlls/winsock/socket.c,v retrieving revision 1.188 diff -u -p -r1.188 socket.c --- dlls/winsock/socket.c 25 Aug 2005 10:22:12 -0000 1.188 +++ dlls/winsock/socket.c 25 Aug 2005 22:20:58 -0000 @@ -3343,16 +3343,16 @@ static struct WS_hostent *WS_dup_he(cons p_to->h_addrtype = p_he->h_addrtype; p_to->h_length = p_he->h_length; - p = (char *)(p_to + 1); + p = (char *)p_to + sizeof(struct hostent); + p_to->h_addr_list = (char **)p; + p += list_dup(p_he->h_addr_list, p_to->h_addr_list, p_he->h_length); + p_to->h_name = p; - strcpy(p, p_he->h_name); - p += strlen(p) + 1; + strcpy(p_to->h_name, p_he->h_name); + p += strlen(p_he->h_name) + 1; p_to->h_aliases = (char **)p; - p += list_dup(p_he->h_aliases, p_to->h_aliases, 0); - - p_to->h_addr_list = (char **)p; - list_dup(p_he->h_addr_list, p_to->h_addr_list, p_he->h_length); + list_dup(p_he->h_aliases, p_to->h_aliases, 0); return p_to; }

1 0

Re: Need some help with a patch for version.dll
by Stefan Dösinger 25 Aug '05

25 Aug '05

Hi, > I can't use a LPCSTR, cause: > > BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPCSTR lpSubBlock, > LPVOID *lplpBuffer, UINT *puLen ) > > lplpBuffer points to a place in pBlock where the value is. This value is > in most cases a UNICODE string. This string has to be converted to ANSI > and placed on a different place in pBlock (+ info->wLength + 4). > > Hope this makes sense. Oh, sure, you can't change it here. I guess you need a typecast here to supress the warning. But there are some helper functions for converting a unicode string to an ansi string. If you can use them, this might save you some troubles. Stefan

1 0

Need some help with a patch for version.dll
by Paul Vriens 25 Aug '05

25 Aug '05

Hi, I've finally nailed the last (?) bugs in version.dll. The attached patch shows how. There is however a warning during compile and I have no clue (still learning C :-) ) how to fix that: info.c: In function `VerQueryValueA': info.c:754: warning: pointer of type `void *' used in arithmetic info.c:754: warning: pointer of type `void *' used in arithmetic info.c: In function `VerQueryValueW': info.c:817: warning: pointer of type `void *' used in subtraction info.c:817: warning: pointer of type `void *' used in arithmetic Any idea's ? Cheers, Paul.

2 1

Compiling winelib dependant code with g++
by Gaudet Michael-MGAU01 25 Aug '05

25 Aug '05

wineg++ is using g++, and is passing its options to g++. How can I link some winelib-dependant code with g++ ? compilation is okay, but at linking time, all wine functions are unresolved. // ### here's the output :### [root@udp015809uds Wine2]# g++ -lwine registry.o registry_wrap.o -o registry.out registry.o(.text+0x2e): In function `CreateKey(char const*)': : undefined reference to `RegCreateKeyA' registry.o(.text+0x58): In function `CreateKey(char const*)': : undefined reference to `RegQueryValueExA' registry.o(.text+0x8f): In function `CreateKey(char const*)': : undefined reference to `RegQueryValueExA' registry.o(.text+0xa5): In function `CreateKey(char const*)': : undefined reference to `MessageBoxA' collect2: ld returned 1 exit status // ### And the same code compiled with wineg++ ### [root@udp015809uds Wine2]# wineg++ -lwine registry.o registry_wrap.o -o registry.out // program runs okay. For information, I need to use g++ in order to assimilate wine lib framework to SWIG, to generate Win32 wrappers in C# for mono. Thanks.

2 1

compile a shared object using winelib with g++
by Gaudet Michael-MGAU01 25 Aug '05

25 Aug '05

Hello all. Do you know if there is a way to compile a shared object using winelib with g++ or wineg++ ? I am using wine20050725 under Linux2.6.8.1-12mdk I need references to advapi32.dll and user32.dll. Thanks.

1 0

Bugzilla - old rubbish bugs...
by Ann & Jason Edmeades 25 Aug '05

25 Aug '05

I asked this a while ago and noone was too upset, but I am going to try to spend some time slowly closing off some of the bugs which do not have enough info in them to be reproduced, and have not had a response to a request to see if the problem persists for a long time (e.g. 6 months). I wont close anything which is reproducible (I'll try if I can) and I believe if something is wrongfully closed it can always be reopened? If anyone else has a spare moment, feel free to help! At the moment there is >1300 available bugs, but looking at lots of them in detail I doubt there's 500 which are worth keeping! (I was bored and looking for some things to fix and it's like a needle in the haystack looking in bugzilla at the moment). Jason

2 1

Loading resources from wine dlls
by Michael Jung 25 Aug '05

25 Aug '05

Hello, I would like to add a 'My Documents' icon to shell32. This icon has a resource ID of 235 in WinXP's shell32. Apparently one can't load resources from wine's own dlls, though. If you call PrivateExtractIcons with 'c:\windows\system32\shell32.dll' as the file name parameter, you'll get a 'WARN: File %s not found or path too long'. I guess that's because there is no such file in wine's fake windows environment. There is a hack (which is even declared as a hack in the comment) in the initialization code of the 'Shell Icon Cache' (starting from line 372 in 'dlls/shell32/iconcache.c'). It loads the first 38 icons from shell32 at initialization time, and later returns them from the cache without having to access the file (which would'nt work). This seems to be a principal problem (Loading resources from wine dlls, if they are accessed by the filename they have on a windows system). Are there any plans on how to fix this? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

3 2

Throwing in an idea (probably it was discussed before though)
by John Smith 25 Aug '05

25 Aug '05

As a Win developer, I want to make a suggestion (sorry if it was already discussed - or if similar mechanism already exists): What if some simple way will be provided for Win developers to say which options they prefer for WINE to use for their application? While it may seem to somewhat contradict to the 'big bright future' of the WINE (with all the apps running flawlessly under WINE), it would hopefully allow for immediate increase of out-of-the-box supported applications. For example, it could be a resource string of special format (for example, "__WINE_CONFIG_HINT: "Managed" = "N""), and multiple hints should be allowed. This hint should override system-wide settings but in turn should be overridden by per-app settings in wine config file/registry. _________________________________________________________________ Dont just search. Find. Check out the new MSN Search! http://search.msn.click-url.com/go/onm00200636ave/direct/01/

8 13

Re: secur32: Getting some real functionality into the NTLM provider, try 2
by Juan Lang 25 Aug '05

25 Aug '05

Hi Kai, In ntlm.c, + /* convert the program name to Unicode */ (snip) + /* and back to the CP_UNIXCP */ This round-tripping is unnecessary when the text is already ASCII. ASCII values are just as valid in UTF8 as they are in CP1252 or whatever. Basically, don't bother converting anything you can type. + if(pAuthData == NULL) In this if statement, you duplicate the business of converting the user name and domain name to CP_UNIXCP in both branches. You should instead store a pointer to the user name and domain name, and convert them in one common branch after the if statement. + SEC_CHAR *client_argv[] = + { + program, + client_protocol, + client_user_arg, + client_domain_arg, + NULL + }; You must declare variables at the beginning of the block, not in the middle. Not all C compilers allow this. + if(pszPackage != NULL) + { + int package_sizeW = MultiByteToWideChar(CP_ACP, 0, pszPackage, -1, + NULL, 0); Since you don't use pszPackage in ntlm_AcquireCredentialsHandleW, why bother converting it? Just pass NULL. + if(identity->Flags == SEC_WINNT_AUTH_IDENTITY_ANSI) (snip) + else + { + memcpy(pAuthDataW, identity, sizeof(SEC_WINNT_AUTH_IDENTITY_W)); + } This looks funny. Why not just set pAuthDataW to identity in this case? That way you avoid the memcpy. Something like this: PSEC_WINNT_AUTH_IDENTITY_W pAuthDataW; if (identity->Flags == SEC_WINNT_AUTH_IDENTITY_ANSI) { /* convert it like you do */ } else pAuthDataW = (PSEC_WINNT_AUTH_IDENTITY_W)identity; /* call ntlm_AcquireCredentialsHandleW */ if (pAuthDataW != identity) HeapFree(GetProcessHeap(), 0, pAuthDataW); + if((ret = encodeBase64(helper->password, + helper->pwlen-2, buffer+3, + max_len-3, &buffer_len)) != SEC_E_OK) + { + HeapFree(GetProcessHeap(), 0, buffer); + HeapFree(GetProcessHeap(), 0, bin); + return ret; + } You ought to zero the memory of the password and free it, regardless of whether encodeBase64 succeeds or fails. (Really you ought to call SecureZeroMemory, but wine hasn't implemented that.. oh well.) In tests/ntlm.c: + //lstrcpyA(identity->Password, pass ? pass :""); No C++ style comments, please. More generally, on the tests, I like them because they should nearly always succeed in Windows. But they're not very likely to succeed in Wine, are they? You handle not having an ntlm_auth fairly gracefully, I think, and also handle not being able to create an inbound context, which you say may not work without some magic setup. But this won't generally work out of the box if ntlm_auth works and an inbound context can be created, can it? The tests will try to authenticate with whatever domain name is in the registry, or default to WORKGROUP if that's empty, and your UNIX username, and no password. That's not very likely to succeed. So, it would be nice to have these tests somewhere for people to check that this code indeed works.. but I'm not sure they can go into the regression test suite. Unless I'm mistaken. Thanks, --Juan ____________________________________________________ Start your day with Yahoo! - make it your home page http://www.yahoo.com/r/hs

1 0

Delphi 5 debugger is working!
by Vitaliy Margolen 24 Aug '05

24 Aug '05

As of todays CVS Delphi 5 debugger is fixed. Well, ok, there are still some bugs. One is a minor bug (Module view reports all modules as a project executable name), but all exports are there. You can even try to disassemble them. But here is where the major problems start. Debugger segfaults on that. This is because NtQueryVirtualMemory and NtProtectVirtualMemory currently don't work on other processes. I have modified those functions to return STATUS_SUCCESS instead. This allows to access ntdll, kernel32 and possibly any other modules that have the same base address for application and debugger. You might need prelink installed to relocate ntdll and kernel32 to 0x7bxxxxxx addresses. This makes their base addresses the same for all wine apps. Unfortunately fixing NtQueryVirtualMemory, NtProtectVirtualMemory and others is not that simple. Basically there are no way to do it from other processes. Ok, NtQueryVirtualMemory could be implemented some-what easily using NtReadVirtualMemory and possibly one more server call. But for others I see only three ways to implement them: 1. Adding worker thread to each process. This way we can ask it to perform requested operation for us. But, there is a catch - this will complicate lots of things. Besides, messing with processes is not a good thing(tm). It will brake some apps, that don't expect to see more then one thread. Or if we'll try to hide a worker thread, it will make things even worse. 2. Using signal(s). Unfortunately this is not as simple to do ether. From what I been told, this will require non trivial synchronization, that still doesn't guarantee deadlocks. 3. Infamous wine kernel module. Some how I don't think that kernel guys will go for this type of functionality. Even for debugging proposes, it still poses considerable security risk allowing one process manipulate other process' memory. So it will have to be a wine only module, which means we'll have to maintain in against all supported kernel versions and require kernel development environment. Any other solutions that I have forgotten/haven't even thought of? -- Best regards, Vitaliy

5 6

Re: Software patents
by gslink 24 Aug '05

24 Aug '05

The whole business of software patents is very likely to explode at any time. There are several software patents on cds and dvds which are so vague that it is impossible to tell exactly what is going on. The licenses to use these patents allow the company issuing the patent to control cd content and to examine it. The first time one of these companies tries to use the license to access DOD classified information there will be a resolution. The easiest way to resolve this business with Borland is to contact Borland. They may also have an interest in Wine. If they have no objection to what Wine wants to do then there is no one else to complain. They might even help Wine. Borland probably doesn't even realize that Wine exists although some of the people in Borland are probably very familiar with it. I think you will find this to be true of all big software companies such as IBM and Microsoft.

8 10

solution for including itss.h in hhctrl.ocx
by James Hawkins 24 Aug '05

24 Aug '05

Hey Alexandre, I need to be able to include itss.h from dlls/itss in order to read CHM files. Mike offered the solution that I add -I($SRCDIR)../itss to hhctrl's Makefile.in. The next problem comes when I run make depend. make depend looks for itss.h but can't find it because it hasn't been built yet. Mike then suggested adding ../dlls/itss/itss.idl to IDL_SRCS in include/Makefile.in. That works fine up until make install which gives these two errors: /usr/bin/install: cannot create regular file `/usr/include/wine/windows/../dlls/itss/itss.idl': No such file or directory /usr/bin/install: cannot create regular file `/usr/include/wine/windows/../dlls/itss/itss.h': No such file or directory Do you have any suggestions on how to access itss.h from hhctrl.ocx? -- James Hawkins

2 1

Re: commctrl: dialog theming
by Evil 24 Aug '05

24 Aug '05

I'm no longer able to run programs that require the native comctl32 and commctrl DLLs, since updating to today's CVS. Could it be related to these theme patches? It seems that now, if you override comctl32 for any app (or globally), even WineCfg itself will error out with the error. err:thunk:_loadthunk (commctrl.dll, Cctl1632_ThunkData16, comctl32.dll): Unable to load 'commctrl.dll', error 2 err:module:LdrInitializeThunk "comctl32.dll" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"c:\\windows\\system32\\winecfg.exe" failed, status c0000142 The native commctrl.dll and comctl32.dll both exist in my windows/system directory - the same versions that always worked before. Overriding commctrl doesn't have any effect on this error. -J Frank Richter wrote: >This patch assumes the listbox patch was applied before. > >Frank Richter <frank.richter(a)gmail.com> >Add theming support for dialogs (to support tab page background). > >

5 9

wine error with 'wine client error:d: write: Bad file descriptor'
by Oliver Mössinger 24 Aug '05

24 Aug '05

Hi wine-devel, i have a windows program whitch generates the attached 'wine.txt' wine output. Followed is a part of the output: >>> Threads: process tid prio (all id:s are in hex) 00000042 (D) C:\MGC\LeoSpec\LS2005a_82\bin\win32\leonardo.exe 00000017 0 0000000d 0 <== 0000000e 00000016 0 00000013 0 00000012 0 00000011 0 00000010 0 0000000f 0 WineDbg terminated on pid 0x42 wine client error:d: write: Bad file descriptor <<< The program works with windows! Can someone help me to run the program? thanks Oliver Mössinger

1 0

Re: secur32: Getting real functionality into the NTLM provider
by Alexandre Julliard 24 Aug '05

24 Aug '05

Kai Blin <blin(a)gmx.net> writes: > + unsigned char buffer[SECUR32_MAX_BUF_LEN+6000]; > + BYTE bin[SECUR32_MAX_BUF_LEN]; You shouldn't allocate fixed size buffers on the stack, especially not huge ones like that. You should compute the necessary size and allocate a properly sized buffer from the heap. > + SEC_CHAR client_user_arg[512]; > + SEC_CHAR client_domain_arg[512]; > + SEC_CHAR passwd[512] = {0}; Same here, there's nothing that guarantees the buffers are the right size; using snprintf may avoid overflows but it doesn't make the code behave correctly. > +SECURITY_STATUS fork_helperA(PNegoHelperA *new_helper, const char *prog, > + char * const argv[], char* passwd) > +{ You should have a single fork helper that takes Unicode, you can't pass ASCII chars to the Unix app anyway, you have to use CP_UNIXCP. And more generally, you should do everything in Unicode. > + if( ( pipe(pipe_in) < 0 ) || ( pipe(pipe_out) < 0 ) ) > + { > + return SEC_E_INTERNAL_ERROR; > + } > + > + helper->helper_pid = fork(); > + > + helper->password = passwd; > + > + if(helper->helper_pid == -1) > + { > + return SEC_E_INTERNAL_ERROR; > + } You are leaking file descriptors in the error cases. > + if(helper->helper_pid == 0) > + { > + /* We're in the child now */ > + close(0); > + close(1); > + > + dup2(pipe_out[0], 0); > + close(pipe_out[0]); > + close(pipe_out[1]); > + > + dup2(pipe_in[1], 1); > + close(pipe_in[0]); > + close(pipe_in[1]); > + > + execvp(prog, argv); > + > + /* Whoops, we shouldn't get here. Big badaboom.*/ > + return SEC_E_INTERNAL_ERROR; You shouldn't return from the child, you should pass the error back to the parent and then exit(). > + { > + helper->pipe_in = fdopen(pipe_in[0], "r"); > + close(pipe_in[1]); > + helper->pipe_out = fdopen(pipe_out[1], "w"); > + close(pipe_out[0]); > + } You should avoid using stdio. -- Alexandre Julliard julliard(a)winehq.org

2 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel