wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Buttons in window title bar
by Michael Jung 22 Jul '05

22 Jul '05

Hi, since this patch (http://www.winehq.org/hypermail/wine-cvs/2005/07/0168.html) was applied, the buttons in the window title bars are plain squares on my system. I'm wondering if I have a problem with my font setup. Do other people have this problem (You will only see it in desktop mode or in MDI applications though)? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

5 7

Re: SETUPAPI: Fix whitespace handling in the INF parser.
by Alexandre Julliard 22 Jul '05

22 Jul '05

Matthew Davison <mjd77(a)cam.ac.uk> writes: > Without this patch, the INF parser in setupapi will strip any spaces > which are not inside quotes from an INF file. Windows will only strip > spaces at the start and end of each field/line. This is supposed to be handled by the TRAILING_SPACES state already. Do you have a test case demonstrating the problem? -- Alexandre Julliard julliard(a)winehq.org

2 4

D3DCMPFUNC fix
by Paul Walker 22 Jul '05

22 Jul '05

A tried to run Morrowind (it fails loading the outdoors). I saw a message of unsupported D3DCMPFUNC. So I looked up MSDN and it mentioned defaults, so I've added them. Not sure if they also need to be in the d3d8/ directory too? It didn't fix my problem, but it is probably still useful to have.

1 0

dlls/wined3d/drawprim.c warnings
by Gerald Pfeifer 22 Jul '05

22 Jul '05

I'm currently seeing the following, new warnings for dlls/wined3d/drawprim.c: drawprim.c: In function `primitiveConvertToStridedData': drawprim.c:540: warning: unused variable `canDoViaGLPointers' drawprim.c: At top level: drawprim.c:702: warning: `draw_vertex' defined but not used The former is fixed by the patch below (the variable not being used anywhere). The latter has been introduced by the following cleanup patch: revision 1.16 date: 2005/07/14 12:19:53; author: julliard; state: Exp; lines: +9 -9 Stefan Huehner <stefan(a)huehner.org> Fix some missing-declarations warnings. Gerald ChangeLog: Remove unused variable in primitiveConvertToStridedData(). Index: drawprim.c =================================================================== RCS file: /home/wine/wine/dlls/wined3d/drawprim.c,v retrieving revision 1.19 diff -u -3 -p -r1.19 drawprim.c --- drawprim.c 21 Jul 2005 11:01:19 -0000 1.19 +++ drawprim.c 22 Jul 2005 06:41:51 -0000 @@ -537,7 +537,6 @@ static void primitiveConvertToStridedDat short LoopThroughTo = 0; short nStream; - BOOL canDoViaGLPointers = TRUE; int numBlends; int numTextures; int textureNo;

1 0

Re: HHCTRL.OCX: fix W to A call
by Dmitry Timoshkov 21 Jul '05

21 Jul '05

"Saulius Krasuckas" <saulius2(a)ar.fi.lt> wrote: > ChangeLog: > Saulius Krasuckas <saulius.krasuckas(a)ieee.org> > Fix W to A call. I don't see much point in such a "fix". It actually fixes nothing, and removes a readability of the message. -- Dmitry.

6 6

Re: Update win32.api
by Vincent Béron 21 Jul '05

21 Jul '05

Le jeu 21/07/2005 à 12:17, Francois Gouget a écrit : [snip] > Index: dlls/secur32/secur32.c > =================================================================== > RCS file: /var/cvs/wine/dlls/secur32/secur32.c,v > retrieving revision 1.7 > diff -u -p -r1.7 secur32.c > --- dlls/secur32/secur32.c 18 Jul 2005 09:11:14 -0000 1.7 > +++ dlls/secur32/secur32.c 19 Jul 2005 13:26:26 -0000 > @@ -958,7 +958,7 @@ BOOLEAN WINAPI GetUserNameExW( > NTSTATUS WINAPI LsaCallAuthenticationPackage( > HANDLE LsaHandle, ULONG AuthenticationPackage, PVOID ProtocolSubmitBuffer, > ULONG SubmitBufferLength, PVOID* ProtocolReturnBuffer, PULONG ReturnBufferLength, > - NTSTATUS *ProtocolStatus) > + PNTSTATUS ProtocolStatus) This causes a compilation error, PNTSTATUS isn't defined anywhere else. Or do you have an as of yet unsent patch adding it? :) Vincent

1 0

printing problems
by josie＠mbstemps.com 21 Jul '05

21 Jul '05

Hi I've been running Delphi executables off of Wine and I just installed a default printer to my linux system. It's a miracle but I could print off of my Delphi executable on the first try. The only problem is the margins and page layout are little off. Nothing drastic, but the margins cutoff the first line and about half a character on the left margin. I was wondering if this is a postscript problem and what I could do to fix it? -Josie

1 0

wow32 forwards going into the void?
by Marcus Meissner 21 Jul '05

21 Jul '05

Hi, dlls/wow32/wow32.spec forwards into our kernel32.dll by named imports. However, the referenced functions are no longer exported by name. Also jsut replacing the function by a number does not seem to work. How to fix? Ciao, Marcus

1 0

Re: [wined3d] numblends
by Raphael 21 Jul '05

21 Jul '05

On Wednesday 20 July 2005 20:18, you wrote: > Hi, > This patch corrects a problem with the way that FVF vertex arrays > containing blends or orthographic is calcualted. > > This patch should get Axis and Allies and Kohan 2 started > Good catch :) Regards, Raphael

2 1

Re: foward declare interfaces in stdole2
by Huw D M Davies 21 Jul '05

21 Jul '05

On Thu, Jul 21, 2005 at 12:06:15PM +0530, Vijay Kiran Kamuju wrote: > This fixes the below problem, same problem i faced with msxml > interfaces and forward declarations fixed it. > > ChangeLog > ---------------- > Forward declare interfaces This isn't what we want anyway, since it changes the order of the typeinfos in the typelib. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Run-time error '13'
by Savio Ramos 21 Jul '05

21 Jul '05

Hi, I am using wine without problems but after upgrade for release 0.0.20050628-2, this error appeared in a window after SISUPFOR.exe started: Run-time error '13' Type mismatch Any help? Thanks. -- Savio Martins Ramos - Arquiteto Rio de Janeiro ICQ 174972645 Pirataria não! Seja livre: Linux http://www.debian.org _______________________________________________________ Yahoo! Acesso Grátis - Internet rápida e grátis. Instale o discador agora! http://br.acesso.yahoo.com/

3 5

std* streams in MSVC
by Saulius Krasuckas 21 Jul '05

21 Jul '05

I am testing code: | #include <stdio.h> | | void main( void ) | { | printf( "The file handle for stdin is %p %d\n", stdin, _fileno( stdin )); | printf( "The file handle for stdout is %p %d\n", stdout, _fileno( stdout )); | printf( "The file handle for stderr is %p %d\n", stderr, _fileno( stderr )); | } I link with no libraries and get following output: | The file handle for stdin is 00424A30 0 | The file handle for stdout is 00424A50 1 | The file handle for stderr is 00424A70 2 If I link with msvcrtd.lib, then output is: | The file handle for stdin is 004150B0 270578480 | The file handle for stdout is 004150D0 270608264 | The file handle for stderr is 004150F0 0 And this I get with msvcrt.lib: | The file handle for stdin is 004150B0 2013313950 | The file handle for stdout is 004150D0 2013328746 | The file handle for stderr is 004150F0 0 Calls to freopen(), fprintf(), setvbuf() using any std* stream throws an exception in last two cases (msvcrtd.lib and msvcrt.lib). I guess pointers are left uninitialized. Anybody knows why and how to make this code work in all three cases?

1 0

Re: stdole2.tlb
by Ivan Gyurdiev 21 Jul '05

21 Jul '05

> I've not tested this with an InstallShield installer - feedback > welcome. Thank you very much - GTA will now begin installing, will get through all the InstallShield screens, and then it gets to the last one where it should begin installing, and it freezes and nothing happens. fixme:font:load_VDMX Failed to retrieve vTable fixme:font:load_VDMX Failed to retrieve vTable fixme:font:load_VDMX Failed to retrieve vTable fixme:system:SystemParametersInfoW Unimplemented action: 8202 (SPI_GETFONTSMOOTHINGTYPE) fixme:system:SystemParametersInfoW Unimplemented action: 8202 (SPI_GETFONTSMOOTHINGTYPE) fixme:system:SystemParametersInfoW Unimplemented action: 8202 (SPI_GETFONTSMOOTHINGTYPE) fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects ... (more of this) fixme:win:SetWindowTextA setting text "TITLE_CAPTIONBAR" of other process window (nil) should not use SendMessage fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff fixme:win:SetWindowTextA setting text "GTA San Andreas - InstallShield Wizard" of other process window (nil) should not use SendMessage fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff .... fixme:ole:RpcChannelBuffer_GetDestCtx (0x7fcad3f8,0x7fcad3fc), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x7fcad2f8,0x7fcad2fc), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x7fcad37c,0x7fcad380), stub! fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0000ffff fixme:ole:RpcChannelBuffer_GetDestCtx (0x7fcad8e4,0x7fcad8e8), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x7fcad7e4,0x7fcad7e8), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x7fcad868,0x7fcad86c), stub! ... (more of this)

1 0

Re: headers: handle sizeof(long)==8
by Raphael 21 Jul '05

21 Jul '05

On Wednesday 20 July 2005 05:00, Kevin Koltzau wrote: > Changelog > If sizeof(long)==8, define DWORD and LONG as 32bit int Hi, Why not using basetsd.h defines instead ? Regards, Raphael

2 1

Re: File dialogs *should* browse to the directory when a directory name is typed in and the "Open" button or save button is clicked
by Huw D M Davies 20 Jul '05

20 Jul '05

On Wed, Jul 20, 2005 at 04:18:55PM +1000, Troy Rollo wrote: > This patch reverses the change made by change set 17928 > <http://cvs.winehq.org/patch.py?id=17928>. Under windows if you type in the > name of a directory these dialogs do browse to that directory. As far as I > can tell 17928 does nothing other than make the Wine dialog's behaviour > diverge from native Windows behaviour. > > ChangeLog: > Reverse change set 17928 - the correct behaviour in Windows is to > browse to the directory if a directory name is typed into the edit box > of a file dialog and the confirmation button (or Enter key) is hit. Hmm, there's clearly something else going on here as I didn't just make up this behaviour. Huw. -- Huw Davies huw(a)codeweavers.com

2 1

Today's winetest build?
by Paul Millar 20 Jul '05

20 Jul '05

Hi, I've noticed that the test site (test.winehq.org/data) has no mention of today's cron-build of winetest. Having monkeyed about with the build process over the weekend (but, I thought, not that part) I'm a little worried I might have inadvertently upset the part that registers a new cron-build. Could someone check that test.winehq.org/service received a (http) hit today? Cheers, Paul.

5 6

Celebrating some hard work
by Jeremy White 20 Jul '05

20 Jul '05

Hi folks, You may have noticed Rob submitting a long string of OLE patches. That is formally the last set of 'hard work' we planned to do as part of our work on our 5.0 release. Now we just have to do the 'easy part' - stabilizing for release <g>. The big picture items included the window manager rewrite, the OLE/COM work, and the work on MSI. I'd like to take a minute to thank all the people, both inside and outside CodeWeavers, that helped to work on these projects. I think that these tasks represent a fairly signficant milestone for Wine - we seem to have enough working that Alexandre is willing to contemplate a non alpha release; that's a pretty big deal. (Another 11 years, and maybe 1.0 will actually happen :-/). At any rate, this work has been a bit hard on us, because it's largely been under the hood, unsexy work that tends to cause regressions. So from a customer perspective, the rational analysis is: "you did all that work and now my windows don't scroll right? Morons!" But one of the key benefits that the OLE/MSI work gives us, in particular, is that we can now intelligently debug issues with COM, which was always a nightmare to debug before. And, as you all probably know, many installers rely heavily on both COM and MSI to do their work. So we now believe that many, many more installers will 'just work' than before. And we further believe that those that don't work can be fixed in a much more straightforward way. Thus, I am now making good on my promise to lock Rob and Aric in a room and make installers go. We've announced a formal, CrossOver based program over on our web site. However, I wanted to let you know that we'll do the same on an informal basis, particularly for known Wine developers. I'm hoping that as a result of this work we'll soon be able to claim with a straight face: "Most things install." So, if you have an app that doesn't install, post a message to wine-devel, and let's see if we can't make some lemonade and have a party! Cheers, Jeremy

9 9

Re: WLDAP32: implement ldap_simple_bind* and ldap_unbind* functions
by Felix Nawothnig 20 Jul '05

20 Jul '05

Hans Leidekker wrote: > Although not strictly necessary, I did the ldap_unbind functions > as wrappers because I'd like the debug logging to show ldap_bind > and matching ldap_unbind calls. Does +relay not work here? Felix

1 0

Re: [HHCTRL #1] Add the WebBrowser header
by Alexandre Julliard 20 Jul '05

20 Jul '05

James Hawkins <truiken(a)gmail.com> writes: > +HRESULT STDMETHODCALLTYPE Storage_QueryInterface(IStorage *This, REFIID riid, LPVOID *ppvObj); > +ULONG STDMETHODCALLTYPE Storage_AddRef(IStorage *This); > +ULONG STDMETHODCALLTYPE Storage_Release(IStorage *This); > +HRESULT STDMETHODCALLTYPE Storage_CreateStream(IStorage *This, const WCHAR *pwcsName, DWORD grfMode, DWORD reserved1, DWORD reserved2, IStream **ppstm); > +HRESULT STDMETHODCALLTYPE Storage_OpenStream(IStorage *This, const WCHAR * pwcsName, void *reserved1, DWORD grfMode, DWORD reserved2, IStream **ppstm); > +HRESULT STDMETHODCALLTYPE Storage_CreateStorage(IStorage *This, const WCHAR *pwcsName, DWORD grfMode, DWORD reserved1, DWORD reserved2, IStorage **ppstg); > +HRESULT STDMETHODCALLTYPE Storage_OpenStorage(IStorage *This, const WCHAR * pwcsName, IStorage * pstgPriority, DWORD grfMode, SNB snbExclude, DWORD reserved, IStorage **ppstg); > +HRESULT STDMETHODCALLTYPE Storage_CopyTo(IStorage *This, DWORD ciidExclude, IID const *rgiidExclude, SNB snbExclude,IStorage *pstgDest); > +HRESULT STDMETHODCALLTYPE Storage_MoveElementTo(IStorage *This, const OLECHAR *pwcsName,IStorage * pstgDest, const OLECHAR *pwcsNewName, DWORD grfFlags); > +HRESULT STDMETHODCALLTYPE Storage_Commit(IStorage *This, DWORD grfCommitFlags); > +HRESULT STDMETHODCALLTYPE Storage_Revert(IStorage *This); > +HRESULT STDMETHODCALLTYPE Storage_EnumElements(IStorage *This, DWORD reserved1, void * reserved2, DWORD reserved3, IEnumSTATSTG ** ppenum); > +HRESULT STDMETHODCALLTYPE Storage_DestroyElement(IStorage *This, const OLECHAR *pwcsName); > +HRESULT STDMETHODCALLTYPE Storage_RenameElement(IStorage *This, const WCHAR *pwcsOldName, const WCHAR *pwcsNewName); > +HRESULT STDMETHODCALLTYPE Storage_SetElementTimes(IStorage *This, const WCHAR *pwcsName, FILETIME const *pctime, FILETIME const *patime, FILETIME const *pmtime); > +HRESULT STDMETHODCALLTYPE Storage_SetClass(IStorage *This, REFCLSID clsid); > +HRESULT STDMETHODCALLTYPE Storage_SetStateBits(IStorage *This, DWORD grfStateBits, DWORD grfMask); > +HRESULT STDMETHODCALLTYPE Storage_Stat(IStorage *This, STATSTG * pstatstg, DWORD grfStatFlag); Functions that are not used in other files should be declared static, you should only export functions that really have to be used somewhere else. That will save Mike some trouble... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: difference with long datatype in 64bit gcc and msvc++
by Juan Lang 20 Jul '05

20 Jul '05

Kevin wrote: > Binary compatibility with win64 will be just about impossible as the > long datatype is used extensively throughout the headers and code > > doing -Dlong=int works in simple cases, but not as a general rule Can you give an example of a non-simple case? What about defining LONG as int in win64? --Juan ____________________________________________________ Start your day with Yahoo! - make it your home page http://www.yahoo.com/r/hs

4 3

[AppDB] Fix app and version links in adminBugs.php
by Tony Lambregts 20 Jul '05

20 Jul '05

Change Log: Fix application and version links (Doh!) Files Changed: admin/adminBugs.php Index: admin/adminBugs.php =================================================================== RCS file: /home/wine/appdb/admin/adminBugs.php,v retrieving revision 1.1 diff -u -r1.1 adminBugs.php --- admin/adminBugs.php 20 Jul 2005 02:29:17 -0000 1.1 +++ admin/adminBugs.php 20 Jul 2005 04:08:30 -0000 @@ -145,11 +145,11 @@ echo ' <td align=center>'.$oRow->bug_status.'</td>',"\n"; echo ' <td>'.$oRow->short_desc.'</td>',"\n"; echo ' <td>',"\n"; - echo ' <a href="appview.php?appId='.$oRow->appId.'">'.$oRow->appName.'</a>',"\n"; + echo ' <a href="'.apidb_fullurl('appview.php?appId='.$oRow->appId).'">'.$oRow->appName.'</a>',"\n"; echo ' </td>',"\n"; echo ' <td>'.$oRow->appDescription.'</td>',"\n"; echo ' <td>',"\n"; - echo ' <a href="appview.php?versionId='.$oRow->versionId.'">'.$oRow->versionName.'</a>',"\n"; + echo ' <a href="'.apidb_fullurl('appview.php?versionId='.$oRow->versionId).'">'.$oRow->versionName.'</a>',"\n"; echo ' </td>',"\n"; echo ' <td align=center>[<a href="adminBugs.php?sub=delete',"\n"; echo '&buglinkId='.$oRow->linkId,"\n";

1 0

FreeBSD and wine DVD/CD read errors
by Jeffrey Zellman 20 Jul '05

20 Jul '05

Hi, I am currently running FreeBSD 5.4 and Wine 20050310. When I startup Wine with DVDShrink, I get the following output to the terminal: fixme:file:get_default_drive_device auto detection of DOS devices not supported on this platform fixme:cdrom:CDROM_GetInterfaceInfo not implemented for BSD fixme:ntdll:NtQueryVolumeInformationFile device info not properly supported on this platform Please use the registry key HKEY_CURRENT_CONFIG\Software\Fonts\LogPixels to set the screen resolution and remove the "Resolution" entry in the config file fixme:ole:CoRegisterMessageFilter stub err:x11drv:X11DRV_CreateWindow invalid window height 3339982 err:x11drv:X11DRV_CreateWindow invalid window height 3339982 err:listview:LISTVIEW_WindowProc unknown msg 1044 wp=00000000 lp=0033e5a0 fixme:ole:CoCreateInstance no classfactory created for CLSID {e436ebb2-524f-11ce-9f53-0020af0ba770}, hres is 0x80040154 err:quartz:FILTERGRAPH_create Unable to create filter mapper (80040154) fixme:ole:CoCreateInstance no instance created for interface {56a868a9-0ad4-11ce-b03a-0020af0ba770} of class {e436ebb3-524f-11ce-9f53-0020af0ba770}, hres is 0x80040154 When I try to read a DVD with DVDShrink I get an error message in DVDShrink: "DVD Shrink encountered an error and cannot continue. Failed to read file "D:\" Not Ready I also get some more output to the terminal: fixme:cdrom:DVD_ReadStructure fixme:cdrom:DVD_ReadStructure I guess my question is, has anyone had success working with wine, *BSD and DVD Shrink or any other program that uses CD/DVD devices? I've had success with wine under linux, but I am more comfortable under *BSD. thanks, Jeff

1 0

[AppDB] Use display_page_range() in admin/adminCommentView.php
by Tony Lambregts 20 Jul '05

20 Jul '05

Change Log: Use display_page_range() Files Changed: admin/adminCommentView.php Index: admin/adminCommentView.php =================================================================== RCS file: /home/wine/appdb/admin/adminCommentView.php,v retrieving revision 1.7 diff -u -r1.7 adminCommentView.php --- admin/adminCommentView.php 9 Feb 2005 23:49:21 -0000 1.7 +++ admin/adminCommentView.php 20 Jul 2005 02:16:56 -0000 @@ -10,91 +10,54 @@ apidb_header("Comments"); -function display_range($currentPage, $pageRange, $totalPages, $commentsPerPage) -{ - /* display the links to each of these pages */ - if($currentPage != 0) - { - $previousPage = $currentPage - 1; - echo "<a href='adminCommentView.php?page=$previousPage&commentsPerPage=$commentsPerPage'>Previous</a> "; - } else - echo "Previous "; - - /* display the next 10 and previous 10 pages */ - $pageRange = 10; +/* display a range of 10 pages */ +$pageRange = 10; - if($currentPage > $pageRange) - $startPage = $currentPage - $pageRange; - else - $startPage = 0; - - if($currentPage + $pageRange < $totalPages) - $endPage = $currentPage + $pageRange; - else - $endPage = $totalPages; - - /* display the desired range */ - for($x = $startPage; $x <= $endPage; $x++) - { - if($x != $currentPage) - echo "<a href='adminCommentView.php?page=$x&commentsPerPage=$commentsPerPage'>$x</a> "; - else - echo "$x "; - } - - if($currentPage < $totalPages) - { - $nextPage = $currentPage + 1; - echo "<a href='adminCommentView.php?page=$nextPage&commentsPerPage=$commentsPerPage'>Next</a> "; - } else - echo "Next "; -} - -$commentsPerPage = 10; -$currentPage = 0; +$ItemsPerPage = 10; +$currentPage = 1; +if($_REQUEST['ItemsPerPage']) + $ItemsPerPage = $_REQUEST['ItemsPerPage']; if($_REQUEST['page']) $currentPage = $_REQUEST['page']; -if($_REQUEST['commentsPerPage']) - $commentsPerPage = $_REQUEST['commentsPerPage']; +$totalPages = ceil(getNumberOfComments()/$ItemsPerPage); -$totalPages = floor(getNumberOfComments()/$commentsPerPage); +if($ItemsPerPage > 100) $ItemsPerPage = 100; -if($commentsPerPage > 100) $commentsPerPage = 100; /* display page selection links */ echo "<center>"; echo "<b>Page $currentPage of $totalPages</b><br />"; -display_range($currentPage, $pageRange, $totalPages, $commentsPerPage); +display_page_range($currentPage, $pageRange, $totalPages, $_SERVER['PHP_SELF']."?ItemsPerPage=".$ItemsPerPage); echo "<br />"; echo "<br />"; /* display the option to choose how many comments per-page to display */ echo "<form method=\"get\" name=\"message\" action=\"".$_SERVER['PHP_SELF']."\">"; echo "<b>Number of comments per page:</b>"; -echo "<select name='commentsPerPage'>"; +echo "&nbsp<select name='ItemsPerPage'>"; -$commentsPerPageArray = array(10, 20, 50, 100); -foreach($commentsPerPageArray as $i => $value) +$ItemsPerPageArray = array(10, 20, 50, 100, 500); +foreach($ItemsPerPageArray as $i => $value) { - if($commentsPerPageArray[$i] == $commentsPerPage) - echo "<option value='$commentsPerPageArray[$i]' SELECTED>$commentsPerPageArray[$i]"; + if($ItemsPerPageArray[$i] == $ItemsPerPage) + echo "<option value='$ItemsPerPageArray[$i]' SELECTED>$ItemsPerPageArray[$i]"; else - echo "<option value='$commentsPerPageArray[$i]'>$commentsPerPageArray[$i]"; + echo "<option value='$ItemsPerPageArray[$i]'>$ItemsPerPageArray[$i]"; } echo "</select>"; echo "<input type=hidden name=page value=$currentPage>"; -echo "<input type=submit value='Refresh'>"; +echo "&nbsp<input type=submit value='Refresh'>"; echo "</form>"; echo "</center>"; /* query for all of the commentId's, ordering by their time in reverse order */ -$offset = $currentPage * $commentsPerPage; +$offset = (($currentPage-1) * $ItemsPerPage); $commentIds = query_appdb("SELECT commentId from appComments ORDER BY ". - "appComments.time ASC LIMIT $offset, $commentsPerPage;"); + "appComments.time ASC LIMIT $offset, $ItemsPerPage;"); while ($ob = mysql_fetch_object($commentIds)) { $qstring = "SELECT from_unixtime(unix_timestamp(time), \"%W %M %D %Y, %k:%i\") as time, ". @@ -107,8 +70,9 @@ } /* display page selection links */ + echo "<center>"; -display_range($currentPage, $pageRange, $totalPages, $commentsPerPage); +display_page_range($currentPage, $pageRange, $totalPages, $_SERVER['PHP_SELF']."?ItemsPerPage=".$ItemsPerPage); echo "</center>"; apidb_footer();

1 0

Re: [version/info.c] Don't always convert win32 to win16 structure
by Steven Edwards 19 Jul '05

19 Jul '05

Hi Paul, On Tue, 2005-07-19 at 22:34 +0200, Paul Vriens wrote: > I have to find a better way to retrieve the strings from the unicode > structure in VerQueryValueA (instead of converting the whole structure) > though. > > I do still have a small issue with a 16bit windows application. It seems > that the version is wrong here. But hey, Process Explorer on Windows > doesn't show the process at all :-). While you are working on this could you look at moving the 16bit version resouce stuff to shell32.ExtractVersionResource16W. Its undocumented but according to my tests native version.dll uses it when doing 16bit resource lookups. Thanks Steven

1 0

difference with long datatype in 64bit gcc and msvc++
by Kevin Koltzau 19 Jul '05

19 Jul '05

gcc and msvc++ have different opinions on the size of a long in 64bit code, gcc has sizeof(long)==8 while msvc++ has sizeof(long)==4 Binary compatibility with win64 will be just about impossible as the long datatype is used extensively throughout the headers and code doing -Dlong=int works in simple cases, but not as a general rule I'm at a loss as to where to go from here, suggestions are most welcome.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel