wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Theming
by Frank Richter 06 Jul '05

06 Jul '05

Hi, I've recently submitted a patch to add initial theming support for push buttons. Most likely I'll have to iterate over it a few times before it could get accepted into CVS, so I'd like to just query for comments/questions/criticism on it. Thanks! Patch: http://www.winehq.org/hypermail/wine-patches/2005/07/0073.html -f.r.

2 3

Re: [WINECFG] Japanese translation
by Frank Richter 06 Jul '05

06 Jul '05

On 05.07.2005 09:28, Hajime Segawa wrote: > +FONT 9, "MS UI Gothic" Isn't it on Windows the case that dialogs generally use "MS Shell Dlg[ 2]", which is at runtime mapped to a font appropriate for the language (e.g. "MS UI Gothic" for Japanese)? This link, while not 100% on that topic, contains some links: http://blogs.msdn.com/michkap/archive/2005/03/20/399322.aspx -f.r.

3 2

Re: support for gradient captions (resend)
by Dmitry Timoshkov 06 Jul '05

06 Jul '05

"Frank Richter" <frank.richter(a)gmail.com> wrote: > (Now using GradientFill() instead of GdiGradientFill().) > --- dlls/user/Makefile.in (/wine/trunk/dlls/user) (revision 21713) > +++ dlls/user/Makefile.in (/me/trunk/dlls/user) (local) > @@ -5,7 +5,7 @@ > VPATH = @srcdir@ > MODULE = user32.dll > IMPORTLIB = libuser32.$(IMPLIBEXT) > -IMPORTS = gdi32 advapi32 kernel32 ntdll > +IMPORTS = gdi32 msimg32 advapi32 kernel32 ntdll It's even worse. user32 can't depend on msimg32 or any other high level dll. Just add GdiGradientFill to wingdi.h and resend your 1st patch. -- Dmitry.

2 2

Re: support for gradient captions
by Dmitry Timoshkov 06 Jul '05

06 Jul '05

"Frank Richter" <frank.richter(a)gmail.com> wrote: > --- dlls/user/nonclient.c (/wine/trunk) (revision 21713) > +++ dlls/user/nonclient.c (/me/trunk) (local) > @@ -197,6 +197,69 @@ > return hIcon; > } > > +extern BOOL WINAPI GdiGradientFill (HDC, PTRIVERTEX, ULONG, PVOID, ULONG, ULONG); wingdi.h is a more appropriate place for this. -- Dmitry.

1 0

Re: [ntdll] load all dll sections no matter what attributes say
by Eric Pouech 06 Jul '05

06 Jul '05

Vitaliy Margolen a écrit : > Vitaliy Margolen > > changelog: > dlls/ntdll/virtual.c > Load all dll sections no matter what attributes say why do you need this ? A+ -- Eric Pouech

3 4

sample msxml3 implementation
by Vijay Kiran Kamuju 06 Jul '05

06 Jul '05

Hi, I thought i have some suggestions in implementing the msxml3.dll I am sending an old sample stub implemenation (incomplete). I am rewriting the msxml3.dll need some suggestions. Thanks, Vijay

2 3

wine configuration via the registry and such
by Ray 06 Jul '05

06 Jul '05

Hi, I'm Ray, and I am a wine addict. ;) Seeing how a big step is made, I thought I'd drop a line concerning the "new way" to configure wine. First off, it's great to have some GUI to setup wine, though the config file was kind of handy and simple to use. There had to be changes with the winecfg tool though. But seeing how the configuration now is plainy stuffed into the "normal" registry, and how the important keys are simply get mixed up with other stuff makes me wonder if it could be done otherwise. I also wondered why exactly the registry is used for wine configuration and not a single config file? Winecfg could store the exactly same settings in the config file, too. Of course, on one hand to be as much "windows-ish" as possible, the registry seems to be the way, on the other hand, since wine comes from the linux side, I cannot really see some argument against ONE SINGLE easy-to-handle config file. >From the aspect of a GUI usage, I can't think of an real difference between both, except where the settings are stored. I might miss something else as well, though. But secondly, the winecfg tool is basically not usable for a basic setup or the switch from config file to the registry (yet). In other words, I based my configuration on the Sidenet-configuration-tool once and simply can't be bothered to hack all those DLL settings in via the GUI. And this everytime I have to reconfigure or setup (a new) wine. And there are more settings than just the DLL ones. Of course, once the basic configuration is done, one could use the registry editor to export a couple .reg files for later reimports. Basically it is what I do/did, I just "patched" the Sidenet-1.8.2-script to import .reg files, of course shortly before 1.8.3 came out ;* So I now ended up in doing it the .INF-file way .. it appears to be the best one for script based setup, too. But using simply and ONLY winecfg for setting wine up is hardly practicable if you have an existing configuration to implement. Editing the .reg files in an editor is somewhat strange since all the registrykeys are re-arranged every time wine is started, that means a lot of searching, especially if software has been installed. It also appears there is no coherent block of wine configuration settings, which was some kind of advance for the config file. Another advance was the ability to comment things out in the config file, if you do it the same way in the .reg file it gets deleted with the next wine start. A possible solution is not to comment the whole line out, but change the key's name (e.g. "comctl32"="native" => ";comctl32"="native"). But that again causes the key to be re-arranged and you have to find it again. Granted, using this example it is just moved up to the beginning of the section, plus you can see all the "commented" keys at once.. on the other hand, I don't really know what happens with those keys, since they are not really taken out of the configuration. And it's not very handy to delete and recreate those entries via winecfg in case of error/bug search or whatever. There is an option "disable" on the libraries tab, but it seems to completely disable the use of a DLL. (Err.. just like it says ^^) Speaking of comments, there is also no possibility to comment sections in the configuration anymore, which make it difficult to always remember why a setting has been made, what are there for options etc. This is not good, and even more if the whole configuration stuff is not arranged using my (the users) order/system but wine's :~ I think some im- and export interface for settings in the winecfg tool could be useful. (Using Sidenet seems to be useful, too, but .. I don't think it'd be too much of a redundance :D) Maybe there also should be some kind of description/comment lines available in the GUI. And I think it would be nice to have a way to disable a setting (read: comment out), mostly and especially on the libraries tab. And what I would like to see is some extra .reg file like "wine.reg" where all (real) wine related stuff is stored. This way one can simply transfer wine settings from one wine instance to another without having any worries about accidently catching some keys made by other software. "Native" editing would be much more simpler, too. Another advantage would be that one can easily "reset" a screwed configuration by restoring a backup of the file without the risk of screwing registry entries of installed software. And finally, there is the documentation issue. Many basic config file sections and options are documented, but not all, most of them can be simply "converted" to the registry ones, some of them are commented in the source but may lack of documentation, some are just .. however, the point I am trying to make is, that guessing things because they are undocumented is something from the windows world I do not really want to be "emulated" with wine. ;D -Rayston

1 0

Re: PATCH: EXTRACFLAGS removal from configure
by Alexandre Julliard 06 Jul '05

06 Jul '05

Marcus Meissner <marcus(a)jet.franken.de> writes: > EXTRACFLAGS and CFLAGS complement it each other in the configure.ac script, > I see no need to have it "EXTRA". The reason for it is that the user is allowed to set his own CFLAGS, so the Wine flags have to be in EXTRACFLAGS. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: PATCH: avifile init/exit handling
by Andreas Mohr 06 Jul '05

06 Jul '05

Hi, On Wed, Jul 06, 2005 at 08:14:14AM +0200, Marcus Meissner wrote: > Hi, > > This implements Roberts suggestion of uninitializing Ole if it is no > longer needed. > > Ciao, Marcus > > Changelog: > Call OleUninitialize() on last AVIFileExit() > +static int ole_initialized = 0; > + > + if (!ole_initialized++) > + OleInitialize(NULL); Isn't that somewhat racey? Probably better to use InterlockedIncrement() here. Andreas Mohr

1 0

Re: Half-Life 2 / Counter-Strike: Source under Wine
by Paul Vriens 06 Jul '05

06 Jul '05

> Why it need StackWalk64 ? > Do you use a windows-64 bit version ? You can call the *64 functions without running a 64-bit version of windows or the dll. I had to forward SymLoadModule64 to SymLoadModule to solve an issue in Process Explorer. This however means that more and more apps are going to use the *64 funtions and that our dbghelp needs an overhaul (any volunteers ?). Cheers, Paul.

1 0

Re: fyi link to wine-wiki based on your forum post
by James Liggett 06 Jul '05

06 Jul '05

I think this should also go into the official Wine Wiki too. But anyways, thanks very much for the exposure :) James On Wed, 2005-07-06 at 15:40 +1200, Joseph Black wrote: > I have copied some of what you wrote in the forum into the unofficial > wine-wiki, > but I would appreciate a quick look over in case I have made an error > Here is a link for your perusal. > > http://wiki.jswindle.com/index.php/Palm_Desktop > > there is also some info about dcom,and ie that may be of interest. > > If you wish me to remove /change/ fix.. :-) , please email me > directly, or help > yourself to remove/change/make anon etc.. > > thank you. > > Joseph Black > cc Stefan Leichter

1 0

Re: fyi link to wine-wiki based on your forum post
by James Liggett 06 Jul '05

06 Jul '05

Hi Joseph, Thanks for doing this, great work!! FYI, I just became the app maintainer for Desktop 4.1; the same stuff can now be found in the app db. Other than that, this looks good. James Liggett On Wed, 2005-07-06 at 15:40 +1200, Joseph Black wrote: > I have copied some of what you wrote in the forum into the unofficial > wine-wiki, > but I would appreciate a quick look over in case I have made an error > Here is a link for your perusal. > > http://wiki.jswindle.com/index.php/Palm_Desktop > > there is also some info about dcom,and ie that may be of interest. > > If you wish me to remove /change/ fix.. :-) , please email me > directly, or help > yourself to remove/change/make anon etc.. > > thank you. > > Joseph Black > cc Stefan Leichter

1 0

Re: [USER32] Zero out buffer in SYSPARAMS_Load
by Dmitry Timoshkov 06 Jul '05

06 Jul '05

"Felix Nawothnig" <felix.nawothnig(a)t-online.de> wrote: > + memset( lpBuf, 0, count ); Don't you think that your patch is a bit too large although the only thing it does is adding the only a single memset call? Please get rid of all not necessary formatting changes and resubmit. -- Dmitry.

2 1

Re: Installing Palm Desktop
by James Liggett 06 Jul '05

06 Jul '05

Thanks Chris, just submitted. Knew I was being stupid about it... James On Tue, 2005-07-05 at 22:47 -0400, Chris Morgan wrote: > I wouldn't worry about the reason. If you run the app and are interested in > maintaining the howto and potentially responding to forum posts, thats more > than enough. We put the reason question on there because otherwise its > difficult to tell apart the users that have the knowledge to help vs. the > ones that just want the application to work for them under wine. > > Chris > > > On Tuesday 05 July 2005 10:19 pm, James Liggett wrote: > > Hi Tony, > > This is Desktop 4.1 that came with my Tungsten T. I've considered > > becoming a maintainer for the app, but being the extremely neurotic > > perfectionist I am, I've yet to decide what exactly my "reason" for > > becoming a maintainer will be, but I will be putting in the request > > eventually. > > > > Kind regards, > > James Liggett > > > > On Tue, 2005-07-05 at 19:42 -0600, Tony Lambregts wrote: > > > James Liggett wrote: > > > > Hi Uwe, > > > > I figured out how to install Palm Desktop, perhaps this might prove > > > > useful to someone: > > > > > > > > 1. Install native Windows Installer manually. To do this, install > > > > dcom98 first. Then run instmsia.exe. The install will complain, but it > > > > will leave behind all the files you need in Windows\Installer\InstMsi0. > > > > Copy all the files in there to Windows\system, and set msi.dll and > > > > msiexec.exe to native. > > > > > > > > 2. Install Windows Script 5.6. You can download it from here: > > > > http://www.microsoft.com/downloads/details.aspx?FamilyID=0a8a18f6-249c- > > > >4a72-bfcf-fc6af26dc390&DisplayLang=en Keep in mind that it's the English > > > > version though. To install it, set setupapi to builtin and run the > > > > file. > > > > > > > > 3. Run Palm Desktop setup like normal, and it will install everything > > > > you need. > > > > > > > > Of course, running palm desktop is a different story (there is a crash > > > > in WinMM that stops it from running.) I'm currently working on getting > > > > Hotsync to work with my USB cradle using the visor driver, but there's > > > > some problems with that. I'll post a dump of the messages I get and see > > > > if I can make something happen. Thanks for the help :). > > > > > > What version of Palm Desktop is this? This would make a great howto, I > > > would add it to the proper version myself if I knew the version. > > > > > > Please consider becoming a maintainer for this app. > > > > > > http://appdb.winehq.org/appview.php?appId=688 > > > > > > -- > > > > > > Tony Lambregts

1 0

Palm Desktop and Hotsync with usbserial
by James Liggett 06 Jul '05

06 Jul '05

Hello all, Many have been following my attempts at getting Palm Desktop and Hotsync to work. I've tried setting up a COM port that points to the USB device generated by the visor kernel driver when you hit the button on the cradle. Unfortunately, there's a problem in GetCommState: err:comm:GetCommState tcgetattr or ioctl error 'Invalid argument' I'm not really sure if this is due to my use of the USB stuff, or if this would happen with a direct serial cradle. But, the good news is that it's trying to pick something up. My Dad has a serial cradle, but I don't know if he'd let me borrow it. Anyway, after the sync fails, wine goes crazy and dumps my registry. I've created a dump of all the output, but it's over 500K and is too big for the list. Anybody got any ideas on this stuff? If someone could try exactly what I did and report it, I would appreciate it. ;-) Thanks a lot, James Liggett P.S. If you do try to run Hotsync, set your win version to nt40 to get rid of complaints about missing comm drivers.

1 0

LoadImageW: Fix type of TRACE-Parameter (update to cvs-commit)
by Detlef Riekenberg 05 Jul '05

05 Jul '05

Am Dienstag, den 05.07.2005, 07:40 -0500 schrieb Alexandre Julliard: > > Modified files: > dlls/user : cursoricon.c > > Log message: > Detlef Riekenberg <wine.dev(a)web.de> > LoadImageW: Fix type of TRACE parameter. > > Patch: http://cvs.winehq.org/patch.py?id=18666 > > Old revision New revision Changes Path > 1.6 1.7 +3 -7 wine/dlls/user/cursoricon.c Sorry, but you modified the Patch in a wrong Way. (HIWORD(name)) is the short version of (IS_INTRESOURCE(name)) here Changelog: - LoadImageW: Fix type of TRACE-Parameter (Restored the 'if (HIWORD(name))' - Part and added some comments) -- By By ... ... Detlef

2 2

Re: Add an appearently missing return in commctrl32
by Andreas Mohr 05 Jul '05

05 Jul '05

Hi, On Tue, Jul 05, 2005 at 06:56:20PM +0100, Robbert Xerox wrote: > Hi, let me be clear: i don't know anything about this > comctl32 stuff, but compared to this patch: > http://cvs.winehq.org/patch.py?id=15317 > it seems to me there's a missing return, which i added > in this patch.I have no time to get deeper into this > comctl32 stuff so I'll leave it for a review to others > who know more about it. Anyways: it fixes the > following bug in Shareaza: > http://bugs.winehq.org/show_bug.cgi?id=2659 Hmm, well, the fact that there are many structs like phdi->cxy = (lpItem != NULL) ? lpItem->cxy : 0; suggests that even if lpItem is NULL (failure mode), the outbound phdi struct should still get filled with proper data (which is, to be fair, not much more than a zeroed-out struct, all taken together). IOW, it seems a lot like this should simply be another up-front failure check instead (such code is found in many functions in comctl32 on Windows!): if ((nItem < 0) || (nItem >= (INT)infoPtr->uNumItem)) { memset(phdi, 0, sizeof(HDITEMW)); return FALSE; } lpItem = &infoPtr->items[nItem]; ... But even that is rather non-proven, so the best thing to do here is to write a good test suite test for this function (for the easiest way to call this function's functionality under Windows, that is...). Andreas Mohr

1 0

Re: shell32.dll/Printer_LoadIconsW implemented
by Frank Richter 05 Jul '05

05 Jul '05

On 05.07.2005 13:37, Detlef Riekenberg wrote: > + HMODULE SHELL32_hmodule=NULL; > + INT iconindex=IDI_SHELL_PRINTER; ... > + if(SHELL32_hmodule==NULL) > + { > + SHELL32_hmodule=LoadLibraryA("shell32.dll"); > + } Why not use the global 'shell32_hInstance' variable? -f.r.

2 1

Regression: Installing Zoo Tycoon 1 Demo stalls with ALSA
by Paul Vriens 05 Jul '05

05 Jul '05

Hi, It's been a while since I tried the installation but it hangs with a full 100% when I select ALSA as the audio driver (current CVS). Choosing OSS get's me through the installation. trace with +wave shows: trace:wave:wodPlayer waiting 3ms (10,3) warn:wave:wodUpdatePlayedTotal Unexpected state (3) or delay (-3) while updating Total Played, resetting trace:wave:wodNotifyClient wMsg = 0x03bd dwParm1 = 7BE83560 dwParam2 = 0000 trace:wave:wodPlayer_NotifyCompletions Empty queue trace:wave:wodPlayer waiting 10ms (10,4294967295) trace:wave:ALSA_wodMessage (0, WODM_RESET, 45ABC7B9, 00000000, 00000000); trace:wave:wodReset (0); trace:wave:wodPlayer_ProcessMessages Received WINE_WM_RESETTING 0 Any idea where to look. Cheers, Paul.

1 0

Re: [Darwine] RFC: Bug Management (was: wine_ldt_copy)
by Pierre d'Herbemont 05 Jul '05

05 Jul '05

Sorry for cross posting to the wine-devel but I think this may interest the whole wine community. Selon Phil Krylov <phil.krylov(a)gmail.com>: > Fine :) Could you please correct the corresponding To Do entry on the Web > site? I can't do it right now, so I'll fix that later. Any way our To Do Section is not flexible enough. So that raises a good question: how shall we handle bug reports? My propositions: 1) Every bug reports handled by darwine(a)bugzilla.opendarwin.org or the darwine@sf Bug Management System. 2) Every bug reports handled by bugzilla.winehq.org. 3) - Wine related bugs (including darwin port specific bugs) handled by bugzilla.winehq.org. - bugs that are darwine related and not wine specific (WineHelper bugs, installer bugs, sdk bugs, ... ) handled by darwine(a)bugzilla.opendarwin.org or darwine@sf. Solution 1) is the worst, since we'll have to deal with bug duplication between the darwine BMS and the winehq BMS. Solution 2) is doable but probably not desired. So I think we should go for 3). Whereas it seems to be the most confusing solution for bug reporters, the separation wine code/darwine distrib is clear. Anyway bug reporters usually read the "how to bug report" before submitting a bug, do they? Would solution 3) be acceptable? Pierre.

1 0

Re: [WINECFG] Japanese translation
by Frank Richter 05 Jul '05

05 Jul '05

2 1

Re: [WINECFG] Japanese translation
by Frank Richter 05 Jul '05

05 Jul '05

1 0

Re: http://cvs.winehq.org/patch.py?id=18650
by Paul Vriens 05 Jul '05

05 Jul '05

Hi, +#define ITextServices_OnTxInplaceDeactivate(p,a) (p)->lpVtbl->OnTxInplaceActivate(p,a) shouldn't that be (p)->lpVtbl->OnTxInplaceDeactivate ? Cheers, Paul.

1 0

Re: uxtheme: also send WM_THEMECHANGED to child windows (resend)
by Alexandre Julliard 05 Jul '05

05 Jul '05

Frank Richter <frank.richter(a)gmail.com> writes: > +static BOOL CALLBACK UXTHEME_broadcast_msg (HWND hWnd, LPARAM msg) > +{ > + if (hWnd == NULL) > + { > + EnumWindows (UXTHEME_broadcast_msg, msg); > + } > + else > + { > + PostMessageW(hWnd, msg, 0, 0); > + EnumChildWindows (hWnd, UXTHEME_broadcast_msg, msg); The recursion is redundant here, EnumChildWindows already enumerates all children. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: OLE32/compobj: gcc 4.0 -Wpointer-sign fixes
by Robert Shearman 05 Jul '05

05 Jul '05

Mike McCormack wrote: >Index: dlls/ole32/compobj.c >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/compobj.c,v >retrieving revision 1.154 >diff -u -p -r1.154 compobj.c >--- dlls/ole32/compobj.c 20 Jun 2005 14:18:04 -0000 1.154 >+++ dlls/ole32/compobj.c 4 Jul 2005 14:51:31 -0000 >@@ -787,6 +787,26 @@ HRESULT WINAPI CoCreateGuid(GUID *pguid) > return UuidCreate(pguid); > } > >+static LPBYTE validate_clsid_string( LPCSTR s ) >+{ >+ int i; >+ >+ if (strlen(s) != 38) >+ return NULL; >+ >+ if ((s[0]!='{') || (s[9]!='-') || (s[14]!='-') || (s[19]!='-') || (s[24]!='-') || (s[37]!='}')) >+ return NULL; >+ >+ for (i=1; i<37; i++) { >+ if ((i == 9)||(i == 14)||(i == 19)||(i == 24)) continue; >+ if (!(((s[i] >= '0') && (s[i] <= '9')) || >+ ((s[i] >= 'a') && (s[i] <= 'f')) || >+ ((s[i] >= 'A') && (s[i] <= 'F')))) >+ return NULL; >+ } >+ return (LPBYTE) s; >+} >+ > /****************************************************************************** > * CLSIDFromString [OLE32.@] > * IIDFromString [OLE32.@] >@@ -813,28 +833,16 @@ HRESULT WINAPI CoCreateGuid(GUID *pguid) > */ > HRESULT WINAPI __CLSIDFromStringA(LPCSTR idstr, CLSID *id) > { >- const BYTE *s = (const BYTE *) idstr; >- int i; > BYTE table[256]; >+ LPBYTE s; >+ int i; > >- if (!s) >- s = "{00000000-0000-0000-0000-000000000000}"; >- else { /* validate the CLSID string */ >- >- if (strlen(s) != 38) >- return CO_E_CLASSSTRING; >- >- if ((s[0]!='{') || (s[9]!='-') || (s[14]!='-') || (s[19]!='-') || (s[24]!='-') || (s[37]!='}')) >- return CO_E_CLASSSTRING; >- >- for (i=1; i<37; i++) { >- if ((i == 9)||(i == 14)||(i == 19)||(i == 24)) continue; >- if (!(((s[i] >= '0') && (s[i] <= '9')) || >- ((s[i] >= 'a') && (s[i] <= 'f')) || >- ((s[i] >= 'A') && (s[i] <= 'F')))) >- return CO_E_CLASSSTRING; >- } >- } >+ if (!idstr) >+ idstr = "{00000000-0000-0000-0000-000000000000}"; >+ >+ s = validate_clsid_string( idstr ); >+ if( !s ) >+ return CO_E_CLASSSTRING; > > TRACE("%s -> %p\n", s, id); > I don't think there is any need to split the function into two as you can just use 'idstr' directly, instead of 's'. Also, note that this function will soon be converted into using WCHARs, but I don't think that should change anything. -- Rob Shearman

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel