wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

msi dialogs, events and office 2003
by Aric Stewart 26 May '05

26 May '05

Hi Stefan, We have been concentrating alot of effort on Office 2003 and specifically on getting office 2003 to install and come up properly. We would love to work more directly with you and the whole wine community in this goal. With this patch I have enabled the dialog code that Mike has put into wine and started a basic structure for handling ControlEvents sent to and from various dialog controls. Alot of this code is still pretty hacky and incorrect but the basic functionality and structure is there. It also should allow you to actually start installing Office. With the current CVS tip Office2003 fails to install due to actions relating to MSXML failing but that is where our effort is now focused. You can get around that by changing the ACTION_ProcessExecSequence(package,FALSE) in ACTION_ExecuteAction() to ACTION_ProcessExecSequence(package,TRUE), then at least Office 2003 will be able to install its basic functions and come up. We here at CodeWeavers are constantly trying to work closer with the wine community. I am bad about keeping up on wine-devel, so you can always e-mail me directly with MSI related things, and i know Mike McCormack and a number of other are very good at keeping up on the mailing list. I also hang out in the irc channel quite a bit. With some work and some luck we should be able to get office 2003 looking pretty good. -aric Index: dlls/msi/Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/msi/Makefile.in,v retrieving revision 1.26 diff -u -r1.26 Makefile.in --- dlls/msi/Makefile.in 9 May 2005 14:42:33 -0000 1.26 +++ dlls/msi/Makefile.in 26 May 2005 16:16:03 -0000 @@ -16,6 +16,7 @@ delete.c \ dialog.c \ distinct.c \ + events.c \ format.c \ handle.c \ insert.c \ Index: dlls/msi/action.c =================================================================== RCS file: /home/wine/wine/dlls/msi/action.c,v retrieving revision 1.123 diff -u -r1.123 action.c --- dlls/msi/action.c 26 May 2005 16:08:58 -0000 1.123 +++ dlls/msi/action.c 26 May 2005 16:16:06 -0000 @@ -685,6 +685,21 @@ HeapFree(GetProcessHeap(),0,package->CommitAction); HeapFree(GetProcessHeap(),0,package->PackagePath); + + /* cleanup control event subscriptions */ + ControlEvent_CleanupSubscriptions(package); +} + +static void ce_actiontext(MSIPACKAGE* package, LPCWSTR action) +{ + static const WCHAR szActionText[] = + {'A','c','t','i','o','n','T','e','x','t',0}; + MSIRECORD *row; + + row = MSI_CreateRecord(1); + MSI_RecordSetStringW(row,1,action); + ControlEvent_FireSubscribedEvent(package,szActionText, row); + msiobj_release(&row->hdr); } static void ui_progress(MSIPACKAGE *package, int a, int b, int c, int d ) @@ -714,6 +729,8 @@ MSIQUERY * view; MSIRECORD * row = 0; DWORD size; + static const WCHAR szActionData[] = + {'A','c','t','i','o','n','D','a','t','a',0}; if (!package->LastAction || strcmpW(package->LastAction,action)) { @@ -764,6 +781,9 @@ MSI_RecordSetStringW(row,1,message); MSI_ProcessMessage(package, INSTALLMESSAGE_ACTIONDATA, row); + + ControlEvent_FireSubscribedEvent(package,szActionData, row); + msiobj_release(&row->hdr); } @@ -1403,6 +1423,7 @@ { if (strcmpW(StandardActions[i].action, action)==0) { + ce_actiontext(package, action); ui_actioninfo(package, action, TRUE, 0); ui_actionstart(package, action); if (StandardActions[i].handler) @@ -1427,15 +1448,11 @@ { BOOL ret = FALSE; - /* - * for the UI when we get that working - * if (ACTION_DialogBox(package,dialog) == ERROR_SUCCESS) { *rc = package->CurrentInstallState; ret = TRUE; } - */ return ret; } Index: dlls/msi/action.h =================================================================== RCS file: /home/wine/wine/dlls/msi/action.h,v retrieving revision 1.9 diff -u -r1.9 action.h --- dlls/msi/action.h 26 May 2005 16:08:58 -0000 1.9 +++ dlls/msi/action.h 26 May 2005 16:16:06 -0000 @@ -196,3 +196,8 @@ int get_loaded_feature(MSIPACKAGE* package, LPCWSTR Feature ); int get_loaded_file(MSIPACKAGE* package, LPCWSTR file); int track_tempfile(MSIPACKAGE *package, LPCWSTR name, LPCWSTR path); + +/* control event stuff */ +VOID ControlEvent_FireSubscribedEvent(MSIPACKAGE *package, LPCWSTR event, + MSIRECORD *data); +VOID ControlEvent_CleanupSubscriptions(MSIPACKAGE *package); Index: dlls/msi/msipriv.h =================================================================== RCS file: /home/wine/wine/dlls/msi/msipriv.h,v retrieving revision 1.58 diff -u -r1.58 msipriv.h --- dlls/msi/msipriv.h 26 May 2005 12:24:28 -0000 1.58 +++ dlls/msi/msipriv.h 26 May 2005 16:16:06 -0000 @@ -226,6 +226,7 @@ LPWSTR next_dialog; BOOL ExecuteSequenceRun; + struct _subscriptions *EventSubscriptions; } MSIPACKAGE; typedef struct tagMSIPREVIEW --- /dev/null 2005-03-17 08:20:53.000000000 -0600 +++ dlls/msi/events.c 2005-05-26 10:31:14.000000000 -0500 @@ -0,0 +1,506 @@ +/* + * Implementation of the Microsoft Installer (msi.dll) + * + * Copyright 2005 Aric Stewart for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + + +/* +http://msdn.microsoft.com/library/default.asp?url=/library/en-us/msi/setup/controlevent_overview.asp +*/ + +#include <stdarg.h> +#include <stdio.h> + +#define COBJMACROS + +#include "windef.h" +#include "winbase.h" +#include "winerror.h" +#include "winreg.h" +#include "wine/debug.h" +#include "fdi.h" +#include "msi.h" +#include "msiquery.h" +#include "msvcrt/fcntl.h" +#include "objbase.h" +#include "objidl.h" +#include "msipriv.h" +#include "winnls.h" +#include "winuser.h" +#include "shlobj.h" +#include "wine/unicode.h" +#include "ver.h" +#include "action.h" + +WINE_DEFAULT_DEBUG_CHANNEL(msi); + +typedef void (*EVENTHANDLER)(MSIPACKAGE*,LPCWSTR,msi_dialog *); + +struct _events{ + LPSTR event; + EVENTHANDLER handler; +}; + +struct _subscriber{ + LPWSTR control; + LPWSTR attribute; + struct _subscriber *next; +}; + +struct _subscription_chain { + LPWSTR event; + struct _subscriber *chain; +}; + +struct _subscriptions { + DWORD chain_count; + struct _subscription_chain* chain; +}; + +static VOID ControlEvent_EndDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_NewDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_SpawnDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_SpawnWaitDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_DoAction(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_AddLocal(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_Remove(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_AddSource(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); + +struct _events Events[] = { + { "EndDialog",ControlEvent_EndDialog}, + { "NewDialog",ControlEvent_NewDialog}, + { "SpawnDialog",ControlEvent_SpawnDialog}, + { "SpawnWaitDialog",ControlEvent_SpawnWaitDialog}, + { "DoAction",ControlEvent_DoAction}, + { "AddLocal",ControlEvent_AddLocal}, + { "Remove",ControlEvent_Remove}, + { "AddSource",ControlEvent_AddSource}, + { NULL,NULL}, + }; + +VOID ControlEvent_HandleControlEvent(MSIPACKAGE *package, LPCWSTR event, + LPCWSTR argument, msi_dialog* dialog) +{ + int i = 0; + + TRACE("Handling Control Event %s\n",debugstr_w(event)); + if (!event) + return; + + while( Events[i].event != NULL) + { + LPWSTR wevent = strdupAtoW(Events[i].event); + if (strcmpW(wevent,event)==0) + { + HeapFree(GetProcessHeap(),0,wevent); + Events[i].handler(package,argument,dialog); + return; + } + HeapFree(GetProcessHeap(),0,wevent); + i++; + } + FIXME("UNHANDLED control event %s arg(%s)\n",debugstr_w(event), + debugstr_w(argument)); +} + + +/* + * Create a dialog box and run it if it's modal + */ +static UINT event_do_dialog( MSIPACKAGE *package, LPCWSTR name ) +{ + msi_dialog *dialog; + UINT r; + + /* kill the current modeless dialog */ + if( package->dialog ) + msi_dialog_destroy( package->dialog ); + package->dialog = NULL; + + /* create a new dialog */ + dialog = msi_dialog_create( package, name, + ControlEvent_HandleControlEvent ); + if( dialog ) + { + /* modeless dialogs return an error message */ + r = msi_dialog_run_message_loop( dialog ); + if( r == ERROR_SUCCESS ) + msi_dialog_destroy( dialog ); + else + package->dialog = dialog; + } + else + r = ERROR_FUNCTION_FAILED; + + return r; +} + + +/* + * End a modal dialog box + */ +static VOID ControlEvent_EndDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + static const WCHAR szExit[] = { + 'E','x','i','t',0}; + static const WCHAR szRetry[] = { + 'R','e','t','r','y',0}; + static const WCHAR szIgnore[] = { + 'I','g','n','o','r','e',0}; + static const WCHAR szReturn[] = { + 'R','e','t','u','r','n',0}; + + if (strcmpW(argument,szExit)==0) + package->CurrentInstallState = ERROR_INSTALL_USEREXIT; + else if (strcmpW(argument, szRetry) == 0) + package->CurrentInstallState = ERROR_INSTALL_SUSPEND; + else if (strcmpW(argument, szIgnore) == 0) + package->CurrentInstallState = -1; + else if (strcmpW(argument, szReturn) == 0) + package->CurrentInstallState = ERROR_SUCCESS; + else + { + ERR("Unknown argument string %s\n",debugstr_w(argument)); + package->CurrentInstallState = ERROR_FUNCTION_FAILED; + } + + msi_dialog_end_dialog( dialog ); +} + +/* + * transition from one modal dialog to another modal dialog + */ +static VOID ControlEvent_NewDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog *dialog) +{ + /* store the name of the next dialog, and signal this one to end */ + package->next_dialog = strdupW(argument); + msi_dialog_end_dialog( dialog ); +} + +/* + * Create a new child dialog of an existing modal dialog + */ +static VOID ControlEvent_SpawnDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog *dialog) +{ + event_do_dialog( package, argument ); + if( package->CurrentInstallState != ERROR_SUCCESS ) + msi_dialog_end_dialog( dialog ); +} + +/* + * Creates a dialog that remains up for a period of time + * based on a condition + */ +static VOID ControlEvent_SpawnWaitDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + FIXME("Doing Nothing\n"); +} + +static VOID ControlEvent_DoAction(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + ACTION_PerformAction(package,argument); +} + +static VOID ControlEvent_AddLocal(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + static const WCHAR szAll[] = {'A','L','L',0}; + int i; + + if (strcmpW(szAll,argument)) + { + MSI_SetFeatureStateW(package,argument,INSTALLSTATE_LOCAL); + } + else + { + for (i = 0; i < package->loaded_features; i++) + { + package->features[i].ActionRequest = INSTALLSTATE_LOCAL; + package->features[i].Action = INSTALLSTATE_LOCAL; + } + ACTION_UpdateComponentStates(package,argument); + } + +} + +static VOID ControlEvent_Remove(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + static const WCHAR szAll[] = {'A','L','L',0}; + int i; + + if (strcmpW(szAll,argument)) + { + MSI_SetFeatureStateW(package,argument,INSTALLSTATE_ABSENT); + } + else + { + for (i = 0; i < package->loaded_features; i++) + { + package->features[i].ActionRequest = INSTALLSTATE_ABSENT; + package->features[i].Action= INSTALLSTATE_ABSENT; + } + ACTION_UpdateComponentStates(package,argument); + } +} + +static VOID ControlEvent_AddSource(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + static const WCHAR szAll[] = {'A','L','L',0}; + int i; + + if (strcmpW(szAll,argument)) + { + MSI_SetFeatureStateW(package,argument,INSTALLSTATE_SOURCE); + } + else + { + for (i = 0; i < package->loaded_features; i++) + { + package->features[i].ActionRequest = INSTALLSTATE_SOURCE; + package->features[i].Action = INSTALLSTATE_SOURCE; + } + ACTION_UpdateComponentStates(package,argument); + } +} + + +/* + * Subscribed events + */ +static void free_subscriber(struct _subscriber *who) +{ + HeapFree(GetProcessHeap(),0,who->control); + HeapFree(GetProcessHeap(),0,who->attribute); + HeapFree(GetProcessHeap(),0,who); +} + +VOID ControlEvent_SubscribeToEvent(MSIPACKAGE *package, LPCWSTR event, + LPCWSTR control, LPCWSTR attribute) +{ + int i; + struct _subscription_chain *chain; + struct _subscriber *subscriber, *ptr; + + if (!package->EventSubscriptions) + { + package->EventSubscriptions = HeapAlloc(GetProcessHeap(), 0, + sizeof(struct _subscriptions)); + package->EventSubscriptions->chain_count = 0; + } + + chain = NULL; + + for (i = 0; i < package->EventSubscriptions->chain_count; i++) + { + if (strcmpiW(package->EventSubscriptions->chain[i].event,event)==0) + { + chain = &package->EventSubscriptions->chain[i]; + break; + } + } + + if (chain == NULL) + { + if (package->EventSubscriptions->chain_count) + chain = HeapReAlloc(GetProcessHeap(), 0, + package->EventSubscriptions->chain, + (package->EventSubscriptions->chain_count + 1) * + sizeof (struct _subscription_chain)); + else + chain= HeapAlloc(GetProcessHeap(),0, sizeof (struct + _subscription_chain)); + + package->EventSubscriptions->chain = chain; + chain = &package->EventSubscriptions->chain[ + package->EventSubscriptions->chain_count]; + package->EventSubscriptions->chain_count++; + memset(chain,0,sizeof(struct _subscription_chain)); + chain->event = strdupW(event); + } + + subscriber = ptr = chain->chain; + while (ptr) + { + subscriber = ptr; + ptr = ptr->next; + } + + ptr = HeapAlloc(GetProcessHeap(),0,sizeof(struct _subscriber)); + ptr->control = strdupW(control); + ptr->attribute = strdupW(attribute); + ptr->next = NULL; + + if (subscriber) + subscriber->next = ptr; + else + chain->chain = ptr; +} + +VOID ControlEvent_UnSubscribeToEvent(MSIPACKAGE *package, LPCWSTR event, + LPCWSTR control, LPCWSTR attribute) +{ + int i; + + if (!package->EventSubscriptions) + return; + + for (i = 0; i < package->EventSubscriptions->chain_count; i++) + { + if (strcmpiW(package->EventSubscriptions->chain[i].event,event)==0) + { + struct _subscriber *who; + struct _subscriber *prev=NULL; + who = package->EventSubscriptions->chain[i].chain; + while (who) + { + if (strcmpiW(who->control,control)==0 + && strcmpiW(who->attribute,attribute)==0) + { + if (prev) + prev->next = who->next; + else + package->EventSubscriptions->chain[i].chain = who->next; + + free_subscriber(who); + } + else + { + prev = who; + who = who->next; + } + } + break; + } + } +} + +VOID ControlEvent_FireSubscribedEvent(MSIPACKAGE *package, LPCWSTR event, + MSIRECORD *data) +{ + int i; + + TRACE("Firing Event %s\n",debugstr_w(event)); + + if (!package->dialog) + return; + + if (!package->EventSubscriptions) + return; + + for (i = 0; i < package->EventSubscriptions->chain_count; i++) + { + if (strcmpiW(package->EventSubscriptions->chain[i].event,event)==0) + { + struct _subscriber *who; + who = package->EventSubscriptions->chain[i].chain; + while (who) + { + ERR("Should Fire event for %s %s\n", + debugstr_w(who->control), debugstr_w(who->attribute)); + /* + msi_dialog_fire_subscribed_event(package->dialog, who->control, + who->attribute, data); + */ + who = who->next; + } + break; + } + } +} + +VOID ControlEvent_CleanupSubscriptions(MSIPACKAGE *package) +{ + int i; + + if (!package->EventSubscriptions) + return; + + for (i = 0; i < package->EventSubscriptions->chain_count; i++) + { + struct _subscriber *who; + struct _subscriber *ptr; + who = package->EventSubscriptions->chain[i].chain; + while (who) + { + ptr = who; + who = who->next; + free_subscriber(ptr); + } + HeapFree(GetProcessHeap(), 0, + package->EventSubscriptions->chain[i].event); + } + HeapFree(GetProcessHeap(),0,package->EventSubscriptions->chain); + HeapFree(GetProcessHeap(),0,package->EventSubscriptions); + package->EventSubscriptions = NULL; +} + + + +/* + * ACTION_DialogBox() + * + * Return ERROR_SUCCESS if dialog is process and ERROR_FUNCTION_FAILED + * if the given parameter is not a dialog box + */ +UINT ACTION_DialogBox( MSIPACKAGE* package, LPCWSTR szDialogName ) +{ + UINT r = ERROR_SUCCESS; + + if( package->next_dialog ) + ERR("Already a next dialog... ignoring it\n"); + package->next_dialog = NULL; + + /* + * Dialogs are chained by filling in the next_dialog member + * of the package structure, then terminating the current dialog. + * The code below sees the next_dialog member set, and runs the + * next dialog. + * We fall out of the loop below if we come across a modeless + * dialog, as it returns ERROR_IO_PENDING when we try to run + * its message loop. + */ + r = event_do_dialog( package, szDialogName ); + while( r == ERROR_SUCCESS && package->next_dialog ) + { + LPWSTR name = package->next_dialog; + + package->next_dialog = NULL; + r = event_do_dialog( package, name ); + HeapFree( GetProcessHeap(), 0, name ); + } + + if( r == ERROR_IO_PENDING ) + r = ERROR_SUCCESS; + + return r; +

1 0

Winedocs and Po4a dependencies
by Francois Gouget 26 May '05

26 May '05

For the Wine project we are trying to make it as easy as possible for Wine contributors to modify and rebuild the Wine documentation. The Po4a dependencies have caused some concern in this regard: for each dependency the contributor will have to track down which package to install for his distribution and this makes the initial setup significantly harder. Po4a being not very widespread we have checked it in the Winedocs CVS (http://cvs.sourceforge.net/viewcvs.py/wine/docs/). But Po4a has quite a few dependencies so this does not help very much. So now we are hoping to make it possible to reduce the number of po4a dependencies. Here is the list I came up with, together with some notes for each of them: * Locale::gettext (perl module) Needed by po4a for localization. Provided by liblocale-gettext-perl on Debian, perl-Locale-gettext on Mandrake and Fedora Core(DAG), perl-gettext on SUSE. Would you be open to a patch that acted as a wrapper around Locale::gettext so that po4a would continue to work untranslated if that module was missing? The idea we would add a 'Po4aGettext' module that would export gettext() and dgettext() functions. These would try to load Locale::gettext in an eval function and use it if that succeeds. Otherwise the Po4aGettext would simply return the untranslated strings. The only changes to the other Po4a modules would be replacing 'use Locale::gettext' with 'use Po4aGettext'. * Text::WrapI18N (perl module) Pure perl (so easy to check in) but depends on Text::CharWidth which is not pure perl. Provided by libtext-wrapi18n-perl on Debian. Found no RPM packages providing it. Text::WrapI18N was not used in po4a 0.16.2. I initially thought it was used to wrap the text being output to the .po and .sgml files but in fact it seems to only be used to print messages, warnings and errors. Why is it needed? Doesn't a simple print work fine? * Term::ReadKey (perl module) Provided by libterm-readkey-perl on Debian, perl-Term-ReadKey on Mandrake and Fedora Core(DAG), perl-TermReadKey on SUSE. This module is used to determine the size of the terminal. This information is then used by the wrap functions. * SGMLS (perl module) Needed by po4a to interface with the nsgmls parser. Pure perl (so easy to check in). Provided by libsgmls-perl on Debian, perl-SGMLSpm on Mandrake and Fedora Core, perl-SGMLS on SUSE. This is an essential part of po4a. The easiest way to remove this dependency would be to check it into the Winedocs repository. So no action needed on the Po4a side. * nsgmls (command line tool) Needed by po4a to parse the Sgml files. Provided by sp on Debian, sgml-tools or openjade on Mandrake and Fedora Core, opensp on SUSE. This is an essential part of po4a. So it will have to remain as a dependency which is reasonable. -- Francois Gouget fgouget(a)codeweavers.com

1 0

Nice work Mike M, and others
by Jeremy White 26 May '05

26 May '05

Folks, I saw the following blog entry: http://outflux.net/blog/archives/2005/05/25/ask-a-stupid-question/ (a Wine newbie praising the responsiveness of Wine developers) And I have to say that I thought it was one of the best testaments to our community I'd seen in a while. And I further have to say that it seems to me that a lot of folks (including many of them named Mike or Michael and many others too numerous to list), have really started going out of their way to help others to contribute to Wine. So I thought I'd simply say: Well done! Lord knows we can use all the help we can get <grin>. Cheers, Jeremy

1 0

Re: Write problem with MS Office 2003
by Juan Lang 26 May '05

26 May '05

Hi Stefan, --- Stefan D�siner <stefandoesinger(a)gmx.at> wrote: > How do I handle apidl == NULL? As far as I understand, apidl specifies a > list > of folders/files to be checked, right? If apidl == 0, what folder should > I > check. Is there some 'current folder' in the IShellFolder class? I > didn't > find any. Right, apidl can't be NULL if cidl is nonzero. If cidl is zero, you probably need the check to be in the caller. E.g. in shfldr_fs.c, the current folder is what calls SHELL32_GetItemAttributes, from IShellFolder_fnGetAttributesOf. Perhaps the dwAttributes member that's passed to InitializeEx sets the correct attributes for the current folder? I'm not sure. --Juan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new Resources site http://smallbusiness.yahoo.com/resources/

4 14

IShellFolder::GetDisplayNameOf vs. SHGetPathFromIDList
by Michael Jung 26 May '05

26 May '05

Hi Alexandre, could you please give me a hint on this one: http://www.winehq.org/hypermail/wine-patches/2005/05/0567.html My guess is that you want me to write a test, showing that windows' comdlg32 does it this way. The problem is, I don't know how. We would have to temporarily register a shell namespace extension on Windows, then call one of the file dialogs and show that the GetDisplayNameOf method is called with the SHGDN_FORPARSING flag set, when the user selects a path from the extension. This would be a pretty complex test, which includes user interaction and thus doesn't fit into wine's test framework (or am I wrong?). Could you (or anybody on wine-devel) give me a hint? Thanks, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Re: MSXML: add some idl definitions (exposes a widl bug)
by Alexandre Julliard 26 May '05

26 May '05

Mike McCormack <mike(a)codeweavers.com> writes: > This patch demonstrates a problem with widl. This following > declaration fails to parse correctly, as "async" is detected as a > keyword, and disallowed as the name of a method in an interface. > > [propget, id(DISPID_XMLDOM_DOCUMENT_ASYNC)] > HRESULT async( [out,retval] VARIANT_BOOL *isAsync ); > > For the moment, I've hacked this by renaming "async" to "async_". Yes, keyword handling is broken. You can probably work around it by adding async to the list of keywords supported by the ident: token, but it would certainly be nice to fix this properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: docs/. configure.ac
by Francois Gouget 26 May '05

26 May '05

Dimi Paun wrote: [...] > Modified files: > . : configure.ac > > Log message: > Francois Gouget <fgouget(a)codeweavers.com> > Warn the user if docbook2html is missing. Offer hints as to which > packages he needs to install. > > > Old revision New revision Changes Path > 1.2 1.3 +12 -0 docs/configure.ac Hmm, you forgot to regenerate the configure script. The problem is my autoconf version is a bit different which results in extra changes. So I prefer not to send my configure diff and let you regenerate it... -- Francois Gouget fgouget(a)codeweavers.com

2 1

Re: avoid msvfw32 crash
by Alexandre Julliard 26 May '05

26 May '05

luis lenders <lgvlenders(a)yahoo.co.uk> writes: > Index: wine/dlls/msvideo/drawdib.c > =================================================================== > RCS file: /home/wine/wine/dlls/msvideo/drawdib.c,v > retrieving revision 1.24 > diff -u -p -r1.24 drawdib.c > --- wine/dlls/msvideo/drawdib.c 17 Jan 2005 15:33:43 -0000 1.24 > +++ wine/dlls/msvideo/drawdib.c 24 May 2005 19:09:28 -0000 > @@ -242,7 +242,10 @@ BOOL VFWAPI DrawDibBegin(HDRAWDIB hdd, > TRACE("Not compressed!\n"); > dwSize = lpbi->biSize + num_colours(lpbi)*sizeof(RGBQUAD); > whdd->lpbiOut = HeapAlloc(GetProcessHeap(), 0, dwSize); > - memcpy(whdd->lpbiOut, lpbi, dwSize); > + if (whdd->lpbiOut) > + memcpy(whdd->lpbiOut, lpbi, dwSize); > + else > + ret=FALSE; Sounds like we need a check that the number of colors is reasonable. The HeapAlloc shouldn't normally fail except if the size is bogus. -- Alexandre Julliard julliard(a)winehq.org

1 0

MSI gui questions
by Stefan Dösinger 26 May '05

26 May '05

Hello, The native windows installer has support for a gui, but Wine's msi doesn't (yet). I had a look at this, and it seems that there are already some functions in dlls/msi/dialog.c which are for GUI handling. I had a look at the msi documentation in the MSDN. It appears to me that most dialogs are implemented in the msi file. Well, I tried to implement the PreActionDialog ACTION. I had no problem in adding a new function for that action. According to my observations, I have to call msi_dialog_create with the name of the dialog I want to create. Is there any reference about the dialogs' names? Do I have to write those dialogs(create the GUI), or is this done by the code in the .msi file? Thanks for your help, Stefan

2 1

Re: check for mkdir mode
by Dmitry Timoshkov 26 May '05

26 May '05

"Steven Edwards" <steven_ed4153(a)yahoo.com> wrote: > +int sys_mkdir(const char *path, mode_t mode) > +{ > +#ifdef HAVE_MKDIR_MODE > + return mkdir(path, mode); > +#else > + return mkdir(path); > +#endif > +} Wouldn't it be better to emulate mkdir(path, mode); with mkdir(path); chmod(path, mode); -- Dmitry.

2 1

Wine on Sparc
by Chuck Hall 26 May '05

26 May '05

Greetings, I have heard that people are using Wine on Solaris. I would like to know if they are using Wine on the SPARC version or the x86 version of Solaris? There does seem to be code within Wine to have it run on SPARC machines, but it currently does not seem to compile, at least on the Solaris version. I have attached a small patch that allows me to get throught the 'make depend' section of the compile. Since it is my first patch, please look at and let me know what I did wrong :) Have Fun! Chuck Hall

5 10

Question about advapi32/eventlog.c
by David Hemmo 25 May '05

25 May '05

Hello The stubs in eventlog.c return an odd value (0xcafe4242) instead of NULL. For example, in RegisterEventSourceW, NULL would be an error and would mean the register did not work. The current value doesn't tell the application that it didn't work. Is there a reason ? Thanks David Hemmo

2 1

Re: Fix Sparse Warnings for server/ (Try 2)
by Alexandre Julliard 25 May '05

25 May '05

Robert Shearman <rob(a)codeweavers.com> writes: > --- server/fd.c 24 Apr 2005 17:35:52 -0000 1.37 > +++ server/fd.c 24 May 2005 18:37:28 -0000 > @@ -898,18 +898,6 @@ static void remove_lock( struct file_loc > release_object( lock ); > } > > -/* remove all locks owned by a given process */ > -void remove_process_locks( struct process *process ) > -{ > - struct list *ptr; > - > - while ((ptr = list_head( &process->locks ))) > - { > - struct file_lock *lock = LIST_ENTRY( ptr, struct file_lock, proc_entry ); > - remove_lock( lock, 1 ); /* this removes it from the list */ > - } > -} > - Something's not right, that function should be used somewhere. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Resend: Fix ole32:moniker test for NT4
by Alexandre Julliard 25 May '05

25 May '05

Richard Cohen <richard(a)daijobu.co.uk> writes: > Rediffed against HEAD > > Richard Cohen wrote: > > ... and almost certainly Win9x, 2k, XP > > Changelog: > > + IEnum::Clone shouldn't do a Reset. > > + Don't assume the ROT is already empty when testing The tests fail here: ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p ole32_test.exe.so moniker.c && touch moniker.ok moniker.c:139: Test failed: Number of matches should be equal to 2 not 0 moniker.c:146: Test failed: Number of matches should be equal to 2 not 0 make[3]: *** [moniker.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: DirectX 9 patches
by Andreas 'GlaDiaC' Schneider 25 May '05

25 May '05

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, it was playable (with models) with -dxlevel 90 on Wine 20040310 and it is simple to install with installshield :) MSI: http://www.frankscorner.org/index.php?p=ishield http://www.frankscorner.org/index.php?p=msi HL2 Shots: http://www.cynapses.org/tmp/hl2_shots/ The _problem_ will be always Steam :) My Steam doesn't work since the last Steam update. Cheers, -- andreas > Okay, more info and screenshots over here: > > http://ivan.ivg2.net/hl2/ > > It's not playable, but it's exciting that > it gets this far in the first place! > > ...it has to be installed through Steam (since msi won't work). > > -- > > Ivan Gyurdiev <ivg2_at_cornell.edu> > Cornell University - -- http://www.linux-gamers.net - your online gaming resource -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFClGSFf94+j/M+P8YRAglpAKCLGaA92PoeqIQHvPcd0WyRfd/EAgCcCBIW Nbnr8xwdz+y2tksCpTBekkk= =hHXs -----END PGP SIGNATURE-----

1 0

Release notes
by Mike Hearn 25 May '05

25 May '05

Hi guys, Raphael pointed out on IRC that the great OpenGL work that went into the last release wasn't mentioned in the "What's new" list that goes out with each snapshot. As it's unreasonable to expect Alexandre to remember or mention every large piece of work that goes into any given release, how about we use the Wiki to note big items as they are checked into CVS. By "big item" I mean either: - Large improvements to a particular subsystem - Adding "gold" compatibility with a well known app - Some other end-user interesting feature For instance, I'd say "header cleanups" are less interesting to users than "OpenGL improvements for Warcraft". That's not a criticism of Alexandre, it's totally reasonable that he puts things in that he can quickly remember and as he's closer to parts of the system like import libraries and headers it's natural that this is what springs to mind first. But we can do better. If people think it's a good idea, I'll create a scratchpad page on the Wiki we can use for the next release. Anybody should be able to add things that are "big", then when doing a release Alexandre can pick and choose the ones he thinks are best to put in What's New. Thoughts? thanks -mike

2 2

Bug 469 - Application can not read from serial port
by Dustin Navea 25 May '05

25 May '05

Hey guys, this one was (obviously) reported a while back, and the offending patch was found a while back as well, but it appears that mike (at codeweavers dot com) never was able to get around to it.. Basically it is an issue that a solar panel reading application cant retrieve information via the serial port. I have requested that someone test it (the demo of the app is attached to the bug) on a recent wine build. So hopefully it is working now, and if not, maybe it will be trivial? Either way, the name of the program looks to be SunGoXL, and perhaps there is a more recent version of the program that allows it to run in wine, if the older one doesn't work. The changelog for the patch is: cvs log files/file.c Mike McCormack <mike_mccormack(a)start.com.au> Read data immediately in overlapped ReadFile if possible. From the most recent traces we have that show the problem, it looks as though the GetOverlappedResult function is waiting on something (probably the solar equipment) to be returned, but it never does, so maybe at the time (if not still now) wine was unable to use the serial port for whatever reason? Other people could test the program, but if it is something to do with serial communication with solar equipment, it wouldn't make any sense, unless that someone else has the same equipment and issue... Maybe the reporter still checks that email, and can test it out... If theres no activity on the bug in 1 month, I will resolve it abandoned.. Dustin

3 2

Bug 2977 - Homeworld 2 wont launch
by Dustin Navea 25 May '05

25 May '05

Hey guys, this bug was reported, but recently (without updating wine from what I can tell), the reporter updated the kernel with yum.. After doing so, the game launches perfectly (except for the copy protection getting in the way).. Any comments on why this might happen? The reporter should be subscribing shortly, so he can probably post info about it. Dustin

1 0

Re: [dbghelp] dwarf2 support progress step 5
by Alexandre Julliard 24 May '05

24 May '05

Raphael <fenix(a)club-internet.fr> writes: > Hi, > > This times symt model construction seems good :) > > But for debug lines, i don't really understand the sm/regs concept :( > > Changelog: > - implement dwarf2_find_symt_by_ref and dwarf2_add_symt_ref using hashtables > - some debug lines defines > - handle forwards references (ie dwarf2_find_symt_by_ref returns NULL) using > ref hashtable > - better traces It doesn't compile, you probably forgot part of the diff: elf_module.c: In function `elf_load_debug_info_from_map': elf_module.c:901: too few arguments to function `dwarf2_parse' make: *** [elf_module.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Help with winelib and development
by Afkhampour, Cyrus 24 May '05

24 May '05

Hi I am trying to learn how to use winelib/wine as I am trying to port a piece of code from windows to Linux and was told that wine might be the tool to use. I have downloaded wine and begna the winelib tutorial but now I can not find the winemaker file to save my life. Can someone explain what I am missing?

2 1

Compiling with winelib
by antonio.fernandez.moreno＠dmr-consulting.com 24 May '05

24 May '05

Hello, Im trying to compile with winelib the notepad following the steps in the user guide. When I run the make command, the compiler gives me errors with the .rc files. Then I try to compile without these files and the compiler gives me the next error: bash-2.03$ make gcc -c -I. -I/usr/local/include/wine/windows -g -O2 -fPIC -D_REENTRANT -o dialog.o dialog.c LD_LIBRARY_PATH=":$LD_LIBRARY_PATH" /usr/local/bin/winebuild -fPIC -o notepad2.exe.spec.c --exe notepad2.exe -mgui License_En.o dialog.o license.o main.o notepad.exe.dbg.o -L/usr/local/lib -L/usr/local/lib/wine -ladvapi32 -lcomdlg32 -lgdi32 -lkernel32 -lodbc32 -lole32 -loleaut32 -lshell32 -luser32 -lwinspool gcc -c -I. -I/usr/local/include/wine/windows -g -O2 -fPIC -D_REENTRANT -o notepad2.exe.spec.o notepad2.exe.spec.c gcc -shared -Wl,-Bsymbolic -o notepad2.exe.so License_En.o dialog.o license.o main.o notepad.exe.dbg.o notepad2.exe.spec.o -lwine -lwine_unicode -lwine_uuid -lsocket -lw -lm dialog.o: In function `DIALOG_FilePrint': /opt/cfw/wine/programs/notepad2/dialog.c:380: undefined reference to `strcpy' /opt/cfw/wine/programs/notepad2/dialog.c:381: undefined reference to `strlen' dialog.o: In function `DIALOG_SelectFont': /opt/cfw/wine/programs/notepad2/dialog.c:675: undefined reference to `memcpy' /opt/cfw/wine/programs/notepad2/dialog.c:688: undefined reference to `memcpy' dialog.o: In function `DIALOG_Search': /opt/cfw/wine/programs/notepad2/dialog.c:697: undefined reference to `memset' main.o: In function `NOTEPAD_InitData': /opt/cfw/wine/programs/notepad2/main.c:100: undefined reference to `strlen' /opt/cfw/wine/programs/notepad2/main.c:102: undefined reference to `strlen' /opt/cfw/wine/programs/notepad2/main.c:104: undefined reference to `strlen' /opt/cfw/wine/programs/notepad2/main.c:106: undefined reference to `strlen' main.o: In function `HandleCommandLine': /opt/cfw/wine/programs/notepad2/main.c:205: undefined reference to `printf' /opt/cfw/wine/programs/notepad2/main.c:221: undefined reference to `strlen' /opt/cfw/wine/programs/notepad2/main.c:231: undefined reference to `strlen' /opt/cfw/wine/programs/notepad2/main.c:231: undefined reference to `strcmp' /opt/cfw/wine/programs/notepad2/main.c:238: undefined reference to `strncpy' /opt/cfw/wine/programs/notepad2/main.c:239: undefined reference to `strcat' main.o: In function `WinMain': /opt/cfw/wine/programs/notepad2/main.c:276: undefined reference to `memset' test -f notepad2 || install wineapploader notepad2 find: no es posible abrir notepad2: No existe tal archivo o directorio find: no es posible seguir enlace simbólico /etc/wtmpx: No existe tal archivo o directorio install: wineapploader was not found anywhere! make: *** [notepad2.exe.so] Error 2 This error appears because I have not the include <string.h> line. Wont winelib must link with this file when I compile? Im using this version of Wine: Wine-20030618.tar.gz in a Solaris 8 (SPARC) How can I know if winelib is correctly installed? Thank you. Antonio Fernández.

2 1

Bugzilla wiki
by Dustin Navea 24 May '05

24 May '05

Hey everyone, I've just finished the bugzilla wiki.. If anyone has any comments or changes, go ahead and post them. Alexandre, Jeremy, is there any chance that a link to the bugzilla wiki could be put into the sidebars for the winehq main page and the bugzilla main page? That way people can read that, as it has some preferred guidelines on posting (including initial bug reports). If we can get a link there, or at least in the docs, it should cut down on some of the dupes I have been getting, and also make it easier to diagnose bugs. Todo: * find out _every_ valid flag that can be passed to wine via the WINEDEBUG= variable * post them into a separate wiki * post a link from the bugzilla wiki to that new wiki If anyone wants to start emailing me flags and what they do or can be useful for tracing, feel free, and I will get the wiki page started either tonight or tomorrow. Dustin

2 1

Re: ITSS Conformance Test Patch
by Dimi Paun 24 May '05

24 May '05

From: "Chris Watmore" <chris.watmore(a)gmail.com> > This patch adds tests for the itss dll. Please no Perl or Shell scripts -- they will not run on Windows, where we ship tests via winetest. Just code them in C, it shouldn't be too hard. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 1

question about standalone tests
by Kees Cook 24 May '05

24 May '05

Hi! My crypt32 protectdata tests were just added to CVS (thanks!) but they were added without the #ifndef STANDALONE stuff that exists in the recommended example from the lzexpand test code. The steps here: http://www.winehq.com/site/docs/wine-devel/testing-windows don't have a method for doing the build with the free-of-charge windows CLI compiler (which the "STANDALONE" stuff works fine with). Is there some new way to build standalone tests, or should I send a patch for re-including the #ifndef STANDALONE stuff for the tests? -- Kees Cook @outflux.net

3 3

PowerPaint not working
by Andrew Neil Ramage 24 May '05

24 May '05

I installed PowerPaint (free on thw Net, somewhere) OK, but when I try to run it I get a message box telling me the installation is corrupt, and the following output from Wine. andrew@zeus:~/.wine/drive_c/Program Files/FLISoft/PowerPaint> wine PowerPaint.exe fixme:shell:SHGetFileInfoW set icon to shell size, stub fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoCreateInstance no classfactory created for CLSID {47ad7e45-ba98-47e4-887f-9ab7a07f7d4d}, hres is 0x80040150 fixme:ole:CoRegisterMessageFilter stub I am using the latest CVS of Wine. -- Andrew You can be the captain I will draw the chart Sailing into destiny Closer to the heart Closer to the Heart by Rush (A Farewell to Kings, 1977) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel