wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

safedisk 1 update, get your safedisk 1 games out (Not running just yet, but getting there)
by Ivan Leo Puoti 14 Apr '05

14 Apr '05

OK, here is a little summary on where we are with safedisk, here by safedisk I always mean safedisk 1. Safedisk protected games are packed into an encrypted ICD file, in my case the game executable is called EMPIRES2.ICD. Safedisk is actually made up of a little loader, empires2.exe (But this depends on the name of the game), and a kernel mode driver, Secdrv.sys. A safedisk service is installed, and in windows a kernel mode service is just a driver. The loader starts the secdrv service, so I've hacked advapi32 to call the NT function NtLoadDriver when it detects a kernel mode service. This function, after a couple of checks, passes the call to the ntoskrnl program I've written, Microsoft has ntoskrnl<->ntdll communication done by a fancy exception rising/handling system, I have just gone for a named pipe, as we don't use ntoskrnl as a real kernel (In windows everything you do causes loads of calls to ntoskrnl, in wine ntoskrnl is seldom used at all and only handles very few calls). Ntoskrnl loads the driver, and it successfully initialises. At this point the safedisk loader communicates with its driver using DeviceIoControl, it passes an input buffer, that contains some instructions for the driver, and an output buffer that is meant to receive some well defined values that are meant to tell the user mode loader if everything is OK (For example a debugger isn't loaded). The loader also tries to get device handles for well known debuggers, this isn't an issue for us. DeviceIoControl passes the call to NtDeviceIoControlFile, that passes the call on to ntoskrnl. A windows driver handles user mode IO requests via a function called DeviceDispatchControl, it's address is put in the member of the DEVICE_OBJECT struct that the driver's initialisation function fills for the system (This is the DriverEntry routine). In wine currently a device handle is a pointer to a DEVICE_OBJECT struct, guys in #reactos have confirmed this is how things work in windows, and even if AJ thinks we should have real file handles this approach makes no sense to me whatsoever. DeviceDispatchControl in safedisk 1 check the control code passed to DeviceIoControl (It must always be 0xef002407), it then reads the input buffer, if byte 0xc in the buffer is 0x3c it checks the debug registers, other values trigger other checks. It also checks the length of both input and output buffers. It should then read the debug registers, and this should rise and exception that we will somehow handle. However for some unknown reason this doesn't happen, and the status of the IO operation is STATUS_UNSUCCESSFUL, note that this value is in the IRP sturct under Irp.IoStatus.Status, DispatchDeviceControl always returns 0. At this point I would like to know if other safedisk 1 protected games yield different results. I would love to step trough secdrv.sys with winedbg, but it just hangs or crashes. The code in ntoskrnl prints the interesting buffer values that secdrv.sys checks for, it currently prints trace:ntoskrnl:NtDeviceIoControlFile (0x40340ba8,(nil),(nil),(nil),0x4068d9c8,0xef002407,0x414e1498,0x00000514,0x414e19ac,0x00000610) trace:ntoskrnl:driver_control driver_control is at 0x405cea80 trace:ntoskrnl:driver_control Handling IoContorl, handle is 0x40340ba8, ControlCode is ef002407, OutputBufferLength is 610, InputBufferLength is 514 trace:ntoskrnl:driver_control InputBuffer[0xc] is 3c, InputBuffer[410] is 0 fixme:ntoskrnl:IofCompleteRequest stub! trace:ntoskrnl:driver_control IRP_MJ_DEVICE_CONTROL returned 0, IoStatus it c0000001, Infomation is 0 trace:ntoskrnl:driver_control Irp.UserBuffer[0x410] is 0, Irp.UserBuffer[0x40c] is 0 In case of success Irp.UserBuffer[0x410] should be 0x00000500 and Irp.UserBuffer[0x40c] should be 4. All that is needed to run safedisk up to the point where it can run ATM is at http://spazioinwind.libero.it/nonsolomicrosoft/safedisk.html Please get all your safedisk 1 games and try it out, the more people try it the better.

1 0

Heap problems ?
by Paul Vriens 14 Apr '05

14 Apr '05

Hi, is anybody having heap problems with current CVS? I'm seeing random crashes of an application and it seems to point to heap. How can I best go about testing this? Cheers, Paul.

2 1

Re: Datetime scroll fixes
by Robert Shearman 14 Apr '05

14 Apr '05

Duane Clark wrote: > Changelog: > Hour '0' corresponds to 12AM. > Scroll cleanly. > >------------------------------------------------------------------------ > >Index: dlls/comctl32/datetime.c >=================================================================== >RCS file: /home/wine/wine/dlls/comctl32/datetime.c,v >retrieving revision 1.55 >diff -u -p -r1.55 datetime.c >--- dlls/comctl32/datetime.c 14 Apr 2005 11:31:17 -0000 1.55 >+++ dlls/comctl32/datetime.c 14 Apr 2005 18:20:35 -0000 >@@ -630,8 +642,12 @@ DATETIME_Refresh (DATETIME_INFO *infoPtr > DeleteObject (hbr); > oldTextColor = SetTextColor (hdc, comctl32_color.clrWindow); > } >- else >+ else { >+ HBRUSH hbr = CreateSolidBrush (comctl32_color.clrWindow); >+ FillRect(hdc, field, hbr); >+ DeleteObject (hbr); > oldTextColor = SetTextColor (hdc, comctl32_color.clrWindowText); >+ } > > /* draw the date text using the colour set above */ > DrawTextW (hdc, txt, strlenW(txt), field, DT_RIGHT | DT_VCENTER | DT_SINGLELINE); > > This change is wrong. The reason you get the mess when using anti-aliased fonts is that you don't clear the background in the WM_VSCROLL handler. I fixed this in the patch I sent you. Rob

1 0

Re: Datetime picker updown support
by Rob Shearman 14 Apr '05

14 Apr '05

Duane Clark wrote: > This adds support for the updown control in the datetime picker > (previously it existed but did nothing). ... >@@ -874,13 +1008,23 @@ DATETIME_Size (DATETIME_INFO *infoPtr, W > TRACE("Height=%ld, Width=%ld\n", infoPtr->rcClient.bottom, infoPtr->rcClient.right); > > infoPtr->rcDraw = infoPtr->rcClient; >- >- /* set the size of the button that drops the calendar down */ >- /* FIXME: account for style that allows button on left side */ >- infoPtr->calbutton.top = infoPtr->rcDraw.top; >- infoPtr->calbutton.bottom= infoPtr->rcDraw.bottom; >- infoPtr->calbutton.left = infoPtr->rcDraw.right-15; >- infoPtr->calbutton.right = infoPtr->rcDraw.right; >+ >+ if (infoPtr->dwStyle & DTS_UPDOWN) { >+ /* the updown control seems to ignore SetWindowPos messages */ >+ DestroyWindow(infoPtr->hUpdown); >+ /* hmmm... the updown control seems to ignore the width parameter */ >+ infoPtr->hUpdown = CreateUpDownControl (WS_CHILD | WS_BORDER | WS_VISIBLE, >+ infoPtr->rcClient.right-14, 0, 20, infoPtr->rcClient.bottom, >+ infoPtr->hwndSelf, 1, 0, 0, UD_MAXVAL, UD_MINVAL, 0); >+ } >+ else { >+ /* set the size of the button that drops the calendar down */ >+ /* FIXME: account for style that allows button on left side */ >+ infoPtr->calbutton.top = infoPtr->rcDraw.top; >+ infoPtr->calbutton.bottom= infoPtr->rcDraw.bottom; >+ infoPtr->calbutton.left = infoPtr->rcDraw.right-15; >+ infoPtr->calbutton.right = infoPtr->rcDraw.right; >+ } > > /* set enable/disable button size for show none style being enabled */ > /* FIXME: these dimensions are completely incorrect */ > > This seems really wrong. You are destroying and creating the updown control on every size event?!?! That's really going to slow resizes down. Is there any evidence that the native version does it like this? Rob

3 3

Re: ole32: implement FmtIdToPropStgName & PropStgNameToFmtId
by Juan Lang 14 Apr '05

14 Apr '05

--- Alexandre Julliard <julliard(a)winehq.org> wrote: > I get a test failure here (and the heap messages are worrying too, > though they also occur without the patch): > > err:heap:HEAP_ValidateInUseArena Heap 77c10000: prev arena 77c48518 is > not prev for in-use 77c48570 > err:heap:HEAP_ValidateInUseArena Heap 77c10000: prev arena 77c48518 is > not prev for in-use 77c48570 Some tests snuck in that I didn't mean to, I'll omit those. How do I go about debugging heap errors? --Juan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

2 1

TrashCan: Day 2
by Steven Edwards 14 Apr '05

14 Apr '05

Hi, There are still a whole set of RecycleBin APIs that need to be implemented to query and empty the trash but this should work for explorer sending files to the trash. Also note someone else will need to implement the RecycleBin ShellFolder. Thanks Steven __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

1 0

Re: ole32: implement FmtIdToPropStgName & PropStgNameToFmtId
by Alexandre Julliard 14 Apr '05

14 Apr '05

Juan Lang <juan_lang(a)yahoo.com> writes: > ChangeLog: implement FmtIdToPropStgName & PropStgNameToFmtId, with tests, > plus a few more IPropertyStorage tests I get a test failure here (and the heap messages are worrying too, though they also occur without the patch): err:heap:HEAP_ValidateInUseArena Heap 77c10000: prev arena 77c48518 is not prev for in-use 77c48570 err:heap:HEAP_ValidateInUseArena Heap 77c10000: prev arena 77c48518 is not prev for in-use 77c48570 stg_prop.c:285: Test failed: Didn't get expected type or value for property (got type 0, value 0) -- Alexandre Julliard julliard(a)winehq.org

1 0

Borrowing NTVFS layer from Samba4 for Wine?
by Daniel Kegel 14 Apr '05

14 Apr '05

Apologies if this is an old idea, but: Tridge's remarks in his recent interview make me think maybe Wine should be using the same NTVFS layer that Samba4 does. Who knows, maybe it'd be an easy fit... - Dan http://software.newsforge.com/article.pl?sid=05/04/08/2132221&from=rss NF: What are the biggest improvements that have come to fruition in Samba4 and what are the biggest ones that didn't make it or had to be significantly trimmed? Tridge: From my point of view, the biggest improvement is in the code structure. Over half the code in Samba4 is now auto-generated using a new compiler we wrote for the task. That change alone would be worth the effort for me. The code that isn't auto-generated is structured in a modular and very efficient manner. That point of view isn't what users care about, of course, but it does lead to lots and lots of user-visible improvements due to the ease of programming with the new structure. We now commonly come across situations where we say, "OK, let's start on the following feature," and a couple of hours later it's finished, where we might have spent a week or more on the same feature in Samba3. The most user-visible changes in Samba4 will be those associated with the ADS support, and the additional file system features. The file system features are what started the whole Samba4 effort -- Samba4 was initially called the "Samba NTVFS" project, referring to the new virtual file system layer that allows for NT semantics on top of both POSIX and non-POSIX file systems. One simple but important example of how the new NTVFS layer helps is the addition of support for "NT file streams." A file in a NT filesystem can have multiple "streams," where the primary stream (called ":$DATA") is the normal file data that people are used to thinking about, but there can be any number of other named streams containing other types of data, such as meta-data describing who wrote the file, or an audio stream, or even some data from an anti-virus scan of the file. Importantly, recent updates to WindowsXP use streams to store security information about where a file came from, which allows Windows to display a warning when you try to execute a file that comes from an untrusted "security zone." POSIX file systems have no concept of multiple streams, and as Samba was originally designed as a tool for representing a POSIX filesystem to Windows clients, there was no attempt to add stream support. The situation has now changed, with streams becoming a more essential feature for a file server for Windows clients, and at the same time user expectations for compatibility with WindowsNT have risen. This means we really need to support streams, but in order to do that properly, a lot of the internals of Samba needed to be updated. This is achieved in Samba4 using the new NTVFS layer, which allows streams to be represented either using an external database or using "file xattrs," which is an extension recently added to Linux, and which is also present in a number of other, Unix-like systems

4 7

Threading issue with dinput/joysticks
by d13f00l 14 Apr '05

14 Apr '05

http://veracity.ath.cx/~diefool/failure.gz Log is about 100 megs unzipped. This is pretty bizzare. I gzipped a +all log. When a joystick is plugged into my machine, many dinput apps crash with meaningless backtraces unrelated to dinput. It affects a fair amount of apps http://www.blockland.us/blockland/index.asp is an easy one to work on since it crashes as soon as the program starts. It also only crashes when my joystick is plugged in and wine can see /dev/js0. 0047:trace:dinput:create_DataFormat Matching : 0047:trace:dinput:create_DataFormat - Asked (5) : 0047:trace:dinput:create_DataFormat * GUID: {a36d02e3-c9f3-11cf-bfc7-444553540000} ('GUID_RzAxis') 0047:trace:dinput:create_DataFormat * Offset: 20 0047:trace:dinput:create_DataFormat * dwType: 00000603 0047:trace:dinput:create_DataFormat Type: DIDFT_RELAXIS DIDFT_ABSAXIS / Instance: 6 0047:trace:dinput:create_DataFormat - Wine (5) : 0047:trace:dinput:create_DataFormat * GUID: {a36d02e3-c9f3-11cf-bfc7-444553540000} ('GUID_RzAxis') 0047:trace:dinput:create_DataFormat * Offset: 20 0047:trace:dinput:create_DataFormat * dwType: 80ffff03 0047:trace:dinput:create_DataFormat Type: DIDFT_RELAXIS DIDFT_ABSAXIS (unhandled: 80000000) / Instance: DIDFT_ANYINSTANCE 0047:trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x7e98f3a8 0047:trace:seh:EXC_RtlRaiseException info[0]=00000000 0047:trace:seh:EXC_RtlRaiseException info[1]=00000000 0047:trace:seh:EXC_RtlRaiseException eax=00000010 ebx=7e9aa5d8 ecx=00000010 edx=77c5bd50 esi=00000000 edi=7eda3bcc 0047:trace:seh:EXC_RtlRaiseException ebp=77aefad4 esp=77aefa3c cs=0073 ds=007b es=007b fs=003b gs=0033 flags=00010216 0047:trace:seh:EXC_CallHandler calling handler at 0x6437c8 code=c0000005 flags=0 0047:Call kernel32.UnhandledExceptionFilter(77aef5e8) ret=00649b15 I think this is where it gives up in the log. ^^ I'd like to debug this, anyone know where to start?

1 0

fedora core 4 load error
by James Hawkins 13 Apr '05

13 Apr '05

Hi, Fedora Core 4 test2 Wine cvs compiled with gcc4 Running notepad or regedit with wine works fine, but if I try to run any other program or the regression tests, I get this error: [truiken@dynamic-129-120-169-13 tests]$ wine advapi32_test.exe.so registry wine: could not load L"Z:\\home\\truiken\\workspace\\wine\\dlls\\advapi32\\tests\\advapi32_test.exe.so": /home/truiken/.wine/dosdevices/z:/home/truiken/workspace/wine/dlls/advapi32/tests/advapi32_test.exe.so: cannot restore segment prot after reloc: Permission denied This error happens even if I move advapi32_test.exe.so to .wine/drive_c/ The last few lines of +all: 0009:Call ntdll.wine_server_handle_to_fd(00000014,00000000,bfbfda34,00000000) ret=3f30e804 0009: get_handle_fd( handle=0x14, access=00000000 ) 0009: *fd* 0x14 -> 24 0009: get_handle_fd() = 0 { fd=-1, flags=0 } 0009: set_handle_info( handle=0x14, flags=0, mask=0, fd=9 ) 0009: set_handle_info() = 0 { old_flags=0, cur_fd=9 } 0009:Ret ntdll.wine_server_handle_to_fd() retval=00000000 ret=3f30e804 0009:Call ntdll.wine_server_release_fd(00000014,0000000a) ret=3f30e84a 0009:Ret ntdll.wine_server_release_fd() retval=00000000 ret=3f30e84a 0009:trace:file:ReadFile 0x14 0xbfbfdbbc 64 0xbfbfdc00 (nil) 0009:Call ntdll.NtReadFile(00000014,00000000,00000000,00000000,bfbfda50,bfbfdbbc,00000040,00000000,00000000) ret=3f30f176 0009:trace:ntdll:NtReadFile (0x14,(nil),(nil),(nil),0xbfbfda50,0xbfbfdbbc,0x00000040,(nil),(nil)),partial stub! 0009: get_handle_fd( handle=0x14, access=80000000 ) 0009: get_handle_fd() = 0 { fd=9, flags=0 } 0009:trace:ntdll:NtReadFile = 0x00000000 0009:Ret ntdll.NtReadFile() retval=00000000 ret=3f30f176 0009:trace:process:__wine_kernel_init starting Winelib app L"Z:\\home\\truiken\\workspace\\wine\\dlls\\advapi32\\tests\\advapi32_test.exe.so" 0009:Call ntdll.NtClose(00000014) ret=3f32fa15 0009: close_handle( handle=0x14 ) 0009: close_handle() = 0 { fd=9 } 0009:Ret ntdll.NtClose() retval=00000000 ret=3f32fa15 0009:Call ntdll.RtlDosPathNameToNtPathName_U(7fee0540 L"Z:\\home\\truiken\\workspace\\wine\\dlls\\advapi32\\tests\\advapi32_test.exe.so",bfbfdc04,00000000,00000000) ret=3f32be41 0009:trace:file:RtlDosPathNameToNtPathName_U (L"Z:\\home\\truiken\\workspace\\wine\\dlls\\advapi32\\tests\\advapi32_test.exe.so",0xbfbfdc04,(nil),(nil)) 0009:trace:file:RtlGetFullPathName_U (L"Z:\\home\\truiken\\workspace\\wine\\dlls\\advapi32\\tests\\advapi32_test.exe.so" 520 0xbfbfd92c (nil)) 0009:trace:heap:RtlAllocateHeap (0x7fee0000,00000002,000000a0): returning 7fee06c0 0009:Ret ntdll.RtlDosPathNameToNtPathName_U() retval=00000001 ret=3f32be41 0009:Call ntdll.wine_nt_to_unix_file_name(bfbfdc04,bfbfdbfc,00000003,00000000) ret=3f32be5e 0009:trace:heap:RtlAllocateHeap (0x7fee0000,00000002,00000170): returning 7fee0768 0009:trace:file:wine_nt_to_unix_file_name L"\\??\\Z:\\home\\truiken\\workspace\\wine\\dlls\\advapi32\\tests\\advapi32_test.exe.so" -> "/home/truiken/.wine/dosdevices/z:/home/truiken/workspace/wine/dlls/advapi32/tests/advapi32_test.exe.so" 0009:Ret ntdll.wine_nt_to_unix_file_name() retval=00000000 ret=3f32be5e 0009:Call ntdll.RtlFreeUnicodeString(bfbfdc04) ret=3f32be66 0009:trace:heap:RtlFreeHeap (0x7fee0000,00000002,7fee06c0): returning TRUE 0009:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=3f32be66 wine: could not load L"Z:\\home\\truiken\\workspace\\wine\\dlls\\advapi32\\tests\\advapi32_test.exe.so": /home/truiken/.wine/dosdevices/z:/home/truiken/workspace/wine/dlls/advapi32/tests/advapi32_test.exe.so: cannot restore segment prot after reloc: Permission denied 0009:Call ntdll.LdrShutdownProcess() ret=3f32eb0d 0009:trace:module:LdrShutdownProcess () 0009:Ret ntdll.LdrShutdownProcess() retval=00000000 ret=3f32eb0d 0009: terminate_process( handle=0xffffffff, exit_code=1 ) 0009: terminate_process() = 0 { self=1 } 0009: *killed* exit_code=1 /home/truiken/.wine/system.reg: saving key \\Machine /home/truiken/.wine/userdef.reg: saving key \\User\\.Default /home/truiken/.wine/user.reg: saving key \\User\\truiken wineserver: exiting (pid=7150) Any ideas? -- James Hawkins

3 4

How to format a IMediaSample?
by Maarten Lankhorst 13 Apr '05

13 Apr '05

I'm having troubles sending a media sample over the graph, I'm wondering wether that is because of the receiving filter or my own fault. the thing I'm trying to send is a uncompressed 24 bit image, the bitmap info header data of it is pretty much as this: mediatype: BI_RGB24 Width: 320 Height: 240 Bitcount: 24 Size of the image in bytes: 230400 compression: BI_RGB so my questions about it are: - What should I do with the ALLOCATOR_PROPERTIES - What do I have to put in IMediaSample SetActualDataLength - How can I fill the pointer returned by IMediaSample GetPointer so that the sample gets accepted?

3 4

Problems posting to wine-patches
by Duane Clark 13 Apr '05

13 Apr '05

Sorry about posting here, but... I seem to be having problems posting to wine-patches, and don't seem to be able to get through to Jeremy Newman either. Other people seem to be getting through okay. Am I the only one? Any ideas why? I know they are not getting stuck in the moderation queue; they seem to be disappearing without a trace that I can find.

1 0

Re: dib fixes
by Rein Klazes 13 Apr '05

13 Apr '05

Hi Eric, I am looking into a couple of crashes in dlls/x11drv/dib.c caused by a patch from you. The patch (attached) is only 5 years old, I am sure you remember all the details ;) To be precise, I get X-errors in the calls to XGetSubImage caused by out of range parameters. Fixing this by some parameter checking is not the big problem, but I wonder if it is still necessary to have those calls there. You call it a "quick hack", would it not be better to remove it now and properly fix any problems that may surface? The patch that I sent in yesterday ( "fix decoding compressed dibs") is an example of such problem.. Rein.

3 10

Re: Out-of-tree compilation and running
by Detlef Riekenberg 13 Apr '05

13 Apr '05

On Mi, 30.03.2005, 23:04 +0100 Paul Millar wrote in wine-patches: > I've tested this with an in-tree and out-of-tree compilation. Seems to work OK > for me in both cases. I'm working at wineprefixcreate also and while looking at your Patch, i found a race-condition when the user started wineprefixcreate: wine.inf is searched first in "$datadir" and then in "$srcdatadir". "$datadir" is "from the binary wine-tree" when wineprefixcreate was called with "--use-wine-tree" but it could also come from "the installed wine-version", when the option "--use-wine-tree" was not used. wine.inf could be from a different wine-version in this case! my modifications are: before parsing the options: + topdir="" + srcdatadir="" while parsing "--use-wine-tree": - datadir="$topdir/tools" and later: # Copy the .inf script and run it if [ -n "$topdir$srcdatadir" ] then for dir in "$topdir" "$srcdatadir"; do if [ -n "$dir" -a -e "$dir/tools/wine.inf" ]; then cp "$dir/tools/wine.inf" "$CROOT/windows/inf/wine.inf" break fi else cp "$datadir/wine.inf" "$CROOT/windows/inf/wine.inf" fi ---------- I moved srcdatadir one dir-level up to use the same level as "$topdir" and to make my life more easy, because i need "$srcdatadir/documentation/samples/config" for my patches. Sorry, no diff here because I changed much more in my version. (Bug 2844 and Bug 2845). -- by by ... ... Detlef

3 3

Started on TrashCan implementation
by Steven Edwards 13 Apr '05

13 Apr '05

Hi, This is my first real attempt to add a new feature so its going to take quite some time. My long term goal is to implement the RecycleBin for ReactOS and for Wine to make it interface with the FreeDesktop.org draft trashcan spec. The latter might require a extension to Wines or some other process to move files out of the C:\Recycled folder and in to the users ~/Desktop/Trash I have started by adding a little support for the FOF_ALLOWUNDO flag in SHFileOperationW. Windows can use either Drive:\Recycled or Drive:\Recycler depending on if the TrashCan is on a NTFS drive or not so I am not sure how we want to handle it in Wine. With my first patch if you delete a file with this flag it will move the file to C:\Trash which is a file not a directory. I am using the sample programs here to reverse how its supposed to work http://www.maddogsw.com/cmdutils/ If anyone would like to help they can start working on the namespace stuff needed for the RecycleBin. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: Cross-building went wrong
by Juan Lang 13 Apr '05

13 Apr '05

Hi Paul, > Anyone have a suitable patch against mingw that adds > StgCreatePropSetStg? Well, I haven't a patch, but adding the line "StgCreatePropSetStg@12" to w32api/lib/ole32.def ought to do it. --Juan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

3 2

Re: shell32/brsfolder.c
by Michael Jung 12 Apr '05

12 Apr '05

Hi Wolfgang, On Tuesday 12 April 2005 22:30, you wrote: > As you might have guessed, I don't have too much knowledge about > Windows programming. All I wanted to do in the first place was getting > the DVD Shrink dialog to work ;-) I didn't mean to bash your patch. If DVD Shrink doesn't work as on Windows then obviously there something is not correctly implemented in wine. I'm not that familiar with the Windows API either, but I do have two more comments on your patch. > So in order to fix the DVD Shrink failure, only the following change is > needed: > > # -----8<-----(snip)---------- > @@ -100,6 +100,13 @@ > ILRemoveLastID(pidlParent); > pidlChild = ILClone(ILFindLastID(root)); > > + /* This is needed to avoid duplication of the Desktop GUID, > + when an empty PIDL is passed in! */ > + if (_ILIsDesktop(pidlChild)) { > + ILFree( pidlChild ); > + pidlChild = NULL; > + } > + > if (_ILIsDesktop(pidlParent)) { > hr = SHGetDesktopFolder(&lpsfParent); > } else { > # ----->8-----(snap)---------- > > I still like the BFFM_SETSELECTION feature though. You should probably split this up into two individual patches, then. This would make it easier to find misbehaving code later on. > + { > + /* Always show selection */ > + LONG_PTR dlg_style; > + dlg_style = GetWindowLongPtrW(hwndTreeView, GWL_STYLE); > + dlg_style |= TVS_SHOWSELALWAYS; > + SetWindowLongPtrW(hwndTreeView, GWL_STYLE, dlg_style ); > + } > + This probably belongs into the shell32_*.rc files (look for SHBRSFORFOLDER_MSGBOX). Unfortunately, you have to fix it for all the localized versions. I (and I'm sure all of the wine folks, too) do appreciate your effort. Please go ahead and submit to wine-patches. Alexandre will decide if it's ready for inclusion. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

[NtQuerySystemInformation #1] Fixes + tests (second round)
by Paul Vriens 12 Apr '05

12 Apr '05

Hi, this is a second go at some unit tests and related fixes for NtQuerySystemInformation. The ultimate goal is to get SysInternal's Process Explorer running. I welcome suggestions and remarks. If none I will submit this to wine-patches and start the further works. The differences between this one and the first is that I've tried to get the needed length regardless of the passed Length. This is how SystemProcessInformation and some others work and how MSDN tells us it should be implemented. I've also found that M$ doesn't always do this. The patch after this one will add so more unit tests. For example SystemTimeOfDayInformation will always return STATUS_SUCCESS even if the given buffer is too small. Cheers, Paul Vriens. Changelog Start of unit tests for NtQuerySystemInformation Return STATUS_INVALID_INFO_CLASS for non-implemented classes Return len regardless of given Length Return STATUS_INFO_LENGTH_MISMATCH if given length is not sufficient Return STATUS_ACCESS_VIOLATION if no buffer given

1 0

shell32/brsfolder.c
by Michael Jung 12 Apr '05

12 Apr '05

Hi Wolfgang, @@ -400,24 +423,41 @@ static LRESULT MsgNotify(HWND hWnd, UIN break; lptvid=(LPTV_ITEMDATA)pnmtv->itemNew.lParam; - if (SUCCEEDED(IShellFolder_BindToObject(lptvid->lpsfParent, lptvid->lpi,0, (REFIID)&IID_IShellFolder,(LPVOID *)&lpsf2))) - { FillTreeView( lpsf2, lptvid->lpifq, pnmtv->itemNew.hItem,lptvid->pEnumIL); + if ( _ILIsDesktop( lptvid->lpi )) + { + /* Always fill Desktop node without binding to object */ + FillTreeView( lptvid->lpsfParent, lptvid->lpifq, pnmtv->itemNew.hItem, lptvid->pEnumIL); + } + else if (SUCCEEDED(IShellFolder_BindToObject( + lptvid->lpsfParent, lptvid->lpifq, ^^^^^ In TV_ITEMDATA variables, lpsfParent is the IDL of the parent, lpi is the relative IDL to the child and lpifq is the fully qualified IDL to the child. So what you are doing here effectively is to concatenate the parent's IDL with the fully qualified IDL. Replacing this with "lptvid->lpi" fixes the problem in winecfg. There are several occurences of "_ILIsDesktop( lptvid->lpi )" in your patch, which semantically doesn't make much sense to me, since lpi is only the relative IDL. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Cross-building went wrong
by Paul Millar 12 Apr '05

12 Apr '05

Hi all, [yawn] One of the new tests broke winetest build (see below). Anyone have a suitable patch against mingw that adds StgCreatePropSetStg? Cheers, Paul. [paul@quisquiliae tests]$ make i686-mingw32msvc-gcc marshal.o moniker.o propvariant.o stg_prop.o storage32.o testlist.o -o ole32_test.exe -loleaut32 -lole32 -luser32 -lkernel32 -lntdll -luuid stg_prop.o(.text+0xe8): In function `testProps': /home/paul/Production/wine-cross-source/dlls/ole32/tests/stg_prop.c:55: undefined reference to `StgCreatePropSetStg@12' stg_prop.o(.text+0xdef):/home/paul/Production/wine-cross-source/dlls/ole32/tests/stg_prop.c:217:undefined reference to `StgCreatePropSetStg@12' distcc[2034] ERROR: compile on localhost failed make: *** [ole32_test.exe] Error 1

1 0

Rough Draft
by Andrew Neil Ramage 12 Apr '05

12 Apr '05

Rough Draft is a useful Windows word processor that natively saves files in .RTF format. Unfortunately, when installing it I got the following errors: fixme:richedit:RichEditANSIWndProc EM_AUTOURLDETECT: stub fixme:richedit:RichEditANSIWndProc WM_SETFONT: stub fixme:richedit:RichEditANSIWndProc EM_LIMITTEXT: stub fixme:richedit:RichEditANSIWndProc EM_EXLIMITTEXT: stub fixme:richedit:ME_ReleaseStyle all style references freed (good!) err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:ole:SLTG_ProcessDispatch memh.cbExtra is 4320 fixme:ole:SLTG_ProcessDispatch offset 0 0x4a fixme:ole:SLTG_ProcessDispatch memh.cbExtra is 376 fixme:ole:SLTG_ProcessDispatch offset 0 0x4a fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects Anyone know why I get all the fixme's ? -- Andrew Beneath the noble bird Between the proudest words Behind the beauty, cracks appear Once with heads held high They sang out to the sky Why do their shadows bow in fear? Beneath, Between and Behind by Rush (Fly By Night, 1975) ---------------------------------------

2 1

Re: Fix for shell32.SHBrowseForFolder (proper Desktop tree + BFFM_SETSELECTION implemented)
by Michael Jung 12 Apr '05

12 Apr '05

Hi Wolfgang, On Tuesday 12 April 2005 01:03, Wolfgang Scherer wrote: > Solution > -------- > Fix TreeView setup behavior. Implement BFFM_SETSELECTION > functionality. I've tried your patch and it breaks the SHBrowseForFolder usage in winecfg's drive mapping property sheet. I don't have time now, but will look into it soon (hopefully this evening). The last patch, which was applied to this code is http://www.winehq.org/hypermail/wine-cvs/2005/03/0017.html Would you mind to try if this one broke DVD Shrink 3.2? (patch -R) Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Re: lostwages/templates/en status_ui.template
by Jacek Caban 12 Apr '05

12 Apr '05

Log message: Dimitrie O. Paun <dpaun(a)rogers.com <mailto:dpaun@rogers.com?Subject=Re:%20lostwages/templates/en%20status_ui.template>> * Work is ongoing on richedit * Audit of Syslink * We've done all we can on shdocvw.dll for now ... - <td class="pct25">25%: implement shdocvw.dll</td> + <td class="pct100">100%: We forward to Mozilla, but more work is needed on Mozilla for compatibility.</td> I completely disagree. We can do much more than there is done right now. shdocvw is more than WebBrowser control and we can inplement those areas, but WebBrowser needs a lot of work as well. Mozilla ActiveX Control seems not to be systematically developed and the compability we need is not their aim. We need an implementation of WebBrowser based on MSHTML, which will be possible when I finish my work on it. This way we'll be able to implement shdocvw correctly (eg. it'll be possible to implement Internet Explorer OLE Automation), but now it's far, far away from it and really far from 100% complete.

5 9

shell32, ntdll tests
by Aaron Arvey 11 Apr '05

11 Apr '05

Is anyone currently working (or have feedback) on tests for ntdll/loader.c, ntdll/virtual.c, shell32/folder.c, shell32/shlexec.c, or shell32/shell_main.c? More specifically, is it worth the time to write tests for ntdll/loader.c and ntdll/virtual.c? It seems that these files would be used to load any program, so if there were any bugs, I'm guessing they would become apparent immediately and thus having formal tests would be somewhat pointless. Please correct (or reaffirm) me as I am going to write some tests in my spare time and I want to make sure that they'd be useful to the wine project. I'm looking at these specific files because they have code which is run by google's picasa 2, but not by the wine test suite. Thanks! Aaron

2 1

Re: OLEAUT32: Don't crash on divide by zero
by Marcus Meissner 11 Apr '05

11 Apr '05

On Mon, Apr 11, 2005 at 12:47:22PM -0700, Daniel Remenak wrote: > Changelog: > Return DISP_E_DIVBYZERO instead of crashing when asked to divide a > variant by zero. You cannot really compare floats against 0 I think. Ciao, Marcus

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel