wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Fwd: Re: [Wine]winetest and winrash
by Mitchell Mebane 01 Apr '05

01 Apr '05

Ivan Leo Puoti wrote: > Mitchell Mebane wrote: > >> Hey there, >> >> I ran it on my XP Pro SP2 desktop and Windows Server 2003 under >> VMWare just fine, but when I ran it on Win2K Pro SP4 under VMWare, it >> told me the log was too large (6.4 MB > 1 MB) and it would only send >> partial results. Is there any reason this log would be almost an >> order of magnitude larger than the others? >> > From the log it appears to be a problem with the PathIsValidCharA API, > you may want to report this to wine-devel. > > Ivan. > > . > OK, I'll do so. Results are on this page: http://test.winehq.com/data/200503311000/ Specifically, this: http://test.winehq.com/data/200503311000/2000_mmebane/shlwapi:path.txt The OS setup I ran the test under is pretty much a bare-bones Win2K Pro SP4 install. If you want any more information about it, let me know. --Mitchell -- The roots of education are bitter, but the fruit is sweet. --Aristotle

1 0

Re: KERNEL: improve stubs for DnsHostnameToComputerName{A,W}
by Peter Berg Larsen 31 Mar '05

31 Mar '05

+BOOL WINAPI DnsHostnameToComputerNameA(LPCSTR hostname, + LPSTR computername, LPDWORD size) ... + DWORD len; + ... + if (!hostname || !size) return FALSE; + len = lstrlenW(hostname); + + if (len > MAX_COMPUTERNAME_LENGTH) + len = MAX_COMPUTERNAME_LENGTH; + + if (*size < len) + { + *size = len; + return FALSE; + } + if (!computername) return FALSE; + + memcpy( computername, hostname, len ); + computername[len + 1] = 0; + return TRUE; + } I have seen at lot of these where the \0 termination is unspecified for the size parameter, but in this case msdn mentions it. >From msdn: -------- BOOL DnsHostnameToComputerName( LPCTSTR Hostname, LPTSTR ComputerName, LPDWORD nSize ); Parameters Hostname [in] Pointer to a string that specifies the DNS name. If the DNS name is not a valid, translatable name, the function fails. ComputerName [out] Pointer to a string buffer that receives the computer name. The buffer size should be large enough to contain MAX_COMPUTERNAME_LENGTH + 1 characters. nSize [in, out] On input, specifies the size of the buffer, in TCHARs. On output, receives the number of TCHARs copied to the destination buffer, not including the terminating null character. If the buffer is too small, the function fails, GetLastError returns ERROR_MORE_DATA, and nSize receives the required buffer size, not including the terminating null character. ----------- So at least the check should be: if (*size < len + 1) { ... } or you risk the computername[len+1] is invalid. Now the second question is, which might be a convention, where does is say that I cant set computerName size to 3*MAX_COMPUTERNAME_LENGTH and expect it to return the computername not truncated to MAX_COMPUTERNAME_LENGTH? Peter

1 1

Re: Implementation of EnumMoniker and Partial impl on MkParseDisplayName
by Robert Shearman 31 Mar '05

31 Mar '05

Jeff Latimer wrote: > This is the first installment of the implementation of > MkParseDisplayName. I would like feed back on style and usage. Ok, I'll happily add comments on the patch. > > I think the implementation of the EnumMoniker interface looks ok. > Comments appreciated. > > Jeff Latimer > >------------------------------------------------------------------------ > >Index: moniker.c >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/moniker.c,v >retrieving revision 1.38 >diff -u -r1.38 moniker.c >--- moniker.c 13 Dec 2004 21:19:02 -0000 1.38 >+++ moniker.c 28 Mar 2005 12:06:51 -0000 >@@ -29,7 +29,6 @@ > > #include <assert.h> > #include <stdarg.h> >-#include <string.h> > > #define COBJMACROS > >@@ -38,6 +37,7 @@ > #include "winbase.h" > #include "winuser.h" > #include "wtypes.h" >+#include "wine/unicode.h" > #include "wine/debug.h" > #include "ole2.h" > >@@ -50,11 +50,11 @@ > /* define the structure of the running object table elements */ > typedef struct RunObject{ > >- IUnknown* pObj; /* points on a running object*/ >- IMoniker* pmkObj; /* points on a moniker who identifies this object */ >+ IUnknown* pObj; /* points on a running object*/ >+ IMoniker* pmkObj; /* points on a moniker who identifies this object */ > FILETIME lastModifObj; >- DWORD identRegObj; /* registration key relative to this object */ >- DWORD regTypeObj; /* registration type : strong or weak */ >+ DWORD identRegObj; /* registration key relative to this object */ >+ DWORD regTypeObj; /* registration type : strong or weak */ > }RunObject; > > /* define the RunningObjectTableImpl structure */ >@@ -106,6 +106,55 @@ > RunningObjectTableImpl_EnumRunning > }; > >+/* define the EnumMonikerImpl structure */ >+typedef struct EnumMonikerImpl{ >+ >+ IEnumMonikerVtbl *lpVtbl; >+ ULONG ref; >+ >+ RunObject* TabMoniker; /* pointer to the first object in the table */ >+ DWORD TabSize; /* current table size */ >+ DWORD TabLastIndx; /* first free index element in the table. */ > > Since you asked for feedback on style, I'll say that you should try to keep the naming conventions consistent. >+ DWORD runObjTabRegister; /* registration key of the next registered object */ >+ DWORD currentPos; /* enum position in the list */ >+ >+} EnumMonikerImpl; >+ >+ >+/* IEnumMoniker prototype functions : */ >+/* IUnknown functions*/ >+static HRESULT WINAPI EnumMonikerImpl_QueryInterface(IEnumMoniker* iface,REFIID riid,void** ppvObject); >+static ULONG WINAPI EnumMonikerImpl_AddRef(IEnumMoniker* iface); >+static ULONG WINAPI EnumMonikerImpl_Release(IEnumMoniker* iface); >+/* IEnumMoniker functions */ >+static HRESULT WINAPI EnumMonikerImpl_Next(IEnumMoniker* iface, ULONG celt, IMoniker** rgelt, ULONG* pceltFetched); >+static HRESULT WINAPI EnumMonikerImpl_Skip(IEnumMoniker* iface, ULONG celt); >+static HRESULT WINAPI EnumMonikerImpl_Reset(IEnumMoniker* iface); >+static HRESULT WINAPI EnumMonikerImpl_Clone(IEnumMoniker* iface, IEnumMoniker** ppenum); > > If you put the vtable after the implementations of the functions then you don't need to declare the prototypes here. >+ >+/* Local functions*/ >+HRESULT WINAPI EnumMonikerImpl_Initialize(void); >+HRESULT WINAPI EnumMonikerImpl_CreateEnumROTMoniker(RunObject* runObjTab, >+ ULONG TabSize, >+ ULONG TabLastIndx, >+ ULONG currentPos, >+ IEnumMoniker ** ppenumMoniker); >+HRESULT WINAPI EnumMonikerImpl_UnInitialize(void); >+HRESULT WINAPI EnumMonikerImpl_Destroy(void); >+HRESULT WINAPI EnumMonikerImpl_GetObjectIndex(EnumMonikerImpl* This,DWORD identReg,IMoniker* pmk,DWORD *indx); > > Presumably, these should all be static since they are not used outside the file. >+ >+/* Virtual function table for the IEnumMoniker class. */ >+static IEnumMonikerVtbl VT_EnumMonikerImpl = >+{ >+ EnumMonikerImpl_QueryInterface, >+ EnumMonikerImpl_AddRef, >+ EnumMonikerImpl_Release, >+ EnumMonikerImpl_Next, >+ EnumMonikerImpl_Skip, >+ EnumMonikerImpl_Reset, >+ EnumMonikerImpl_Clone >+}; >+ > /*********************************************************************** > * RunningObjectTable_QueryInterface > */ >+/*********************************************************************** >+ * EnumMonikerImpl_CreateEnumROTMoniker >+ * Used by EnumRunning to create the structure and EnumClone >+ * to copy the structure >+ */ >+HRESULT WINAPI EnumMonikerImpl_CreateEnumROTMoniker(RunObject* TabMoniker, >+ ULONG TabSize, >+ ULONG TabLastIndx, >+ ULONG currentPos, >+ IEnumMoniker ** ppenumMoniker) >+{ >+ int i; >+ if (currentPos > TabSize) >+ return E_INVALIDARG; >+ >+ if (ppenumMoniker == 0) >+ return E_OUTOFMEMORY; > > This should probably be E_INVALIDARG. >+ >+ *ppenumMoniker = HeapAlloc(GetProcessHeap(), 0, sizeof(EnumMonikerImpl)); >+ > > if (!*ppenumMoniker) return E_OUTOFMEMORY; >+ void *vpThis=*ppenumMoniker; > > Variable used just for changing types?!?! >+ EnumMonikerImpl* This=0; > > Using NULL instead of 0 tends to make it clearer that you are using a pointer. >+ This=vpThis; > > All of these variable declarations need moving to the top of the block. >+ TRACE("(%p)\n",This); >+ /* initialize the virtual table function */ >+ This->lpVtbl = &VT_EnumMonikerImpl; >+ >+ /* the initial reference is set to "1" because if set to "0" it will be not practis when */ >+ /* the ROT referred many times not in the same time (all the objects in the ROT will */ >+ /* be removed every time the ROT is removed ) */ >+ This->ref = 1; /* set the ref count to one */ >+ This->currentPos=0; /* Set the list start posn to start */ >+ This->TabSize=TabSize; /* Need the same size table as ROT */ >+ This->TabLastIndx=TabLastIndx; /* end element */ >+ This->TabMoniker=HeapAlloc(GetProcessHeap(),0,This->TabSize*sizeof(RunObject)); >+ >+ if (This->TabMoniker==NULL) { >+ HeapFree(GetProcessHeap(), 0, This); >+ return E_OUTOFMEMORY; >+ } >+ for (i=0;i<This->TabLastIndx;i++){ >+ >+ This->TabMoniker[i]=TabMoniker[i]; >+ IMoniker_AddRef(TabMoniker[i].pmkObj); >+ } >+ >+ return S_OK; > } > > /*********************************************************************** >@@ -512,8 +621,180 @@ > return res; > } > >+/*********************************************************************** >+ * EnumMoniker_QueryInterface >+ */ >+HRESULT WINAPI EnumMonikerImpl_QueryInterface(IEnumMoniker* iface,REFIID riid,void** ppvObject) >+{ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ >+ TRACE("(%p,%p,%p)\n",This,riid,ppvObject); >+ >+ /* validate arguments */ >+ if (This==0) >+ return CO_E_NOTINITIALIZED; > > Remove this check. It is completely bogus. >+ >+ if (ppvObject==0) >+ return E_INVALIDARG; >+ >+ *ppvObject = 0; >+ >+ if (IsEqualIID(&IID_IUnknown, riid)) >+ *ppvObject = (IEnumMoniker*)This; >+ else >+ if (IsEqualIID(&IID_IEnumMoniker, riid)) >+ *ppvObject = (IEnumMoniker*)This; >+ >+ if ((*ppvObject)==0) >+ return E_NOINTERFACE; >+ >+ EnumMonikerImpl_AddRef(iface); >+ >+ return S_OK; >+} >+ >+/*********************************************************************** >+ * EnumMoniker_AddRef >+ */ >+ULONG WINAPI EnumMonikerImpl_AddRef(IEnumMoniker* iface) >+{ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ >+ TRACE("(%p)\n",This); >+ >+ return InterlockedIncrement(&This->ref); >+} >+ >+/*********************************************************************** >+ * EnumMoniker_Destroy >+ */ >+HRESULT WINAPI EnumMonikerImpl_Destroy() >+{ >+ TRACE("(?)\n"); >+ >+// if (enumMonikerInstance==NULL) >+// return E_INVALIDARG; >+ >+ /* free the enummoniker structure memory */ >+// HeapFree(GetProcessHeap(),0,enumMonikerInstance); >+ >+ return S_OK; >+} > > You are not using this function, so remove it. >+ >+/*********************************************************************** >+ * EnumMoniker_release >+ */ >+ULONG WINAPI EnumMonikerImpl_Release(IEnumMoniker* iface) >+{ >+ DWORD i; >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ ULONG ref; >+ >+ TRACE("(%p)\n",This); >+ >+ if (This==0) >+ return E_INVALIDARG; > > Another bogus This pointer check. >+ >+ ref = InterlockedDecrement(&This->ref); >+ >+ /* unitialize rot structure if there's no more reference to it*/ >+ if (ref == 0) { >+ >+ /* release all registered objects in Moniker list */ >+ for(i=0;i<This->TabLastIndx;i++) >+ { >+ IMoniker_Release(This->TabMoniker[i].pmkObj); >+ } >+ >+ /* there're no more elements in the table */ >+ >+ TRACE("(%p) Deleting\n",This); >+ HeapFree (GetProcessHeap(), 0, This->TabMoniker); // free Moniker list >+ HeapFree (GetProcessHeap(), 0, This); // free Enum Instance >+ >+ } >+ >+ return ref; >+} >+/*********************************************************************** >+ * EnmumMoniker_Next >+ */ >+HRESULT WINAPI EnumMonikerImpl_Next(IEnumMoniker* iface, ULONG celt, IMoniker** rgelt, ULONG * pceltFetched) >+{ >+// DWORD i; >+// ULONG ref; > > Remove these lines. >+ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ TRACE("(%p) currentPos %d Tablastindx %d\n",This, (int)This->currentPos, (int)This->TabLastIndx); >+ ULONG i; >+ >+ /* retrieve the requested number of moniker from the current position */ >+ for(i=0;((This->currentPos < This->TabLastIndx) && (i < celt));i++) >+ rgelt[i]=(IMoniker*)This->TabMoniker[This->currentPos++].pmkObj; >+ >+ if (pceltFetched!=NULL) >+ *pceltFetched= i; >+ >+ if (i==celt) >+ return S_OK; >+ else >+ return S_FALSE; >+ >+} >+ >+/*********************************************************************** >+ * EnmumMoniker_Skip >+ */ >+HRESULT WINAPI EnumMonikerImpl_Skip(IEnumMoniker* iface, ULONG celt) >+{ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ >+ TRACE("(%p)\n",This); >+ if (This==0) >+ return E_INVALIDARG; > > Another bogus check. I'll stop commenting about these now, but you should remove all of them. >+ >+ if ((This->currentPos+celt) >= This->TabLastIndx) >+ return S_FALSE; >+ >+ This->currentPos+=celt; >+ >+ return S_OK; >+} >+ >+/*********************************************************************** >+ * EnmumMoniker_Reset >+ */ >+HRESULT WINAPI EnumMonikerImpl_Reset(IEnumMoniker* iface) >+{ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ if (This==0) >+ return E_INVALIDARG; >+ >+ This->currentPos = 0; /* set back to start of list */ >+ >+ TRACE("(%p)\n",This); >+ >+ return S_OK; >+} >+ >+/*********************************************************************** >+ * EnmumMoniker_Clone >+ */ >+HRESULT WINAPI EnumMonikerImpl_Clone(IEnumMoniker* iface, IEnumMoniker ** ppenum) >+{ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ if (This==0) >+ return E_INVALIDARG; >+ >+ TRACE("(%p)\n",This); >+ /* copy the enum structure */ >+ return EnumMonikerImpl_CreateEnumROTMoniker(This->TabMoniker, This->TabSize, >+ This->TabLastIndx, This->currentPos, >+ ppenum); >+} >+ > /****************************************************************************** >- * OleRun [OLE32.@] >+ * olerun [ole32.@] > > The name of the function really is OleRun, not olerun. Feel free to submit the change from OLE32->ole32 in another patch, but make sure you change every instance of this. > */ > HRESULT WINAPI OleRun(LPUNKNOWN pUnknown) > { >@@ -523,22 +804,142 @@ > > ret = IRunnableObject_QueryInterface(This,&IID_IRunnableObject,(LPVOID*)&runable); > if (ret) >- return 0; /* Appears to return no error. */ >+ return 0; /* appears to return no error. */ > ret = IRunnableObject_Run(runable,NULL); > IRunnableObject_Release(runable); > return ret; > } > > /****************************************************************************** >- * MkParseDisplayName [OLE32.@] >+ * MkParseDisplayName [ole32.@] > */ > HRESULT WINAPI MkParseDisplayName(LPBC pbc, LPCOLESTR szUserName, > LPDWORD pchEaten, LPMONIKER *ppmk) > { >- FIXME("(%p, %s, %p, %p): stub.\n", pbc, debugstr_w(szUserName), pchEaten, *ppmk); >+ int char_cnt = 0; >+ int usernamelen = 0; >+ HRESULT rc =0; >+ WCHAR username [2048]; // workspace to parse name into > > Please don't use C99 comments. Use "/* comment */" instead. >+ IRunningObjectTable * pprot; >+ IEnumMoniker *spEM; >+ IMoniker * spMoniker; >+// IUnknown * spUnk; >+ LPMALLOC * ppMalloc; >+ TRACE("(%p)\n", pbc); >+ rc = CoGetMalloc(1, (LPMALLOC *) &ppMalloc); > > You leak references to ppMalloc everywhere. Is it really necessary to use CoGetMalloc? > if (!(IsValidInterface((LPUNKNOWN) pbc))) > return E_INVALIDARG; >+ usernamelen = (int) lstrlenW(szUserName); // overall string len >+ > >+ if (szUserName[char_cnt] == (WCHAR) '@') { // This is a progid not a file name >+ FIXME("Progid not implemented\n"); >+ return MK_E_SYNTAX; >+ } else { >+ char_cnt = 0; >+ if (szUserName[char_cnt+1] == ':') { >+ if ((szUserName[char_cnt] < 'a' || szUserName[char_cnt] > 'z') && >+ (szUserName[char_cnt] < 'A' || szUserName[char_cnt] > 'Z')) { >+ FIXME("bad drive %c\n", szUserName[char_cnt]); > > This should be an ERR instead of FIXME, unless there is something you haven't implemented. If that is the case, please add a comment here as to what that could be. >+ return MK_E_SYNTAX; >+ } >+ username[0] = (WCHAR)szUserName[0]; >+ username[1] = szUserName[1]; >+ char_cnt += 2; // point past drive spec >+ } >+ for (; szUserName[char_cnt] != 0x0 && // until end of string or >+ szUserName[char_cnt] != '!' ; char_cnt++) { // end of component >+ FIXME("%c",szUserName[char_cnt]); > > Is this just a debugging statement? >+ if (szUserName[char_cnt] == '\\' && szUserName[char_cnt+1] == '\\') { >+ FIXME("badchar %c\n",szUserName[char_cnt]); >+ return MK_E_SYNTAX; >+ } >+ if (szUserName[char_cnt] == '/' || >+ szUserName[char_cnt] == '?' || >+ szUserName[char_cnt] == '<' || >+ szUserName[char_cnt] == '>' || >+ szUserName[char_cnt] == '*' || >+ szUserName[char_cnt] == '|' || >+ szUserName[char_cnt] == ':') >+ { >+ FIXME("badchar %c\n",szUserName[char_cnt]); >+ return MK_E_SYNTAX; >+ } >+ username[char_cnt] = (WCHAR) szUserName[char_cnt]; > > Shouldn't need a cast here. >+ } >+ FIXME("\n"); >+ username[char_cnt] = 0x0; // terminate the substring >+ TRACE("File name to be converted to Moniker: %s\n", debugstr_w(username)); >+ rc = IBindCtx_GetRunningObjectTable(pbc, &pprot); >+ if (!SUCCEEDED(rc)) >+ { >+ ERR("IBindCtx_GetRunningObjectTable failed %04x\n", (int) rc); > > This should be: + ERR("IBindCtx_GetRunningObjectTable failed 0x%08lx\n", rc); >+ return MK_E_SYNTAX; >+ } >+ rc = IRunningObjectTable_EnumRunning(pprot, &spEM); >+ TRACE("IRunningObjectTable_EnumRunning rc:%04x %p\n", (int)rc, spEM); > > >+ if (SUCCEEDED(rc)) >+ { >+ rc = MK_E_NOOBJECT; >+ while ((IEnumMoniker_Next(spEM, 1, &spMoniker, NULL)==S_OK) && >+ (*ppmk ==NULL)) >+ { >+ WCHAR *szDisplayn=NULL; >+ rc=IMoniker_GetDisplayName(spMoniker, pbc, NULL, >+ (LPOLESTR*) &szDisplayn); >+ TRACE("Display Name %s for Moniker %p\n", debugstr_w(szDisplayn), spMoniker); >+ if (SUCCEEDED(rc)) >+ { >+ TRACE("IMoniker_GetDisplayName succeeded, rc %08x ROT Name:%s, New name:%s\n", >+ (int)rc, debugstr_w(szDisplayn), debugstr_w(username)); >+ if (0==strcmpiW((WCHAR *)szDisplayn, (WCHAR *)username)) >+ { >+ TRACE("is Equal %p\n", spMoniker); >+ *ppmk = spMoniker; // we already have the Moniker, so use it >+ IMoniker_AddRef(spMoniker); // say we are reusing this Moniker >+ } >+ else >+ TRACE("Not Equal\n"); >+ >+ CoTaskMemFree(szDisplayn); >+ } >+ } >+// rc = IRunningObjectTable_GetObject(pprot, spMoniker, &spUnk); >+// if (!SUCCEEDED(rc)) >+// TRACE("ok\n"); >+ IEnumMoniker_Release(spEM); // Free Enum interface >+ IRunningObjectTable_Release(pprot); // Decrement ROT count >+ pprot = NULL; // Finished with ROT pointer >+ } >+ else >+ ERR("IRunningObjectTable_EnumRunning failed %04x\n", (int ) rc); >+ >+ if (*ppmk == NULL) >+ { >+ rc = CreateFileMoniker(username, ppmk); // convert to moniker >+ if (SUCCEEDED(rc)) >+ { >+ *pchEaten = (int) char_cnt; >+ if (usernamelen > char_cnt) // there is more to do and not implemented >+ { >+ TRACE("Username len %i exceeds parsed text %i\n", usernamelen, char_cnt); > > This should be a FIXME then. >+ return MK_E_SYNTAX; >+ } >+ TRACE(" CreateFileMoniker Succeeded %04x\n", (int) rc); >+ return (S_OK); >+ } else >+ { >+ TRACE("CreateFileMoniker Failed %04x\n", (int) rc); > > ERR >+ return(rc); >+ } >+ } >+ else >+ { >+ *pchEaten = (int) char_cnt; >+ TRACE(" Reused Moniker %p\n", *ppmk); >+ return (S_OK); >+ } >+ } > return MK_E_SYNTAX; > } > >Index: Makefile.in >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/Makefile.in,v >retrieving revision 1.43 >diff -u -r1.43 Makefile.in >--- Makefile.in 17 Mar 2005 20:50:35 -0000 1.43 >+++ Makefile.in 28 Mar 2005 12:06:52 -0000 >@@ -5,7 +5,7 @@ > VPATH = @srcdir@ > MODULE = ole32.dll > IMPORTS = advapi32 user32 gdi32 rpcrt4 kernel32 ntdll >-EXTRALIBS = -luuid $(LIBUNICODE) >+EXTRALIBS = -luuid $(LIBUNICODE) > > C_SRCS = \ > antimoniker.c \ > > Useless whitespace only change. >Index: tests/moniker.c >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/tests/moniker.c,v >retrieving revision 1.2 >diff -u -r1.2 moniker.c >--- tests/moniker.c 28 Jan 2005 12:39:13 -0000 1.2 >+++ tests/moniker.c 28 Mar 2005 12:06:56 -0000 >@@ -22,40 +22,166 @@ > #define COBJMACROS > > #include <stdarg.h> >+//#include <wchar.h> > > Remove this line. > > #include "windef.h" > #include "winbase.h" > #include "objbase.h" >+#include "objidl.h" > #include "comcat.h" > > #include "wine/test.h" > > #define ok_ole_success(hr, func) ok(hr == S_OK, #func " failed with error 0x%08lx\n", hr) > >+LPTSTR * prt(HRESULT hr, LPTSTR * lpMsgBuf); > > Not used anywhere. >+ > static void test_MkParseDisplayName() > { > IBindCtx * pbc = NULL; > HRESULT hr; >- IMoniker * pmk = NULL; > ULONG eaten; >- IUnknown * object = NULL; >+ int cnt; >+ > /* CLSID of My Computer */ >- static const WCHAR wszDisplayName[] = {'c','l','s','i','d',':', >+ static const WCHAR wszDisplayName1[] = {'@','c','l','s','i','d',':', >+ '2','0','D','0','4','F','E','0','-','3','A','E','A','-','1','0','6','9','-','A','2','D','8','-','0','8','0','0','2','B','3','0','3','0','9','D',':',0}; > > Does "clsid:..." without the "@" still work? I'd prefer to see that test still in there. >+ >+ hr = CreateBindCtx(0, &pbc); >+ ok_ole_success(hr, CreateBindCtx); >+ IMoniker *pmk1 = NULL; >+ hr = MkParseDisplayName(pbc, wszDisplayName1, &eaten, &pmk1); >+ todo_wine { ok(hr==0x800401e4, "MkParseDisplayName - Progid not implemented hr=%08x\n", (int) hr); } > > MK_E_SYNTAX. See the ok_ole_success macro for how to print out HRESULTs without casts. >+ >+ IBindCtx_Release(pbc); >+ >+ /* A bad drive */ >+ static const WCHAR wszDisplayName2[] = {'1',':','s','i','d',':', > '2','0','D','0','4','F','E','0','-','3','A','E','A','-','1','0','6','9','-','A','2','D','8','-','0','8','0','0','2','B','3','0','3','0','9','D',':',0}; > > hr = CreateBindCtx(0, &pbc); > ok_ole_success(hr, CreateBindCtx); >+ IMoniker *pmk2=NULL; >+ hr = MkParseDisplayName(pbc, wszDisplayName2, &eaten, &pmk2); >+ ok(hr==0x800401e4, "MkParseDisplayName hr=%08x\n", (int) hr); >+ >+ IBindCtx_Release(pbc); > >- hr = MkParseDisplayName(pbc, wszDisplayName, &eaten, &pmk); >- todo_wine { ok_ole_success(hr, MkParseDisplayName); } >+ /* A good drive, bad char */ >+ static const WCHAR wszDisplayName3[] = {'b',':','s','i','d',':', >+ '2','0','D','0','4','F','E','0','-','3','A','E','A','-','1','0','6','9','-','A','2','D','8','-','0','8','0','0','2','B','3','0','3','0','9','D',':',0}; >+ >+ hr = CreateBindCtx(0, &pbc); >+ ok_ole_success(hr, CreateBindCtx); >+ IMoniker *pmk3=NULL; >+ hr = MkParseDisplayName(pbc, wszDisplayName3, &eaten, &pmk3); >+ todo_wine { ok(hr==0x800401e4, "MkParseDisplayName hr=%08x\n", (int) hr); } >+ >+ IBindCtx_Release(pbc); >+ >+ // Good file name >+ static const WCHAR wszDisplayName4[] = {'c',':','\\','w','i','n','d', >+ 'o','w','s','\\','f','r','E','d','.','e','x','E',0x0}; >+ >+ hr = CreateBindCtx(0, &pbc); >+ ok_ole_success(hr, CreateBindCtx); >+ >+ IMoniker *pmk4=NULL; >+ eaten=0; >+ hr = MkParseDisplayName(pbc, wszDisplayName4, &eaten, &pmk4); >+ todo_wine { ok(hr==0, "MkParseDisplayName hr=%08x\n", (int) hr); } >+ >+ IBindCtx_Release(pbc); >+ >+ /* Good file name + item. This test is to see if the whole display >+ * name is consumed >+ */ >+ static const WCHAR wszDisplayName5[] = {'c',':','\\','w','i','n','d', >+ 'o','w','s','\\','f','r','E','d','.','e','x','E','!','m','a','r','k',0x0}; >+ >+ hr = CreateBindCtx(0, &pbc); >+ ok_ole_success(hr, CreateBindCtx); >+ >+ IMoniker *pmk5=NULL; >+ eaten=0; >+ hr = MkParseDisplayName(pbc, wszDisplayName5, &eaten, &pmk5); >+ ok(hr!=0, "MkParseDisplayName failed hr=%08x\n", (int) hr); >+ cnt = (int) lstrlenW(wszDisplayName5); // Get length of text >+ ok(eaten==cnt, "eaten %d string len %i\n", (int) eaten, cnt); // See if consiumed >+ >+ IBindCtx_Release(pbc); >+ >+ /* This test is to create a valid Moniker an then load a couple of >+ * entries into the ROT to test that MkParseDisplayName reuses the >+ * Moniker in the ROT. Currently using the EnumMoniker object as >+ * part of the Register call to satisfy the syntax >+ */ >+ >+ static const WCHAR wszDisplayName6[] = {'c',':','\\','P','r','o','g', >+ 'r','a','m',' ','F','i','l','e','s','\\','v','i','m','\\', >+ 'v','i','m','6','1','\\','g','v','i','m','.','e','x','e',0x0}; >+ hr = CreateBindCtx(0, &pbc); >+ ok_ole_success(hr, CreateBindCtx); > >- if (object) >- { >- hr = IMoniker_BindToObject(pmk, pbc, NULL, &IID_IUnknown, (LPVOID*)&object); >- ok_ole_success(hr, IMoniker_BindToObject); >+ IMoniker *pmk6=NULL; >+ eaten=0; >+ hr = MkParseDisplayName(pbc, wszDisplayName6, &eaten, &pmk6); >+ ok(hr==0, "MkParseDisplayName hr=%08x\n", (int) hr); >+ cnt = lstrlenW(wszDisplayName6); // Get length of text >+ ok(eaten==cnt, "eaten %d string len %i\n", (int) eaten, cnt); // See if consiumed >+ >+ IRunningObjectTable * pprot=NULL; >+ hr = IBindCtx_GetRunningObjectTable(pbc, &pprot); >+ todo_wine { ok(hr==0, "IBindCtx_GetRunningObjectTable hr=%08x\n", (int) hr); } >+ IEnumMoniker *spEM1=NULL; >+ hr = IRunningObjectTable_EnumRunning(pprot, &spEM1); >+ todo_wine { ok(hr==0, "IRunningObjectTable_EnumRunning hr=%08x\n", (int) hr);} >+ IUnknown *lpEM1; >+ hr = IEnumMoniker_QueryInterface(spEM1, &IID_IUnknown, (void*) &lpEM1); >+ todo_wine { ok(hr==0, "IEnumMoniker_QueryInterface hr %08x %p\n", (int) hr, lpEM1); } >+ DWORD pdwReg1=0; >+ DWORD grflags=0; >+ grflags= grflags | ROTFLAGS_REGISTRATIONKEEPSALIVE; >+ hr = IRunningObjectTable_Register(pprot, grflags, lpEM1, pmk5, &pdwReg1); >+ todo_wine { ok(hr==0, "IRunningObjectTable_Register hr=%08x %p %08x %p %p %d\n", >+ (int) hr, pprot, (int) grflags, lpEM1, pmk5, (int) pdwReg1); } >+ >+ DWORD pdwReg2=0; >+ grflags=0; >+ grflags= grflags | ROTFLAGS_REGISTRATIONKEEPSALIVE; >+ hr = IRunningObjectTable_Register(pprot, grflags, lpEM1, pmk6, &pdwReg2); >+ ok(hr==0, "IRunningObjectTable_Register hr=%08x %p %08x %p %p %d\n", (int) hr, >+ pprot, (int) grflags, lpEM1, pmk6, (int) pdwReg2); >+ >+ IEnumMoniker *spEM=NULL; >+ hr = IRunningObjectTable_EnumRunning(pprot, &spEM); >+ todo_wine { ok(hr==0, "IRunningObjectTable_EnumRunning hr=%08x\n", (int) hr); } >+ // Now see if the we get the same moniker after querying the ROT >+ IMoniker *pmk61=NULL; >+ eaten=0; >+ hr = MkParseDisplayName(pbc, wszDisplayName6, &eaten, &pmk61); >+ ok(pmk6==pmk61, "Moniker should be the same address %p != %p\n", pmk6, pmk61); >+ >+ IRunningObjectTable_Revoke(pprot,pdwReg1); >+ IRunningObjectTable_Revoke(pprot,pdwReg2); >+ IEnumMoniker_Release(spEM); >+ IEnumMoniker_Release(spEM1); >+ IRunningObjectTable_Release(pprot); >+ if (pmk61!=NULL) >+ IMoniker_Release(pmk61); >+ if (pmk6!=NULL) >+ IMoniker_Release(pmk6); >+ if (pmk5!=NULL) >+ IMoniker_Release(pmk5); >+ if (pmk4!=NULL) >+ IMoniker_Release(pmk4); >+ if (pmk3!=NULL) >+ IMoniker_Release(pmk3); >+ if (pmk2!=NULL) >+ IMoniker_Release(pmk2); >+ if (pmk1!=NULL) >+ IMoniker_Release(pmk1); > >- IUnknown_Release(object); >- } > IBindCtx_Release(pbc); > } > > > Rob

3 2

installing Win32 Compilers
by Wesley Parish 31 Mar '05

31 Mar '05

Installing MinGW32 together with msys-1.* and msysDTK was a breeze. I started installing lccwin32, only to find problems with the library compilation in the latter part of installation, with it hanging once it got to commandline.txt fdlibm.lib lcccrt0.obj libcrt0s.obj stdlib.idx complex.lib gdbmdll.lib lcccrt0s.obj libml.lib tcconio.lib daguid.lib gdbm.lib lcc.lib regexp.lib UUID.LIB dx8math.lib glaux.lib libc.lib scrnsave.lib weditres.lib dxguid.lib iostream.lib libcrt0.obj shell32.lib wizard/ until I stopped it. Consequently it hung on installing Sleepycat's db. I'll erase the installation and try again, this time saving the error messages. Wesley Parish PS But wow, it felt good, watching MinGW32 install _without_ a hitch! Well done! -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

1 0

Re: Wine Debugger
by Pouech Eric DMI AEI CAEN 31 Mar '05

31 Mar '05

use regedit at the beginning of your script to set the AeDebug key to a "" string (and you should have saved the key value before), and restore it at the end of your script > Message du 31/03/05 08:47 > De : "Cal Pierog" > A : wine-devel(a)winehq.org > Copie à : > Objet : Wine Debugger > > I am trying to write a script which, at one point, needs to run the wine > test suite, accomplished with: > > make -k test > > Even though this skips over bad tests, it does not prevent the debugger > from kicking in every once in a while and asking for user input. I would > like this script to be robust enough to run the test suite without user > input, even when one of the tests fails badly enough to call the debugger. > > So, is there any way to disable the debugger so that the script can just > continue on errors and not sit at a "Wine-dbg>" prompt? > > Thanks, > Cal Pierog > > > > >

2 1

Re: winetest: ask for a tag (take 2)
by Alexandre Julliard 31 Mar '05

31 Mar '05

Ferenc Wagner <wferi(a)tba.elte.hu> writes: > ChangeLog: Ask for a tag if one was not given on the command line. > > This patch incorporates the suggestions of Rob and Mike. > Some casts are still necessary to suppress the warnings, but > this code is hopefully 64-bit safe. Simply storing the string in a global variable would make things a lot easier and more readable... -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine Debugger
by Cal Pierog 31 Mar '05

31 Mar '05

I am trying to write a script which, at one point, needs to run the wine test suite, accomplished with: make -k test Even though this skips over bad tests, it does not prevent the debugger from kicking in every once in a while and asking for user input. I would like this script to be robust enough to run the test suite without user input, even when one of the tests fails badly enough to call the debugger. So, is there any way to disable the debugger so that the script can just continue on errors and not sit at a "Wine-dbg>" prompt? Thanks, Cal Pierog

2 1

Regression in comctl32 Treeview (breaks Filezilla)
by Hannu Valtonen 30 Mar '05

30 Mar '05

Hi, The following patch: ChangeSet ID: 15259 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine.codeweavers.com 2005/01/07 09:34:25 Modified files: dlls/comctl32 : treeview.c Log message: Crestez Leonard <cleonard(a)go.ro> Fix bug with Treeview_SelectItem reselecting the same item. Patch: http://cvs.winehq.org/patch.py?id=15259 Old revision New revision Changes Path 1.160 1.161 +0 -3 wine/dlls/comctl32/treeview.c Breaks Filezilla's (filezilla.sourceforge.net) add new site dialog. The way to reproduce it is to go to the Site manager and click the "New site" button. (Doesn't work even with latest CVS) Without the check which the patch removes, if (prevSelect == newSelect) return FALSE; The dialog goes to an infinite loop. (you can exit it if you just hold the ESC-key down for long enough) I have no idea whether the rationale Leonard provided with his patch is correct, but it does break Filezilla. The binary file for Filezilla can be gotten from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_setup.exe?dow… and the source file from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_src.zip?downl… I would appreciate it if some comctl32 messaging guru could step up and take look at this problem -- - Hannu Valtonen Hannu.Valtonen(a)hut.fi +358408030179

1 1

Re: ScrollWindow fix for windows with WS_CLIPCHILDREN style, with tests - version 2
by Alexandre Julliard 30 Mar '05

30 Mar '05

Rein Klazes <wijn(a)wanadoo.nl> writes: > windows : scroll.c > dlls/user/tests : win.c > > If ScrollWindowEx is called with SW_SCROLLCHILDREN flags for a window > with a WS_CLIPCHILDREN style, then do not use the DCX_USESTYLE flag > option to get a DC for this window. With a couple of regression tests. DCX_USESTYLE has other effects, is it really correct to disable them all? And if so, wouldn't it be better to never use DCX_USESTYLE? -- Alexandre Julliard julliard(a)winehq.org

2 1

Fwd: Wine install fails on Gentoo with `SYS_sigaction' undeclared
by Ferenc Wagner 30 Mar '05

30 Mar '05

Hi, I think this message better fits here on the devel list. Cheers, Feri. -------------------- Start of forwarded message -------------------- From: "Jonathan Duncan" <googlegroups(a)nacnud.com> Newsgroups: comp.emulators.ms-windows.wine Date: 25 Mar 2005 10:26:46 -0800 Message-ID: <1111775206.112993.209430(a)f14g2000cwb.googlegroups.com> I downloaded "Wine-20050310.tar.gz" Untar/zipped it. Entered the directory "wine-20050310" Typed "./configure" -> Success Typed "make depend" -> Success Typed "make" -> The following is the last of the make process: ------------------------------------------------------------- gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o server.o server.c gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o signal_i386.o signal_i386.c signal_i386.c: In function `wine_sigaction': signal_i386.c:114: error: `SYS_sigaction' undeclared (first use in this function) signal_i386.c:114: error: (Each undeclared identifier is reported only once signal_i386.c:114: error: for each function it appears in.) make[2]: *** [signal_i386.o] Error 1 make[2]: Leaving directory `/home/jduncan/downloads/wine-20050310/dlls/ntdll' make[1]: *** [ntdll] Error 2 make[1]: Leaving directory `/home/jduncan/downloads/wine-20050310/dlls' make: *** [dlls] Error 2 ------------------------------------------------------------- I have tried this as a regualar user and as root. I have tried "./tools/wineinstall". I have tried "make distclean" and then reinstalling. I have tried deleting and recreating the install directory. I am using Gentoo with a linux kernel of 2.6.10 on a dual-Xeon 3.2ghz 64-bit system. Any other ideas would be helpful. Thank you. -------------------- End of forwarded message --------------------

4 3

Re: MSVCRT: implement _chsize
by Alexandre Julliard 30 Mar '05

30 Mar '05

Hans Leidekker <hans(a)it.vu.nl> writes: > int _chsize(int fd, long size) > { > - FIXME("(fd=%d, size=%ld): stub\n", fd, size); > - return -1; > + DWORD cur, pos; > + HANDLE handle; > + BOOL ret = FALSE; > + > + TRACE("(fd=%d, size=%ld)\n", fd, size); > + > + LOCK_FILES(); > + > + handle = msvcrt_fdtoh(fd); > + if (handle != INVALID_HANDLE_VALUE) > + { > + /* save the current file pointer */ > + cur = SetFilePointer(handle, 0, NULL, FILE_CURRENT); > + if (cur != INVALID_SET_FILE_POINTER) > + { > + pos = SetFilePointer(handle, size, NULL, FILE_BEGIN); > + if (pos != INVALID_SET_FILE_POINTER) > + ret = SetEndOfFile(handle); > + > + /* restore the file pointer */ > + pos = SetFilePointer(handle, cur, NULL, FILE_BEGIN); > + } > + } > + > + UNLOCK_FILES(); > + return ret ? 0 : -1; > } SetFilePointer can return INVALID_SET_FILE_POINTER on success if the current pointer is 0xffffffff, you have to check last error in that case. Also you need to set errno on failure. It may be easier to use _lseek instead of SetFilePointer as it takes care of all that already. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: increase robustness for incorrect api usage
by Alexandre Julliard 30 Mar '05

30 Mar '05

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > When a context is released, the corresponding heap based struct variable is > zero'ed before being released. When the CryptDestroyHash function is called, > the corresponding context is checked if it was already being zero'ed out. > Note that a heap location is read, which has already been released. However, > this only happens in case of incorrect api usage. This is not guaranteed to > work, but it should be more robust. > > I suspect that windows does it in a similar way. Looking at the actual values > of HCRYPTHASH variables shows that those are addresses in WinXP SP2. > Considering this, I think that the only 100% clean way to implement this > behaviour would be to have a list of currently existing hash and key objects > in the context, which then would be marked invalid when the context is > released. I don't think there's any need to go that far, and I doubt Windows does either. The usual way to handle that is to store a magic number in the struct and clear it on destroy; this is more robust than simply zeroing the pointer since even if the block gets reused it's very unlikely that the proper magic number would get restored. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winetest: ask for a tag
by Robert Shearman 30 Mar '05

30 Mar '05

Ferenc Wagner wrote: >ChangeLog: Ask for a tag if one was not given on the command line. > >This patch depends on sizeof(int)==sizeof(char*) for >returning the buffer address from the dialog. If it should >be done differently, please tell me how. > > Use DialogBoxParam. Rob

1 0

Re: MSVCRT: implement _chsize
by Dmitry Timoshkov 30 Mar '05

30 Mar '05

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > int _chsize(int fd, long size) > { > - FIXME("(fd=%d, size=%ld): stub\n", fd, size); > - return -1; > + DWORD cur, pos; > + HANDLE handle; > + BOOL ret = FALSE; > + > + TRACE("(fd=%d, size=%ld)\n", fd, size); > + > + LOCK_FILES(); > + > + handle = msvcrt_fdtoh(fd); > + if (handle == INVALID_HANDLE_VALUE) goto exit; > + > + /* save the current file pointer */ > + cur = SetFilePointer(handle, 0, NULL, FILE_CURRENT); > + if (cur == INVALID_SET_FILE_POINTER) goto exit; > + > + pos = SetFilePointer(handle, size, NULL, FILE_BEGIN); > + if (pos == INVALID_SET_FILE_POINTER) goto restore; > + > + ret = SetEndOfFile(handle); > + > +restore: > + /* restore the file pointer */ > + pos = SetFilePointer(handle, cur, NULL, FILE_BEGIN); > + > +exit: > + if (ret == FALSE) > + { UNLOCK_FILES(); return -1; } > + else > + { UNLOCK_FILES(); return 0; } > } This a pure coding style comment, just ignore it if you are not agree. In order to avoid goto's (absolutely not needed here IMO) and doubled UNLOCK_FILES(): LOCK_FILES(); handle = msvcrt_fdtoh(fd); if (handle != INVALID_HANDLE_VALUE) { /* save the current file pointer */ cur = SetFilePointer(handle, 0, NULL, FILE_CURRENT); if (cur != INVALID_SET_FILE_POINTER) { pos = SetFilePointer(handle, size, NULL, FILE_BEGIN); if (pos != INVALID_SET_FILE_POINTER) ret = SetEndOfFile(handle); /* restore the file pointer */ pos = SetFilePointer(handle, cur, NULL, FILE_BEGIN); } } UNLOCK_FILES(); return ret ? 0 : -1; -- Dmitry.

1 0

Regression: origin6 crashes with 20050310 (20050211 works)
by Tobias Burnus 30 Mar '05

30 Mar '05

Hello, I try to run a freshly installed Origin6.0 with 20050310, but it shows only the splash window and crashes then. Using the previous release 20050211 it runs just fine. While I don't mind compiling Wine and hunting for the patch which causes this problem, the number of patches is rather huge. Do you have some ideas which can shortcut the regression search? Tobias -------------Working-------------- wine-20050211-1.1.i586.rpm: > wine Origin60.exe fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub err:x11drv:X11DRV_CreateWindow invalid window width -22 fixme:profile:GetPrivateProfileIntW result may be wrong! fixme:storage:StgCreateDocfile Transacted mode not implemented. fixme:storage:StgCreateDocfile Transacted mode not implemented. [...] ----------Crashing---------------- wine-20050310-0.1.i586.rpm: > wine Origin60.exe fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub err:x11drv:X11DRV_CreateWindow invalid window width -22 fixme:msvcrt:_XcptFilter (-1073741819,0x406db1cc)semi-stub wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x20649124 in 32-bit code (0x40f27ca0). In 32 bit mode. Register dump: [...] Stack dump: [...] Backtrace: =>1 0x40f27ca0 cxx_frame_handler+0x1c0 in msvcrt (0x406db6e4) 2 0x40f284d1 MSVCRT__CxxFrameHandler+0x41 in msvcrt (0x406db708) 3 0x401d9fc1 __wine_call_from_32_regs+0xb5 in ntdll (0x406dba70) 4 0x40f278c5 __CxxFrameHandler+0x5 in msvcrt (0x406dbabc) 5 0x401af1b2 EXC_RtlRaiseException+0x1e2 in ntdll (0x406dbb6c) 6 0x401cf6cc raise_segv_exception+0x3c in ntdll (0x406dbb88) 7 0x401da030 __wine_call_from_32_restore_regs+0x0 in ntdll (0x406dbf78) 8 0x40f284d1 MSVCRT__CxxFrameHandler+0x41 in msvcrt (0x406dbf9c) 9 0x401d9fc1 __wine_call_from_32_regs+0xb5 in ntdll (0x406dc304) 10 0x40f278c5 __CxxFrameHandler+0x5 in msvcrt (0x406dc350) 11 0x401af1b2 EXC_RtlRaiseException+0x1e2 in ntdll (0x406dc400) 12 0x401cf6cc raise_segv_exception+0x3c in ntdll (0x406dc41c) 13 0x401da030 __wine_call_from_32_restore_regs+0x0 in ntdll (0x406dc80c) 14 0x40f284d1 MSVCRT__CxxFrameHandler+0x41 in msvcrt (0x406dc830) 15 0x401d9fc1 __wine_call_from_32_regs+0xb5 in ntdll (0x406dcb98) 16 0x40f278c5 __CxxFrameHandler+0x5 in msvcrt (0x406dcbe4) 17 0x401af1b2 EXC_RtlRaiseException+0x1e2 in ntdll (0x406dcc94) 18 0x401cf6cc raise_segv_exception+0x3c in ntdll (0x406dccb0) 19 0x401da030 __wine_call_from_32_restore_regs+0x0 in ntdll (0x40450358) 20 0x00000001 (0x00407244) 21 0x00401970 in origin60 (+0x1970) (0x00401910) 22 0x9090c300 (0x407190b8) 0x40f27ca0 cxx_frame_handler+0x1c0 in msvcrt: movl 0xc(%edi),%eax Modules:[...] +relay output: ---------------------- 000b:Call user32.CallWindowProcA(409def2c,00010084,00000111,050103e9,00010088) ret=5f401ee9 000b:Call window proc 0x409def2c (hwnd=0x10084,msg=WM_COMMAND,wp=050103e9,lp=00010088) 000b:Call window proc 0x5f4019fa (hwnd=0x10066,msg=WM_COMMAND,wp=ffff026e,lp=00010084) 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call user32.GetParent(0001003a) ret=5f401281 000b:Ret user32.GetParent() retval=00000000 ret=5f401281 000b:Call user32.SendMessageA(0001003a,00000111,ffff026e,00010084) ret=5f462ceb 000b:Call window proc 0x5f4019fa (hwnd=0x1003a,msg=WM_COMMAND,wp=ffff026e,lp=00010084) 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.UnhandledExceptionFilter(406cd50c) ret=40c8f2b8 000b:Call ntdll.NtQueryVirtualMemory(ffffffff,000000b4,00000000,406cd410,0000001c,406cd3cc) ret=40532d52 000b:Ret ntdll.NtQueryVirtualMemory() retval=00000000 ret=40532d52 000b:Call ntdll.RtlImageDirectoryEntryToData(00000000,00000001,00000002,406cd40c) ret=404f6029 000b:Ret ntdll.RtlImageDirectoryEntryToData() retval=00000000 ret=404f6029 000b:Call ntdll.NtCreateEvent(406cd3d8,001f0003,406cd3dc,00000001,00000000) ret=404f5f79 000b:Ret ntdll.NtCreateEvent() retval=00000000 ret=404f5f79 wine: Unhandled exception (thread 000b), starting debugger..

1 1

specified Windows directory not accessible
by Wesley Parish 30 Mar '05

30 Mar '05

I get this response when I try to install the VCToolkit. [wparish@localhost wine-hdd]$ wine ./VCToolkitSetup.exe Warning: the specified Windows directory L"C:\\windows" is not accessible. Warning: the specified System directory L"C:\\windows\\system" is not accessible. Warning: could not find DOS drive for current working directory '/home/wparish/wine-hdd', starting in the Windows directory. wine: cannot find './VCToolkitSetup.exe' What have I missed, or misconfigured? (I'm officially running 20040813, though I compiled and installed 20050211 over it - I hadn't read that I should uninstall the previous wine installation before installing a new one. :) Wesley Parish -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

2 1

Autopackage 1.0
by Boaz Harrosh 29 Mar '05

29 Mar '05

now that Autopackage 1.0 is out does any one plan on a Wine Autopackage installer.

2 1

Regression in winealsa (message only?)
by Paul Vriens 29 Mar '05

29 Mar '05

Hi, after this patch: http://cvs.winehq.org/patch.py?id=16795 the installation of Zoo Tycoon 1 demo shows: ALSA lib control.c:654:(snd_ctl_open_noupdate) Invalid CTL plug:hw:0 my .config: ;"Drivers" = "wineoss.drv" ; default for most common configurations ;"Drivers" = "winearts.drv" ; for KDE "Drivers" = "winealsa.drv" ; for ALSA users ;"Drivers" = "winejack.drv" ; for Jack sound server ;"Drivers" = "winenas.drv" ; for NAS sound system ;"Drivers" = "wineaudioio.drv" ; for Solaris machines ;"Drivers" = "" ; to disable sound sound doesn't seem to be affected. Any idea's if this is serious enough? Paul.

3 5

Progress of work on MSHTML
by Jacek Caban 29 Mar '05

29 Mar '05

Hi. I decided that it's time to write here about my work. I'm working on an implementation of MSHTML using Gecko (Mozilla's engine) API. Results of this work you can see here: http://members.lycos.co.uk/merplayers/wine/ Yes, it is Internet Explorer on Mozilla's engine under Wine! At last... it doesn't work as nice as one can think looking at the picture... but it starts to work. I'd like to do it using Linux Mozilla, but to do it I'd need to pass GtkWidget to Gecko. So AFAIK there is no way to do it in an acceptable way for Wine. If there is, please let me know. Gecko API is based on XPCOM that is quite similar to MSCOM. We cannot use Gecko's headers as they are designed for C++, but I wrote idl files that can be used by widl to generate binary-compatibile headers. Fortunetly, excluding interfaces, we can do everything using only C functions. Currently Wine's implementayion uses Mozilla ActiveX Comtrol. It's enough for some applications using it as replacement of WebBrowser Control, yet I don't know anyone using it as replacement of HTMLDocument (and it won't work as this is control, not document). This code needs a lot of cleanup and I need to remove temporary hacks, but I think it's time to start sending patches. Unfortunetly I'll be out next week and this week I won't have much time. This week I'll send only some simple code, and later will come more. Just wanted let you know:) Jacek

1 0

Re: OLEPICTURE: Initialize [orig|himetric][Width|Height] for PICTYPE_ICON case
by Alexandre Julliard 29 Mar '05

29 Mar '05

Alex Villacis Lasso <a_villacis(a)palosanto.com> writes: > You are right. I did a copy&paste from the SerializeIcon code. What do > you think about this patch? Better, but note that there is a twist with GetIconInfo, if the icon is monochrome the color bitmap is 0 and you then need to get the info from hbmMask and divide the height by 2 (you can always count on Microsoft to design clean and intuitive APIs...) You also need to delete the bitmaps when done. Note also that GetDC(0) is preferable to CreateCompatibleDC, it avoids creating a new DC just to delete it again. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: OLEPICTURE: Initialize [orig|himetric][Width|Height] for PICTYPE_ICON case
by Marcelo Duarte 29 Mar '05

29 Mar '05

Alex Villacis Lasso escreveu: > Alexandre Julliard wrote: > >> >> This seems a bit overkill just to retrieve the bitmap size. Couldn't >> you simply do a GetObject on the bitmap? >> >> >> > You are right. I did a copy&paste from the SerializeIcon code. What do > you think about this patch? > > Changelog: > * Initialize [orig|himetric][Width|Height] for PICTYPE_ICON case ... >+ if(GetObjectA(infoIcon.hbmColor, sizeof(bm), &bm) != sizeof(bm)) { > > Maybe GetObjectW is more consistent (get rid w->A calls)?

1 0

Re: Dragon Naturally Speaking - working.
by Konstantin Goudkov 29 Mar '05

29 Mar '05

I got NS7 working on Debian Sid, after running Sidenet setup on Wine 20050310. It took me a while to figure out that I need to raise the Capture level, not just the Mic volume on ALSA. Without it, it looked like NS (and Wine) didn't not pick up the mic even though I could hear myself on the speakers. Also, sometimes not all buttons are clickable even through they should be, so try "Ctrl-S" during the user setup. -- Konstantin Goudkov

3 3

discusion about a message loop in listview.c
by Dietrich Teickner 29 Mar '05

29 Mar '05

Sorry, this helps Agent 2.0 only with a earlyer try, where I have directly checked the loop inside SendMessageTimeout. After moving this to LISTVIEW_SetItemState only FlashFXP 3.02 works. Agent 2.0 has also a meesageloop (veryfied in Odin), it is not the same as with LISTVIEW_SetItemState. Dietrich

1 0

Re: Resent^2 : Zero out return string in GetMenuStr
by Alexandre Julliard 29 Mar '05

29 Mar '05

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > Anything wrong with this patch? > > Changelog: > dlls/user/menu.c: GetMenuStrA|W > Initialize return string as an empty string You need to take the specified length into account before writing to the string. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: OLEAUT32: fix detection of GIF palette index >= 128 for transparency
by Andreas Mohr 29 Mar '05

29 Mar '05

Hi, On Tue, Mar 29, 2005 at 12:43:38PM -0500, Alex Villacis Lasso wrote: > I traced this problem to a one-line bug in the GIF loading code. The > code is supposed to initialize a transparency flag to -1 when no > transparency is used, or else the palette index of the transparency > color. The sample image I was using indicates that the transparency > index is 255. Due to an unintended sign extension, the transparency > index (held in a Byte array of basic type "signed char") is > sign-extended to the variable "transparency" of basic type "signed int". > This causes the flag to be assigned the value -1, which happens to be > the same value used as a no-transparency indicator. So transparency was ....^^^^^^^^^^^^ Heh, 3 times "the transparency" in exactly the same line position, 4 times "transparency" in exactly the same position - what did you smoke?? ;-) (or worse, what did *I* smoke to recognize this?? :-) OK, I promise I'll stop that useless fun email here. Anyway, thanks for all those nice patches, Andreas Mohr

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel