wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

ntdll / kernel32: #53
by Eric Pouech 20 Mar '05

20 Mar '05

This patch starts looking at providing full overlapped I/O support to named pipes. We're not here yet. It basically starts making the wineserver side of the named pipe code: - use NT values instead of kernel32 - make use of asynchronous I/O The rest of the patch is mainly cleanup. It should be a no op change. A+ -- Eric Pouech

1 0

Re: winmm patch
by Dimitrie O. Paun 20 Mar '05

20 Mar '05

On Sat, Mar 19, 2005 at 07:46:01PM -0600, Royce Mitchell III wrote: > Royce Mitchell III <royce3(a)ev1.net> > - fix warning that is really a bug - from looking at the code, wDevID > should be a UINT, not a UINT_16 ( perhaps these should be renamed? ) Please: 1. Send a diff -u (http://winehq.org/site/sending_patches) 2. Don't compress your submissions. -- Dimi.

1 0

Re: Correct calling conventions
by Marcus Meissner 20 Mar '05

20 Mar '05

On Sat, Mar 19, 2005 at 08:30:44PM -0500, Vincent Béron wrote: > Changelog: > Use the correct calling convention in various places. The problem here is too, that these functions do not have prototypes in the correct headers, otherwise gcc would have already warned about them. Ciao, Marcus

2 1

winmm problems
by Robert Lunnon 20 Mar '05

20 Mar '05

I am having some problems with the latest wine under Solaris and a small test game I use, (Little Fighter 2) , if I enable audio support the application seems to deadlock but without audio it runs OK. It doesn't matter what audio driver I select (libaudioio or arts). Since February, what changes have been made to the audio framework that might cause this behaviour? Bob

1 0

Four questions to dll/iphlpapi/* wrt lstrcpyA.
by Peter Berg Larsen 20 Mar '05

20 Mar '05

Hi, I was looking at the Janitorial project of replacing strncpy with lstrcpyn{A,W}. I found the following code in iphlpapi a little strange. (Well, only question number 2, but then could as well ask about the 2 others.) I have marked where in the code the question belongs to with the question numbers. 1) I am wondering, why sizeof(ptr->Adaptername) is used instead of MAX_ADAPTER_NAME_LENGTH+1? Is there something special coded in the 3 last bytes, since they are hidden by the = '\0' the line below? if not then this be replaced with lstrcpyn(... , MAX_ADAPTER_NAME_LENGTH+1)? 2) Is 2a supposed to be saying 15 or is there someting about IpMask and Context that must be zero, when setting IpAddress, and IpMask? 3) Why suddenly the change to use memcpy? and not some strcpy function as the code above it? Peter typedef struct { char String[4 * 4]; } IP_ADDRESS_STRING, IP_MASK_STRING, ...; typedef struct _IP_ADDR_STRING { struct _IP_ADDR_STRING* Next; IP_ADDRESS_STRING IpAddress; IP_MASK_STRING IpMask; DWORD Context; } IP_ADDR_STRING, *PIP_ADDR_STRING; typedef struct _IP_ADAPTER_INFO { ... char AdapterName[MAX_ADAPTER_NAME_LENGTH + 4]; char Description[MAX_ADAPTER_DESCRIPTION_LENGTH + 4]; BYTE Address[MAX_ADAPTER_ADDRESS_LENGTH]; IP_ADDR_STRING IpAddressList; ... IP_ADDR_STRING PrimaryWinsServer; IP_ADDR_STRING SecondaryWinsServer; } IP_ADAPTER_INFO, *PIP_ADAPTER_INFO; ipenum.c: 936 char *toIPAddressString(unsigned int addr, char string[16]) { if (string) { struct in_addr iAddr; iAddr.s_addr = addr; /* extra-anal, just to make auditors happy */ strncpy(string, inet_ntoa(iAddr), 16); string[16] = '\0'; **** 2a **** } return string; } iphlpapi_main.c: 584 DWORD WINAPI GetAdaptersInfo(PIP_ADAPTER_INFO pAdapterInfo, PULONG pOutBufLen) { ... PIP_ADAPTER_INFO ptr = &pAdapterInfo[ndx]; ... 1) /* on Win98 this is left empty, but whatever */ strncpy(ptr->AdapterName, getInterfaceNameByIndex(table->indexes[ndx]), sizeof(ptr->AdapterName)); ptr->AdapterName[MAX_ADAPTER_NAME_LENGTH] = '\0'; ... 2) toIPAddressString(getInterfaceIPAddrByIndex(table->indexes[ndx]), ptr->IpAddressList.IpAddress.String); toIPAddressString(getInterfaceMaskByIndex(table->indexes[ndx]), ptr->IpAddressList.IpMask.String); ... 3) memcpy(ptr->PrimaryWinsServer.IpAddress.String, primaryWINS.String, sizeof(primaryWINS.String)); memcpy(ptr->SecondaryWinsServer.IpAddress.String, secondaryWINS.String, sizeof(secondaryWINS.String)); ... }

1 0

kde plugin
by Oliver Stieber 20 Mar '05

20 Mar '05

Hi, I've got a plugin for KDE that displays icons and thumbnails for windows applications and dlls in Konqueror. I was intending to extend it to meta info and maybe a full kioslave for browsing windows PE files, but never got that far. At the moment it's a bit of a licensing nightmare, but I can package it up in a format that's ok for QT and Wine if anyone's interested. Oliver. Send instant messages to your online friends http://uk.messenger.yahoo.com

2 3

Re: Theming for Wine via the registry
by Oliver Stieber 20 Mar '05

20 Mar '05

--- Mike Hearn <mike(a)navi.cx> wrote: > On Sat, 2005-03-12 at 21:00 +0000, Oliver Stieber > wrote: > > > > > > Ah, that's different. That'd actually require > using > > > Gtk/Qt which we cannot > > > do, the best we can get is to look like them. > > > > > What's the problem, licensing, integration or > > thread-safety (I know QT isn't thread safe) > > Well all those *could* be problems, but the real > problem is that the > Windows widget toolkit and GTK/Qt are too different, > you can't map > between them. The only problem I can see would be drawing the widgets, I haven't looked deeply enough into QT or GTK to know if it's more on the 'impossible' side of difficult or not. Wrapping the event loop and passing events should be relatively easy. > > I may have a look at that too, it would be useful > if > > QT/GTK could use some of the existing Windows > > accessibility software. > > No, that's not what I meant. Implementing OLE > accessibility would mean > that Win32 apps on Wine appear to in native tools > like at-poke. It > wouldn't mean you could use win32 accessibility > software to access > native apps. > That doesn't sound too hard, I don't know how well defined Gnome and QT's accessibility interfaces are but I think QT's coming along quite well it would be nice is everything got Dbused though. Send instant messages to your online friends http://uk.messenger.yahoo.com

4 3

Re: dlls/advapi32/tests/security.c - Bugfix in test!
by Alexandre Julliard 19 Mar '05

19 Mar '05

Jakob Eriksson <jakov(a)vmlinux.org> writes: > --- dlls/advapi32/tests/security.c 14 Mar 2005 17:20:58 -0000 1.12 > +++ dlls/advapi32/tests/security.c 16 Mar 2005 09:32:28 -0000 > @@ -289,8 +289,8 @@ > luid.LowPart = i; > cchName = sizeof(buf); > ret = pLookupPrivilegeNameA(NULL, &luid, buf, &cchName); > - ok( ret && GetLastError() != ERROR_NO_SUCH_PRIVILEGE, > - "LookupPrivilegeNameA(0.%ld) failed: %ld\n", i, GetLastError()); > + if (GetLastError() != ERROR_NO_SUCH_PRIVILEGE) > + ok( ret, "LookupPrivilegeNameA(0.%ld) failed: %ld\n", i, GetLastError()); It doesn't really make sense to check the last error if the function succeeded. -- Alexandre Julliard julliard(a)winehq.org

4 4

Re: Wine FAQ removed from the doc tarballs
by Hiji 19 Mar '05

19 Mar '05

> I always find it annoying when I cannot go to > /usr/share/doc/<package> I suppose the other option is to provide all docs as a seperate package on a release basis (like any other package.) I could be wrong on this, but I don't think the docs are updated on a monthly basis. :) For example, a user could see that the newest Wine package released thus far is from March and the newest Wine docs package could be November of last year (arbitrary date). And if its only 23kb, it shouldn't be much of a problem for modem users; escpecially since it saves them from having to download an extra 23kb with every Wine release when they don't really need it. :) Hiji P.S. Looking at http://www.gimp.org/downloads/ , it looks like they are already doing something similar with their help files. They offer them as a seperate download. __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: RICHED20: remove casts and unused code
by Dimitrie O. Paun 19 Mar '05

19 Mar '05

> +static inline char *RTFStrSave(char *s) Not a big deal, but the name is a bit uncommon. Wouldn't RTFStrDup() be a better/more recognizable name? -- Dimi.

1 0

Re: Wine FAQ removed from the doc tarballs
by Hiji 19 Mar '05

19 Mar '05

--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > On Fri, Mar 18, 2005 at 02:04:08PM +0100, Francois > Gouget wrote: > > But I don't see any reason not to put it in > wine-doc-html.tar.gz or > > wine-doc-txt.tar.gz. The idea of these tar files > is so that one can get > > all the Wine documentation with just one download > and the FAQ is part of > > the documentation. > > Yes, but I can not possibly see why would anyone > want to download and > read the FAQ like this. A FAQ is essentially a Web > type of document, > best view and browsed on the Web. By including it in > those packages, > we just make them bigger for 99.99% of the users > that don't care > about the FAQ, and those users are probably the ones > that have most > bandwidth restrictions anyway. > > But I'm not totally against it being there, if > people feel strongly > that we must, I'll go with the flow. As a web developer (and Wine user), I feel inclined to believe that all major documentation should be removed from the source. A README file pointing the user to the web site for the latest documentation would be most efficient and beneficial. Basically, by doing this, users will begin realizing that if they want documentation, WineHQ is the place to go. In a sense, it is streamlining information. Not only does this reduce user confusion, but it also minimizes the propagation of old documentation which no one will have the power to update. By not consolidating the documentation resource, there will eventually be a certain percentage of the Wine userbase trying to follow outdated Wine documents. Hiji __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

3 2

TlsAlloc limitation in winxp mode
by Michael Ost 19 Mar '05

19 Mar '05

With the emulation mode set to "winxp" I can only TlsAlloc 64 indexes, even though the MSDN docs say there should be at least 20 million. http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/ba… Has anyone done any work on this? Any workaround/hackarounds? ... mo

3 3

Re: [WINEOSS] use default prepare functions
by Francois Gouget 18 Mar '05

18 Mar '05

On Thu, 17 Mar 2005, Robert Reif wrote: > Fall back to default header prepare and unprepare functions. > > A driver only needs to support prepare and unprepare functions > when it is doing something special like allocating a DMA buffer for > each header. Since we don't do anything special, just fall back > to the default functions. Removes redundant code. Does that mean we could do the same wor winealsa, winearts, etc? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

3 4

Re: RICHEDIT: RTF reader i18n (now with font charset support)
by Vitaly Lipatov 18 Mar '05

18 Mar '05

В сообщении от 17 Март 2005 13:20 Phil Krylov написал(a): > this patch replaces my precious patch "RICHEDIT: RTF reader i18n" and > needs to be applied after Krzysztof Foltman's "RICHEDIT: RTF reader > improvements and optimizations (TAB craziness fixed)" patch. > > ChangeLog: > > Replaced slow and outdated character set handling in RTF reader by > Unicode/codepages support. Added charset->codepage conversion. Will we do this code in locale independent manner? Why we have ansiCodePage=1252 by default? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Registration of dlls - proposition
by Jacek Caban 18 Mar '05

18 Mar '05

Hi, Currently functions Dll[Un]RegisterServer in Wine look strange to me. It's a great code duplication. As we have ATLRegistrar implementation right now it can be changed. We can use ATL to register dlls. This way functions Dll[Un]RegisterServer can be really simple and registry can be described by elastic and simple rgs scripts. You can see example of rgs script here: http://cvs.winehq.org/cvsweb/wine/dlls/atl/atl.rgs?rev=1.2&content-type=tex… and documentation of ATLRegistrar here: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vcmfc98/ht… There are two more aspects of this solution: - dependence on atl I don't think it's a true problem as we can create ATLRegistrar by CoCreateInstance and finally we depend on atl _only_ while registering, so it's not a great dependency... - header file We would need to make atliface.idl accessible for other dlls. Actually it is a public ATL header file, so there is nothing wrong in doing this. We could just move it to include/ (or maybe include/atl where, in future, more headers of ATL could be placed). The benefit is: no code duplication, more elastic and clean registration code. What do you think? Is it a good idea? Thanks, Jacek

2 1

Re: Add some autoconf warnings
by Alexandre Julliard 18 Mar '05

18 Mar '05

Francois Gouget <fgouget(a)free.fr> writes: > I thought I had sent this patch months ago but apparently not. The > idea is to warn the user when some often used libraries are missing > and is based on the warnings issued for bad Mesa or X > configurations. Let me know if the range of checks should be expanded > or reduced or otherwise tweaked. We've discussed this before, I don't think we should warn about these things, it's perfectly harmless in most cases and will just alarm users for no good reason. -- Alexandre Julliard julliard(a)winehq.org

5 5

Re: Wine FAQ removed from the doc tarballs
by wino＠piments.com 18 Mar '05

18 Mar '05

>> A FAQ is essentially a Web type of document, best view and browsed on the Web. This does not ring true. I dont see that any part of the doc "best viewed on the web" unless it's something like a change log or last minute info. Someone with limitted acces time or pay by the minute may well want to grab the whole thing at full speed and read it later off line. Neither do I think that the FAQ represents such a large percentage of the total that it merits speciail treatment. If the doc as a whole is deemed too big split it, I doubt that this is necessary. Regards. -- Opera 7 mail on Linux

1 0

Re: STI, device drivers and stuff
by Damjan Jovanovic 18 Mar '05

18 Mar '05

--- Kuba Ober <kuba(a)mareimbrium.org> wrote: > > IStiDeviceControl are probably part of the Windows > DDK > > (Device Driver Kit), and that you get separately > from > > Microsoft (for a ridiculous price). > > It's a free CD. You pay only for shipping. If you > want, I've got two of those > and can transfer one of them to be taken care of by > the wine folks. As long > as it's a US address, that is. > > Cheers, Kuba No, I live in South Africa. Can't you email me the file? Bye Damjan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

2 1

Wine FAQ removed from the doc tarballs
by Francois Gouget 18 Mar '05

18 Mar '05

I noticed that we don't include the Wine FAQ in the Wine documentation tarballs. So I added it but then I noticed that it was removed from the tarballs by this patch: --- revision 1.36 date: 2003-09-18 20:51:32 +0000; author: julliard; state: Exp; lines: +9 -5 Remove the FAQ from the doc tarball, and build it as a single .html file (based on patch by Dimitrie O. Paun). --- What's the reasoning behind this? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ In theory, theory and practice are the same, but in practice they're different.

2 3

Re: ddraw correctness fixes patch
by Christian Costa 18 Mar '05

18 Mar '05

> Message du 18/03/05 06:44 > De : "Tom Wickline" > A : "wine-devel" > Copie à : > Objet : ddraw correctness fixes patch > > anyone know why this patch hasn't been accepted? > > http://www.winehq.org/hypermail/wine-patches/2005/03/0328.html > > Tom > Hi Tom, Sorry I missed the patch on wine-patches but I do remember an old version sent to wine-devel. So let's review it. :-) The new locking mechanism is wrong. DDLOCK_xxx are just used for optimization. The thing to do during the blit should be something like that : sdesc.dwSize = sizeof(sdesc); ddesc.dwSize = sizeof(ddesc); if (src == NULL) IDirectDrawSurface7_Lock(iface, &lock_dst, &ddesc, DDLOCK_WRITEONLY, 0); else if (src == iface) { RECT lock_union = < rect that just contains lock_dst and lock_src >; IDirectDrawSurface7_Lock(iface, &lock_union, &ddesc, 0, 0); sdesc = ddesc; } else { IDirectDrawSurface7_Lock(src, &lock_src, &sdesc, DDLOCK_READONLY, 0); IDirectDrawSurface7_Lock(iface, &lock_dst, &ddesc, DDLOCK_WRITEONLY, 0); } and the previous locking code should be used. The added DD_STRUCT_INIT are useless. Hope that helps. Bye, Christian

1 0

animate control regression
by Krzysztof Foltman 18 Mar '05

18 Mar '05

The current CVS version has a regression in the animate control, causing a deadlock, most probably in WM_DESTROY handler, in the app I'm testing Wine with. trace:message:SPY_ExitMessage (0x10038) L"{SysAnimate32}" message [0047] WM_WINDOWPOSCHANGED returned 00000000 trace:message:SPY_EnterMessage (0x10038) L"{SysAnimate32}" message [0002] WM_DESTROY sent from self wp=00000000 lp=00000000 err:ntdll:RtlpWaitForCriticalSection section 0x403a3cb8 "?" wait timed out in thread 0009, blocked by 000a, retrying (60 sec) Reversing these two patches seems to fix the problem: http://cvs.winehq.org/patch.py?id=16654 http://cvs.winehq.org/patch.py?id=16619 I don't know if patch 16654 has any effect on this problem - I don't know this code well enough to reverse patches in random order. Hope it isn't difficult to fix... Krzysztof

3 3

New wine user
by Jerry H. Menor 18 Mar '05

18 Mar '05

Hi all, Wine is ronning just fine, and our program.exe is working, I just want to know if it is possible to create a shorcut of our program on our desktop so that a end user will just click the icon on the desktop to run the program.exe without typing on th text command "wine program.exe". TYIA! Jerry

2 1

Re: TlsAlloc limitation in winxp mode
by Jon Griffiths 18 Mar '05

18 Mar '05

Hi Michael, > With the emulation mode set to "winxp" I can only TlsAlloc 64 > indexes, even though the MSDN docs say there should be at least > 20 million. You're misreading that page, the limits are: Win 2000/2003 & XP - 1088 indexes per process Win Me/98 - 80 indexes per process Win NT and 95 - 64 indexes per process So it seems that Me/98 add 16 on top of the original 64 limit, while from Win2k onwards another 1024 indices were added. You can almost certainly work around this if you have the source for the app you are trying to run, unless your app has more than 64 threads running at once. Just take all of the per-thread data you need and stick it into a structure, store only the pointer to that for each thread (1 slot). This adds a layer of indirection but means you are limited only by the heap, provided you don't have more than 64 threads. See dlls/msvcrt/thread.c for an implementation example. Cheers, Jon "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: New wine user
by Hiji 18 Mar '05

18 Mar '05

--- "Jerry H. Menor" <jerry(a)netserve.ph> wrote: > Hi all, > > Wine is ronning just fine, and our program.exe is > working, I just want to > know if it is possible to create a shorcut of our > program on our desktop > so that a end user will just click the icon on the > desktop to run the > program.exe without typing on th text command "wine > program.exe". > > TYIA! > Jerry Hi Jerry, Yes, you can. On your Linux desktop, create a launcher with the "wine program.exe" command (there should be a field for such a thing). Also, for general Wine usage, wine-users(a)winehq.org might be better suited for your needs. :) Hiji __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: OLE32: Allow STGM_SHARE_EXCLUSIVE for nameless storage files
by Mike McCormack 18 Mar '05

18 Mar '05

Actually, I think the test is just the wrong way round. It should read if (STGM_SHARE_MODE(grfMode) != STGM_SHARE_EXCLUSIVE) I screwed it up in the following commit: http://cvs.winehq.org/cvsweb/wine/dlls/ole32/storage32.c.diff?r1=1.71&r2=1.… Mike Troy Rollo wrote: > StgOpenStorage was failing if pwcsName was NULL and the share flags were > STGM_SHARE_EXCLUSIVE. It shouldn't (Windows allows this). > > ChangeLog: > Allow STGM_SHARE_EXCLUSIVE for StgOpenStorage with pwcsName == NULL > - if (STGM_SHARE_MODE(grfMode) == STGM_SHARE_EXCLUSIVE) > - goto end; > -

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel