wine-devel

wine-devel@winehq.org

12 participants
84463 discussions

NOTIFY_PRE and NOTIFY_POST definitions in include files
by Paul Vriens 13 Jan '05

13 Jan '05

Hi, just found the following: [paul@penguin include]$ grep -e NOTIFY_PRE -e NOTIFY_POST * netspi.h:#define NOTIFY_PRE 0x00 netspi.h:#define NOTIFY_POST 0x01 npapi.h:#define NOTIFY_PRE 0x00000001 npapi.h:#define NOTIFY_POST 0x00000002 this doesn't look right although they do not seem to be used anywhere in the code currently. Any comments? Cheers, Paul.

2 1

Re: The use of a zero flag
by Rolf Kalbermatter 13 Jan '05

13 Jan '05

Paul Vriens wrote: >a few days ago I found a bug in ole32/compobj.c where we did something >like: > >if ( foo & FLAG) .... where FLAG=0 > >This 'inspired' me to check for more of these kind of checks. > >One that I already found is in dlls/dplayx/dplay.c > >We are checking for DPSET_REMOTE (which is zero) where we should have >checked for !DPSET_LOCAL or something alike. Often flag sets with a zero flag are more like an enumeration than real flags and have some sort of mask defined which specifies which bits are relevant for that group of flags. Microsoft does something mix real flags and enumeration flags in the same integer but always at different bit locations. Something like if ((foo & MASK) == FLAG) will usually work fine then. Rolf Kalbermatter

1 0

[COMCTL32] The use of the PGS_VERT flag
by Paul Vriens 13 Jan '05

13 Jan '05

Hi, the flag PGS_VERT is zero and should not be checked against. It's only the lack of PGS_HORZ that should be checked. Is the following piece of code needed in dll//comctl32/pager.c: 851 if (!(dwStyle & PGS_HORZ) && !(dwStyle & PGS_VERT)) 852 { 853 dwStyle |= PGS_VERT; 854 SetWindowLongA(hwnd, GWL_STYLE, dwStyle); 855 } The check is whether any of the flags is set, but PGS_VERT is already the default when there is a lack of PGS_HORZ. Cheers, Paul.

1 0

Best DLLs to write conformance tests for?
by Dan Kegel 13 Jan '05

13 Jan '05

Recently, I helped a student at Harvey Mudd college write and submit a conformance test for the lzexpand dll: http://www.winehq.com/hypermail/wine-cvs/2004/11/0164.html I picked lzexpand.dll since (lacking a GUI) it seemed simple to test. Now I'm putting together a reusable lab project for other colleges, at http://kegel.com/wine/sweng, and am trying to pick a few good DLLs for the students to write tests for. (I plan ask the students to send me their patches so I can review them before they post them on wine-patches.) Clearly, I shouldn't ask anyone to write a conformance test for a huge DLL in a term, so I guess I'll focus on on the DLLs with under 100 functions. And I'd like to skip DLLs that have GUIs, so I guess I'll omit any where the word HWND occurs. That leaves the following 53 DLLs or VxDs: amstream atl cabinet capi2032 cards cfgmgr32 comcat crypt32 d3dx8 d3dxof dbghelp devenum dinput8 dmband dmcompos dmscript dmsynth dmusic32 dplayx dpnet dpnhpast dswave dxdiagn dxerr8 dxerr9 glu32 iccvid icmp ifsmgr.vxd imagehlp itss mmdevldr.vxd monodebg.vxd msdmo mshtml msimg32 msisys msnet32 msvidc32 mswsock olepro32 olesvr qcap secur32 vdhcp.vxd vmm.vxd vnbt.vxd vnetbios.vxd vtdapi.vxd vwin32.vxd win32s winaspi wsock32 That's a small enough list that I can start guessing at which ones are worth writing tests for. Let's see, how 'bout the following 12: amstream atl cabinet crypt32 dplayx dpnet icmp imagehlp itss mswsock winaspi wsock32 Are any of those obviously poor choices for writing a conformance test? Or are there others that are obviously good choices, but that I missed? Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 3

Re: USER32: Implement SPI_{GET,SET}MINIMIZEDMETRICS
by Mike McCormack 13 Jan '05

13 Jan '05

jchevrier(a)nexicom.net wrote: > *Implemented SPI_GETMINIMIZEDMETRICS calculated from values returned by > GetSystemMetrics. The math applied to the values returned from > GetSystemMetrics was verified against Windows 98 and XP using a simple test > program. Yey for test programs :) Would you mind sending it to the list or adding some tests in dlls/user/tests/sysparams.c ? thanks, Mike

1 0

[AppDB] script to clean duplicate users
by Jonathan Ernst 12 Jan '05

12 Jan '05

This script will remove duplicate users from the appdb (same email address), give their data to the most recently logged user that has the same email address and then fix the db structure so that it's not possible anymore to have two time the same email address. Usage: 1)chmod u+x ./clean.php 2)edit clean.php to set up the database connection (line 11 and 12) 3)./clean.php (if php is not in /usr/bin/php you'll have to edit the first line too)

1 0

Re: [QUARTZ] Revert regsvr.c patch
by Robert Shearman 12 Jan '05

12 Jan '05

Paul Vriens wrote: >Hi, > >Christian made me aware of the following: > >--- >As long as this object is not implemented, the FIXME should remain to >remind us that something is missing from quartz. >--- > >As 'Seeking' is not yet implemented I would like to have this patch >reverted. > >Sorry for any inconvenience. > >Cheers, > >Paul > >Changelog > Remove CLSID for registration as it's not implemented yet. > > There is no need to revert the patch because, although the CLSID is not implement yet, it will still print out a fixme in DllGetClassObject (line 181 in dlls/quartz/main.c). Rob

1 0

Re: Palm OS Desktop & Wine
by Stefan Dösinger 12 Jan '05

12 Jan '05

> > The palm Desktop > > installer requires some playing with MSI, I don't remember exactly what I > > did. Note that you can't run the Palm Desktop application, but you can > > run hotsync.exe which is enought to get PDF files onto the palm. > > hotsync.exe: I guess you mean running the HotSync icon on the PDA. No, it's an Win32 binary in the Palm Desktop install directory (usually C: \program files\palm\) It's the "Hotsync Manager". Of course you'll need the HotSync programs on the PalmOS side too. > > No, it doesn't work with USB. > > OK that, it is clear. Well, I didn't try, it might work but I don't think so. Especially because visor.c claims the device. > Here I am lost: Sorry for that. > Could you please explain me this a little more in detail. Should I use > infrared connection or USB connection for what you just described (network > sync with 127.0.0.1)? I do have pi-nredir & pilot-link on my linux laptop > but I do not see what I should configure on my PDA. Moroever, which port > should I provide to pi-nredir ? Could give me the right command to use for > "pi-nredir" to install > /mnt/cdrom/essential_software/acrobatreader_for_palmos/adobereader-palmos.e >xe as example ? A small step-for-step howto: *Install Palm Desktop. *install the Adobe Reader for PalmOS converter. This means running adobereader-palmos.exe with wine *Launch hotsync.exe from the directory where Palm.exe is installed. You'll get the hotsync icon in your Desktop's systray *Double-click it with the right mouse button. You'll always have to double click the hotsync icon to open the menu, I don't know why *Select the "Setup..." menu item or whatever it is called. I have the German version and it's labeled "Einrichten..." *Open the network tab, press "TCP/IP Settings". Check if the ip is correct and enter a correct subnet mask, e.g. 255.255.255.0 *Press OK to close the windows *terminate any Linux app which might access the Palm. Connect the Palm to your PC with the USB cable *Launch the Hotsync program on your PalmOS device *Open the menu and select "LANSync-Setup" or what it's called. The german version labels it "LANSync-Einst..." *Select LANSync and tab OK to close the dialog *Start the Hotsync over the usb cable. *Run pi-nredir -p /dev/pilot on your Computer 3 or 4 secounds later. The Hotsync dialog should pop up and the Device should perform a hotsync with the Win32 Palm Desktop. (replace /dev/pilot with the hotsync port visor.c provides to you. Usually /dev/ttyUSBX or /dev/usb/tts/X) To upload a pdf launch the pdf converter from it's install directory, and select the pdf file to upload. Then perform a hotsync. I hope this is correct, I wrote it down from memory. Cheers, Stefan

1 0

Janitorial : check all refcounts in Wine?
by Paul Vriens 12 Jan '05

12 Jan '05

Hi, for the described Janitorial task 'Use Interlocked functions in AddRef and Release methods' I'm currently looking at This->ref. If I however do a wider search I find a bit more, for example: kernel/atom.c:256: entryPtr->refCount++; msi/handle.c:188: ret = info->refcount--; rpcrt4/cproxy.c:219: This->RefCount++; setupapi/virtcopy.c:106: vhstrlist[n]->refcount++; and so on. I only looked at names containing 'ref'. But there are more around where 'ref' is not in the name: ole32/compobj.c: COM_CurrentInfo()->inits++; I know it's a hell of a job, but should these also be 'fixed'/changed? Of course it's a bit hard to tell which are thread unsafe. Cheers, Paul.

2 1

[AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c
by Paul Vriens 12 Jan '05

12 Jan '05

Hi, during my code cleanup I came to acmstream.c and found the following: static ULONG WINAPI ACMStream_fnAddRef(IAVIStream *iface) { IAVIStreamImpl *This = (IAVIStreamImpl *)iface; TRACE("(%p) -> %ld\n", iface, This->ref + 1); /* also add reference to the nested stream */ if (This->pStream != NULL) IAVIStream_AddRef(This->pStream); return ++(This->ref); } the AddRef can be cleaned up. the Release however looks buggy: static ULONG WINAPI ACMStream_fnRelease(IAVIStream* iface) { IAVIStreamImpl *This = (IAVIStreamImpl *)iface; TRACE("(%p) -> %ld\n", iface, This->ref - 1); if (This->ref == 0) { /* destruct */ This means I have to do a Release twice before it actually goes into the if statement, because the decrementing takes place at the end of the Release function. Can anybody confirm my finding. Cheers, Paul.

2 3

Request for Sourceforge Upload Access
by Scott Ritchie 12 Jan '05

12 Jan '05

I need to upload the Debian packages into the Sourceforge HTTP space in order for our APT server to be up to date. It'd be nice if I could do it myself. My sourceforge name is yokozar If someone could add me that would be great. Thanks, Scott Ritchie

1 0

[Fwd: msttcorefonts are missing I think]
by Scott Ritchie 12 Jan '05

12 Jan '05

A user sent me this. I'm not exactly sure what she's referring to. Any ideas?

2 1

import stubs
by Dan Notestein 12 Jan '05

12 Jan '05

Instead of directly using native methods to export functions from wine shared libs, Wine and WineLib emulate the windows methodology for exporting/importing these functions. Is this just to enable the use of native Windows dlls in Wine, or is it needed for other reasons? I ask because we're currently using WineLib to port to Solaris and HPUX, where native Windows dlls wouldn't work anyways, and it might be nice if we can remove this overhead on these platforms (and save us some porting headaches). However, before we started this work, we want to be sure there are no "gotchas" associated with removing it.

1 0

Re: Correction to COINIT_MULTITHREADED test
by Christian Costa 11 Jan '05

11 Jan '05

> Message du 11/01/05 08:45 > De : "Paul Vriens" > A : "Bill Medland" > Copie à : "wine-devel(a)winehq.org" > Objet : Re: Correction to COINIT_MULTITHREADED test > On Mon, 2005-01-10 at 21:20, Bill Medland wrote: > > Bill Medland (billmedland(a)mercuryspeed.com) > > Correct testing for multithreaded > > (as spotted by Paul Vriens; fix suggested by Robert Shearman) > > > Hi Bill, > > it wasn't the check that was way over my head. The thing is, that with > this code change we walk a new path in COM_CreateApartment. > > I don't know what the result is but in CoInitializeEx we do: > > 545 if (!(apt = COM_CurrentInfo()->apt)) > 546 { > 547 apt = COM_CreateApartment(dwCoInit); > 548 if (!apt) return E_OUTOFMEMORY; > 549 } > > and apparently that leaves us with a E_OUTOFMEMORY all the time. Which > means that we will not come to the part: All the time ? Looking at COM_CreateApartment it seems COINIT_APARTMENTTHREADED works but indeed COINIT_MULTITHREADED always return NULL. I think the code at the beginning of COM_CreateApartment is wrong. TRACE("thread 0x%lx is entering the multithreaded apartment\n", GetCurrentThreadId()); COM_CurrentInfo()->apt = &MTA; return apt; I think we should return COM_CurrentInfo()->apt rather than apt. Bye, Christian

2 4

Palm OS Desktop & Wine
by FyD 11 Jan '05

11 Jan '05

Dear All, I have a Tungsten E PDA and use K-pilot/J-pilot to backup/restore/install .pdb/.prc files with my linux box. No problem for that. => However, I would like to install a .pdf viewer on my PDA and the files provided for this installation are not .pdb/.prc files but a Windows executable file (AdobeReader305-PalmOS.exe). To install this file, I need to install the whole Palm Desktop CD under windows. => Consequently, I thought to use Wine for that: I compiled Wine_20041201 on my linux box (RedHat 9.0), configured it with 'winesetuptk' and run 'wine /mnt/cdrom/autorun.exe' to install the whole Palm Desktop CD for window. The installation seems to start ok & I get the following error message: [...] fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:powermgnt:SetThreadExecutionState (0x80000000): stub, harmless. Please use the registry key HKEY_CURRENT_CONFIG\Software\Fonts\LogPixels to set the screen resolution and remove the "Resolution" entry in the config file fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to (nil) fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to 0x4c Installation of D:\palm desktop\Palm Desktop.msi (SETUPEXEDIR=D:\palm desktop) failed. err:dc:DCE_FreeWindowDCE [0x20024] GetDC() without ReleaseDC()! I tried to find info on the web about 'Palm OS Desktop installation & Wine' without success... Is it possible to do install the 'Palm OS Desktop' CD with Wine and/or any idea for my problem ? Thanks a lot, regards, Francois

6 10

Re: [AppDB] mysql_query -> appdb_query in /include
by Paul van Schayck 11 Jan '05

11 Jan '05

Hey Jonathan, On Tue, 11 Jan 2005 00:59:44 +0100, Jonathan Ernst <Jonathan(a)ernstfamily.ch> wrote: > This patch replaces nearly all mysql_query with appdb_query in /include. We should use query_userdb() in include/user.php. We're allowing a seperate database for it. This patch was already applied tough: http://www.winehq.org/hypermail/wine-cvs/2005/01/0257.html But also your previous mysql_query patch is using query_appdb where it should use query_userdb(). Or will we just start dropping that second database? It seems like the live server did not seperate them. Jeremy can you confirm? Paul

2 1

(Job) Two Embedded Positions - S. CALIF
by Naren 11 Jan '05

11 Jan '05

I have 2 embedded positions in this email: Position 1) Embedded Engineer - S. California This is my direct client opening - I need an Embedded Engineer for my client in S. California - 6 months contract to hire position I need an Embedded Engineer, as follows: Minimum of five years experience in developing embedded management systems for telecom/datacom products. Proven track record in C++ and Linux programming. Strong hands-on design knowledge of SNMP, web browser and IP based network management architectures applying Ethernet, RS-232 and I2C protocols is required. This is a Full time Permanent FTE position with the client in S. CA. Salary being offered is $80K - $90K per year, with standard benefits. Very stable company with a great working atmosphere. Client would prefer to have local US citizens or GC Holders only (but may be open to H1 Visa transfer for the right individual). Client prefers not to pay for relocation for this position. Please complete and copy/paste this completed skills-matrix to me with your response: Full name: Total IT exp: Total Embedded Engineer exp: Total Embedded telecom products exp: Total Embedded datacom products exp: Total C++ exp: Total Linux exp: Total SNMP exp: Total web browser programming exp: Total IP based network protocols exp: Specify protocols used: Degree Major: Are you a US citizen or GC holder (Y/N): Specify: What percentage of a fit are you, based on the above job description?: Are the above skills reflected in your resume? (Please ensure you send me a resume that shows all the above skills) Salary required: Day Tel# Eve Tel# Cell number: Availability: Your current City / State: If you qualify for this position, are available immediately and are interested, please send your resume, rate and contact information to mailto:ResumeCGT9@cgt-consult.com?subject=Embedded-Eng-S-CA Please ensure you complete and copy/paste the above completed matrix with your response. Position 2) Embedded Linux Networking Systems Engineer - Los Angeles This is my direct client opening - I need an Embedded Linux Networking Systems Engineer for my client in S. California - Full time permanent position I need an Embedded Linux Networking Systems Engineer, as follows: PRINCIPAL FUNCTIONS · Embedded system architecture definition and design with particular emphasis on standard and tailored MAC (Medium Access Control) layer protocols. · Design, modify and implement Linux device drivers for wireless physical interfaces. · Design, modify and guide the implementation of tools for testing and user network configuration and administration. · Design and guide the selection and implementation of IP security algorithms and processes. · Support Sales and Product Management as required. JOB SKILLS · Must understand software/firmware development and testing strategies. · Proficiency in GNU C++ Compiler, Real-time programming concepts, Linux drivers. . Experience in Python and/or Visual C++ in Windows is a bonus. · Fundamental understanding of wireless networking and 802.11x standards. · A working knowledge of IP security techniques. · Technical knowledge of IP routing protocols and algorithms (RIP2, OSPF, OLSR, BGP) · Working knowledge of internet standards and protocols, MAC Layer concepts, scheduling algorithms and routing algorithms. · Familiar with Linux Kernel, Red Hat and Fedora. QUALIFICATIONS · Must recently have had the responsibilities of Embedded System or Design Engineer. · BS or Masters, or equivalent, in Electrical Engineering, Computer Science or Physics. This is a Full time Permanent FTE position with the client in Los Angeles, S. CA. Salary being offered is $80K - $90K per year, with standard benefits. Very stable company with a great working atmosphere. Client would prefer to have local US citizens or GC Holders only. There is no relocation available for this position. Please complete and copy/paste this completed skills-matrix to me with your response: Full name: Total IT exp: Total MAC layer protocols exp: Total Wireless exp: Specify (CDMA, 802.11x): Total IP security algorithms and processes exp: Total IP security protocols exp: Specify: Total Linux exp: Total Routing exp: Total Python exp: Total VC++ exp: Degree Major: Are you a US citizen or GC holder (Y/N): Specify: What percentage of a fit are you, based on the above job description?: Are the above skills reflected in your resume? (Please ensure you send me a resume that shows all the above skills) Salary required: Day Tel# Eve Tel# Cell number: Availability: Your current City / State: If you qualify for this position, are available immediately and are interested, please send your resume, rate and contact information to mailto:ResumeCGT9@cgt-consult.com?subject=Embed-Linux-Network-Sys-Eng Please ensure you complete and copy/paste the above completed matrix with your response. Please click here to view all other openings from CGT Consulting: http://www.cgt-consult.com/displayjobs.asp PS - If you know of other groups where I can post these jobs, I would welcome such suggestions. The more candidates who get the opportunity to review our opening the more candidates we can help find a job!! I am only looking for job sites, which cater for US candidates only. PSS - If you want to receive future real-time IT job notifications, from CGT Consulting Inc., via email, go to: <http://www.cgt-consult.com/join-cgt-groups.htm> and sign up to receive such notifications, based on your skills. Subscribe to receive ALL job postings or openings for only your specific background. Feel free to refer your friends, who are looking for a job to the above groups!! Please feel free to forward this email to anybody whom you know would be interested or is looking for a job and can benefit from joining our job groups. Expand your job search and send your resume to over 3,000 recruiters - http://www.ResumeAgencies.com CGT Consulting Privacy Policy: <http://www.cgt-consult.com/privacy> Can Spam Compliant To opt-out of future correspondence, please send an email to mailto:cgt@cgt-consult.com?subject=Remove-Embededd or reply with "REMOVE" in the subject heading and include in the body of your email. Email-id: wine-devel(a)winehq.com

1 0

OXID marshaling error
by Bill Medland 11 Jan '05

11 Jan '05

Any idea what is going wrong in the OXID handling here? Is "a" the first thread of the new process? Is the problem that it should be "b"? (I've removed a few extraneous traces) (This is after the COM_CreateApartment fixes patch) 0009:trace:ole:create_marshalled_proxy rclsid={4dfceca2-156a-4e02-9d02-2e5253ad1d01}, iid={00000001-0000-0000-c000-000000000046} 0009:trace:ole:create_marshalled_proxy waiting for \\.\pipe\{4DFCECA2-156A-4E02-9D02-2E5253AD1D01} 0009:trace:ole:create_server activating local server 'L"G:\\runtime\\a4wlpmgr.exe -Embedding"' for {4DFCECA2-156A-4E02-9D02-2E5253AD1D01} 0009:trace:ole:create_marshalled_proxy waiting for \\.\pipe\{4DFCECA2-156A-4E02-9D02-2E5253AD1D01} 0009:warn:ole:create_marshalled_proxy Could not open named pipe to broker \\.\pipe\{4DFCECA2-156A-4E02-9D02-2E5253AD1D01}, le is 2 000b:trace:ole:DllMain 0x540000 0x1 0x1 0009:trace:ole:create_marshalled_proxy waiting for \\.\pipe\{4DFCECA2-156A-4E02-9D02-2E5253AD1D01} 0009:warn:ole:create_marshalled_proxy Could not open named pipe to broker \\.\pipe\{4DFCECA2-156A-4E02-9D02-2E5253AD1D01}, le is 2 000b:trace:ole:CoInitializeEx ((nil), 0) 000b:trace:ole:CoInitializeEx () - Initializing the COM libraries 000b:trace:ole:RunningObjectTableImpl_Initialize () 000b:trace:ole:COM_CreateApartment thread 0xb is entering the multithreaded apartment 000b:trace:ole:CoRegisterClassObject ({4dfceca2-156a-4e02-9d02-2e5253ad1d01},0x405701a0,0x00000004,0x00000005,0x412054) 000b:trace:ole:CoMarshalInterface (0x4006b7a0, {00000001-0000-0000-c000-000000000046}, 0x405701a0, 0, (nil), 1) 000b:trace:ole:CoGetStandardMarshal ({00000001-0000-0000-c000-000000000046},0x405701a0,0,(nil),1,0x51fd84) 000b:trace:ole:CoMarshalInterface Using standard marshaling 000b:trace:ole:CoMarshalInterface Calling IMarshal::MarshalInterace 000b:trace:ole:StdMarshalImpl_MarshalInterface (...,{00000001-0000-0000-c000-000000000046},...) 000b:trace:ole:start_apartment_listener_thread apt->listenertid=0 000d:trace:ole:apartment_listener_thread Apartment listener thread starting on (\\.\pipe\WINE_OLE_StubMgr_0000000a00000000) 000b:trace:ole:CoGetPSClsid () riid={00000001-0000-0000-c000-000000000046}, pclsid=0x51fd18 000b:trace:ole:CoGetPSClsid () Returning CLSID={00000320-0000-0000-c000-000000000046} 000b:trace:ole:CoGetClassObject CLSID: {00000320-0000-0000-c000-000000000046}, IID: {d5f569d0-593b-101a-b569-08002b2dbf7a} 000b:trace:ole:COMPOBJ_DLLList_Add 000b:trace:ole:PSFacBuf_CreateStub ({00000001-0000-0000-c000-000000000046},0x405701a0,0x51fd10) 000b:fixme:ole:StdMarshalImpl_MarshalInterface table marshalling unimplemented 000b:warn:ole:get_stub_manager_from_object Could not map OXID a00000000 to apartment object 000b:trace:ole:register_ifstub constructing new stub manager 000b:warn:ole:register_ifstub Could not map OXID a00000000 to apartment object -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

2 2

Re: USER32: cursoricon
by Alexandre Julliard 11 Jan '05

11 Jan '05

Vitaly Lipatov <lav(a)etersoft.ru> writes: > Changelog: > return fail if file format is unknown This will make it fail for all normal cursor/icon files. These don't have a header so you can't check a magic number. -- Alexandre Julliard julliard(a)winehq.org

2 2

ole32: questions about the COINIT flags
by Paul Vriens 11 Jan '05

11 Jan '05

Hi, I was looking through some MSDN doc: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/com/htm/cm… there it's stated that: If neither concurrency model is specified by the dwCoInit parameter, the default is COINIT_MULTITHREADED. Does this mean we should change the way we interpret these flags (in compobj.c for example) because COINIT_MULTITHREADED equals 0 (which is a bit strange value for a flag)? The native QUARTZ.DDL calls CoInitializeEx with a COINIT of 4 which effectively has the COINIT_DISABLE_OLE1DDE and the COINIT_MULTITHREADED flags set. Shouldn't we have a check for COINIT_APARTMENTTHREADED and if this flag is not set we have to assume COINIT_MULTITHREADED? Especially because both these flags cannot be set at the same time (see mentioned MSDN doc). Cheers, Paul.

2 1

Re: [QUARTZ] Get rid of a CLSID fixme
by Christian Costa 11 Jan '05

11 Jan '05

> Message du 11/01/05 13:50 > De : "Paul Vriens" > A : "wine-patches(a)winehq.org" > Copie à : "Christian Costa" > Objet : [QUARTZ] Get rid of a CLSID fixme > Hi, > > just needed an extra CLSID in the registry to avoid some fixme's: > > fixme:ole:CoCreateInstance no classfactory created for CLSID > {060af76c-68dd-11d0-8fc1-00c04fd9189d} As long as this object is not implemented, the FIXME should remain to remind us that something is missing from quartz. Bye, Christian

1 0

wine alsa detection
by Joris Huizer 11 Jan '05

11 Jan '05

Hello, Today I switched back to alsa 0.9 (downgraded everything that had to do with alsa 1.0 as far as I can tell) but still, alsa is detected as available: checking alsa/asoundlib.h usability... yes checking alsa/asoundlib.h presence... yes checking for alsa/asoundlib.h... yes checking for snd_pcm_open in -lasound... yes And wine breaks when compiling wine alsa - then it does all the compiling again as dependencies are assumed to be wrong -- finally breaking again at the same place; Are you sure your configuration patch tests for those failing functions? I attached a log of it failing with wine 0.9 - maybe you have to test for some (all??) of those? If you have reason to think I forgot something when downgrading, please tell me what it was (I'm using debian/stable - with added unofficial alsa packages, of http://afavant.elte.hu/~wferi/lilypond/, as suggested earlier on the list ) regards, Joris

2 3

Re: Janitorial : Use Compiler Warnings ( -Wmissing-declarations ) ( #1, take 2 )
by Alexandre Julliard 11 Jan '05

11 Jan '05

Rémi Assailly <remi.assailly(a)free.fr> writes: > diff -u libs/wine/debug.c libs/wine/debug.c > --- libs/wine/debug.c 2005-01-10 20:12:34.748897920 +0100 > +++ libs/wine/debug.c 2005-01-10 19:18:26.000000000 +0100 > @@ -61,6 +61,9 @@ > return strcmp( name, *chan + 1 ); > } > > +void *__wine_dbg_register( char * const *channels, int nb ); > +void __wine_dbg_unregister( void *channel ); This is useless, please don't add such code only to quiet optional warnings. > diff -u include/wine/unicode.h include/wine/unicode.h > --- include/wine/unicode.h 2005-01-09 12:09:03.000000000 +0100 > +++ include/wine/unicode.h 2005-01-10 19:23:51.000000000 +0100 > @@ -95,6 +95,8 @@ > extern int vsprintfW( WCHAR *str, const WCHAR *format, va_list valist ); > extern int vsnprintfW( WCHAR *str, size_t len, const WCHAR *format, va_list valist ); > > +extern int get_decomposition(WCHAR src, WCHAR *dst, unsigned int dstlen); > + get_decomposition is an internal function, it shouldn't be exported in the public header. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Minor wine-devel DCOM corrections
by Dan Kegel 11 Jan '05

11 Jan '05

Rob Shearman wrote: > We have a number of marshaling tests in our test framework at the moment > (in wine/dlls/ole32/tests/marshal.c). It is hard to do anything > cross-process (or cross-machine!) because of the way the test framework > is done. Mike did suggest using environment variables to hack around > those limitations, but so far that hasn't turned into any code from > either of us. Hey, that's not a bad idea. You could set an environment variable, then rerun the same program with the same arguments, and your test could sense the environment variable and run the 2nd process's test role. Is there a generic win32 way to run yourself again with the same arguments? If not, it'd probably only take a little tweaking of include/wine/test.h to set one up... - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

Re: Correction to COINIT_MULTITHREADED test
by Paul Vriens 11 Jan '05

11 Jan '05

On Mon, 2005-01-10 at 21:20, Bill Medland wrote: > Bill Medland (billmedland(a)mercuryspeed.com) > Correct testing for multithreaded > (as spotted by Paul Vriens; fix suggested by Robert Shearman) > Hi Bill, it wasn't the check that was way over my head. The thing is, that with this code change we walk a new path in COM_CreateApartment. I don't know what the result is but in CoInitializeEx we do: 545 if (!(apt = COM_CurrentInfo()->apt)) 546 { 547 apt = COM_CreateApartment(dwCoInit); 548 if (!apt) return E_OUTOFMEMORY; 549 } and apparently that leaves us with a E_OUTOFMEMORY all the time. Which means that we will not come to the part: 559 COM_CurrentInfo()->inits++; and that leads to errors as: trace:ole:CoInitializeEx ((nil), 4) trace:ole:COM_CreateApartment thread 0xd is entering the multithreaded apartment trace:ole:CoInitializeEx ((nil), 2) err:ole:CoInitializeEx Attempt to change threading model of this apartment from 0x0 to 0x2 which also shows that the check is wrong. When CoInitializeEx is called with COINIT_DISABLE_OLE1DDE it shouldn't go in. What MSDN also says is: Any combination of values from the COINIT enumeration can be used, except that the COINIT_APARTMENTTHREADED and COINIT_MULTITHREADED flags cannot both be set. So should that be accounted for as well? Cheers, Paul.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel