wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: Advapi32/service.c fix
by Dmitry Timoshkov 17 Dec '04

17 Dec '04

"Ivan Leo Puoti" <puoti(a)inwind.it> wrote: > - if( strcmpiW( lpDatabaseName, SERVICES_ACTIVE_DATABASEW ) == 0 ) > + if( (strcmpiW(lpDatabaseName, SERVICES_ACTIVE_DATABASEW)==0) || (lpDatabaseName[0]==(INT)NULL)) It's much simpler to use either !lpDatabaseName[0] or lpDatabaseName[0] == 0 instead of several levels of casting. -- Dmitry.

1 0

Build problems with GL_VERSION_1_2
by Bill Medland 17 Dec '04

17 Dec '04

(Jason?) Currently (after many weeks without concentrating) wine doesn't build; it fails in dlls/wined3d/drawprim.c line 594 with GL_TEXTURE0 undefined. That's because of the definition of GL_MULTITEXCOORD... in wined3d_private.h for the non-GL_VERSION_1_3 case. I can see a linguistically obvious fix that gets me thorugh the compilation but since I haven't the faintest idea about d3d and GL I don't know if it is correct, so I won't submit it. -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

2 2

Hang in usr1_handler (ptrace issue?)
by Mike Hearn 17 Dec '04

17 Dec '04

Hi, Lately I've been seeing hangs of this form: Backtrace: =>1 0x4df8e7a2 (0x659ffb54) 2 0x5246f507 NTDLL_wait_for_multiple_objects+0x387(count=0x0, handles=0x0, flags=0x8, timeout=0x659ffd10) [/source/wine/dlls/ntdll/sync.c:683] in ntdll (0x659ffcf8) 3 0x5246da88 usr1_handler+0x38(__signal=0xa, __context=0x33) [/source/wine/dlls/ntdll/signal_i386.c:1159] in ntdll (0x659ffd1c) 4 0x100238a8 (0x65bfc6cc) 5 0x5246f507 NTDLL_wait_for_multiple_objects+0x387(count=0x1, handles=0x65bfc8bc, flags=0x4, timeout=0x0) [/source/wine/dlls/ntdll/sync.c:683] in ntdll (0x65bfc870) 6 0x5246f5df NtWaitForMultipleObjects+0x4b(count=0x1, handles=0x65bfc8bc, wait_all=0x0, alertable=0x0, timeout=0x0) [/source/wine/dlls/ntdll/sync.c:713] in ntdll (0x65bfc898) 7 0x1894e4b3 WaitForMultipleObjectsEx+0xa3(count=0x1, handles=0x65bfc9f0, wait_all=0x0, timeout=0xffffffff, alertable=0x0) [/source/wine/dlls/kernel/sync.c:180] in kernel32 (0x65bfc9c8) in other words, whilst waiting on some server object it was suspended. I am running the FC3 kernel "2.6.9-1.681_FC3". Is this what the previously discussed ptrace change would look like? If so I may need to ask Red Hat to do an errata or something. I saw that in 2.6.10-rc3 another ptrace change went in, so it may be that it's now fixed. thanks -mike

4 5

Re: PATCH: dlls/oleaut32/tests/vartype.c
by Robert Shearman 16 Dec '04

16 Dec '04

Marcus Meissner wrote: >Hi, > >This fixes the currently last gcc4 problem. > >I had to split up MSVC / non-MSVC cases since glibc/sprintf >and msvcrt/sprintf disagree on how to print out 64bit integers. > > If you don't use the macro then you can use wine_dbgstr_longlong and not have to worry about compiler differences. Rob

1 0

<<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive
by Robert van Herk 16 Dec '04

16 Dec '04

Hi, I had some problems with my mail server, so I send in this patch again. If the previous one did arrive, please ignore this e-mail. ------------------------------------------------------------------------ Changes: Added functionality to browse for a UNIX folder. This is done by making two new funtions in dlls/shell32/brsfolder.c, namely wine_shell_browse_for_UNIX_directoryA wine_shell_browse_for_UNIX_directoryW These functions are exported in shlobj.h. The original code that allowed just for picking a Windows folder, was split up. It was to be found in brsfolder.c, but I split this in: brsfolder.c brsfolder.h brsfolder_windows.c brsfolder_windows.h brsfolder_unix.c brsfolder_unix.h unixTools.c unixTools.h, Otherwise I found the code to be incomprehendible. Furthermore, winecfg now uses the wine_shell_browse_for_UNIX_directoryA to let the user pick a UNIX directory as root for his virtual drive mappings. Regards, Robert van Herk

8 15

Re: Stubs in PE build
by Jon Griffiths 16 Dec '04

16 Dec '04

Hi, I had a patch which enabled stub generation for building native dlls last year (http://www.winehq.org/hypermail/wine-patches/2003/07/0176.html), that part was not accepted for the same reasons that are being mentioned in this thread. I would like to point out again that the VC linker will not generate a correct dll unless the ordinal stubs are present. Other native linkers may have the same problem. It seems very silly to me that we can't use M$'s own compiler/linker to build valid dlls (especially since these tools can be downloaded for free these days). M$ defined the dll format we are using, after all. If this is intentional, perhaps we should document it somewhere? Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com

3 6

Re: Definition of IMessageFilter in objidl.h
by Dmitry Timoshkov 16 Dec '04

16 Dec '04

"Serge S. Spiridonoff" <sss(a)corbina.net> wrote: > Well, I've just noticed the following record in the ChangeLog... > > * include/objidl.h, include/objidl.idl: > Jake Hamby <jhamby(a)anobject.com> > IMessageFilter::HandleInComingCall() should be HandleIncomingCall(). > > Also, http://cvs.winehq.org/patch.py?id=12310 > > So I'm a bit confused now!? Since I'm new to Wine I'd like someone more > experienced to judge this collision. Apparently the patch above is wrong since microsoft headers have it in different case. The patch should be reverted. If you could send a patch which just reverts the above change that would be great. -- Dmitry.

1 0

dlls/gdi/tests/metafile.c warning about test_mf_PatternBrush
by Gerald Pfeifer 16 Dec '04

16 Dec '04

The following patch to dlls/gdi/tests/metafile.c revision 1.3 date: 2004/12/09 11:37:59; author: julliard; state: Exp; lines: +236 -0 Walt Ogburn <reuben(a)ugcs.caltech.edu> Added some tests for win-format metafiles. introduces the following warning: metafile.c:381: warning: `test_mf_PatternBrush' defined but not used Should we put #ifdefs around the definition, or enable the following code in the main test function? /* Crashes under wine: */ /* test_mf_PatternBrush(); */ Another option would be not to make this function static. Gerald

5 5

Re: Definition of IMessageFilter in objidl.h
by Dmitry Timoshkov 16 Dec '04

16 Dec '04

"Serge S. Spiridonoff" <sss(a)corbina.net> wrote: > IMessageFilter::HandleInComingCall is defined as HandleIncomingCall in > include/wine/windows/objidl.h (.idl) > Note the capital 'C' in 'InComing' in MS headers. > Is it a misprint? Yes. Please send a patch. -- Dmitry.

2 1

Definition of IMessageFilter in objidl.h
by Serge S. Spiridonoff 15 Dec '04

15 Dec '04

Hi, IMessageFilter::HandleInComingCall is defined as HandleIncomingCall in include/wine/windows/objidl.h (.idl) Note the capital 'C' in 'InComing' in MS headers. Is it a misprint? Thanks

1 0

Re: Should we get rid of the wine-license list?
by Ivan Leo Puoti 15 Dec '04

15 Dec '04

> OK, I'll take it down. Shall I remove the archives as well? Or simply > leave them for historical type purposes? IMHO we should keep the archives. Ivan. ____________________________________________________________ Regala e regalati Libero ADSL: 3 mesi gratis, navighi veloce e scarichi a 1.2 Mega. Abbonati subito senza costi di attivazione su http://www.libero.it

1 0

State of the Msi
by Aric Stewart 15 Dec '04

15 Dec '04

Hi all, Long time no post :) I just wanted to give an update that Mike M. and I have done alot of msi work over the first few weeks of December which caused a few significant changes to particularly action.c where we eliminated many of the static buffers for file paths and replaced them with dynamic buffers. Vitaly Lipatov's patchs reminded me that i should probably give you all a heads up about that. We where going to break them down and start submitting them but then Mike went off and got married and is on his Honeymoon. So when he gets back we are going to either break the changes down into smaller patches or try to get Alexandre to approve a big one. I will start trying to get some of the smaller ones broken down and submitted in the meantime. Vitaly Lipatov's patchs do not directly conflict with anything so we are just fine there. I will work them into our tree so that i can be sure they are not lost. But if anyone else is also doing msi work you may want to check in here so that we can make sure it all fits together ok. Thanks, -aric

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by William Lahti 15 Dec '04

15 Dec '04

Upon further review, the patch works. Stupid me. William

1 0

Re: Include file cleanup : dce.h
by Alexandre Julliard 15 Dec '04

15 Dec '04

Rémi Assailly <remi.assailly(a)free.fr> writes: > Changelog: > * get rid of dce.h > --- dlls/x11drv/winpos.c 2004-12-09 19:10:35.000000000 +0100 > +++ dlls/x11drv/winpos.c 2004-12-11 19:46:03.000000000 +0100 > @@ -40,7 +40,6 @@ > #include "x11drv.h" > #include "win.h" > #include "winpos.h" > -#include "dce.h" > #include "cursoricon.h" > #include "nonclient.h" > > @@ -49,6 +48,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(x11drv); > > +extern BOOL DCE_InvalidateDCE( HWND, const RECT* ); The goal of the header files cleanup is not to mechanically remove the #includes by duplicating the definitions, if we wanted to do that it would have been done long ago. The real goal is to get rid of the inter-dll dependencies, the global headers are really just a symptom of the problem. -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: [winelib] Can't figure out a Winemaker error
by Michael Jung 15 Dec '04

15 Dec '04

Scott, On Wednesday 15 December 2004 06:32, Scott Ritchie wrote: > Global symbol "%directories" requires explicit package name > at /usr/bin/winemaker line 423. > Global symbol "%directories" requires explicit package name > at /usr/bin/winemaker line 441. > Execution of /usr/bin/winemaker aborted due to compilation errors. > > What's going on here? Did I screw something up, or was this broken in > that release? This is with the December release. This is a problem, which seems to have been introduced in the december release and which is already fixed in cvs. If you don't want to use cvs you can just patch the winemaker script: Move the "my %directories" global variable declaration (somewhere around line 1060) above the "get_directory_contents" function declaration (ca. line 400). Ciao, Michael

1 0

[winelib] Can't figure out a Winemaker error
by Scott Ritchie 15 Dec '04

15 Dec '04

As part of my effort to create a successful demonstration of how to port something, I tried out winelib. Unfortunately, I can't seem to get it working at all. I get this error whenever I run winemaker: Global symbol "%directories" requires explicit package name at /usr/bin/winemaker line 423. Global symbol "%directories" requires explicit package name at /usr/bin/winemaker line 441. Execution of /usr/bin/winemaker aborted due to compilation errors. What's going on here? Did I screw something up, or was this broken in that release? This is with the December release. Thanks, Scott Ritchie

2 1

Re: PATCH: revive FreeBSD support
by Alexandre Julliard 14 Dec '04

14 Dec '04

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > --- dlls/ntdll/virtual.c 11 Oct 2004 20:59:06 -0000 1.41 > +++ dlls/ntdll/virtual.c 3 Dec 2004 04:06:42 -0000 > @@ -119,6 +119,12 @@ static CRITICAL_SECTION csVirtual = { &c > /* Note: these are Windows limits, you cannot change them. */ > # define ADDRESS_SPACE_LIMIT ((void *)0xc0000000) /* top of the total available address space */ > # define USER_SPACE_LIMIT ((void *)0x80000000) /* top of the user address space */ > +# ifdef __FreeBSD__ > +# define LOW_SPACE_LIMIT ((void *)0x110000) /* lower address space limit */ > +# else > +# define LOW_SPACE_LIMIT NULL > +# endif > + > #else > static UINT page_shift; > static UINT page_mask; > @@ -600,7 +606,7 @@ static NTSTATUS map_view( struct file_vi > > for (;;) > { > - if ((ptr = wine_anon_mmap( NULL, view_size, VIRTUAL_GetUnixProt(vprot), 0 )) == (void *)-1) > + if ((ptr = wine_anon_mmap( LOW_SPACE_LIMIT, view_size, VIRTUAL_GetUnixProt(vprot), 0 )) == (void *)-1) Looks OK, but this is a job for wine_anon_mmap, it's supposed to abstract these sorts of platform dependencies so that the callers don't have to worry about it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Includes: x11drv
by Rémi Assailly 14 Dec '04

14 Dec '04

Jon Griffiths wrote : >Hi, > >x11drv: 8 includes removed. > >Cheers, >Jon > > +dlls/x11drv/text.c dlls/x11drv/window.c dlls/x11drv/winpos.c > dlls/x11drv/x11ddraw.c > Remove uneeded headers to reduce uneeded rebuilds. > > Hi Jon, As I am working on x11drv I can tell you some things : win.h is declared in x11drv.h so if you want to remove it, remove it from all files. But I think it is not a good idea : win.h is one of the header files which need to be moved so I think it is better to keep #include "win.h" where it is needed. It will be easier to find files which need definitions in win.h. For example you removed win.h from window.c which use the structure WND. I also noticed that you removed wingdi.h from x11ddraw.c. wingdi.h is declared in gdi.h which is a header file which need to be moved too ! So when we get rid of gdi.h we'll must redeclare wingdi.h in x11ddraw.c Regards Rémi

1 0

Re: Stubs in PE build
by Alexandre Julliard 14 Dec '04

14 Dec '04

Ge van Geldorp <gvg(a)reactos.com> writes: > Send for review to wine-devel: http://www.winehq.org/hypermail/wine-devel/2004/11/0658.html (no comments) > Submitted to wine-patch: http://www.winehq.org/hypermail/wine-patches/2004/11/0327.html > Resubmitting against current CVS > > Changelog: > Ge van Geldorp <gvg(a)reactos.com> > - Generate and export stubs specified in .spec files for PE builds I don't think we want to add a special mode just for stubs; they should really be replaced by proper functions (even if the functions are stubs themselves, at least they can print the parameters and try to return something meaningful instead of killing the app). You can view the lack of stubs support on PE as an encouragement to help us remove them from the spec files ;-) -- Alexandre Julliard julliard(a)winehq.org

7 13

Re: [AppDB] Remove borders=0 from img
by tony_lambregts＠telusplanet.net 14 Dec '04

14 Dec '04

Paul van Schayck wrote: > Ok, since we have img{border: 0;} in our stylesheet we can now remove > border=0 from all img elements. > > Changelog: > Remove border=0 from img tags > > A patch would be nice.. ;-) -- Tony Lambregts

1 0

"Debugging" a password dialog
by David Gümbel 14 Dec '04

14 Dec '04

Hi everybody, I am trying to get an application to run under Wine that requires a login with a username and a password. The program runs all fine, however I can't login with data that should work (and AFAIK works under Windows). Having entered the password, in the corresponding part of the dialog I only see "*****" (which is correct). However, when I change focus to some other part of that dialog afterwards, the password field shows "*************" (way more asterisks than before). The previous (i.e. correct) length of ****s is restored when setting the focus back onto the password field. I have reason to believe that the password I entered is not correctly passed on to the login procedure of the program. However, I am sort of badly lacking a nice idea how to efficiently debug this thingy and verify (falsify ;) that I'm right. So, does anybody have an idea? Bye, David

5 7

wineprefixcreate and config file
by Raul Dias 14 Dec '04

14 Dec '04

Hi, Shouldn't tools/wineprefixcreate copy a sample config file? Right now it does all the job to create a standalone wine environment, but with no config. I would suggest copying documentation/samples/config to tools/config, installing it at $(SRCDIR) and them just copying it during wineprefixcreate call. I can do that if no one disagrees with the change. Some rpms in the sourceforge does not even have the sample config file in it. -- Raul Dias

2 1

Dodgy NetBSD code in dlls/kernel/cpu.c?
by Jon Griffiths 14 Dec '04

14 Dec '04

Hi, in dlls/kernel/cpu.c, around line 430, is the following code for NetBSD: { int mib[2]; int value[2]; ... if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) if (value) PF[PF_FLOATING_POINT_EMULATED] = FALSE; else PF[PF_FLOATING_POINT_EMULATED] = TRUE; This looks dodgy, the "if (value)" test will always be true. I gather it should be "if (value[0])" or "if (value)[1]", but I'm no NetBSD guru. Also, there should be not need to set values to FALSE, since the flag array is cleared to 0 at the start of this function. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Visual studio 6 build fix.
by Rein Klazes 14 Dec '04

14 Dec '04

Hi, MS Visual C++ v6, when invoking the compiler and other build tools does the following: create anonymous pipe; duplicate the pipes write handle; open's the file NUL calls CreateProcess starting vcspawn.exe with: startup info iohandles set to the 3 handles obtained above; the startup info flag STARTF_USESTDHANDLES set; create flag CREATE_NEW_CONSOLE set. the parent process reads from the pipe, and analyses the compiler and other messages that are obtained that way. Wine's console startup code is not really expecting this and insists on creating new stdio handles instead of inheriting them. The attached patch makes this work properly. Changelog: server : process.c dlls/kernel : console.c A starting process must obey the STARTF_USESTDHANDLES flag, even it is starting a new console. Rein. -- Rein Klazes rklazes(a)xs4all.nl

3 5

Re: Perform automatic bitmap font configuration based on the current locale
by Huw D M Davies 14 Dec '04

14 Dec '04

On Mon, Dec 13, 2004 at 11:39:58PM +0800, Dmitry Timoshkov wrote: > Hello, > > due to a GDI bug new values don't actually work, and that's another > thing I'm going to look at. > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Perform automatic bitmap font configuration based on the current locale. > > diff -up cvs/hq/wine/dlls/kernel/locale.c wine/dlls/kernel/locale.c > --- cvs/hq/wine/dlls/kernel/locale.c 2004-11-22 17:52:19.000000000 +0800 > +++ wine/dlls/kernel/locale.c 2004-12-13 23:25:50.000000000 +0800 > @@ -5,6 +5,7 @@ > * Copyright 1998 David Lee Lambert > * Copyright 2000 Julio C?sar G?zquez > * Copyright 2002 Alexandre Julliard for CodeWeavers > + * Copyright 2003, 2004 Dmitry Timoshkov > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -226,25 +227,175 @@ inline static HKEY create_registry_key(v > { > static const WCHAR intlW[] = {'C','o','n','t','r','o','l',' ','P','a','n','e','l','\\', > 'I','n','t','e','r','n','a','t','i','o','n','a','l',0}; > - OBJECT_ATTRIBUTES attr; > - UNICODE_STRING nameW; > HKEY hkey; > > if (RtlOpenCurrentUser( KEY_ALL_ACCESS, &hkey ) != STATUS_SUCCESS) return 0; > > - attr.Length = sizeof(attr); > - attr.RootDirectory = hkey; > - attr.ObjectName = &nameW; > - attr.Attributes = 0; > - attr.SecurityDescriptor = NULL; > - attr.SecurityQualityOfService = NULL; > - RtlInitUnicodeString( &nameW, intlW ); > + return NLS_RegOpenSubKey( hkey, intlW ); > +} > > - if (NtCreateKey( &hkey, KEY_ALL_ACCESS, &attr, 0, NULL, 0, NULL ) != STATUS_SUCCESS) hkey = 0; > - NtClose( attr.RootDirectory ); > - return hkey; > +/*********************************************************************** > + * create_fonts_registry_key > + * > + * Create the HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion\\Fonts > + * registry subkey. > + */ > +inline static HKEY create_fonts_registry_key(void) > +{ > + static const WCHAR fontsW[] = { > + 'M','a','c','h','i','n','e','\\','S','o','f','t','w','a','r','e','\\', > + 'M','i','c','r','o','s','o','f','t','\\','W','i','n','d','o','w','s',' ','N','T','\\', > + 'C','u','r','r','e','n','t','V','e','r','s','i','o','n','\\', > + 'F','o','n','t','s',0}; > + > + return NLS_RegOpenKey( 0, fontsW ); > } You should probably put them under HKLM\Software\Microsoft\Windows\CurrentVersion\Fonts too. (Or at least use this key for winver=win9x, since this is where we'll look if running in win9x mode). Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel