wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: VERSION_GetLinkedDllVersion bug fix
by Ivan Leo Puoti 14 Dec '04

14 Dec '04

>I just tried Ivan's patch on my program, and get the same insufficient >version >error that I was getting with the original, unpatched, version. My >original patch did not have this problem. Why don't you add a few traces to see what's going on? I've already explained that your orginal patch is wrong. Also check the versions of the dlls that the function is calling, and the winver setting. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by William Lahti 14 Dec '04

14 Dec '04

I just tried Ivan's patch on my program, and get the same insufficient version error that I was getting with the original, unpatched, version. My original patch did not have this problem. William

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by Ivan Leo Puoti 13 Dec '04

13 Dec '04

> It was 4. Pehaps there is yet another bug someplace else. That's why in my updated patch I check the OS using the available info. It's here, you may want to try it out and check if it works for you app http://www.winehq.com/hypermail/wine-patches/2004/12/att-0275/01-wkivcf2.di… You patch was wrong because the fact that MajorSubsystemVersion is 4 and MinorOperatingSystemVersion is 0 doesn't mean the OS is win2k, it could be nt4 or win95, and returning win2000 when winver is set to win95 could cause problems. See http://msdn.microsoft.com/library/default.asp?url=/library/en-us/sysinfo/ba… Also it's better to use switch when comparing a variable to multiple values, it's more readable, and you added some useless braces. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

wine loader bug
by Ivan Leo Puoti 13 Dec '04

13 Dec '04

I've got this strange error wine-pthread: virtual.c:703: map_file_into_view: Assertion `start + size <= view->size' failed. Aborted the wine loader seems unable to load the binary into memory, I tried commenting out the code between line 701 and 719 with #if 0, but that just caused a few compiler warnings and a segfault. I think I'll leave this to someone more skilled than me, if you want the binary that causes this drop me a line (And no I am not posting it to the list) Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by William Lahti 13 Dec '04

13 Dec '04

I actually test-ran my version of the patch with VB .NET's installer, which requires 2K or higher, where the other version was only compile-tested. It fixed the problem of the installer saying that I needed WIN2K or higher. I had actually tried exactly what Andreas Mohr had before coming up with the version I submitted, and it didn't work. My config file was set to emulate XP, so I echoed what MajorSubsystemVersion was. It was 4. Pehaps there is yet another bug someplace else. William Lahti

1 0

appdb bug
by Ivan Leo Puoti 13 Dec '04

13 Dec '04

I can view the maintainers queue, and I can click on view, but I'm just redirected to the queue again and can't approve maintainers. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Re: A new systray patch
by Steven Edwards 13 Dec '04

13 Dec '04

Hi, --- Mike Hearn <mh(a)codeweavers.com> wrote: > - Add a wineshell process to stand in for Explorer > - Rewrite system tray code to be standards compliant Maybe we should just go ahead and call it explorer in case you plan on adding stuff later on or adapting parts of ReactOS explorer. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - Easier than ever with enhanced search. Learn more. http://info.mail.yahoo.com/mail_250

5 10

Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total Annihilation
by Jonathan Gevaryahu 13 Dec '04

13 Dec '04

The CVS commit on 12/02 at 18:05:37 UTC causes the game "Total Annihilation" to cease functioning. Previously the game worked (although sounds don't work due to a seperate directsound issue), but since the aformentioned commit, the game changes resolution but does not ever display its titlescreen (it isn't invisible either, clicking where the exit button would be has no effect), and cpu usage is maxed out, suggesting an infinite loop. I did a trace using WINEDEBUG="err+all,warn+all,fixme+all,trace+ntdll,trace+kernel,trace+server" and got the following, repeated over and over with some small variation: ... 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102866572.849273 (+0.002667) , handles={0x10c} ) 000d: select() = PENDING 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 000a: event_op( handle=0xc0, op=1 ) 000a: event_op() = 0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102866572.859131 (+0.005230) , handles={0x10c} ) 000d: select() = PENDING 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 ... This was tested on both normal and modified (no-CD crack) versions of total annihilation, and no difference in behavior was noted. Here is the information about the commit in question: CVS Commit 12/02 18:05:37 message: Eric Pouech <pouech-eric(a)wanadoo.fr> - moved event, semaphore, mutex implementation from kernel32 to ntdll - added mutant implementation in ntdll, and use it for mutex implementation in kernel32 - added access parameter on event, semaphore, timer creation in wineserver (as ntdll interface requires it) - added missing definitions in include/winternl.h Files modified by commit: dlls/kernel/sync.c dlls/ntdll/ntdll.spec dlls/ntdll/sync.c include/winternl.h include/wine/server_protocol.h server/event.c server/mutex.c server/protocol.def server/semaphore.c server/timer.c server/trace.c Jonathan Gevaryahu lord_nightmare(a)users.sf.net

3 5

Wine test suite (or winrash, don't know which one) - possible way to improve for some persons (with some antivirus or firewall software running)
by Tero Tamminen 13 Dec '04

13 Dec '04

Hi! I don't know if this is proper list to send this (well, I didn't find any mailinglist for the Wine test suite app and mailinglist in sf project for winrash was empty). So I thought that information would possibly reach developers of Wine test suite or winrash through this mailinglist. And as I said in the subject, I don't know if this message concerns wine test suite or winrash program or both. Because of that, I use winrash from now on, because it is much shorter to write. I have this winrash running on one of my computers, in windows 2003 server. There is a firewall program (ZoneAlarm Pro) installed to this computer. Some time ago, I upgraded Zonealarm to new version (5.5.062.004). This version has a feature, that checks if some programs are trying to execute new programs or something. It is possible to allow execution of new programs permanently (it saves directory and name of executable), but not in case of winrash. Winrahs starts its tests every time in temporary directory with new name. So every time a test starts, Zonealarm asks me if the execution of test is allowed. This is a problem for me, because it is annoying to click through all the messages, but it is also a problem for winrash, because I am not sitting in front of this computer very often and some tests might timeout because of that (and I think it has happened a couple of times already). So would it be possible to start all the tests from same directory (I mean, every version of the tests would start in same directory). It would save me some time because I wouldn't have to click through all the messages. Thanks! Tero Tamminen

4 9

Re: [AppDB] php config
by Jonathan Ernst 13 Dec '04

13 Dec '04

I forgot to mention that it should be checked if the used config.php file is using short tags (<?) if it is, it has to be replaced with longtags (<?php). thanks, -- Jonathan Ernst <Jonathan(a)ErnstFamily.ch>

2 1

Re: VERSION_GetLinkedDllVersion bug fix
by Andreas Mohr 13 Dec '04

13 Dec '04

On Mon, Dec 13, 2004 at 03:09:29PM +0100, Ivan Leo Puoti wrote: > > I fixed a bug in ntdll's VERSION_GetLinkedDllVersion which caused it to > > not be able to return any Windows version higher than WIN98. It has now been > > extended for WIN2K, WINXP, and WIN2K3. This function would eventually be > > called any time that kernel's GetVersionEx was called, which is a problem > > for any software requiring a version higher than WIN98, like Visual Basic > > .NET. > If MajorSubsystemVersion is 4 then the OS can never be win2k or higher, so your > patch can't be correct. > The attached patch should fix the bug you found. Compile tested only. Where's the FIXME message for the default case? ;) (things like this are the prime reason this version issue wasn't uncovered for such a long time!) Andreas Mohr

1 0

(LPVOID) NULL: unnecessary cast?
by Francois Gouget 13 Dec '04

13 Dec '04

I have noticed a lot of constructs of the form: HRESULT WINAPI DMUSIC_CreateDirectMusicScriptImpl (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) { IDirectMusicScriptImpl* obj; obj = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectMusicScriptImpl)); if (NULL == obj) { *ppobj = (LPVOID) NULL; return E_OUTOFMEMORY; } What's the point of casting NULL to (LPVOID)? Isn't it already a void* anyway? Is it to fix a warning issued by ultra-recent gcc versions? (gcc 3.4.2 does not complain here) Similarly there are a lot of casts like this: *ppobj = (LPVOID)&This->UnknownVtbl; Again I thought any kind of pointer could be assigned to a void* pointer so is this cast really necessary? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ It really galls me that most of the computer power in the world is wasted on screen savers. Chris Caldwell from the GIMPS project http://www.mersenne.org/prime.htm

2 1

Re: Includes [4] shlwapi
by Juan Lang 13 Dec '04

13 Dec '04

Jon, are you sure about removing the winnls.h includes? This patch looks suspect: > diff -ur wine/dlls/shlwapi/url.c wine-develop/dlls/shlwapi/url.c > --- wine/dlls/shlwapi/url.c 2004-12-03 23:27:08.000000000 -0500 > +++ wine-develop/dlls/shlwapi/url.c 2004-12-06 15:42:34.000000000 -0500 > @@ -25,8 +25,6 @@ > #include <stdlib.h> > #include "windef.h" > #include "winbase.h" > -#include "winnls.h" > -#include "winerror.h" > #include "wine/unicode.h" > #include "wininet.h" > #include "winreg.h" > @@ -1416,7 +1414,7 @@ > * return the same digests for the same URL. > */ > WideCharToMultiByte(0, 0, pszUrl, -1, szUrl, MAX_PATH, 0, 0); > - HashData((PBYTE)szUrl, (int)strlen(szUrl), lpDest, nDestLen); > + HashData((const BYTE*)szUrl, (int)strlen(szUrl), lpDest, nDestLen); > return S_OK; > } winnls.h declares WideCharToMultiByte, and we just saw a compilation error on some systems because it was missing [1]. I haven't checked others, but this caught my eye. [1] http://www.winehq.org/hypermail/wine-cvs/2004/12/0091.html --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - Find what you need with new enhanced search. http://info.mail.yahoo.com/mail_250

3 9

Re: winsock:WS_setsockopt
by Rein Klazes 13 Dec '04

13 Dec '04

On Sun, 12 Dec 2004 12:42:55 +0200, you wrote: > It's a little bit...embracing :-) > > But the program is "Lanwatch". A nice little app, which makes a lot of > noise (if configured correctly) when the Internet connection goes down. > I used it for years, but now we've got rid of the last Windows here.... > > I have other network monitoring tools, but it's just the acoustical > waring, for which I used it...I'll just attach it to the mail, OK? > > It would be great, if there could be a fix for this....Also I contacted > the writer of the little app, but didn't got a answer... > > I think, that it just tries to open a socket (with correct or wrong > parameters), and than gets a back a error and reports (wrongly) that the > Internet connection is down...It might be easy to fix (or hack > workaround) for it, just if you can lead me to the solution? | fixme:winsock:convert_sockopt Unimplemented or unknown socket level | err:winsock:WS_setsockopt Invalid level (65407) or optname (128) | fixme:mpr:WNetGetUniversalNameA ("K:\\", 0x00000001, 0x779cf98c, 0x779cfd98): stub | fixme:winsock:convert_sockopt Unimplemented or unknown socket level | err:winsock:WS_setsockopt Invalid level (65407) or optname (128) | fixme:winsock:convert_sockopt Unknown SOL_SOCKET optname 0xff7f | err:winsock:WS_setsockopt Invalid level (1) or optname (65407) The same output as Space Empires 4. The unknown optname 65407 or 0xff7f, is suspiciously looking like the option SO_DONT_LINGER, 0xffffff7f, with the high bits chopped off. Both these calls fail under Windows (win2K). It is a good idea to ask the programmer, to see what he is trying to accomplish here. Also note that these errors may not be fatal at all if the program is just ignoring them. Letting the program going through I see a fair bit of data exchange, so communications seems to work, at least partly. Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 2

Re: Re: Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total Annihilation
by Jonathan Gevaryahu 13 Dec '04

13 Dec '04

On Sunday 12 December 2004 02:54 pm, Eric Pouech wrote: > Jonathan Gevaryahu a écrit : > does this help? > A+ > > Index: sync.c > =================================================================== > RCS file: /home/cvs/cvsroot/wine/wine/dlls/kernel/sync.c,v > retrieving revision 1.64 > diff -u -u -r1.64 sync.c > --- sync.c 7 Dec 2004 14:23:03 -0000 1.64 > +++ sync.c 12 Dec 2004 19:53:14 -0000 > @@ -893,7 +893,7 @@ > OBJECT_ATTRIBUTES attr; > NTSTATUS status; > > - if (!is_version_nt()) access = SEMAPHORE_ALL_ACCESS; > + if (!is_version_nt()) access = TIMER_ALL_ACCESS; > > attr.Length = sizeof(attr); > attr.RootDirectory = 0; Unfortunately, your patch doesn't fix the problem. But I noticed something disturbing: in CVS (without your patch) occasionally Total Annihilation will run fine (it did ONCE), but almost all of the time it will not work, and give the previously mentioned trace result. Sometimes, it will give a different trace result: ... 000d: select() = PENDING warn:file:wine_nt_to_unix_file_name L"units\\CORDEV1.OVR" not found in /home/jon athan/.wine/dosdevices/g:/cavedog/totala/units warn:ntdll:NtCreateFile L"\\??\\G:\\cavedog\\totala\\units\\CORDEV1.OVR" not fou nd (c000003a) warn:file:CreateFileW Unable to create file L"units\\CORDEV1.OVR" (status c00000 3a) trace:ntdll:NtCreateFile handle=0x4087f7a4 access=80000000 name=L"\\??\\G:\\cave dog\\totala\\units-english\\CORDOOM.FBI" objattr=00000042 root=(nil) sec=(nil) i o=0x4087f7a8 alloc_size=(nil) attr=00000080 sharing=00000003 disp=1 options=00000050 ea=(nil).0x00000000 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.834956 (+0.003836) , handles={0x110} ) 000d: select() = PENDING warn:file:wine_nt_to_unix_file_name L"units-english\\CORDOOM.FBI" not found in / home/jonathan/.wine/dosdevices/g:/cavedog/totala warn:ntdll:NtCreateFile L"\\??\\G:\\cavedog\\totala\\units-english\\CORDOOM.FBI" not found (c000003a) warn:file:CreateFileW Unable to create file L"units-english\\CORDOOM.FBI" (statu s c000003a) trace:ntdll:NtCreateFile handle=0x4087f7c8 access=80000000 name=L"\\??\\G:\\cave dog\\totala\\units\\CORDOOM.FBI" objattr=00000042 root=(nil) sec=(nil) io=0x4087 f7cc alloc_size=(nil) attr=00000080 sharing=00000003 disp=1 options=00000050 ea=(nil).0x00000000 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.844670 (+0.005838) , handles={0x110} ) 000d: select() = PENDING warn:file:wine_nt_to_unix_file_name L"units\\CORDOOM.FBI" not found in /home/jon athan/.wine/dosdevices/g:/cavedog/totala/units warn:ntdll:NtCreateFile L"\\??\\G:\\cavedog\\totala\\units\\CORDOOM.FBI" not fou nd (c000003a) 000a: event_op( handle=0xc0, op=1 ) 000a: event_op() = 0 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.854135 (+0.007851) , handles={0x110} ) 000d: select() = PENDING warn:file:CreateFileW Unable to create file L"units\\CORDOOM.FBI" (status c00000 3a) 0009: get_handle_fd( handle=0xec, access=00000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } trace:ntdll:NtReadFile (0xec,(nil),(nil),(nil),0x4087f80c,0x44404668,0x00000200, (nil),(nil)),partial stub! 0009: get_handle_fd( handle=0xec, access=80000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.864331 (+0.009845) , handles={0x110} ) 000d: select() = PENDING trace:ntdll:NtReadFile = 0x00000000 0009: get_handle_fd( handle=0xec, access=00000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } trace:ntdll:NtReadFile (0xec,(nil),(nil),(nil),0x4087f414,0x4506cf40,0x00000200, (nil),(nil)),partial stub! 0009: get_handle_fd( handle=0xec, access=80000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } trace:ntdll:NtReadFile = 0x00000000 trace:ntdll:NtReadFile (0xec,(nil),(nil),(nil),0x4087f404,0x44404668,0x00000200, (nil),(nil)),partial stub! ... And that trace means that it was actually working. If I hadn't Control-C terminated that trace, it would have run the game. Jonathan Gevaryahu lord_nightmare(a)users.sf.net

1 0

Baldur's Gate 2 randomly crashes ("Runtime error") with Wine-20041201
by Michal Kepien 12 Dec '04

12 Dec '04

Hi there, I've recently compiled Wine-20041201 and I'm trying to get Baldur's Gate II running. The installation sequence is fine, so is the main menu, character creation etc. The problem is, once inside the actual game, the application randomly crashes giving me: Runtime error c:\bg2\BGMain.exe abnormal program termination This happens often enough to render the gameplay quite unnerving. Especially when it happens 15 minutes after the last quicksave ;-) I haven't found out what makes the game crash. I'm quite sure it isn't a sound problem - I've turned sound off both in ~/.wine/config and in BGConfig.exe - not better at all. The only clue I've got is the message which appears in the system console after the game quits: err:ntdll:RtlpWaitForCriticalSection section 0x40689020 "?" wait timed out in thread 000f, blocked by 0009, retrying (60 sec) Whatever it means ;-) The same thing happened in Wine-20041019. I'd be grateful for any clues as right now I'm quite fed up with restarting the game every 3 minutes (or even worse). If you need any more debug messages, just ask. System specification: Toshiba Satellite Pro 4270 - Celeron 500, Savage/IX (8 MB), Yamaha sound card, 320 MB RAM. Slackware 10.0, kernel 2.4.27. X.org - 6.8.1.99 (CVS), CVS Savage driver. ALSA sound driver, using OSS emulation. Window manager: Fluxbox v0.9.10. Thanks in advance for any support, Michal Kepien

1 0

Re: winsock:WS_setsockopt
by Dan Kegel 12 Dec '04

12 Dec '04

You wrote: >>... the program is "Lanwatch". A nice little app, which makes a lot of >>noise (if configured correctly) when the Internet connection goes down. >>I used it for years, but now we've got rid of the last Windows here.... >> >>I have other network monitoring tools, but it's just the acoustical >>waring, for which I used it...I'll just attach it to the mail, OK? Do you have a URL for lanwatch, or a few more details that would let us identify it (e.g. vendor name, version number)? (There may be several programs by that name.) Is there a free demo download? - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

[AppDB] login problem
by Jonathan Ernst 12 Dec '04

12 Dec '04

Hi guys, It's nearly 2 o'clock and I have to wake up early "tomorrow". I made a very big patch that cleans up a lot of code (thousands of tabs, bad indentation, etc. and follows the CODING_STANDARD we wrote together. Of course I didn't had time to clean up every single line of code (I didn't wanted to use any automated mean to do the cleanup to avoid problems). As for the login problem I re-read most of the code and I runned it with all compatibility options turned off and all warnigns turned on and it works very well on my local system. I think there is still one $current occurence somewhere but the problem doesn't come from here. As for the online version that doesn't work, I think that first thing would be to put a test page on the server with phpinfo() in it to know exactly what version of php and what options we are using. Then we have to understand why in function cmd_do_login() of file account.php we have something like: if($result == null) { $_SESSION['current'] = $user; addmsg("You are successfully logged in as '$user->username'.", "green"); redirect(apidb_fullurl("index.php")); } else { retry("login","Login failed ($result)"); $_SESSION['current'] = ""; } And when providing a wrong password we get the error message and when providing a good password we get no message at all ! The reason why it's buggy online and works locally using the latest cvs versions is still to be found... Finally there are still some register_globals to clean up and when we are done we can turn off the following options in php.ini: short_open_tag = Off session.bug_compat_42 = 0 register_globals = Off register_long_arrays = Off P.S. I send a copy to wine-devel in case someone finds out the solution before us.

2 3

Re: ntdll / kernel32: #52
by Robert Shearman 12 Dec '04

12 Dec '04

Eric Pouech wrote: > Moving atom implementation to: > - dlls/kernel32/atom16.c for the 16 bit part > - dlls/ntdll/ntdll.c for the 32 bit part > > A+ > >------------------------------------------------------------------------ > >Name: ntkrnl_52 >ChangeLog: > - moved 16 bit atom support in (16bit) dlls/kernel/atom16.c > - added atom support to NTDLL > - made 32 bit atom support in kernel32 call ntdll's brand new one > - copied the atom tests for global atom so that we can test local atoms too >License: X11 >GenDate: 2004/12/11 12:59:19 UTC >ModifiedFiles: dlls/kernel/Makefile.in dlls/kernel/atom.c dlls/kernel/tests/atom.c dlls/ntdll/Makefile.in dlls/ntdll/ntdll.spec include/winternl.h server/protocol.def server/atom.c >AddedFiles: dlls/kernel/atom16.c dlls/ntdll/atom.c > > ... >--- /dev/null 1970-01-01 01:00:00.000000000 +0100 >+++ dlls/ntdll/atom.c 2004-12-04 15:31:03.000000000 +0100 >@@ -0,0 +1,331 @@ >+/* >+ * Atom table functions >+ * >+ * Copyright 1993, 1994, 1995 Alexandre Julliard >+ * Copyright 2004 Eric Pouech >+ * >+ * This library is free software; you can redistribute it and/or >+ * modify it under the terms of the GNU Lesser General Public >+ * License as published by the Free Software Foundation; either >+ * version 2.1 of the License, or (at your option) any later version. >+ * >+ * This library is distributed in the hope that it will be useful, >+ * but WITHOUT ANY WARRANTY; without even the implied warranty of >+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >+ * Lesser General Public License for more details. >+ * >+ * You should have received a copy of the GNU Lesser General Public >+ * License along with this library; if not, write to the Free Software >+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA >+ */ >+ >+#include "config.h" >+#include "wine/port.h" >+ >+#include <stdlib.h> >+#include <stdarg.h> >+#include <stdio.h> >+#include <string.h> >+#include <ctype.h> >+ >+#include "windef.h" >+#include "winbase.h" >+#include "ntstatus.h" >+ >+#include "wine/server.h" >+#include "wine/unicode.h" >+ >+#include "wine/debug.h" >+ >+WINE_DEFAULT_DEBUG_CHANNEL(atom); >+ >+#define DEFAULT_ATOMTABLE_SIZE 37 >+#define MAX_ATOM_LEN 255 >+ >+/****************************************************************** >+ * is_integral_atom >+ * Returns STATUS_SUCCESS if integral atom and 'pAtom' is filled >+ * STATUS_INVALID_PARAMETER if 'atomstr' is too long >+ * STATUS_MORE_ENTRIES otherwise >+ */ >+static NTSTATUS is_integral_atom( LPCWSTR atomstr, ATOM* pAtom ) >+{ >+ ATOM atom; >+ >+ if (HIWORD( atomstr )) >+ { >+ const WCHAR* ptr = atomstr; >+ if (*ptr++ == '#') >+ { >+ atom = 0; >+ while (*ptr >= '0' && *ptr <= '9') >+ { >+ atom = atom * 10 + *ptr++ - '0'; >+ } >+ if (ptr > atomstr + 1 && !*ptr) goto done; >+ } >+ if (strlenW( atomstr ) > MAX_ATOM_LEN) return STATUS_INVALID_PARAMETER; >+ return STATUS_MORE_ENTRIES; >+ } >+ else atom = LOWORD( atomstr ); >+done: >+ if (atom >= MAXINTATOM) return STATUS_INVALID_PARAMETER; >+ *pAtom = atom; >+ return STATUS_SUCCESS; >+} >+ >+/****************************************************************** >+ * RtlDeleteAtomFromAtomTable (NTDLL.@) >+ */ >+NTSTATUS WINAPI RtlDeleteAtomFromAtomTable( void* table, ATOM atom ) >+{ >+ NTSTATUS status; >+ >+ TRACE( "%p %x\n", table, atom ); >+ SERVER_START_REQ( delete_atom ) >+ { >+ req->atom = atom; >+ req->table = table; >+ status = wine_server_call( req ); >+ } >+ SERVER_END_REQ; >+ return status; >+} > > Rtl* functions should generally avoid doing server calls. You should implement the Rtl* functions on top of the Nt* functions, not the other way around. ... >+/****************************************************************** >+ * NtDeleteAtom (NTDLL.@) >+ */ >+NTSTATUS WINAPI NtDeleteAtom(ATOM atom) >+{ >+ return RtlDeleteAtomFromAtomTable( GLOBAL_ATOM_TABLE, atom ); >+} > > Rob

3 5

winsock:WS_setsockopt
by MediaHost (TM) 12 Dec '04

12 Dec '04

Hi Wine-Devel, Is here anybody which knows what the following function is supposed to do and what needs to get implemented? I'm referring to this: fixme:winsock:convert_sockopt Unimplemented or unknown socket level err:winsock:WS_setsockopt Invalid level (65407) or optname (128) Many thanks.... -- Regards Signer: Eddy Nigg Company: StartCom Linux at www.startcom.org <http://www.startcom.org/> MediaHost^(TM) at www.mediahost.org <http://www.mediahost.org/> Skype: startcom <callto://startcom/>

2 1

Re: msacm: pcm compatibility patch
by Christian Costa 11 Dec '04

11 Dec '04

Hi Robert, Robert Reif wrote: > Makes the PCM conversion routines of msacm produce identical results > to the native dll. > Allow any PCM to PCM conversion, not just advertised ones. > > The algorithms used by Microsoft in this dll are very crude and > produce an output of much poorer quality than what is currently > in wine. This is unfortunate but unavoidable if we are to be compatible. I don't see how improving the quality of the conversion could cause problems. Is there an app out there that refuses to run or crashes because of that? The algorithms may have slightly changed across all versions of this dll. And if we can do better job than Microsoft, I think we should do it. > > I have a test program that was used to verify compatibility and can > make it available by request. I hope to integrate some of it into > the regression tests someday. > Bye, Christian

4 4

BeginPaint not called on WM_PAINT
by James Hawkins 11 Dec '04

11 Dec '04

I'm trying to get a program running called BZEdit. Under the latest cvs, the program shows a scrambled mess over the whole screen (I think that is a result of this patch http://cvs.winehq.org/patch.py?id=14725), but when I went back in time to 2004-10-12, the only part of the screen I cant see is the part of the screen where the map you're editing is shown. See http://www.artemisgames.com/BZEdit/ for screenshots. This is the error output I'm getting. err:msg:DispatchMessageA BeginPaint not called on WM_PAINT for hwnd 0x1002a! This message happens every time the editor needs a repaint like when it gets covered by another window. Any ideas about what's going on here? -- James Hawkins

4 7

Re: include file cleanup : another step
by Robert Shearman 11 Dec '04

11 Dec '04

Rémi Assailly wrote: > I moved some defines, ttydrv will not use gdi.h any longer. > I notice that some headers are declared twice, I removed useless > declarations. > > Changelog: > * moved some defines from gdi.h > >------------------------------------------------------------------------ > >--- dlls/gdi/palette.c~ 2004-10-18 23:18:58.000000000 +0200 >+++ dlls/gdi/palette.c 2004-12-09 14:14:52.000000000 +0100 >@@ -37,6 +37,11 @@ > #include "wine/debug.h" > #include "winerror.h" > >+/* palette object */ >+#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >+ >+#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ >+ > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > static INT PALETTE_GetObject( HGDIOBJ handle, void *obj, INT count, LPVOID buffer ); > >--- include/gdi.h~ 2004-03-04 21:41:13.000000000 +0100 >+++ include/gdi.h 2004-12-09 19:01:20.154559672 +0100 >@@ -83,14 +83,6 @@ > SEGPTR segptr_bits; /* segptr to DIB bits */ > } BITMAPOBJ; > >-/* palette object */ >- >-#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >- >-#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ >-#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ >-#define PC_SYS_MAPPED 0x10 /* logical palentry is a direct alias for system palentry */ >- > typedef struct tagPALETTEOBJ > { > GDIOBJHDR header; > >--- dlls/ttydrv/palette.c~ 2004-12-09 18:57:42.835597176 +0100 >+++ dlls/ttydrv/palette.c 2004-12-09 14:27:48.000000000 +0100 >@@ -22,10 +22,14 @@ > > #include <stdlib.h> > >-#include "gdi.h" >-#include "winbase.h" > #include "ttydrv.h" > #include "wine/debug.h" >+#include "wine/wingdi16.h" >+ >+/* palette object */ >+#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >+ >+#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > > WINE_DEFAULT_DEBUG_CHANNEL(ttydrv); > >--- dlls/x11drv/palette.c~ 2004-12-01 12:32:11.000000000 +0100 >+++ dlls/x11drv/palette.c 2004-12-09 19:03:03.933782832 +0100 >@@ -24,11 +24,16 @@ > #include <string.h> > > #include "gdi.h" >-#include "windef.h" > #include "winreg.h" > #include "x11drv.h" > #include "wine/debug.h" > >+/* palette object */ >+#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >+ >+#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ >+#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ >+ > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > /* Palette indexed mode: > > Nice try, but I don't think we want three copies of the same defines. That's just asking for trouble with them getting out of sync. Rob

2 1

questionable code
by Eric Pouech 11 Dec '04

11 Dec '04

still toying with various compilers, here's two new questions (to whom it may concern): **** dlls/gdi/freetype.c line 1467 the test for "(offset < 0)" is always false. I'm not sure changing it into "offset == -1" is the right solution. *** dlls/ole32/hglobalstream.c line 602 the test "if (newPosition.QuadPart < 0)" is always false as QuadPart is unsigned A+

2 2

Re: [AppDB] TODO patch
by tony_lambregts＠telusplanet.net 11 Dec '04

11 Dec '04

Jonathan Ernst wrote: [snip] > Index: CODING_STANDARD > =================================================================== > RCS file: /home/wine/appdb/CODING_STANDARD,v > retrieving revision 1.1 > diff -u -r1.1 CODING_STANDARD > --- CODING_STANDARD 11 Dec 2004 03:42:43 -0000 1.1 > +++ CODING_STANDARD 11 Dec 2004 18:56:07 -0000 > @@ -62,4 +62,11 @@ > } > } > > +- use long php tags (<?php ?>) instead of short ones (<? ?>) as : > + 1) it could be removed from future versions of php > + 2) if conflicts with tags like <?xml version=1.0 ?> that are used in xhtml [snip] Should be it not if oops//: + 2) it conflicts with tags like <?xml version=1.0 ?> that are used in xhtml

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel