wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: [resend] shell32 tests
by Rolf Kalbermatter 04 Dec '04

04 Dec '04

>+static HMODULE hshell32; >+static int (WINAPI *pSHCreateDirectoryExA)(HWND, LPCSTR, LPSECURITY_ATTRIBUTES); >+ >+static void InitFunctionPointers(void) >+{ >+ hshell32 = GetModuleHandleA("shell32.dll"); >+ >+ if(hshell32) >+ pSHCreateDirectoryExA = (void*)GetProcAddress(hshell32, "SHCreateDirectoryExA"); >+} >+ > /* creates a file with the specified name for tests */ > void createTestFile(CHAR *name) > { >@@ -398,17 +409,19 @@ > int ret; > > set_curr_dir_path(path, "testdir2\\test4.txt\0"); >- ret = SHCreateDirectoryExA(NULL, path, NULL); >+ ret = pSHCreateDirectoryExA(NULL, path, NULL); I think this is not right. Implementing dynamic loading of functions in tests is supposedly because that function may not be available on some systems. But here you invoke the (maybe uninitialized, or NULL assigned) function pointer nevertheless without protecting for this. As such your patch does only allow loading the test on such systems but will create a nice crash when run. Rolf Kalbermatter

1 0

2nd attemp at DllCanUnloadNow
by James Hawkins 03 Dec '04

03 Dec '04

This time I respect heap-based objects, leaving there internal ref counts and respective HeapFree's. I also took Alexandre's suggestions and changed Un/LockServer to DMCOMPOS_LockServer etc and change cLocks to refCount. Let me know if this is any closer to what it needs to be. Thanks. -- James Hawkins

2 1

Re: Wine book
by Ivan Leo Puoti 03 Dec '04

03 Dec '04

> The 'high level' parts (like d3drm) should work too, No program or sdk sample I know of and uses this dll currently works on wine. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

2 1

03 Dec '04

On windows xp/2k the IME window class appears to be always registered, even if a program doesn't link to nor loads imm32, the class is registered. How should this be handled in wine, should the class be registered at startup? Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: wine-preloader defunct
by James Hawkins 03 Dec '04

03 Dec '04

On Thu, 02 Dec 2004 20:01:48 -0800, Kenneth Porter <shiva(a)sewingwitch.com> wrote: > I've now got several instances of "[wine-preloader] <defunct>" in my ps > listing from a game server that's died in some strange way. Anyone have > experience in clearing these short of bouncing the whole box? They're > holding onto a couple of TCP ports that I'd like to use. The ports are > stuck in CLOSE_WAIT, because the processes are stuck in memory so the > sockets can't close. > > Does 'kill -9 processnum' not work? -- James Hawkins

6 10

Re: Implement GetLayout
by Shachar Shemesh 03 Dec '04

03 Dec '04

Rémi Assailly wrote: > I added some things to my previous patch. > Please tell me if something seems incorrect or is missing > Thanks ;) > > Changelog: > * implement GetLayout Thanks for spotting another one for my growing heap of BiDi TODOs.... http://bugs.winehq.org/show_bug.cgi?id=2584 Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: rsaenh/implglue.c: Added missing break
by Marcus Meissner 03 Dec '04

03 Dec '04

On Fri, Dec 03, 2004 at 11:49:22AM +0100, Michael Jung wrote: > Greetings, > Michael > > Changelog: > Added a missing break in encrypt_block_impl > > Index: dlls/rsaenh/implglue.c JFYI, we (Novell) are now working on reapproving WINE for US export due to your cryptographic library import. I will keep you posted, but I expect approval. Actually, in the closest meaning of the export regulations, I am not even allowed to build RPMs for SourceForge anymore here at SUSE/Novell :( Fun without end, I had hoped we keep openssl dynamic linking ;) Ciao, Marcus

2 2

Providing success stories
by Stefan Munz 03 Dec '04

03 Dec '04

Hi, I already mailed with some developers a few days ago. Basicly wether and in which way the wine logo can be used to communicate wine compatibility for software producers (this is already solved). For those who didn't read it, i copied a passage of the orig. mail: --- In order to push the use of Open Source Software we plan a project with the "Wirtschaftsförderung Region Stuttgart GmbH" (I don't know whats the equivalent in english but its a public organization that promotes OSS and assists companies that resident in Stuttgart). Within this project we want to find software producers who pay us for a wine compatibility test of their software. --- This project is starting at the moment. I thought a good idea to give something back to the community is to provide some success stories i.e. for use on winehq.com. Is this interesting? If the answer is yes, who is responsible for something of the kind. Regards, Stefan Munz

1 0

Preliminary Darwine SDK Released
by Sanjay Connare 03 Dec '04

03 Dec '04

Hello All, I have released a preliminary version of the Darwine SDK version 0.1. Many people are interested in getting Darwine up and running so they can compile programs on OS X and this release should satisfy their curiosity. The SDK features the following: -source code for the current Darwine binary 20040820 -source code for WineHelper -Xcode Integration -Xcode Template -Updated Uninstaller The Xcode integration allows for a user to compile windows source code from within the Xcode IDE using the wine tools. Users may want to note that there are some changes to the way Darwine is installed and functions. Due to limitations in Xcode, the wine source tools such as winegcc, winemaker, winebuild are installed in the /usr/bin directory and not the /Library/Darwine/bin directory. This may be changed in a future release but was necessary so Xcode integration would work correctly. As a result there is an updated uninstaller as well. The uninstaller will remove everything except for the Xcode project template folder, which is moved to the trash and needs to be removed manually. To start a new Darwine project, simply launch Xcode, select new project, and select Darwine (Windows) Application. Currently in Xcode the "Build and Run" does not work, it will build the program but not launch. However, the Build button works as expected. When compiling a Darwine application for the first time Xcode may give the error: "ld: table of contents for archive: /Library/Darwine/lib/wine/lib<name>.a is out of date; rerun ranlib(1) (can't load from it)" Open a terminal and type the following command: "sudo ranlib /Library/Darwine/lib/wine/lib<name>.a" <name> being replaced by the name of the library whose table of contents is out of date. The source code should then compile fine. There are many examples of source in the wine source code "programs" folder which is located in the root of the source directory. Simple programs should compile fine. However, bigger programs that depend on more of the windows headers will probably not compile due to header incompatabitlies between the wine and OS X headers. You can download the preliminary release here http://prdownloads.sourceforge.net/darwine/Darwine_SDK0.1.dmg?download or through the Darwine web site http://darwine.opendarwin.org Post any comments, questions or concerns to the Darwine Mailing List "darwine-devel(a)lists.sourceforge.net" . Remember this is a preliminary release and there are many bugs and issues that need to be worked out and features that need to be implemented. More information will be posted on the Darwine website in the near feature. Last but not least enjoy. Sanjay Connare

1 0

wine-preloader defunct
by Kenneth Porter 03 Dec '04

03 Dec '04

I've now got several instances of "[wine-preloader] <defunct>" in my ps listing from a game server that's died in some strange way. Anyone have experience in clearing these short of bouncing the whole box? They're holding onto a couple of TCP ports that I'd like to use. The ports are stuck in CLOSE_WAIT, because the processes are stuck in memory so the sockets can't close.

1 0

Suggestions for fixing test?
by Jakob Eriksson 03 Dec '04

03 Dec '04

http://test.winehq.org/data/200412011000/xp_IDWASEMPTY/gdi32:metafile.txt Any suggestions for fixing this? regards, Jakob

2 5

Re: shell32: reduce version to win2k
by Dmitry Timoshkov 03 Dec '04

03 Dec '04

"Juan Lang" <juan_lang(a)yahoo.com> wrote: > I hope this removes the IE6 regression. No, it doesn't. It turned out that it's something different that causes a regression, lowering down version of shell32 changes nothing. It seems that a better solution is to add missing images to shell32. We need at least the following bitmaps to make IE display images on toolbars: id 230/231 - they are the same with different brightness, 20x20 1 image id 227/228 - they are the same with different brightness, 24x24 6 images id 204/205 - they are the same with different brightness, 24x24 16 images id 214/215 - they are the same with different brightness, 24x24 47 images id 240 - 22x22 50 vertical images (animated windows logo) -- Dmitry.

1 0

RE: Treeview +/-
by Ge van Geldorp 02 Dec '04

02 Dec '04

> From: Jon Griffiths > > >Maybe the height/width at which to switch to the Rectangle drawing > >algorithm needs a bit of tuning? > > Ge, Can you confirm this fixes the size for you? It works for > me if I change my system font to a larger one... Yes, this works for me. Thanks. Ge van Geldorp.

1 0

automatic tests screwed up again
by Ivan Leo Puoti 02 Dec '04

02 Dec '04

In the reports page the link to the tests points to http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/winetest-200411251000… and this is probably what the server tells winrash to download, but it returns a 404. The test actually is at http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/winetest-200411251000… can someone please fix this? Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

3 3

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow
by Dmitry Timoshkov 02 Dec '04

02 Dec '04

"Robert Shearman" <rob(a)codeweavers.com> wrote: > -DWORD dll_ref = 0; > +LONG cLocks; ... > +/********************************************************************** > + * Dll lifetime tracking declaration > + */ > +void LockModule() > +{ > + InterlockedIncrement(&cLocks); > +} > + > +void UnlockModule() > +{ > + InterlockedDecrement(&cLocks); > +} Perhaps it would be better to prefix both a variable and lock/unlock interfaces with a module name, in this case "DEVENUM_" since they are global and externally visible. -- Dmitry.

4 5

Re: IME window class update
by Ivan Leo Puoti 02 Dec '04

02 Dec '04

> You mean 65535, in which case it'd be 0xffff? Nope, just doubled checked and with the value is 65553, or 0x10011. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: IME window class update
by Andreas Mohr 02 Dec '04

02 Dec '04

Hi, On Thu, Dec 02, 2004 at 04:38:39PM +0100, Ivan Leo Puoti wrote: > This patch is based on the IME window class implemented in windows 2000 and xp. > On both OSes hCursor is 65553, but I don't know what that is, maybe it's a > custom IME cursor? You mean 65535, in which case it'd be 0xffff? No idea what kind of cursor that is, but it looks like an invalid/unused one... Andreas Mohr

1 0

attemp at implementing DllCanUnload now for dcompos
by James Hawkins 02 Dec '04

02 Dec '04

Hey all, It would really help me out if you could look over this patch and see if I've incorrectly implemented ref-counting and DllCanUnloadNow for dcompos. I used suggestions from Rob and a sample implementation written by him. The only concern I have is that I'm not sure if all of these classes are non-heap based. -- James Hawkins

3 3

Re: systray rewrite part 2
by Grant Williamson 02 Dec '04

02 Dec '04

Mike, ok the rewrite, applies & compiles cleanly on 20041019, however, running SIP Phone-lite, it does not show on the systray, the older patch did. I am running gnome-2.8 on rhel4, what program do you want us to test with it. Mike Hearn wrote: >Clearly, I need to figure out a system for generating patches. This time >with (hopefully) all the files in the patch. > >- Add a new wineshell process, and put system tray handling in there >- Rewrite the shell32 systray handling to be out of process >- Support the freedesktop.org XEMBED protocol > > >------------------------------------------------------------------------ > > > >

2 3

SHBrowseForFolder
by Robert van Herk 02 Dec '04

02 Dec '04

Hi all, I am trying to implement the Browse button in the winecfg application, that would allow people to browse for a directory to use as their virtual c drive. In order to do so, I though I'd use the SHBrowseForFolder function from shlobj.h (see http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl…). However, when I tried this in Wine, I get a compiler warning: In driveui.c I did: case IDC_BUTTON_BROWSE_PATH: SHBrowseForFolder(0); //MessageBox(dialog, "", "Write me!", MB_OK); break; Then, at compile time I get: driveui.c:589: warning: undefined reference to `SHBrowseForFolderA' I made sure that there is a line that says: #include <shlobj.h> When I try to launch the app, I get ./winecfg wine: could not load L"Z:\\home\\robert\\Documents\\devel\\wine\\programs\\winecfg\\winecfg.exe.so": /home/robert/.wine/dosdevices/z:/home/robert/Documents/devel/wine/programs/winecfg/winecfg.exe.so: undefined symbol: SHBrowseForFolderA Does this mean that the SHBrowseForFolder thing is not implemented? Probably it is, because I checked Wine's shlobj.h. What am I doing wrong? Thanks, Robert

9 33

Re: Implement GetLayout
by Shachar Shemesh 02 Dec '04

02 Dec '04

Rémi Assailly wrote: > Shachar Shemesh wrote : > >> Thanks for spotting another one for my growing heap of BiDi TODOs.... >> >> http://bugs.winehq.org/show_bug.cgi?id=2584 >> >> Shachar >> > I know that there is no effect... I'm sorry if I came off cynical. There was no cynicism in that comment. I opened 2584 as a result of seeing your patch. I was not aware of this particular missing functionality. I'm aiming for http://bugs.winehq.org/show_bug.cgi?id=609 to be the ultimate documentation of all BiDi APIs in Windows. Opening 2584 is a good thing, as it documents things that are still to be done. > What is wrong ? It seems that this flag reverses the meaning of several common conventions (left/right etc.). The idea is probably so that applications that are natively right to left not have to change their design too much. I can't tell you exactly what it means, however, as I don't know myself. It will probably be a matter of comparing behaviors to the real Windows. I have some doubts about whether anyone is even using this flag at all. Maybe on localized Hebrew Windows, where the whole window decorations are reversed (Ughh. My GF has localized XP Home installed. This thing is horrible, but I didn't spot any non-Windows native applications that were affected by it). > Tell me and I will help you, if you want... I'll gladly accept all the help I can get. Basically, this particular unimplemented bit requires writing small test programs on Windows, and then running them on Wine until they produce the same results. The idea is that you read the MSDN page for the function (linked from the bug). That page also links to http://msdn.microsoft.com/library/en-us/winui/winui/windowsuserinterface/wi…, which gives more details on what this flag is supposed to mean. If you check out 2584 again, you will see I added this new information there. The steps one takes is to read all the relevant manuals, and try to understand what this means. Next, you write a small test program that does stuff with and without this flag, showing where this flag takes effect on Windows. Next, you move this test program to Wine and start tweaking Wine until it behaves the same there. There is also a last step, which is to make this program into a test suite, returning success or failure. I'm not sure, however, how that is supposed to be done for programs where success and failure are measured with graphical output. Hope this helps you help me help everyone..... :-) Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: [OLE #3] Tests For COM Functions
by Dmitry Timoshkov 02 Dec '04

02 Dec '04

"Robert Shearman" <rob(a)codeweavers.com> wrote: > I have only tried these tests on WinXP SP2. Please report > if they fail on Win9x. In order compile the tests with Platform SDK I applied the attached patch. Under win2k SP4 I got: marshal.c:898: Test failed: CoGetClassObject should have returned CO_E_SERVER_STOPPING instead of 0x80040154 Under Win95 the tests don't run due to missing APIs CoResumeClassObjects and CoInitializeEx. -- Dmitry.

1 1

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory;
by Rolf Kalbermatter 01 Dec '04

01 Dec '04

Robert van Herk wrote: >-LPITEMIDLIST WINAPI SHBrowseForFolderA (LPBROWSEINFOA lpbi) >+static INT_PTR BrowseW (LPBROWSEINFOW lpbi, DLGPROC dlgproc, enum browsemode aBrowseMode) >+{ >+ INT_PTR ret; >+ >+ browseMode = aBrowseMode; ^^^^^^^^^^ I may miss something here but this looks like a global variable and that would make these function theoretically thread unsafe. As long as only winecfg is going to use this functionality for the unix case it seems not a problem as there is probably not any chance that the native Windows version is called at that moment but this may of course change in the future. Rolf Kalbermatter

3 5

MAP_ANON support on HPUX
by Warren_Baird/CSI＠cimmetry.com 01 Dec '04

01 Dec '04

Hi All, I've just discovered that HP-UX's mmap implementation doesn't define MAP_ANON, it only defines MAP_ANONYMOUS. linux defined both, as does solaris (and solaris's manpage actually states that MAP_ANON is deprecated), but MacOS X seems to only define MAP_ANON MAP_ANON is only used in two source files: libs/wine/mmap.c and loader/preloader.c. My proposed patch involves slightly different changes in both places : in mmap.c, I just add a new #elif to handle the case, and in preloader.c I add a #ifdef block at the top to define MAP_ANON to be MAP_ANONYMOUS if MAP_ANON is undefined, but MAP_ANONYMOUS is defined. The other possible solution would be to put the #ifdef block from preloader.c into a common header... It's not obvious to me where to put it, though, which is why I'm proposing this patch. Should I rework it to use a common header? If so - any suggestions as to which header would be appropriate? Thanks, Warren

1 0

Bugzilla in CVS
by Jeremy Newman 01 Dec '04

01 Dec '04

http://cvs.winehq.org/cvsweb/bugzilla/ I have imported our buzilla into CVS for anyone to start submitting patches on. If I remember correctly, it is a fairly straight branch of version 2.17.4. All I modified was the templates in: /template/en/default/global Enjoy!

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel