wine-devel

wine-devel@winehq.org

11 participants
84461 discussions

Re: Public domain source in wine
by Scott Ritchie 04 Nov '04

04 Nov '04

>1. What is the legaly correct way to do this? As I understand it, >public domain source can simply be taken as is and re-licensed under >the LGPL. Is this correct? Am I allowed to remove the headers in the >original file, which state that the code is public domain? How do you >generally acknowledge the original author? Actually, public domain is a legal term meaning without copyright, so we can do whatever we want with the code - change it, cut it into pieces, even claim we made it. There is no public domain license, so to speak, since something in the public can be used without a license. As a matter of courtesy, however, citing the author in the source is a good idea. This is, of course, assuming that the code actually is in the public domain, and not licensed under something like some forms of BSD, which require acknowledgement in the source somewhere. -Scott

1 0

Has anyone done this before?
by Bill Medland 04 Nov '04

04 Nov '04

I would be interested in knowing if anyone has succeeded with this before I start getting too carried away trying to fix the errors. When I tried I got an X error (BadWindow). I am sitting at a RedHat 8.0 computer with a VPN tunnel to a remote network (Microsoft VPN server) ssh through that VPN to a remote computer running RHEL3 (ES) Set DISPLAY back to my end of the VPN tunnel, to my display Prove it works by typing xterm in the ssh session Try running winemine After rebuilding the cached metrics it momentarily (in the non-American sense) opens something and then closes it and gives me the X error. Does this stand a chance of actually working? -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

3 2

winmm:wave testing
by Jakob Eriksson 04 Nov '04

04 Nov '04

How should this be handled, is this a buggy driver? http://test.winehq.org/data/200411021000/2000_BennyGoemans/winmm:wave.txt wave.c:998:found 1 WaveOut devices wave.c:664: 0: "SB PCI" (\\?\pci#ven_1274&dev_1371&subsys_13711274&rev_08#3&61aaa01&0&68#{6994ad04-93ef-11d0-a3cc-00a0c9223196}\wave) 5.0 (1:100) wave.c:667: channels=65535 formats=00fff support=002c wave.c:669: WAVECAPS_VOLUME WAVECAPS_LRVOLUME WAVECAPS_SAMPLEACCURATE wave.c:524:Playing 1 second silence at 22050x 8x1 WAVE_FORMAT_PCM wave.c:420:waveOutGetPosition(0): TIME_MS not supported, returned TIME_SAMPLES wave.c:443:waveOutGetPosition(0): TIME_SMPTE not supported, returned TIME_SAMPLES wave.c:549: Test failed: The sound played for 1342 ms instead of 1000 ms

1 0

Wine dll testing state of affairs
by Jakob Eriksson 04 Nov '04

04 Nov '04

I looked around in the Wine dlls tree to see how many dlls had a "tests" directory in them. Quite a few had, but these did not: Just thought it could be interesting to see. . ./advpack ./amstream ./atl ./avicap32 ./avifil32 ./cabinet ./capi2032 ./cards ./cfgmgr32 ./comcat ./commdlg ./crtdll ./crypt32 ./ctl3d ./d3d8 ./d3d9 ./d3dim ./d3drm ./d3dx8 ./d3dxof ./dbghelp ./dciman32 ./devenum ./dinput ./dinput8 ./dmband ./dmcompos ./dmime ./dmloader ./dmscript ./dmstyle ./dmsynth ./dmusic ./dmusic32 ./dplay ./dplayx ./dpnet ./dpnhpast ./dswave ./dxdiagn ./dxerr8 ./dxerr9 ./dxguid ./glu32 ./glut32 ./hhctrl.ocx ./iccvid ./icmp ./ifsmgr.vxd ./imagehlp ./imm32 ./itss ./lzexpand ./mmdevldr.vxd ./monodebg.vxd ./mpr ./msdmo ./mshtml ./msi ./msimg32 ./msisys ./msnet32 ./msrle32 ./msvcrt20 ./msvcrt40 ./msvidc32 ./msvideo ./mswsock ./newdev ./odbc32 ./oleacc ./olecli ./oledlg ./olepro32 ./olesvr ./opengl32 ./qcap ./rasapi32 ./richedit ./secur32 ./serialui ./setupapi ./shdocvw ./shfolder ./snmpapi ./sti ./strmiids ./tapi32 ./ttydrv ./twain ./unicows ./url ./uuid ./uxtheme ./vdhcp.vxd ./vdmdbg ./vmm.vxd ./vnbt.vxd ./vnetbios.vxd ./vtdapi.vxd ./vwin32.vxd ./win32s ./winaspi ./wined3d ./winedos ./wineps ./winnls ./wintab32 ./wintrust ./wow32 ./wsock32 ./x11drv These have tests: ./advapi32/tests ./comctl32/tests ./ddraw/tests ./dsound/tests ./gdi/tests ./iphlpapi/tests ./kernel/tests ./mapi32/tests ./mlang/tests ./msacm/tests ./mscms/tests ./msvcrt/tests ./msvcrtd/tests ./netapi32/tests ./ntdll/tests ./ole32/tests ./oleaut32/tests ./psapi/tests ./quartz/tests ./rpcrt4/tests ./rsabase/tests ./shell32/tests ./shlwapi/tests ./urlmon/tests ./user/tests ./version/tests ./wininet/tests ./winmm/tests ./winsock/tests ./winspool/tests

1 0

Update region patch
by Alexandre Julliard 04 Nov '04

04 Nov '04

Here's the first step of moving the update region management to the server. The refresh on window moves is not optimized yet, so it will probably flicker quite a bit, but things should still be painted properly in the end. If you feel like giving this a try, I'm interested in hearing about any case where things don't repaint correctly. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: Some conformance tests for msvcrt printf functions
by Aneurin Price 04 Nov '04

04 Nov '04

Is there any particular reason this patch hasn't been committed? Something wrong or just overlooked?

2 1

Access Tokens and Threads
by Elad Lahav 03 Nov '04

03 Nov '04

I've been looking into the annoying "Set ThreadImpersonationToken handle" messages. In order to fix this issue, I need to know a few things: 1. Does Wine maintain access tokens at all? It seems that most of the relevant functions (e.g., NtQueryInformationThread and NtSetInformationThread) simply ignore it. 2. It looks like the thread's token is a part of the so-called "security descriptor" member of the thread's SECURITY_ATTRIBUTES structure. Does anyone know what structure this descriptor points to? Elad

2 1

source level debugging with WineLib?
by Geoff K. Hart 03 Nov '04

03 Nov '04

Hello, We just started using WineLib, and have very basic question: which -g??? option do you use to do source level debugging with winedbg? I searched the documentation and mailing list for any step-by-step about this, but found nothing. So either the answer is so obvious that I just can't see it - or it doesn't work? By default, winemaker seems configure things for no debug - so I edited one Makefile manually, and added -g. Winedbg can attach to the process, and can even show the stack - but didn't know much beyond that. I tried all the -g variants that I could find, but only -gstabs and -gstabs+ seemed to help. They allowed the debugger to find the correct place in the source, and "whatis" seemed to work - however, if I tried to dereference something, it complained about "no type ...", like this: Wine-dbg>info process pid threads parent executable (all id:s are in hex) 00000008 3 00000000 'Z:\home\s\src\SysSrv \DataDistributionService\DDSServer2\ddsserver2.exe' Wine-dbg>attach 8 In 32 bit mode. 0x546387a2: ret Wine-dbg>bt Backtrace: =>1 0x546387a2 (0x10252c50) 2 0x48714a7e NTDLL_wait_for_multiple_objects+0x12e in ntdll (0x10252cf8) 3 0x48712fec vm86_return_end+0xc55 in ntdll (0x10252d1c) 4 0x1000b808 (0x10352d64) 5 0x48714a7e NTDLL_wait_for_multiple_objects+0x12e in ntdll (0x10352e0c) 6 0x48714afc NtWaitForMultipleObjects+0x6c in ntdll (0x10352e30) 7 0x61e57a95 WaitForMultipleObjectsEx+0xb5 in kernel32 (0x10352f60) 8 0x61e5797b WaitForSingleObjectEx+0x3b in kernel32 (0x10352f80) 9 0x1002878afixme:dbghelp:elf_new_wine_thunks Duplicate in ddsserver2<elf>: _ZZ17BroadCastIdentityPvmmE22lRepCntrClientDeletion<10037720-00000004> lRepCntrClientDeletion<10037720-00000000> fixme:dbghelp:elf_new_wine_thunks Duplicate in ddsserver2<elf>: _ZZ17BroadCastIdentityPvmmE20lRepKeepAliveCounter<10037724-00000004> lRepKeepAliveCounter<10037724-00000000> fixme:dbghelp:elf_new_wine_thunks Duplicate in ddsserver2<elf>: _ZZ17BroadCastIdentityPvmmE17lRepCntrBroadcast<1003771c-00000004> lRepCntrBroadcast<1003771c-00000000> _Z13DDSServerMainPv+0x88(lpParameter=0x44c47098) [/home/s/src/SysSrv/ DataDistributionService/DDSServer2/AcceptSocket.cpp:220] in ddsserver2 (0x10353150) 10 0x61e5eeda (0x10353228) 11 0x48716523 (0x10353a78) 12 0x1000508d (0x10353b0c) 13 0x660d255a (0x00000000) Wine-dbg>up 8 220 dwRetVal = ::WaitForSingleObjectEx (pServer- >m_hStopEvent, INFINITE, TRUE); Wine-dbg>p pServer 0x44c47098 Wine-dbg>p *pServer No type or type mismatch Wine-dbg>whatis pServer struct DDSServer* Wine-dbg> Any help? Geoff

5 4

Re: InternetGetConnectedStateExA
by Alexandre Julliard 03 Nov '04

03 Nov '04

Aric Stewart <aric(a)codeweavers.com> writes: > +BOOL WINAPI InternetGetConnectedStateExA(LPDWORD lpdwStatus, > + LPSTR lpszConnectionName, DWORD dwNameLen, DWORD dwReserved) > +{ > + INT len; > + LPWSTR lpwszConnectionName = NULL; > + BOOL rc; > + > + TRACE("(%p, %s, %ld, 0x%08lx)\n", lpdwStatus, debugstr_a(lpszConnectionName), dwNameLen, dwReserved); > + > + if (lpszConnectionName) > + { > + len = MultiByteToWideChar(CP_ACP, 0, lpszConnectionName, -1, NULL, 0); > + lpwszConnectionName= HeapAlloc(GetProcessHeap(), 0, len*sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, lpszConnectionName, -1, > + lpwszConnectionName, len); > + } > + > + rc = InternetGetConnectedStateExW(lpdwStatus,lpwszConnectionName, dwNameLen, lpszConnectionName is an output parameter, it should be converted on return from the W call. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: WINSOCK: Implement WSAAddressToStringA/W
by Alexandre Julliard 03 Nov '04

03 Nov '04

Hans Leidekker <hans(a)it.vu.nl> writes: > + if (stringW) > + { > + ret = WSAAddressToStringW( sockaddr, len, NULL, stringW, &lenstrW ); > + *lenstr = lenstrW / sizeof(WCHAR); To be really correct you have to use WideCharToMultiByte to compute the ASCII length. Though in this case it would probably be easier to just duplicate the code and do a simple sprintf in the A function instead of trying to call the W function. -- Alexandre Julliard julliard(a)winehq.org

1 0

compiling wine with msvc
by James Hawkins 03 Nov '04

03 Nov '04

I'm trying to get the wine tests to compile under msvc, so I ran msvcmaker in the wine source under cygwin (which was successful). Then I opened the winetest project and did a 'rebuild all'. When it tries to compile advapi32_test/security.c I get an warning and 102 errors: C:\Program Files\Microsoft Visual Studio\VC98\INCLUDE\rpc.h(89) : warning C4005: 'RPCRTAPI' : macro redefinition ..\..\..\include\rpc.h(45) : see previous definition of 'RPCRTAPI' :\Program Files\Microsoft Visual Studio\VC98\INCLUDE\rpcnsi.h(37) : error C2143: syntax error : missing ')' before 'type' C:\Program Files\Microsoft Visual Studio\VC98\INCLUDE\rpcnsi.h(37) : error C2491: 'RpcNsBindingExportA' : definition of dllimport function not allowed ......etc I'm pretty sure the problem is that the the msvc's rpc.h and rpcnsi.h files are being included when they shouldn't. Is that about right? If so, what could be a possible solution? BTW I'm compiling with MSVC++ 6.0. wine cvs from 11-01-2004. -- James Hawkins

3 6

Re: Fix for metafile test
by Dmitry Timoshkov 03 Nov '04

03 Nov '04

"Jakob Eriksson" <jakov(a)vmlinux.org> wrote: > Seems the test fails in non-interactive mode without this patch. No, the problem seems to be related to a window's visibility. Windows does not play EMF records if the DC was created for a not visible window. A lot of other tests fail due to exactly that problem: user32/win.c and user32/msg.c are the examples. The question is what makes the tests create invisible windows? Does winetest run as a service on a not visible desktop? Anything else? -- Dmitry.

4 5

Re: The Return of IE6 Problems
by Mike Hearn 03 Nov '04

03 Nov '04

> The common denominator for this situation is that these patches modified > some of the same files. Patch 13475 implemented itss.dll and modified > wine/dlls/Makefile.in, wine/configure.ac and wine/configure. A partial > implementation of advpack.RegInstall, Patch 13938 also modified > wine/dlls/Makefile.in, wine/configure.ac and wine/configure in addition > to adding /wine/dlls/advpack/reg.c. Although IE6 would still > initialize, patch 13937 added advpack to the repository. Hi Dan, Great work on the regression search! This is exactly the sort of information we need. ITSS was implemented by Mike - as it's a component of IE I guess it should at least work with it so I'm CCing him. It may be that he implemented it for some other app rather than IE and he doesn't have time to bring it up to scratch for IE right now. I'm not sure. The second patch suggests that we got RegInstall wrong. That needs to be fixed, but for now you can probably get IE back to a working state again by overriding both these DLLs as native (itss, advpack). If you look at the script I wrote back in January, quite a lot of what it does is simply overriding various incomplete DLLs. I no longer maintain that script (buy CrossOver! :) but if you want to take over maintenance by all means do so, I'd be happy to help you get up to speed. thanks -mike

2 1

RE: Test Drive failure
by Dagan Shai 03 Nov '04

03 Nov '04

This results in a helloworld executable. When I execute it I get lots of output lines, here's a sample: fixme:ttydrv:TTYDRV_GetBitmapBits (0x3bc, 0x77cafa7c, 32): stub fixme:ttydrv:TTYDRV_GetBitmapBits (0x3b8, 0x77cafa9c, 32): stub err:imagelist:ImageList_ReplaceIcon no color! fixme:ttydrv:TTYDRV_DC_StretchBlt (0x94, 288, 0, 16, 16, 0x3c4, 0, 0, 16, 32, 13 369376): stub fixme:ttydrv:TTYDRV_DC_StretchBlt (0x98, 288, 0, 16, 16, 0x3c4, 0, 0, 16, 32, 13 369376): stub fixme:ttydrv:TTYDRV_GetBitmapBits (0x3cc, 0x77cafa7c, 128): stub fixme:ttydrv:TTYDRV_GetBitmapBits (0x3c8, 0x77cafafc, 128): stub err:imagelist:ImageList_ReplaceIcon no color! fixme:ttydrv:TTYDRV_DC_StretchBlt (0xb0, 576, 0, 32, 32, 0x3d4, 0, 0, 32, 64, 13 369376): stub fixme:ttydrv:TTYDRV_DC_StretchBlt (0xb4, 576, 0, 32, 32, 0x3d4, 0, 0, 32, 64, 13 369376): stub These are all functions that helloworld does not use, so I don't understand the problem here. Regards, Shai Dagan -----Original Message----- From: Dimitrie O. Paun [mailto:dpaun@rogers.com] Sent: Tuesday, November 02, 2004 6:57 PM To: Dagan Shai Cc: Dimitrie O. Paun; wine-devel(a)winehq.org Subject: Re: Test Drive failure On Tue, Nov 02, 2004 at 06:40:57PM +0200, Dagan Shai wrote: > Thanks. > > Here they are. Winemaker is buggy, the generated Makefile has a small problem. Here's the fix: --- Makefile.orig 2004-11-02 09:52:59.000000000 -0500 +++ Makefile 2004-11-02 11:52:57.451738280 -0500 @@ -58,7 +58,7 @@ ### Generic targets -all: $(SUBDIRS) $(DLLS:%=%.so) $(EXES:%=%.so) +all: $(SUBDIRS) $(DLLS:%=%.so) $(EXES) ### Build rules @@ -106,7 +106,7 @@ $(helloworld_exe_MODULE).dbg.c: $(helloworld_exe_C_SRCS) $(helloworld_exe_CXX_SRCS) $(WINEBUILD) -o $@ --debug -C$(SRCDIR) $(helloworld_exe_C_SRCS) $(helloworld_exe_CXX_SRCS) -$(helloworld_exe_MODULE).so: $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_OBJS) +$(helloworld_exe_MODULE): $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_OBJS) $(CXX) $(helloworld_exe_LDFLAGS) -o $@ $(helloworld_exe_OBJS) $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_LIBRARY_PATH) $(LIBRARY_PATH) $(helloworld_exe_DLLS:%=-l%) $(helloworld_exe_LIBRARIES:%=-l%) -- Dimi. ______________________________________________________________________ This email message has been scanned by PineApp Mail-Secure and has been found clean.

1 0

Re: EnumDateFormatsA: Add ru_RU locale and default DATE format
by Dmitry Timoshkov 03 Nov '04

03 Nov '04

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Changelog: > EnumDateFormatsA: > - Add ru_RU locale (0x419) That's a completely broken implementation, please do not extend it. It should retrieve the data from the kernel32 locale database (have a look at dlls/kernel/nls). > - Use DATE_SHORTDATE when dwFlags is 0 > - Ignore LOCALE_USE_CP_ACP bit in dwFlags (I can't find a difference in > Windows behavior with this flag) It would be nice to see a test case for that. Also please use a common indent 4 spaces as (almost) everywhere in Wine. -- Dmitry.

2 2

dinput - mouse
by Vitaliy Margolen 03 Nov '04

03 Nov '04

Is there are anyone working on it? It seems like there are some strange problem with mouse input, and I can't find it! I trying to get Descent 3 running. So far so good. It installs, and runs. But mouse does not work. It's not like it doesn't work at all. It does, but it moves erratically and mostly left-right. Could it be that it can't switch to full screen mode and fails because of it? Dome could be downloaded from here: http://www.descent3.com/4_downloads.html#d3_demos P.S. I know there is Linux version of it. Too bad I don't have it. It cost $$ and have to by purchased separately. Vitaliy Here is what dinput log looks like: trace:dinput:dinput_mouse_hook msg 200 pt 320 240 (W=0) trace:dinput:dinput_mouse_hook (X: 0 - Y: 0 L: 00 M: 00 R: 00) trace:dinput:dinput_mouse_hook msg 200 pt 320 240 (W=0) trace:dinput:dinput_mouse_hook (X: 0 - Y: 0 L: 00 M: 00 R: 00) trace:dinput:dinput_mouse_hook queueing -2 at offset 0 (queue head 46 / size 64) trace:dinput:dinput_mouse_hook queueing 8 at offset 4 (queue head 47 / size 64) trace:dinput:dinput_mouse_hook msg 200 pt 318 248 (W=1) trace:dinput:dinput_mouse_hook (X: -2 - Y: 8 L: 00 M: 00 R: 00) trace:dinput:dinput_mouse_hook queueing -2 at offset 0 (queue head 48 / size 64) trace:dinput:dinput_mouse_hook queueing 6 at offset 4 (queue head 49 / size 64) trace:dinput:dinput_mouse_hook msg 200 pt 316 254 (W=1) trace:dinput:dinput_mouse_hook (X: -4 - Y: 14 L: 00 M: 00 R: 00) trace:dinput:dinput_mouse_hook queueing -2 at offset 0 (queue head 50 / size 64) trace:dinput:dinput_mouse_hook queueing 6 at offset 4 (queue head 51 / size 64) trace:dinput:dinput_mouse_hook msg 200 pt 314 260 (W=1) trace:dinput:dinput_mouse_hook (X: -6 - Y: 20 L: 00 M: 00 R: 00) trace:dinput:dinput_mouse_hook queueing -2 at offset 0 (queue head 52 / size 64) trace:dinput:dinput_mouse_hook queueing 8 at offset 4 (queue head 53 / size 64) trace:dinput:dinput_mouse_hook msg 200 pt 312 268 (W=1) trace:dinput:dinput_mouse_hook (X: -8 - Y: 28 L: 00 M: 00 R: 00) trace:msg:MSG_peek_message got type 7 msg 200 (WM_MOUSEMOVE) hwnd 0x10022 wp 0 lp 0 trace:dinput:SysMouseAImpl_GetDeviceData (0x4036bd48)->(dods=16,entries=64,fl=0x00000000) trace:dinput:SysMouseAImpl_GetDeviceData Application retrieving 12 event(s). trace:dinput:SysMouseAImpl_GetDeviceData Warping mouse to 320 - 240

1 0

WSARecv not calling CompletionRoutine on socket close
by Geoff K. Hart 02 Nov '04

02 Nov '04

I've tried to search the mailing list archives (is their a searchable archive someplace?) for some reference to this problem. but found none. Forgive me if I didn't search hard enough. The Problem: we register a callback (lpCompletionRoutine) in our WSARecv call. This callback works fine for normal incoming messages. However, on socketclose, it does NOT get called. This behavior doesn't match what we see on Windows. Is there some configuration option we are missing? We see this same behavior for .exe's built on Windows and run under Wine - and with source code brought to Linux and built with WineLib. thanks, Geoff

1 0

[shellpath.c]: minor fix to Rolf's patch
by Rolf Kalbermatter 02 Nov '04

02 Nov '04

<menard.fabrice(a)wanadoo.fr> wrote: >The latest patch from Rolf Kalbermatter on shellpath.c was breaking the installation of wine.inf. > > wine rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 d:\\wine.inf > >was returning errors about being unable to create some dirs. In facts these errors was concerning >already existing directories in SHGetFolderPathW. I believe this patch is not fully correct. I noticed these errors too after the patch was applied, but did a little more investigation. SHCreateDirectoryEx should never be called if the directory already exists since this is explicitedly tested before the call to the function with PathFileExistsW(). Also inside the SHCreateDirectoryEx function I saw that the first call to CreateDirectory fails since intermediate directories are missing and then in the recursive call to CreateDirectory every single call returns ERROR_ALREAY_EXISTS on my system in spite of that it actually creates the last two or three directories in there. My investigations showed that in spite of that some of the the top level directories do not exist, the function NtCreateFile() which is ultimately called does seem to return an according NT status when called from SHGetFolderPath() but does create the directory nevertheless. Strange thing is that I can't reproduce this behaviour when calling SHCreateDirectoryEx() with many different parameters from an extended test in tests/shfileop.c So I believe the root cause really seems somewhere else, namely NTCreateFile or maybe wineserver itself, but I hadn't time to further go into details. >I think it is not necessary to care about that in this function so I added a check on the >type of error returned by SHCreateDirectoryExW. ShCreateDirectory should fail with that error if the directory really already existed. Rolf Kalbermatter

2 2

Can't debug mingw compiled program
by Vitaly Lipatov 02 Nov '04

02 Nov '04

During program debugging I have some trouble with winedbg use. Simple test program with error on write access to constant: #include <string.h> int main(int argc, char **argv) { char * str = "test"; _strupr(str); return (0); } I try debug it: $ winedbg 3.exe Can't attach process 3: error 87 WineDbg starting on pid 0xa In 32 bit mode. Wine-dbg>c First chance exception: page fault on write access to 0x00404000 in 32-bit code (0x00935d20). ... Backtrace: =>1 0x00935d20 _memccpy+0x595 in msvcrt (0x0090fec8) 2 0x00401330wine-kthread: stabs.c:246: stabs_find_ref: Assertion `filenr <= cu_include_stk_idx' failed. I see some bug in stubs handling. Versions: i386-mingw32msvc-gcc-3.3.3 wine from last CVS Any suggestions? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

RFC: yield on Waits
by Jeremy White 02 Nov '04

02 Nov '04

Hi folks, Due to my new found belief that all of the flaws in Wine are timing problems, I have found what appears to be a gaping hole in Wine's timing behavior. Specifically, it appears as though any style of Waitxxx is supposed to yield the processor. This seems a bit difficult for me to believe, even though we had earlier discovered that Wine was never yielding on a Sleep(0). I've attached the test program I used to discover this. If you run sleep2 -1 0w the program will start 2 threads, one which spin loops (-1), and one which does a wait on an object for 0 seconds. You'll see in the results that the Wait(...,0) thread gets far fewer loops, and thus must be yielding. Further, changing that to a 0ws (or even 5ws), which means we're waiting on a signalled object, doesn't change the behavior. This leads me to suggest the attached patch. I would appreciate review from other folks, because this seems like a drastic change to me, and it strikes me as equally likely that I've done something stupid. Cheers, Jeremy

1 1

Re: Test Drive failure
by Dimitrie O. Paun 02 Nov '04

02 Nov '04

On Tue, Nov 02, 2004 at 06:40:57PM +0200, Dagan Shai wrote: > Thanks. > > Here they are. Winemaker is buggy, the generated Makefile has a small problem. Here's the fix: --- Makefile.orig 2004-11-02 09:52:59.000000000 -0500 +++ Makefile 2004-11-02 11:52:57.451738280 -0500 @@ -58,7 +58,7 @@ ### Generic targets -all: $(SUBDIRS) $(DLLS:%=%.so) $(EXES:%=%.so) +all: $(SUBDIRS) $(DLLS:%=%.so) $(EXES) ### Build rules @@ -106,7 +106,7 @@ $(helloworld_exe_MODULE).dbg.c: $(helloworld_exe_C_SRCS) $(helloworld_exe_CXX_SRCS) $(WINEBUILD) -o $@ --debug -C$(SRCDIR) $(helloworld_exe_C_SRCS) $(helloworld_exe_CXX_SRCS) -$(helloworld_exe_MODULE).so: $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_OBJS) +$(helloworld_exe_MODULE): $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_OBJS) $(CXX) $(helloworld_exe_LDFLAGS) -o $@ $(helloworld_exe_OBJS) $(helloworld_exe_MODULE).dbg.o $(helloworld_exe_LIBRARY_PATH) $(LIBRARY_PATH) $(helloworld_exe_DLLS:%=-l%) $(helloworld_exe_LIBRARIES:%=-l%) -- Dimi.

1 0

Correct time stamps on x11 events
by Jeremy White 02 Nov '04

02 Nov '04

Log message: Fix x11 event timing so that we correctly correlate x11 timing and Wine timing and dynamically adjust it as we go.

1 0

RE: Test Drive failure
by Dagan Shai 02 Nov '04

02 Nov '04

It only generated the helloworld.exe.so file, and no others. This is the only file defined in the makefile generated by winemaker. It is listed as part of the EXES macro and not the DLLS, which is why I thought it to be an executable. Could there be some reason that no executable is generated? Shai Dagan -----Original Message----- From: Dimitrie O. Paun [mailto:dpaun@rogers.com] Sent: Tuesday, November 02, 2004 6:14 PM To: Dagan Shai Cc: wine-devel(a)winehq.org Subject: Re: Test Drive failure On Tue, Nov 02, 2004 at 05:53:11PM +0200, Dagan Shai wrote: > Hi, > I'm new to WINELIB. As a test drive I tried to port the Hello World > application, just to see that the environment is functioning. > I called: > winemaker --console --lower-uppercase . > In the source directory. Then I called: > make > A helloworld.exe.so file was successfully created as a result (no errors > or warnings). It should have also generated a helloworld executable file, and you should be running it as: # ./helloworld -- Dimi. ______________________________________________________________________ This email message has been scanned by PineApp Mail-Secure and has been found clean.

3 2

Re: Fix for metafile test
by Juan Lang 02 Nov '04

02 Nov '04

Dmitry wrote: > The question is what makes the tests create invisible windows? Does > winetest run as a service on a not visible desktop? Anything else? I believe this is the reason. The shellpath tests fail on WinXP, I believe because HKCU doesn't exist because the service doesn't interact with the desktop. --Juan __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

Re: COM / InstallShield status
by Mike Hearn 02 Nov '04

02 Nov '04

> Likewise, what's the current status of Installshield support, > and how much work would it be to fully support > Installshield-based installers? I don't see any > open Installshield bug reports, maybe I should file > one against the apps I have that don't install at > the moment. (Or would that be overkill?) Rob and I did some work on InstallShield for iTunes a few months ago, since then AFAIK no work has been done. Status back then was that the InstallShield 7/MSI hybrid installers worked pretty well, the bug I chased for nearly a week was refcounting related (the backend wasn't shutting down) and since that was fixed I believe it works pretty well. The other main problems I'm aware of are: - needs stdole32.tlb, we have a program to generate this in CrossOver and it needs to be pulled upstream as previously discussed. - Painting problems. I've not investigated this deeply but I'm 99% sure I know what the problem is. I've even written a patch to fix it as part of investigating iTunes, but I never tried the patch with an InstallShield that shows the issue. Apart from those two there are mostly just generic issues - InstallShield contains its own scripting language which heavily exercises the variant APIs, so it sometimes shows up problems with them. I believe Marcus found an issue with them thanks to InstallShield recently. In other words, InstallShield *should* work though it might not be pretty. There may be installers out there which don't work, I'd like to start nailing them once I get back to Wine hacking. I don't know if I'll get time however. Also, Murphy continues to smack me down w.r.t internet connection, the ISP sent me the wrong type of modem and yesterday I discovered the phone socket I was going to connect the modem to doesn't actually work :( thanks -mike

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel