wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: Gradient Color for Caption Bar
by Dmitry Timoshkov 27 Oct '04

27 Oct '04

"William Poetra Yoga H" <williampoetra(a)yahoo.com> wrote: > This patch is for filling the caption bar (a.k.a. title bar) with gradient > colors, like in Win98/WinME/Win2K/WinXP. > > I've modified nonclient.c too heavily (work on other parts of it), so this > patch may generate offsets or things like that. Please comment on wine-devel. > Thanks. > -IMPORTS = gdi32 advapi32 kernel32 ntdll > +IMPORTS = msimg32 gdi32 advapi32 kernel32 ntdll Use gdi32.GdiGradientFill instead of msimg32.GradientFill, the latter one is forwarded to gdi32 anyway. -- Dmitry.

3 3

Re: GetTimeZoneInformation return value fix
by Alexandre Julliard 27 Oct '04

27 Oct '04

Rein Klazes <rklazes(a)xs4all.nl> writes: > - reordered some code from the existing helper _GetTimeZoneBias > to make it more general useful (and changed the helper names to > TIME_xyz). > - Make GetTimeZoneInformation return the correct zone id > constants. > - changed some "const LPX_Y_Z" declarations to "const X_Y_Z *" This breaks the msvcrt tests: ../../../tools/runtest -q -P wine -M msvcrt.dll -T ../../.. -p msvcrt_test.exe.so time.c && touch time.ok time.c:101: Test failed: Wrong date:Year 70 mon 0 yday 1 mday 2 wday 5 hour 0 min 0 sec 0 dst -1 time.c:112: Test failed: Wrong date:Year 70 mon 0 yday 1 mday 2 wday 5 hour 0 min 0 sec 0 dst -1 -- Alexandre Julliard julliard(a)winehq.org

2 1

RE: Wine User Guide Improvements
by Scott Ritchie 27 Oct '04

27 Oct '04

Brian, I agree with your plan to condense the guide down. I would still keep some parts of the Getting Wine chapter and put it at the end of the introduction, or possibly at the beginning of configuring wine. I agree about changing it to be mostly a reference to the relevant parts of WineHQ. Would it be duplicitous of me to just go ahead and redo the Getting Wine chapter and leave it as it is now, and perhaps merge it into configuring/introduction once you're done? That way we'll have 4 chapters: Introduction Configuring Wine Running Wine Troubleshooting The running wine chapter eventually needs to be rewritten too (outdated switches, etc.) It could probably be reorganized a bit to read nicer as well (for example, directions for uninstalling programs are given before running them.) I'd like to have the documentation revamped by the next release. Combined with the coming winecfg patches, the major red marks at http://www.winehq.org/site/todo_lists can be replaced with happy green bars. I think we can easily have the yellow bit for the User Guide finished by then too. After that, the only major things in the way of 0.9 seem to be the developer and winelib guide, which are a bit beyond my abilities. (note: forwarded to wine-devel for further feedback) Thanks, Scott Ritchie

2 1

rsaenh
by Michael Jung 26 Oct '04

26 Oct '04

Hello, this is an updated version of the rsaenh implementation from yesterday. Updates: 1.) Broke long lines to not exceed a length of 100 characters. 2.) Substituted tabs with spaces. 3.) Removed magic constants. 4.) Rsaenh now uses MD4, MD5 and SHA from advapi32. 5.) Regression tests should work now without failures even if OpenSSL is not available. 6.) Fixed filenames in comments. If you want to try the patch note the following: - After you have applied the patch you have to run autoheader and autoconf. Then cd dlls ; make_dlls ; cd .. ; configure. - After you have compiled and installed wine, you have to unregister rsabase and register rsaenh (regsvr32 /U rsabase ; regsvr32 rsaenh). rsaenh.dll is meant to replace rsabase.dll sometime (Windows XP also has rsaenh.dll only). Greetings, Michael

1 0

Re: WSCEnumProtocols
by Alexandre Julliard 26 Oct '04

26 Oct '04

Hans Leidekker <hans(a)it.vu.nl> writes: > +INT WINAPI WSAEnumProtocolsA( LPINT lpiProtocols, LPWSAPROTOCOL_INFOA lpBuffer, LPDWORD lpdwLength ) > +{ > + return WINSOCK_EnumProtocols( lpiProtocols, (WSAPROTOCOL_INFOW *)lpBuffer, lpdwLength, FALSE ); > +} You cannot cast a WSAPROTOCOL_INFOA* to a WSAPROTOCOL_INFOW*, the structures don't have the same size. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: rsaenh
by Michael Jung 26 Oct '04

26 Oct '04

On Tuesday 26 October 2004 16:56, Juan Lang wrote: > Michael wrote: > > > 1. MD4, MD5, and SHA1 are now implemented in wine's > > > advapi32. Please use these instead of OpenSSL's. > > > > Yes, that makes sense. Would it be possible to move > > the SHA1, MD4 and MD5 related code to some other > > directory in the wine tree and link to it > > statically from both advapi32 and rsaenh? Is the > > misc directory meant for this purpose? > > No. Generally, creating static libs is something we > avoid in wine. More specifically, these functions are > already exported by advapi32, and you already link > advapi32 (to get access to the registry) so there's no > advantage to having a copy in both places. There is also a DES implementation in dlls/advapi32/crypt_des.c. However, this one is not exported by advapi32.dll. I could copy the code over to dlls/rsaenh, but this would mean unnecessary code duplication. How are such cases handled in wine typically? Although it is of no concern at the moment, another problem will arise in the future: advapi32 and cryptographic service provider dll's check each other against tempering by the use of digital signatures in windows (Probably because of US export restrictions on cryptographic software). Although I don't know for sure, I could imagine that this is actually the reason, why there are MD4, MD5 and SHA implementations in advapi32. Having rsaenh.dll call advapi32.dll for these algorithms would bypass these checks. I don't know if this will be an issue for wine though. Greetings, Michael

2 1

Re: shell32: shellpath tests failing greatly
by Juan Lang 26 Oct '04

26 Oct '04

Hi Rolf, try reregistering shell32; those entries are supposed to be created by wine.inf when it registers it. --Juan __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

1 0

shell32: shellpath tests failing greatly
by Rolf Kalbermatter 26 Oct '04

26 Oct '04

The recently added tests for shellpath are failing almost completely on my system as it is missing the according registry entries. Not sure how one is supposed to get those registry entries properly. Maybe there is an install script? Although the current documentation talks about an utility wineinstall this seems to have gone completely and I doubt it would take care of those settings. Rolf Kalbermatter

1 0

FW: GetEnvironmentVariableW regression?
by Rolf Kalbermatter 26 Oct '04

26 Oct '04

I suddenly happen to get an error when starting up any application in Wine after having upgraded to current CVS yesterday night from a version a few days ago. The error message is about: "Warning: The specified Windows directory L"c:\\windows" is not accessible" and the same applies for the system directory with the message: "Warning: The specified System directory L"c:\\windows\\system" is not accessible". Looking in the sources I can find the according message in dlls/kernel/process.c and the paths seem to get extracted with GetEnvironmentVariableW(). It seems to me that there is a problem with bad variable expanding or something as the double backslashes in the path in the warning text definitely look wrong. I'm using SUSE Linux 9.0 with XFree 4.3.99. Has this to do with some changes where the .wine/config is supposed to be moved to the registry? If so how do we get the right settings into the registry for common users? Rolf Kalbermatter

1 0

Re: WineHQ: Assorted spelling fixes
by Filip Navara 26 Oct '04

26 Oct '04

Francois Gouget wrote: >Index: wwn/wn20041015_244.xml >=================================================================== >RCS file: /var/cvs/lostwages/wwn/wn20041015_244.xml,v >retrieving revision 1.1 >diff -u -r1.1 wn20041015_244.xml >--- wwn/wn20041015_244.xml 15 Oct 2004 03:59:52 -0000 1.1 >+++ wwn/wn20041015_244.xml 25 Oct 2004 23:10:22 -0000 >@@ -185,7 +185,7 @@ > <p>We discussed Jason Edmeades plans to work on > Direct3D 9 a few weeks ago (see WWN issue > <a href="http://www.winehq.com/?issue=240#DirectX%209%20Roadmap">#240</a>). >-The concensus seemed to be created a shared library between >+The concensus seemed to be ro create a shared library between > s/to be ro/to be to/

2 1

Re: rsaenh
by Juan Lang 26 Oct '04

26 Oct '04

Michael wrote: > There is also a DES implementation in dlls/advapi32/crypt_des.c. > However, this one is not exported by advapi32.dll. I could copy the > code over to dlls/rsaenh, but this would mean unnecessary code > duplication. How are such cases handled in wine typically? They are typically handled by copying the code. If linking between the two requires a private export, then our DLLs can't work with native ones, and that's something we try to avoid. If we use a static library, the number of static libraries can potentially get very large, and the makefiles unmanageable. It's really best to accept code duplication, especially for something like DES that is quite stable. > Although it is of no concern at the moment, another problem will arise > in the future: advapi32 and cryptographic service provider dll's check > each other against tempering by the use of digital signatures in > windows Yes, I know. The functions in advapi32 for verifying a provider always return success at the moment, unfortunately. Maybe with more crypto support we can tackle this, but not yet. > (Probably because of US export restrictions on cryptographic software). I'd be surprised if this were the motivation. US export restriction is on key length, not on algorithm, and the signatures don't say anything about these, just that the files have not been modified and their source can be verified. I expect the motivation is more along the lines of, I'm trusting these DLLs to encrypt my credit card number and whatnot, so how can I trust the DLLs? --Juan __________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo

2 1

Re: Re: Problems downloading the RedHat Packages.
by gslink 26 Oct '04

26 Oct '04

I downloaded the Oct. Package from Heanet and got garbage. This isn't surprising if it is not there.

1 0

Wine for Solaris 2.8 assembler problems
by Doug 26 Oct '04

26 Oct '04

I am trying to compile Wine for Solaris to get MCS working for mono. However there are problems getting Wine to work on Solaris 2.8. When first compiling wine, I was thought the errors were caused by using the assembler for Solaris so I changed the as (assembler) to the GNU version. Now I get the following errors. Any ideas of how to fix this? I have heard people getting mono to work on Solaris 2.8 so from what I know it is possible to get Wine working. gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DBINDIR="\"/usr/l ocal/bin\"" -DDLLDIR="\"/usr/local/lib/wine\"" -D_REENTRANT -fPIC -Wall -pipe -f no-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o port.o port.c {standard input}: Assembler messages: {standard input}:1162: Error: ignoring unrecognized symbol type "" {standard input}:1162: Error: Rest of line ignored. First ignored character is ` 2'.

1 0

Re: rsaenh [beware: 27kB attachment]
by Juan Lang 26 Oct '04

26 Oct '04

Hi Michael, some very brief feedback: 1. MD4, MD5, and SHA1 are now implemented in wine's advapi32. Please use these instead of OpenSSL's. 2. The regression tests should be written so they don't fail if OpenSSL isn't available. 3. Get rid of magic numbers: What do the values 0x36 and 0x5c mean in copy_hmac_info? What is the length 64? Finally, some stylistic nits: 4. Please break long lines. 5. In some of the files you have the incorrect filename in the comments, e.g. dlls/rsabase/handle.c, dlls/rsabse/handle.h 6. Your indentation in some places is inconsistent; you mix spaces and tabs, and that makes it hard for me to guess the appropriate tab size. __________________________________ Do you Yahoo!? Yahoo! Mail Address AutoComplete - You start. We finish. http://promotions.yahoo.com/new_mail

3 2

Functions For Helping FillRect
by William Poetra Yoga H 26 Oct '04

26 Oct '04

FillRect is used in many places for drawing the GUI. But one thing I think many developers miss is that it doesn't fill the right and bottom borders of the rectangle, very much like LineTo doesn't draw the destination point (as per the MSDN docs). But when handling RECT structures we usually think about the objects, not how the objects are going to be painted on-screen. For example, if we wanted to draw a red rectangle at (10,10) with width of 50 pixels and height of 75 pixels, we do (assuming hdc and hbr is already set correctly): RECT r; r.left = 10; r.top = 10; r.right = r.left + 50; r.bottom = r.top + 75; FillRect(hdc, &r, hbr); This _will_ draw it all right, but there are conceptual errors: 1. The rectangle that we have here is not 50x75, but actually 51x76. But FillRect doesn't fill the right and bottom borders, so it appears correctly. 2. If we thought that FillRect fills the whole rectangle, then actually the above code doesn't do what we want; it should actually draw a 51x76 rectangle. So I think we have to make helper functions: RECT ToFill(RECT r) { ++r.right; ++r.bottom; return r; } RECT ToFillLP(LPRECT lpr) { RECT r = *lpr; return ToFill(r); } LPRECT LPToFill(RECT r) { ++r.right; ++r.bottom; return &r; } LPRECT LPToFillLP(LPRECT lpr) { RECT r = *lpr; return LPToFill(r); } So that: 1. Drawing with FillRect will be correct. 2. We can forget about FillRect's peculiar way of doing things. 3. We can concentrate on the actual rectangles. So instead of the above code, we do: RECT r; r.left = 10; r.top = 10; r.right = r.left + 50 - 1; r.bottom = r.top + 75 - 1; FillRect(hdc, LPToFill(r), hbr); What do you all think? Anyway, for LineTo we can just add "+ 1" at the arguments, no need for a helper function. __________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo

4 9

Re: wine/dlls/user button.c
by Dimitrie O. Paun 26 Oct '04

26 Oct '04

> The thing is that the old code wasn't entirely correct too. > Here is a test case + fix. Thanks a lot Dmitry, I got carried away with some other stuff. -- Dimi.

1 0

Problems downloading the RedHat packages
by Bill Medland 26 Oct '04

26 Oct '04

I am unable to download the RedHat 20041019 packages; any idea why? (Did they get built?) I can download a SuSE one (well, it at least asks me if I want to save it) but for all the Red Hat ones I've tried the mirror page keeps repeatedly coming up and it never actually tries to download. -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

3 2

Re: unaligned access bug in winspool on sparc
by Juan Lang 26 Oct '04

26 Oct '04

> I just ran across an evil little bug in the > WINSPOOL_GetPrinter_2 function. It looks like this > type of bug could be hiding in other API functions > too. It causes a segmentation fault because of an > unaligned access on Solaris (sparc). Yikes. That's a bad one. The trouble is MS loves this sort of return value. Even if the dll itself doesn't dereference an unaligned pointer, the caller might depending on how things are layed out. The trouble is i386 allows unaligned memory access, so we don't see this sort of thing. If you happen to know how MS handles alignment on platforms that require it, we might be able to fix it. Otherwise it'll have to be case-by-case I'm afraid. --Juan _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

4 4

Re: wine/dlls/user button.c
by Mike McCormack 25 Oct '04

25 Oct '04

Hi Dimi, The following hunk of the patch below breaks the IE install. You should be able to press Alt-A to accept the license in the first dialog, but with this hunk applied it no longer works. Mike Index: wine/dlls/user/button.c diff -u wine/dlls/user/button.c:1.2 wine/dlls/user/button.c:1.3 --- wine/dlls/user/button.c:1.2 Thu Oct 21 11:18:35 2004 +++ wine/dlls/user/button.c Thu Oct 21 11:18:35 2004 @@ -179,10 +224,13 @@ case WM_GETDLGCODE: switch(btn_type) { - case BS_PUSHBUTTON: return DLGC_BUTTON | DLGC_UNDEFPUSHBUTTON; - case BS_DEFPUSHBUTTON: return DLGC_BUTTON | DLGC_DEFPUSHBUTTON; - case BS_RADIOBUTTON: - case BS_AUTORADIOBUTTON: return DLGC_BUTTON | DLGC_RADIOBUTTON; + case BS_AUTOCHECKBOX: return DLGC_BUTTON | DLGC_WANTCHARS; + case BS_AUTORADIOBUTTON: return DLGC_RADIOBUTTON; + case BS_CHECKBOX: return DLGC_BUTTON | DLGC_WANTCHARS; + case BS_DEFPUSHBUTTON: return DLGC_DEFPUSHBUTTON; + case BS_GROUPBOX: return DLGC_STATIC; + case BS_PUSHBUTTON: return DLGC_UNDEFPUSHBUTTON; + case BS_RADIOBUTTON: return DLGC_RADIOBUTTON; default: return DLGC_BUTTON; } Alexandre Julliard wrote: > ChangeSet ID: 14031 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/10/04 23:11:13 > > Modified files: > dlls/user : button.c > > Log message: > Dimitrie O. Paun <dpaun(a)rogers.com> > Audit and document button code. > Change [GS]etWindowLong{,Ptr}A to [GS]etWindowLong{,Ptr}W. > Change WM_GETDLGCODE as per the MSDN documentation. > > Patch: http://cvs.winehq.org/patch.py?id=14031 > > Old revision New revision Changes Path > 1.2 1.3 +74 -26 wine/dlls/user/button.c > >

2 1

rsaenh [beware: 27kB attachment]
by Michael Jung 25 Oct '04

25 Oct '04

Hello, I've worked on an OpenSSL based implementation of rsaenh.dll in my spare time over the last three months. Although it is by no means complete, I feel that the coarse structure should be stable by now. The patch is appended to this mail as a gzipped tape archive. I'm aware that small patches are preferable, but I hope someone helps me to get this beast in: Please give me feedback on what remains to be done. If you want to try the patch note the following: - After you have applied the patch you have to run autoheader and autoconf. Then cd dlls ; make_dlls ; cd .. ; configure. - After you have compiled and installed wine, you have to unregister rsabase and register rsaenh (regsvr32 /U rsabase ; regsvr32 rsaenh). rsaenh.dll is meant to replace rsabase.dll sometime (Windows XP also has rsaenh.dll only). - This patch was tested with the attached regression tests and with some MSDN example code. No real application was tested until now. - This code is not secure! The user's persistent private RSA signature and key exchange key pairs are stored in the registry in _plaintext_. Do not use this with your homebanking application ;) - The code depends on CUR_BLOB_VERSION being defined in wincrypt.h. This is implemented in a distinct trivial patch, which I've submitted this morning and which will probably go into CVS tonight (that is if you live in germany ;) - You ain't see a whole lot, if you don't have the openssl headers installed (libssl-dev on debian). The code will compile without, but you'll get a lot of FIXME's and some of the regression tests will fail. Please excuse me for posting a 30kB message. Greetings, Michael

1 0

Problems With MSI
by Joaquín Fernández 25 Oct '04

25 Oct '04

Hello... i am having problems installing program with MSI Installer. When i launch setup.exe, the installer begin the process and when finish of copy files (progress bar is 100%), stay in endless loop. I ran serveral programs using MSI installer but nothing, all hangs at end of copy files. I tested it with WINEDLLOVERRIDES="msi,msiexec.exe=n" too but is equal. Some dll override or other thing? Regards Joaquín P.D.: Wine 20040914 & Mandrake Linux 10.1 Community -- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.4 (GNU/Linux) mQFCBEFI/gARAwDd2+ojasT3rCyRktSw+Ix3m+yoxSD0NkpMLlunmJxwvn6wKZVl mDw76/Zu9mqDWWeSGdSl+60T7fDLrJZSEB45O9T5jdujj01GFeer7xuiuHBTFw8o CXqD/hzhqYc46ecAoIQQjZ2qZtOWLPRBbegK/nyOIguNAv9QGiKPLBS8o0ksxEUp EfLAExVmu6Zp693uKGf6XrBWNcLriuwRPr1mjy3N/bhMlqc3vcTeUBwxiUuX5h2P NQgB3d2AbJS6oEvhmZL0Bn/8Ij/MSvVrartmCXuw9eSx0aMC/R7Kw9TtUfxFVUGx fQKwoA9BXNElPLcNohbBS/fH87IMMxCJyn+rmTeNCEcUEQ7UgvVCdlzZ8+L4PdlH qGR81nhZVEwPRnSSesLpSHRC1QQVoceBeb7PICr/b2eZiKMX+bQ+Sm9hcXXDrW4g TWFudWVsIEZlcm7DoW5kZXogUXVpbGVzIDxqb2FxdWluQGNhc2FkZWFsYWJhbnph Lm9yZz6IXgQTEQIAHgUCQUj+AAIbAwYLCQgHAwIDFQIDAxYCAQIeAQIXgAAKCRBH 677/q7xL4e15AJwNfSpeaXXMH2EjuKblfeBe51MrUgCcCP5jEnpXrDXLWULIW5yD t6VdHlU= =a8BM -----END PGP PUBLIC KEY BLOCK-----

1 0

Re: WSCEnumProtocols, was _SHExpandEnvironmentStrings() should return input string if no % found to expand?
by Rolf Kalbermatter 25 Oct '04

25 Oct '04

James Hawkins wrote: >> No, it will work. The cast probably there because the original author >> didn't want to write two functions. Instead he added a bool to the >> internal function that specifies whether the buffer is unicode or >> not. The cast is then needed to keep the compiler happy. > >The fact that the structures have a string in them is one issue that >you're ignoring. You can't make a cast from a unicode to an ansi >string just by casting. You have to call RtlMultiByteToWideChar to >convert it. This isn't a problem here since the helper function which is called has as last parameter a boolean telling it if the structure should be interpreted as the ANSI or Unicode version. While this may look asthetically wrong it is technically correct as long as the strings are embedded as pointers instead of inlined. There is a string inlined in the structure but it is at the end of the structure only so even there it is not necessarily a problem although the internal helper function needs to take extra care to get it right and in that it might be a better idea to just implement the Unicode version and convert for the ANSI one. >The major problem that you're ignoring is that you're >casting from one kind of struct to another, and they aren't the same. >The cast wont work. You would have to individually pull out the >relevant fields into a new PROTOCOL_INFO struct like I said in the >last post. If by original author I'm assuming you're talking about >the author of the spec file. In which case, there was only one >function in the spec file to begin with, because all functions only >have one in the spec file originally until someone stubs out that >function and finds out that it needs and A and a W...which is why I >didn't want my patch committed. This would be indeed the real problem if it was the case, but (from my SDK headers): int WSPAPI WSCEnumProtocols(IN LPINT lpiProtocols, OUT LPWSAPROTOCOL_INFOW lpProtocolBuffer, IN OUT LPDWORD lpdwBufferLength, OUT LPINT lpErrno); int WSAAPI WSAEnumProtocolsA(IN LPINT lpiProtocols, OUT LPWSAPROTOCOL_INFOA lpProtocolBuffer, IN OUT LPDWORD lpdwBufferLength); There is no ANSI version defined for the WSC function. This means either of two things: It is on all versions of Windows Unicode or it is very much like many Shell functions really ANSI on non NT systems while NT systems implement it as Unicode. Seeing that MSDN claims this to be supported on even Win95 I tend to believe the second one but only tests will show. The fact that modern SDK headers don't contain any indication of ANSI support means nothing as Microsoft has removed support for developing Win9x application from many SDK headers and MSDN. The problem seems to me rather that even the WSAEnumProtocols function casts the WSAPROTOCOL_INFOA/W structure pointer into PROTOCOL_INFOA and since they have indeed a completely different layout we are basically causing big trouble. I doubt that WSAEnumProtocols ever did work properly unless MS has at some point changed the second parameter of the function. Once this has been fixed, the implementation as suggested by Hans should actually work fine. Rolf Kalbermatter

1 0

Re: Fully Revised Wine User Guide Introduction
by Francois Gouget 25 Oct '04

25 Oct '04

On Mon, 25 Oct 2004, Francois Gouget wrote: > On Fri, 22 Oct 2004, Scott Ritchie wrote: > [...] >> Unlike my previous patch, this one should be properly formatted, > > It still had very long lines. So here's a line-wrapped version of the patch: > > Changelog: > > * documentation/introduction.sgml > > Scott Ritchie <scott(a)open-vote.org> > Revised Wine User Guide Introduction Sorry for this. I was without Internet access for a while and our emails crossed. Hmmm, I wonder... does this double the chances of the patch getting accepted?<g> -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

1 0

d3drs_multisampleantialias: check for it?
by Devils Cry 24 Oct '04

24 Oct '04

Hi again... :/ ^^ So im now moving for the multisampleantialias call... ive found the gl_multisample_arb function to be matching, so far, so good. Now while googling for it i only found code examples which check whether multisampling is supported before it is activated. My question: do i need this? I found no other call in the d3d8lib which asks for its extension the way i found it (http://nehe.gamedev.net/data/lessons/lesson.asp?lesson=46). Theres also another problem: the multisampling has to be turned off after its done, turned on again if something is drawn and after this turned off again (at least i understood it that way...). Is it enough to simply turn it on? And if not, how should i do this??? Thx in advance Nikolas

2 1

Re: _SHExpandEnvironmentStrings() should return input string if no % found to expand?
by Hans Leidekker 24 Oct '04

24 Oct '04

On Sunday 24 October 2004 01:35, James Hawkins wrote: > The reason why I said to ignore this patch is because there has to be > both an A and a W version of it. I'm pretty sure that this cast: No, I believe this is an exception. I assume that the spec file is correct in that there are no A and W versions of this function in shell32, it's just WSCEnumProtocols(). > (PROTOCOL_INFOA *)buffer > from a LPWSAPROTOCOL_INFOW structure isn't going to work. No, it will work. The cast probably there because the original author didn't want to write two functions. Instead he added a bool to the internal function that specifies whether the buffer is unicode or not. The cast is then needed to keep the compiler happy. > WSAPROTOCOL_INFO and PROTOCOL_INFO don't even have the same fields: No, but WSCEnumProtocols() wants WSAPROTOCOL_INFOW structures, just like WSAEnumProtocolsW(). Quote from MSDN: int WSCEnumProtocols( LPINT lpiProtocols, LPWSAPROTOCOL_INFOW lpProtocolBuffer, LPDWORD lpdwBufferLength, LPINT lpErrno ); -Hans

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel