wine-devel

wine-devel@winehq.org

11 participants
84461 discussions

Toolbar control Messages causing WM_PAINT
by Thorsten Kani 21 Oct '04

21 Oct '04

I did a quick check of ToolbarMessages that cause WM_PAINT instantly: TB_CHANGEBITMAP TB_CHECKBUTTON TB_DELETEBUTTON TB_ENABLEBUTTON TB_INDERTERMINATE TB_MARKBUTTON TB_PRESSBUTTON TB_SETBITMAPSIZE TB_SETBUTTONSIZE TB_SETBUTTONWIDTH TB_SETCOLOSCHEME TB_SETIMAGELIST TB_SETINDENT TB_SETINSERTMARK TB_SETMAXTEXTROWS TB_SETSTATE I left some the remaining ToolbarMessages untestet because i did not know how to send them correcty with controlspy. other Messages showing up and caused Paint: WM_UNKNOWN(128) WM_CHILDACTIVATE WM_ERASEBKGND WM_MOUSELEAVE(borders) probably this is not everything you need. (: Tho

1 0

Winecfg resources
by David Kredba 21 Oct '04

21 Oct '04

Hello all. There are disabled other than English resources in the wincfg.rc file. I finished tranlating resources to the Czech language and want to enable it. Why are non English resources commented out ? Thanks, David -- David Kredba <kredba at ibot.cas.cz> GPG: ID 1024D/5B6B02DE Fingerprint: F0B3312596BEDCF91DFB 0699E06AACD75B6B02DE

2 1

Re: [wineD3D] HW Vertex Buffer
by Ann and Jason Edmeades 21 Oct '04

21 Oct '04

Hiya, Re your new patch... -#define IWineD3DDevice_CreateVertexBuffer(p,a,b,c,d,e,f) (p)->lpVtbl->CreateVertexBuffer(p,a,b,c,d,e,f) +#define IWineD3DDevice_SetFVF(p,a) (p)->lpVtbl->SetFVF(p,a) +#define IWineD3DDevice_GetFVF(p,a) (p)->lpVtbl->GetFVF(p,a) +#define IWineD3DDevice_CreateVertexDeclaration(p,a,r) (p)->lpVtbl->CreateVertexDeclaration(p,a,r) +#define IWineD3DDevice_SetVertexDeclaration(p,a) (p)->lpVtbl->SetVertexDeclaration(p,a) +#define IWineD3DDevice_GetVertexDeclaration(p,a) (p)->lpVtbl->GetVertexDeclaration(p,a) +#define IWineD3DDevice_CreateVertexShader(p,a,r) (p)->lpVtbl->CreateVertexShader(p,a,r) +#define IWineD3DDevice_SetVertexShader(p,a) (p)->lpVtbl->SetVertexShader(p,a) +#define IWineD3DDevice_GetVertexShader(p,a) (p)->lpVtbl->GetVertexShader(p,a) +#define IWineD3DDevice_CreatePixelShader(p,a,r) (p)->lpVtbl->CreatePixelShader(p,a,r) +#define IWineD3DDevice_SetPixelShader(p,a) (p)->lpVtbl->SetPixelShader(p,a) +#define IWineD3DDevice_GetPixelShader(p,a) (p)->lpVtbl->GetPixelShader(p,a) +#define IWineD3DDevice_CreateVertexBuffer(p,a,b,c,d,e,f) (p)->lpVtbl->CreateVertexBuffer(p,a,b,c,d,e,f) +#define IWineD3DDevice_BindVertexBuffer(p,a) (p)->lpVtbl->BindVertexBuffer(p,a) +#define IWineD3DDevice_UnbindVertexBuffer(p,a) (p)->lpVtbl->UnbindVertexBuffer(p,a) Some of these are defining functions which dont exist yet in wined3d, which will get confusing. Additionally, the functionality for the wined3d vertex buffer is almost untested, because its just copying code and ensuring it gets driven. The d3d9 -> wined3d support isnt enough to prove your changes actually work, and I would rather we didnt put in untested code during the migration phase. I'm finding it hard to keep track of where I am on the migration from d3d8 -> wined3d, so could I ask that you hold off this patch for a month or so, until I can get enought support into the wined3d library so you can prove the new code works. I could do with the d3d8, d3d9 and wined3d code staying fixed as I try to shuffle it all around. Once I get enough in wined3d to be able to prove parts of it work, and we are using it from both d3d8 and d3d9 then by all means put in this change. I'd also comment that this change is desperately needed as hardware buffer support should speed up the d3d support too. It seems odd to turn away new code, especially when hardly anyone else helps on the d3d side! Jason

2 2

msdn: d3drs_wrap[0-7] ???
by Ann and Jason Edmeades 21 Oct '04

21 Oct '04

As I understand it, there is texture states (D3DTSS_ADDRESSU/V/W) which map to the GL_WRAP_* states, and there is no direct mapping for the d3drs_* versions. I am not sure I understand the differences, but you would need to understand it before implementing it. BTW Any help on the d3d8/9 interfaces is very welcome - there's not enough people working on it (Nor the ddraw stuff either, come to that). I'm working on moving all the code from d3d8 into wined3d and calling from both d3d8/d3d9. It will probably take another month or so, but if patches could be held until it is complete I would appreciate it - I'm afraid of dropping or missing something as I go! Regards, Jason

2 1

msdn: d3drs_wrap[0-7] ???
by Devils Cry 21 Oct '04

21 Oct '04

Hi folks! Dunno why, but this list regrets my subscriptionrequests. Anyway, lets see if this gets through... Im currently working a bit on the d3d8 dll (i know there are currently heavy changes made, just creating some new interfaces) and am now focusing on the d3drs_wrap[0-7] function. I have some problems understanding what it should do, from msdn: [quote] D3DRS_WRAP0 [ie, its the same for wrap0 to 7] Texture-wrapping behavior for multiple sets of texture coordinates. Valid values for this render state can be any combination of the D3DWRAPCOORD_0 (or D3DWRAP_U), D3DWRAPCOORD_1 (or D3DWRAP_V), D3DWRAPCOORD_2 (or D3DWRAP_W), and D3DWRAPCOORD_3 flags. These cause the system to wrap in the direction of the first, second, third, and fourth dimensions, sometimes referred to as the s, t, r, and q directions, for a given texture. The default value for this render state is 0 (wrapping disabled in all directions). [/quote] My current thoughts are to enable the GL_TEXTURE_WRAP_S, T and R functions by the value passed to it (ie for 2 enable the S and T wrappers), but i guess this isnt exactly what it should do. Any thoughts, ideas, guesses? BTW, i havent found anything matching the D3DWRAPCOORD_3 flag (should be the 4th dimension). Is there something i can use for this? Thx in advance Nikolas

2 1

msdn: d3drs_wrap[0-7] ???
by Devils Cry 21 Oct '04

21 Oct '04

Hi folks! Im currently working a bit on the d3d8 dll (i know there are currently heavy changes made, just creating some new interfaces) and am now focusing on the d3drs_wrap[0-7] function. I have some problems understanding what it should do, from msdn: [quote] D3DRS_WRAP0 [ie, its the same for wrap0 to 7] Texture-wrapping behavior for multiple sets of texture coordinates. Valid values for this render state can be any combination of the D3DWRAPCOORD_0 (or D3DWRAP_U), D3DWRAPCOORD_1 (or D3DWRAP_V), D3DWRAPCOORD_2 (or D3DWRAP_W), and D3DWRAPCOORD_3 flags. These cause the system to wrap in the direction of the first, second, third, and fourth dimensions, sometimes referred to as the s, t, r, and q directions, for a given texture. The default value for this render state is 0 (wrapping disabled in all directions). [/quote] My current thoughts are to enable the GL_TEXTURE_WRAP_S, T and R functions by the value passed to it (ie for 2 enable the S and T wrappers), but i guess this isnt what it should do. Any thoughts, ideas, guesses? BTW, i havent found anything matching the D3DWRAPCOORD_3 flag (should be the 4th dimension). Is there something i can use for this? Thx in advance Nikolas

1 0

Re: shell32: shlfileop; Add resource for renaming files on collision (patch 2)
by Tobias Burnus 21 Oct '04

21 Oct '04

Hello, Rolf Kalbermatter wrote: > + IDS_COPY_X_OF_TEXT "Kopie%svon %s" > + IDS_COPY_X_OF_TEXT "Copy%sof %s" I may miss something, but I think there is are space missing around the first '%s'. Tobias

1 0

RE: Treeview +/-
by Ge van Geldorp 21 Oct '04

21 Oct '04

> From: Jon Griffiths > > Hi, > > Fixing my own FIXME. > > Cheers, > Jon > > +wine/dlls/comctl32/treeview.c > Draw +/- correctly for large icon sizes (patch applied here: http://www.winehq.org/hypermail/wine-cvs/2004/10/0115.html) I can see that this would be an improvement for large icon sizes, but I don't think it's good for small icon sizes. See attached screenshot of regedit. Maybe the height/width at which to switch to the Rectangle drawing algorithm needs a bit of tuning? Ge van Geldorp.

1 0

scroll bars not shown
by Nicolai Kuntze 21 Oct '04

21 Oct '04

Hi, in the application given in Bug 2302 are in some menus the scroll bars missing. I think the programm gets wrong dimensions from the size of the window. I do not have enough experience to track the bug by myself. Can someone please have a look on it? I have tried with the latest CVS checkout and comctrl32 as an native library. Yours, Nicolai ---- Diese Nachricht wurde auf Viren und andere gefaehrliche Inhalte sowie Spam untersucht.

1 0

Wine on OpenBSD
by Sascha Hanse 21 Oct '04

21 Oct '04

Hi people, I just tried to install the recent Wine-tarball (20041019) on my OpenBSD 3.6. First I had to remove kthread.c:275: the RFTHREAD flag. Then the 'make depend && make' worked properly but the make install first fails with: /usr/bin/install -c serialui.dll.so /usr/local/lib/wine/serialui.dll.so cd `dirname setupapi/__install__` && make install gcc -g -O2 -o install install.c install.c:23: windef.h: No such file or directory install.c:24: winbase.h: No such file or directory install.c:25: winreg.h: No such file or directory install.c:26: winternl.h: No such file or directory install.c:27: winerror.h: No such file or directory install.c:28: wingdi.h: No such file or directory install.c:29: winuser.h: No such file or directory install.c:30: winnls.h: No such file or directory install.c:31: setupapi.h: No such file or directory install.c:33: wine/unicode.h: No such file or directory install.c:34: wine/debug.h: No such file or directory *** Error code 1 Stop in /home/sensei/wine-20041019/dlls/setupapi. *** Error code 1 Stop in /home/sensei/wine-20041019/dlls (line 416 of Makefile). *** Error code 1 Stop in /home/sensei/wine-20041019 (line 301 of Makefile). After that I copied all needed headerfiles into dlls/setupapi/ and finally I got these errors: [SNIP] /tmp//ccU25700.o(.text+0x18d1): In function `InstallHinfSectionW': /home/sensei/wine-20041019/dlls/setupapi/install.c:927: undefined reference to `SetupOpenInfFileW'/tmp//ccU25700.o(.text+0x18e1):/home/sensei/wine-200 41019/dlls/setupapi/install.c:930: undefined reference to `SetupInitDefaultQueueCallback'/tmp//ccU25700.o(.text+0x18f0):/home/sen sei/wine-20041019/dlls/setupapi/install.c:931: undefined reference to `SetupDefaultQueueCallbackW'/tmp//ccU25700.o(.text+0x1912):/home/sensei /wine-20041019/dlls/setupapi/install.c:934: undefined reference to `SetupTermDefaultQueueCallback'/tmp//ccU25700.o(.text+0x1918):/home/sen sei/wine-20041019/dlls/setupapi/install.c:935: undefined reference to `SetupCloseInfFile'/tmp//ccU25700.o(.text+0x193e): In function `InstallHinfSectionA':/home/sensei/wine-20041019/dlls/setupapi/install. c:950: undefined reference to `RtlCreateUnicodeStringFromAsciiz'/tmp//ccU25700.o(.text+0x195f):/home/ sensei/wine-20041019/dlls/setupapi/install.c:953: undefined reference to `RtlFreeUnicodeString'/tmp//ccU25700.o(.rodata+0x80): In function `get_field_string':/home/sensei/wine-20041019/dlls/setupapi/install.c:9 8: undefined reference to `__wine_dbch_setupapi' collect2: ld returned 1 exit status*** Error code 1 Stop in /home/sensei/wine-20041019/dlls/setupapi. *** Error code 1 Stop in /home/sensei/wine-20041019/dlls/setupapi. *** Error code 1 Stop in /home/sensei/wine-20041019/dlls (line 416 of Makefile). *** Error code 1 Stop in /home/sensei/wine-20041019 (line 301 of Makefile). Please CC me because I'm not subscribed to the list. -Sascha -- Anyone who considers arithmetical methods of producing random digits is, of course, in a state of sin. --John von Neumann (1951)

2 1

Re: Tiny optimizations of bit testing operations
by Rein Klazes 21 Oct '04

21 Oct '04

On Wed, 20 Oct 2004 19:48:05 +0900, you wrote: > Hello, > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Tiny optimizations of bit testing operations. Testing with gcc 3.3.5: > - BOOL min_or_max_box = (wndPtr->dwStyle & WS_MAXIMIZEBOX) || > - (wndPtr->dwStyle & WS_MINIMIZEBOX); > + BOOL min_or_max_box = wndPtr->dwStyle & (WS_MAXIMIZEBOX | WS_MINIMIZEBOX); At moderate optimization levels (-O1) gcc compiles this to identical code. > - if((wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) != 0) > + if (wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) At any optimization level, gcc compiles this to identical code. > if ((wndPtr->dwStyle & WS_VSCROLL) && > - ((((wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) != 0) && (ptClient.x <= rcClient.left + GetSystemMetrics(SM_CXVSCROLL))) || > - (((wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) == 0) && (ptClient.x >= rcClient.right - GetSystemMetrics(SM_CXVSCROLL))))) > + (((wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) && (ptClient.x <= rcClient.left + GetSystemMetrics(SM_CXVSCROLL))) || > + (!(wndPtr->dwExStyle & WS_EX_LEFTSCROLLBAR) && (ptClient.x >= rcClient.right - GetSystemMetrics(SM_CXVSCROLL))))) Not different then the previous example. >From the C point of view these bit logics are identical. The compiler finds that out easy. Rein. -- Rein Klazes rklazes(a)xs4all.nl

4 4

IE6: Help Engine Sputtering, Main Engine Doesn't Start, Segmentation Fault
by Dan McGhee 21 Oct '04

21 Oct '04

At the outset I must apologize for the length of this post. This situation is intricately convoluted and, currently, I cannot interpret the information that I have collected. Right now I can only relay information that I think is relevant. I would be more than happy to generate more info, but I will need some specific direction for commands and so forth. Right now I have reached the limit of my current troubleshooting skills. My overall goal is to get Edit Studio 4, a video editing application, running in wine. It depends on the IE6 Help Engine. There are other situations with this app and that's why I don't depend on an older version of wine to run it. Right now, if I can't get IE6 to run its help engine, I can't get my app to work. Here goes on my problems with IE6. Conventions: 1013 implies wine compiled from the cvs update on October 13 and a .wine, created from that update aug implies wine version compiled from the cvs update on October 13 and a .wine from a wine version, compiled from my repository, before the 20040824 16:00:16 CDT commit Symptoms: 1. with wine from 1013 and .wine from 1013, IE6 exits with no window--this started sometime after the September snapshot 2. with wine from 1013, any version of wine that I compile, and .wine from aug, IE6 runs and Help works 3. with wine from September snapshot and .wine from 1013, IE6 creates a segmentation fault My original symptom was that I couldn't get IE6 Help to work after the September snapshot. I did a regression and identified the commit of 20040824 16:00:16 CDT as causing the problem. The commit edits this patch: http://cvs.winehq.org/patch.py?id=13475 Among other things this patch changes wine/dlls/Makefile.in wine/configure.ac wine/configure it also changes itss.dll. However, my symptoms still persist whether I use a native or builtin version of itss. I include this information because I don't know if the symptoms are separate problems or are related. I am not able to pin point the cause of Symptom 1 because I do not yet know how to update my repository to do a regression. I must wait for the archive after the October snapshot. I have reasoned, since I can get IE6 to work completely using a ~/.wine created before that August commit, that the problem lies somewhere in the "fake windows" directory. There are differences in the registry, win.ini and system.ini files, but I do not know how to diagnose them. The following excerpt, from one of the logs I created, shows that there is a completely different sequence, between the working and non-working situations, when shell32 loads for the first time: trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\shell32.dll" : builtin -trace:loaddll:MODULE_FlushModrefs Unloaded module L"c:\\windows\\system\\shell32.dll" : builtin -trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\shell32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\ole32.dll" : native trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\BROWSEUI.dll" : native err:shell:ReadCabinetState Initializing shell cabinet settings trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\browselc.dll" : native -trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\RPCRT4.DLL" : native +trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\shdoclc.dll" : native +err:rebar:REBAR_WindowProc unknown msg 200b wp=00000000 lp=71180f00 +trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\uxtheme.dll" : builtin +trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\RPCRT4.dll" : native +trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\lz32.dll" : builtin +trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\version.dll" : builtin +trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\urlmon.dll" : native trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\MSOSS.dll" : native trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\CRYPT32.dll" : native trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\OLEAUT32.dll" : native trace:loaddll:load_dll Loaded module L"C:\\windows\\system\\WININET.dll" : native I stopped the excerpt here because this is the point at which the non-working situation exits. I have generated a log from +relay "grepped" for shell32 but do not know how to interpret it to see if I can glean any more information. This log and all the others are contained in the tarball that I have attached. It creates a directory called "wine-trouble" and contains all the information that I have generated. The README contains specifics of what I have done. As I was composing the README for inclusion here, I realized that I had not done two things. I forgot to copy shell and shell32 to my fake windows directory so that all of my tests were conducted with builtin shell and shell32. Additionally, I have not run wine compiled before the August commit with a fake windows created on October 13. I will do both of these and see if I get differenet results. I'm really interested in resolving this and would rather that I had been able to supply better information. However, my knowlege of winedbg, windows and cvs does not currently allow me to proceed further. If anyone wants me to do more, I would appreciate being pointed in the right direction, but I will need some specifics. I have found no documentation on any of the wine mailing lists or other forums to indicate that anyone else is having this problem. It could be something that I am doing. This is why I haven't yet submitted a bug report. If a bug report would be more appropriate, I will do that. Thanks, Dan

1 1

Re: [wineD3D] HW Vertex Buffer
by Raphael 21 Oct '04

21 Oct '04

Hi again, A better patch than previous Changelog: - beta implementation of HW Vertex Buffer support (using ARB_vertex_buffer_object): locking/unlocking, creation, destruction - some wined3d headers/interface extension Todo - Bind/Unbind on rendering (use exported APIs, see IWineD3DDevice_BindVertexBuffer/IWineD3DDevice_UnbindVertexBuffer) Regards, Raphael

1 0

wine developer guide
by Eric Pouech 20 Oct '04

20 Oct '04

While looking at the WDG (and please don't count me in about arguing whether it's WDG or WD'sG or WD'G), I came onto the Advanced Topics book after the two big ones ("Developing Wine" and "Wine Architecture") I does seem very odd to me as it right now: - it just contains "random" bits of information on some parts of wine - we don't have (yet) a uniform way to qualify something of advanced So my proposal would be to: - get rid of "Advanced Topics" book altogether, and keep only "Developing Wine" (the way we'd like development going on) and "Wine architecture" (the way it works - or it's supposed to) - move the various items from "Advanced Topics" to where they belong (see below) - maybe tag in both the "developing" and "architecture" books which parts are really advanced (change of font, specific paragraph type... pick up the visual effect you like most) The mapping that could be done would be: 14.1 Keyboard => Architecture/X11DRV DLL 14.2 Undocumented API => somewhere in the "developing" chapter 14.3 accelerators => Architecture/USER32.DLL 14.4 HW trace => somewhere in the "developing" chapter (likely in debugging) 15 Porting to new OS => somewhere in the "developing" chapter (likely in writing patches, to be renamed as "coding practice" or so) 16 Consoles => Architecture/KERNEL32.DLL 17 Address space => Architecture/6.3.4 (as advanced material) 18 Regression testing => somewhere in the "developing" chapter (in conformance tests) Likewise, the 5.1 about adding new languages could be moved into the "coding practice" part. If noone objects, I'll submit the changes. A+

1 0

Stack overflows
by Robert Lunnon 20 Oct '04

20 Oct '04

I have been trying to make wine work properly with Solaris xlib and have been experiencing a few stack overflow exceptions eg 0009:Ret kernel32._LeaveSysLevel() retval=00000000 ret=7f86a7ba 0009:Ret user32.USER_Unlock() retval=00000000 ret=7f53f837 0009:Call ntdll.RtlEnterCriticalSection(7f579840) ret=7f549249 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=7f549249 0009:Call ntdll.RtlLeaveCriticalSection(7f579840) ret=7f54926a 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=7f54926a 0009:Call ntdll.RtlEnterCriticalSection(7f579840) ret=7f549249 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=7f549249 err:seh:setup_exception stack overflow 0 bytes in thread 0009 eip ca096003 esp 7fc11000 stack 7fc10000-7fd10000 As I recall PE executables specify the stack size in the PE header so in the past I have used a little windows utility under wine to increase the stack allocation to the program, sometimes with mixed results. I Thought I'd post here to find out if this is known problem and what the cause is. I had presumed it was probably due to the extra call layering through xlib adding too much overhead to the stack for the app. Assuming this is the issue there were two actions I was looking at taking 1. A Wine utility to adjust the stack allocation for the executable 2. Adjust the stack allocation in wine to allow a little extra for wine over and above that requested by the app. Opinions ? Bob

1 0

Reimplementing SHGetFolder functions
by Juan Lang 20 Oct '04

20 Oct '04

Any reason this patch wasn't applied? http://www.winehq.org/hypermail/wine-patches/2004/10/0167.html I know it's big, but I hope the test cases help demonstrate its correctness. Let me know if there's anything else I can do to help a review. Thanks, --Juan __________________________________ Do you Yahoo!? Yahoo! Mail Address AutoComplete - You start. We finish. http://promotions.yahoo.com/new_mail

2 1

Re: Startmenu
by Robert Shearman 20 Oct '04

20 Oct '04

Thorsten Kani wrote: > Nice Patch - looks good now! > i have changed the offsets and used SM_CXBORDER instead of SM_CXEDGE. > (According to MSDN, cxedge is used for 3D while cxborder is used for > Flat ) > This seems to fix the"draw below" issue. Visual Experience comes now > really near native. > > I noticed that SM_CXEDGE is used everywhere, regardless of Style > TBSTYLE_FLAT. > Please review my attached Patch. It seems to me that this Stylechecks > shoud be used everywhere. I don't think this is correct. If you change the return value for GetSystemMetrics(SM_CXEDGE) in wine/windows/sysmetrics.c then you can see that it does affect the spacing between border and icon (but our toolbar control doesn't exactly match the native for this). > As for String position issue, maybe i can help out with the controlspy > check. > Im interested in understanding the controls and wanted to play around > with CSpy anyway. > Suggestions ? You can download controlspy here: http://www.microsoft.com/msj/0798/controlspy.aspx It is very useful for throwing messages at the common controls, but it cannot test custom draw functionality and it is becoming dated (it is missing new functionality from comctl32 v5.80 and new controls). Rob

2 2

Re: dlls/x11drv/winpos.c::SWP_DoOwnedPopups()
by Dmitry Timoshkov 20 Oct '04

20 Oct '04

"Peter Riocreux" <par+wine_patches(a)silistix.com> wrote: > The comment above SWP_DoOwnedPopups in dlls/x11drv/winpos.c suggests > that the only thing missing is what I *might* have fixed here, > therefore the patch also removes the FIXME and the WARN. It compiles > and doesn't break any behaviour I can test, but I am only guessing > whether I have done the right thing. You have to write a test case and add it to existing ones in dlls/user/tests/win.c to confirm that the patch is correct. -- Dmitry.

2 3

DrawTextA: regarding the nCount variable
by William Poetra Yoga H 20 Oct '04

20 Oct '04

In the MSDN, it is stated that if nCount is 1, then it is assumed that lpString is a null-terminated string. But in the DrawTextExA function, it is -1, as in the code: if (count == -1) count = strlen(str); Shouldn't this be 1 instead of -1? CMIIW. (But theForger's tutorial also uses -1) _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

3 3

Re: ADVAPI32: implement ChangeServiceConfigA using ChangeServiceConfigW (take 2)
by Robert Shearman 20 Oct '04

20 Oct '04

Mike McCormack wrote: > > oops. The macro functions for duplicating strings already exist, so > use them instead. > > Mike > > > ChangeLog: > * implement ChangeServiceConfigA using ChangeServiceConfigW > >------------------------------------------------------------------------ > >Index: dlls/advapi32/service.c >=================================================================== >RCS file: /home/wine/wine/dlls/advapi32/service.c,v >retrieving revision 1.60 >diff -u -r1.60 service.c >--- dlls/advapi32/service.c 27 Sep 2004 20:35:27 -0000 1.60 >+++ dlls/advapi32/service.c 20 Oct 2004 07:28:54 -0000 >@@ -810,7 +810,8 @@ > > static inline VOID SERV_free( LPWSTR wstr ) > { >- HeapFree( GetProcessHeap(), 0, wstr ); >+ if (wstr) >+ HeapFree( GetProcessHeap(), 0, wstr ); > } > > There is no need for this check. Freeing NULL pointers is not an error and is handled by the RtlFreeHeap code. Rob

1 0

Re: fix tbn_deletingbutton
by Dmitry Timoshkov 19 Oct '04

19 Oct '04

"Thorsten Kani" <beebix(a)gmx.net> wrote: > I'm a bit unsure about my solution, but actually everything works. > -complaints appreciated- > --- toolbar.c 23 Sep 2004 22:51:14 -0000 1.194 > +++ toolbar.c 10 Oct 2004 17:29:01 -0000 > @@ -3191,12 +3191,20 @@ > TOOLBAR_INFO *infoPtr = TOOLBAR_GetInfoPtr (hwnd); > INT nIndex = (INT)wParam; > NMTOOLBARW nmtb; > + WCHAR Buffer[256]; > > if ((nIndex < 0) || (nIndex >= infoPtr->nNumButtons)) > return FALSE; > > memset(&nmtb, 0, sizeof(nmtb)); > nmtb.iItem = nIndex; > + memcpy(&nmtb.tbButton, &infoPtr->buttons[nIndex], sizeof(nmtb.tbButton) ); > + nmtb.cchText = 256; > + nmtb.pszText = Buffer; > +#if (_WIN32_IE >= 0x500) > + nmtb.rcButton =(RECT)infoPtr->buttons[nIndex].rect; > +#endif > + > TOOLBAR_SendNotify((NMHDR *)&nmtb, infoPtr, TBN_DELETINGBUTTON); 1. do not use _WIN32_IE version checks in Wine code, they have no sense 2. there is no point in setting a pointer to a not initialized buffer 3. there is no need to cast RECT to a RECT -- Dmitry.

3 8

Re: add epoll implementation to libwine_port (take 3)
by Chris Dodd 19 Oct '04

19 Oct '04

Mike McCormack <mike(a)codeweavers.com> wrote in news:4174D681.9050503@codeweavers.com: > A few more changes after consulting with Alexandre. > > ChangeLog: > * add epoll implementation to libwine_port : > + __asm__ __volatile__( "pushl %%ebx; movl %2,%%ebx; int $0x80; popl > %%ebx" + : "=a" (ret) : "0" : A random question here from someone who is not too familiar with wine internals -- why are you using inline asm code instead of syscall(2)? It seems like syscall would be both simpler and more portable. Chris Dodd cdodd(a)acm.org

1 0

Re: add epoll implementation to libwine_port (take 3)
by Boaz Harrosh 19 Oct '04

19 Oct '04

Mike McCormack wrote: > > > ChangeLog: > * add epoll implementation to libwine_port > >.... > > >+ __asm__ __volatile__( "pushl %%ebx; movl %2,%%ebx; int $0x80; popl %%ebx" > > Grate ! [Q] Does that mean that we directly check if it is supported in kernel, bypassing glibc all together? how do we avoid conflicts with glibc?

4 5

dlls/x11drv/winpos.c::SWP_DoOwnedPopups
by Peter Riocreux 19 Oct '04

19 Oct '04

I have a lot of WARNs from this function so I thought I would have a shufty at it to see if it was easy to fix. The FIXME above it is written so as to suggest that it is a matter of mere keystrokes to fix it up, or weeks of work, depending on your frame of mind when you read it. Still being a beginner (first patch now committed be Aj - yay!) and not knowing about Windows programming, I don't know where to look to decide which is the case. The comment above it says: /*********************************************************************** * SWP_DoOwnedPopups * * fix Z order taking into account owned popups - * basically we need to maintain them above the window that owns them * * FIXME: hide/show owned popups when owner visibility changes. */ It looks like, depending on some property of 'owner' it should or shouldn't use the property SWP_HIDEWINDOW in the call to SetWindowPos <http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winu…> If this is the case I could fix it, if I knew how to determine when 'owner' is visible. Do I also need a callback of some kind so that the popup is rendered invisible when the parent is, even if SWP_DoOwnedPopups is not called (or is that not (supposed to be) possible?)? Is the WARN there only because of the FIXME and if I fix the FIXME I should remove the WARN? Peter

1 1

Re: wine/dlls/ntdll time.c
by Dimitrie O. Paun 19 Oct '04

19 Oct '04

On Mon, Oct 18, 2004 at 04:19:29PM -0500, Alexandre Julliard wrote: > Log message: > Rein Klazes <rklazes(a)xs4all.nl> > In RtlQueryTimezoneInformation use information from the registry if it > is available. > > Patch: http://cvs.winehq.org/patch.py?id=14188 Hmm, shouldn't we synch up with the Unix env instead? I assume this info is available in the Unix env... This would be preferable even in the case of a shared Windows install, me thinks. -- Dimi.

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel