wine-devel

wine-devel@winehq.org

11 participants
84461 discussions

CreateFile GENERIC_WRITE on a directory
by ScratchMonkey 19 Oct '04

19 Oct '04

Not sure if this should be in -users, but I'm trying to get the Tribes: Vengeance dedicated server going (1st person shooter) and it stops with a messagebox that it can't write to its own directory. Tracing the program with +relay reveals this: 000b:Call kernel32.CreateFileW(10415fc0 L"Z:\\home\\vengeance\\Server \\Program\\Bin\\",40000000,00000007,00000000,00000003,02000000,00000000) ret=1015b46d 000b:Call ntdll.RtlIsDosDeviceName_U(10415fc0 L"Z:\\home\\vengeance\\Server \\Program\\Bin\\") ret=554b4506 000b:Ret ntdll.RtlIsDosDeviceName_U() retval=00000000 ret=554b4506 000b:Call ntdll.RtlDosPathNameToNtPathName_U(10415fc0 L"Z:\\home\\vengeance \\Server\\Program\\Bin\\",559bebb0,00000000,00000000) ret=554b42c7 000b:Ret ntdll.RtlDosPathNameToNtPathName_U() retval=00000001 ret=554b42c7 000b:Call ntdll.NtCreateFile (559beba4,40000000,559bebb8,559beba8,00000000,00000000,00000007,00000001,00 004010,00000000,00000000) ret=554b438f 000b:Ret ntdll.NtCreateFile() retval=c00000ba ret=554b438f 000b:Call ntdll.RtlNtStatusToDosError(c00000ba) ret=554b43bd 000b:Ret ntdll.RtlNtStatusToDosError() retval=00000005 ret=554b43bd 000b:Call ntdll.RtlFreeUnicodeString(559bebb0) ret=554b43cc 000b:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=554b43cc 000b:Ret kernel32.CreateFileW() retval=ffffffff ret=1015b46d Decoding the parameters to CreateFile show it trying to open the directory for GENERIC_WRITE. I'm about to dig into the wine sources but am hoping someone can spot the problem more quickly than me. I'm using the 20040914 source RPM from NewRPMs.

2 3

Re: Turn off Antialiasing for Rendering with Palette
by Alexandre Julliard 19 Oct '04

19 Oct '04

Glenn Wurster <gwurster(a)scs.carleton.ca> writes: > Description: > * When we are working with a palette, we need to disable antialiasing. > Antialiasing results in a lot of extra colour values which are not > mapped in the palette, causing bad display artifacts. > > Changelog: > * Disable antialiasing when working with the palette You shouldn't change the global antialias flag, this is ugly and it will most likely break the font caching. You have to add checks for a palette directly at the places that handle the anti-aliasing (and your palette check is wrong too, you shouldn't peek into the internals of the DC bitmap). -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Server: Create and Use New mem_free Function
by Alexandre Julliard 19 Oct '04

19 Oct '04

Robert Shearman <rob(a)codeweavers.com> writes: > We have our own mem_alloc memory allocator, so this patch adds the a > new free function, mem_free, and replaces instances of free with > mem_free. At the moment, the implementation completely defers to the > libc free function, but it makes sense to have this new function so > that we can easily change memory allocators. The patch also changes a > few instances of malloc to mem_alloc. You cannot do that, mem_alloc sets the error code but malloc doesn't, they are not the same thing. The purpose of mem_alloc is to simplify handling of allocation failures in common cases, it's not a general replacement for malloc. If you really want to change the memory allocator you can redefine malloc and free, but I'm not sure why you'd want to do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

oleaut32: SafeArrayDestroyData
by Walt Ogburn 18 Oct '04

18 Oct '04

Hi, I am working on getting a scientific / engineering application called SRIM (www.srim.org), specifically the batch-mode component SRModule of SRIM 2003. This is a Visual Basic program, so there's lots of reliance on oleaut32.dll. In addition to freeing the data memory of the SafeArray, Wine's implementation of SafeArrayDestroyData sets the pointer pvData to NULL. The native Windows version apparently does not do this, and SRIM depends on pvData still pointing to the same place afterwards. Wine's code also uses this nulling to keep track of the memory, so that it won't get freed again. I can't say why a program would still want pvData after a call to SafeArrayDestroyData, but there it is. Could the flag FADF_DATADELETED be used to keep track of this instead? That seems to be the case only for vector SafeArrays now. The following patch seems to make SRIM work: =================================================================== Index: dlls/oleaut32/safearray.c =================================================================== RCS file: /home/wine/wine/dlls/oleaut32/safearray.c,v retrieving revision 1.40 diff -u -r1.40 safearray.c --- dlls/oleaut32/safearray.c 20 Sep 2004 19:11:48 -0000 1.40 +++ dlls/oleaut32/safearray.c 18 Oct 2004 17:03:51 -0000 @@ -1254,7 +1254,7 @@ if (psa->cLocks) return DISP_E_ARRAYISLOCKED; /* Can't delete a locked array */ - if (psa->pvData) + if (psa->pvData && !(psa->fFeatures & FADF_DATADELETED)) { /* Delete the actual item data */ if (FAILED(SAFEARRAY_DestroyData(psa, 0))) @@ -1265,7 +1265,8 @@ { if (!SAFEARRAY_Free(psa->pvData)) return E_UNEXPECTED; - psa->pvData = NULL; + /* psa->pvData = NULL; */ + psa->fFeatures |= FADF_DATADELETED; } else psa->fFeatures |= FADF_DATADELETED; /* Mark the data deleted */ =================================================================== Also, is there a way to make the tests in oleaut32/tests/ run on the native dlls? If so, I could more clearly show that the Windows version doesn't null pvData. Thanks, Walter

2 2

Re: x11drv: Add stretching support to AlphaBlend
by Huw D M Davies 18 Oct '04

18 Oct '04

On Sun, Oct 17, 2004 at 10:34:28PM -0400, Kevin Koltzau wrote: > Changelog: > Add stretching support to AlphaBlend XRenderSetPictureTransform is a relatively new addition to libxrender, arriving just before XFree 4.3. I don't think we want the whole xrender stuff to fail if this specific function isn't available in the library. Could you make the presence of this function optional and simply skip the stretched AlphaBlend if it's not there? Huw.

1 0

-fPIC on link line in winegcc for HPUX
by Warren_Baird/CSI＠cimmetry.com 18 Oct '04

18 Oct '04

Hi all, Another change I had to make for HPUX that I'm not 100% sure about: The HPUX linker gets quite unhappy unless the gcc link line inside of winegcc is fed -fPIC. The problem is that the collect2 phase builds it's own temporary object file that gets included in the final link, and if that temp .o file isn't compiled with -fPIC, the HP linker complains. In order to get this to work, I had to add -fPIC to the list of link flags that winegcc recognizes: diff -ur patched/wine-20040914/tools/winegcc/winegcc.c wine-20040914/tools/winegcc/winegcc.c --- patched/wine-20040914/tools/winegcc/winegcc.c 2004-10-12 10:28:37.000000000 -0400 +++ wine-20040914/tools/winegcc/winegcc.c 2004-10-12 10:10:07.000000000 -0400 @@ -616,7 +616,7 @@ { "-nostartfiles", "-nodefaultlibs", "-nostdlib", "-s", "-static", "-static-libgcc", "-shared", "-shared-libgcc", "-symbolic", - "-framework" + "-framework", "-fPIC" }; int j; The question: is this going to be harmful on other platforms? I'm not sure whether I should protect it with ifdefs, or just leave it as is. Any suggestions? Thanks, Warren

3 6

Re: Resend: Honor --disable-debug or --disable-trace completely
by Alexandre Julliard 18 Oct '04

18 Oct '04

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > wine/debug.h has some tests based on NO_{DEBUG,TRACE}_MSGS, which is set > (or not) in config.h. Quite a few files didn't #include config.h before > wine/debug.h, so some debugmsgs were always compiled in, even with > ./configure --disable-debug. > > Now maybe we want to install config.h as well, as debug.h is already > installed. I'll leave that one to Alexandre. No, the right fix is to put these defines in the Makefile and get rid of them in config.h. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: MinGW portability fix
by Hans Leidekker 18 Oct '04

18 Oct '04

On Sunday 17 October 2004 16:16, Hans Leidekker wrote: > Changelog: > Add configure check for getpagesize() declaration, needed by MinGW. Hmm, I just found that the AC_CHECK_DECL macro doesn't work as expected. You can skip this patch. -Hans

1 0

Re: [wine] Re: window caption buttons
by William Poetra Yoga H 18 Oct '04

18 Oct '04

--- David Lee Lambert <lamber45(a)cse.msu.edu> wrote: > On Wed, Oct 13, 2004 at 08:31:37AM -0700, William Poetra Yoga Hadisoesen > wrote: > > --- Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> wrote: > > > > If it really makes a functional difference, then I guess it should be > fixed, > > > otherwise why not leave it as is? > > > 1. Developers coming from Windows can have the same "look and feel". This > > increases their productivity, although indirectly. When people see > something > > different but similar to the one they see everyday, their attention will be > > divided to the new object and the work they are doing. And their motivation > to > > work will decrease, too, if the GUI doesn't get fixed. > > Once in a while on Windows, I tweak the desktop fonts and colors a little > bit just so it doesn't get boring. I've made document backgrounds > off-white; changed the menu font; even done a little bit with Active > Desktop on some boxes. An off-by-one error in a terminal emulator that > lets it only display 79 columns needs to be fixed, but I'd rather we kept > little oddities like this. Yeah, you've got a point there. But then wouldn't it be better if we start off emulating the "standard" win9x style, and then create themes and stuff? Just like reactos: they start by trying to be nt4.0-compatible, but have plans to do win2k. Or xpde: they start with the win2k shell and add the winxp features later ;) > > 2. Windows users looking at WINE will reject it straight away, because it > > doesn't look like a "professionaly-made" software, and maybe mocking it as > a > > carelessly written software, with sloppy GUI. Remember, some users become > > developers. > > I don't aggree with this either. "Professional" apps on Windows these > days go out of their way to look fancy, do their own drawing, be a > little bit different than Windows. (I know these have better alternatives > on Linux but) look at MusicMatch Jukebox, WinAmp, RealPlayer, Windows > Media Player, AOL, Kodak Photo Editor... these apps have all their own > icons anyway. The Win3.1->Win95 or WinNT->WinXP UI jump is already bigger > than that from Wine to the average of all versions it matches, in terms > of things like this. Yes, there are inconsistencies between Windows versions, and between some programs and programs which use the "standard" ui. It's true that there are many professional programs which draw their own windows. But have you looked more closely at WINE's window decorations? They're like Windows 95's, but they're somewhat different. I think it's better (and more appealing to the eye) if we were to define a theme (WINE theme) that looks at least obviously different from the Windows shell. It's because when we draw things so similar -- yet different -- to things found in Windows, people won't like it. It's like, doing a (sorry, just a comparison) fake thing that's similar to the original. If you have lived in China, you can find fake Nike's everywhere, for example. Or fake Yonex shuttlecocks. They're not so much different from the original, but they still look... odd. It's one reason people won't buy them. And one more thing, is that I've found numerous off-by-one bugs in the ui part (that draws buttons, decorations, etc), just by attacking the "caption buttons" problem. I know they're off-by one bugs because they don't look right :( I'm not a good programmer, and I don't know how the Windows UI work, so if I'm left to fix the UI bugs there would be little or no wastage of resources, it will make me learn, and also make WINE look better. So I think it should be okay for me to "fix" the buttons (and numerous bugs I find along the way). _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

1 0

Re: UCS2 vs. UTF16 question
by Shachar Shemesh 18 Oct '04

18 Oct '04

Hi Juan, I took the liberty of answering to the list. I hope you don't mind. Juan Lang wrote: >Hi Schachar, something you said earlier this year at >wineconf caught my ear, and I think I'm finally >understanding enough to ask about it. You said >Windows uses UCS2-LE (I think you did, anyway) rather >than UTF16. Is that true? > I most certainly didn't say that. I may have mentioned UCS4, but to the best of my knowledge at the time, Windows uses UTF-16. As a result of your email, I tried to check it again, however. The results are somewhat inconclusive. I generated a file (attached) containing two musical symbols in Unicode. These are from the codepoints above U10000, and are therefor unrepresentable in UCS2. Opening this file up in notepad reveals a mixed result. On the one hand, they appear as two unknown characters (which seems to suggest that at least Notepad understands this is UTF-16LE). On the other hand, I did not manage to find any font that has any characters with codepoints above U10000. I'm hoping one of our far-eastern speakers jumps in with more insight (Mike?). Are surrogates used on Windows? How common are they? > Does that then imply that >Windows really can't handle characters outside the >Basic Multilingual Plane? Does that also imply that >WCHARs are in fact fixed-width in Windows? > > As far as I know, they are not. Sorry. >I'm planning to write a tool to detect the following >problematic bit of code: >char str[] = "hi", *p = str + sizeof(str) - 1; >p--; >At least, it's problematic when str contains >double-byte characters. > I'm not sure what you are aiming at achieving. Are you trying to hit the beginning of the last character of the string? If so, then you do, indeed, have a problem here. > If the type of char and p >were WCHAR * instead, and WCHARs are fixed width, >there isn't a problem. > >If you have thoughts on similar programming bugs >relating to internationalization (use of strchr and >strrchr, for example) I'd be interested to hear them. > > In the past I have written programs that had to do MBCS (the non-unicode Japanese encoding). This is an encoding in which some characters are one byte, and some two. The best I could come up with was to build a wrapper around std::string that had two bytes per character internally. When you loaded a string, it would check character by character for whether it's a double byte, and then have each string location contain exactly one character. This allowed random access, as well as both forward AND backwards scanning. Fortunately, UTF is much better than MBCS. Given a byte in either UTF-8 or UTF-16, it's fairly easy to figure out whether it's part of a surrogate, and what part. If you have assurance that the string you are handling is a well formed one, you can do backward scans of a UTF string fairly easily. >Thanks, >--Juan > >_______________________________ >Do you Yahoo!? >Declare Yourself - Register online to vote today! >http://vote.yahoo.com > > Do you want a gmail account? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Wineconf 2005
by Jeremy White 18 Oct '04

18 Oct '04

Hey Folks, It's that time again, time to plan for another Wineconf. There has been some back room chatter about Wineconf this year, but no definitive plans. A small cabal of people (myself included) think that we should hold it in Southern Germany around February/March. Marcus and Michael have each expressed that they might be able to get a facility to hold it in, but those efforts have so far not yielded anything definitive (I think we're tied up in big company red tape). Also, Huw Davies has offered to help host Wineconf in Oxford; that essentially translates into an offer by CodeWeavers to host Wineconf in mid March in Oxford. However, I want to throw this open to discussion and see if others have great ideas or if someone outside our secret cabal wants to step up and make this happen in Southern Germany. Based on our experience last year, I feel pretty strongly that we need the following: 1. An inexpensive, yet easy to reach location. Connection to nice places to visit before/after is a plus, but should be a substantially secondary consideration imo. 2. Two rooms that can each hold about 30-40 people, ideally with white boards, power, and high speed internet. 3. Access to food and hotels, preferably all within walking distance of each other. Since Europe is civilized, we should be able to walk from our Hotel to the conference, to a variety of food sources, and then, of course, to the pub. Candidly, I don't know that this is all that complicated. We'll likely be bringing enough people in that we should be able to negotiate a pretty nice deal with a Hotel. (We promise them xxx heads in beds, they give us conference facilities for a weekend). If someone wanted to help host Wineconf, and was willing to facilitate a conversation between myself and a Hotel that was well situated, CodeWeavers would be happy to sponsor the conference (i.e. financially reassure the Hotel). Thoughts? Comments? Cheers, Jeremy

4 5

Re: Make TranslateAcceleratorA handle national characters
by Dmitry Timoshkov 18 Oct '04

18 Oct '04

"Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > Make TranslateAcceleratorA handle national characters. Please ignore this patch, it apparently corrupts original msg structure but it shouldn't. I'll send a new patch tomorrow. -- Dmitry.

1 0

Re: [PATCH] setkey breaks FreeBSD
by Mike Hearn 18 Oct '04

18 Oct '04

Anish Mistry wrote: > The attached patch fixes a CVS build problem with confilicting setkey in the > stdlib.h header. It's changed to WINE_setkey. I've gone ahead and changed > getkey to match. Aesthetics wise, I'd rather it was renamed to eg setcfgkey or something - there are no WINE_ prefixes in winecfg and none are needed, I'd rather keep it that way. thanks -mike

3 3

Re: ez-cdda sleep
by Mike Hearn 18 Oct '04

18 Oct '04

>> - storing context in server while entering USR1 signal handler (to be >> done without races, which will require some more work, as the server >> doesn't synchronize with the USR1 handler) I've implemented this in my local tree, and it works fine: Easy CD-DA gets further now. It is still being nailed by the copy protection system (called "Armadillo" apparently) but the splash screen appears now :) Today the BT engineer reconnected our line. So, now I just have to wait for ADSL to be activated, then I can flush my patch queue and get back to some real work. To eliminate the race at the top of SIGUSR1 handler I made server get_thread_context/set_thread_context RPCs fail with STATUS_RETRY if the context has not yet been uploaded, and adjusted the ntdll code to spin in a loop yielding the timeslice whenever it receives STATUS_RETRY. It's not fancy but it works, and on average only 1 yield is needed (obvious in hindsight I guess). The SIGCONTEXT is reloaded when the context override is cancelled, so set_thread_context on a suspended thread works as expected. thanks -mike

1 0

Problem using winelib
by Ross Quinlan 18 Oct '04

18 Oct '04

Hello, This is my first try with winelib ... I'm running RedHat 7.3. I've downloaded the wine source (wine-20040914) and built everything using ./tools/wineinstall. I'm trying the winemine example in the winelib doc. I've copied the .c, .h, and .rc files to a new directory winemine2 and in that directory I've run winemaker as follows: E> winemaker --lower-uppercase . Winemaker 0.6.0 Copyright 2000 Francois Gouget <fgouget(a)codeweavers.com> for CodeWeavers Scanning the source directories... Fixing the source files... dialog.c main.c De.rc En.rc Es.rc Fr.rc It.rc Nl.rc Pl.rc Pt.rc Ru.rc Si.rc rsrc.rc dialog.h main.h resource.h Generating project files... . This generates one new file, "Makefile" (no Makefile.in, configure) so I can't run ./configure --with-wine etc. If I try a simple make, here's the result: E> make all winebuild -o winemine2.exe.dbg.c --debug -C. dialog.c main.c winegcc -c -mno-cygwin -I. -o winemine2.exe.dbg.o winemine2.exe.dbg.c winegcc -c -mno-cygwin -I. -o dialog.o dialog.c winegcc -c -mno-cygwin -I. -o main.o main.c wrc -I. -foDe.res De.rc De.rc:22:21: Error: parse error make: *** [De.res] Error 1 I'm therefore contacting this address as suggested in the winemaker documentation. Any help for a complete novice would be appreciated! Regards, Ross

3 2

Fwd: Re: Fwd: Re: about a book I'm thinking of writing
by Wesley Parish 18 Oct '04

18 Oct '04

This is in relation to an idea I had a few months ago. Bruce Perens stated that he didn't see any future at present for a book on ReactOS, but he would definitely be interested in a book on Win internals, from one of the Wine developers. Is there anyone on this list who'd be interested? FWIW, I'd be willing to edit, if necessary. (That's something I'm not unfamiliar with.) Wesley Parish ---------- Forwarded Message ---------- Subject: Re: Fwd: Re: about a book I'm thinking of writing Date: Mon, 18 Oct 2004 13:53 From: Alexandre Julliard <julliard(a)winehq.org> To: Wesley Parish <wes.parish(a)paradise.net.nz> Wesley Parish <wes.parish(a)paradise.net.nz> writes: > I wrote an email to Bruce Perens on doing something for the ReactOS > project, and he sent me this reply. Do you think there'd be anyone in the > Wine HQ who'd be interested and capable of writing a book on the Wine > internals a la "Inside Windows NT" or "VAX/VMS Internals and Data > Structures", or suchlike? I don't know of anyone, but you may want to ask this on the wine-devel list. -- Alexandre Julliard julliard(a)winehq.org ------------------------------------------------------- -- Wesley Parish * * * Clinersterton beademung - in all of love. RIP James Blish * * * Mau e ki, "He aha te mea nui?" You ask, "What is the most important thing?" Maku e ki, "He tangata, he tangata, he tangata." I reply, "It is people, it is people, it is people."

1 0

Appdb - Add 'Delete' button to comments when the user is an admin
by Chris Morgan 18 Oct '04

18 Oct '04

This patch adds a delete button to comments when the user is an admin. It will need to be modified slightly when application maintainers are added to appdb. The hope is that we can start to clear the stale comments out of the database to increase the signal-to-noise. After deleting the comment the parentId of the child comments are adjusted to be the parentId of the deleted comment. I'm still a php rookie, comments, questions are welcome ;-) Chris

1 0

Re: Temporary fix to trying to put a pointer in a DWORD
by Dmitry Timoshkov 17 Oct '04

17 Oct '04

"Vincent Béron" <vberon(a)mecano.gme.usherb.ca> wrote: > We try to put a pointer in a DWORD in a static initialization of > CRITICAL_SECTION_DEBUGs. Of course it doesn't work on Win64. We'll have > to find a better solution though. Another way to fix it is to use full 'DWORD Spare[2]' to store a pointer on Win64 and leave it as it is now for Win32. -- Dmitry.

3 4

Re: Fix various function prototypes
by Rolf Kalbermatter 17 Oct '04

17 Oct '04

Vincent Béron wrote: >MSDN says it's void >http://msdn.microsoft.com/library/default.asp?url=/library/en- >us/shellcc/platform/shell/reference/functions/shcocreateinstance.asp > >I don't have latest PSDK. > >This will need to be investigated some more (although I'm leaning >towards HRESULT). My own tests seem to indicate that the function really returns some codes which are consistent with HRESULTs. Also my SDK (from February 2003) declares the functions as SHSTDAPI which is an abbreviation for "extern HRESULT __stdcall". So MSDN seems to be wrong here and besides returning them anyhow in the implementation eventhough some clients may ignore them based on MSDN documentation seems the correct way to me! Rolf Kalbermatter

1 0

Re: Enable _WIN64
by Robert Shearman 17 Oct '04

17 Oct '04

Vincent Béron wrote: >Index: wine/dlls/oleaut32/oaidl_p.c >=================================================================== >RCS file: /home/wine/wine/dlls/oleaut32/oaidl_p.c,v >retrieving revision 1.4 >diff -u -r1.4 oaidl_p.c >--- wine/dlls/oleaut32/oaidl_p.c 7 Oct 2004 03:06:49 -0000 1.4 >+++ wine/dlls/oleaut32/oaidl_p.c 16 Oct 2004 04:50:00 -0000 >@@ -11119,7 +11119,7 @@ > }; > > >-#if !defined(__RPC_WIN32__) >+#if !defined(__RPC_WIN32__) && !defined(__RPC_WIN64__) > #error Invalid build platform for this stub. > #endif > > > oaidl.idl needs to be regenerated from a newer MIDL that knows about Win64 instead of this hack. Rob

1 0

Re: Fix various function prototypes
by Robert Shearman 17 Oct '04

17 Oct '04

Vincent Béron wrote: >SHCoCreateInstance returns void, not HRESULT. >Some functions had a different prototype than their declaration. > >Changelog: >Fix various function prototypes. > > Some of these are wrong if we want binary compatibility with Windows 64-bit because e.g.: sizeof(unsigned long) on linux != sizeof(unsigned long) on Windows If a parameter to a function is "unsigned long" then we will have to change it to "ULONG" instead. Rob

1 0

Re: Freetype portability fix for older versions - improved
by Rein Klazes 17 Oct '04

17 Oct '04

On 15 Sep 2004 11:17:10 -0400, you wrote: > Tested on both freetype 2.1.2 and freetype 2.1.4. > > Changelog: > Use the preferred FT_ENCODING values rather than ft_encoding. > > +#ifndef FT_ENCODING_NONE > +#define FT_ENCODING_NONE ft_encoding_none > +#endif > +#ifndef FT_ENCODING_MS_SYMBOL > +#define FT_ENCODING_MS_SYMBOL ft_encoding_symbol > +#endif > +#ifndef FT_ENCODING_UNICODE > +#define FT_ENCODING_UNICODE ft_encoding_unicode > +#endif > +#ifndef FT_ENCODING_APPLE_ROMAN > +#define FT_ENCODING_APPLE_ROMAN ft_encoding_apple_roman > +#endif The patch works, but is not quite correct and doing the opposite of what you claim: the FT_ENCODING's are never defined but are enums. Therefore "ifndef FT_ENCODING_XYZ" is always true and you always use the depreciated ft_encodings. On old freetype2: enum FT_Encoding { ft_encoding_xyz, ... On Newer freetype2: enum FT_Encoding { FT_ENCODING_XYZ, ... #define ft_encoding_xyz FT_ENCODING_XYZ So to use FT_ENCODING_XYZ in the code and still compile with older freetype2's, we need to test: #ifndef ft_encoding_xyz Patch attached, tested to compile with freetype 2.0.9 and 2.1.7. Changelog: dlls/gdi : freetype.c Test whether the ft_encoding's are defined, not the FT_ENCODING's. Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

Re: winesetuptk0.72/tcltk-winesetuptk-0.72
by Ivan Leo Puoti 17 Oct '04

17 Oct '04

> /tcltk-winesetuptk-0.72/build.sh Winesetuptk isn't maintained any more, and it isn't needed to configure wine. Why do you need it? Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: Honor --disable-debug or --disable-trace completely
by Vincent Béron 17 Oct '04

17 Oct '04

Le sam 16/10/2004 à 22:29, Vincent Béron a écrit : > (Yes, the patch is gzip as it's over 200k) > > wine/debug.h has some tests based on NO_{DEBUG,TRACE}_MSGS, which is set > (or not) in config.h. Quite a few files didn't #include config.h before > wine/debug.h, so some debugmsgs were always compiled in, even with > ./configure --disable-debug. > > Now maybe we want to install config.h as well, as debug.h is already > installed. I'll leave that one to Alexandre. > > Changelog: > Force inclusion of config.h before wine/debug.h. Don't commit yet, make depend fails (config.h has been added to some includes in some dirs). I'll resend. Vincent

1 0

Re: Use LLP64 compatible sized-types for LONG and DWORD
by Dmitry Timoshkov 17 Oct '04

17 Oct '04

"Vincent Béron" <vberon(a)mecano.gme.usherb.ca> wrote: > Changelog: > Change the type of LONG and DWORD to be int based instead of long based > for Win64 compatibility. It would be cleaner IMO to use that only when compiling with _WIN64 defined, that would avoid affecting the Win32 target. -- Dmitry.

2 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel