wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: Directx9
by Ivan Leo Puoti 13 Sep '04

13 Sep '04

> At *some* point we have to stop simply releasing CVS snapshots which may > or may not work/run important apps/eat your hard disk and actually do > proper releases that are, you know, tested'n'stuff. Also consider that the time wasted on testing/releasing/branching will slow up wine development, whoever would be doing that could certanly work on the wine code itself. I fully agree with what Joerg Mayer says, the time has not yet come. Ivan.

1 0

Re: Directx9
by Ivan Leo Puoti 13 Sep '04

13 Sep '04

>Anyway, that wasn't really what I was getting at.. last spring Lionel >had this to say about a wined3d library: It does make sense to have common code all in the same place... Ivan.

1 0

dlls/winsock/socket breakage
by Gerald Pfeifer 13 Sep '04

13 Sep '04

The following change revision 1.155 date: 2004/09/07 20:47:03; author: julliard; state: Exp; lines: +113 -0 Roderick Colenbrander <thunderbird2k(a)gmx.net> - set ipx packet type - add support for retrieving some ipx info breaks FreeBSD 4.10 quite a bit: /sw/gcc-3.3.4/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DUSE_WS_PREFIX -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o socket.o socket.c socket.c: In function `WS2_send': socket.c:1120: error: `SOL_IPX' undeclared (first use in this function) socket.c:1120: error: (Each undeclared identifier is reported only once socket.c:1120: error: for each function it appears in.) socket.c:1120: error: `IPX_TYPE' undeclared (first use in this function) socket.c:1123: error: structure has no member named `sipx_type' socket.c: In function `WS_getsockopt': socket.c:1585: error: `SOL_IPX' undeclared (first use in this function) socket.c:1585: error: `IPX_TYPE' undeclared (first use in this function) socket.c: In function `WS_setsockopt': socket.c:2312: error: `SOL_IPX' undeclared (first use in this function) socket.c:2312: error: `IPX_TYPE' undeclared (first use in this function) gmake: *** [socket.o] Error 1 Concerning the error in socket.c, line 1120, SOL_IPX is not defined on FreeBSD 4.10, but there is a constant SOL_SOCKET which is supposed to be passed as the second parameter of getsockopt with the following description: "To manipulate options at the socket level, level is specified as SOL_SOCKET". Would that do the job? Concerning the error in socket.c, line 1123, struct sockaddr_ipx looks as follows on FreeBSD 4.10: struct sockaddr_ipx { u_char sipx_len; u_char sipx_family; struct ipx_addr sipx_addr; char sipx_zero[2]; }; Finally, I could not find anything remotely similiar to IPX_TYPE. I hope this will allow you to fix this breakage? (To check for FreeBSD, you can use #ifdef __FreeBSD_...) Thanks, Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

3 7

Re: Shwapi updates
by James Hawkins 13 Sep '04

13 Sep '04

Can this patch be broken up into smaller, independent parts? It's more likely to be committed if that is the case. On Sun, 12 Sep 2004 08:55:27 -0700 (PDT), Jon Griffiths <jon_p_griffiths(a)yahoo.com> wrote: > Cheers, > Jon > > +dlls/shlwapi/shlwapi.spec dlls/shlwapi/ordinal.c > Implement SHSimulateDrop > > +dlls/shlwapi/reg.c > Implement MIME_GetExtensionA/W > > +dlls/shlwapi/string.c > Implement StrCpyNXA/W, SHAnsiToAnsi, SHUnicodeToUnicode > > +dlls/shlwapi/tests/string.c > Test StrCpyNXA/W, SHAnsiToAnsi, SHUnicodeToUnicode > > ===== > "Don't wait for the seas to part, or messiahs to come; > Don't you sit around and waste this chance..." - Live > > jon_p_griffiths(a)yahoo.com > > > _______________________________ > Do you Yahoo!? > Shop for Back-to-School deals on Yahoo! Shopping. > http://shopping.yahoo.com/backtoschool > > > diff -ur wine/dlls/shlwapi/ordinal.c wine-develop/dlls/shlwapi/ordinal.c > --- wine/dlls/shlwapi/ordinal.c 2004-09-05 08:36:36.000000000 +0000 > +++ wine-develop/dlls/shlwapi/ordinal.c 2004-09-11 12:38:46.000000000 +0000 > @@ -1829,6 +1829,30 @@ > } > > /************************************************************************* > + * @ [SHLWAPI.186] > + */ > +BOOL WINAPI SHSimulateDrop(IDropTarget *pDrop, IDataObject *pDataObj, > + DWORD grfKeyState, PPOINTL lpPt, DWORD* pdwEffect) > +{ > + DWORD dwEffect = DROPEFFECT_LINK | DROPEFFECT_MOVE | DROPEFFECT_COPY; > + POINTL pt = { 0, 0 }; > + > + if (!lpPt) > + lpPt = &pt; > + > + if (!pdwEffect) > + pdwEffect = &dwEffect; > + > + IDropTarget_DragEnter(pDrop, pDataObj, grfKeyState, *lpPt, pdwEffect); > + > + if (*pdwEffect) > + return IDropTarget_Drop(pDrop, pDataObj, grfKeyState, *lpPt, pdwEffect); > + > + IDropTarget_DragLeave(pDrop); > + return TRUE; > +} > + > +/************************************************************************* > * @ [SHLWAPI.187] > * > * Call IPersistPropertyBag_Load() on an object. > @@ -3000,19 +3024,6 @@ > } > > /************************************************************************* > - * @ [SHLWAPI.346] > - */ > -DWORD WINAPI SHUnicodeToUnicode( > - LPCWSTR src, > - LPWSTR dest, > - int len) > -{ > - FIXME("(%s %p 0x%08x)stub\n",debugstr_w(src),dest,len); > - lstrcpynW(dest, src, len); > - return lstrlenW(dest)+1; > -} > - > -/************************************************************************* > * @ [SHLWAPI.350] > * > * See GetFileVersionInfoSizeW. > diff -ur wine/dlls/shlwapi/reg.c wine-develop/dlls/shlwapi/reg.c > --- wine/dlls/shlwapi/reg.c 2004-07-05 20:27:24.000000000 +0000 > +++ wine-develop/dlls/shlwapi/reg.c 2004-09-11 12:41:58.000000000 +0000 > @@ -1833,6 +1833,77 @@ > } > > /************************************************************************* > + * @ [SHLWAPI.330] > + * > + * Get the files extension for a given Mime type. > + * > + * PARAMS > + * lpszType [I] Mime type to get the file extension for > + * lpExt [O] Destingtion for the resulting extension > + * iLen [I] Length og lpExt in characters > + * > + * RETURNS > + * Success: TRUE. lpExt contains the file extension. > + * Failure: FALSE, if any paramater is invalid or the extension cannot be > + * retrieved. If iLen > 0, lpExt is set to an empty string. > + * > + * NOTES > + * - The extension returned in lpExt always has a leading '.' character, even > + * if the registry Mime database entry does not. > + * - iLen must be long enough for the file extension for this function to succeed. > + */ > +BOOL WINAPI MIME_GetExtensionA(LPCSTR lpszType, LPSTR lpExt, INT iLen) > +{ > + char szSubKey[MAX_PATH]; > + DWORD dwlen = iLen - 1, dwType; > + BOOL bRet = FALSE; > + > + if (iLen > 0 && lpExt) > + *lpExt = '\0'; > + > + if (lpszType && lpExt && iLen > 2 && > + GetMIMETypeSubKeyA(lpszType, szSubKey, MAX_PATH) && > + !SHGetValueA(HKEY_CLASSES_ROOT, szSubKey, szExtensionA, &dwType, lpExt + 1, &dwlen) && > + lpExt[1]) > + { > + if (lpExt[1] == '.') > + memmove(lpExt, lpExt + 1, strlen(lpExt + 1) + 1); > + else > + *lpExt = '.'; /* Supply a '.' */ > + bRet = TRUE; > + } > + return bRet; > +} > + > +/************************************************************************* > + * @ [SHLWAPI.331] > + * > + * Unicode version of MIME_GetExtensionA. > + */ > +BOOL WINAPI MIME_GetExtensionW(LPCWSTR lpszType, LPWSTR lpExt, INT iLen) > +{ > + WCHAR szSubKey[MAX_PATH]; > + DWORD dwlen = iLen - 1, dwType; > + BOOL bRet = FALSE; > + > + if (iLen > 0 && lpExt) > + *lpExt = '\0'; > + > + if (lpszType && lpExt && iLen > 2 && > + GetMIMETypeSubKeyW(lpszType, szSubKey, MAX_PATH) && > + !SHGetValueW(HKEY_CLASSES_ROOT, szSubKey, szExtensionW, &dwType, lpExt + 1, &dwlen) && > + lpExt[1]) > + { > + if (lpExt[1] == '.') > + memmove(lpExt, lpExt + 1, (strlenW(lpExt + 1) + 1) * sizeof(WCHAR)); > + else > + *lpExt = '.'; /* Supply a '.' */ > + bRet = TRUE; > + } > + return bRet; > +} > + > +/************************************************************************* > * @ [SHLWAPI.324] > * > * Set the file extension for a MIME content key. > diff -ur wine/dlls/shlwapi/shlwapi.spec wine-develop/dlls/shlwapi/shlwapi.spec > --- wine/dlls/shlwapi/shlwapi.spec 2004-09-05 08:36:36.000000000 +0000 > +++ wine-develop/dlls/shlwapi/shlwapi.spec 2004-09-11 12:42:10.000000000 +0000 > @@ -183,7 +183,7 @@ > 183 stdcall -noname SHRegisterClassA(ptr) > 184 stdcall @(ptr ptr long) SHLWAPI_184 > 185 stdcall -noname SHMessageBoxCheckA(ptr str str long long str) > -186 stub -noname SHSimulateDrop > +186 stdcall -noname SHSimulateDrop(ptr ptr long ptr ptr) > 187 stdcall -noname SHLoadFromPropertyBag(ptr ptr) > 188 stub -noname IUnknown_TranslateAcceleratorOCS > 189 stdcall -noname IUnknown_OnFocusOCS(ptr ptr) > @@ -327,8 +327,8 @@ > 327 stdcall -noname UnregisterExtensionForMIMETypeW(wstr) > 328 stdcall -noname GetMIMETypeSubKeyA(str ptr long) > 329 stdcall -noname GetMIMETypeSubKeyW(wstr ptr long) > -330 stub -noname MIME_GetExtensionA > -331 stub -noname MIME_GetExtensionW > +330 stdcall -noname MIME_GetExtensionA(str ptr long) > +331 stdcall -noname MIME_GetExtensionW(wstr ptr long) > 332 stdcall @(ptr long) user32.CallMsgFilterW > 333 stdcall -noname SHBrowseForFolderWrapW(ptr) > 334 stdcall -noname SHGetPathFromIDListWrapW(ptr ptr) > @@ -342,7 +342,7 @@ > 342 stdcall -noname SHInterlockedCompareExchange(ptr long long) > 343 stdcall -noname SHRegGetCLSIDKeyA(ptr str long long ptr) > 344 stdcall -noname SHRegGetCLSIDKeyW(ptr wstr long long ptr) > -345 stub -noname SHAnsiToAnsi > +345 stdcall -noname SHAnsiToAnsi(str ptr long) > 346 stdcall -noname SHUnicodeToUnicode(wstr ptr long) > 347 stdcall @(long wstr) advapi32.RegDeleteValueW > 348 stub -noname SHGetFileDescriptionW > diff -ur wine/dlls/shlwapi/string.c wine-develop/dlls/shlwapi/string.c > --- wine/dlls/shlwapi/string.c 2004-09-05 08:36:36.000000000 +0000 > +++ wine-develop/dlls/shlwapi/string.c 2004-09-11 12:43:37.000000000 +0000 > @@ -2098,7 +2098,7 @@ > * iLen [I] Maximum number of chars to copy > * > * RETURNS > - * Success: A pointer to the last character written. > + * Success: A pointer to the last character written to lpszDest.. > * Failure: lpszDest, if any arguments are invalid. > */ > LPSTR WINAPI StrCpyNXA(LPSTR lpszDest, LPCSTR lpszSrc, int iLen) > @@ -2623,6 +2623,48 @@ > } > > /************************************************************************* > + * @ [SHLWAPI.345] > + * > + * Copy one string to another. > + * > + * PARAMS > + * lpszSrc [I] Source string to copy > + * lpszDst [O] Destination for copy > + * iLen [I] Length of lpszDst in characters > + * > + * RETURNS > + * The length of the copied string, including the terminating NUL. lpszDst > + * contains iLen characters of lpszSrc. > + */ > +DWORD WINAPI SHAnsiToAnsi(LPCSTR lpszSrc, LPSTR lpszDst, int iLen) > +{ > + LPSTR lpszRet; > + > + TRACE("(%s,%p,0x%08x)\n", debugstr_a(lpszSrc), lpszDst, iLen); > + > + /* Our original version used lstrncpy/lstrlen, incorrectly filling up all > + * of lpszDst with extra NULs. This version is correct, and faster too. > + */ > + lpszRet = StrCpyNXA(lpszDst, lpszSrc, iLen); > + return lpszRet - lpszDst + 1; > +} > + > +/************************************************************************* > + * @ [SHLWAPI.346] > + * > + * Unicode version of SSHAnsiToAnsi. > + */ > +DWORD WINAPI SHUnicodeToUnicode(LPCWSTR lpszSrc, LPWSTR lpszDst, int iLen) > +{ > + LPWSTR lpszRet; > + > + TRACE("(%s,%p,0x%08x)\n", debugstr_w(lpszSrc), lpszDst, iLen); > + > + lpszRet = StrCpyNXW(lpszDst, lpszSrc, iLen); > + return lpszRet - lpszDst + 1; > +} > + > +/************************************************************************* > * @ [SHLWAPI.364] > * > * Determine if an Ascii string converts to Unicode and back identically. > diff -ur wine/dlls/shlwapi/tests/string.c wine-develop/dlls/shlwapi/tests/string.c > --- wine/dlls/shlwapi/tests/string.c 2004-07-21 12:17:03.000000000 +0000 > +++ wine-develop/dlls/shlwapi/tests/string.c 2004-09-11 12:47:14.000000000 +0000 > @@ -33,7 +33,12 @@ > #include "shlwapi.h" > #include "shtypes.h" > > -static HRESULT (WINAPI *ptr_StrRetToBSTR) (STRRET*, void*, BSTR*); > +static HMODULE hShlwapi; > +static LPSTR (WINAPI *pStrCpyNXA)(LPSTR,LPCSTR,int); > +static LPWSTR (WINAPI *pStrCpyNXW)(LPWSTR,LPCWSTR,int); > +static HRESULT (WINAPI *pStrRetToBSTR)(STRRET*,void*,BSTR*); > +static DWORD (WINAPI *pSHAnsiToAnsi)(LPCSTR,LPSTR,int); > +static DWORD (WINAPI *pSHUnicodeToUnicode)(LPCWSTR,LPWSTR,int); > > static inline int strcmpW(const WCHAR *str1, const WCHAR *str2) > { > @@ -592,22 +597,19 @@ > > static void test_StrRetToBSTR(void) > { > - HMODULE module; > static const WCHAR szTestW[] = { 'T','e','s','t','\0' }; > ITEMIDLIST iidl[10]; > BSTR bstr; > STRRET strret; > HRESULT ret; > > - module = GetModuleHandleA("shlwapi"); > - if (!module) return; > - ptr_StrRetToBSTR = (void *)GetProcAddress(module, "StrRetToBSTR"); > - if (!ptr_StrRetToBSTR) return; > + pStrRetToBSTR = (void *)GetProcAddress(hShlwapi, "StrRetToBSTR"); > + if (!pStrRetToBSTR) return; > > strret.uType = STRRET_WSTR; > strret.u.pOleStr = CoDupStrW("Test"); > bstr = 0; > - ret = ptr_StrRetToBSTR(&strret, NULL, &bstr); > + ret = pStrRetToBSTR(&strret, NULL, &bstr); > ok(ret == S_OK && bstr && !strcmpW(bstr, szTestW), > "STRRET_WSTR: dup failed, ret=0x%08lx, bstr %p\n", ret, bstr); > if (bstr) > @@ -615,7 +617,7 @@ > > strret.uType = STRRET_CSTR; > lstrcpyA(strret.u.cStr, "Test"); > - ret = ptr_StrRetToBSTR(&strret, NULL, &bstr); > + ret = pStrRetToBSTR(&strret, NULL, &bstr); > ok(ret == S_OK && bstr && !strcmpW(bstr, szTestW), > "STRRET_CSTR: dup failed, ret=0x%08lx, bstr %p\n", ret, bstr); > if (bstr) > @@ -624,7 +626,7 @@ > strret.uType = STRRET_OFFSET; > strret.u.uOffset = 1; > strcpy((char*)&iidl, " Test"); > - ret = ptr_StrRetToBSTR(&strret, iidl, &bstr); > + ret = pStrRetToBSTR(&strret, iidl, &bstr); > ok(ret == S_OK && bstr && !strcmpW(bstr, szTestW), > "STRRET_OFFSET: dup failed, ret=0x%08lx, bstr %p\n", ret, bstr); > if (bstr) > @@ -633,10 +635,85 @@ > /* Native crashes if str is NULL */ > } > > +static void test_StrCpyNXA(void) > +{ > + LPCSTR lpSrc = "hello"; > + LPSTR lpszRes; > + char dest[8]; > + > + pStrCpyNXA = (void *)GetProcAddress(hShlwapi, (LPSTR)399); > + if (!pStrCpyNXA) > + return; > + > + memset(dest, '\n', sizeof(dest)); > + lpszRes = pStrCpyNXA(dest, lpSrc, sizeof(dest)/sizeof(dest[0])); > + ok(lpszRes == dest + 5 && !memcmp(dest, "hello\0\n\n", sizeof(dest)), > + "StrCpyNXA: expected %p, \"hello\\0\\n\\n\", got %p, \"%d,%d,%d,%d,%d,%d,%d,%d\"\n", > + dest + 5, lpszRes, dest[0], dest[1], dest[2], dest[3], dest[4], dest[5], dest[6], dest[7]); > +} > + > +static void test_StrCpyNXW(void) > +{ > + static const WCHAR lpInit[] = { '\n','\n','\n','\n','\n','\n','\n','\n' }; > + static const WCHAR lpSrc[] = { 'h','e','l','l','o','\0' }; > + static const WCHAR lpRes[] = { 'h','e','l','l','o','\0','\n','\n' }; > + LPWSTR lpszRes; > + WCHAR dest[8]; > + > + pStrCpyNXW = (void *)GetProcAddress(hShlwapi, (LPSTR)400); > + if (!pStrCpyNXW) > + return; > + > + memcpy(dest, lpInit, sizeof(lpInit)); > + lpszRes = pStrCpyNXW(dest, lpSrc, sizeof(dest)/sizeof(dest[0])); > + ok(lpszRes == dest + 5 && !memcmp(dest, lpRes, sizeof(dest)), > + "StrCpyNXA: expected %p, \"hello\\0\\n\\n\", got %p, \"%d,%d,%d,%d,%d,%d,%d,%d\"\n", > + dest + 5, lpszRes, dest[0], dest[1], dest[2], dest[3], dest[4], dest[5], dest[6], dest[7]); > +} > + > +static void test_SHAnsiToAnsi(void) > +{ > + char dest[8]; > + DWORD dwRet; > + > + pSHAnsiToAnsi = (void *)GetProcAddress(hShlwapi, (LPSTR)345); > + if (!pSHAnsiToAnsi) > + return; > + > + memset(dest, '\n', sizeof(dest)); > + dwRet = pSHAnsiToAnsi("hello", dest, sizeof(dest)/sizeof(dest[0])); > + ok(dwRet == 6 && !memcmp(dest, "hello\0\n\n", sizeof(dest)), > + "SHAnsiToAnsi: expected 6, \"hello\\0\\n\\n\", got %ld, \"%d,%d,%d,%d,%d,%d,%d,%d\"\n", > + dwRet, dest[0], dest[1], dest[2], dest[3], dest[4], dest[5], dest[6], dest[7]); > +} > + > +static void test_SHUnicodeToUnicode(void) > +{ > + static const WCHAR lpInit[] = { '\n','\n','\n','\n','\n','\n','\n','\n' }; > + static const WCHAR lpSrc[] = { 'h','e','l','l','o','\0' }; > + static const WCHAR lpRes[] = { 'h','e','l','l','o','\0','\n','\n' }; > + WCHAR dest[8]; > + DWORD dwRet; > + > + pSHUnicodeToUnicode = (void *)GetProcAddress(hShlwapi, (LPSTR)346); > + if (!pSHUnicodeToUnicode) > + return; > + > + memcpy(dest, lpInit, sizeof(lpInit)); > + dwRet = pSHUnicodeToUnicode(lpSrc, dest, sizeof(dest)/sizeof(dest[0])); > + ok(dwRet == 6 && !memcmp(dest, lpRes, sizeof(dest)), > + "SHUnicodeToUnicode: expected 6, \"hello\\0\\n\\n\", got %ld, \"%d,%d,%d,%d,%d,%d,%d,%d\"\n", > + dwRet, dest[0], dest[1], dest[2], dest[3], dest[4], dest[5], dest[6], dest[7]); > +} > + > START_TEST(string) > { > CoInitialize(0); > > + hShlwapi = GetModuleHandleA("shlwapi"); > + if (!hShlwapi) > + return; > + > test_StrChrA(); > test_StrChrW(); > test_StrChrIA(); > @@ -656,4 +733,8 @@ > test_StrCmpA(); > test_StrCmpW(); > test_StrRetToBSTR(); > + test_StrCpyNXA(); > + test_StrCpyNXW(); > + test_SHAnsiToAnsi(); > + test_SHUnicodeToUnicode(); > } > > > -- James Hawkins

3 3

RE: patch: shell32.dll - SHELL_ArgifyW expands env-vars - HOLD PATCH
by Jens Collin 13 Sep '04

13 Sep '04

Please hold this patch and don't commit it yet. I've been told that it contains things to be checked first. /J -----Original Message----- From: wine-patches-admin(a)winehq.org [mailto:wine-patches-admin@winehq.org] On Behalf Of Jens Collin Sent: den 11 september 2004 21:47 To: wine-patches(a)winehq.org Subject: patch: shell32.dll - SHELL_ArgifyW expands env-vars Patch updated with correct string constants handling. thanks James and Alexandre. changelog: * lookup of envoronment-vars in SHELL_ArgifyW in shell32.dll added. (Such as %SystemRoot%).

1 0

(no subject)
by Ivan Leo Puoti 13 Sep '04

13 Sep '04

> For example, if DirectX is broken for 3 consecutive releases, I would expect > the people doing the release to label the old 'working' version and branch > from there if any bugs fixes are needed. Things in wine break all the time, users know it and are used to it, if d3d8 breaks for 3 releases, people will just use an old version until things are fixed. Many people stayed at wine-20031212 for months because of regressions that weren't fixed for a few months, but people just kept wine-20031212 and were happy. With alpha software this is quite normal. Ivan.

2 1

RE: Why is our OutputDebugString a server request?
by Raghavan Gurumurthy 13 Sep '04

13 Sep '04

I agree - I got stumped on this very issue when I got into Wine last year. I was used to relying on these trace messages and it took me a while to understand where the messages were actually being sent! //raghavan -----Original Message----- From: Shachar Shemesh [mailto:wine-devel@shemesh.biz] Sent: Monday, September 13, 2004 9:11 AM To: pouech-eric(a)wanadoo.fr Cc: Wine Development Subject: Re: Why is our OutputDebugString a server request? Pouech Eric DMI AEI CAEN wrote: > so that debuggers can intercept it (especially ones with GUI) and do > what they want with it. > A+ > > > > > Message du 13/09/04 17:50 > > De : "Shachar Shemesh" > > A : "Wine Development" > > Copie à : > > Objet : Why is our OutputDebugString a server request? > > > But as far as I can see, this means that Windows debuggers won't get it. Wouldn't it be better to implement it the Win32 way? At the very least, implement it ALSO as the Win32 way? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

1 0

A window update problem in Dutch tax program.
by Rein Klazes 13 Sep '04

13 Sep '04

Hi, I am looking in a display problem in the electronic declaration programs of the Dutch tax office. Here is a schematic of the windows involved: +--10022-------------------------------+ | | | +--100c6-------------------------+ | | | | | ..20110... | | | . . | | | . . | | | +-20114--+ | | | | | | | | | | | | | +--------+ | | | | | | | | +--------------------------------+ +--------------------------------------+ [10022] is a top level window. One of its child [20114] has itself a child window [20110] that initially lies outside the parent client area. A series of calls to ScrollWindowEx() brings it inside, simulating a drop down listbox. Now [20114] should normally not be visible because it lies behind another child of the main window: [10022] | +--[20114] | | | +--[20110] | | +-[100c6] | + ... No window styles that could affect this behavior (WS_CLIPCHILDREN, WS_CLIPSIBLINGS, WS_EX_TRANSPARENT) are used. Here the partial output of info wnd command: 00010022 WindowIB2003 14cb0000 00000000 Aangifte 2003 00020114 WindowIB2003 50000000 00000000 -- Empty -- 00020110 @LISTBOX 50800141 00000000 -- Empty -- 000100c6 WindowIB2003 50000000 00000000 TheContent The program first validates the update region of the main window with the rect of [20114]. |0009:Call user32.ValidateRect(00010022,4070f988) ret=00426f64 ... |trace:win:RedrawWindow Update region of hwnd 0x10022 is nil |0009:Ret user32.ValidateRect() retval=00000001 ret=00426f64 As the extra trace message reports, this window has a null update region at this point. Then the first scroll is requested: |0009:Call user32.ScrollWindowEx(00020114,00000000,0000000a,4070f6e4,4070f6b4,00000000,00000000,00000001) ret=00426fd1 |trace:scroll:ScrollWindowEx 0x20114, 0,10 hrgnUpdate=(nil) rcUpdate = (nil) (0,-47)-(71,0) 0001 |trace:scroll:ScrollWindowEx clipRect = (0,0)-(71,10) ... |0009:Ret user32.ScrollWindowEx() retval=00000001 ret=00426fd1 directly after this the same scroll rectangle (4070f6e4) is invalidated: |0009:Call user32.InvalidateRect(00020114,4070f6e4,00000001) ret=00426fe6 |trace:win:RedrawWindow 0x20114 (0x137e) rect 0,0-71,10 (nil) flags=0005 |trace:win:dump_rdw_flags flags: RDW_INVALIDATE RDW_ERASE ... |0009:Ret user32.InvalidateRect() retval=00000001 ret=00426fe6 and directly UpdateWindow is called: |0009:Call user32.UpdateWindow(00020114) ret=00426fef |0009:Call x11drv.MsgWaitForMultipleObjectsEx(00000001,4070f460,00000000,000000ff,00000000) ret=40764927 |trace:event:EVENT_ProcessEvent called. UpdateWindow calls RedrawWindows that first looks for outstanding events, that is where the trouble starts: |trace:event:EVENT_ProcessEvent Got event Expose for hwnd/window 0x20114/3a001aa, GetFocus()=0x20112 |trace:x11drv:X11DRV_Expose win 0x20114 (3a001aa) 0,0 71x47 ... |0009:Call user32.RedrawWindow(00010022,4070f010,00000000,00000085) ret=40d519a2 |trace:win:RedrawWindow 0x10022 ((nil)) rect 291,142-362,189 (nil) flags=0085 |trace:win:dump_rdw_flags flags: RDW_INVALIDATE RDW_ERASE RDW_ALLCHILDREN and the main window and child [100c6] find them selves invalidated: |trace:win:RDW_Paint hwnd 0x10022 [0x1382] -> hrgn [0x139e], flags [0085] ... |trace:win:RDW_Paint hwnd 0x100c6 [0x138a] -> hrgn [0x139e], flags [0085] after the final scroll, a WM_PAINT message is dispatched to [100c6] and the scrolled window [20114] is invisible. I am not sure what the real problem is: either the expose event should not be there or the handling of the event is wrong. For the latter case: the handling in expose_window() sure does not expect to make visible a normally obscured window. Any suggestions? The program is available on-line, but I would need to give some instruction for non-Dutch users. Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

Re: Directx9
by Ivan Leo Puoti 13 Sep '04

13 Sep '04

> If we as a project are committed to doing 0.9, 1.0+ releases it means we > can't simply break code people are using to play their games for months > at a time and shrug it off After 1.0 there will be a stable and a development branch, the stable one for users, and the development one for new stuff, where it doesn't matter if things are broken for a while. A bit like the kernel with 2.4 stable and 2.5 full of broken/buggy stuff until 2.6 is ready, and so on. At least that's how most projects work. Ivan.

3 2

Re: Http Fixes
by Marcus Meissner 13 Sep '04

13 Sep '04

On Mon, Sep 13, 2004 at 11:38:32AM +0100, Robert Shearman wrote: > Hi, > > I have seen one server that likes to return "ICY" instead of "HTTP/1.x". > This patch allows the connection to the server continue, as native does. This would be "icecast" I suspect ;) Ciao, Marcus

1 0

Re: Wininet: InternetSetStatusCallback Fix
by Robert Shearman 13 Sep '04

13 Sep '04

Robert Shearman wrote: > Hi, > > You can call InternetSetStatusCallback on a HTTP handle, not just a > InternetOpen handle, so we should search up through the parents to > find it. Oops, I just checked on MSDN and this patch is wrong. We should copy and store the status callback in every handle, not just in the top level one. I'll submit a new patch soon. Rob

1 0

PEB documentation
by Mike Hearn 13 Sep '04

13 Sep '04

This is interesting information, but where did it come from? Is this structure described in some MS documentation? If so, does it have the full layout of the TEB as well? > Log message: > Robert Reif <reif(a)earthlink.net> > Document all the structure members up to SessionId in the PEB.

1 0

Re: winecfg (was Re: W->A calls)
by Mike Hearn 13 Sep '04

13 Sep '04

> It appears that Mike has been doing a lot of work on this. > http://www.winehq.org/hypermail/wine-devel/2004/09/0221.html > So you probably first want to coordinate with him. Yes. I'm aware that I'm holding people up right now due to my non-connectedness. I'm actually living in a bed&breakfast with no net connection, so I only have web/email access at work. It's kind of odd - I've been doing some work on it lately, and suddenly people pop up who want to work on it after a long period of inactivity. Oh well :) > I would start by running "winecfg", and seeing what doesn't work, which > is a lot. For example, on the very first tab, you can select a "Windows > Version", but changing the setting doesn't actually change anything (it > should make/alter a registry entry). The winecfg code is in > wine/programs/winecfg. Fixed by me already. Actually, I've done quite a bit of work on it, I'd recommend waiting for 2 weeks at which point I'll have net access to my laptop again and can hopefully send off my work. At that point I'll be disappearing back into university life and doing CW work again so the coast will be clear for others to work on it. > A long discussion of things that are needed is in the thread starting: > http://www.winehq.org/hypermail/wine-devel/2004/08/0007.html I've sorted some of these already, especially in the apps tab. So ... if you guys can wait for 2 weeks I should (hopefully) have something to show soon. thanks -mike

1 0

RFC: ntdll critical section debug
by Robert Reif 13 Sep '04

13 Sep '04

I have been running into deadlock problems in the direct sound dll and have been playing with the debug part of critical sections. I added a lock name to Spare[1] to give the critical sections names that will show up in the error messages just like wine's ntdll does. After looking at the ntdll code, it looks like this causes a leak because ntdll statically initializes it's locks and doesn't delete the debug part when it finds Spare[1] used. I also tried adding a linked list of critical section debug structs just like real windows does. Because ntdll statically initializes it's locks, they don't get added to the list. I manually stuff the critical section list lock into the list so it shows up and user locks show up but not the other internal ntdll locks. Is there a good reason to statically initialize ntdll locks or can they be initialized like normal locks? Here is a patch that adds the linked list of debug info: Index: dlls/ntdll/critsection.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/critsection.c,v retrieving revision 1.27 diff -u -r1.27 critsection.c --- dlls/ntdll/critsection.c 6 Sep 2004 20:26:23 -0000 1.27 +++ dlls/ntdll/critsection.c 10 Sep 2004 16:29:14 -0000 @@ -36,6 +36,51 @@ WINE_DEFAULT_DEBUG_CHANNEL(ntdll); WINE_DECLARE_DEBUG_CHANNEL(relay); +static LIST_ENTRY RtlCriticalSectionList; +static CRITICAL_SECTION RtlCriticalSectionLock; +static CRITICAL_SECTION_DEBUG RtlCriticalSectionDebug = +{ + 0, 0, &RtlCriticalSectionLock, + { &RtlCriticalSectionDebug.ProcessLocksList, + &RtlCriticalSectionDebug.ProcessLocksList }, + 0, 0, { 0, (DWORD)(__FILE__ ": RtlCriticalSectionLock") } +}; +static CRITICAL_SECTION RtlCriticalSectionLock = { &RtlCriticalSectionDebug, -1, 0, 0, 0, 0 }; + +void critsection_init() +{ + InitializeListHead( &RtlCriticalSectionList ); + InsertHeadList( &RtlCriticalSectionList, &RtlCriticalSectionDebug.ProcessLocksList ); +} + +static void CRIT_Dump() +{ + int i = 0; + PLIST_ENTRY mark, entry; + PCRITICAL_SECTION_DEBUG debug; + + RtlEnterCriticalSection( &RtlCriticalSectionLock ); + + mark = &RtlCriticalSectionList; + for (entry = mark->Flink; entry != mark; entry = entry->Flink) + { + debug = CONTAINING_RECORD(entry, CRITICAL_SECTION_DEBUG, ProcessLocksList); + + TRACE("RtlCriticalSectionDebug[%d]:\n", i++); + TRACE(" Type = %04x\n", debug->Type); + TRACE(" CreatorBackTraceIndex = %04x\n", debug->CreatorBackTraceIndex); + TRACE(" CriticalSection = %p\n", debug->CriticalSection); + TRACE(" ProcessLocksList.Flink = %p\n", debug->ProcessLocksList.Flink); + TRACE(" ProcessLocksList.Blink = %p\n", debug->ProcessLocksList.Blink); + TRACE(" EntryCount = %ld\n", debug->EntryCount); + TRACE(" ContentionCount = %ld\n", debug->ContentionCount); + TRACE(" Spare[0] = %08lx\n", debug->Spare[0]); + TRACE(" Spare[1] = %08lx (%s)\n", debug->Spare[1], debugstr_a((char *)debug->Spare[1])); + } + + RtlLeaveCriticalSection( &RtlCriticalSectionLock ); +} + inline static LONG interlocked_inc( PLONG dest ) { return interlocked_xchg_add( dest, 1 ) + 1; @@ -126,12 +171,16 @@ crit->DebugInfo->Type = 0; crit->DebugInfo->CreatorBackTraceIndex = 0; crit->DebugInfo->CriticalSection = crit; - crit->DebugInfo->ProcessLocksList.Blink = &(crit->DebugInfo->ProcessLocksList); - crit->DebugInfo->ProcessLocksList.Flink = &(crit->DebugInfo->ProcessLocksList); crit->DebugInfo->EntryCount = 0; crit->DebugInfo->ContentionCount = 0; crit->DebugInfo->Spare[0] = 0; crit->DebugInfo->Spare[1] = 0; + RtlEnterCriticalSection( &RtlCriticalSectionLock ); + InsertTailList( &RtlCriticalSectionList, &(crit->DebugInfo->ProcessLocksList) ); + RtlLeaveCriticalSection( &RtlCriticalSectionLock ); + + if (TRACE_ON(ntdll)) + CRIT_Dump(); } } crit->LockCount = -1; @@ -195,12 +244,19 @@ crit->LockSemaphore = 0; if (crit->DebugInfo) { + RtlEnterCriticalSection( &RtlCriticalSectionLock ); + RemoveEntryList( &(crit->DebugInfo->ProcessLocksList) ); + RtlLeaveCriticalSection( &RtlCriticalSectionLock ); + /* only free the ones we made in here */ if (!crit->DebugInfo->Spare[1]) { RtlFreeHeap( GetProcessHeap(), 0, crit->DebugInfo ); crit->DebugInfo = NULL; } + + if (TRACE_ON(ntdll)) + CRIT_Dump(); } return STATUS_SUCCESS; } Index: dlls/ntdll/ntdll_misc.h =================================================================== RCS file: /home/wine/wine/dlls/ntdll/ntdll_misc.h,v retrieving revision 1.48 diff -u -r1.48 ntdll_misc.h --- dlls/ntdll/ntdll_misc.h 15 Jul 2004 22:07:21 -0000 1.48 +++ dlls/ntdll/ntdll_misc.h 10 Sep 2004 16:29:14 -0000 @@ -50,6 +50,7 @@ extern void debug_init(void); extern void thread_init(void); extern void virtual_init(void); +extern void critsection_init(void); /* server support */ extern void server_init_process(void); Index: dlls/ntdll/thread.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/thread.c,v retrieving revision 1.21 diff -u -r1.21 thread.c --- dlls/ntdll/thread.c 23 Aug 2004 18:52:54 -0000 1.21 +++ dlls/ntdll/thread.c 10 Sep 2004 16:29:14 -0000 @@ -134,6 +134,7 @@ debug_info.str_pos = debug_info.strings; debug_info.out_pos = debug_info.output; + critsection_init(); debug_init(); virtual_init();

3 2

spying COM
by Saulius Krasuckas 13 Sep '04

13 Sep '04

Am not sure would it be of any use for list members, but just some minutes ago I've discovered "The COM spy". Quite old stuff, but whatever: http://staff.develop.com/jasonw/comspy/default.htm

2 1

epoll patch - status?
by Shachar Shemesh 12 Sep '04

12 Sep '04

Hi Alexandre, I'm sorry for being a pest about this. I was wondering whether there is anything that needs to be done on that one in order to facilitate committing this patch? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

5 14

Re: IShellFolder::CompareIDs partially undocumented take 2
by Vitaliy Margolen 12 Sep '04

12 Sep '04

Is there are any problems with this patch? Tests do confirm it. Vitaliy Margolen Saturday, September 4, 2004, 9:48:41 PM, Vitaliy Margolen wrote: > Since my previous patch wasn't excepted here it is again. This time with more fixes > and tests. > Also it _is_ documented that CompareIDs returns result in lower 16 bits. And this function > returns only -1/0/1 as a result. > Vitaliy Margolen > changelog: > dlls/shell32/shlfolder.c > IShellFolder::CompareIDs - return only -1/0/1 in lower 16 bit.

1 0

W->A calls
by Joris Huizer 11 Sep '04

11 Sep '04

Hello, By accident, I removed the emails of the thread I started, but I'll look it up if necessary; I found this old wine issue of some time ago.. I think the patch it has there could be helpfull http://winehq.org/?issue=229#About%20Converting%20W-%3EA%20Calls However, I don't know how to make simple tests.. as I'd really need to test wether the code I write works, and works properly :p How do I write tests for that? I'm running linux (in practice, I never boot into windows) so how should I do this (testing without windows environment)? How are tests supposed to run? I hope you can give some clues on that; I found there are many W->A calls in dlls/winmm/winmm.c (according to the janitorial page) so I might start there (hoping not all of them are so tricky ;) ) Thanks for suggestions on this, Joris

7 9

Re: Correct ConvertSidToStringSidW with test
by Dimitrie O. Paun 11 Sep '04

11 Sep '04

On Sat, Sep 11, 2004 at 08:37:09AM -0700, Juan Lang wrote: > ConvertSidToStringSidW was incorrect for low-value > authorities; it put spaces in the resulting string. > This corrects that, and includes a test case for it. Content-Description: advapi32.diff Uniffied diff, please :) -- Dimi.

1 0

Re: PROPSHEET: Wizard resizing
by Filip Navara 11 Sep '04

11 Sep '04

Filip Navara wrote: > I know this patch isn't really correct, but the old code isn't correct > either. Without it about 80% of the wizards were resized incorrectly > (or not at all) and the header line wasn't hidden sometimes. Even > though I would like to code the resizing correctly it will require > major code shuffling that I can't do now due to time constraints. So I > believe for now this patch is less evil than letting the code as is. > > (I can provide more details about how it should be implemented > correctly on request) > > - Filip > > Changelog: > First attempt at correcting wizard resizing. Scratch this patch please. I'll try to implement it correctly... Regards, Filip

1 0

Wine and non ANSI charset fonts
by Andreas Rosenberg 11 Sep '04

11 Sep '04

Hello guys, after a long pause I'm back testing our application (http://appdb.winehq.org/appview.php?appId=1536) with WINE. In the meantime I've been working to prepare our application for the east european/asian market (UTF16, wide char API). This seems to work so far, but as soon as you enter text requiring non ANSI glyphs, I'm only getting "square boxes" instead of the desired characters. So I was searching for another application that uses non ANSI glyhps with WINE. I choosed Opera, because it's quite easy to install. But unfortunately Opera 7.x crashed after entering the first URL. The function "WSAStringToAddress" and some other WSA funtions were missing/stubs. Yesterday evening I fixed these problems and just sent a patch making Opera work with Wine. With Opera I'm now getting the same or similar effects. just try the Opera in Wine and go to: http://www.viatech.com.tw/big5/index/index.jsp So my question: is this a configuration problem? Konquerer displays the page correctly, so the fonts on the Linux side have the correct glyphs available. But it seems they are not available in WINE - I looked into the WINE config file and found something like this: ;;default TrueType fonts with russian koi8-r encoding "Default" = "-monotype-arial-*-*-*--*-*-*-*-*-*-koi8-r" "DefaultFixed" = "-monotype-courier new-*-*-*--*-*-*-*-*-*-koi8-r" "DefaultSerif" = "-monotype-times new roman-*-*-*--*-*-*-*-*-*-koi8-r" "DefaultSansSerif" = "-monotype-arial-*-*-*--*-*-*-*-*-*-koi8-r" This seems to define something regarding the cyrilic charset. With these lines enabled, Opera can display russian pages correctly. But what do I need to enter to get the glyphs of other character sets? (chinese, hangul, etc...) I read the Wine users guide regarding fonts, but it still does not address the character set topic.Can anybody shed some light on this? Regards Andy

2 1

Re: Implementation of WSAStringToAddress(A/W), WSAHtonl, WSAHtons
by Alexandre Julliard 10 Sep '04

10 Sep '04

Andreas Rosenberg <andreas_rosenberg(a)web.de> writes: > +INT WINAPI WSAStringToAddressW(LPCWSTR AddressString, > + INT AddressFamily, > + LPWSAPROTOCOL_INFOA lpProtocolInfo, You should have an LPWSAPROTOCOL_INFOW here instead, and convert it before calling WSAStringToAddressA. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Almost complete UpdateResource implementation
by Alexandre Julliard 10 Sep '04

10 Sep '04

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > + if(!updates_list) > + { > + updates_list = current_updates; > + list_init(&updates_list->entry); > + } > + else > + list_add_after(&updates_list->entry, &current_updates->entry); That's not the right way to use the list functions. updates_list should be a separate struct list, that will make things a lot easier. > + LIST_FOR_EACH(ptr, &current_updates->resources_list->entry) > + { > + current_resource = LIST_ENTRY(ptr, QUEUEDRESOURCE, entry); > + free_queuedresource(current_resource); > + } You cannot free objects that are still on list, you have to remove them first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: CreateDirectoryA conformance test improvement
by Alexandre Julliard 10 Sep '04

10 Sep '04

Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> writes: > This patch provides a conformance test for my patch > sent on 06. Sept 2004. > > I have successfully tested it on Windows98 and WindowsNT4. Actually the results of that test depend on what the current directory is on the drive you are testing. If your current directory is \ you will see that it fails on Windows too. I believe the Wine code is correct, it returns ACCESS_DENIED on the root and ALREADY_EXISTS anywhere else, just like Windows. -- Alexandre Julliard julliard(a)winehq.org

1 0

COmpilation problems with older Freetype 2
by Vincent Béron 10 Sep '04

10 Sep '04

A patch by Huw broke compilation of Wine on RH8 (and probably other platforms as well) which use Freetype 2.1.3 or earlier. More specifically, FT_ENCODING_NONE is undefined. Other ft_encoding_* (or FT_ENCODING_*) problems have arised in the past, but the solution used identifiers already present in older Freetype versions. The attached patch works (and results in the same compiled code IMHO), but looks like a hack rather than a proper fix (use MS_MAKE_TAG? that has already been removed in the past to use ft_encoding_*). Vincent

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel