wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

make crosstest fails
by Stefan Leichter 07 Aug '04

07 Aug '04

Hello, building cross tests of current cvs fails for me with: i386-mingw32-gcc capture.cross.o ds3d.cross.o dsound.cross.o propset.cross.o testlist.cross.o -o dsound_crosstest.exe -ldsound -lole32 -luser32 -lkernel32 -ldxguid -luuid -ldxerr8 /usr/local/lib/gcc-lib/i386-mingw32/3.2.3/../../../../i386-mingw32/lib/ libdxguid.a(dxguid.o)(.text+0x570):/usr/src/packages/BUILD/mingw-3.2/ w32api-2.5/lib/directx/dxguid.c: multiple definition of `CLSID_DirectSoundPrivate' propset.cross.o(.text+0x0):propset.c: first defined here /usr/local/lib/gcc-lib/i386-mingw32/3.2.3/../../../../i386-mingw32/lib/ libdxguid.a(dxguid.o)(.text+0x580):/usr/src/packages/BUILD/mingw-3.2/ w32api-2.5/lib/directx/dxguid.c: multiple definition of `DSPROPSETID_DirectSoundDevice' propset.cross.o(.text+0x10):propset.c: first defined here make[3]: *** [dsound_crosstest.exe] Fehler 1 make[3]: Leaving directory `/usr/src/wine/wine-mingw/dlls/dsound/tests' make[2]: *** [tests/__crosstest__] Fehler 2 make[2]: Leaving directory `/usr/src/wine/wine-mingw/dlls/dsound' make[1]: *** [dsound/__crosstest__] Fehler 2 make[1]: Leaving directory `/usr/src/wine/wine-mingw/dlls' make: *** [dlls/__crosstest__] Fehler 2 Bye Stefan

4 3

DOOM 3 misses some opengl32 wgl* and Cg functions
by Dr. Uwe Girlich 07 Aug '04

07 Aug '04

Hello all! I just tested out DOOM 3 (no-cd-cracked version) with the current Wine (CVS from 1 hour ago) and found the following problems on the game console: Couldn't find proc address for: wglSwapIntervalEXT Couldn't find proc address for: wglGetPixelFormatAttribivARB Couldn't find proc address for: wglGetPixelFormatAttribfvARB Couldn't find proc address for: wglChoosePixelFormatARB Couldn't find proc address for: wglCreatePbufferARB Couldn't find proc address for: wglGetPbufferDCARB Couldn't find proc address for: wglReleasePbufferDCARB Couldn't find proc address for: wglDestroyPbufferARB Couldn't find proc address for: wglQueryPbufferARB Couldn't find proc address for: wglBindTexImageARB Couldn't find proc address for: wglReleaseTexImageARB Couldn't find proc address for: wglSetPbufferAttribARB GL_ARB_texture_non_power_of_two not found GL_ATI_fragment_shader not found (this is expected, I have a nvidia card) Cg not available. Are these wgl* function difficult to implement? Almost all computer terminals in the game show static black & white noise (instead of some animated computer screen image). I suspect, that this has something to do with the missing 'Cg' support in Wine (DOOM3 cannot find cg.dll & cgGL.dll). On the other hand, the rendering paths (r_renderer nv10, nv20, arb, and arb2) are all more or less working (besides the noise and the too bright lighting in nv10). BTW, DOOM 3 crashes at program start in Cedega, you made it better! Bye, Uwe

7 7

Re: Take monospace fonts into account in default font selectionalgorithm.
by Dmitry Timoshkov 07 Aug '04

07 Aug '04

"Mike Hearn" <mike(a)navi.cx> wrote: > + (*insertface)->fixed_width = ft_face->face_flags & FT_FACE_FLAG_FIXED_WIDTH; ... > - if(csi.fs.fsCsb[0] & family->FirstFace->fs.fsCsb[0]) > + if((csi.fs.fsCsb[0] & family->FirstFace->fs.fsCsb[0]) && > + (family->FirstFace->fixed_width == (lf.lfPitchAndFamily & MONO_FONT))) This can't work because instead of logical boolean results you compare binary flags which are different: #define FT_FACE_FLAG_FIXED_WIDTH ( 1L << 2 ) #define MONO_FONT 0x08 -- Dmitry.

1 0

suse patch for wineprefixcreate
by Marcus Meissner 07 Aug '04

07 Aug '04

Hi, This is the patch I use at SUSE for wineprefixcreate. Mike wanted to see it ;) $dlldir/config is the sample config file with just minimal local suse changes. Ciao, Marcus Index: wineprefixcreate.in =================================================================== RCS file: /home/wine/wine/tools/wineprefixcreate.in,v retrieving revision 1.4 diff -u -r1.4 wineprefixcreate.in --- wineprefixcreate.in 14 May 2004 00:43:50 -0000 1.4 +++ wineprefixcreate.in 7 Aug 2004 12:40:57 -0000 @@ -86,8 +86,10 @@ if [ -d "$WINEPREFIX" ] || mkdir "$WINEPREFIX"; then : else - echo "Could not create $WINEPREFIX, aborting" - exit 1 +fi + +if [ ! -f "$WINEPREFIX/config" ]; then + cp $dlldir/config "$WINEPREFIX/config" fi WINEPREFIX=`cd "$WINEPREFIX" && pwd` @@ -124,6 +126,35 @@ [ -d "$i" ] || mkdir "$i" done +# Create the drive symlinks +if [ ! -d "$WINEPREFIX/dosdevices" ] +then + mkdir "$WINEPREFIX/dosdevices" + ln -s "../drive_c" "$WINEPREFIX/dosdevices/c:" + ln -s "/" "$WINEPREFIX/dosdevices/z:" + ln -s "/tmp" "$WINEPREFIX/dosdevices/x:" + if [ -d "$HOME" ]; then + ln -s "$HOME" "$WINEPREFIX/dosdevices/y:" + if [ ! -f "$HOME/.windows-label" ]; then + echo "HOME" > "$HOME/.windows-label" + fi + fi + # autodetect CD-ROMS on SUSE. + drive=D + for i in /media/* ; do + bn=`basename $i` + if [ "$i" = "/media/floppy" ]; then + ln -s /media/floppy "$WINEPREFIX/dosdevices/a:" + ln -s /dev/fd0 "$WINEPREFIX/dosdevices/a::" + fi + if echo $bn| grep -E -v "^(sd|usb-storage|floppy)" >/dev/null; then + ln -s /media/$bn "$WINEPREFIX/dosdevices/"`echo $drive|tr "[A-Z]" "[a-z]"`: + ln -s /dev/$bn "$WINEPREFIX/dosdevices/"`echo $drive|tr "[A-Z]" "[a-z]"`:: + drive=`echo $drive|tr "D-L" "E-M"` + fi + done +fi + # Create the application symlinks link_app()

2 1

msvideo 16bit codec question
by Mike Hearn 07 Aug '04

07 Aug '04

Hey Mike, I've been trying to make Maxis Marble Drop work in my non-connected spare time in the evenings, and the intro video doesn't render right. Examination of the code revealed that it had been patched to output pixel blocks in the right direction for the 8 bit decoder but the 16 bit decoder hadn't been modified. So, I copied across the changes to the 16 bit decoder as well, unfortunately it doesn't work. Something is going wrong, and the codec trashes the heap arena, so I'm guessing there's something in the maths that is different for 16 bit videos than 8 bit. Got any ideas? thanks -mike

1 0

wine debugger
by Chipzz 07 Aug '04

07 Aug '04

Hi all, for some reason, the wine debugger just doesn't seem to work for me. wine: Unhandled exception (thread 000f), starting debugger... fixme:console:SetConsoleCtrlHandler (0x405ae990,1) - no error checking or testing yet WineDbg starting on pid 0xe In 32 bit mode. Wine-dbg>bt Backtrace: =>1 0x40107b08 __read+0x28 in libc.so.6 (0x40032c54) 2 0x401cc022 Exception c0000005 The backtrace it shows appears to be from the debugger itself, not from the program? Or am I wrong in assuming this? I am getting this same backtrace for each and every program... Also, the ctrl-c key doesn't work as advertised (just does nothing). Wine is wine cvs from 07/31, gdb is 6.1-3 from debian unstable. Anyone got some pointers? kr, Chipzz AKA Jan Van Buggenhout -- ------------------------------------------------------------------------ UNIX isn't dead - It just smells funny Chipzz(a)ULYSSIS.Org ------------------------------------------------------------------------ "Baldric, you wouldn't recognize a subtle plan if it painted itself pur- ple and danced naked on a harpsicord singing 'subtle plans are here a- gain'."

2 1

FW: FW: WM_NEXTDLGCTL changes the default button ID and does not rest ore default control identifier
by Krishna Murthy 06 Aug '04

06 Aug '04

Alexandre, I am resending this patch. There exists a defect 2388. Also confirmed that it fixes one of the Katia's defect found. Please let us know about your thoughts. Thanks, Krishna -----Original Message----- From: Krishna Murthy Sent: Tuesday, June 22, 2004 2:56 PM To: 'Alexandre Julliard'; Krishna Murthy Cc: wine-devel(a)winehq.org Subject: RE: FW: WM_NEXTDLGCTL changes the default button ID and does not rest ore default control identifier Alexandre, Please find attached modified patch. The method DEFDLG_SetDefButton() now accepts the BOOL bSetDefID parameter to adapt for both DM_SETDEFID and WM_NEXTDLGCTL. Thanks, Krishna -----Original Message----- From: Alexandre Julliard [mailto:julliard@winehq.org] Sent: Friday, June 18, 2004 10:30 AM To: Krishna Murthy Cc: wine-devel(a)winehq.org Subject: Re: FW: WM_NEXTDLGCTL changes the default button ID and does not rest ore default control identifier Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > No, it is required. The DEFDLG_SetDefButton() is also called from > message DM_SETDEFID. In this case idResult should set to the default > button ID passed. And the current logic of DEFDLG_SetDefButton() does > what is required for DM_SETDEFID. Well, of course you'd need to adapt the DM_SETDEFID handling to the change. I think that's better than sending duplicate messages. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: list view completely mangled in WINE
by Dan Kegel 06 Aug '04

06 Aug '04

Hi Filip, if you're looking for testcases, could you try the demo programs in http://bugs.winehq.org/show_bug.cgi?id=1268 and http://bugs.winehq.org/show_bug.cgi?id=1404 ? Especially the latter one, which has a tiny MFC demo program in both source code form and precompiled. It misbehaves badly with Wine, and has for years, but perhaps your patch will fix it. Thanks, Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

2 1

vc++ install requires NetUserModalsGet
by James Hawkins 06 Aug '04

06 Aug '04

Hi, Taking the advice of Ivan, I downloaded the beta of Visual C++ 2005 to see how far it could work in Wine, and these are the results: # wine vcsetup.exe fixme:ver:RtlVerifyVersionInfo (0x406df40c,64,180000): Not all cases correctly implemented yet fixme:ole:CoInitializeSecurity ((nil),-1,(nil),(nil),0,3,(nil),0,(nil)) - stub! fixme:netapi32:NetUserModalsGet (null) 2 0x406df394 Then an error message pops up stating that "a problem has been encountered while loading components" and then it exits. Looking into netapi32/access.c, NetUserModalsGet is a stub and returns NERR_InternalError by default. I think vcsetup is requiring this call to succeed so it bails out because of the error. Reading the trace and the msdn docs about NetUserModalsGet, vcsetup is calling with the level parameter == 2 so it is requesting the domain name and identifier. With the included patch, I have stubbed the structure of the 4 levels that can be queried, but I haven't written the code to handle them yet. If anyone has any information or links that will enlighten me about netapi32 or anything pertaining to this matter, I would greatly appreciate it. quote from MSDN: "The NetUserModalsGet function retrieves global information for all users and global groups in the security database, which is the security accounts manager (SAM) database or, in the case of domain controllers, the Active Directory." Does wine have a security accounts manager or an Active Directory? -- James Hawkins

3 2

Different approach to a->w cleanup of crypt
by James Hawkins 06 Aug '04

06 Aug '04

Hi, I have been trying to get my a->w cleanup of crypt committed for quite some time now, and mostly with no luck because of all the bugs, but I have a better idea about how accomplish this. The problem is that crypt requires a lot of changes to get rid of the w->a calls (the patch was ~27k), and it's too risky to commit the patch even though it looks like all the bugs are gone. The solution is that I will change one piece of crypt at a time and submit small patches that are easier to find bugs in. There are a number of private functions in crypt though that cant be changed to unicode because it will break compilation before the rest of the patches are submitted, so I will submit unicode patches with a W appended to the name of the function as in static inline PSTR CRYPT_GetProvKeyName(PCSTR pProvName) static inline PWSTR CRYPT_GetProvKeyNameW(PCWSTR pProvName) //added Any public api functions that I change until the final patch will use the W version while the unchanged version will continue using the regular ansii version so as to not break compilation. Along with the changes, I will also submit tests for the new unicode api functions so they can be verified to be correct. The first patch adds CRYPT_GetProvKeyNameW. -- James Hawkins

1 1

Re: [D3D] Fixed XYZRHW vertex handling
by Francois Gouget 06 Aug '04

06 Aug '04

--- dlls/ddraw/d3ddevice/mesa_old.c 2004-08-05 15:11:43.000000000 +0100 +++ dlls/ddraw/d3ddevice/mesa.c 2004-08-05 12:50:45.000000000 +0100 @@ -1172,7 +1172,7 @@ glVertex3fv(coords); } inline static void handle_xyzrhw(D3DVALUE *coords) { - if (coords[3] < 1e-8) + if ((coords[3] < 1e-8) && (coords[3] > -1e-8)) glVertex3fv(coords); else { GLfloat w = 1.0 / coords[3]; This could be a job for fabsf of fabs (might be more portable): + if (fabsf(coords[3]) < 1e-8) -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

2 1

BeginUpdateResource, UpdateResource and EndUpdateResource
by Vincent Béron 05 Aug '04

05 Aug '04

Hi, I'd like to implement those 3 APIs (both the A and W variants) as the process to update the Mozilla installer for a localized build uses them. Anybody has some pointers where to begin? I tried following the FindResourceEx path, but got lost in ntdll. Vincent

1 0

list view completely mangled in WINE
by Tobias Burnus 05 Aug '04

05 Aug '04

Hello, in Crystal Impact's Diamond the list view is completely mangled and only barely recognizable as list view. Result in WINE: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list_wine.png Result in Windows: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list.png I'd be really pleased if someone could look at the problem. The demo version of the program is free and available from http://www.crystalimpact.com/download/diamond/demo/dm2demo.exe (In addition to this list-view problem the application does off-screen rendering which is not supported by WINE; one needs to disable rendering in order use the program. See WINE bug http://bugs.winehq.com/show_bug.cgi?id=2320 ) Tobias

5 15

Is check for WS_THICKFRAME style really needed for sizing?
by Santosh Siddheshwar 05 Aug '04

05 Aug '04

Hi, Is the check for windows WS_THICKFRAME style really needed to decide whether a window can be resized or not? I have a scenario where this style is not set but the user can still size the window. This is being done by dispatching WM_SYSCOMMAND messages with SC_SIZE command but WINE is preventing these messages from being effectively handled by returning from the SysCommandSizeMove (winpos.c) method, without doing anything, if the window in question doesnt have this style set. Regards Santosh Siddheshwar ********************************************************************* Disclaimer: The information in this e-mail and any attachments is confidential / privileged. It is intended solely for the addressee or addressees. If you are not the addressee indicated in this message, you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to Internet email for messages of this kind. *********************************************************************

1 0

warning when configuring wine-20040716 on OpenBSD 3.5+
by Angelos D. Keromytis 05 Aug '04

05 Aug '04

configure: WARNING: sys/sysctl.h: present but cannot be compiled configure: WARNING: sys/sysctl.h: check for missing prerequisite headers? configure: WARNING: sys/sysctl.h: see the Autoconf documentation configure: WARNING: sys/sysctl.h: section "Present But Cannot Be Compiled" configure: WARNING: sys/sysctl.h: proceeding with the preprocessor's result configure: WARNING: sys/sysctl.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## checking for sys/sysctl.h... yes

1 0

Fwd:Novell client
by Ivan Leo Puoti 04 Aug '04

04 Aug '04

new ad request.

1 0

Re: Wine and locales
by Dmitry Timoshkov 04 Aug '04

04 Aug '04

"Shachar Shemesh" <wine-devel(a)shemesh.biz> wrote: > In an attempt to get away from a possibly confusing subject line, and to > converge on an agreed behavior, here is an attempt to clear the desired > locale behavior Wine should have. Dmitry (and anyone else), please > comment on this table where you think there are errors in it, and say > what should be there. > > In the "Unix setting", I'm always assuming that LC_ALL overrides > whatever is written in that column, and that LANG is used if neither > LC_ALL nor the column are set. I said it many times already, and I'll repeat once more: Windows has only one active locale which defines all the things you mentioned in the table except language of the interface which let's set aside to not confuse each other. There is no need to try to find appropriate mappings for LC_TYPE or anything else you find in the output of the 'locale' command. But still (almost) any locale setting you want to modify in the win32 environment on a per user basis can be done either by running Control Panel/Regional Options, or modifying the registry or win.ini directly. By default all locale data are set according to the global system locale. Any attempt to have more than one active locale simultaneously will lead to confusion and nothing else, be it unix environment or win32. -- Dmitry.

5 40

Re: winedos: dos debugger support
by markus.amsler＠oribi.org 04 Aug '04

04 Aug '04

Quoting Andreas Mohr <andi(a)rhlx01.fht-esslingen.de>: > What does this patch do? Does it do what I believe it does?? :-) > (finally provide useful debugging for DOS programs launched by Wine?) Yeahp. For Debugging .com files you also have to apply the EXEC fix patch [1]. For line editing support, apply BUFFERED INPUT patch [5]. Tested Debuggers (for more see [2]): - Microsoft's debug.exe - ddeb.exe (my favorite) [3] - debug.com (with source) [4] Markus [1] http://www.winehq.org/hypermail/wine-patches/2004/08/0044.html [2] http://www.programmersheaven.com/zone5/cat188/ [3] http://www.programmersheaven.com/zone5/cat188/26391.htm [4] http://www.programmersheaven.com/zone5/cat188/2025.htm [5] http://www.winehq.org/hypermail/wine-patches/2004/08/0043.html

1 0

Re: ListView fixes for Diamond (Try 2)
by Robert Shearman 04 Aug '04

04 Aug '04

Filip Navara wrote: > Changelog: > - Don't update infoPtr->dwStyle in LISTVIEW_WindowProc. It's already > handled in LISTVIEW_StyleChanged and LISTVIEW_Create processing. > - Ignore WS_VSCROLL/WS_HSCROLL flags in infoPtr->dwStyle because it's > not always up-to-date. > - Fix TOOLBAR_DrawMasked to correctly use image list mask. > > - Filip > >------------------------------------------------------------------------ > >Changelog: >- Don't update infoPtr->dwStyle in LISTVIEW_WindowProc. It's already > handled in LISTVIEW_StyleChanged and LISTVIEW_Create processing. >- Ignore WS_VSCROLL/WS_HSCROLL flags in infoPtr->dwStyle because it's > not always up-to-date. >- Fix TOOLBAR_DrawMasked to correctly use image list mask. > >--- comctl32/listview.c Sat Jul 31 22:07:42 2004 >+++ comctl32/listview.c Wed Aug 4 00:19:30 2004 > > ... >--- comctl32/toolbar.c Sat Jul 31 22:07:14 2004 >+++ comctl32/toolbar.c Wed Aug 4 00:19:34 2004 >@@ -658,8 +658,7 @@ > > /* Create src image */ > hdcImage = CreateCompatibleDC(hdc); >- hbmImage = CreateBitmap(cx, cy, GetDeviceCaps(hdc,PLANES), >- GetDeviceCaps(hdc,BITSPIXEL), NULL); >+ hbmImage = CreateCompatibleBitmap(hdc, cx, cy); > SelectObject(hdcImage, hbmImage); > ImageList_DrawEx(himl, index, hdcImage, 0, 0, cx, cy, > RGB(0xff, 0xff, 0xff), RGB(0,0,0), ILD_NORMAL); >@@ -670,8 +669,8 @@ > SelectObject(hdcMask, hbmMask); > > /* Remove the background and all white pixels */ >- SetBkColor(hdcImage, ImageList_GetBkColor(himl)); >- BitBlt(hdcMask, 0, 0, cx, cy, hdcImage, 0, 0, SRCCOPY); >+ ImageList_DrawEx(himl, index, hdcMask, 0, 0, cx, cy, >+ RGB(0xff, 0xff, 0xff), RGB(0,0,0), ILD_MASK); > SetBkColor(hdcImage, RGB(0xff, 0xff, 0xff)); > BitBlt(hdcMask, 0, 0, cx, cy, hdcImage, 0, 0, NOTSRCERASE); > > > Filip, please put this in a separate patch. Rob

1 0

Re: WININET: take account of dwHeaderLength in HttpSendRequest
by Dmitry Timoshkov 03 Aug '04

03 Aug '04

"Mike McCormack" <mike(a)codeweavers.com> wrote: > Does this look better? Strange I didn't get a compiler warning from that... > + if( dwHeaderLength == -1L ) > + len = strlenW(lpszHeaders); > + else > + len = dwHeaderLength; Well, it's better, but really needs a test to verify whether only -1 or any negative value is treated as a hidden strlen. -- Dmitry.

1 0

Re: WININET: take account of dwHeaderLength in HttpSendRequest
by Dmitry Timoshkov 03 Aug '04

03 Aug '04

"Mike McCormack" <mike(a)codeweavers.com> wrote: > ChangeLog: > * take account of dwHeaderLength in HttpSendRequest > - len = strlenW(lpszHeaders)+3; > - szCookedHeaders = HeapAlloc( GetProcessHeap(), 0, sizeof(WCHAR)*len ); > - strcpyW( szCookedHeaders, lpszHeaders ); > + if( dwHeaderLength < 0 ) > + len = strlenW(lpszHeaders); > + else > + len = dwHeaderLength; (dwHeaderLength < 0) is an always true condition, since dwHeaderLength is DWORD, i.e. unsigned long. -- Dmitry.

1 0

wine metacity and ctrl-alt-del binding - ctrl sticks
by Grant Williamson 03 Aug '04

03 Aug '04

Curious if there is a patch somewhere for this. Running rhel3, gnome-2.2 with metacity. 1) Start notepad, type a few characters 2) hit the keyboard combination ctrl-alt-del ... "gnome-session-kill --save" is started. 3) Cancel this option. 4) Now try typing in Notepad, i.e. hit the keys "s" or "f", its just like ctrl-s or ctrl-f have been held in. 5) Hitting ctrl once cancels this. Anyone have a patch, to stop this happening?

2 1

Re: cleanup a->w cross calls in advapi32/crypt.c
by Mike McCormack 03 Aug '04

03 Aug '04

James Hawkins wrote: > + PWSTR keyname; > > - keyname = CRYPT_Alloc(strlen(KEYSTR) + strlen(pProvName) +1); > + keyname = CRYPT_Alloc((strlenW(KEYSTR) + strlenW(pProvName) + 1) * sizeof(WCHAR)); > if (keyname) > { > - strcpy(keyname, KEYSTR); > - strcpy(keyname + strlen(KEYSTR), pProvName); > + strcpyW(keyname, KEYSTR); > + strcpyW(keyname + strlenW(KEYSTR) * sizeof(WCHAR), pProvName); > } else > SetLastError(ERROR_NOT_ENOUGH_MEMORY); > return keyname; > } This doesn't look right.... when using pointer arithmetic, you do so in increments of the pointer's type (eg. WCHAR). The following two lines are the same, and are both wrong: strcpyW(keyname + strlenW(KEYSTR) * sizeof(WCHAR), pProvName); strcpyW(&keyname[strlenW(KEYSTR) * sizeof(WCHAR)], pProvName); The right version would be: strcpyW(&keyname[strlenW(KEYSTR)], pProvName); but how about just using: strcatW( keyname, pProvname ); Mike

4 4

Re: cleanup a->w cross calls in advapi32/crypt.c
by Jeroen Janssen 02 Aug '04

02 Aug '04

James Hawkins wrote: > I'm wasn't exactly sure on this one so it would be great if you could > help me on this one. When using pointer arithmetic, do the operations > such as --, ++... increment or decrement by the size of the pointer > type? Yes, if you have a char (1byte) pointer and you ++, you'll get one byte further. If you have a short (2byte) you'll get two bytes further in memory. If you have a long (4byte) pointer, you'll get 4 bytes further in memory if you ++. It is simular to dealing with arrays (looking at the memory layout) If you have an array of structs and need to get to the next struct in the array then you will need to look sizeof(struct) further in memory to find the next item in the array. --- Jeroen

1 0

Dynamic memory management in CryptAcquireContext
by Michael Jung 02 Aug '04

02 Aug '04

Alexandre, I've noticed that you applied a modified version of my patch, which tries to fix a potential double free of the "temp" variable in dlls/advapi32/crypt.c's CryptAcquireContextA function. However, I think that the modified version does not fix the problem. Here is a code snippet from the current cvs versionc of crypt.c: CRYPT_Free(temp); ... if (pProv->pFuncs->pCPAcquireContext(&pProv->hPrivate, (CHAR*)pszContainer, dwFlags, pProv->pVTable)) { ... return TRUE; } /* FALLTHROUGH TO ERROR IF FALSE - CSP internal error! */ error: ... CRYPT_Free(temp); ... return FALSE; If the CSP's CPAcquireContext function fails, which is quite common (e.g. because the user specified key container does not exist), the "temp" variable is still free'd twice. I'm aware that my original patch was pretty ugly, due to a lot of redundancy, but I think this is due to fact that the CryptAcquireContext function seems not to be very well structured. I've submitted a patch two weeks ago, which basically was a reimplementation of CryptAcquireContext, but which was not committed (http://www.winehq.org/hypermail/wine-patches/2004/07/0213.html). Rob Shearman commented on this patch and felt that it is overkill to add both a helper function and a new struct type. Is this the reason the patch was not applied? I would be glad to rework the patch, if you give me some hints about what you did not like. However, I would prefer to wait until James Hawkins got his a->w cross call cleanup patch committed, in order not to break his work. Greetings, Michael -- Michael Jung, MSc Be liberal in what you accept, Integrated Circuits and Systems Lab and conservative in what you send. University of Technology, Darmstadt -- Jonathan Postel, Internet Pioneer phone: +49(6151)16-6692 / email: mjung(a)iss.tu-darmstadt.de

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel