wine-devel

wine-devel@winehq.org

10 participants
84460 discussions

winecfg todo list
by Mike Hearn 25 Jul '04

25 Jul '04

So, I talked with Chris and here are some tasks remaining on winecfg. All of these are *easy* and can be done by anybody who has basic coding ability. For a few of them you don't even really need to know C! So come on lurkers, I know you're out there, step on up. Things that need to be done before we should switch to winecfg IMHO are: * Windows Look has no associated edit control. Who modifies this setting these days anyway? I vote for killing the label rather than adding the edit. * UseTakeFocus (FIXME) - why is this a setting in the UI? I don't even know what the UseTakeFocus protocol does, I've certainly never tweaked it. Does it need to be there? At the very least it needs to be rephrased into terms people can understand and the FIXME needs to be removed. * In the Drives tab, the top half is full of widgetry we probably don't want anymore. In particular "Use real windows drive" etc doesn't make much sense, you can just change the c: mapping to get that effect and it's not something we want to encourage anyway. Especially as most people these days seem to use XP rather than Win98 using a real windows drive is fast way to get an inoperable Wine as well as (possibly) a torched Windows install if it's on FAT32 and you can even pick up viruses from them. I kid you not, the other day I ran a program that had been sitting on my Windows XP partition for a few months and my virtual windows drive (I think the term virtual rather than fake sounds better) ended up infected with some W32.Bagle variant. Anyway the top half of this tab doesn't do anything, never did, doesn't make any sense and should just be removed. * We should probably merge the X11 Driver and Audio tabs together as they both have lots of empty space, and rename it to "Audio and Video" or something. I think the term "X11 Driver" doesn't make much sense to many people anyway. Minor cosmetic fix: remove the groupbox on the "about" tab, it doesn't provide any information at all. We also may want to stick the authors list in there, as it's a bit more visible than in the shell32 about box which is hardly ever shown. But obviously these things should not block us switching to it. Once those things are done we can apply the patch to switch Wine to using the registry entirely. Is it worth writing a migration tool? I'm not really sure, I guess some people would like their settings preserved but most of the settings people tweak are just check boxes in the new UI anyway and would take like 5 seconds to restore. AppDefaults are a bigger issue but do many people have lots of these? Oh, final thing, we need to double check that removing the config doesn't regress things. I've been running with no config file for a few months now and while there are a few minor things I don't think they are critical. I may well have missed things though. thanks -mike

2 2

Invalid path L"c:\\WINDOWS" for L"windows" directory: does not exist
by Andreas Davour 25 Jul '04

25 Jul '04

Hi! I try to use wine v.20040505 on FreeBSD5.2 and I just get the error in the subject line. I found another post about this and that OP was just told to check the "dosdevices" directly, since I have such a directory and I don't get any closer to a solution by staring uncomprehending at the files I thought maybe someone could give a wine newbie some more ideas on what to do? I didn't find any "C:" in that directory mentioned, and tried to make a c: synlink to a new directory without any more success. /andreas

3 3

Marshalling tutorial
by Mike Hearn 25 Jul '04

25 Jul '04

Hi guys, Here is the start of some notes on DCOM and OLE RPC. They're intended to help people like Duane who are hitting problems caused by it, and possibly to form the basis of some decent documentation for the developer guide. Things that only a few people understand make me nervous, getting this stuff into writing will maybe help increase the number of people working on Wine - at the very least it means when people move on we're not left stranded. Firstly, even though this is a reasonably high level overview it's not exactly bed time reading. DCOM is massively complex, and tends to abuse and duplicate terminology rampantly. If you read this and get confused or don't understand it DON'T PANIC! That's perfectly normal. I'll use the term "DCOM" to refer to all aspects of COM and OLE marshalling though other terms could certainly be used too. DCOM is a huge, sprawling part of the Windows API and it's impossible to cover it all in one email. If people find this helpful maybe I'll write some more. I'll assume a basic knowledge of COM (interfaces, IUnknown, refcounts etc). The basics are well documented and there are plenty of tutorials on the net. Secondly, my understanding is not 100% complete and is still improving. There may well be mistakes and omissions here. Hopefully Ove, Marcus, Huw or somebody with a better understanding than I, will review it and correct me. BASICS The basic idea behind DCOM is to take a COM object and make it location transparent. That means you can use it from other threads, processes and machines without having to worry about the fact that you can't just dereference the interface vtable pointer to call methods on it. You might be wondering about putting threads next to processes and machines in that last paragraph. You can access thread safe objects from multiple threads without DCOM normally, right? Why would you need RPC magic to do that? Well, the details of why you'd want to do that can be left until later. For now, suffice it to say that COM lets you "marshal" interfaces into other "apartments". An apartment (you may see it referred to as a context in modern versions of COM) can be thought of as a location, and contains objects. Every thread in a program that uses COM exists in an apartment. If a thread wishes to use an object from another apartment, marshalling and the whole DCOM infrastructure gets involved to make that happen behind the scenes. So. Each COM object resides in an apartment, and each apartment resides in a process, and each process resides in a machine, and each machine resides in a network. Allowing those objects to be used from *any* of these different places is what DCOM is all about. The process of marshalling refers to taking a function call in an apartment and actually performing it in another apartment. Let's say you have two machines, A and B, and on machine B there is an object sitting in a DLL on the hard disk. You want to create an instance of that object (activate it) and use it as if you had compiled it into your own program. This is hard, because the remote object is expecting to be called by code in its own address space - it may do things like accept pointers to linked lists and even return other objects. Very basic marshalling is easy enough to understand. You take a method on a remote interface, copy each of its parameters into a buffer, and send it to the remote computer. On the other end, the remote server reads each parameter from the buffer, calls the method, writes the result into another buffer and sends it back. The tricky part is exactly how to encode those parameters in the buffer, and how to convert standard stdcall/cdecl method calls to network packets and back again. This is the job of the RPCRT4.DLL file - or the Remote Procedure Call Runtime. The backbone of DCOM is this RPC runtime, which is an implementation of DCE RPC [1]. DCE RPC is not naturally object oriented, so this protocol is extended with some new constructs and by assigning new meanings to some of the packet fields, to produce ORPC or Object RPC. You might see it called MS-RPC as well. RPC packets contain a buffer containing marshalled data in NDR format. NDR is short for "Network Data Representation" and is similar the XDR format used in SunRPC (the closest native equivalent on Linux to DCE RPC). NDR/XDR are all based on the idea of graph serialization and were worked out during the 80s, meaning they are very powerful and can do things like marshal doubly linked lists and other rather tricky structures. In Wine, our DCOM implementation is *not* based on the RPC runtime, as while few programs use DCOM even fewer use RPC directly so it was developed some time after OLE32/OLEAUT32 were. Eventually this will have to be fixed, otherwise our DCOM will never be compatible with Microsofts. Bear this in mind as you read through the code however. PROXIES AND STUBS Manually marshalling and unmarshalling each method call using the NDR APIs (NdrConformantArrayMarshall etc) is very tedious work, so the Platform SDK ships with a tool called "midl" which is an IDL compiler. IDL or the "Interface Definition Language" is a tool designed specifically for describing interfaces in a reasonably language neutral fashion, though in reality it bears a close resemblence to C++. By describing the functions you want to expose via RPC in IDL therefore, it becomes possible to pass this file to MIDL which spits out a huge amount of C source code. That code defines functions which have the same prototype as the functions described in your IDL but which internally take each argument, marshal it using Ndr, send the packet, and unmarshal the return. Because this code proxies the code from the client to the server, the functions are called proxies. Easy, right? Of course, in the RPC server process at the other end, you need some way to unmarshal the RPCs, so you have functions also generated by MIDL which are the inverse of the proxies: they accept an NDR buffer, extract the parameters, call the real function then marshal the result back. They are called stubs, and stand in for the real calling code in the client process. The sort of marshalling/unmarshalling code that MIDL spits out can be seen in dlls/oleaut32/oaidl_p.c - it's not exactly what it would look like as that file contains DCOM proxies/stubs which are different, but you get the idea. Proxy functions take the arguments and feel them to the NDR marshallers (or picklers), invoke an NdrProxySendReceive and then convert the out parameters and return code. There's a ton of goop in there for dealing with buffer allocation, exceptions and so on - it's really ugly code. But, this is the basic concept behind DCE RPC. INTERFACE MARSHALLING Standard NDR only knows about C style function calls - they can accept and even return structures, but it has no concept of COM interfaces. Confusingly DCE RPC *does* have a concept of RPC interfaces which are just convenient ways to bundle function calls together into namespaces, but let's ignore that for now as it just muddies the water. The primary extension made by Microsoft to NDR then was the ability to take a COM interface pointer and marshal that into the NDR stream. The basic theory of proxies and stubs and IDL is still here, but it's been modified slightly. Whereas before you could define a bunch of functions in IDL, now a new "object" keyword has appeared. This tells MIDL that you're describing a COM interface, and as a result the proxies/stubs it generates are also COM objects. That's a very important distinction. When you make a call to a remote COM object you do it via a proxy object that COM has constructed on the fly. Likewise, a stub object on the remote end unpacks the RPC packet and makes the call. Because this is object-oriented RPC, there are a few complications: for instance, a call that goes via the same proxies/stubs may end up at a different object instance, so the RPC runtime keeps track of "this" and "that" in the RPC packets. This leads naturally onto the question of how we got those proxy/stub objects in the first place, and where they came from. You can use the CoCreateInstanceEx API to activate COM objects on a remote machine, this works like CoCreateInstance API. Behind the scenes, a lot of stuff is involved to do this (like IRemoteActivation, IOXIDResolver and so on) but let's gloss over that for now. When DCOM creates an object on a remote machine, the DCOM runtime on that machine activates the object in the usual way (by looking it up in the registry etc) and then marshals the requested interface back to the client. Marshalling an interface takes a pointer, and produces a buffer containing all the information DCOM needs to construct a proxy object in the client, a stub object in the server and link the two together. The structure of a marshalled interface pointer is somewhat complex. Let's ignore that too. The important thing is how COM proxies/stubs are loaded. COM PROXY/STUB SYSTEM COM proxies are objects that implement both the interfaces needing to be proxied and also IRpcProxyBuffer. Likewise, COM stubs implement IRpcStubBuffer and understand how to invoke the methods of the requested interface. You may be wondering what the word "buffer" is doing in those interface names. I'm not sure either, except that a running theme in DCOM is that interfaces which have nothing to do with buffers have the word Buffer appended to them, seemingly at random. Ignore it and *don't let it confuse you* :) This stuff is convoluted enough ... The IRpc[Proxy/Stub]Buffer interfaces are used to control the proxy/stub objects and are one of the many semi-public interfaces used in DCOM. DCOM is theoretically an internet RFC [2] and is specced out, but in reality the only implementation of it apart from ours is Microsofts, and as a result there are lots of interfaces which *can* be used if you want to customize or control DCOM but in practice are badly documented or not documented at all, or exist mostly as interfaces between MIDL generated code and COM itself. Don't pay too much attention to the MSDN definitions of these interfaces and APIs. COM proxies and stubs are like any other normal COM object - they are registered in the registry, they can be loaded with CoCreateInstance and so on. They have to be in process (in DLLs) however. They aren't activated directly by COM however, instead the process goes something like this: - COM receives a marshalled interface packet, and retrieves the IID of the marshalled interface from it - COM looks in HKEY_CLASSES_ROOT/Interface/{whatever-iid}/ProxyStubClsId32 to retrieve the CLSID of another COM object, which implements IPSFactoryBuffer. - IPSFactoryBuffer has only two methods, CreateProxy and CreateStub. COM calls whichever is appropriate: CreateStub for the server, CreateProxy for the client. MIDL will normally provide an implementation of this object for you in the code it generates. Once CreateProxy has been called, the resultant object is QId to IRpcProxyBuffer, which only has 1 method, IRpcProxyBuffer::Connect [4] This method only takes one parameter, the IRpcChannelBuffer object which encapsulates the "RPC Channel" between the client and server. On the server side, a similar process is performed - the PSFactoryBuffer is created, CreateStub is called, result is QId to IRpcStubBuffer, and IRpcStubBuffer::Connect is used to link it to the RPC channel. RPC CHANNELS Remember the RPC runtime? Well, that's not just responsible for marshalling stuff, it also controls the connection and protocols between the client and server. We can ignore the details of this for now, suffice it to say that an RPC Channel is a COM object that implements IRpcChannelBuffer, and it's basically an abstraction of different RPC methods. For instance, in the case of inter-thread marshalling (not covered here) the RPC connection code isn't used, only the NDR marshallers are, so IRpcChannelBuffer in that case isn't actually implemented by RPCRT4 but rather just by the COM/OLE DLLS (fixme: is this actually correct?). RPC channels are constructed on the fly by DCOM as part of the marshalling process. So, when you make a call on a COM proxy, it goes like this: Your code -> COM proxy object -> RPC Channel -> COM stub object -> Their code HOW THIS ACTUALLY WORKS IN WINE Right now, Wine does not use the NDR marshallers or RPC to implement its DCOM. When you marshal an interface in Wine, in the server process a _StubMgrThread thread is started. I haven't gone into the stub manager here. The important thing is that eventually a _StubReaderThread is started which accepts marshalled DCOM RPCs, and then passes them to IRpcStubBuffer::Invoke on the correct stub object which in turn demarshals the packet and performs the call. The threads started by our implementation of DCOM are never terminated, they just hang around until the process dies. Remember that I said our DCOM doesn't use RPC? Well, you might be thinking "but we use IRpcStubBuffer like we're supposed to ... isn't that provided by MIDL which generates code that uses the NDR APIs?". If so pat yourself on the back, you're still with me. Go get a cup of coffee. TYPELIB MARSHALLER In fact, the reason for the PSFactoryBuffer layer of indirection is because you not all interfaces are marshalled using MIDL generated code. Why not? Well, to understand *that* you have to see that one of the driving forces behind OLE and by extension DCOM was the development Visual Basic. Microsoft wanted VB developers to be first class citizens in the COM world, but things like writing IDL and compiling them with a C compiler into DLLs wasn't easy enough. So, type libraries were invented. Actually they were invented as part of a parallel line of COM development known as "OLE Automation", but let's not get into that here. Type libraries are basically binary IDL files, except that despite there being two type library formats neither of them can fully express everything expressable in IDL. Anyway, with a type library (which can be embedded as a resource into a DLL) you have another option beyond compiling MIDL output - you can set the ProxyStubClsId32 registry entry for your interfaces to the CLSID of the "type library marshaller" or "universal marshaller". Both terms are used, but in the Wine source it's called the typelib marshaller. The type library marshaller constructs proxy and stub objects on the fly. It does so by having generic marshalling glue which reads the information from the type libraries, and takes the parameters directly off the stack. The CreateProxy method actually builds a vtable out of blocks of assembly stitched together which pass control to _xCall, which then does the marshalling. You can see all this magic in dlls/oleaut32/tmarshal.c In the case of InstallShield, it actually comes with typelibs for all the interfaces it needs to marshal (fixme: is this right?), but they actually use a mix of MIDL and typelib marshalling. In order to cover up for the fact that we don't really use RPC they're all force to go via the typelib marshaller - that's what the 1 || hack is for and what the "Registering non-automation type library!" warning is about (I think). WRAPUP OK, so there are some (very) basic notes on DCOM. There's a ton of stuff I have not covered: - Format strings/MOPs - Apartments, threading models, inter-thread marshalling - OXIDs/OIDs, etc, IOXIDResolver - IRemoteActivation - Complex/simple pings, distributed garbage collection - Marshalling IDispatch - Structure of marshalled interface pointers (STDOBJREFs etc) - Runtime class object registration (CoRegisterClassObject), ROT - IRemUnknown - Exactly how InstallShield uses DCOM Then there's a bunch of stuff I still don't understand, like ICallFrame, interface pointer swizzling, exactly where and how all this stuff is actually implemented and so on. But for now that's enough. thanks -mike FURTHER READING Most of these documents assume you have knowledge only contained in other documents. You may have to reread them a few times for it all to make sense. Don't feel you need to read these to understand DCOM, you don't, you only need to look at them if you're planning to help implement it. [1] http://www.opengroup.org/onlinepubs/009629399/toc.htm [2] http://www.grimes.demon.co.uk/DCOM/DCOMSpec.htm [3] http://msdn.microsoft.com/library/default.asp?url=/library/en-us/com/htm/cm… [4] http://msdn.microsoft.com/library/default.asp?url=/library/en-us/com/htm/cm… http://www.microsoft.com/msj/0398/dcom.aspx http://www.microsoft.com/ntserver/techresources/appserv/COM/DCOM/4_Connecti… http://www.idevresource.com/com/library/articles/comonlinux.asp (unfortunately part 2 of this article does not seem to exist anymore, if it was ever written)

5 8

Re: Is bugzilla worth keeping?
by Ivan Leo Puoti 25 Jul '04

25 Jul '04

> 2. The people entering bugs aren't always developers and don't always > have the skills to provide a good bug report. We have a tools for writing bug report, tools/bug_report.pl We should encourage people to use it to write bug reports. Also closing unmaintained bugs would be a good idea. Ivan.

1 0

Re: rsabase unit tests
by Michael Jung 25 Jul '04

25 Jul '04

Am Sonntag, 25. Juli 2004 13:56 schrieben Sie: > Michael Jung wrote: > >Greetings, > >Michael > > > >Changelog: > > Added unit tests for CPGenRandom API function of rsabase.dll > > You seem to be working on Crypto stuff, so I thought I'd better tell you > that I've got a patch pending that implements half of the functionality > in rsabase. > > Rob Thanks for the information. Indeed I've been working on rsabase.dll. When do you plan to submit your patch? I would like to see if at least some of my code can be incorporated, or if the work was in vain. Michael

1 0

location of mouse, scroll wheel handling
by James Hawkins 25 Jul '04

25 Jul '04

Does anyone know where most of the mouse and scroll wheel actions are being handled in the code? For example, say I am surfing the internet with Internet Explorere and WINE and I use my scroll wheel to move the page up and down. Where is the code that handles that? If anyone has any ideas whatsoever (or even if you can just say you don't know) I would really appreciate it. -- James Hawkins

2 1

Re: Support PBS_MARQUE for progress bars
by Thomas Weidenmueller 25 Jul '04

25 Jul '04

Sorry, this patch should compile. Index: dlls/comctl32/progress.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/progress.c,v retrieving revision 1.36 diff -u -r1.36 progress.c --- dlls/comctl32/progress.c 11 Mar 2004 00:39:53 -0000 1.36 +++ dlls/comctl32/progress.c 25 Jul 2004 12:26:33 -0000 @@ -26,9 +26,6 @@ * Unless otherwise noted, we believe this code to be complete, as per * the specification mentioned above. * If you discover missing features, or bugs, please note them below. - * - * TODO - * --support PBS_MARQUE * */ @@ -59,7 +56,9 @@ /* Control configuration constants */ -#define LED_GAP 2 +#define LED_GAP 2 +#define MARQUEE_LEDS 5 +#define ID_MARQUEE_TIMER 1 /*********************************************************************** * PROGRESS_Invalidate @@ -156,51 +155,215 @@ { if (dwStyle & PBS_VERTICAL) { - INT old_top = rect.top; - rect.top = rightBar; - FillRect(hdc, &rect, hbrBar); - rect.bottom = rect.top; - rect.top = old_top; - FillRect(hdc, &rect, hbrBk); + if (dwStyle & PBS_MARQUEE) + { + INT old_top, old_bottom; + old_top = rect.top; + old_bottom = rect.bottom; + + leds = rect.bottom - rect.top; + ledMStart = (infoPtr->MarqueePos + MARQUEE_LEDS) - leds; + + if(ledMStart > 0) + { + rect.top = max(rect.bottom - ledMStart, old_top); + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + } + if(infoPtr->MarqueePos > 0) + { + rect.top = max(old_bottom - infoPtr->MarqueePos, old_top); + FillRect(hdc, &rect, hbrBk); + rect.bottom = rect.top; + } + if(rect.top >= old_top) + { + rect.top = max(rect.bottom - MARQUEE_LEDS, old_top); + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + } + if(rect.top >= old_top) + { + rect.top = old_top; + FillRect(hdc, &rect, hbrBk); + } + } + else + { + INT old_top = rect.top; + rect.top = rightBar; + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + rect.top = old_top; + FillRect(hdc, &rect, hbrBk); + } } else { - INT old_right = rect.right; - rect.right = rightBar; - FillRect(hdc, &rect, hbrBar); - rect.left = rect.right; - rect.right = old_right; - FillRect(hdc, &rect, hbrBk); + if (dwStyle & PBS_MARQUEE) + { + INT old_left, old_right; + old_left = rect.left; + old_right = rect.right; + + leds = rect.right - rect.left; + ledMStart = (infoPtr->MarqueePos + MARQUEE_LEDS) - leds; + rect.right = rect.left; + + if(ledMStart > 0) + { + rect.right = min(rect.left + ledMStart, old_right); + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + } + if(infoPtr->MarqueePos > 0) + { + rect.right = min(old_left + infoPtr->MarqueePos, old_right); + FillRect(hdc, &rect, hbrBk); + rect.left = rect.right; + } + if(rect.right < old_right) + { + rect.right = min(rect.left + MARQUEE_LEDS, old_right); + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + } + if(rect.right < old_right) + { + rect.right = old_right; + FillRect(hdc, &rect, hbrBk); + } + } + else + { + INT old_right = rect.right; + rect.right = rightBar; + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + rect.right = old_right; + FillRect(hdc, &rect, hbrBk); + } } } else { if (dwStyle & PBS_VERTICAL) { - while(rect.bottom > rightBar) { - rect.top = rect.bottom - ledWidth; - if (rect.top < rightMost) - rect.top = rightMost; - FillRect(hdc, &rect, hbrBar); - rect.bottom = rect.top; - rect.top -= LED_GAP; - if (rect.top <= rightBar) break; - FillRect(hdc, &rect, hbrBk); - rect.bottom = rect.top; + if (dwStyle & PBS_MARQUEE) + { + INT i, old_top, old_bottom; + old_top = rect.top; + old_bottom = rect.bottom; + + leds = ((rect.bottom - rect.top) + (ledWidth + LED_GAP) - 1) / (ledWidth + LED_GAP); + ledMStart = (infoPtr->MarqueePos + MARQUEE_LEDS) - leds; + + while(ledMStart > 0) + { + rect.top = max(rect.bottom - ledWidth, old_top); + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + rect.top -= LED_GAP; + if (rect.top <= old_top) break; + FillRect(hdc, &rect, hbrBk); + rect.bottom = rect.top; + ledMStart--; + } + if(infoPtr->MarqueePos > 0) + { + rect.top = max(old_bottom - (infoPtr->MarqueePos * (ledWidth + LED_GAP)), old_top); + FillRect(hdc, &rect, hbrBk); + rect.bottom = rect.top; + } + for(i = 0; i < MARQUEE_LEDS && rect.top >= old_top; i++) + { + rect.top = max(rect.bottom - ledWidth, old_top); + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + rect.top -= LED_GAP; + if (rect.top <= old_top) break; + FillRect(hdc, &rect, hbrBk); + rect.bottom = rect.top; + } + if(rect.top >= old_top) + { + rect.top = old_top; + FillRect(hdc, &rect, hbrBk); + } + } + else + { + while(rect.bottom > rightBar) { + rect.top = rect.bottom - ledWidth; + if (rect.top < rightMost) + rect.top = rightMost; + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + rect.top -= LED_GAP; + if (rect.top <= rightBar) break; + FillRect(hdc, &rect, hbrBk); + rect.bottom = rect.top; + } } rect.top = rightMost; FillRect(hdc, &rect, hbrBk); } else { - while(rect.left < rightBar) { - rect.right = rect.left + ledWidth; - if (rect.right > rightMost) - rect.right = rightMost; - FillRect(hdc, &rect, hbrBar); - rect.left = rect.right; - rect.right += LED_GAP; - if (rect.right >= rightBar) break; + if (dwStyle & PBS_MARQUEE) + { + INT i, old_right, old_left; + old_left = rect.left; + old_right = rect.right; + + leds = ((rect.right - rect.left) + ledWidth - 1) / (ledWidth + LED_GAP); + ledMStart = (infoPtr->MarqueePos + MARQUEE_LEDS) - leds; + rect.right = rect.left; + + while(ledMStart > 0) + { + rect.right = min(rect.left + ledWidth, old_right); + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + rect.right += LED_GAP; + if (rect.right > old_right) break; + FillRect(hdc, &rect, hbrBk); + rect.left = rect.right; + ledMStart--; + } + if(infoPtr->MarqueePos > 0) + { + rect.right = min(old_left + (infoPtr->MarqueePos * (ledWidth + LED_GAP)), old_right); + FillRect(hdc, &rect, hbrBk); + rect.left = rect.right; + } + for(i = 0; i < MARQUEE_LEDS && rect.right < old_right; i++) + { + rect.right = min(rect.left + ledWidth, old_right); + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + rect.right += LED_GAP; + if (rect.right > old_right) break; + FillRect(hdc, &rect, hbrBk); + rect.left = rect.right; + } + if(rect.right < old_right) + { + rect.right = old_right; + FillRect(hdc, &rect, hbrBk); + } + } + else + { + while(rect.left < rightBar) { + rect.right = rect.left + ledWidth; + if (rect.right > rightMost) + rect.right = rightMost; + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + rect.right += LED_GAP; + if (rect.right >= rightBar) break; + FillRect(hdc, &rect, hbrBk); + rect.left = rect.right; + } + rect.right = rightMost; FillRect(hdc, &rect, hbrBk); - rect.left = rect.right; } - rect.right = rightMost; - FillRect(hdc, &rect, hbrBk); } } @@ -229,6 +392,63 @@ /*********************************************************************** + * PROGRESS_Timer + * Handle the marquee timer messages + */ +static LRESULT PROGRESS_Timer (PROGRESS_INFO *infoPtr, INT idTimer) +{ + if(idTimer == ID_MARQUEE_TIMER) + { + LONG style = GetWindowLongW (infoPtr->Self, GWL_STYLE); + RECT rect; + int ledWidth, leds; + + GetClientRect (infoPtr->Self, &rect); + InflateRect(&rect, -1, -1); + + if(!(style & PBS_SMOOTH)) + { + int width, height; + + if(style & PBS_VERTICAL) + { + width = rect.bottom - rect.top; + height = rect.right - rect.left; + } + else + { + height = rect.bottom - rect.top; + width = rect.right - rect.left; + } + ledWidth = MulDiv (height, 2, 3); + leds = (width + ledWidth - 1) / (ledWidth + LED_GAP); + } + else + { + ledWidth = 1; + if(style & PBS_VERTICAL) + { + leds = rect.bottom - rect.top; + } + else + { + leds = rect.right - rect.left; + } + } + + /* increment the marquee progress */ + if(++infoPtr->MarqueePos >= leds) + { + infoPtr->MarqueePos = 0; + } + + InvalidateRect(infoPtr->Self, &rect, TRUE); + } + return 0; +} + + +/*********************************************************************** * PROGRESS_CoercePos * Makes sure the current position (CurVal) is within bounds. */ @@ -304,6 +524,8 @@ infoPtr->MaxVal = 100; infoPtr->CurVal = 0; infoPtr->Step = 10; + infoPtr->MarqueePos = 0; + infoPtr->Marquee = FALSE; infoPtr->ColorBar = CLR_DEFAULT; infoPtr->ColorBk = CLR_DEFAULT; infoPtr->Font = 0; @@ -326,6 +548,9 @@ case WM_PAINT: return PROGRESS_Paint (infoPtr, (HDC)wParam); + case WM_TIMER: + return PROGRESS_Timer (infoPtr, (INT)wParam); + case PBM_DELTAPOS: { INT oldVal; @@ -400,6 +625,19 @@ infoPtr->ColorBk = (COLORREF)lParam; InvalidateRect(hwnd, NULL, TRUE); return 0; + + case PBM_SETMARQUEE: + if(wParam != 0) + { + infoPtr->Marquee = TRUE; + SetTimer(infoPtr->Self, ID_MARQUEE_TIMER, (UINT)lParam, NULL); + } + else + { + infoPtr->Marquee = FALSE; + KillTimer(infoPtr->Self, ID_MARQUEE_TIMER); + } + return infoPtr->Marquee; default: if ((message >= WM_USER) && (message < WM_APP)) Index: include/commctrl.h =================================================================== RCS file: /home/wine/wine/include/commctrl.h,v retrieving revision 1.134 diff -u -r1.134 commctrl.h --- include/commctrl.h 6 Jul 2004 21:02:36 -0000 1.134 +++ include/commctrl.h 25 Jul 2004 12:13:28 -0000 @@ -456,10 +456,12 @@ #define PBM_GETRANGE (WM_USER+7) #define PBM_GETPOS (WM_USER+8) #define PBM_SETBARCOLOR (WM_USER+9) +#define PBM_SETMARQUEE (WM_USER+10) #define PBM_SETBKCOLOR CCM_SETBKCOLOR #define PBS_SMOOTH 0x01 #define PBS_VERTICAL 0x04 +#define PBS_MARQUEE 0x08 typedef struct {

1 0

how can I find what functions a dll file provides?
by James Hawkins 25 Jul '04

25 Jul '04

In what way can I list the API functions provided from a certain dll file? I seem to remember seeing somewhere that you could use a debugger, but I'm not sure. -- James Hawkins

4 3

Re: Implement StdMarshal::ReleaseMarshalData
by Jeroen Janssen 25 Jul '04

25 Jul '04

Mike Hearn wrote: > Mike Hearn <mh(a)codeweavers.com> > Rob Shearman <rob(a)codeweavers.com> > Implement StdMarshal::ReleaseMarshalData > + res = IRpcStubBuffer_Release(stub); I'm not sure but, is there a hypothical race condition here when a thread switch takes place and someone tries to reuse the stub while valid is not set to TRUE yet (but the stub has already been released)? > + stubs[i].valid = FALSE; --- Jeroen Janssen

3 4

(Quite) Slow Starcraft
by Maurizio Monge 25 Jul '04

25 Jul '04

It is now really *slow*, but a quite old 2d game such as starcraft that runs perfectly in a PII 300 under windows should also run perfectly on linux with an AMD64 3200 :-) It happens that using the nasty DGA hack on sourceforge.net/projects/starcraft-wine applied by hand to current cvs it does run (as root) perfectly. but even if X11 is a sucky architecture for games it should run perfectly too with accelerated X11+XShm. Instead it happens that *sometimes* it runs fast (as with DGA), and sometimes it becomes unacceptably slow (for little time, though). I started to give a look at wine source to understand why this strange thing happens, but i fould no place where DGA and X11 code paths could differ in this way... maybe with x11 there are such things as an additionl wine thread or boh... maybe you wine hackers are already aware of similar problems, or may help me to understand what's up (and i would like possibly to help fix it). Thanx Please CC monge(at)sns(dot)it as i'm not subscribed. -- Best Regards Maurizio Monge "..the triumph of evil is for good men to do nothing." (Edmond Burke)

1 0

status of advapi32
by James Hawkins 25 Jul '04

25 Jul '04

Hi all, Using Dependency Walker to extract the function names from the advapi32.dll, I have compiled a list of implemented, stubbed, semi-stubbed, missing, and questionable api functions of advapi32.dll. As for the percentage that is completed, using implemented / total * 100, advapi32.dll is 50% complete. With this format, developers can see what has already been done and what has yet to be done. It puts the whole process into a proper perspective. If anyone has any ideas about this or suggestions, let me know. -- James Hawkins

1 0

Re: Is bugzilla worth keeping?
by Ivan Leo Puoti 24 Jul '04

24 Jul '04

Of course we should keep it. It's a place to track bugs, and keep everything related to a non working application in the same place. And if we didn't have it, people would just flood the devel list with bug reports, or not report at all, and non of them seem a great idea. I've got a couple bugs fixed with bugzilla, and if wine will ever be finished then eventually all the bugs will be fixed. And not really we get messages on the patches list with patches that fix something in bugzilla. And it's a good place to send developers that aren't sure what to do next. Ivan.

3 2

out of sync (MSDN) web references in the wine code
by Jeroen Janssen 24 Jul '04

24 Jul '04

Hello, I'm wondering.. it seems there are a lot (MSDN) web references throughout the code. However, some of those links are out of date. Either the pages do not exist anymore, or moved to somewhere else. Is there any structural way to handle this? I mean, I want to look something up on the web based upon an url in the code, but the page doesn't exist anymore. So I could send in a patch to either remove the link, or find a correct one. But what is stopping (MSDN) people from moving things to a different location again, breaking the link again? --- Jeroen Janssen

2 1

Re: slightly OT: c expression evaluation order
by Diego 'Flameeyes' Pettenò 24 Jul '04

24 Jul '04

Michael Jung wrote: > I've always thought that the order in which subexpressions are evaluated > is not specified in the C language. Isn't there the danger of a NULL > pointer dereference given here? I don't think so. Order is expressed and is from left to right, so if you have two functions and do func1() && func2() if func1() will be evalutated as false, func2() will never be called. I saw code wrote without if statements and using directly the logic operators (also if I don't like this syntax) and also Gentoo's scripts (ebuilds and init.d) uses this syntax for some conditional statements. So it should be sure that there won't be a null pointer deference. Regards, -- Diego "Flameeyes" Pettenò dgp85(a)users.sourceforge.net - http://flameeyes.web.ctonet.it/

1 0

slightly OT: c expression evaluation order
by Michael Jung 24 Jul '04

24 Jul '04

Hello, this is slightly of topic for this mailing list. However, it would be nice if someone could answer my question. I've seen that Alexandre changed the if statement expression in one of my patches from if (pszProvider ? *pszProvider == '\0' : 1) to if (!pszProvider || !*pszProvider) I've always thought that the order in which subexpressions are evaluated is not specified in the C language. Isn't there the danger of a NULL pointer dereference given here? Thanks, Michael

2 1

dlls/winmm/wineoss/audio.c build failure
by Gerald Pfeifer 24 Jul '04

24 Jul '04

The following change to dlls/winmm/wineoss/audio.c revision 1.135 date: 2004/07/19 20:08:06; author: julliard; state: Exp; lines: +1 -1 Francois Gouget <fgouget(a)codeweavers.com> Use round() instead of ceil() in wodGetPosition(TIME_SMPTE). Fixes the corresponding winmm conformance test. causes the following build failure on FreeBSD 4.9: ../../../tools/winegcc/winegcc -B../../../tools/winebuild -shared ./wineoss.drv.spec audio.o midi.o midipatch.o mixer.o mmaux.o oss.o wineoss.drv.dbg.o -o wineoss.drv.so -L../../../dlls -lwinmm -luser32 -lkernel32 -L../../../libs/wine -lwine -ldxguid -luuid -L../../../libs/port -lwine_port audio.o: In function `wodGetPosition': /test/wine/dlls/winmm/wineoss/audio.c:2127: undefined reference to `round' collect2: ld returned 1 exit status winegcc: /sw/gcc-3.3.2/bin/gcc failed. gmake: *** [wineoss.drv.so] Error 2 Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

2 2

Re: wine/dlls/kernel locale.c
by Dmitry Timoshkov 24 Jul '04

24 Jul '04

"Alexandre Julliard" <julliard(a)winehq.org> wrote: > Log message: > Shachar Shemesh <wine-patches(a)shemesh.biz> > System default locale in Windows determines the ANSI encoding > (LC_CTYPE on Unix). I still think that this patch is wrong. On my english win2k with locale set to russian both GetSystemDefaultLCID and GetUserDefaultLCID return 0419. -- Dmitry.

1 0

Division by zero in snd_pcm_rate_sw_params()
by Francois Gouget 24 Jul '04

24 Jul '04

Hi, I am working on Wine and lately I have been tracking various sound related issues. One issue I noticed is a crash in Wine's winmm wave test when using the Alsa sound backend. More precisely: * if Wine's winmm wave test is the only application using the sound device, then it works * but if another application is already using the sound device (e.g. xmms), then Wine's winmm wave test crashes when trying to play the 96kHz test. The crash occurs when calling snd_pcm_sw_params(): EXIT_ON_ERROR( snd_pcm_sw_params(pcm, sw_params), MMSYSERR_ERROR, "unable to set sw params for playback"); See this URL for the exact source: http://source.winehq.org/source/dlls/winmm/winealsa/audio.c#L1602 Digging some more I found out that the division by zero happens in the snd_pcm_rate_sw_params() function pcm_rate.c. Here's why: * Wine sets xfer_align to 1: EXIT_ON_ERROR(snd_pcm_sw_params_set_xfer_align(pcm, sw_params, 1), MMSYSERR_ERROR, "unable to set xfer align"); * then it calls snd_pcm_sw_params() as shown above * eventually we get to snd_pcm_rate_sw_params() in src/pcm/pcm_rate.c. (http://cvs.sourceforge.net/viewcvs.py/alsa/alsa-lib/src/pcm/pcm_rate.c?rev=…) * There we call recalc(): recalc(pcm, &sparams->xfer_align); * when more than one application uses the soundcard, recalc() ends up doing: *val = muldiv_near(*val, slave->period_size, pcm->period_size); * however in my case slave->period_size is less than half of pcm->period_size so I end up with xfer_align == *val == 0. * then, a few lines later in snd_pcm_rate_sw_params() we do: if (sparams->start_threshold > (slave->buffer_size / sparams->xfer_align) * sparams->xfer_align) sparams->start_threshold = (slave->buffer_size / sparams->xfer_align) * sparams->xfer_align; And we crash with a division by zero because now sparams->xfer_align==0. (these lines were added in CVS revision 1.83 of this file) Simply resetting xfer_align to 1 is it is zero after the call to recalc() (see attached patch) fixes the problem for me (no crash and the test tone plays correctly). However I don't know if this is the right fix, hence the following questions: Does my patch look ok? What is the proper procedure to get it applied? Is there further information I can provide to resolve this issue? My configuration: * Up to date Debian testing * Alsa 1.0.5a * cat /proc/asound/cards 0 [V8235 ]: VIA8233 - VIA 8235 VIA 8235 at 0xbc00, irq 5 -- Francois Gouget fgouget(a)codeweavers.com --- pcm_rate.c.orig 2004-07-24 03:19:41.000000000 +0200 +++ pcm_rate.c 2004-07-24 03:20:41.000000000 +0200 @@ -630,6 +638,8 @@ recalc(pcm, &sparams->avail_min); rate->orig_avail_min = sparams->avail_min; recalc(pcm, &sparams->xfer_align); + if (sparams->xfer_align==0) + sparams->xfer_align=1; recalc(pcm, &sparams->start_threshold); if (sparams->start_threshold <= slave->buffer_size) { if (sparams->start_threshold > (slave->buffer_size / sparams->avail_min) * sparams->avail_min)

1 0

Re: make crosstest fails
by Ivan Leo Puoti 24 Jul '04

24 Jul '04

> Or can we actually use this instead? > http://prdownloads.sourceforge.net/wine/wine-w32api-20040505.zip?download You should be able to use them, or I don't see the point of having them. Note that updated versions exist http://prdownloads.sourceforge.net/wine/wine-w32api-20040615.zip?download http://prdownloads.sourceforge.net/wine/wine-w32api-20040716.zip?download Ivan.

1 0

Re: devenum
by Ivan Leo Puoti 23 Jul '04

23 Jul '04

> Why you do not leave the neutral resources in the main archive? That's how it's done in other files, anyway, I'll send another patch that leaves the neutral resources in the main file. Ivan.

1 0

Re: Install msiexec in the bin dir while make install.
by Alexandre Julliard 23 Jul '04

23 Jul '04

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > Alexandre, what are the guidelines for installing winelib applications > in /foo/bin/? It should be restricted to apps that users will frequently run from the command-line on Windows so that they expect the same behavior on Wine, or else to apps prefixed with 'wine' as there isn't a risk of conflict in that case. I'm not sure msiexec qualifies; is it really something that end users are expected to use on Windows? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: French translation and other adjustments
by Francois Gouget 23 Jul '04

23 Jul '04

On Fri, 23 Jul 2004, Marcelo Duarte wrote: > Changelog: > Marcelo Duarte <wine-devel(a)bol.com.br> > French translation and other adjustments + IDS_RESTART_TITLE "Recommencer" + IDS_RESTART_PROMPT "Tu voulez simuler la remise du Windows?" + IDS_SHUTDOWN_TITLE "Débrancher" + IDS_SHUTDOWN_PROMPT "Tu voulez finir la session du Wine?" Urgh! Maybe you meant something like: + IDS_RESTART_TITLE "Recommencer" + IDS_RESTART_PROMPT "Voulez-vous simuler le redémarrage de Windows?" + IDS_SHUTDOWN_TITLE "Arrêter" + IDS_SHUTDOWN_PROMPT "Voulez-vous fermer la la session Wine?" Note: I not entirely sure about 'Arrêter'. Translation can be pretty tricky sometimes... -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Before you criticize someone, walk a mile in his shoes. That way, if he gets angry, he'll be a mile away - and barefoot.

2 1

Re: Add a WINEVER environment variable
by Andreas Mohr 23 Jul '04

23 Jul '04

Hi, I'm afraid I don't like the naming, since it's potentially confusing (plus, it somewhat goes against established rules, "WINE + function"). What about WINEWINVER instead? I for one like it much more. Also, this doesn't take into account that we're also able to set the DOS version. So what would that be called then? WINEVER, too? ;-) WINEWINVER and WINEDOSVER is a much better choice, IMHO. Greetings, Andreas

3 4

Re: COM outproc & CFProxy unhandled interface for IRunnableObject
by Mike Hearn 23 Jul '04

23 Jul '04

CCing to wine-devel as the original reply will be forwarded soon too by Jeroen .. On Fri, 2004-07-23 at 17:58 +0200, Jeroen Janssen wrote: > I had a short look at the 'world of com' patch, and it looks like there > is something in there that implements the IRemUnknown stuff. Is there > any easy way to determine if/how this can be 'ported' to the current wine? The "world of dcom" patch used to apply to WineHQ but it may not these days. Mike did a recent merge of it a month or two ago, maybe he has the latest copy? As to actually merging it into CVS, I'm not sure that's a good idea anymore. There's a lot of duplication there and we understand the code Marcus wrote better than Oves. Marcus is still a part of the project, whereas Ove basically isn't anymore. I think some of it is usable, and some of it is not, but merging it isn't a simple "make it apply cleanly and submit" I'm afraid.

2 1

Re: COM outproc & CFProxy unhandled interface for IRunnableObject
by Robert Shearman 23 Jul '04

23 Jul '04

Jeroen Janssen wrote: > Robert Shearman wrote: > >> Jeroen Janssen wrote: >> >>> Hello, >>> >>> I'm mailing the both of you with a small (com) example attached. >>> >>> It is a client/server/proxystub example (with binaries), so you need to >>> /RegServer the server and regsvr32 the proxy. >>> >>> Now I first manually start the server in a seperate console and then I >>> manually start the client. >>> >>> I modified the client to look for input, so there are basically two >>> paths >>> in the client: >>> >>> * you press: 1 <enter>; the normal path, goes OK >>> hr = >>> CoCreateInstance(CLSID_Calculate,NULL,CLSCTX_LOCAL_SERVER,IID_ICalculate,(void**) >>> >>> &pICalculate); >>> >>> * you press: 2 (or something else) <enter>; the other path, FAILURE >>> hr = >>> CoCreateInstance(CLSID_Calculate,NULL,CLSCTX_LOCAL_SERVER,IID_IUnknown,(void**) >>> >>> &pIUnknown); >>> hr = pIUnknown->QueryInterface(IID_ICalculate, (void **) &pICalculate); >>> >>> Now either there is something wrong with my sample, or there is >>> something >>> wrong in wine that causes this to fail. >>> >>> Can you verify that the client code path is ok (the very few above >>> mentioned lines that differentiate in scenario 1,2). If the client >>> code is >>> ok, then any idea what is actually causing the problem? >> >> >> >> Yes, I can see the problem. What happens with native OLE is that the >> IUnknown part of the object is handled by the proxy manager. What >> this basically means is that it is translated into IRemUnknown >> (remote unknown) calls that will do the appropriate thing. However, >> this is currently not implemented on Wine. >> I'm not sure we (Mike and I) will have time to properly implement >> this, but I could maybe write a quick hack for you sometime over the >> weekend. > > > Ok, thanks for this explanation (that explains why this is not working > yet on wine). > > I had a short look at the 'world of com' patch, and it looks like > there is something in there that implements the IRemUnknown stuff. Is > there any easy way to determine if/how this can be 'ported' to the > current wine? As Mike said, some of it is usable and some of it isn't. Try applying the patch, but YMMV - I ran the patch for a while and it seemed to cause more problems than it solved, particularly in IE. In particular, I don't think the IRemUnknown stuff will be merged as is, because I think the way it is implemented in the patch is not the way it is implemented in Windows (there is only one IRemUnkown interface per apartment) and we only want to write this code once! Rob

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel