wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: FW: WM_NEXTDLGCTL changes the default button ID and does not rest ore default control identifier
by Mike Hearn 17 Jun '04

17 Jun '04

On Thu, 2004-06-17 at 09:09 -0700, Krishna Murthy wrote: > I have submitted this patch last Friday. Today I got the latest update > from the CVS and found that the changes are not applied. > > Earlier I have found that the patches used to get updated overnight. > Please let me know if I am missing anything? OR the patch update > process takes some time? Probably it just needs thinking about, this sort of patch affects core parts of Wine and so often it takes Alexandre some time to decide if the patch is correct or not. Be patient, he is only human ;) Having said that, there are a few things you can do to make it more likely that patches will be applied quickly. 1) Use text mail rather than HTML mail. Alexandre applies patches by feeding the entire email to patch, so the less junk there is the more likely it is to just work. 2) You don't need to provide a long/short description, just a changelog entry is fine. If after a week or so the patch is still not applied, try resending it or asking why it was not applied on wine-devel. thanks -mike

2 1

RE: FW: WM_NEXTDLGCTL changes the default button ID and does not rest ore default control identifier
by Krishna Murthy 17 Jun '04

17 Jun '04

Thanks a lot. Krishna -----Original Message----- From: Mike Hearn [mailto:mike@navi.cx] Sent: Thursday, June 17, 2004 9:28 AM To: wine-devel(a)winehq.org Cc: Krishna Murthy Subject: Re: FW: WM_NEXTDLGCTL changes the default button ID and does not rest ore default control identifier On Thu, 2004-06-17 at 09:09 -0700, Krishna Murthy wrote: > I have submitted this patch last Friday. Today I got the latest update > from the CVS and found that the changes are not applied. > > Earlier I have found that the patches used to get updated overnight. > Please let me know if I am missing anything? OR the patch update > process takes some time? Probably it just needs thinking about, this sort of patch affects core parts of Wine and so often it takes Alexandre some time to decide if the patch is correct or not. Be patient, he is only human ;) Having said that, there are a few things you can do to make it more likely that patches will be applied quickly. 1) Use text mail rather than HTML mail. Alexandre applies patches by feeding the entire email to patch, so the less junk there is the more likely it is to just work. 2) You don't need to provide a long/short description, just a changelog entry is fine. If after a week or so the patch is still not applied, try resending it or asking why it was not applied on wine-devel. thanks -mike

1 0

How to test patches?
by Joel Konkle-Parker 17 Jun '04

17 Jun '04

I want to patch something in wrc/ (hopefully trivial), but I'm not sure how to test for any side effects. Is there a regression test suite or something you guys use to test your patches? Thanks. -- Joel Konkle-Parker Webmaster [Ballsome.com] E-mail [jjk3(a)msstate.edu]

2 1

[DCOM95] not installable: "a newer version had been installed"
by Luca Capello 17 Jun '04

17 Jun '04

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, as Mike Hearn asked if 'wineinstall' is still needed [1], I was making some tests with no config file and a fresh 'fake_windows' created automatically by 'wine-20040615'. This is the first test of two: 'Adobe Illustrator 10' doesn't install because a problem with the DCOM95 package The steps: - - get and uncompress 'Wine-20040615' - - ./configure && make depend && make - - su root - - make install - - CTRL-D - - then the following ===== luca@gismo:~/cvs/wine-20040615$ wine /home/luca/win32_install/Adobe/Adobe.Illustrator.10/Adobe\ Illustrator\ 10/Setup.exe wine: creating configuration directory '/home/luca/.wine'... wine: '/home/luca/.wine' created successfully. fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:create_marshalled_proxy Failed to read marshal id from classfactory of {91814ec0-b5f0-11d2-80b9-00104b1f6cea}. ************************************************************************** You must copy a 'stdole32.tlb' file to your Windows\System directory! You can get one from a Windows installation, or look for the DCOM95 package on the Microsoft Download Pages. ************************************************************************** fixme:ole:LoadTypeLibEx Wanted to load L"stdole32.tlb" as typelib, but file was not found. fixme:ole:_get_funcdesc Did not find a typeinfo for reftype 0? fixme:ole:PSFacBuf_CreateProxy GetFuncDesc 80004005 should not fail here. fixme:ole:StdMarshalImpl_UnmarshalInterface Failed to create a proxy for {91814ec1-b5f0-11d2-80b9-00104b1f6cea} fixme:ole:CoUnmarshalInterface Failed to Unmarshal the interface, 80004005? fixme:ole:_unmarshal_interface Marshalling interface {91814ec1-b5f0-11d2-80b9-00104b1f6cea} failed with 80004005 fixme:ole:deserialize_param failed to stuballoc in TKIND_RECORD. fixme:ole:xCall Failed to unmarshall param, hres 80004005 wine: Unhandled exception (thread 0009), starting debugger... fixme:console:SetConsoleCtrlHandler (0x405de730,1) - no error checking or testing yet WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00404a34). In 32 bit mode. 0x00404a34: movl 0x0(%eax),%ecx Wine-dbg> Wine-dbg>WineDbg terminated on pid 0x8 fixme:ole:_xread Read only 0 of 4 bytes from 0x50. fixme:ole:_StubReaderThread Failed with hres 80004005 luca@gismo:~/cvs/wine-20040615$ ===== I downloaded the DCOM95 package [2], but when I tried to install it, I got the message window: "A newer version of DCOM95 or DCOM98 had been installed. To override, you must uninstall the current version first." with this message in the 'gnome-terminal': ===== luca@gismo:~/cvs/wine-20040615$ wine /home/luca/.wine/drive_c/windows/temp/x86/DCom95.Exe err:module:load_builtin_dll loaded .so for L"setupx.dll" but got L"setupapi.dll" instead - probably 16-bit dll luca@gismo:~/cvs/wine-20040615$ ===== The same if I try to install DCOM98... and I can't install 'Adobe Illustrator 10' :-( With the 'fake_windows' provided by the 'WineTools' [3], I can install the DCOM98 with no problem. Is this the same problem reported as bug #1456 [4]? Or is it a problem of mine? Thx, bye, Gismo / Luca [1] http://www.winehq.org/hypermail/wine-devel/2004/06/0242.html [2] http://www.microsoft.com/com/dcom/dcom95/download.asp [3] http://franksworld.net/winetools.html [4] http://bugs.winehq.org/show_bug.cgi?id=1456 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Debian - http://enigmail.mozdev.org iD8DBQFA0BxYVAp7Xm10JmkRAqptAJ45+cwvWG0ZX8zrAxRRvGmW7m39UwCfUA83 3s222OvH6YaXFtzLA0uK/ro= =TMuG -----END PGP SIGNATURE-----

4 6

WineHQ-hosted projects?
by Joel Konkle-Parker 17 Jun '04

17 Jun '04

I'd like to start up a WINE-based project to further development for a specific app. (e.g. The WINE-Star Wars Galaxies Project, or The WINE-Internet Explorer Project). Does WineHQ have a place to host such things (with their own sites, etc.), or should I turn to SourceForge? -- Joel Konkle-Parker Webmaster [Ballsome.com] E-mail [jjk3(a)msstate.edu]

4 6

RE: Text message
by Johane 17 Jun '04

17 Jun '04

1 0

New changes
by Twickline 17 Jun '04

17 Jun '04

1 0

Changes..
by Twickline 17 Jun '04

17 Jun '04

1 0

Re: dlls/dinput/mouse.c - GetDeviceState
by Lionel Ulmer 17 Jun '04

17 Jun '04

> this patch adds a missing errorcode in GetDeviceState in > dlls/dinput/mouse.c which prevented the mouse to work in some game. Which games did require this error to be set ? I seem to remember some hacks around this but I do not remember if it was an error added in the GetDeviceData function or an error removed somewhere because it relied on getting something even if not acquired... I will try a test application when I have access to my Windows development machine to get the error code :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 1

Re: dlls/dinput/mouse.c warp handling
by Lionel Ulmer 17 Jun '04

17 Jun '04

> this is a more complete version of my mouse patch in which I tried to > remove this funny mouse-warping-stuff. > > the mouse feels much better this way, but I am new to wine and maybe I > missed something important and/or did not remove the mousewarping cleanly. Errrm, do you understand exactly what you remove and why it was in the code ? Basically, if you remove mouse warping, when you play games like Quake, you will only be able to turn to your right (or left :-) ) for a fixed amount... I.e. up until the point where the mouse will hit the right border of the window. I agree though that 2D games (like StarCraft or others) will feel a LOT better with a patch like that, but it's plainly wrong. The only way to fix this is to sometimes warp the mouse back in the middle of the window (or to use DGAMouse (or to write a new X11 extension :-) )). Lionel -- Lionel Ulmer - http://www.bbrox.org/

3 5

Re: [KERNEL] add CmdBatNotification stub
by Dmitry Timoshkov 17 Jun '04

17 Jun '04

<markus.amsler(a)oribi.org> wrote: > CmdBatNotification is used by cmd.exe when executing a bat file. > Found no documentation about this function, so I dissassembled it: Please do not send disassembled Windows code to these lists. To find number of arguments for an API call there is no need to disassemble anything, just run an app with +snoop and it will do the job for you. -- Dmitry.

3 2

D3D9 - Anyone working on that
by Andrei Barbu 16 Jun '04

16 Jun '04

Hey, Is anyone working on DX9? It's all implemented by stubs right now, and I was thinking of lending a hand. If anyone's doing that, do you have a place where I can see how far you've gotten. No point in reinventing the wheel. I probably won't be able to do very advanced work with it because I've barely touched DX under Windows, I can find a few books on it though. Also I've never used DX shaders, only CG so unless it's very close to that I can't much help there, I am willing to try though. If noone's in the middle of doing that, I guess I can start on my own. Thanks, Andrei

2 1

[PHOTOSHOP7] not installable, OS not supported, for NT4 service pack >= 6a
by Luca Capello 16 Jun '04

16 Jun '04

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, this is the second test with no config file as Mike Hearn suggested [1]. 'Adobe Photoshop 7.0' can't be installed: the problem is grave, as the installation process doesn't start at all. The steps: ===== luca@gismo:~/cvs/wine-20040615$ rm -rf /home/luca/.wine/ luca@gismo:~/cvs/wine-20040615$ wine /home/luca/win32_install/Adobe/Adobe.Photoshop.7/Photoshop/Setup.exe wine: creating configuration directory '/home/luca/.wine'... wine: '/home/luca/.wine' created successfully. fixme:dialog:MSGBOX_OnInit task modal msgbox ! Not modal yet. luca@gismo:~/cvs/wine-20040615$ ===== I can see the 'Photoshop 7' logo window, but then another window appears with this message: "This operating system is not supported by this installation. For Windows NT 4, you must have service pack 6a or greater to install. Setup will now quit." And pressing OK causes nothing, I mean, I don't need to press OK to have 'wine' quitting: I can leave the message window open and continue to use the 'gnome-terminal' with no problem. Again, with the 'fake_windows' provided by the 'WineTools' [2], I can install 'Photoshop 7.0' with all the options (included 'ImageReady'). The only problem I get is an error creating the icon set, but pressing 'OK' lets the installation process to finish cleanly. Solutions? Thx, bye, Gismo / Luca [1] http://www.winehq.org/hypermail/wine-devel/2004/06/0242.html [2] http://franksworld.net/winetools.html -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Debian - http://enigmail.mozdev.org iD8DBQFA0CH4VAp7Xm10JmkRAmufAJ9yKlSlSJhV6Wt0C1RIYGdoacLsxgCfUi1B /bN09F/mXRzMmG5lKTqDQss= =ARER -----END PGP SIGNATURE-----

2 2

Re: WineHQ-hosted projects?pecific app. (e.g. The WINE-Star Wars Galaxies Project, or The
by Brian Vincent 16 Jun '04

16 Jun '04

> I'd like to start up a WINE-based project to further development for a > specific app. (e.g. The WINE-Star Wars Galaxies Project, or The > WINE-Internet Explorer Project). Does WineHQ have a place to host such > things (with their own sites, etc.), or should I turn to SourceForge? Another resource is the AppDB: http://appdb.winehq.org I'd think all the details could go in there. Ideally it would all work out of the box and there would be no reason for special instructions. -Brian

1 0

Re: PATCH: fix dlls/ntdll/cdrom.c breakage
by Uwe Bonnes 16 Jun '04

16 Jun '04

>>>>> "Gerald" == Gerald Pfeifer <gerald(a)pfeifer.com> writes: Gerald> The following patch to dlls/ntdll/cdrom.c revision 1.46 date: Gerald> 2004/06/15 00:45:01; author: julliard; state: Exp; lines: +421 Gerald> -1 Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> Support Gerald> for reading encrypted DVDs. Gerald> causes a build failure on all FreeBSD (and it seems also NetBSD) Gerald> platforms: Gerald> cdrom.c: In function `DVD_EndSession': cdrom.c:1739: error: Gerald> `dev' undeclared (first use in this function) cdrom.c:1739: Gerald> error: (Each undeclared identifier is reported only once Gerald> cdrom.c:1739: error: for each function it appears in.) Gerald> cdrom.c:1739: error: `rmv' undeclared (first use in this Gerald> function) gmake[2]: *** [cdrom.o] Error 1 gmake[2]: Leaving Gerald> directory `/.amd_mnt/nashira/files5/test/wine/dlls/ntdll' Gerald> gmake[1]: *** [ntdll] Error 2 Gerald> There is BSD-specific code in this function, but both dev and Gerald> rmv do not appear anywhere, so I guess this was copied from Gerald> somewhere else and then not adjusted? The Non-Linux side of the patch was never tested. Appended patch return STATUS_NOT_SUPPORTED for that code clause and should make the code compile again. Gerald, can you perhaps have a look at the implementation of the BSD parts? libdvdcss should have all the needed calls somewhere. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/ntdll/cdrom.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/cdrom.c,v retrieving revision 1.46 diff -u -w -r1.46 cdrom.c --- wine/dlls/ntdll/cdrom.c 15 Jun 2004 00:45:01 -0000 1.46 +++ wine/dlls/ntdll/cdrom.c 16 Jun 2004 15:11:00 -0000 @@ -1736,7 +1736,8 @@ TRACE("\n"); return CDROM_GetStatusCode(ioctl(fd, DVD_AUTH, &auth_info)); #elif defined(__FreeBSD__) || defined(__NetBSD__) - return CDROM_GetStatusCode(ioctl(cdrom_cache[dev].fd, (rmv->PreventMediaRemoval) ? CDIOCPREVENT : CDIOCALLOW, NULL)); + TRACE("bsd\n"); + return STATUS_NOT_SUPPORTED; #else return STATUS_NOT_SUPPORTED; #endif

1 0

Re: WineHQ-hosted projects?
by chmorgan＠charter.net 16 Jun '04

16 Jun '04

No need to fork winehq to support such things. Imaging having to keep up with all of the patches applied to the mainline code? It's probably better just to fix things that break those apps in the winehq tree so every other app gets the benifit. Chris > > From: Joel Konkle-Parker <jjk3(a)msstate.edu> > Date: 2004/06/16 Wed AM 07:09:28 EDT > To: wine-devel(a)winehq.com > Subject: WineHQ-hosted projects? > > I'd like to start up a WINE-based project to further development for a > specific app. (e.g. The WINE-Star Wars Galaxies Project, or The > WINE-Internet Explorer Project). Does WineHQ have a place to host such > things (with their own sites, etc.), or should I turn to SourceForge? > > > -- > Joel Konkle-Parker > Webmaster [Ballsome.com] > > E-mail [jjk3(a)msstate.edu] > > >

1 0

Notification
by Twickline 16 Jun '04

16 Jun '04

1 0

Fax Message Received
by Twickline 16 Jun '04

16 Jun '04

1 0

Debugger spews elf_new_wine_thunks fixmes
by Mike Hearn 16 Jun '04

16 Jun '04

Hi Eric, I get a lot of messages like this since the new debugger shuffle patch landed: fixme:dbghelp:elf_new_wine_thunks Duplicate in kernel32<elf>: audiocdW.6<40515de8-00000012> audiocdW<40515de8-00000000> For now I just changed the fixme to a warn in my local tree - what does this message mean though? It makes it much harder to use the debugger currently. thanks -mike

4 4

WineHQ-hosted projects?
by Joel Konkle-Parker 16 Jun '04

16 Jun '04

1 0

assertion "view->next->flags & VFLAG_SYSTEM" failed: file "virtual.c", line 330
by jordan lougheed 16 Jun '04

16 Jun '04

WINE BUILD: /wine-20040505 I need Internet Explorer on my workstation (openbsd 3.4) at work, so I decided to see if I could get the lastest wine to compile/run. I'll list the steps required to get it to build and install. `sh configure` complained about 'libGL.a' so i renamed it and the configure completed successfully. `make` ./loader/kthread.c: line 276 complained about an unknown flag `RFTHREAD` so i erased that flag from the code, and the build continued. (openbsd's rfork doesn't support that flag, side effects are unknown) `make install` wouldn't complete. I had to `gmake install`. worked fine. everything is built and installed, now here is my problem. $ wine notepad.exe wine:/usr/local/lib/wine/ntdll.dll.so: undefined symbol 'DllMain' wine: /usr/local/lib/wine/ntdll.dll.so: can't resolve reference 'DllMain' fixme:ntdll:NtQueryVolumeInformationFile device info not properly supported on this platform fixme:file:get_default_drive_device auto detection of DOS devices not supported on this platform assertion "view->next->flags & VFLAG_SYSTEM" failed: file "virtual.c", line 330 the "fixme:" problems seem to be common with FreeBSD, so i figure i can ignore them. I always seems to hit that assertion on no matter what i run. The first time i ran this "PokerStarsInstall.exe" it ran fine and gave me the install menu after configuring the "font cache". The second time it gave me this usual assertion. If someone can confirm/deny that this is related the that FLAG i erased from kthread.c (i don't think these are related). Or is there something else going on here? If anyone can offer any help it would be appreciated. I'm going to compile with -DNDEBUG tommorow and see what happends, until then i'll let you guys stew on this. Thank you in advance, JordanL

1 0

3GB address space
by Shachar Shemesh 15 Jun '04

15 Jun '04

Hi all, Is there a way to run processes intended for a 3GB user addressable memory to work under Wine? I'm talking here, of course, assuming that the Linux kernel is compiled with the relevant big memory support. Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

4 11

Re: GetAcceptLanguages A->W [2nd][resend]
by Alexandre Julliard 15 Jun '04

15 Jun '04

Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > Hello, > > anything wrong with this patch? The last error handling is very suspicious, I doubt the function sets ERROR_FILE_NOT_FOUND on a null buffer. I think it's because your test is broken, you need to clear last error before every call if you want to be able to test it afterwards otherwise you just get leftovers from a previous call. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winetest: move to resources (take n+1)
by Alexandre Julliard 15 Jun '04

15 Jun '04

Ferenc Wagner <wferi(a)afavant.elte.hu> writes: > Alexandre Julliard <julliard(a)winehq.org> writes: > >> Also I think it would be cleaner to use a different rc >> file for the dist case instead of using #ifdefs. > > I agree. The problem is the single-rc-file limitation, > which would require some code duplication. That's why I > went for the #ifdefs. Please come back at me if you still > have strong feelings about this. What you can do is have a dist.rc file that defines the extra values and then #includes the normal .rc file. This way there is no duplication and no problems with multiple rc files. The only thing is that the code should behave gracefully when the extra resources are missing, but that would be a good thing to do anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [WineHQ] service.cgi fixes
by Paul Millar 15 Jun '04

15 Jun '04

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Dimi, Why remove the verification of the code's gpg signature? It seems to break a basic security maxim: don't trust the network. On Thursday 10 June 2004 22:48, Dimitrie O. Paun wrote: > ChangeLog > Do not include irrelevant stuff in the _history. > Do not instruct the client to verify the .sig, > it's a b0rken idea anyway. - -- Paul Millar -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFAybhq/9JwS78PA+kRAuv/AJ9Ulntb1MLGn+2gp8r/qpy6VqJDVACePwVB VXxAHr9gaBuMhIJ7P81ahMA= =0tkh -----END PGP SIGNATURE-----

3 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel