wine-devel

wine-devel@winehq.org

10 participants
84459 discussions

Unsupported feature in SHFileOperationW
by Lionel Ulmer 28 May '04

28 May '04

Hi all, A game demo installer uses SHFileOperationA to copy files over... And it expects also the destination directories to be created when the copy is done. Basically, it gives a list of fully qualified source files and their corresponding fully qualified destination files and cann the SHFileOperationA function with the 'FO_COPY' function and 'FOF_MULTIDESTFILES FOF_NOCONFIRMATION FOF_NOCONFIRMMKDIR' flags. This seems to not be handled properly in the current Wine tree as it fails as soon as it needs to create the directory on the destination files. I tested this on Windows and it works just fine (with nice MessageBoxes if one ommits the 'NOCONFIRMMKDIR' flag :-) ). Is anyone (Martin, Ge ?) currently working on Shell32 who has an updated tree with fixes in the Shell file operations ? If not, I will try to fix it on my own (be aware though that as I find the style of coding used in this file particularely hard to decipher, I may do a 'NIH' on it and rewrite most of it to fit my tastes :-) ). Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

focused code review
by Glen Kaukola 28 May '04

28 May '04

Hi, So one project suggested on the website is to do a focused code review. In particular it talks about getting rid of inefficient uses of strcat. But that leaves me wondering what exactly constitutes an inefficient use of strcat? If anyone could provide an example I'd appreciate it. Thanks. Glen

2 1

Re: Default to 96dpi for the no config file case
by Rolf Kalbermatter 28 May '04

28 May '04

>If you mean via DDC then I guess this should work in most places, but for >whatever reason it does not work here :( In particular, xdpyinfo says: > >screen #0: > dimensions: 1024x768 pixels (321x241 millimeters) > resolution: 81x81 dots per inch > >So it appears to know the screen size (I measured with a ruler and >321x241 is right), but it gets the DPI too small anyway. At 81 dpi the >text is hardly readable. But: 1024/321*25.4 = 81.026 768/241*25.4 = 80.943 Seems to me X has it very right. That Windows usually doesn't care about real resolutions and instead fudges with it (consider the Large Font setting in the Display Control Panel) is probably another issue. Or the metrics this function requires are not dots per inch but something else. Rolf Kalbermatter

1 0

Re: Default to 96dpi for the no config file case
by Rein Klazes 28 May '04

28 May '04

On Thu, 27 May 2004 22:18:20 +0100, you wrote: > wineprefixcreate doesn't create a config file. This means we use a (wrong) > formula to decide what the DPI is supposed to be. Why do you mean (wrong) ? Do you not get the dpi values used by X? Or is it that is uses the X values but those are wrong? > It's wrong because > nobody tells the system how big their monitor is these days so it always > picks a DPI that is too small. Here X gets it from the monitor at start-up (via the logic of the video card). I did not realize that my situation is not normal. Somehow, I think setting a proper dpi should ideally be done in X. But in practice ... I agree with you that 95 dpi is about the minimum that is being used today. But I would keep this the minimum: if the dpi is set bigger then it is probably intentional. Either monitor magic or from a careful system administration. Rein. -- Rein Klazes rklazes(a)xs4all.nl

4 4

Re: Add documentation on the address space layout in Wine
by Pouech Eric DMI AEI CAEN 28 May '04

28 May '04

Hi Mike I've started to revisit the architecture.sgml file, and started to write also about this matters (and a few others). For coherency reasons, if you don't mind, I'll reintegrate your bits in the architecture.sgml file (what you wrote covers also process image loading...). A+ > Message du 28/05/04 01:35 > De : "Mike Hearn" > A : wine-patches(a)winehq.com > Copie à : > Objet : Add documentation on the address space layout in Wine > Mike Hearn > Add documentation on the address space layout in Wine > > Generated from: > * mike(a)navi.cx--2004/wine--mainline--0.9--patch-25 > > --- /dev/null 2003-09-15 14:40:47.000000000 +0100 > +++ documentation/address-space.sgml 2004-05-28 00:26:06.000000000 +0100 > @@ -0,0 +1,175 @@ > + > + > + > + > + Every Win32 process in Wine has its own dedicated native process on the host system, and > + therefore its own address space. This section explores the layout of the Windows address space > + and how it is emulated. > + > + > + > + Firstly, a quick recap of how virtual memory works. Physical memory in RAM chips is split > + into frames, and the memory that each process sees is split > + into pages. Each process has its own 4 gigabytes of address space (4gig > + being the maximum space addressable with a 32 bit pointer). Pages can be mapped or unmapped: > + attempts to access an unmapped page cause an EXCEPTION_ACCESS_VIOLATION which has the > + easily recognizable code of 0xC0000005. Any page can be mapped to any frame, therefore you can > + have multiple addresses which actually "contain" the same memory. Pages can also be mapped to > + things like files or swap space, in which case accessing that page will cause a disk access to > + read the contents into a free frame. > + > + > + > + > + > + > + When a Win32 process starts, it does not have a clear address space to use as it pleases. Many pages > + are already mapped by the operating system. In particular, the EXE file itself and any DLLs it > + needs are mapped into memory, and space has been reserved for the stack and a couple of heaps > + (zones used to allocate memory to the app from). Some of these things need to be at a fixed > + address, and others can be placed anywhere. > + > + > + > + The EXE file itself is almost always mapped at address 0x400000 and up: indeed, most EXEs have > + their relocation records stripped which means they must be loaded at their base address and > + cannot be loaded at any other address. > + > + > + > + DLLs are internally much the same as EXE files but they have relocation records, which means > + that they can be mapped at any address in the address space. Remember we are not dealing with > + physical memory here, but rather virtual memory which is different for each > + process. Therefore OLEAUT32.DLL may be loaded at one address in one process, and a totally > + different one in another. Ensuring all the functions loaded into memory can find each other > + is the job of the Windows dynamic linker, which is a part of NTDLL. > + > + > + > + So, we have the EXE and its DLLs mapped into memory. Two other very important regions also > + exist: the stack and the process heap. The process heap is simply the equivalent of the libc > + malloc arena on UNIX: it's a region of memory managed by the OS which malloc/HeapAlloc > + partitions and hands out to the application. Windows applications can create several heaps but > + the process heap always exists. It's created as part of process initialization in > + dlls/ntdll/thread.c:thread_init(). > + > + > + > + There is another heap created as part of process startup, the so-called shared or system > + heap. This is an undocumented service that exists only on Windows 9x: it is implemented in > + Wine so native win9x DLLs can be used. The shared heap is unusual in that anything allocated > + from it will be visible in every other process. This heap is always created at the > + SYSTEM_HEAP_BASE address or 0x65430000 and defaults to a megabyte in size. > + > + > + > + So far we've assumed the entire 4 gigs of address space is available for the application. In > + fact that's not so: only the lower 2 gigs are available, the upper 2 gigs are on Windows NT > + used by the operating system and hold the kernel (from 0x80000000). Why is the kernel mapped > + into every address space? Mostly for performance: while it's possible to give the kernel its > + own address space too - this is what Ingo Molnars 4G/4G VM split patch does for Linux - it > + requires that every system call into the kernel switches address space. As that is a fairly > + expensive operation (requires flushing the translation lookaside buffers etc) and syscalls are > + made frequently it's best avoided by keeping the kernel mapped at a constant position in every > + processes address space. > + > + > + > + On Windows 9x, in fact only the upper gigabyte (0xC0000000 and up) is used by the kernel, the > + region from 2 to 3 gigs is a shared area used for loading system DLLs and for file > + mappings. The bottom 2 gigs on both NT and 9x are available for the programs memory allocation > + and stack. > + > + > + > + There are a few other magic locations. The bottom 64k of memory is deliberately left unmapped > + to catch null pointer dereferences. The region from 64k to 4mb are reserved for DOS > + compatibility and contain various DOS data structures. Finally, the address space also > + contains mappings for the Wine binary itself, any native libaries Wine is using, the glibc > + malloc arena and so on. > + > + > + > + > + > + > + > + > + Up until about the start of 2004, the Linux address space very much resembled the Windows 9x > + layout: the kernel sat in the top gigabyte, the bottom pages were unmapped to catch null > + pointer dereferences, and the rest was free. The kernels mmap algorithm was predictable: it > + would start by mapping files at low addresses and work up from there. > + > + > + > + The development of a series of new low level patches violated many of these assumptions, and > + resulted in Wine needing to force the Win32 address space layout upon the system. This > + section looks at why and how this is done. > + > + > + > + The exec-shield patch increases security by randomizing the kernels mmap algorithms. Rather > + than consistently choosing the same addresses given the same sequence of requests, the kernel > + will now choose randomized addresses. Because the Linux dynamic linker (ld-linux.so.2) loads > + DSOs into memory by using mmap, this means that DSOs are no longer loaded at predictable > + addresses, so making it harder to attack software by using buffer overflows. It also attempts > + to relocate certain binaries into a special low area of memory known as the ASCII armor so > + making it harder to jump into them when using string based attacks. > + > + > + > + Prelink is a technology that enhances startup times by precalculating ELF global offset > + tables then saving the results inside the native binaries themselves. By grid fitting each > + DSO into the address space, the dynamic linker does not have to perform as many relocations > + so allowing applications that heavily rely on dynamic linkage to be loaded into memory much > + quicker. Complex C++ applications such as Mozilla, OpenOffice and KDE can especially benefit > + from this technique. > + > + > + > + The 4G VM split patch was developed by Ingo Molnar. It gives the Linux kernel its own address > + space, thereby allowing processes to access the maximum addressable amount of memory on a > + 32-bit machine: 4 gigabytes. It allows people with lots of RAM to fully utilise that in any > + given process at the cost of performance: as mentioned previously the reason behind giving > + the kernel a part of each processes address space was to avoid the overhead of switching on > + each syscall. > + > + > + > + Each of these changes alter the address space in a way incompatible with Windows. Prelink and > + exec-shield mean that the libraries Wine uses can be placed at any point in the address > + space: typically this meant that a library was sitting in the region that the EXE you wanted > + to run had to be loaded (remember that unlike DLLs, EXE files cannot be moved around in > + memory). The 4G VM split means that programs could receive pointers to the top gigabyte of > + address space which some are not prepared for (they may store extra information in the high > + bits of a pointer, for instance). In particular, in combination with exec-shield this one is > + especially deadly as it's possible the process heap could be allocated beyond > + ADDRESS_SPACE_LIMIT which causes Wine initialization to fail. > + > + > + > + The solution to these problems is for Wine to reserve particular parts of the address space > + so that areas that we don't want the system to use will be avoided. We later on > + (re/de)allocate those areas as needed. One problem is that some of these mappings are put in > + place automatically by the dynamic linker: for instance any libraries that Wine > + is linked to (like libc, libwine, libpthread etc) will be mapped into memory before Wine even > + gets control. In order to solve that, Wine overrides the default ELF initialization sequence > + at a low level and reserves the needed areas by using direct syscalls into the kernel (ie > + without linking against any other code to do it) before restarting the standard > + initialization and letting the dynamic linker continue. This is referred to as the > + preloader and is found in ld-winepreload.so (loader/preloader.c) > + > + > + > + Once the usual ELF boot sequence has been completed, some native libraries may well have been > + mapped above the 3gig limit: however, this doesn't matter as 3G is a Windows limit, not a > + Linux limit. We still have to prevent the system from allocating anything else above there > + (like the heap or other DLLs) though so Wine performs a binary search over the upper gig of > + address space in order to iteratively fill in the holes with MAP_NORESERVE mappings so the > + address space is allocated but the memory to actually back it is not. This code can be found > + in libs/wine/mmap.c:reserve_area. > + > + > + > + > + > --- documentation/wine-devel.sgml > +++ documentation/wine-devel.sgml > @@ -13,6 +13,7 @@ > > > > + > > > > @@ -138,6 +139,7 @@ > &implementation; > &porting; > &consoles; > + &address-space; > &cvs-regression; > > > > >

1 0

[Fwd: winetest: copy and submit manually]
by Robert Reif 28 May '04

28 May '04

oops, wrong list.

1 0

RE: FW: Edit Paste operation does not behave same as MS Windows
by Krishna Murthy 28 May '04

28 May '04

This means it is sufficient to return FALSE in EDIT_MakeFit if the honor limit is not set and size exceeds the buffer limit? static BOOL EDIT_MakeFit(EDITSTATE *es, UINT size, BOOL honor_limit) { HLOCAL hNew32W; if ((!honor_limit) && (es->buffer_limit > 0) && (size > es->buffer_limit)) { EDIT_NOTIFY_PARENT(es, EN_MAXTEXT, "EN_MAXTEXT"); return FALSE; } ... } I will verify with this change and if works in all condition, will submit the patch. Thanks for your help, Krishna -----Original Message----- From: Alexandre Julliard [mailto:julliard@winehq.org] Sent: Thursday, May 27, 2004 5:12 PM To: Krishna Murthy Cc: wine-devel(a)winehq.org Subject: Re: FW: Edit Paste operation does not behave same as MS Windows Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > Actually the logic truncates the data which exceeded the buffer. If > the honor limit is set and the size exceeded, the EDIT_MakeFit will return TRUE. > The following code after the EDIT_MakeFit will try to take limit to > the buffer size. > > + /* Only replace or insert that many characters that can fit into the > + edit control. Do this only if honor_limit is TRUE */ > + if(honor_limit && strl > es->buffer_limit) > + strl = es->buffer_limit - (tl - (e-s)); That only takes into account the limit, not the current buffer size. It's very possible that you need to grow the buffer even when the limit is not exceeded. Also you only check the length of the inserted string against the limit, you should check the total resulting length instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: FW: Edit Paste operation does not behave same as MS Windows
by Krishna Murthy 28 May '04

28 May '04

Actually the logic truncates the data which exceeded the buffer. If the honor limit is set and the size exceeded, the EDIT_MakeFit will return TRUE. The following code after the EDIT_MakeFit will try to take limit to the buffer size. + /* Only replace or insert that many characters that can fit into the + edit control. Do this only if honor_limit is TRUE */ + if(honor_limit && strl > es->buffer_limit) + strl = es->buffer_limit - (tl - (e-s)); Krishna -----Original Message----- From: Alexandre Julliard [mailto:julliard@winehq.org] Sent: Thursday, May 27, 2004 2:30 PM To: Krishna Murthy Cc: wine-devel(a)winehq.org Subject: Re: FW: Edit Paste operation does not behave same as MS Windows Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > - Change log Entry: > EDIT_MakeFit should return TRUE when the honor_limit is set and paste > buffer exceeds the limit. Also EDIT_EM_ReplaceSel should compute size > which could fit in the edit control by truncating the extra characters > to behave similar to MS Windows paste operation. You are bypassing the reallocation of the buffer when the limit is exceeded, but still adding the data to the buffer. I don't think this will work right. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Crash and corrupted registry
by Alexandre Julliard 27 May '04

27 May '04

Christian Costa <titan.costa(a)wanadoo.fr> writes: > This seems to be more a filesytem issue then because the file is in a > really bad shape. > I use reiserfs on a Mandrake 2.4.21-0.13mdk kernel. > It seems to happend on files that are open when the crash (freeze + > reboot) occurs. Yes, it very much looks like a filesystem issue, I prefer that <g> If you feel like trying to reproduce it, maybe you could try to add an fsync() in the saving code and see if this makes a difference. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: FW: Edit Paste operation does not behave same as MS Windows
by Alexandre Julliard 27 May '04

27 May '04

Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > - Change log Entry: > EDIT_MakeFit should return TRUE when the honor_limit is set and paste buffer > exceeds the limit. Also EDIT_EM_ReplaceSel should compute size which could > fit in the edit control by truncating the extra characters to behave similar > to MS Windows paste operation. You are bypassing the reallocation of the buffer when the limit is exceeded, but still adding the data to the buffer. I don't think this will work right. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Repaint the whole nonclient window area on SetWindowPos(SWP_FRAMECHANGED)
by Alexandre Julliard 27 May '04

27 May '04

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > SetWindowPos(SWP_FRAMECHANGED) causes the whole nonclient window area > to be repainted. > > Also, according to the tests Windows always repaints windows before > SetWindowPos has finished. > > This patch reduces number of message test failures from 56 to 47. The message order is wrong because we rely on X expose events to repaint the window. This is one of the reasons we need to go back to not using X windows for every window; but until that is done, your fix is going to cause every window to be repainted twice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Add a test for accessing classes from another thread
by Alexandre Julliard 27 May '04

27 May '04

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > somebody on the ReactOS mailing list mentioned that Windows stores class > information in the per thread list, not a per process or per module list. > That would effecively meant that accessing classes or creating windows > from other threads would fail. > > So, I decided to write a test for that. The test passes under Wine. Not for me: class.c:258: Test failed: GetLastError() should be set to ERROR_CLASS_HAS_WINDOWS class.c:258: Test failed: GetLastError() should be set to ERROR_CLASS_HAS_WINDOWS -- Alexandre Julliard julliard(a)winehq.org

1 0

atoi and undefined usage
by andrejoh＠c2i.net 27 May '04

27 May '04

The atoi() function has undefined usage when trying to convert numbers outside the range of int. When parsing numbers >= 2^31, GNU libc seems to truncate the number to 2^31-1; however, with MSVC, such a number would wrap, and when cast to an unsigned integer, numbers within an unsigned int are preserved. Should Wine care about such undefined behaviour? Currently, it seems Wine uses the GNU libc implementation, giving a different result than when running in Windows. (In my case, an IP address was given as a string, and ended up as "127.255.255.255" when running in Wine. I've now fixed that specific bug in the source code, but with other programs, that might not be an option...) -- Try Anarchy Online http://www.anarchy-online.com/content/downloads/tryout/ Netiquette guidelines ftp://ftp.rfc-editor.org/in-notes/rfc1855.txt How to quote properly http://www.i-hate-computers.demon.co.uk/ Hvordan sitere riktig http://home.online.no/~vidaandr/news/OBSquoting.html

2 1

Re: test for GetAcceptLanguagesA
by Martin Fuchs 27 May '04

27 May '04

On 27.05.2004 04:09:34 Alexandre Julliard wrote: > Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > > before removing the acsii calls from GetAcceptLanguagesW, i like to see > the > > results of the attached tests. This will hopefuly save me some work when > > rewriting the function. The tests passes on my Win2k system. > But they fail on Wine, so I can't apply the patch. I've seen some test cases wrapped in TODO sections, for example: todo_wine { SetWindowLong(hwnd1, GWL_EXSTYLE, GetWindowLong(hwnd1,GWL_EXSTYLE)|WS_EX_TOPMOST); ret = GetWindowLong(hwnd1,GWL_EXSTYLE)&WS_EX_TOPMOST? TRUE: FALSE; ok(!ret, "SetWindowExStyle(hwnd1, WS_EX_TOPMOST)\n"); } This prints a warning message about something yet to to in Wine, but the test doesn't fail. Can't you use this also for the patch in question? Regards, Martin

1 0

having problem in understanding debug channels
by zeeshaan umer 27 May '04

27 May '04

hi, its zee here, i am a student and i have just came to know about wine 2-3 weeks ago. i have started studying it for exploration purpose. its quite a great effort of u people. really it is........ nways the problem i m having is that i m not clearly understanding debug channels. i actually was trying to be a part of developers of wine and i tried to implement an API but when i wrote and included it in the source it could not be compiled i got an error " invalid debug channel specification ' ZEE_DEFAULT_DEBUG_CHANNEL( );' " i de have define ZEE_DEFAULT_DEBUG_CHANNEL in debug.h but frankly i have not actually understood the complete philosphy of these debug channels that how they work and how are they defined properly. plz,.......anybody help me. i m a student so dont mind if it is really rediculous type of problem......:-) zeeshan xeshaan(a)yahoo.co.in Yahoo! India Matrimony: Find your partner online.

2 1

Re: Additional downloads for winehq
by Ivan 27 May '04

27 May '04

OK, I don't see the utility of having a 3rd party download section just to list one download. But what about dcom95? We have a message in oleaut that tells the user to download dcom95, and it provides a link to sf, but we can't host dom on sf because it isn't open source, and people can download it free from m$ anyway. But Alexandre doesn't like long links, and the link to the dcom95 download page is just too long. It's http://www.microsoft.com/downloads/details.aspx?familyid=d7a4de78-81a9-4db7… and we want to keep the error log short. Ivan.

2 1

Re: Re: test for GetAcceptLanguagesA
by Pouech Eric DMI AEI CAEN 27 May '04

27 May '04

> Its not a fault of the tests that they fail on wine, its a fault of > wine. For my understanding the test are created to show that either the > behaviour of wine is correct (when the test succeeds) or that something > left to do one wine (when a test fails)!? check out the todo_wine construct in winetest Alexandre point is not that you cannot add a test that currently fails in Wine. His point is that you cannot add a test that will make the test process fail. The todo_wine is done for that: 1/ it marks a test as failing on wine 2/ it will report it (but not make the test fail) 3/ it will also make the test process fail if the test succeeds (so that we can remove the todo_wine mark) A+

1 0

Re: test for GetAcceptLanguagesA
by Alexandre Julliard 27 May '04

27 May '04

Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > before removing the acsii calls from GetAcceptLanguagesW, i like to see the > results of the attached tests. This will hopefuly save me some work when > rewriting the function. The tests passes on my Win2k system. But they fail on Wine, so I can't apply the patch. -- Alexandre Julliard julliard(a)winehq.org

4 3

[Janitorial]: Missing inversion im Bit manipulation
by Uwe Bonnes 27 May '04

27 May '04

Changelog: wine/dlls/winmm/winmm.c: Add obvious missing inversion -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/winmm/winmm.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/winmm.c,v retrieving revision 1.33 diff -u -w -r1.33 winmm.c --- wine/dlls/winmm/winmm.c 27 Feb 2004 21:29:32 -0000 1.33 +++ wine/dlls/winmm/winmm.c 27 May 2004 07:56:13 -0000 @@ -1983,7 +1983,7 @@ lpMidiHdr = (LPMIDIHDR)msg->lParam; lpMidiHdr->lpNext = 0; lpMidiHdr->dwFlags |= MHDR_INQUEUE; - lpMidiHdr->dwFlags &= MHDR_DONE; + lpMidiHdr->dwFlags &= ~MHDR_DONE; lpMidiHdr->dwOffset = 0; break;

1 0

Re: Additional downloads for winehq
by Jeremy Newman 27 May '04

27 May '04

I don't think these belong on the download page. That would confuse the users. IMO the download page should only contain links to download Wine. All this should go in a HowTo or in the docs. I know we have the 3rd party tools section there. I was opposed to that as well. We just cleaned up the download page, and you people want to clutter it up again! <g> Btw, your link to the download page in the second patch in wrong. it should be: http://www.winehq.org/download (we need to keep consistent on the .org thing) On Wed, 2004-05-26 at 18:09, Ivan wrote: > These downloads can be useful for lots of wine users. > > Ivan.

1 0

Re: [DMUSIC] IDirectMusicSegment8 loading of Wave Segments
by Rok Mandeljc 26 May '04

26 May '04

> PS: > Rok, i have you have implemented IDirectMusicSegment8 interface on > IDirectMusicWaveImpl. > Why ? > What it your "sample" who permit to check this behavior ? > For testing my patch you only have, for example, to open a .wav file using > 3DAudio.exe sdk sample Hey, I'm sorry but I cannot really remember (have experienced computer crash and it will take some time for me to organise everything again). I'm not even sure if IDirectMusicSegment should be implemented for it, but i think my test was to create native IDirectMusicWave via CoCreateInstance and then try to QueryInterface it with all possible IIDs; I can't remember result, but I think it was supported (unless I made a mistake ;=) - Rok

2 1

Assume MAX_PATH length for pszDisplayName
by Uwe Bonnes 26 May '04

26 May '04

Changelog: dlls/shell32/brsfolders.c: SHBrowseForFolderA LPBROWSEINFOA->pszDisplayName is assumed to have MAX_PATH legth Fixes a crash in Xilinx ISE when vreating a new project with a long path -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/shell32/brsfolder.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/brsfolder.c,v retrieving revision 1.51 diff -u -w -5 -r1.51 brsfolder.c --- wine/dlls/shell32/brsfolder.c 19 Apr 2004 20:12:14 -0000 1.51 +++ wine/dlls/shell32/brsfolder.c 26 May 2004 13:56:29 -0000 @@ -460,11 +460,12 @@ bi.hwndOwner = lpbi->hwndOwner; bi.pidlRoot = lpbi->pidlRoot; if (lpbi->pszDisplayName) { len = MultiByteToWideChar(CP_ACP, 0, lpbi->pszDisplayName, -1, NULL, 0); - bi.pszDisplayName = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); + /*lpbi->pszDisplayName is assumed to be MAX_PATH (MSDN) */ + bi.pszDisplayName = HeapAlloc(GetProcessHeap(), 0, MAX_PATH * sizeof(WCHAR)); MultiByteToWideChar(CP_ACP, 0, lpbi->pszDisplayName, -1, bi.pszDisplayName, len); } else bi.pszDisplayName = NULL;

1 0

Type in msvcrt
by Uwe Bonnes 26 May '04

26 May '04

Changelog: dlls/msvcrt/file.c: _setmode() Reset only the affected flag Make Xilinx ise not hang at startup Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/msvcrt/file.c =================================================================== RCS file: /home/wine/wine/dlls/msvcrt/file.c,v retrieving revision 1.67 diff -u -w -5 -r1.67 file.c --- wine/dlls/msvcrt/file.c 13 May 2004 00:23:25 -0000 1.67 +++ wine/dlls/msvcrt/file.c 26 May 2004 12:17:06 -0000 @@ -1437,11 +1448,11 @@ if (mode & (~(_O_TEXT|_O_BINARY))) FIXME("fd (%d) mode (0x%08x) unknown\n",fd,mode); if ((mode & _O_TEXT) == _O_TEXT) MSVCRT_fdesc[fd].xflag |= WX_TEXT; else - MSVCRT_fdesc[fd].xflag &= WX_TEXT; + MSVCRT_fdesc[fd].xflag &= ~WX_TEXT; return ret; } /********************************************************************* * _stati64 (MSVCRT.@)

1 0

Re: Re: [OLE] Better handling of References
by fenix＠club-internet.fr 26 May '04

26 May '04

>On Wed, 26 May 2004 03:55:25 +0200, Raphael wrote: >> I'm trying to install Splinter Cell Demo (installshield). >> And i have seen: >> - one typelib was released while typeinfos (childs of typelib) are in use >> - the install "crash" (catched and returns an E_UNEXPECTED error) when it >> wants to call ITypeInfo_fnGetContainingTypeLib (who want to AddRef the >> freshly released TypeLib) > >Hi Raphael, Hi Mike >This has been a known problem for a long time now, with several attempts >to fix it, all of them have been incorrect. It seems your approach is a >new one and interesting, but I'm not sure this is how Windows does it. Well Soft References are used in many places in COM (for example D3D textures/surfaces use it on windows) >Does anybody know exactly what Windows does in this situation? It might be >worth writing a test case to find out. > >Objects in a semi-freed state seem like a slightly odd way to do things. > >> Now i have another crash later, but it seems a problem with an invoke method >> who failed :( >> If any ole/rpc expert can look at this problem i'll be very happy :) > >Well, if you could provide more detail (backtrace etc) on the crash it >would be good. I can't have a backtrace as i can't get winedbg working correctly on installshield programs :( But i'll send you the traces later (when i'll be back home). For what i have see it's a problem of ITypeInfo::Invoke when it should returns a Pointer to an IUnknown Variant. InstallShield complains about Objects References not set !! >A few comments on the patch: > >- --(This->ref); >+ /** escape decrement for soft_references */ >+ if (This->ref > 0) { >+ --(This->ref); >+ } else { >+ ERR("trying to Release again an ITypeLib2 in freing state waiting for ITypeInfo (%p) childs Releases\n", This); >+ } > >I don't remember whether this object is supposed to be thread safe or not, >but should this not be an InterlockedDecrement? Yes, but as the code of ITypeLib2/ITypeInfo don't seems thread safe at all ... (anyway i'll fix it) :) >I think the error could be better phrased as: > >ERR("Reference count on an ITypeLib2 object (%p) already zero: waiting for >ITypeInfo children to be released as well"); :) >or words to that effect. > >+ if (This->soft_ref > 0) { >+ ERR("trying to Release an ITypeLib2 while some ITypeInfo (%p) childs are actually with Refs > 1. So Dont free it now \n", This); >+ /** maybe scaning ITypeInfo list to dump ITypeInfos with Refs > 1 */ >+ return 1; >+ } > >Is it actually an error to do that? If you free a typelib while refs are >held on child typeinfos, is this a bug in the app or a legitimate thing to >do? If it's not a bug in the app we probably shouldn't use ERR here. Weel, we had problems like that on d3d8 (a long time ago) about ref counting. For me, seems more a wine bug (we have to found where missing AddRefs as to be done) than an app bug (new traces can help us to find what happened) >--- variant.c 30 Apr 2004 18:32:58 -0000 1.97 >+++ variant.c 26 May 2004 01:46:44 -0000 >@@ -605,6 +605,8 @@ > > hres = VARIANT_ValidateType(V_VT(pVarg)); > >+ if (V_VT(pVarg) == VT_EMPTY) return hres; >+ > if (SUCCEEDED(hres)) > { > if (!V_ISBYREF(pVarg)) > >This change looks OK though I'm not sure why it's necessary. Does the >Splinter Cell installer actually need this? No, i have only to no have a lot of debug traces (i have added on my tree) on Variant* Operations when clearing already empty Variants >thanks -mike > Regards, Raphael

2 1

Re: [OLE] Better handling of References
by Mike Hearn 26 May '04

26 May '04

Oops, sending to wine-devel too (this is what I get for using a newsreader...) On Wed, 26 May 2004 03:55:25 +0200, Raphael wrote: > I'm trying to install Splinter Cell Demo (installshield). > And i have seen: > - one typelib was released while typeinfos (childs of typelib) are in use > - the install "crash" (catched and returns an E_UNEXPECTED error) when it > wants to call ITypeInfo_fnGetContainingTypeLib (who want to AddRef the > freshly released TypeLib) Hi Raphael, This has been a known problem for a long time now, with several attempts to fix it, all of them have been incorrect. It seems your approach is a new one and interesting, but I'm not sure this is how Windows does it. Does anybody know exactly what Windows does in this situation? It might be worth writing a test case to find out. Objects in a semi-freed state seem like a slightly odd way to do things. > Now i have another crash later, but it seems a problem with an invoke method > who failed :( > If any ole/rpc expert can look at this problem i'll be very happy :) Well, if you could provide more detail (backtrace etc) on the crash it would be good. A few comments on the patch: - --(This->ref); + /** escape decrement for soft_references */ + if (This->ref > 0) { + --(This->ref); + } else { + ERR("trying to Release again an ITypeLib2 in freing state waiting for ITypeInfo (%p) childs Releases\n", This); + } I don't remember whether this object is supposed to be thread safe or not, but should this not be an InterlockedDecrement? I think the error could be better phrased as: ERR("Reference count on an ITypeLib2 object (%p) already zero: waiting for ITypeInfo children to be released as well"); or words to that effect. + if (This->soft_ref > 0) { + ERR("trying to Release an ITypeLib2 while some ITypeInfo (%p) childs are actually with Refs > 1. So Dont free it now \n", This); + /** maybe scaning ITypeInfo list to dump ITypeInfos with Refs > 1 */ + return 1; + } Is it actually an error to do that? If you free a typelib while refs are held on child typeinfos, is this a bug in the app or a legitimate thing to do? If it's not a bug in the app we probably shouldn't use ERR here. ++(This->ref); + if (This->ref > 1) { + if (NULL != This->pTypeLib) ++(This->pTypeLib->soft_ref); + } + Ditto on thread safety. Please forgive me if this object is not free threaded. --- variant.c 30 Apr 2004 18:32:58 -0000 1.97 +++ variant.c 26 May 2004 01:46:44 -0000 @@ -605,6 +605,8 @@ hres = VARIANT_ValidateType(V_VT(pVarg)); + if (V_VT(pVarg) == VT_EMPTY) return hres; + if (SUCCEEDED(hres)) { if (!V_ISBYREF(pVarg)) This change looks OK though I'm not sure why it's necessary. Does the Splinter Cell installer actually need this? thanks -mike

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel