wine-devel

wine-devel@winehq.org

10 participants
84459 discussions

Re: [RESENT] TIME_GetBias
by Alexandre Julliard 18 Mar '04

18 Mar '04

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > Changelog: > wine/dlls/ntdll/time.c: TIME_GetBias > Calculate the Bias before calling gmtime This cannot be right, the bias is supposed to be the difference between local time and GMT, so you have to use gmtime() not localtime(). -- Alexandre Julliard julliard(a)winehq.org

5 15

Re: Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec)
by Christian Costa 18 Mar '04

18 Mar '04

> Message du 18/03/04 00:51 > De : Marcus Meissner > A : Christian Costa > Copie à : wined > Objet : Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec) > On Wed, Mar 17, 2004 at 10:37:01PM +0000, Christian Costa wrote: > > Hi, > > > > When executing the DllMain of the native IR32_32.DLL (VFW), Wine crashes. > > After some investigations, I found that a part of the code uses the EBX > > register at one point without saving > > and restore it afterwards. Since this register contains the PLT pointer > > for standard unix functions like libc ones, this > > does not take a long time for Wine to crashing. > > I tested with the ugly hack attached that saves and restores the EBX > > register between the call to DllMain and that fixed the problem and > > the DLL works fine then. > > This might happen. That ebx can be scrapped? > > Your fix is not really ok, you must not modify the stackpointer in asm statements. > > Try using: > __asm__ __volatile__ ("":::"ebx"); > > after entry(), which tells the compiler that ebx has been scrapped. Thanks for this! :-) Christian

2 1

Re: Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec)
by Christian Costa 18 Mar '04

18 Mar '04

> Message du 18/03/04 00:50 > De : Mike Hearn > A : wine-devel(a)winehq.com > Copie à : > Objet : Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec) > On Wed, 17 Mar 2004 22:37:01 +0000, Christian Costa wrote: > > When executing the DllMain of the native IR32_32.DLL (VFW), Wine crashes. > > After some investigations, I found that a part of the code uses the EBX > > register at one point without saving and restore it afterwards. > > What calling convention is the entrypoint declared with? How can I retreive this info from the dll? I guess it is stdcall like it should be. > I thought EBX was > a register that had to be saved/restored according to the ABI and the > windows compilers would always do that? > I don't know but that would explain what is happening altough if it was the case I wonder why noone has encountered this problem yet. Bye, Christian

2 1

Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec)
by Christian Costa 18 Mar '04

18 Mar '04

> Message du 18/03/04 01:02 > De : Alexandre Julliard > A : Christian Costa > Copie à : wined > Objet : Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec) > Christian Costa writes: > > > When executing the DllMain of the native IR32_32.DLL (VFW), Wine crashes. > > After some investigations, I found that a part of the code uses the > > EBX register at one point without saving > > and restore it afterwards. Since this register contains the PLT > > pointer for standard unix functions like libc ones, this > > does not take a long time for Wine to crashing. > > Is the dll really modifying ebx explicitly? Isn't it rather a > consequence of a stack overflow or some similar bug? Yes, ebx is modified explicity and not poped from the stack. There is no save/restore statements. Bye, Christian

1 0

wineinstall hangs
by Fabian Cenedese 18 Mar '04

18 Mar '04

Hi I just tried on a new computer to checkout wine from cvs and do a install. Compilation worked fine, but there was again a problem with the regedit: --- snip --- Preparing to install default Wine registry entries... Installing default Wine registry entries... Warning: Language 'us' was not recognized, defaulting to English. Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: Xlib: extension "GLX" missing on display ":1.0". fixme:urlmon:URLMON_DllRegisterServer (void): stub wine: Unhandled exception (thread 0009), starting debugger... Warning: Language 'us' was not recognized, defaulting to English. Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: (hang, CTRL-C) Registry entries successfully installed. err:seh:setup_exception nested exception on signal stack in thread 0009 eip 40108aa6 esp 40031c28 stack 0x405a0000-0x406a0000 Installation complete for now. Good luck (this is still alpha software). If you have problems with WINE, please read the documentation first, as many kinds of potential problems are explained there. --- snip --- But after that I could start wine regedit and the keys seem to have been generated. So I don't know what really failed. bye Fabi

3 4

Re: Avoid a possible deadlock when stopping playback
by Christian Costa 18 Mar '04

18 Mar '04

Hi Dmitry, Are you sure this is usefull. How can SetEvent cause a deadlock? Bye, Christian > Message du 16/03/04 14:54 > De : Dmitry Timoshkov > A : wine-patches(a)winehq.com > Copie à : > Objet : Avoid a possible deadlock when stopping playback > Hello, > > looks like it's a good idea to do the same when signalling hStopEvent. > > Changelog: > Dmitry Timoshkov > Avoid a possible deadlock when stopping playback. > > --- cvs/hq/wine/dlls/winmm/mciavi/mciavi.c 2004-03-16 18:37:03.000000000 +0800 > +++ wine/dlls/winmm/mciavi/mciavi.c 2004-03-16 19:38:42.000000000 +0800 > @@ -606,7 +606,9 @@ static DWORD MCIAVI_mciStop(UINT wDevID, > switch (wma->dwStatus) { > case MCI_MODE_PLAY: > case MCI_MODE_RECORD: > + LeaveCriticalSection(&wma->cs); > SetEvent(wma->hStopEvent); > + EnterCriticalSection(&wma->cs); > /* fall through */ > case MCI_MODE_PAUSE: > /* Since our wave notification callback takes the lock, > > > > >

2 3

Rundll32 needs X
by Vincent Béron 18 Mar '04

18 Mar '04

Hi folks, Since wine.inf is now used as the source for the default values for the registry (via rundll32), importing it absolutely needs X (whereas the older regedit method didn't when importing a .reg file). This can be a problem for people running wineinstall via ssh from a Windows box. Is there a reason rundll32 needs user32 and cannot delayimport it? Vincent

3 3

PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec)
by Christian Costa 17 Mar '04

17 Mar '04

Hi, When executing the DllMain of the native IR32_32.DLL (VFW), Wine crashes. After some investigations, I found that a part of the code uses the EBX register at one point without saving and restore it afterwards. Since this register contains the PLT pointer for standard unix functions like libc ones, this does not take a long time for Wine to crashing. I tested with the ugly hack attached that saves and restores the EBX register between the call to DllMain and that fixed the problem and the DLL works fine then. Can someone tell me what happens? Thanks in advance, Christian Index: loader.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/loader.c,v retrieving revision 1.66 diff -u -r1.66 loader.c --- loader.c 16 Mar 2004 03:10:07 -0000 1.66 +++ loader.c 17 Mar 2004 21:19:39 -0000 @@ -690,7 +690,9 @@ else TRACE("(%p %s,%s,%p) - CALL\n", module, debugstr_w(wm->ldr.BaseDllName.Buffer), reason_names[reason], lpReserved ); + __asm("push %ebx"); retv = entry( module, reason, lpReserved ); + __asm("pop %ebx"); /* The state of the module list may have changed due to the call to the dll. We cannot assume that this module has not been

4 3

Re: [AppDB] - Script the table creation, help users to setup local appdb
by Paul van Schayck 17 Mar '04

17 Mar '04

Chris, On Wednesday 17 March 2004 19:16, Chris Morgan wrote: > README now has some instructions on how to setup a local > appdb. You should also note that magic_quotes_gpc should be off. Otherwise you would end up inside your database with \ everywhere. And for development display_errors is very handy. And great work on those tables. I was already wondered wy I couldn't login. Regards, Paul

1 0

Win32 packages released on sourceforge
by Ivan Leo Murray-Smith 17 Mar '04

17 Mar '04

The win32 packages of wine are on sourceforge, you can get them from http://sourceforge.net/project/showfiles.php?group_id=6241 or to view the win32 packages only http://sourceforge.net/project/showfiles.php?group_id=6241&package_id=112520 Ivan.

2 1

Re: Stubs needed by some Windows Update Installs
by Dmitry Timoshkov 17 Mar '04

17 Mar '04

"Aric Stewart" <aric(a)codeweavers.com> wrote: > @@ -297,7 +297,7 @@ > @ stub SetupSetSourceListA > @ stub SetupSetSourceListW > @ stdcall SetupTermDefaultQueueCallback(ptr) > -@ stub SetupTerminateFileLog > +@ stdcall SetupTerminateFileLog(ptr) The argument here should be 'long'. -- Dmitry.

2 3

Current CVS msi build failure
by Ferenc Wagner 17 Mar '04

17 Mar '04

Hi, with current CVS I get: [...] bison -p SQL_ -d ../../../src/dlls/msi/sql.y -o sql.tab.c ../../../src/dlls/msi/sql.y contains 4 shift/reduce conflicts and 10 reduce/reduce conflicts. bison -p SQL_ -d ../../../src/dlls/msi/sql.y -o sql.tab.c ../../../src/dlls/msi/sql.y contains 4 shift/reduce conflicts and 10 reduce/reduce conflicts. gcc -c -I../../../src/dlls/msi -I. -I../../../src/include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o tokenize.o ../../../src/dlls/msi/tokenize.c ../../../src/dlls/msi/tokenize.c:58: `TK_CHAR' undeclared here (not in a function) ../../../src/dlls/msi/tokenize.c:58: initializer element is not constant ../../../src/dlls/msi/tokenize.c:58: (near initialization for `aKeywordTable[12].tokenType') ../../../src/dlls/msi/tokenize.c:59: `TK_CHAR' undeclared here (not in a function) ../../../src/dlls/msi/tokenize.c:59: initializer element is not constant ../../../src/dlls/msi/tokenize.c:59: (near initialization for `aKeywordTable[13].tokenType') ../../../src/dlls/msi/tokenize.c:90: `TK_HOLD' undeclared here (not in a function) ../../../src/dlls/msi/tokenize.c:90: initializer element is not constant [etc., similar ones for TK_INT, TK_LONG, TK_LONGCHAR, TK_OBJECT and TK_SHORT] These IDs are really missing from my sql.tab.h. Any clues? -- Feri.

2 2

Re: Stub for SignalObjectAndWait
by Mike Hearn 17 Mar '04

17 Mar '04

On Wed, 17 Mar 2004 01:50:40 +0100, Raphael wrote: > PS: i'm trying to get MSN Messenger working, how we can register some com dlls > into registry ? The app installer should do that for you (last time I tried MSN Messenger I didn't have any problems with missing registrations) but you can run regsvr32 on a DLL to reregister it if you want to. thanks -mike

1 0

Re: REBAR: prevent recursions with WM_SIZE reason
by Mike McCormack 17 Mar '04

17 Mar '04

Alexandre, please don't apply this patch... it doesn't work the right way. Juan Lang pointed out that I have a = instead of a |= ... and after fixing it, it doesn't do what it mean to do. thanks, Mike Mike McCormack wrote: > > ChangeLog: > * prevent recursions with WM_SIZE reason

1 0

Re: tools/winetest winetest.cron
by Ferenc Wagner 16 Mar '04

16 Mar '04

Jeremy Newman <jnewman(a)winehq.org> writes: > ChangeSet ID: 11483 > > Log message: > set the lang Did you check if it was needed? I thought my patch took care of this in a language/locale neutral way by opening the report file in :raw mode. I'd like to not if it's not the case. -- Feri.

2 1

Browsing the wine source
by Blake Leverett 16 Mar '04

16 Mar '04

Hello, I have been getting wine from CVS for a while now, and have been looking through the source. How do people who work with the wine code browse around in the source tree? I found that 'ctags -e -R' can be used with emacs, which works OK, but I was wondering if there is a better method. Thanks, Blake Leverett

2 1

Re: cards.dll improvements
by Tom 16 Mar '04

16 Mar '04

Sam wrote: > Improvements to cards.dll based on documentation at > http://www.microsoft.com/mind/0396/games.asp. > I'm not sure if you have read this post or not but here it is. http://www.winehq.com/hypermail/wine-devel/2003/07/0691.html Tom

1 0

how to call setupapi / wine.inf
by Marcus Meissner 16 Mar '04

16 Mar '04

Hi, I am trying to setup wine with wine.inf, with the following call: /usr/bin/rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 /usr/share/wine/wine.inf However, the /usr/share/wine/wine.inf path does not seem to be translated correctly. 0009:Call kernel32.GetFullPathNameW(406efb6e L"/usr/share/wine/wine.inf",00000000,00000000,00 000000) ret=40c8333c 0009:Ret kernel32.GetFullPathNameW() retval=0000001b ret=40c8333c 0009:Call ntdll.RtlAllocateHeap(40360000,00000000,00000036) ret=40c83542 0009:Ret ntdll.RtlAllocateHeap() retval=4039a0e0 ret=40c83542 0009:Call kernel32.GetFullPathNameW(406efb6e L"/usr/share/wine/wine.inf",0000001b,4039a0e0,00 000000) ret=40c83571 0009:Ret kernel32.GetFullPathNameW() retval=0000001a ret=40c83571 0009:Call kernel32.CreateFileW(4039a0e0 L"Y:\\usr\\share\\wine\\wine.inf",80000000,00000001,0 0000000,00000003,00000000,00000000) ret=40c835af 0009:Ret kernel32.CreateFileW() retval=ffffffff ret=40c835af The config script has: [Drive Y] "Type" = "network" "Path" = "%HOME%" [Drive Z] "Type" = "network" "Path" = "/" So it should have been using Z:\\ Is this a problem in GetFullPathName or should I better use: /usr/bin/rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 z:\\usr\\share\\wine\\wine.inf ? Ciao, Marcus

4 4

dlls/ntdll/directory.c portability breakage
by Gerald Pfeifer 16 Mar '04

16 Mar '04

The new file dlls/ntdll/directory.c added by date: 2004/03/16 01:32:02; author: julliard; state: Exp; Implemented NtQueryDirectoryFile (partly based on a patch by Eric Pouech). broke non-Linux platforms (like FreeBSD): /usr/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o directory.o directory.c directory.c: In function `NtQueryDirectoryFile': directory.c:446: error: `O_DIRECTORY' undeclared (first use in this function) directory.c:446: error: (Each undeclared identifier is reported only once directory.c:446: error: for each function it appears in.) There *is* code to #define O_DIRECTORY /* To avoid blocking on non-directories in DOSFS_OpenDir_VFAT*/ #ifndef O_DIRECTORY # define O_DIRECTORY 0200000 /* must be directory */ #endif but it's in #ifdef linux only! Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

1 0

Re: cards.dll
by Joerg Mayer 16 Mar '04

16 Mar '04

On Tue, Mar 16, 2004 at 12:09:24AM +0200, Shachar Shemesh wrote: > Can someone remind me again why we can't have GPL DLLs in the tree? > Doesn't the "call through documented interface blah blah blah not > derived work" argument cause the license for each two DLLs in Wine to be > independant? Basically it goes like this: LGPLed code can be run as a library, i.e. a function of an LGPLed dll can be called as a function call. GPLed code must be run as a (Unix) process if you want to use it from non-GPL-compatible code. See the GPL and especially the GPL FAQ for details. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.

2 1

Re: shell32 patch 23 d [correction]
by Alexandre Julliard 15 Mar '04

15 Mar '04

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > Alexandre - is there any thing wrong with this patch? Yes there has to be something wrong, you create a sei_tmp structure but you never actually use it. I'm not sure what your intent was. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [resend] rebar.c: RBBS_HIDETITLE support
by Alexandre Julliard 15 Mar '04

15 Mar '04

Filip Navara <xnavara(a)volny.cz> writes: > I'm sending this patch second time. Is there any reason why it wasn't > commited previously or it just got lost? It will get in faster if you send a non wrapped version ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

dlls/glu32 compile error
by Peter Hyman 15 Mar '04

15 Mar '04

Kernel 2.6.4 gcc = 3.2.3 The following compile time error occurs: make[2]: Entering directory `/mnt/src/src/wine/dlls/glu32' gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o glu32.spec.o glu32.spec.c {standard input}: Assembler messages: {standard input}:274: Error: no such instruction: `yes "glu32.dll"' {standard input}:275: Error: no such instruction: `yes "gluBeginCurve"' {standard input}:276: Error: no such instruction: `yes "gluBeginPolygon"' {standard input}:277: Error: no such instruction: `yes "gluBeginSurface"' {standard input}:278: Error: no such instruction: `yes "gluBeginTrim"' {standard input}:279: Error: no such instruction: `yes "gluBuild1DMipmaps"' {standard input}:280: Error: no such instruction: `yes "gluBuild2DMipmaps"' {standard input}:281: Error: no such instruction: `yes "gluCheckExtension"' etc... The source file at this location is: "__wine_spec_exp_names:\n" "\tyes \"glu32.dll\"\n" "\tyes \"gluBeginCurve\"\n" "\tyes \"gluBeginPolygon\"\n" "\tyes \"gluBeginSurface\"\n" "\tyes \"gluBeginTrim\"\n" Seems like the \" is being taken as a literal ". Did you mean for a \ to occur? or a \glu... to occur? Regards -- Peter Hyman

2 1

Re: shell32 [was cards.dll]
by Martin Fuchs 15 Mar '04

15 Mar '04

On 15.03.2004 23:01:56 Martin Fuchs wrote: > Well to take up for the ReactOS folks.... Martin and Ge have done one hell > of a fine job on shell32 !! > And they have given every thing back.. Not once but twice! > As AJ was on vacation at the time and Martin & Ge spent alot of time > i'm sure spliting the patch up into smaller chunks so it would be > excepted here. .. and the merge is not yet finished. I hope it will ever be finished. But it takes a very long time by sending out those small patch pieces, waiting for the commit, and then go on... Currently I'm splitting the ShellExecute patch (aka "shell32 patch 23") into small pieces, and sending them separately since most of them depends on some another piece. On my list there are also patch nr. 1 and 22 without any answer from Alexandre or some one else. Is there really no possibility to speed this up a bit? If it's going on at the current speed it may be finished at next christmas day. ;-) Martin

1 0

static.c patch
by Filip Navara 15 Mar '04

15 Mar '04

Hi, I want to synchronize my change from ReactOS with the Wine tree. Unfortunetly I can't test it and I don't even know if it compiles under Wine. So if anyone want to take care of it, here it is. Regards, Filip --- static.c Tue Feb 10 20:09:04 2004 +++ static.c Mon Mar 15 21:34:06 2004 @@ -122,6 +122,7 @@ static HBITMAP STATIC_SetBitmap( HWND hwnd, HBITMAP hBitmap, DWORD style ) { HBITMAP hOldBitmap; + LONG full_style = GetWindowLongA( hwnd, GWL_STYLE ); if ((style & SS_TYPEMASK) != SS_BITMAP) return 0; if (hBitmap && GetObjectType(hBitmap) != OBJ_BITMAP) { @@ -129,7 +130,7 @@ return 0; } hOldBitmap = (HBITMAP)SetWindowLongA( hwnd, HICON_GWL_OFFSET, (LONG)hBitmap ); - if (hBitmap) + if (hBitmap && !(full_style & SS_REALSIZEIMAGE)) { BITMAP bm; GetObjectW(hBitmap, sizeof(bm), &bm); @@ -559,6 +560,7 @@ HBRUSH hbrush; HDC hMemDC; HBITMAP hBitmap, oldbitmap; + LONG full_style = GetWindowLongA( hwnd, GWL_STYLE ); GetClientRect( hwnd, &rc ); hbrush = (HBRUSH)SendMessageW( GetParent(hwnd), WM_CTLCOLORSTATIC, @@ -573,8 +575,17 @@ if (!(hMemDC = CreateCompatibleDC( hdc ))) return; GetObjectW(hBitmap, sizeof(bm), &bm); oldbitmap = SelectObject(hMemDC, hBitmap); - BitBlt(hdc, 0, 0, bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, - SRCCOPY); + if (full_style & SS_CENTERIMAGE) + { + BitBlt(hdc, (rc.right - bm.bmWidth) >> 1, + (rc.bottom - bm.bmHeight) >> 1, + bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, SRCCOPY); + } + else + { + BitBlt(hdc, 0, 0, bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, + SRCCOPY); + } SelectObject(hMemDC, oldbitmap); DeleteDC(hMemDC); }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel