wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Browsing the wine source
by Blake Leverett 16 Mar '04

16 Mar '04

Hello, I have been getting wine from CVS for a while now, and have been looking through the source. How do people who work with the wine code browse around in the source tree? I found that 'ctags -e -R' can be used with emacs, which works OK, but I was wondering if there is a better method. Thanks, Blake Leverett

2 1

Re: cards.dll improvements
by Tom 16 Mar '04

16 Mar '04

Sam wrote: > Improvements to cards.dll based on documentation at > http://www.microsoft.com/mind/0396/games.asp. > I'm not sure if you have read this post or not but here it is. http://www.winehq.com/hypermail/wine-devel/2003/07/0691.html Tom

1 0

how to call setupapi / wine.inf
by Marcus Meissner 16 Mar '04

16 Mar '04

Hi, I am trying to setup wine with wine.inf, with the following call: /usr/bin/rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 /usr/share/wine/wine.inf However, the /usr/share/wine/wine.inf path does not seem to be translated correctly. 0009:Call kernel32.GetFullPathNameW(406efb6e L"/usr/share/wine/wine.inf",00000000,00000000,00 000000) ret=40c8333c 0009:Ret kernel32.GetFullPathNameW() retval=0000001b ret=40c8333c 0009:Call ntdll.RtlAllocateHeap(40360000,00000000,00000036) ret=40c83542 0009:Ret ntdll.RtlAllocateHeap() retval=4039a0e0 ret=40c83542 0009:Call kernel32.GetFullPathNameW(406efb6e L"/usr/share/wine/wine.inf",0000001b,4039a0e0,00 000000) ret=40c83571 0009:Ret kernel32.GetFullPathNameW() retval=0000001a ret=40c83571 0009:Call kernel32.CreateFileW(4039a0e0 L"Y:\\usr\\share\\wine\\wine.inf",80000000,00000001,0 0000000,00000003,00000000,00000000) ret=40c835af 0009:Ret kernel32.CreateFileW() retval=ffffffff ret=40c835af The config script has: [Drive Y] "Type" = "network" "Path" = "%HOME%" [Drive Z] "Type" = "network" "Path" = "/" So it should have been using Z:\\ Is this a problem in GetFullPathName or should I better use: /usr/bin/rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 z:\\usr\\share\\wine\\wine.inf ? Ciao, Marcus

4 4

dlls/ntdll/directory.c portability breakage
by Gerald Pfeifer 16 Mar '04

16 Mar '04

The new file dlls/ntdll/directory.c added by date: 2004/03/16 01:32:02; author: julliard; state: Exp; Implemented NtQueryDirectoryFile (partly based on a patch by Eric Pouech). broke non-Linux platforms (like FreeBSD): /usr/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o directory.o directory.c directory.c: In function `NtQueryDirectoryFile': directory.c:446: error: `O_DIRECTORY' undeclared (first use in this function) directory.c:446: error: (Each undeclared identifier is reported only once directory.c:446: error: for each function it appears in.) There *is* code to #define O_DIRECTORY /* To avoid blocking on non-directories in DOSFS_OpenDir_VFAT*/ #ifndef O_DIRECTORY # define O_DIRECTORY 0200000 /* must be directory */ #endif but it's in #ifdef linux only! Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

1 0

Re: cards.dll
by Joerg Mayer 16 Mar '04

16 Mar '04

On Tue, Mar 16, 2004 at 12:09:24AM +0200, Shachar Shemesh wrote: > Can someone remind me again why we can't have GPL DLLs in the tree? > Doesn't the "call through documented interface blah blah blah not > derived work" argument cause the license for each two DLLs in Wine to be > independant? Basically it goes like this: LGPLed code can be run as a library, i.e. a function of an LGPLed dll can be called as a function call. GPLed code must be run as a (Unix) process if you want to use it from non-GPL-compatible code. See the GPL and especially the GPL FAQ for details. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.

2 1

Re: shell32 patch 23 d [correction]
by Alexandre Julliard 15 Mar '04

15 Mar '04

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > Alexandre - is there any thing wrong with this patch? Yes there has to be something wrong, you create a sei_tmp structure but you never actually use it. I'm not sure what your intent was. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [resend] rebar.c: RBBS_HIDETITLE support
by Alexandre Julliard 15 Mar '04

15 Mar '04

Filip Navara <xnavara(a)volny.cz> writes: > I'm sending this patch second time. Is there any reason why it wasn't > commited previously or it just got lost? It will get in faster if you send a non wrapped version ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

dlls/glu32 compile error
by Peter Hyman 15 Mar '04

15 Mar '04

Kernel 2.6.4 gcc = 3.2.3 The following compile time error occurs: make[2]: Entering directory `/mnt/src/src/wine/dlls/glu32' gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o glu32.spec.o glu32.spec.c {standard input}: Assembler messages: {standard input}:274: Error: no such instruction: `yes "glu32.dll"' {standard input}:275: Error: no such instruction: `yes "gluBeginCurve"' {standard input}:276: Error: no such instruction: `yes "gluBeginPolygon"' {standard input}:277: Error: no such instruction: `yes "gluBeginSurface"' {standard input}:278: Error: no such instruction: `yes "gluBeginTrim"' {standard input}:279: Error: no such instruction: `yes "gluBuild1DMipmaps"' {standard input}:280: Error: no such instruction: `yes "gluBuild2DMipmaps"' {standard input}:281: Error: no such instruction: `yes "gluCheckExtension"' etc... The source file at this location is: "__wine_spec_exp_names:\n" "\tyes \"glu32.dll\"\n" "\tyes \"gluBeginCurve\"\n" "\tyes \"gluBeginPolygon\"\n" "\tyes \"gluBeginSurface\"\n" "\tyes \"gluBeginTrim\"\n" Seems like the \" is being taken as a literal ". Did you mean for a \ to occur? or a \glu... to occur? Regards -- Peter Hyman

2 1

Re: shell32 [was cards.dll]
by Martin Fuchs 15 Mar '04

15 Mar '04

On 15.03.2004 23:01:56 Martin Fuchs wrote: > Well to take up for the ReactOS folks.... Martin and Ge have done one hell > of a fine job on shell32 !! > And they have given every thing back.. Not once but twice! > As AJ was on vacation at the time and Martin & Ge spent alot of time > i'm sure spliting the patch up into smaller chunks so it would be > excepted here. .. and the merge is not yet finished. I hope it will ever be finished. But it takes a very long time by sending out those small patch pieces, waiting for the commit, and then go on... Currently I'm splitting the ShellExecute patch (aka "shell32 patch 23") into small pieces, and sending them separately since most of them depends on some another piece. On my list there are also patch nr. 1 and 22 without any answer from Alexandre or some one else. Is there really no possibility to speed this up a bit? If it's going on at the current speed it may be finished at next christmas day. ;-) Martin

1 0

static.c patch
by Filip Navara 15 Mar '04

15 Mar '04

Hi, I want to synchronize my change from ReactOS with the Wine tree. Unfortunetly I can't test it and I don't even know if it compiles under Wine. So if anyone want to take care of it, here it is. Regards, Filip --- static.c Tue Feb 10 20:09:04 2004 +++ static.c Mon Mar 15 21:34:06 2004 @@ -122,6 +122,7 @@ static HBITMAP STATIC_SetBitmap( HWND hwnd, HBITMAP hBitmap, DWORD style ) { HBITMAP hOldBitmap; + LONG full_style = GetWindowLongA( hwnd, GWL_STYLE ); if ((style & SS_TYPEMASK) != SS_BITMAP) return 0; if (hBitmap && GetObjectType(hBitmap) != OBJ_BITMAP) { @@ -129,7 +130,7 @@ return 0; } hOldBitmap = (HBITMAP)SetWindowLongA( hwnd, HICON_GWL_OFFSET, (LONG)hBitmap ); - if (hBitmap) + if (hBitmap && !(full_style & SS_REALSIZEIMAGE)) { BITMAP bm; GetObjectW(hBitmap, sizeof(bm), &bm); @@ -559,6 +560,7 @@ HBRUSH hbrush; HDC hMemDC; HBITMAP hBitmap, oldbitmap; + LONG full_style = GetWindowLongA( hwnd, GWL_STYLE ); GetClientRect( hwnd, &rc ); hbrush = (HBRUSH)SendMessageW( GetParent(hwnd), WM_CTLCOLORSTATIC, @@ -573,8 +575,17 @@ if (!(hMemDC = CreateCompatibleDC( hdc ))) return; GetObjectW(hBitmap, sizeof(bm), &bm); oldbitmap = SelectObject(hMemDC, hBitmap); - BitBlt(hdc, 0, 0, bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, - SRCCOPY); + if (full_style & SS_CENTERIMAGE) + { + BitBlt(hdc, (rc.right - bm.bmWidth) >> 1, + (rc.bottom - bm.bmHeight) >> 1, + bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, SRCCOPY); + } + else + { + BitBlt(hdc, 0, 0, bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, + SRCCOPY); + } SelectObject(hMemDC, oldbitmap); DeleteDC(hMemDC); }

1 0

Re:dlls/glu32 compile error
by Peter Hyman 15 Mar '04

15 Mar '04

Kernel 2.6.4 gcc = 3.2.3 The following compile time error occurs: clip... Needed to recheck from cvs. update did not work right. Now, however, I have the same problem as Tom Williams did with Kernel 2.6.3 and the include files using type __u32, etc. http://www.winehq.org/hypermail/wine-devel/2004/03/0093.html In fact, Configure is nice enough to note there is a problem with the test for cdrom.h, but does not abort. configure:16424: checking linux/cdrom.h usability configure:16436: gcc -c -g -O2 conftest.c >&5 In file included from /usr/include/linux/cdrom.h:14, from conftest.c:189: /usr/include/asm/byteorder.h:14: syntax error before "__u32" /usr/include/asm/byteorder.h:28: syntax error before "__u64" In file included from /usr/include/linux/byteorder/little_endian.h:11, from /usr/include/asm/byteorder.h:57, from /usr/include/linux/cdrom.h:14, from conftest.c:189: /usr/include/linux/byteorder/swab.h:133: syntax error before "__u16" /usr/include/linux/byteorder/swab.h:146: syntax error before "__u32" /usr/include/linux/byteorder/swab.h:160: syntax error before "__u64" configure:16442: $? = 1 configure: failed program was: | /* confdefs.h. */ | | #define PACKAGE_NAME "Wine" | #define PACKAGE_TARNAME "wine" | #define PACKAGE_VERSION "20040309" | #define PACKAGE_STRING "Wine 20040309" | #define PACKAGE_BUGREPORT "wine-devel(a)winehq.org" -- Peter Hyman

1 0

Replace SetConsoleCtrlHandler fixme with a comment
by Mike Hearn 15 Mar '04

15 Mar '04

This output can interfere with shell/wcmd processes, or at least make them harder to use. If we put every todo item in a fixme wine would be unusable anyway :) Mike Hearn <mh(a)codeweavers.com> Replace SetConsoleCtrlHandler fixme with a comment Index: dlls/kernel/console.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/console.c,v retrieving revision 1.26 diff -u -r1.26 console.c --- dlls/kernel/console.c 11 Mar 2004 22:46:27 -0000 1.26 +++ dlls/kernel/console.c 15 Mar 2004 13:44:22 -0000 @@ -1427,7 +1427,7 @@ { BOOL ret = TRUE; - FIXME("(%p,%i) - no error checking or testing yet\n", func, add); + /* FIXME: no error checking or testing yet */ if (!func) {

2 2

Debugger frontend
by Fabian Cenedese 15 Mar '04

15 Mar '04

Hi This project is a curses based frontend for gdb. Maybe there are some things useful for winedbg. The source view sure would make debugging easier. http://cgdb.sourceforge.net/ bye Fabi

2 1

Re: [AppDB] ID checks
by Tom 15 Mar '04

15 Mar '04

Paul van Schayck wrote: > Hey, > > A start to the AppDB. The whole system is using the strongly depreceated auto > registered globals. (The DB was made before this rule was made/enforced) > This patch will just fix that problem for the browsing trough the DB. > It will also check if we really have a numeric ID and not someone entering > evil SQL. > > Regards, > Paul van Schayck > Yah.... The first patch to the AppDB code! Tom

1 0

[Tools] Unshield from SynCE
by Uwe Bonnes 15 Mar '04

15 Mar '04

Hallo, perhaps out tool section should mention Unshield from SynCE http://synce.sourceforge.net/synce/ It allows to exctract IS 5|6 cabinet files Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

WineHQ AppDB Source
by Jeremy Newman 15 Mar '04

15 Mar '04

I have opened up the source to the WineHQ appdb. Anyone with spare time and some PHP skills is welcome to help improve it. The tree has not been touched in over a year. I did some work to clean it up for this import, and thats about it. I will be available to answer any questions on it. Check it out: cvs -d:pserver:cvs@cvs.winehq.org:/home/wine co appdb If there is interest, I plan to switch the online version to auto-update from CVS like the lostwages tree does. -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc.

1 0

Re: mdi: remove child activate optimization
by Huw D M Davies 15 Mar '04

15 Mar '04

On Mon, Mar 15, 2004 at 06:49:00PM +0300, Phil Krylov wrote: > Hello Huw, > > Monday, March 15, 2004, 2:27:41 PM, you wrote: > > HDMD> Hi Phil, > > HDMD> Could you send me a +relay,+message,+mdi log of this please? > > It's around 1M in size when bzipped; do you want me to send it to your > email at physics.ox.ac.uk? Sure, let's give that a go. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: Toolbar: Tooltips
by Dimitrie O. Paun 15 Mar '04

15 Mar '04

On March 14, 2004 8:03 pm, Robert Shearman wrote: > + * This code was audited for completeness against the documented features > + * of Comctl32.dll version 6.0 on Mar. 14, 2004, by Robert Shearman. Nice! Right now I have toolbar listed at 70% completion. Should I change that (when I said 70%, I wasn't basing my estimation on reality as I didn't audit the code, so an informed option would be much appreciated :)). -- Dimi.

1 0

FW: Re: Munge /r and /n in HTTP_HttpSendRequestA
by Rolf Kalbermatter 15 Mar '04

15 Mar '04

Argh, forget my previous message. I must have been utterly distracted. Rolf Kalbermatter -----Original Message----- From: Rolf Kalbermatter [mailto:rolf.kalbermatter@citeng.com] Sent: Mon, March 15, 2004 1:04 PM To: 'wine-devel(a)winehq.com' Cc: 'bon(a)elektron.ikp.physik.tu-darmstadt.de' Subject: Re: Munge /r and /n in HTTP_HttpSendRequestA Uwe Bonnes wrote: >The test for nLen is a good idea. But >with nLen = strlen(lpwhr->lpszPath); lpwhr->lpszPath[nLen] should give the >terminating NULL to my understanding... > >Or am I off by one? According to my ANSI C book strlen() returns the number of characters in a string NOT including the zero termination character. So I think in that case you would be indeed off by one. Rolf Kalbermatter

2 1

Re: Munge /r and /n in HTTP_HttpSendRequestA
by Rolf Kalbermatter 15 Mar '04

15 Mar '04

Uwe Bonnes wrote: >The test for nLen is a good idea. But >with nLen = strlen(lpwhr->lpszPath); lpwhr->lpszPath[nLen] should give the >terminating NULL to my understanding... > >Or am I off by one? According to my ANSI C book strlen() returns the number of characters in a string NOT including the zero termination character. So I think in that case you would be indeed off by one. Rolf Kalbermatter

2 2

Re: mdi: remove child activate optimization
by Phil Krylov 15 Mar '04

15 Mar '04

Hello Huw, Tuesday, March 9, 2004, 1:46:20 PM, you wrote: HDMD> Huw Davies <huw(a)codeweavers.com> HDMD> We need to at least refresh the window menu in ChildActivate, HDMD> so for now remove the 'is already activated' optimization. This patch brings a regression: IBM Translation Manager enters an endless activation-switching loop when closing one of its MDI children (which is in some non-trivial way used as a parent for 4 more MDI children). -- Best regards, Phil mailto:phil@newstar.rinet.ru

2 1

Re: Munge /r and /n in HTTP_HttpSendRequestA
by Rolf Kalbermatter 15 Mar '04

15 Mar '04

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: >This makes Xilinx webupdate.exe see the Servicepack > >+ else >+ /* remove \r and \n*/ >+ { >+ int nLen = strlen(lpwhr->lpszPath); >+ while ((lpwhr->lpszPath[nLen-1] == '\r')||(lpwhr->lpszPath[nLen-1] == '\n')) >+ { >+ nLen--; >+ lpwhr->lpszPath[nLen]='\0'; >+ } Mmmh, what happens if the passed in path would only exist of \r\n? A for or while loop without a guaranteed termination condition always seems suspect to me. I guess this would crash with an access violation, and most probably overwrite a few bytes of memory with 0 before that happens. Not good I think although I think it couldn't be effectively exploited as buffer overrun! while (nLen > 0 && ((lpwhr->lpszPath[nLen-1] == '\r') || (lpwhr->lpszPath[nLen-1] == '\n'))) might be the better solution. Though I still wonder about the [nLen-1] in above term. It seems [nLen] instead would be actually the right thing to do here which would make it while (nLen >= 0 && ((lpwhr->lpszPath[nLen] == '\r') || (lpwhr->lpszPath[nLen] == '\n'))) Rolf Kalbermatter

2 1

Re: Updated debug delay patch
by Uwe Bonnes 15 Mar '04

15 Mar '04

>>>>> "Mike" == Mike Hearn <mh(a)codeweavers.com> writes: Mike> Here is the updated version of my debug delay patch, back by Mike> popular request (well, ok, one person asked for it :) Mike> Usage is simple: Mike> WINEDELAY=1 WINEDEBUG=+relay wine foobar.exe Mike> Hit f12 in any window to switch debug tracing on/off Mike, it looks like the patch dosen't turn on debugging for new processes that where started after debugging for the parent process was turned on... Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Working otu what is happening in a network dependent app
by Peter Riocreux 15 Mar '04

15 Mar '04

I am trying to see if I can work out why an app that contacts a licensing daemon, doesn't. I am inexperienced at Wine debug stuff, so point me at docs if that is appropriate. 1. The host and port for the daemon are passed through an environment variable. I am *definitely* exporting this. Is there a noddy Wine app that will just print out all the environment it sees to I can be *absolutely* sure that my app is seeing it? 2. Is there a specific set of debug messages I can turn on to see (a) the app looking up the environment and (b) trying to open a network connection. tcpdump shows it is *not* sending *any* packets to the host/port that it *does* use when running in real WindowsXP. Regards, Peter

2 2

Fail load module
by flyker 15 Mar '04

15 Mar '04

Problem: The wphsesam.dll linked with libssvlux.so Contents libssvlux.def: LIBRARY libssvlux.so EXPORTS SSV_AllouerZoneMem@8 @1 SSV_ChargerLecteur@14 @2 SSV_FormaterFSE@29 @3 SSV_FormaterFichier@12 @4 SSV_FormaterLot@32 @5 SSV_InitTrace@11 @6 SSV_LibererZoneMem@4 @7 SSV_LireCartePS@20 @8 SSV_LireConfig@8 @9 SSV_LireDateLecteur@8 @10 SSV_LireDroitsVitale@32 @11 SSV_LireVITALE@20 @12 SSV_MajDateLecteur@8 @13 SSV_TraduireARL@18 @14 But when i load this module i have errors: err:module:import_dll Loading module (file) libssvlux.so (which is needed by L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll") failed (error c0000020). err:module:import_dll No implementation for libssvlux.so.SSV_AllouerZoneMem imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_ChargerLecteur imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_FormaterFSE imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_FormaterFichier imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_FormaterLot imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LibererZoneMem imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireCartePS imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireConfig imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireDateLecteur imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireDroitsVitale imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireVITALE imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_MajDateLecteur imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_TraduireARL imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef Help me please. What wrong here ?

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel