wine-devel

wine-devel@winehq.org

10 participants
84459 discussions

Re:dlls/glu32 compile error
by Peter Hyman 15 Mar '04

15 Mar '04

Kernel 2.6.4 gcc = 3.2.3 The following compile time error occurs: clip... Needed to recheck from cvs. update did not work right. Now, however, I have the same problem as Tom Williams did with Kernel 2.6.3 and the include files using type __u32, etc. http://www.winehq.org/hypermail/wine-devel/2004/03/0093.html In fact, Configure is nice enough to note there is a problem with the test for cdrom.h, but does not abort. configure:16424: checking linux/cdrom.h usability configure:16436: gcc -c -g -O2 conftest.c >&5 In file included from /usr/include/linux/cdrom.h:14, from conftest.c:189: /usr/include/asm/byteorder.h:14: syntax error before "__u32" /usr/include/asm/byteorder.h:28: syntax error before "__u64" In file included from /usr/include/linux/byteorder/little_endian.h:11, from /usr/include/asm/byteorder.h:57, from /usr/include/linux/cdrom.h:14, from conftest.c:189: /usr/include/linux/byteorder/swab.h:133: syntax error before "__u16" /usr/include/linux/byteorder/swab.h:146: syntax error before "__u32" /usr/include/linux/byteorder/swab.h:160: syntax error before "__u64" configure:16442: $? = 1 configure: failed program was: | /* confdefs.h. */ | | #define PACKAGE_NAME "Wine" | #define PACKAGE_TARNAME "wine" | #define PACKAGE_VERSION "20040309" | #define PACKAGE_STRING "Wine 20040309" | #define PACKAGE_BUGREPORT "wine-devel(a)winehq.org" -- Peter Hyman

1 0

Replace SetConsoleCtrlHandler fixme with a comment
by Mike Hearn 15 Mar '04

15 Mar '04

This output can interfere with shell/wcmd processes, or at least make them harder to use. If we put every todo item in a fixme wine would be unusable anyway :) Mike Hearn <mh(a)codeweavers.com> Replace SetConsoleCtrlHandler fixme with a comment Index: dlls/kernel/console.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/console.c,v retrieving revision 1.26 diff -u -r1.26 console.c --- dlls/kernel/console.c 11 Mar 2004 22:46:27 -0000 1.26 +++ dlls/kernel/console.c 15 Mar 2004 13:44:22 -0000 @@ -1427,7 +1427,7 @@ { BOOL ret = TRUE; - FIXME("(%p,%i) - no error checking or testing yet\n", func, add); + /* FIXME: no error checking or testing yet */ if (!func) {

2 2

Debugger frontend
by Fabian Cenedese 15 Mar '04

15 Mar '04

Hi This project is a curses based frontend for gdb. Maybe there are some things useful for winedbg. The source view sure would make debugging easier. http://cgdb.sourceforge.net/ bye Fabi

2 1

Re: [AppDB] ID checks
by Tom 15 Mar '04

15 Mar '04

Paul van Schayck wrote: > Hey, > > A start to the AppDB. The whole system is using the strongly depreceated auto > registered globals. (The DB was made before this rule was made/enforced) > This patch will just fix that problem for the browsing trough the DB. > It will also check if we really have a numeric ID and not someone entering > evil SQL. > > Regards, > Paul van Schayck > Yah.... The first patch to the AppDB code! Tom

1 0

[Tools] Unshield from SynCE
by Uwe Bonnes 15 Mar '04

15 Mar '04

Hallo, perhaps out tool section should mention Unshield from SynCE http://synce.sourceforge.net/synce/ It allows to exctract IS 5|6 cabinet files Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

WineHQ AppDB Source
by Jeremy Newman 15 Mar '04

15 Mar '04

I have opened up the source to the WineHQ appdb. Anyone with spare time and some PHP skills is welcome to help improve it. The tree has not been touched in over a year. I did some work to clean it up for this import, and thats about it. I will be available to answer any questions on it. Check it out: cvs -d:pserver:cvs@cvs.winehq.org:/home/wine co appdb If there is interest, I plan to switch the online version to auto-update from CVS like the lostwages tree does. -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc.

1 0

Re: mdi: remove child activate optimization
by Huw D M Davies 15 Mar '04

15 Mar '04

On Mon, Mar 15, 2004 at 06:49:00PM +0300, Phil Krylov wrote: > Hello Huw, > > Monday, March 15, 2004, 2:27:41 PM, you wrote: > > HDMD> Hi Phil, > > HDMD> Could you send me a +relay,+message,+mdi log of this please? > > It's around 1M in size when bzipped; do you want me to send it to your > email at physics.ox.ac.uk? Sure, let's give that a go. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: Toolbar: Tooltips
by Dimitrie O. Paun 15 Mar '04

15 Mar '04

On March 14, 2004 8:03 pm, Robert Shearman wrote: > + * This code was audited for completeness against the documented features > + * of Comctl32.dll version 6.0 on Mar. 14, 2004, by Robert Shearman. Nice! Right now I have toolbar listed at 70% completion. Should I change that (when I said 70%, I wasn't basing my estimation on reality as I didn't audit the code, so an informed option would be much appreciated :)). -- Dimi.

1 0

FW: Re: Munge /r and /n in HTTP_HttpSendRequestA
by Rolf Kalbermatter 15 Mar '04

15 Mar '04

Argh, forget my previous message. I must have been utterly distracted. Rolf Kalbermatter -----Original Message----- From: Rolf Kalbermatter [mailto:rolf.kalbermatter@citeng.com] Sent: Mon, March 15, 2004 1:04 PM To: 'wine-devel(a)winehq.com' Cc: 'bon(a)elektron.ikp.physik.tu-darmstadt.de' Subject: Re: Munge /r and /n in HTTP_HttpSendRequestA Uwe Bonnes wrote: >The test for nLen is a good idea. But >with nLen = strlen(lpwhr->lpszPath); lpwhr->lpszPath[nLen] should give the >terminating NULL to my understanding... > >Or am I off by one? According to my ANSI C book strlen() returns the number of characters in a string NOT including the zero termination character. So I think in that case you would be indeed off by one. Rolf Kalbermatter

2 1

Re: Munge /r and /n in HTTP_HttpSendRequestA
by Rolf Kalbermatter 15 Mar '04

15 Mar '04

Uwe Bonnes wrote: >The test for nLen is a good idea. But >with nLen = strlen(lpwhr->lpszPath); lpwhr->lpszPath[nLen] should give the >terminating NULL to my understanding... > >Or am I off by one? According to my ANSI C book strlen() returns the number of characters in a string NOT including the zero termination character. So I think in that case you would be indeed off by one. Rolf Kalbermatter

2 2

Re: mdi: remove child activate optimization
by Phil Krylov 15 Mar '04

15 Mar '04

Hello Huw, Tuesday, March 9, 2004, 1:46:20 PM, you wrote: HDMD> Huw Davies <huw(a)codeweavers.com> HDMD> We need to at least refresh the window menu in ChildActivate, HDMD> so for now remove the 'is already activated' optimization. This patch brings a regression: IBM Translation Manager enters an endless activation-switching loop when closing one of its MDI children (which is in some non-trivial way used as a parent for 4 more MDI children). -- Best regards, Phil mailto:phil@newstar.rinet.ru

2 1

Re: Munge /r and /n in HTTP_HttpSendRequestA
by Rolf Kalbermatter 15 Mar '04

15 Mar '04

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: >This makes Xilinx webupdate.exe see the Servicepack > >+ else >+ /* remove \r and \n*/ >+ { >+ int nLen = strlen(lpwhr->lpszPath); >+ while ((lpwhr->lpszPath[nLen-1] == '\r')||(lpwhr->lpszPath[nLen-1] == '\n')) >+ { >+ nLen--; >+ lpwhr->lpszPath[nLen]='\0'; >+ } Mmmh, what happens if the passed in path would only exist of \r\n? A for or while loop without a guaranteed termination condition always seems suspect to me. I guess this would crash with an access violation, and most probably overwrite a few bytes of memory with 0 before that happens. Not good I think although I think it couldn't be effectively exploited as buffer overrun! while (nLen > 0 && ((lpwhr->lpszPath[nLen-1] == '\r') || (lpwhr->lpszPath[nLen-1] == '\n'))) might be the better solution. Though I still wonder about the [nLen-1] in above term. It seems [nLen] instead would be actually the right thing to do here which would make it while (nLen >= 0 && ((lpwhr->lpszPath[nLen] == '\r') || (lpwhr->lpszPath[nLen] == '\n'))) Rolf Kalbermatter

2 1

Re: Updated debug delay patch
by Uwe Bonnes 15 Mar '04

15 Mar '04

2 1

Working otu what is happening in a network dependent app
by Peter Riocreux 15 Mar '04

15 Mar '04

I am trying to see if I can work out why an app that contacts a licensing daemon, doesn't. I am inexperienced at Wine debug stuff, so point me at docs if that is appropriate. 1. The host and port for the daemon are passed through an environment variable. I am *definitely* exporting this. Is there a noddy Wine app that will just print out all the environment it sees to I can be *absolutely* sure that my app is seeing it? 2. Is there a specific set of debug messages I can turn on to see (a) the app looking up the environment and (b) trying to open a network connection. tcpdump shows it is *not* sending *any* packets to the host/port that it *does* use when running in real WindowsXP. Regards, Peter

2 2

Fail load module
by flyker 15 Mar '04

15 Mar '04

Problem: The wphsesam.dll linked with libssvlux.so Contents libssvlux.def: LIBRARY libssvlux.so EXPORTS SSV_AllouerZoneMem@8 @1 SSV_ChargerLecteur@14 @2 SSV_FormaterFSE@29 @3 SSV_FormaterFichier@12 @4 SSV_FormaterLot@32 @5 SSV_InitTrace@11 @6 SSV_LibererZoneMem@4 @7 SSV_LireCartePS@20 @8 SSV_LireConfig@8 @9 SSV_LireDateLecteur@8 @10 SSV_LireDroitsVitale@32 @11 SSV_LireVITALE@20 @12 SSV_MajDateLecteur@8 @13 SSV_TraduireARL@18 @14 But when i load this module i have errors: err:module:import_dll Loading module (file) libssvlux.so (which is needed by L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll") failed (error c0000020). err:module:import_dll No implementation for libssvlux.so.SSV_AllouerZoneMem imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_ChargerLecteur imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_FormaterFSE imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_FormaterFichier imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_FormaterLot imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LibererZoneMem imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireCartePS imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireConfig imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireDateLecteur imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireDroitsVitale imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireVITALE imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_MajDateLecteur imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_TraduireARL imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef Help me please. What wrong here ?

1 0

Re: Updated debug delay patch
by Uwe Bonnes 14 Mar '04

14 Mar '04

>>>>> "Mike" == Mike Hearn <mh(a)codeweavers.com> writes: Mike> Here is the updated version of my debug delay patch, back by Mike> popular request (well, ok, one person asked for it :) Mike> Usage is simple: Mike> WINEDELAY=1 WINEDEBUG=+relay wine foobar.exe Mike> Hit f12 in any window to switch debug tracing on/off Mike, this patch comes like sent from heaven. However: > cat ../delay_debug | patch -s -p0 --dry-run 1 out of 3 hunks FAILED -- saving rejects to file dlls/ntdll/debugtools.c.rej 2 out of 3 hunks FAILED -- saving rejects to file libs/wine/debug.c.rej 1 out of 1 hunk FAILED -- saving rejects to file include/wine/debug.h.rej Looking at the rejects, I could see no cause for the rejection however. Appended patch applies clean -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/ntdll/debugtools.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/debugtools.c,v retrieving revision 1.37 diff -u -r1.37 debugtools.c --- wine/dlls/ntdll/debugtools.c 3 Mar 2004 21:34:13 -0000 1.37 +++ wine/dlls/ntdll/debugtools.c 14 Mar 2004 13:02:46 -0000 @@ -300,7 +300,7 @@ ret += wine_dbg_printf( "%s:%s:%s ", classes[cls], channel + 1, function ); } if (format) - ret += NTDLL_dbg_vprintf( format, args ); + ret += __wine_dbg_vprintf( format, args ); return ret; } @@ -313,5 +313,6 @@ __wine_dbgstr_wn = NTDLL_dbgstr_wn; __wine_dbg_vsprintf = NTDLL_dbg_vsprintf; __wine_dbg_vprintf = NTDLL_dbg_vprintf; + if (getenv("WINEDELAY")) wine_dbg_toggle_block(); __wine_dbg_vlog = NTDLL_dbg_vlog; } Index: wine/libs/wine/debug.c =================================================================== RCS file: /home/wine/wine/libs/wine/debug.c,v retrieving revision 1.3 diff -u -r1.3 debug.c --- wine/libs/wine/debug.c 5 Dec 2003 00:17:41 -0000 1.3 +++ wine/libs/wine/debug.c 14 Mar 2004 13:02:46 -0000 @@ -54,6 +54,9 @@ static const char * const debug_classes[] = { "fixme", "err", "warn", "trace" }; +static int disabled_dbg_vprintf( const char *format, va_list args ); +static void* old_vprintf = &disabled_dbg_vprintf; /* used when blocking debug output */ + static int cmp_name( const void *p1, const void *p2 ) { const char *name = p1; @@ -140,6 +143,16 @@ } } +static int disabled_dbg_vprintf( const char *format, va_list args ) { + return 0; +} + +/* prevents printing of debug messages temporarily */ +void wine_dbg_toggle_block() { + fprintf(stderr, "wine: toggling tracing\n"); + old_vprintf = interlocked_xchg_ptr((void**)&__wine_dbg_vprintf, old_vprintf); /* fixme: is this thread safe? */ +} + /* parse a set of debugging option specifications and add them to the option list */ int wine_dbg_parse_options( const char *str ) { @@ -412,3 +425,4 @@ { return __wine_dbgstr_wn( s, -1 ); } + Index: wine/libs/wine/wine.def =================================================================== RCS file: /home/wine/wine/libs/wine/wine.def,v retrieving revision 1.10 diff -u -r1.10 wine.def --- wine/libs/wine/wine.def 5 Feb 2004 02:01:35 -0000 1.10 +++ wine/libs/wine/wine.def 14 Mar 2004 13:02:46 -0000 @@ -9,6 +9,7 @@ __wine_dbgstr_an __wine_dbgstr_wn __wine_dll_register + wine_dbg_toggle_block __wine_main_argc __wine_main_argv __wine_main_environ Index: wine/libs/wine/wine.map =================================================================== RCS file: /home/wine/wine/libs/wine/wine.map,v retrieving revision 1.1 diff -u -r1.1 wine.map --- wine/libs/wine/wine.map 12 Feb 2004 22:54:00 -0000 1.1 +++ wine/libs/wine/wine.map 14 Mar 2004 13:02:46 -0000 @@ -6,6 +6,7 @@ __wine_dbg_vlog; __wine_dbg_vprintf; __wine_dbg_vsprintf; + wine_dbg_toggle_block; __wine_dbgstr_an; __wine_dbgstr_wn; __wine_dll_register; Index: wine/dlls/x11drv/keyboard.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/keyboard.c,v retrieving revision 1.49 diff -u -r1.49 keyboard.c --- wine/dlls/x11drv/keyboard.c 2 Mar 2004 20:55:57 -0000 1.49 +++ wine/dlls/x11drv/keyboard.c 14 Mar 2004 13:02:51 -0000 @@ -1171,6 +1171,11 @@ KEYBOARD_GenerateMsg( VK_CAPITAL, 0x3A, event->type, event_time ); TRACE("State after : %#.2x\n",pKeyStateTable[vkey]); break; + case VK_F12: + if ((event->type == KeyPress) && getenv("WINEDELAY")) { + /* we get this event repeatedly if we hold down the key (keyboard repeat) */ + wine_dbg_toggle_block(); + } default: /* Adjust the NUMLOCK state if it has been changed outside wine */ if (!(pKeyStateTable[VK_NUMLOCK] & 0x01) != !(event->state & NumLockMask)) Index: wine/include/wine/debug.h =================================================================== RCS file: /home/wine/wine/include/wine/debug.h,v retrieving revision 1.12 diff -u -r1.12 debug.h --- wine/include/wine/debug.h 18 Nov 2003 20:47:48 -0000 1.12 +++ wine/include/wine/debug.h 14 Mar 2004 13:02:52 -0000 @@ -145,6 +145,7 @@ extern int wine_dbg_printf( const char *format, ... ) __WINE_PRINTF_ATTR(1,2); extern int wine_dbg_log( unsigned int cls, const char *ch, const char *func, const char *format, ... ) __WINE_PRINTF_ATTR(4,5); +extern void wine_dbg_toggle_block(); static inline const char *wine_dbgstr_guid( const GUID *id ) {

2 1

Re: shell32 patch 23 d [correction]
by Martin Fuchs 14 Mar '04

14 Mar '04

Alexandre - is there any thing wrong with this patch? > Changelog: > - expand environment strings in command, parameter and directory strings of > ShellExecuteExW32() My follow-up patches are blocked by this not yet committed patch.

1 0

README update offer
by Christian Britz 13 Mar '04

13 Mar '04

Hi, I know that I was pointed to the README file for my first german translation "because it is pretty stable and no major overhauls are planned". ;-) Nevertheless, I refuse to not offer you a little bit of my time to update some parts of the README and README.de files (the other translators would have to follow because I don't speak their languages well enough). I have two major update favorites: 1) Fabian Cenedese and others have made some good remarks about parts of the README being not precise enough or a little bit wrong / outdated. I would like to work on these sections. 2) Someone on the ML of my local LUG asked a rather simple question that would fit to the "quick start" section IMO. He asked how to include original MS fonts into wine because some Windows application seems to demand them being present (physically). A short explanation of this and the possibility to use native DLL files would perfect to a README file I think. Using native files certainly is not a primary goal of wine development; on the other hand it could help new users or users with tricky applications a lot. I will wait for your positive or negative feedback before I will post to wine-patches. If updating the README at this time is not wanted at all, please let me also know. I would offer then my help later. Christian

3 5

Re: Documentation does not get installed with cvs sources?!
by Ivan Leo Murray-Smith 13 Mar '04

13 Mar '04

AFAIK ./configure make depend make has never built the docs, at least since I use wine. Ivan.

2 1

Re: Application database
by Ivan Leo Murray-Smith 13 Mar '04

13 Mar '04

> I've noticed that the application database hasn't been updated for quite > some time. I'm willing to help to keep it up to date or become the > maintainer. I can help on this, if it's needed, and as long as I aren't alone. Ivan.

1 0

Willing to help with animated icons/cursors
by Joel Konkle-Parker 13 Mar '04

13 Mar '04

If anyone out there is currently working on animated icons/cursors in cursoricon.c, I'd like to try to help in any way I can. I'm not really sure where to start on my own though. Thanks in advance. -- Joel Konkle-Parker Webmaster [Ballsome.com] E-mail [jjk3(a)msstate.edu]

3 3

Re: wine/dlls/comctl32 rebar.c
by Robert Shearman 13 Mar '04

13 Mar '04

On Sat, 2004-03-13 at 02:12, Mike McCormack wrote: > Btw. what is the problem? When i click "Search" or "Favourites" in IE6, > it seems to work for me. Which version of IE are you using, and what is > the exact problem you are seeing? It is v6.0.2800.1106 The problem is that all of the Search, Favorites, Media and History sidebars seem to open the rebar in a very tiny width (it depends on which is being displayed). For example, the rebar in the history sidebar has a width of 4 pixels. The Media sidebar (shown in attachment) is slightly better with a width of 16 pixels. BTW, it is definitely this patch. I have tried reversing the other rebar patch and it made absolutely no difference. > A screenshot maybe? Attached. Rob

1 0

Re: wine/ misc/options.c documentation/wine.man.in ...
by Uwe Bonnes 12 Mar '04

12 Mar '04

>>>>> "Alexandre" == Alexandre Julliard <julliard(a)winehq.org> writes: ... Alexandre> ... Start deprecating the --debugmsg option. Would a patch extending the wrapper to understand all those old but handy options ( --debugmsg , --dll) be acceptable? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

5 9

Re: wine/dlls/comctl32 rebar.c
by Robert Shearman 12 Mar '04

12 Mar '04

On Fri, 2004-03-12 at 20:23, Alexandre Julliard wrote: > ChangeSet ID: 11458 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/03/12 14:23:39 > > Modified files: > dlls/comctl32 : rebar.c > > Log message: > Mike McCormack <mike(a)codeweavers.com> > Don't calculate the redundant and unused REBAR_ROW structures. > > Patch: http://cvs.winehq.org/patch.py?id=11458 This patch causes big problems with the width of the sidebars in IE6. I recommend that it be reversed until this issue has been investigated and resolved. Rob

1 0

Re: Add debug SnoopFromInclude/SnoopFromExclude options
by Alexandre Julliard 12 Mar '04

12 Mar '04

Mike Hearn <mh(a)codeweavers.com> writes: > + if (!check_snoop_from_module(name)) { > + TRACE_(snoop)("skipping snoop for %s\n", name); > + return; > + } This will disable snoop for calls into that dll, this is not what FromInclude/Exclude should do, it should check the caller module. -- Alexandre Julliard julliard(a)winehq.org

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel