wine-devel

wine-devel@winehq.org

10 participants
84459 discussions

Oleaut32 tests fail
by Sylvain Petreolle 14 Jan '04

14 Jan '04

Running the oleaut32 tests shows that vartype and vartest are failing. The 25 tests that fail are returning DISP_E_TYPEMISMATCH (0x80020005) Has someone an idea about these ? vartest.c:2653:======== Testing different VARTYPES ======== fixme:ole:VarParseNumFromStr dwInFlags & NUMPRS_HEX_OCT not yet implemented! vartest.c:2680: Test failed: 14: vt 83, return value 80020005, expected was 0 ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 Say NO to software patents Dites NON aux brevets logiciels "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". _________________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Re: Re: slight trouble running winetests under windows
by chmorgan＠charter.net 14 Jan '04

14 Jan '04

Ahh yes, this appears to be the issue. If I go to "project settings->link->object/library modules" and add "uuid.lib" to the list then the test compiles without many other issues. Shouldn't the script be adding this to the .dsp/.dsw? I'm having great troubles compiling the test against vs6 header files as well, should I upgrade to the latest platform sdk? The wine headers work pretty well except for errors from the compiler about not being able to convert __uint64 to double. Chris > > From: Hans Leidekker <hans(a)it.vu.nl> > Date: 2004/01/13 Tue AM 05:20:29 EST > To: wine-devel <wine-devel(a)winehq.com> > CC: Chris Morgan <cmorgan(a)alum.WPI.EDU> > Subject: Re: slight trouble running winetests under windows > > On Tuesday 13 January 2004 05:47, Chris Morgan wrote: > > > I'm trying to get some of the wine tests compiling and running under > > windows, oleaut32 test specifically. I've got the project file built and > > everything opens fine under visual studio 6. The only issue is that during > > linking of the oleaut32 tests _IID_IFont is undefined. Oddly enough if I > > I get these linking errors too when compiling with MinGW. I solve > these by manually adding -luuid. The dsound test needs -luuid and > -ldxguid to link. There has been some discussion in the past as to > how to solve this. I proposed a number of changes to Wine's build > system to fix this but they were rejected. > > Let's see if I can sum up the issues. In Wine uuids are put in > a lib called libwine_uuid. It's called like that because a > libuuid already exists. Second thing is that in MinGW and MSVC > there are two separate libraries with uuids, uuid and dxguid, > whereas in Wine they're all in one. > > -Hans > >

3 2

Re: Implement LockWindowUpdate [take 2]
by Alexandre Julliard 14 Jan '04

14 Jan '04

Mike Hearn <mike(a)theoretic.com> writes: > The other reason it might have bounced is if we're not allowed to extend > WND, though as it's purely internal and not accessible from the APIs that > should be OK? I'm not sure how to do this otherwise without exporting the > currently locked window variable from USER to X11DRV which probably breaks > dll separation. Either that, or adding a new driver procedure. Extending the WND structure is OK (though it doesn't seem necessary in that case), but accessing it from x11drv is a violation of dll separation. We still do that in a number of places but they will have to be fixed, so we probably shouldn't add new ones. -- Alexandre Julliard julliard(a)winehq.com

2 2

Cdrom driver
by Robert Lunnon 13 Jan '04

13 Jan '04

I have just finished embelishing the cdrom driver to support solaris but I have nothing to test it against. Can anyone recommend a good test program for excercising CDROM ioctls ? Thanks Bob

2 1

Re: Solaris compile time fixes for CVS wine
by Dimitrie O. Paun 13 Jan '04

13 Jan '04

On January 8, 2004 01:22 am, Robert Lunnon wrote: > Here are a buch of Solais compatibility patches for wine (Some but not all > of them). Within the enclosed tarball the diffs are structured according to > the wine cvs tree. There is a readme file accompanying each diff to explain > what the change is. Please break the archive into one patch per message, not compressed (preferably inlined). Here are a few pointers on how to send patches: http://www.winehq.org/site/sending_patches BTW, what's the status of building Wine under Solaris? What architecture (i386, etc) are you using? -- Dimi.

4 3

Re: [Bug 521] WINE removes trailing backslash in GetFullPathNameA/W in dos_fs.c.
by Eric Pouech 13 Jan '04

13 Jan '04

Mike McCormack a écrit : > > This closes bug 521, and removes a couple of wine_todos from the > regression test for pathes. The test for setting "lastpart" in both > GetFullPathNameA/W was wrong (would always pass). for the record, I also sent a patch regarding (among other things) this issue, which also has never been applied. I don't know Alexandre's state on this. A+

2 3

WWN Links are busted
by Tom 13 Jan '04

13 Jan '04

Hi, If you try to go to a WWN article from the status page's they don't work. example : Wine's fundamental architecture #154 = http://www.winehq.com/site/status_wine?issue=154#Kernel%20Module%20/%20Shar… the current link is: <a href="?issue=154#Kernel%20Module%20/%20Shared%20Memory%20Revisited">#154</a></td> when I think it should be: <a href="{$root}/site/?issue=154#Kernel%20Module%20/%20Shared%20Memory%20Revisited">#154</a></td> Jeremey N is this correct? If so I can fix all the links in the next day or so.. Tom

2 1

Re: WWN Links are busted
by Brian Vincent (C) 13 Jan '04

13 Jan '04

> the current link is: > <a > href="?issue=154#Kernel%20Module%20/%20Shared%20Memory%20Revisited">#154</a> </td> I think it should be: href="/?issue=154#Kernel%20Module%20/%20Shared%20Memory%20Revisited" sed -e "s/href=\"\?/href=\"\/\?/g" --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

1 0

Re: shell32 patches to be usable by ReactOS Explorer
by Alexandre Julliard 13 Jan '04

13 Jan '04

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > This was no joke. If you say, you would accept such as reformating patch, > I can easyly create one that eliminates all tab-characters, and generates > nice and uniform indented code. > This will make it a bit easier to create the small self-contained patches > you want to see instead of the big one. As additional bonus you will get > a very better formated shell32 code base. There's no reason to reformat all of shell32. If a given function is messed up you can fix it (in a separate patch), but otherwise it doesn't really matter if all functions don't use the exact same style. -- Alexandre Julliard julliard(a)winehq.com

2 1

stray file
by Hans Leidekker 13 Jan '04

13 Jan '04

Hi, There's a stray file, dlls/checklink.c, in Wine CVS with these contents: int main(void) { return 0; } It must be a leftover from a configure run. I suspected my own tree but but it came back after I removed it and did a cvs update. -Hans

4 4

Re: uxtheme: lots of infrastructure
by Alexandre Julliard 13 Jan '04

13 Jan '04

Kevin Koltzau <kevin(a)plop.org> writes: > This is a ton of infrastructure for my future patches, and a full > implementation of GetThemeDocumentationProperty which I primarilly > used to test my INI file processing, and its now possible to set the > current theme through the API..not that its much use to do that yet The part about storing the string maps as resources seems unnecessarily complicated and inefficient. Why can't you store an array directly in the code? -- Alexandre Julliard julliard(a)winehq.com

2 4

[Janitorial] Remove CopyMetaFileW->A call
by Vincent Béron 13 Jan '04

13 Jan '04

Indentation in CopyMetaFileW is a bit inconsistent (there are some tabs which I left since I didn't touch those lines). Should I redo my patch to get rid of them (adds some noise to the patch), keep them in a separate patch (limited to this very function) or leave it as is? Also, should I change MF_CreateMetaHeaderDisk to accept a LPCWSTR, even though it then needs to convert it back to Ascii, or is the proposed way sufficient? Changelog: Removed a W->A cross-call (CopyMetaFileW->CopyMetaFileA). Vincent

1 0

Re: Implemention of LockWindowUpdate
by Mike Hearn 13 Jan '04

13 Jan '04

On Tue, 13 Jan 2004 00:10:20 +0000, Mike Hearn wrote: > This patch makes the halflife menu screen look a bit better, with less > flashing. Unfortunately it also makes it feel a bit slower, but I think > that's just an optical illusion caused by less screen activity. The > bottleneck is elsewhere. Just had a hunch, and yes, switching off XRender and antialiasing speeds things up nicely. I guess I should yell at keithp or something.... :)

1 0

Re: wine/ windows/scroll.c include/user.h dlls/x11 ...
by Dimitrie O. Paun 12 Jan '04

12 Jan '04

On Mon, 12 Jan 2004, Alexandre Julliard wrote: > Log message: > ScrollDC doesn't need to be in the graphics driver. Yay! (I submitted a similar patch some time ago, but you didn't like the {Start,End}GraphicsExposures functions. I still think they are decent GUI abstractions :)): http://www.winehq.com/hypermail/wine-patches/2002/09/0196.html Speaking of these things, I also don't think the driver should know about the caret. I see no need for the USER driver to know anything about the caret, we can just always implement it ourselves, no? http://www.winehq.com/hypermail/wine-patches/2002/09/0174.html I think there is a bug in the above patch (IIRC, I used to get some freezing in certain situations), but the idea still stands. -- Dimi.

2 1

Re: [WINEALSA] Add Midi IN support (take 3)
by Alexandre Julliard 12 Jan '04

12 Jan '04

Christian Costa <titan.costa(a)wanadoo.fr> writes: > +static int npfd; > +static int pfd_array_size = 0; > +static struct pollfd *pfd = NULL; This isn't thread-safe. Why don't you simply allocate the array in the function and free it when you are done? -- Alexandre Julliard julliard(a)winehq.com

2 2

Re: shell32 patches to be usable by ReactOS Explorer
by Martin Fuchs 12 Jan '04

12 Jan '04

On 12.01.2004 01:41:45 Alexandre Julliard wrote: > "Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > > > Mhh - could you please tell me which "ugly hacks" you are speaking of? > > From a quick look at the patch, what I noticed is mostly the ifdefs > and other various disabling/commenting out of parts of the code. We had to disable some calls to internal functions, which are only exported from WINE, no real Windows OS. > There are also a number of unneeded whitespace changes that make the > patch larger than it should be. Yes, I tried to make some functions I had to alter a bit more readable. What about running a pretty printer, for example astyle (http://astyle.sourceforge.net/) on the whole code (or at least the shell32 directory) ? Some sections are currently indented with 2, some with 4 and some with 8 spaces - even mixed in the same function. Regards, Martin

1 1

Re: [Janitorial] ResetDCA->ResetDCW
by Dmitry Timoshkov 12 Jan '04

12 Jan '04

"Vincent Beron" <vberon(a)mecano.gme.usherb.ca> wrote: > Changelog: > Get rid of a W->A crosscall (ResetDCA->ResetDCW). > -HDC WINAPI ResetDCW( HDC hdc, const DEVMODEW *devmode ) > +HDC WINAPI ResetDCA( HDC hdc, const DEVMODEA *devmode ) > { > - return ResetDCA(hdc, (const DEVMODEA*)devmode); /* FIXME */ > + DEVMODEW *devmodeW; > + HDC ret; > + > + if (devmode) devmodeW = GdiConvertToDevmodeW(devmode); > + else devmodeW = NULL; > + > + ret = ResetDCW(hdc, (const DEVMODEW*)devmode); It would be better to pass a real, newly allocated DEVMODEW* to ResetDCW(). That way you shouldn't need to cast type of a pointer. -- Dmitry.

2 1

Re: #2 - Mdi Win16/32 Split
by Dimitrie O. Paun 12 Jan '04

12 Jan '04

On January 2, 2004 10:31 am, Steven Edwards wrote: > Split up the Win16/32 MDI support a bit. Any idea what the status of the Win16/32 split is? What DLLs are still not properly split? -- Dimi.

4 11

Re: shell32 patches to be usable by ReactOS Explorer
by Dimitrie O. Paun 12 Jan '04

12 Jan '04

On January 11, 2004 08:04 am, Martin Fuchs wrote: > This patch consists of a number of changes we implemented in the ReactOS > CVS tree in order to use Wine's shell32.dll implementation for ReactOS > explorer. Please see the following changelog lists for the individual patch > descriptions: Martin, sending a bunch of patches compressed and in one message, makes them almost unreviewable but by the most die hards readers of wine-patches. It also makes it so much more difficult for Alexandre to split them up, match the ChangeLog, review them, etc. Please stick to one-(uncompressed, inlined)-patch-per-email-messsage rule, it's so much better for everybody. Here are some relevant links: http://www.winehq.org/site/sending_patches http://www.winehq.org/site/docs/wine-devel/patches -- Dimi.

4 6

Re: [Janitorial] ResetDCA->ResetDCW
by Dimitrie O. Paun 12 Jan '04

12 Jan '04

On January 11, 2004 03:43 pm, Vincent Béron wrote: > Dimi, do you prefer to keep track of progress on this yourself, or > should I send a patch for the janitorial page too? It would be great if you'd send the update to the janitorial page. I try to keep track, but it's so much easier if patch authors lend a hand. But please wait until Alexandre commits it. -- Dimi.

1 0

Re: bogus patch to bind() dlls/winsock/socket.c (request removal)
by Ivan Leo Murray-Smith 11 Jan '04

11 Jan '04

> With this change, we can use the 6.3 version of Quicktime > to see streamed video from Wineconf... This would break Grand Prix Legends and Nascar 2002 (Thats why the patch was written in the first place), maybe you should contact the author of the patch, a proper fix would be better, why should we chose between 2 games and quicktime? It should be possible to run all these apps. Ivan.

4 4

Re: [WINEALSA] Add Midi IN support (w/o alloca)
by Eric Pouech 11 Jan '04

11 Jan '04

Christian Costa a écrit : > + for (wDevID = 0; wDevID < MIDM_NumDevs; wDevID++) > + if ( (ev->source.client == MidiInDev[wDevID].addr.client) && (ev->source.client == MidiInDev[wDevID].addr.client) ) > + break; Why do you do twice the same test ? A+

2 1

exception outside of stack limits
by Robert Lunnon 11 Jan '04

11 Jan '04

There is a warning in signal_i368.c WARN( "exception outside of stack limits in thread %04lx eip %08lx esp %08lx stack %p-%p\n", GetCurrentThreadId(), EIP_sig(sigcontext), Can anyone tell me what this "means" in terms of what would have to go wrong to generate this warning ??

2 2

Correction to wineps spec file
by Vincent Béron 11 Jan '04

11 Jan '04

Changelog: CreateDC in wineps is Unicode now, change the spec file accordingly. Vincent

1 0

Re: [WINEALSA] Add Midi IN support
by Alexandre Julliard 11 Jan '04

11 Jan '04

Christian Costa <titan.costa(a)wanadoo.fr> writes: > + int npfd; > + struct pollfd *pfd; > + > + npfd = snd_seq_poll_descriptors_count(midiSeq, POLLIN); > + pfd = (struct pollfd *)alloca(npfd * sizeof(struct pollfd)); You should not use alloca in Wine, it's not portable enough. -- Alexandre Julliard julliard(a)winehq.com

4 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel