wine-devel

wine-devel@winehq.org

84471 discussions

More deadlocks + backtrace
by Shachar Shemesh 13 Dec '03

13 Dec '03

I ran "spyxx" from MSVC on my deadlocking program, and everything was ok. I then quite the program itself (Microsoft Digital Image Pro was run with +relay, spy was run without any debug values). I left spy running for a while (~2 days), as I had other things to do, and I wanted the window handles it collected. At some point, the console that launched spy began showing the following: $ wine SPYXX err:font:ReadFontDir Can't open directory "/win/windows/fonts" fixme:mdi:MDIRefreshMenu partially function stub fixme:mdi:MDIRefreshMenu partially function stub err:toolbar:TOOLBAR_NotifyFormat wrong response to WM_NOTIFYFORMAT (0), assuming ANSI err:win:CreateWindowExA bad class name "msctls_updown" err:ntdll:RtlpWaitForCriticalSection section 0x40380d68 "?" wait timed out in thread 0011, blocked by 0000, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x40380d68 "?" wait timed out in thread 0011, blocked by 0000, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x40380d68 "?" wait timed out in thread 0011, blocked by 0000, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x40380d68 "?" wait timed out in thread 0011, blocked by 0000, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x40380d68 "?" wait timed out in thread 0011, blocked by 0000, retrying (60 sec) Here are the backtraces: Wine-dbg>walk process pid threads parent executable >00000010 2 00000000 'Y:\sources\Transfer\RemoteDebug\SPYXX.EXE' Wine-dbg>walk thread process tid prio 00000010 (D) Y:\sources\Transfer\RemoteDebug\SPYXX.EXE 00000012 0 <== 00000011 0 Wine-dbg>bt 0x11 Backtrace: =>0 0x4010e8ab (NTDLL.DLL._memccpy+0x5202b in libc.so.6) (ebp=40032c60) 1 0x401f4002 (NTDLL_wait_for_multiple_objects+0xbf(count=0x0, handles=0x0, flags=0x8, timeout=0x40032d10) [sync.c:578] in NTDLL.DLL) (ebp=40032cf8) 2 0x401f1edd (usr1_handler+0x4e(__signal=0xa, __context=0x8f) [signal_i386.c:1123] in NTDLL.DLL) (ebp=40032d1c) 3 0x4006e498 (NTDLL.DLL.toupper+0x6208 in libc.so.6) (ebp=4080f7e0) 4 0x401f4002 (NTDLL_wait_for_multiple_objects+0xbf(count=0x1, handles=0x4080f8cc, flags=0xc, timeout=0x4080f900) [sync.c:578] in NTDLL.DLL) (ebp=4080f878) 5 0x401f40ae (NTDLL.DLL.NtWaitForMultipleObjects+0x74 in NTDLL.DLL) (ebp=4080f8a0) 6 0x401f40fe (NtWaitForSingleObject+0x42(handle=0x88, alertable=0x0, timeout=0x4080f900) [sync.c:611] in NTDLL.DLL) (ebp=4080f8c4) 7 0x401cda35 (RtlpWaitForCriticalSection+0x127(crit=0x40380d68) [critsection.c:193] in NTDLL.DLL) (ebp=4080f964) 8 0x401cdc25 (RtlEnterCriticalSection+0x51(crit=0x40380d68) [critsection.c:255] in NTDLL.DLL) (ebp=4080f97c) 9 0x404f2555 (wine_pthread_mutex_lock+0x34(mutex=0x101593c8) [pthread.c:182] in KERNEL32.DLL) (ebp=4080f98c) 10 0x0011273a (__pthread_mutex_lock+0x25(mutex=0x101593c8) [kthread.c:588] in wine-kthread) (ebp=4080f99c) 11 0x40f409ea (_end+0x75bb6 in libX11.so.6) (ebp=4080f9bc) 12 0x40f0d799 (_end+0x42965 in libX11.so.6) (ebp=4080fa1c) 13 0x40e8b39e (X11DRV_InitKeyboard+0x84(key_state_table=0x40b66880) [keyboard.c:1332] in X11DRV.DLL) (ebp=4080fadc) 14 0x40e8c1c4 (X11DRV_MappingNotify+0x35(event=0x4080fb94) [keyboard.c:1635] in X11DRV.DLL) (ebp=4080fafc) 15 0x40e83647 (.L164+0xb [event.c] in X11DRV.DLL) (ebp=4080fb7c) 16 0x40e82e65 (process_events+0x71(data=0x40380d40) [event.c:143] in X11DRV.DLL) (ebp=4080fbf8) 17 0x40e82ffa (X11DRV_MsgWaitForMultipleObjectsEx+0x17b(count=0x1, handles=0x40380c6c, timeout=0xffffffff, mask=0x0, flags=0x0) [event.c:184] in X11DRV.DLL) (ebp=4080fd38) 18 0x40ad5f96 (GetMessageW+0x287(msg=0x46becc, hwnd=0x0, first=0x0, last=0x0) [message.c:2363] in USER32.DLL) (ebp=4080fdf4) 19 0x40ad6020 (GetMessageA+0x33(msg=0x46becc, hwnd=0x0, first=0x0, last=0x0) [message.c:2380] in USER32.DLL) (ebp=4080fe14) 20 0x6c3be6e9 (MFC42.DLL.5307+0x13 in MFC42.DLL) (ebp=0046becc) 21 0x0000000f (ebp=000100d6) Wine-dbg>bt 0x12 Backtrace: =>0 0x4010e8ab (NTDLL.DLL._memccpy+0x5202b in libc.so.6) (ebp=4030fc60) 1 0x401f4002 (NTDLL_wait_for_multiple_objects+0xbf(count=0x0, handles=0x0, flags=0x8, timeout=0x4030fd10) [sync.c:578] in NTDLL.DLL) (ebp=4030fcf8) 2 0x401f1edd (usr1_handler+0x4e(__signal=0xa, __context=0x8f) [signal_i386.c:1123] in NTDLL.DLL) (ebp=4030fd1c) 3 0x4006e498 (NTDLL.DLL.toupper+0x6208 in libc.so.6) (ebp=419eb450) 4 0x401f4002 (NTDLL_wait_for_multiple_objects+0xbf(count=0x1, handles=0x419eb53c, flags=0xc, timeout=0x419eb530) [sync.c:578] in NTDLL.DLL) (ebp=419eb4e8) 5 0x401f40ae (NTDLL.DLL.NtWaitForMultipleObjects+0x74 in NTDLL.DLL) (ebp=419eb510) 6 0x404fcb20 (WaitForMultipleObjectsEx+0x1d5(count=0x1, handles=0x419eb670, wait_all=0x0, timeout=0x32, alertable=0x0) [sync.c:167] in KERNEL32.DLL) (ebp=419eb648) 7 0x404fc8b8 (WaitForSingleObject+0x3c(handle=0x64, timeout=0x32) [sync.c:95] in KERNEL32.DLL) (ebp=419eb668) 8 0x004232fa (SPYXX.EXE..text+0x222fa in SPYXX.EXE) (ebp=40aab4df) 9 0x0168ec81 (SPYXX.EXE..rsrc+0x1221c81 in wine-kthread) (ebp=53e58955) *** Invalid address 0x53e58955 (_end+0x121f453d) I hope this helps someone. -- Shachar Shemesh Open Source integration & consulting Home page & resume - http://www.shemesh.biz/

2 3

Added support for inter-process GetWindowLong on the window extra bytes
by Phil Krylov 13 Dec '03

13 Dec '03

Hello, This change prevents IBM Translation Manager from working correctly. It has a dialog named "Export Folder" which used to contain three buttons and a tabbed notebook with various options. After this update, the pages of the tabbed notebook are no longer displayed (and created). Hope I can provide some more details like a debug log if someone will tell me which channels should be traced. AJ> ChangeSet ID: 10222 AJ> CVSROOT: /opt/cvs-commit AJ> Module name: wine AJ> Changes by: julliard(a)wine.codeweavers.com 2003/11/26 16:15:41 AJ> Modified files: AJ> windows : win.c AJ> server : window.c trace.c protocol.def AJ> include/wine : server_protocol.h AJ> Log message: AJ> Added support for inter-process GetWindowLong on the window extra AJ> bytes. AJ> Patch: http://cvs.winehq.com/patch.py?id=10222 AJ> Old revision New revision Changes Path AJ> 1.226 1.227 +132 -111 wine/windows/win.c AJ> 1.25 1.26 +36 -4 wine/server/window.c AJ> 1.185 1.186 +7 -3 wine/server/trace.c AJ> 1.87 1.88 +6 -0 wine/server/protocol.def AJ> 1.88 1.89 +7 -1 AJ> wine/include/wine/server_protocol.h -- Best regards, Phil mailto:phil@newstar.rinet.ru

2 3

Core DLL's Status Section
by Tom 13 Dec '03

13 Dec '03

Hi, Here is my first draft anyone have any comments?, constructive criticism? You will see I have wineps, x11drv, winedos listed on this page now so ill remove those sections from the Core Status page. If everything looks good ill paste the three sections together and send Brian a copy for WWN inclusion. :) And while he is doing that ill add in the remaining doc links. and then it should be ready for wine-patches. I've also got a nice new list of todo's to add to that page as well. Happy Holidays, Tom

1 0

Re: gdi: AlphaBlend constants
by Alexandre Julliard 12 Dec '03

12 Dec '03

Kirill Smelkov <kirr(a)landau.phys.spbu.ru> writes: > +/* AlphaBlend flags */ > +#define AC_SRC_NO_PREMULT_ALPHA 0x01 > +#define AC_SRC_NO_ALPHA 0x02 > +#define AC_DST_NO_PREMULT_ALPHA 0x10 > +#define AC_DST_NO_ALPHA 0x20 Where do these come from? I don't see them in the SDK headers or on MSDN, there's only an AC_SRC_ALPHA. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: ntdll / kernel32: #38
by Dmitry Timoshkov 12 Dec '03

12 Dec '03

"Eric Pouech" <pouech-eric(a)wanadoo.fr> wrote: > +HANDLE WINAPI OpenConsoleW(LPCWSTR name, DWORD access, LPSECURITY_ATTRIBUTES sa, > + DWORD creation) > +{ > + static const WCHAR coninW[] = {'C','O','N','I','N','$',0}; > + static const WCHAR conoutW[] = {'C','O','N','O','U','T','$',0}; > + BOOL output; > + HANDLE ret; > + > + if (strcmpW(coninW, name) == 0) > + output = FALSE; > + else if (strcmpW(conoutW, name) == 0) > + output = TRUE; While you are moving the code around then you are probably reviewing it as well? So, the question is: shouldn't the above comparisons be case insensitive? -- Dmitry.

2 1

Re: menu: Fix for menu tracking problem version 2
by Alexandre Julliard 12 Dec '03

12 Dec '03

Andrew de Quincey <adq_dvb(a)lidskialf.net> writes: > I wrote a program in windows which had owner drawn menu items. Whenever I > received the WM_DRAWITEM message: > > 1) I called GetCapture(), and compared it with the hwnd of main window > containing the menu. It pops up a message box if they are different. > 2) I then called SetCapture() with the HWND of the menu item itself. > > This approximately simulates what IDA is doing. > > The message box never popped up. This shows that even though the capture was > changed in one WM_DRAWITEM, windows had reset the capture to the window > containing the menu by the time of the next one. I also checked the messages > _were_ being sent using Spy++ (in case of a programming error). That's a good start, but it's not enough to know what Windows is really doing. You should also check the capture window right after you call SetCapture; and you should use GetGUIThreadInfo and print out all the details, especially the GUI_INMENUMODE flag. My suspicion is that the capture is not allowed to change at all in menu mode. -- Alexandre Julliard julliard(a)winehq.com

2 5

Problems with transparent windows
by Juan Antonio Boscá Lloret 12 Dec '03

12 Dec '03

Hello, I've found a probable bug in Wine when running win32 applications. Wine does not repaint windows areas that are hidden by another window over them (I think this is a behaviour by design). This behaviour is not correct when the upper window is transparent (WS_EX_TRANSPARENT style). Is it a bug? Thank you. --------------------------------------------------------------- Juan Antonio Boscá Lloret Departamento Programación CAE, S.A. jabosca(a)edicurs.com ---------------------------------------------------------------

2 1

Re: wine/dlls/kernel pthread.c
by Rein Klazes 12 Dec '03

12 Dec '03

On Fri, 12 Dec 2003 00:19:25 -0600, you wrote: > Log message: > Return an error in wine_pthread_mutex_unlock if we don't own the > critical section, this should avoid trouble caused by a locking bug > inside Xlib. Good, the locking problem that I reported seems to be fixed by this. Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

Re: unicode & wine internals
by Mike Hearn 12 Dec '03

12 Dec '03

No patch? On Thu, 2003-12-11 at 20:14, Eric Pouech wrote: > wine_get_unix_file_name is now a unicode function > A+

1 0

Re: shlexec: Fixes for buffer overrun problems
by Alexandre Julliard 12 Dec '03

12 Dec '03

Andrew de Quincey <adq_dvb(a)lidskialf.net> writes: > Hi, this is a cleanup of shell32/shlexec.c to remove potential buffer > overruns. I've also tried to make parts of the code a little easier to > follow, without affecting the functionality. It's a very inefficient mechanism, you are reallocating the same string over and over to append sometimes only a single char. The right way to avoid overflows is to compute the length of the full string first and then allocate all the needed space at once. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Janitorial: Get rid of W->A calls for shlexec (2/2)
by Alexandre Julliard 12 Dec '03

12 Dec '03

Marcelo Duarte <wine-devel(a)bol.com.br> writes: > Hi, > > Changelog: > Marcelo Duarte <wine-devel(a)bol.com.br> > -Janitorial: Get rid of W->A calls for shlexec > -Implementation of FindExecutableW > > Coments: > After you aplying my patch 1/2 and made corrections using sizeof, I see the > problems in the patch 2/2 and I do the corrections, and now, I think that all > is correct. No, there are still many places where the sizes are wrong. Every time you change a buffer from char[] to WCHAR[] you have to fix uses of sizeof on that buffer to count characters properly. Also there are still HeapAlloc calls that are done in bytes instead of WCHARs. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars
by Dimitrie O. Paun 12 Dec '03

12 Dec '03

On December 11, 2003 04:32 pm, Andrew de Quincey wrote: > I have concluded that the WM_ERASEBKGND is sent from within WM_PAINT when > the toolbar detects that the mouse has moved off a button and wants to > de-highlight it. Well, it probably does a InvalidateRect() call. You can try an ugly InvaldateRect(hwnd, 0, TRUE); but this will probably result in flicker. For added bonus, figure out the button's rect, and pass it in: /* figure out stuff in rect */ InvalidateRect(hwnd, &rect, TRUE); BTW, what are the parameters of WM_ERASEBKGND? -- Dimi.

2 4

bugs in d3d8.dll and msvcrt.dll
by Ivan Leo Murray-Smith 11 Dec '03

11 Dec '03

There are 2 bugs that prevent mafia (Trial version) from working correctly, they are in d3d8.dll and msvcrt.dll, updated backtraces generated with wine-20031212 are at http://bugs.winehq.com/show_bug.cgi?id=1670 the demo is at http://www.mafia-game.com in the downloads section.

1 0

Deadlock?
by Shachar Shemesh 11 Dec '03

11 Dec '03

When trying to run Microsoft Digital Image Pro, I occasionally get problems when loading it. The splash screen comes up, and then it hangs. This problem only happens occasionally. I have not, to date, managed to reproduce it with relay turned on. This is what I do get on screen: err:module:import_dll No implementation for USER32.dll.GetScrollBarInfo imported from L"C:\\Program Files\\Microsoft Picture It! 9\\piutil.dll", setting to 0xdeadbeef err:font:ReadFontDir Can't open directory "/win/windows/fonts" err:imagelist:ImageList_LoadImageW Error loading image! err:toolbar:ToolbarWindowProc unknown msg 204e wp=000000ca lp=4080deec err:toolbar:ToolbarWindowProc unknown msg 204e wp=000000ca lp=4080ea54 err:toolbar:ToolbarWindowProc unknown msg 2210 wp=00ca0001 lp=00010051 err:toolbar:ToolbarWindowProc unknown msg 204e wp=40c757d8 lp=4080eaa4 err:toolbar:ToolbarWindowProc unknown msg 2210 wp=57d80001 lp=00010053 fixme:toolbar:TOOLBAR_SetPadding stub - nothing done with values, cx=7, cy=9 fixme:imm:ImmAssociateContext (0x10056, (nil)): semi-stub fixme:imm:ImmAssociateContext (0x10058, (nil)): semi-stub fixme:imm:ImmAssociateContext (0x1005a, (nil)): semi-stub fixme:hook:NotifyWinEvent (32784,0x10056,-4,0)-stub! fixme:hook:NotifyWinEvent (32784,0x1005a,-4,0)-stub! fixme:hook:NotifyWinEvent (32782,0x10058,-4,0)-stub! err:toolbar:ToolbarWindowProc unknown msg 204e wp=000000ca lp=4080e61c fixme:imm:ImmAssociateContext (0x1009d, (nil)): semi-stub err:ntdll:RtlpWaitForCriticalSection section 0x4020fc60 "loader.c: loader_section" wait timed out in thread 0009, blocked by 000c, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7c38b208 "?" wait timed out in thread 000c, blocked by 0009, retrying (60 sec) -- Shachar Shemesh Open Source integration & consulting Home page & resume - http://www.shemesh.biz/

2 4

winefile can't launch any apps!
by Dan Kegel 11 Dec '03

11 Dec '03

Trying to launch any app, e.g. wine's notepad, by double-clicking on the .exe in 'winefile' crashes wine, like this: 0x42079c30 (NTDLL.DLL.strcpy+0x20): movzbl 0x0(%edx),%eax Wine-dbg>bt Backtrace: =>0 0x42079c30 (NTDLL.DLL.strcpy+0x20) (ebp=4072ed8c) 1 0x40778fd4 (SHELL32.DLL.FindExecutableW+0x7ec in SHELL32.DLL) (ebp=4072f840) 2 0x40779103 (SHELL32.DLL.ShellExecuteExA+0x1f in SHELL32.DLL) (ebp=4072f854) 3 0x40620515 (winefile.exe.EntryPoint+0x4515 in winefile.exe) (ebp=4072f9c4) 4 0x40620692 (winefile.exe.EntryPoint+0x4692 in winefile.exe) (ebp=4072f9f0) 5 0x40620a8c (winefile.exe.EntryPoint+0x4a8c in winefile.exe) (ebp=4072faa4) 6 0x408d0703 (USER32.DLL.EndDeferWindowPos+0x31b in USER32.DLL) (ebp=4072fac8) 7 0x408d0761 (USER32.DLL.EndDeferWindowPos+0x379 in USER32.DLL) (ebp=4072faf4) 8 0x408d4ff2 (USER32.DLL.EndDeferWindowPos+0x4c0a in USER32.DLL) (ebp=4072fb1c) 9 0x408d5645 (USER32.DLL.CallWindowProcW+0xf9 in USER32.DLL) (ebp=4072fb50) 10 0x408e50ab (USER32.DLL.IsCharAlphaW+0x2d57 in USER32.DLL) (ebp=4072fbac) 11 0x408e5e2d (USER32.DLL.SendMessageTimeoutW+0x135 in USER32.DLL) (ebp=4072fc10) 12 0x408e604d (USER32.DLL.SendMessageW+0x31 in USER32.DLL) (ebp=4072fc3c) 13 0x40895f32 (USER32.DLL.EditWndProc+0xaff6 in USER32.DLL) (ebp=4072fcd4) 14 0x40897359 (USER32.DLL.EditWndProc+0xc41d in USER32.DLL) (ebp=4072fcf8) 15 0x408d0703 (USER32.DLL.EndDeferWindowPos+0x31b in USER32.DLL) (ebp=4072fd1c) 16 0x408d0761 (USER32.DLL.EndDeferWindowPos+0x379 in USER32.DLL) (ebp=4072fd48) 17 0x408d5539 (USER32.DLL.CallWindowProcA+0xf9 in USER32.DLL) (ebp=4072fd7c) 18 0x40620d99 (winefile.exe.EntryPoint+0x4d99 in winefile.exe) (ebp=4072fda4) 19 0x408d0703 (USER32.DLL.EndDeferWindowPos+0x31b in USER32.DLL) (ebp=4072fdc8) 20 0x408d0761 (USER32.DLL.EndDeferWindowPos+0x379 in USER32.DLL) (ebp=4072fdf4) 21 0x408d5539 (USER32.DLL.CallWindowProcA+0xf9 in USER32.DLL) (ebp=4072fe28) 22 0x408b94a2 (USER32.DLL.DispatchMessageA+0x96 in USER32.DLL) (ebp=4072fe6c) 23 0x406214b9 (winefile.exe.EntryPoint+0x54b9 in winefile.exe) (ebp=4072fea4) 24 0x406214f1 (winefile.exe.EntryPoint+0x54f1 in winefile.exe) (ebp=4072febc) 25 0x4061c0a5 (winefile.exe.EntryPoint+0xa5 in winefile.exe) (ebp=4072ff2c) 26 0x4036b132 (KERNEL32.DLL.SetThreadExecutionState+0x16d6 in KERNEL32.DLL) (ebp=4072fff4) 27 0x4002df1d (_end+0x402c0f1) (ebp=00000000) This is on an SMP RH9 system running wine 20031118 compiled from source. - Dan

5 7

Low level dlls
by carlini＠dcc.ufmg.br 11 Dec '03

11 Dec '03

Hi, what is a low level dlls in M$ windows nt? (low level dll == ddl whit access win device driver and/or hardware recourses.) They can natively be loaded? tanks Ricardo ================================ = Ricardo Carlini Sperandio = = 4! perido = = Ciencia da Computacao - UFMG = = Slack User / FreeBSD user = ================================

1 0

Re: I made a wish, wrote a letter to Santa...
by Subhobroto Sinha 11 Dec '03

11 Dec '03

Actually Shachar, I was thinking along these lines: (1) Programs in WINE are making direct calls to internal functions (which are not really Win32, but made by us using which we can use te Win32 functions as wrappers...) and that's just possible because C functions are globally callable (the only thing you really need to keep the compiler happy is the function prototype) And that's a bad thing, because while developing tools we should really forget that we are coding fo WINE, and just write using Win32 SDK APIs... Encapsulating internal WINE functions as private, and exposing them using the correct APIs would be better engineering... Just to force lazy people like us to write protable code (you see, calling internal WINE functions are a lot easier than calling the corresponding wrappers.. (2) A few things like DirectX and COM are so very closely tied with C++ objects that implementing them in C seems an overkill to me. But after knowing they are done, I have nothing against that .... (3) C++ is VERY reusable. WINE has a lot of potential for reusablity , but by doing C where it was not needed, we are unnecessarily having to spend time finding out pieces here and there in the huge code structure. WINE is recieving more interest than ever, and we can only encourage people to join us by giving something they too can reuse, and people who really work for WINE are those types who start writing their own code if they find that tracing down a function and it's references will take more time. For example, whatever I have gone through (which is VERY little BTW..), I still feel that implementing many tools like winemenubuilder or winefile would have been better in C++ Infact, I intent to do some experimentation after Xmas (I am having my semester exams now, so ..) Hope what I said reaches you all ;) Season's greetings Subhobroto <snip> On Thu, 11 Dec 2003 Shachar Shemesh wrote : >I'm sorry, it has been YEARS since I wrote anything OLE related (my very first Windows program was an OLE server, hand coded, that did a shell extension. That was my only interaction with OLE). As such, I will not presume to decide whether that statement is correct or not. </snip snip, snip..>

2 1

Re: Adding support for a USB device
by Rolf Kalbermatter 11 Dec '03

11 Dec '03

Message: 2 Date: Tue, 9 Dec 2003 14:56:16 -0800 Subject: Adding support for a USB device From: Dan Timis <timis(a)museresearch.com> To: wine-devel(a)winehq.org Hi, >I need help with supporting a particular USB device under wine. I have >to start by saying that although I am an experienced C/C++ programmer >with some Linux experience, I have almost no Windows or wine experience. > >The Windows code for which I need to provide support uses CreateFile() >to get a handle to the device. The name of the device is something >like "\\.\MyDevice0" "\\.\MyDevice1" and so on. Then, the code uses >DeviceIoControl() to read and write from/to the device. The >requirement is not to change the windows code. > >I looked through the wine code and I found this in device.c: > >static const struct VxDInfo VxDList[] > >I could add another entry into the table and write a deviceio handler >(BOOL (*deviceio)(DWORD, LPVOID, DWORD, LPVOID, DWORD, LPDWORD, >LPOVERLAPPED);). I wrote some test code in Linux using libusb reading >and writing to the device so I know what to do inside the deviceio >handler. > >Is this the right approach? If so, what do I need to do to get >CreateFile to return the right handle? I think it really depends on the type of device and the possibility to rewrite the device driver or not. \\.\MyDevice0 is just a device driver name which at some point is registered in the registry with the appropriate VXD, SYS, or WDM driver file. If you know the exact DeviceIOControls called into that driver with its parameters and all, you could rewrite the VXD, SYS or WDM driver to call directly the appropriate Unix device driver calls and maybe compile it as a Winelib driver. With a bit hacking in the CreateFile function it should be possible to call such a driver over DeviceIOControl or you could add the according code to the above mentioned VXDList. >Or should I write an external driver that gets loaded by wine? If so, >how would I do that? What are the chances that the Windows driver for >this device would just work with wine? If you don't know these details and want to use the original device driver you are probably out of luck. The current CreateFile implementation is not really up to the task of loading an external native device driver and invoke it over the DeviceIOControl (which could probably be remedied with a little hacking at this point) and what is much more problematic there is little or no support for a lot of the Windows kernel services most device driver usually expect to be able to call. When they are not able to link to one or more of those functions at load time, loading of the device driver will simply fail in Wine, as it does with normal DLL files under all Win32 implementations, too. Rolf Kalbermatter

3 3

Crash early in running msiexec.exe
by Dan Kegel 11 Dec '03

11 Dec '03

This is on RH9 SMP with wine-20031118. Trying to run the MS SFU 3.0 (hey, I got it for $5 from that special offer they ran on slashdot a couple weeks ago...) setup.exe from the commandline yields the crash: Unhandled exception: page fault on read access to 0x0049002e in 32-bit code (0x400b73fd). In 32-bit mode. 0x400b73fd (NTDLL.DLL.RtlInitAnsiString+0x19 in NTDLL.DLL): repne scasb %es:(%edi) Wine-dbg>bt Backtrace: =>0 0x400b73fd (NTDLL.DLL.RtlInitAnsiString+0x19 in NTDLL.DLL) (ebp=4071e8f8) 1 0x400b7628 (NTDLL.DLL.RtlCreateUnicodeStringFromAsciiz+0x20 in NTDLL.DLL) (ebp=4071e918) 2 0x407bf5ad (USER32.DLL.MessageBoxIndirectA+0x119 in USER32.DLL) (ebp=4071e984) 3 0x407bf422 (USER32.DLL.MessageBoxExA+0x5e in USER32.DLL) (ebp=4071e9c4) 4 0x407bf38f (USER32.DLL.MessageBoxA+0x23 in USER32.DLL) (ebp=4071e9e4) 5 0x004010f7 (msiinst.exe.EntryPoint+0xf7 in msiinst.exe) (ebp=00000001) Seems a shame to bail out so early. Any suggestions for which --debugmsg channel to turn on? Best I could find was +process,+ntdll,+string which output the following right before the crash: ... trace:string:wvsnprintfA "Y:\\instmsi.exe /D:E:\\IXP001.TMP\\" trace:process:CreateProcessW app (null) cmdline L"E:\\IXP001.TMP\\msiinst.exe /i instmsi.msi REBOOT=REALLYSUPRESS /q" trace:process:find_exe_file looking for L"E:\\IXP001.TMP\\msiinst.exe" trace:process:find_exe_file Trying native exe L"E:\\IXP001.TMP\\msiinst.exe" trace:ntdll:NtReadFile (0x34,(nil),(nil),(nil),0x4051dca0,0x4051dd44,0x00000040,(nil),(nil)),partial stub! trace:ntdll:NtReadFile (0x34,(nil),(nil),(nil),0x4051dca0,0x4051dcdc,0x00000004,(nil),(nil)),partial stub! trace:ntdll:NtReadFile (0x34,(nil),(nil),(nil),0x4051dca0,0x4051dd24,0x00000014,(nil),(nil)),partial stub! trace:process:CreateProcessW starting L"E:\\IXP001.TMP\\msiinst.exe" as Win32 binary trace:process:__wine_kernel_init starting process name=L"E:\\IXP001.TMP\\msiinst.exe" file=0x4 argv[0]="E:\\IXP001.TMP\\msiinst.exe" trace:ntdll:NtReadFile (0x4,(nil),(nil),(nil),0xbfffd438,0xbfffd4dc,0x00000040,(nil),(nil)),partial stub! trace:ntdll:NtReadFile (0x4,(nil),(nil),(nil),0xbfffd438,0xbfffd474,0x00000004,(nil),(nil)),partial stub! trace:ntdll:NtReadFile (0x4,(nil),(nil),(nil),0xbfffd438,0xbfffd4bc,0x00000014,(nil),(nil)),partial stub! trace:process:__wine_kernel_init starting Win32 binary L"E:\\IXP001.TMP\\msiinst.exe" - Dan

2 4

Re: PATCH for Bugs 1844 and 1845
by Andreas Rosenberg 11 Dec '03

11 Dec '03

I sent two patches about a week ago. The first one: "Bug 1844: Point Size in DLG_TEMPLATE may be negative" made it into the CVS (I browsed with: http://cvs.winehq.com/cvsweb) The second "Bug 1845: Return values of CharUpperA and CharLowerA" did not. Any reasons to reject this patch? I also wrote an conformance test for this problem. Did the case mentioned on the WINE web site happen? "Rejected patches might receive a note in the wine-devel mailing list, and accidentally ignored patches will disappear into a silent, featureless void. Please resubmit if this happens to your patch." -- Andy

2 1

Re: Patch for bug 1848 - TrackPopupMenu returns wrong result, when menu is canceled
by Dimitrie O. Paun 11 Dec '03

11 Dec '03

On December 11, 2003 01:20 pm, Andreas Rosenberg wrote: > + if (!(menu = MENU_GetMenu( hmenu ))) > + { > + SetLastError(ERROR_INVALID_MENU_HANDLE); /* - added by A.Rosenberg > 2003.12.11 */ + return FALSE; > + } No need to add the 'added by ...' comment, it uglifies the code needlessly. That info is available in the log. Also, please try to follow the style of the file, nowhere do we use this bracketing style. -- Dimi.

1 0

multi-level subdirs under dlls/
by Dimitrie O. Paun 11 Dec '03

11 Dec '03

Hi folks, I know people are concerned right now with more important matters, but given that (1) we're cleaning up the tree, and (2) we're getting close to 0.9, I figured it maybe time to bring this up. Namely, under dlls/ we have by and large a flat structure, with the exception of a few 'special' cases (there's always have to be special cases :/). I find this rather upsetting, for the following reasons: -- the organization is confusing since it implies some sort of dependency that's not there (they are all .dlls) -- it makes grepping so much more difficult. Instead of the simple: grep BLAH dlls/*/*.[ch] we need to resort to find, etc. -- it makes scripts in general needlessly complicated -- it hides those parts in the depth of tree -- it is inconsistent with the rest of our DLLs Now, I know that this is mainly historical, but why not fix it? Yeah, we're going to loose a bit of CVS history, but not quite, because the move can mark that so in the log. So we're only making 'cvs log' on a few files a bit more complicated, but we're simplifying every day operation by so much. I think it's a clear win. Here is the list of the offending DLLs: ddraw/d3ddevice ddraw/dclipper ddraw/ddraw ddraw/direct3d ddraw/dpalette ddraw/dsurface dinput/joystick dinput/keyboard dinput/mouse gdi/enhmfdrv gdi/mfdrv msacm/imaadp32 msacm/msg711 msacm/msadp32 msacm/winemp3 msvideo/msrle32 user/dde wineps/data winmm/joystick winmm/mcianim winmm/mciavi winmm/mcicda winmm/mciseq winmm/mciwave winmm/midimap winmm/wavemap winmm/wineoss winmm/winearts winmm/winealsa winmm/winenas winmm/wineaudioio winmm/winejack Pretty please... -- Dimi.

3 3

Partial success: RoughDraft 2.11
by Dan Kegel 11 Dec '03

11 Dec '03

On a whim, I tried out RoughDraft 2.11 under wine-20031118 this morning. It installed and ran with some anomolies (e.g. the installer's EULA doesn't display at all!, .doc import works really poorly, a few pixels misplaced here and there, can't invoke web browser to display help), but it might be good enough for some users. It's a free download at http://www.rsalsbury.co.uk/rd.htm and I recommend it as a test app. His FAQ says no Linux or Mac port is planned, so there must be interest out there, and he'd probably be tickled pink if Wine improved to the point where it ran his app well enough for aunt Tilly to use. Sources not available but the author seems like a good guy, and would probably be willing to work with us if we really needed it (especially if we fixed a few things first, like that EULA display problem). - Dan

3 2

I made a wish, wrote a letter to Santa...
by Subhobroto Sinha 11 Dec '03

11 Dec '03

With XMas nearing, I thought it was time I made my yearly wish to Santa - that he would let his elves use C++ in WINE. (Just in case, you did not know Santa's email address, it's 'julliard[at]winehq.org', and you can make your wishes at 'wine-devel[at]winehq.com'..) You see, Santa was always so good - he answered people's prayers and got together his obedient elves to run Win32 on Non-Windows platforms! However, soon many of his elves found out that technologies like MFC, WTL, ATL, COM, DCOM, COM+ and other MS bloops were getting too complex to be implemented using plain C, and thus developments in those areas were soon in limbo. But that could be solved using yet another language called C++ - if only Santa would let it be. Oh please Santa ! Let us adultrate WINE with C++, please. It's not that we will rewrite everything in C++ once we get the green signal - things like the loader, scheduler, and most of the Win32 SDK does not need C++ at all, but what about MFC, COM, OLE ? Not that I expect to compile native MFC source using WineLib, but at least we can write the runtimes so that native MFC apps can atleast run under WINE ? DirectX oozes of classes,inheritance,abstaction and everything C++ as does OLE, COM and already our implementations have structure object pointers running wild, whereas encapsulation would have done away with it ! As a simple explanation, we might take our 'This' hack wheras C++ would let have us use it as 'this' without even us worrying about it ! Also, there are many places in shell32, ole and shwlapi (I cannot comment on DirectX source as I do not have a graphics base at all ..) where initializing a few member variables from a constructor would have done away with some redundancy. Most of the time we are passing around multilevel pointers when a simple reference would have done: For example a call like Stream_LoadString( stm, unicode, &This->sString ); [To 'static HRESULT Stream_LoadString( IStream* stm, BOOL unicode,LPWSTR *pstr )'] can be made to a simple Stream_LoadString(sString); using C++ if we had the prototype rewritten to 'static HRESULT Stream_LoadString(LPWSTR& pstr )' and making it a member function of IStream (and thus the 'IStream* stm' and 'BOOL unicode' would be member variables..) We have code like that all over the place whenever COM etc comes into play and "That's Not A Good Thing(TM)" ! Please give us the green card - alternately, a new test branch may also be created just to see if C++ would work.All C++ based modfications would goto that tree. If that test branch works and delivers, it maybe merged into the main WINE tree, otherwise if it fails to deliver just remove it after a stipulated period ! If WINE stuck to C only because some platforms do not support C++, then will Win32 apps run on such OS at all ? Things like SPARC do not need MS Apps at all (though SPARC has C++..) For a expert discussion on C++ please see http://www.research.att.com/~bs/blast.html Microsoft themselves use C++ : <quote> Microsoft: Literally everything at Microsoft is built using various flavors of Visual C++ - mostly 6.0 and 7.0 but we do have a few holdouts still using 5.0 :-( and some products like Windows XP use more recent builds of the compiler. The list would include major products like: Windows XP Windows NT (NT4 and 2000) Windows 9x (95, 98,

9 12

dlls/oleaut32/tests/vartype.c problems
by Gerald Pfeifer 11 Dec '03

11 Dec '03

The new file dlls/oleaut32/tests/vartype.c, add by the following commit revision 1.1 date: 2003/12/11 05:25:44; author: julliard; state: Exp; Jon Griffiths <jon_p_griffiths(a)yahoo.com> Test almost all of the low level variant functions adds a couple of warnings: vartype.c:4118: warning: integer constant is too large for "long" type vartype.c:4118: warning: integer constant is too large for "long" type vartype.c:4118: warning: integer constant is too large for "long" type vartype.c:4119: warning: integer constant is too large for "long" type vartype.c:4119: warning: integer constant is too large for "long" type vartype.c:4119: warning: integer constant is too large for "long" type The problem is, that in the use of EXPECTDEC(0,0,0,0x100000000), the constant is 0x100000000 is too large for both long and unsigned long. This could be addressed by writing it as 0x100000000ULL (unsigned long long), but in that case the uses in the EXPECTDEC macro seem wrong, as they cast the value to long and unsigned long, respectively. Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel