wine-devel

wine-devel@winehq.org

10 participants
84459 discussions

RE: TreeView & WM_NOTIFY
by Igor Grahek 05 Sep '03

05 Sep '03

It looks like comctl32.dll is seting up some hooks to forward messages to requested window because even if you use --dll comctl32=n the owner is set up to "GetAncestor( cs->hwndParent, GA_ROOT )" Same thing happends under Windows so it seems that everything is OK with windows/win.c I tried to figure out what is going on with hooks but I don't have much experience with windows hooks so I will appreciate any help. Thanks, Igor > -----Original Message----- > From: Igor Grahek [mailto:igorg@cadlink.com] > Sent: September 5, 2003 11:29 AM > To: 'wine-devel(a)winehq.org' > Subject: RE: TreeView & WM_NOTIFY > > > Here is an example in attachment (Visual C++ project) . > If you click on "tst" button it opens TreeView control with > WS_POPUP and Cview as parent (to process WM_NOTIFY messages) > With current code in windows/win.c owner is set to > "GetAncestor( cs->hwndParent, GA_ROOT )" and WM_NOTIFY goes > to wrong window. If I change code so that owner is > "WIN_GetFullHandle(cs->hwndParent)" then there is problem > with Z ordering (keeping popup window on top) but WM_NOTIFY > goes to Cview as it should. > > However if I use --dll comctl32=n and owner is set to > "GetAncestor( cs->hwndParent, GA_ROOT )" everything works OK > - popup is on top and CView receives WM_NOTIFY from it. > > I know I'm repeating myself but I'm not sure where I should > look for the problem: is it in dll/comctl32/treeview.c (as > --dll comctl32=n suggesting) or is it in windows/win.c and > dll/x11drv/* ? > > Igor > > > -----Original Message----- > > From: Igor Grahek [mailto:igorg@cadlink.com] > > Sent: September 4, 2003 1:50 PM > > To: 'Dimitrie O. Paun' > > Cc: 'wine-devel(a)winehq.org' > > Subject: RE: TreeView & WM_NOTIFY > > > > > > I think I found the source of my problem: > > ------------- > > Wine/windows/win.c ::CreateWindowEx > > > > if ((cs->style & (WS_CHILD|WS_POPUP)) == WS_CHILD) > > parent = WIN_GetFullHandle(cs->hwndParent); > > else > > owner = GetAncestor( cs->hwndParent, GA_ROOT ); > > -------------------------- > > Why owner is not set to "WIN_GetFullHandle(cs->hwndParent)" ? > > > > If I change this everything works OK except there is a > > problem with Z ordering (it is hiding popup window behind its > > owner when Managed=N) Is the source of problem somewhere in > > wine/dll/x11drv/winpos.c (I'm currently examining > > SWP_DoOwnedPopups function) and why it is working with --dll > > comctl32=n - no problems with Z order there?! > > > > BTW I'm working with 20030618 build. > > > > Igor > > > > > -----Original Message----- > > > From: Dimitrie O. Paun [mailto:dimi@intelliware.ca] > > > Sent: September 2, 2003 6:42 PM > > > To: Igor Grahek > > > Cc: wine-devel(a)winehq.org > > > Subject: Re: TreeView & WM_NOTIFY > > > > > > > > > On Tue, 2 Sep 2003, Igor Grahek wrote: > > > > > > > My problem is very similar to bug 1227 > > > > (http://bugs.winehq.org/show_bug.cgi?id=1227) > > > > Treeview in application is sending WM_NOTIFY on double > > > click (NM_DBLCLK) > > > > to the wrong > > > > Window handle. GetParent() function returns handle to the > > > root window > > > > and root window is not forwarding/broadcasting that message > > > and message > > > > is lost. Everything works fine under Windows > > > > or with --dll comctl32=n > > > > > > I'm afraid you'll need to debug this and post a lot more > > detail, maybe > > > a code fragment showing the undesirable behaviour. > > > > > > -- > > > Dimi. > > > > > > > > >

1 0

Help required regarding compilation of windows project in Linux via WineLib
by Anjan Sarkar 05 Sep '03

05 Sep '03

Hello, I am using wine for my personal interest and need your help regarding the following problem I have faced. I have following configuration, a) Red Had Linux 9.0 b) Wine (wine-20030813.tar.gz) is extracted in /ww/wine-20030813 c) It creates a directory /c for windows and /root/.wine d) All the bin files are at /usr/local/bin Wine runs fine in my machine. Now I try to complie windows project in Linux via WineLib. I have made the following things, copy all the .c, .h, .rc files from programs/winemine dir to programs/winemine2 then from winemine2 run the following commands, $ winemaker --lower-uppercase . $ ./configure --with-wine=/usr/local/wine It gives me the error, "checking for windef.h configure:error couldnot find Wine headers(windef.h) I have also copy the file from /usr/local/include/wine/windows to current directory. Still the problem exists. Kindly suggest me what I have to do? Again please excuse me for this silly question. Thanking you, Anjan Sarkar Need a new email address that people can remember Check out the new EudoraMail at http://www.eudoramail.com

4 3

Display detection bug
by hatky 05 Sep '03

05 Sep '03

Some games are failing at detecting a 3D card or sometimes the screen dept, have a look at bug : http://bugs.winehq.org/show_bug.cgi?id=1696 getting into another bugzila/testing prenzy, hatky. __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

5 6

Re: Get rid of W->A calls
by Rolf Kalbermatter 05 Sep '03

05 Sep '03

hatky(a)users.sourceforge.net wrote: > Ok, one last line: > > strcpy(((char*)lpwh) + sizeof(WINHELP), lpHelpFile); I'm also not sure about the context here and it seems a little strange but what you would want to do here is probably: strcpyW((LPWSTR)((char*)lpwh + sizeof(WINHELP)), lpHelpFile); Rolf Kalbermatter

1 0

Re: Get rid of W->A calls
by hatky 05 Sep '03

05 Sep '03

> Let us know if you need any help. Just to be sure I got it right, I moved the DirectDrawEnumerateExA stuff into DirectDrawEnumerateExW since there is nothing ascii or unicode specific in it I think it's ok on it's own now in DirectDrawEnumerateExA I have these variables: LPDDENUMCALLBACKEXA lpCallback pointer to a callback function, the DirectDrawEnumerateExW get a LPDDENUMCALLBACKEXW (not match a suprise I guess) so do I need to convert it? just cast it as (DirectDrawEnumerateExW)? something else? LPVOID lpContext Address of an application-defined context to be passed to the enumeration callback function each time that it is called when they called from W -> A they did: DirectDrawEnumerateProcData epd; epd.lpCallback = (LPVOID) lpCallback; epd.lpContext = lpContext; and sent in as: (LPVOID) &epd Should it just be sent as is? DWORD dwFlags I assume it should be passed as is, for some reason the opposite call sent 0 Hatky. __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

3 11

Re: [winecfg 5] Implement transactions support, remove some crack x11drv prefs, complete desktop sizing code
by Dimitrie O. Paun 05 Sep '03

05 Sep '03

On 5 Sep 2003, Mike Hearn wrote: > This patch will add some warnings, and yeah, the commenting out of lots > of code is ugly, but don't worry, it's all temporary until I've finished > bringing the code across from the old global config struct. At that > point it'll all be deleted in favour of the transaction system. Cool. I should put you up as a worker on this task... > The transactions system is very simple, at the moment the default is > instant apply, despite the presence of OK and Cancel buttons. That's a > bit misleading, but the PropertySheet() API doesn't seem to have any way > to express the need for "Close" and maybe "Revert" buttons. The UI > standard on free software desktops for instant apply dialogs is to have > just a Close dialog, with a Revert button in cases where the user might > not be able to undo the changes themselves. For the main window, just a > Close button is enough. Would it be OK to implement a Wine extension > here Alexandre? Maybe we should just commit on OK, but that will be inconsistent with Gnome. I guess that at some point we need some extensions, one for the edit control to work with selections would be nice :) > ChangeLog: > - Remove "PerfectGraphics", "Use XSHM extension", and "Use a private > colour map", people who know what these actually are can probably use > regedit (we'll need default reg entries, don't let me forget!) Yeah, we should create a table with all the options, and keep track of wich ones were review, default values, static/dynamic behaviour, etc. I said I'd do it, but I didn't get around to it yet... -- Dimi.

1 0

WIDL problems
by Rolf Kalbermatter 05 Sep '03

05 Sep '03

I'm trying to get a new shell object into Wine and seeing that most of the object definition stuff has recently been moved to IDL files I wondered if I could define the object in shobjidl.idl. However I seem to get some problems compiling shobjidl.idl with with widl. I tried ./tools/widl/widl -I ./include ./include/shobjidl.idl and get an error. To be sure it wasn't caused by my editing I made sure the entire include dir is an unmodified version of the CVS tree and tried it there and I still get the error ./include/shobjidl.idl:426: Error: method index mismatch in write_proxy What is the problem here? Should I just sent in the patch to shobjidl.idl and the header file gets generated automatically with some more capable tool? By the way I noticed also that IPersistFolder3 got probably overlooked when moving the definitions to idl files. Rolf Kalbermatter

2 1

RE: Get rid of W->A calls
by Robert Shearman 05 Sep '03

05 Sep '03

> -----Original Message----- > From: wine-devel-admin(a)winehq.org [mailto:wine-devel-admin@winehq.org]On > Behalf Of Dimitrie O. Paun > Sent: 05 September 2003 17:40 > To: hatky(a)users.sourceforge.net > Cc: wine-devel(a)winehq.org > Subject: Re: Get rid of W->A calls > > > why did they call them wcommand in WinHelpA and > > command in WinHelpW ?? (msdn calls them uCommand but > > the code uses wcommand...) > > I don't see why, it should be named the same in > both versions if it's encoding independent. I think the confusing thing is the 'w' prefix. In this case 'w' stands for WORD, i.e. a two-byte integer. Also, MSDN isn't clear as to whether it is encoding independent but I would assume so. > > -hDest = FindWindowA("MS_WINHELP", NULL); > > +hDest = FindWindowW("MS_WINHELP", NULL); > > You can't to that directly, as we don't support > Unicode literals. You need to do that by hand: > > WCHAR clsName[] = { 'M', 'S', '_', 'W', 'I', 'N', 'H', 'E', > 'L', 'P', 0 }; > hDest = FindWindowW(clsName, NULL); > This would be better: static const WCHAR clsName[]... It allows for better optimization by the compiler (assuming that the compiler can't work out that clsName will not be modified) and shows the purpose better to the next person who looks at it. Rob

1 0

Looking for guidance..
by Jon Brandenburg 05 Sep '03

05 Sep '03

Hi, I'm interested in doing some development/help for wine and was wondering in what way I could help out? I have a college level understanding of C/C++/Java, have done some professional programming in (ack, VB), am currently in the process of learning C#, but would really like to do some development in unix/linux and I figure this is a good way to get some experience. I'm willing to do whatever needs to be done, but I do have as I'm sure most of you have, other projects/assignments/obligations which I'm sure the rest of you have also. If you could give me a bit of direction on an area of the project that needs some attention and perhaps a little bit of hand holding to begin with I'd like to help out. Thanks! Jon

2 1

WineHQ
by Ivan Leo Murray-Smith 05 Sep '03

05 Sep '03

Hi list, A guy that lives in my town found me via the linux counter, and we would like to translate the wine web site to italian, I was thinking of something like microsoft, with a drop menu of languages, where one can choose the destination language. This guy is also a really good web designer, and I could give him a hand as I'm a native english speaker and I could answer any emails we may get on an italian users mailing list, can we do this? Would a flag be better than a drop menu? any ideas/sugestions welcome.

2 1

Re: Display detection bug
by hatky 05 Sep '03

05 Sep '03

> What about rather a coding / debugging frenzy ? I considered them both but they are very hard to do for me for a known reason, Documentation. I read them all + a lot of the mailing lists but still do not know where to start with all of this even in the debugging, getting the trace of a certain component is not that easy because there is no place listing them I need to guess if it's +reg or +registry for example, there are places where it's match harder (ex display stuff).... About coding it's even harder since I do not know a lot about linux and in programming for linux for a first, the list of tasks is updated very slowly and usually not very clear to outsiders, the Janitorial list that is suppose to be the easiest is not very clear about what to do and is full of junk already done, not updated very frequently and also has stuff that the gurus here are working months on them (like dll separation) so how does a Janitorial suppose to do that? Don't get me wrong, I am not trying to say anything bad about you or the project or the rest of the wonderful people working on it, but as I see it the reason others programmers do not join it or at least I don't is becouse you do not make this task easy at all, if anyone would want to turn this around and try to pass some of this knowledge I am willing to learn and document (I am not a writer and my primary language is not English...) just to get the view point of a new programmer (ok I HAVE been watching this project for about 4 years but did not get active as a programmer). Ya, this is not a constant signature, sincerely yours, Hatky. __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

4 3

Get rid of W->A calls
by hatky 05 Sep '03

05 Sep '03

Janitorial reporting ;-) In the Get rid of W->A calls task, Say I try dlls/ddraw/main.c: ddraw: DirectDrawEnumerateExW: illegal call to DirectDrawEnumerateExA The misbheaving function is : HRESULT WINAPI DirectDrawEnumerateExW( LPDDENUMCALLBACKEXW lpCallback, LPVOID lpContext, DWORD dwFlags) { DirectDrawEnumerateProcData epd; epd.lpCallback = (LPVOID) lpCallback; epd.lpContext = lpContext; return DirectDrawEnumerateExA(DirectDrawEnumerateExProcW, (LPVOID) &epd, 0); } What sould I do? 1. copy the entire DirectDrawEnumerateExA into it 2. create a 3rd function DirectDrawEnumerateEx that both of them will call 3. somthing else (you tell me) Hatky. __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

3 2

Case sensitive in wine
by Fabian Cenedese 05 Sep '03

05 Sep '03

Hi I just sent an email about a file that isn't found -> Current Working Dir. I don't know if my next problem is related to it, just mentioning it. I tried another app which needs dlls and again I had the error that the file was not found, this time from wine. But the dll sure was in the fake c:\windows\system32. Just as a wild guess I made a copy of this dll and changed the case to all upper case as was the name wine told me. And miraculously the dll was found. So it seems that even while doing "Windows work" wine sometimes behaves case sensitive. FYI: Linux is Suse 8.0, wine is 20030813 (which makes me wonder as I made clean/distclean the old one, cvs up wine, configure, make depend, make, make install... and I never had a wine-rpm) bye Fabi

2 2

Installshield GetDC/ReleaseDC regression?
by Robert Reif 05 Sep '03

05 Sep '03

Installshield for dx8.1 sdk with win98 set in config is giving this error: err:dc:DCE_FreeWindowDCE[0x10023] GetDC() without ReleaseDC! A trace is attached.

1 0

Re: commctrl.h cleanup
by Alexandre Julliard 05 Sep '03

05 Sep '03

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > I know, it would be nice to have an intelligent utility to > cleanup the headers, but by the looks of it, it has to be > rather smart. This is probably one of the more difficult > cleanups, and I did it all by hand, which gave me a chance > to cleanup/reorganize the includes a bit. Looks like you have been reorganizing a bit too much, config.h and wine/port.h should always be included before anything else. > All other (except > for winbase.h) are *a lot* simpler. People can do them by > hand quite easily. I'm not so sure. For instance prsht.h still includes windef.h, wingdi.h and winuser.h, and since it's included from commctrl.h in fact your patch didn't actually remove these. I think there will still be a lot of changes to make, and I'd really prefer to avoid having to fix the same C files again and again. -- Alexandre Julliard julliard(a)winehq.com

3 7

Re: [dcom 1.2] Implement dispatch variant marshalling
by Mike Hearn 04 Sep '03

04 Sep '03

On Thu, 2003-09-04 at 20:53, Dimitrie O. Paun wrote: > I'd prefer we don't have there -- they really clutter the code, > provide a bad example to follow, and provide little, if any, > benefit. What you can do is put some strategic TRACEs that would > help someone who knows the code to identify the problem. > But I wouldn't worry about memory allocation failures... Another possibility is to have a wine convenience macro, similar to the glib g_return_if_fail() macro, that works for instance: wine_return_if_fail_hr(CoDoSomethingCOMRelated()) which expands to { HRESULT hr = CoDoSomethingCOMRelated() if (hr != S_OK) { ERR("CoDoSomethingCOMRelated() failed, hr=%ld\n", hr); return hr; } or whatever..... could be convenient, but perhaps too much magic. I'll drop the ERRs then. thanks -mike

2 1

Re: [dcom 1.2] Implement dispatch variant marshalling
by Dimitrie O. Paun 04 Sep '03

04 Sep '03

On 4 Sep 2003, Mike Hearn wrote: > I removed the use of asserts to check the results, and replaced them > with ERRs. > + working_mem = GlobalAlloc(0, size); > + if (!working_mem) { > + ERR("failed to get a global alloc\n"); > + return oldpos; > + } I don't think this is such a good idea. If the API can fail, it should just fail. ERR should be used only to signal internal inconsistencies. Doing an ERR on very memory allocation / function call that can fail is not only useless, but harmful, as it bloats and clutters the code. The above should just be: working_mem = GlobalAlloc(0, size); if (!working_mem) return oldpos; -- Dimi.

1 0

TreeView & WM_NOTIFY
by Igor Grahek 04 Sep '03

04 Sep '03

Hi :) My problem is very similar to bug 1227 (http://bugs.winehq.org/show_bug.cgi?id=1227) Treeview in application is sending WM_NOTIFY on double click (NM_DBLCLK) to the wrong Window handle. GetParent() function returns handle to the root window and root window is not forwarding/broadcasting that message and message is lost. Everything works fine under Windows or with --dll comctl32=n Any suggestions? Igor

2 2

Re: winres.h cleanup
by jonwil＠tpg.com.au 04 Sep '03

04 Sep '03

I dont see the reason for this change... The real version of winres.h from microsoft includes winresrc.h

3 2

Bugzilla down?
by Dustin Navea 04 Sep '03

04 Sep '03

Hi guys, I just tried to access Bugzilla, and it isnt responding, checked with a ping and a traceroute but both gave me request timed out, although that could be because of a firewall, I just figured someone might want to know (jeremy).. ===== Dustin Navea Minor Contributor, http://www.winehq.com Bugzilla Janitor, http://bugs.winehq.com Network Admin, irc://irc.blynk.net (down) __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

2 1

Re: stdarg.h in winbase.h
by Alexandre Julliard 04 Sep '03

04 Sep '03

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > With this patch, we can get rid of the stdarg.h > include from winbase.h if it weren't for the > FormatMessage() functions: > > DWORD WINAPI FormatMessageA(DWORD,LPCVOID,DWORD,DWORD,LPSTR,DWORD,va_list*); > DWORD WINAPI FormatMessageW(DWORD,LPCVOID,DWORD,DWORD,LPWSTR,DWORD,va_list*); > > Alexandre, how do we handle this one? We have to include stdarg.h everywhere we include winbase.h, about 650 files at last count. That's why we need some kind of script... -- Alexandre Julliard julliard(a)winehq.com

4 6

Re: wineproc: a new wine utility
by Dimitrie O. Paun 04 Sep '03

04 Sep '03

On September 3, 2003 03:53 pm, Eric Pouech wrote: > any comment welcomed!! This is very nice (from the comments and the code)! I will compile it soon, but I was hoping Alexandre bits me to it and commits it, so I can be lazy and just to a 'cvs up' :) > (thanks to Dimi for his quick fixies on the listview control BTW) You are most welcome, thank you for spotting the problems! -- Dimi.

1 0

Re: [gethostbyname] Set appropriate error code
by Rein Klazes 03 Sep '03

03 Sep '03

On Wed, 3 Sep 2003 18:20:56 +0200, you wrote: > Changelog: > - Set appropriate error code for gethostbyname and WSAAsyncGetHostByName > - Restore NULL name/aq->host_name to NULL at the end of each function respectively > > Stephan > > aq->host_name = buf; > if( gethostname( buf, 100) == -1) { > - fail = WSAENOBUFS; /* appropriate ? */ > + fail = (errno == EINVAL) ? WSAEFAULT : wsaErrno(); Explanation why I arrived at WSAENOBUFS as appropriate value.. (Remember it is used as the error value for the windows code calling gethostbyname(), not gethostname();) - glibc documentation as I read it indicates that in this case the only way gethostname() may fail is an insufficient bufferlength. Clearly invalid name pointer or negative length do not apply. - WSAEFAULT means (by Microsoft): "The system detected an invalid pointer address in attempting to use a pointer argument in a call" At the vary least this will confuse somebody that does gethostbyname(NULL), thinking it is the null pointer that is causing this error. This is the one error code that I did not want to return, that is why I cannot use the wsaErrno functions. But perhaps you have found another cause where gethostname() will fail? > + if (name==buf) name=NULL; > return retval; name is an argument, passed by value. Destroyed as the function returns. No need to restore. Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

Various fixme's and error messages with Visual FoxPro 8
by Paul McNett 03 Sep '03

03 Sep '03

In case it may be interesting to any of the hackers here, here is a spattering of messages that get output when running Visual FoxPro 8. If this isn't of interest, please forgive the bandwidth. The NotifyWinEvent messages fill pages of output during a typical session. The keyboard: X11DRV_ToUnicode is actually a minor problem as the key combination of Shift+Tab gets eaten instead of being passed to VFP. I've tried looking at the keyboard code to see if I can fix this, but the code is way beyond my level of comprehension. This is using the latest tarball release (Wine20030813). err:win32:_EnterSysLevel (0x409ddfc0, level 2): Holding 0x40a95de0, level 3. Expect deadlock! fixme:hook:NotifyWinEvent (32773,0x10044,1,8)-stub! err:clipboard:X11DRV_CLIPBOARD_QueryAvailableData Failed to cache text/plain;charset=utf-8 property err:keyboard:X11DRV_ToUnicode Please report: no char for keysym FE20 (ISO_Left_Tab) : err:keyboard:X11DRV_ToUnicode (virtKey=9,scanCode=F,keycode=17,state=1) -- Paul McNett

1 0

Re: listview expert required (again)
by Dimitrie O. Paun 03 Sep '03

03 Sep '03

OK, Please give this a try -- it should fix it. Index: dlls/comctl32/listview.c =================================================================== RCS file: /var/cvs/wine/dlls/comctl32/listview.c,v retrieving revision 1.360 diff -u -r1.360 listview.c --- dlls/comctl32/listview.c 1 Sep 2003 23:55:33 -0000 1.360 +++ dlls/comctl32/listview.c 3 Sep 2003 15:32:36 -0000 @@ -5939,6 +5939,9 @@ if (nItem == -1) goto fail; infoPtr->nItemCount++; + /* shift indices first so they don't get tangled */ + LISTVIEW_ShiftIndices(infoPtr, nItem, 1); + /* set the item attributes */ if (lpLVItem->mask & (LVIF_GROUPID|LVIF_COLUMNS)) { @@ -5979,11 +5982,6 @@ } } - /* Add the subitem list to the items array. Do this last in case we go to - * fail during the above. - */ - LISTVIEW_ShiftIndices(infoPtr, nItem, 1); - /* send LVN_INSERTITEM notification */ ZeroMemory(&nmlv, sizeof(NMLISTVIEW)); nmlv.iItem = nItem; @@ -6008,6 +6006,7 @@ return nItem; undo: + LISTVIEW_ShiftIndices(infoPtr, nItem, -1); DPA_DeletePtr(infoPtr->hdpaItems, nItem); infoPtr->nItemCount--; fail: -- Dimi.

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel