wine-devel

wine-devel@winehq.org

9 participants
84458 discussions

MSI Installer trouble
by Davide Giannotti 26 Mar '03

26 Mar '03

There's nothing i can do to make some installers work. I always get the "The installshield engine (ikernel.exe) could not be installed" message. I tried to install the dcom98, and it unpacked the files in the windows\system dir, and that's ok, but i don't think there was much more. When i try to install the microsoft installer (InstMsi.exe) it seems working, and it gives me the "succesfull installed" popup windows too... but i know it didn't cause it unpacks and doesn't even ask me if i want to proceed, it just jumps... to the end of process. And when i try to install some progs like Dreamweaver MX, i get the darn message above. Any suggestion? Thank you all guys P.s: The "export LD_ASSUME_KERNEL=2.2.5" command seems to work (at least partially). i added the line in my winelauncher script and konqueror uses winelauncher to start my win apps. Shouldn't you check for glibc version and add that line as default in the winelauncher script? -- Davide Giannotti ITS Planet s.n.c davide.giannotti(a)itsplanet.com www.itsplanet.com

3 2

Re: Don't check stateMask in treeview
by Dimitrie O. Paun 26 Mar '03

26 Mar '03

On 25 Mar 2003, Mike Hearn wrote: > I tested in windows xp, and found that the treeview control ignores the > stateMask field when getting item data. This fixes a bug in the NSIS > installer as well. Cool -- since you have the test, can you please check if the same is true for the listview as well? -- Dimi.

3 2

WineHQ redesign - going live soon
by Jeremy Newman 26 Mar '03

26 Mar '03

OK, I believe the site is ready to go live now. If you want any changes this is your last change to get them in. I need anyone who is available to go through the site and look for bad links, bad grammar, and any HTML anomalies. http://lostwages.winehq.org/ I plan to get the site live at 4pm CST today. In the meantime I'm going to work on any requests. -- _ _ WebGeek/SysAdmin CodeWeavers -= http://www.codeweavers.com | \| |_____ __ ___ __ __ _ _ _ -= http://www.dracowulf.com | .` / -_) | | / ' \/ _` | ' \ -= mailto:jnewman@codeweavers.com |_|\_\___|\_/\_/|_|_|_\__,_|_||_| -= ICQ: 1711553 Yahoo: laxdragon

10 14

Middleware regression test suites, e.g. ACE
by Dan Kegel 26 Mar '03

26 Mar '03

The idea of using middleware test suites to test Wine has come up before, I'm sure, but while looking for real world uses of overlapped I/O to named pipes for my named pipe conformance test, I noticed a good candidate. ACE is a set of object-oriented wrappers around operating system primitives, See http://www.cs.wustl.edu/~schmidt/ACE.html I think it's cruft (hey, it's c++ :-), but in spite of that, it is the basis of a whole lot of software, some very, very good. Ace has a largish set of regression tests which, being tests of a fairly thin OS abstraction layer, would be an almost perfect match for Wine's needs. See http://cvs.doc.wustl.edu/ace-cvs.cgi/ACE_wrappers/tests/README?rev=4.25 for more info about their regression tests. Can someone with a beefy machine and time on their hands give this a shot under Wine? Presumably you'd build everything with msvc, then run the tests under Wine. Warning: ACE is huge, and will hurt your head if you're not prepared. Wear sunglasses or something :-) - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

4 15

WineHQ redesign - DONE
by Jeremy Newman 25 Mar '03

25 Mar '03

The hard parts are done. The site is live. Time to party like its 1999! Thanks to all those who helped me with this undertaking. The new site was months in the making with most of the hard work in the last few days. Dimi, when I see you, I owe you a beer. Alright, back to my real job. /me wonders if Jer notices how long I spent on this. :-) -- _ _ WebGeek/SysAdmin CodeWeavers -= http://www.codeweavers.com | \| |_____ __ ___ __ __ _ _ _ -= http://www.dracowulf.com | .` / -_) | | / ' \/ _` | ' \ -= mailto:jnewman@codeweavers.com |_|\_\___|\_/\_/|_|_|_\__,_|_||_| -= ICQ: 1711553 Yahoo: laxdragon

2 1

[ANN] Wine @ SourceForge
by Dimitrie O. Paun 25 Mar '03

25 Mar '03

Hi folks, Some of you probably know that we had a wine project at SourceForge for a long time, but not much was done with it. Recently, we decided to transform it into our official download site: http://sourceforge.net/project/showfiles.php?group_id=6241 It currently hosts source tarballs, support files, and binary packages for FreeBSD, RedHat, and Slackware. Check it out. We invite comments, criticism, and/or praise :). -- Dimi.

3 4

Wine Weekly news
by Tony Lambregts 25 Mar '03

25 Mar '03

It would be nice if the news page had a link to the latest WWN. I would prefer at the top of the page myself. The way it is I can only get there by reloading the home page. Also I think that it could be clearer the link back to the home page was the wine hq logo.. -- Tony Lambregts

1 0

Re: winehq/ include/config.php templates/en/suppor ...
by Dimitrie O. Paun 25 Mar '03

25 Mar '03

On Tue, 25 Mar 2003, Jeremy Newman wrote: > Log message: > updated the to do list, and the supported apps pages Nice. However, I think I'd rename the menu item from "Applicatation DB" to just "Applications", that DB is rather unsightly. It's under the "Support" heading, so it should be clear enough. -- Dimi.

1 0

Hard data about traffic on wine mailing lists
by Uwe Bonnes 25 Mar '03

25 Mar '03

Hallo, I have 870 messages in my wine-patches folder since Jan 1. This is about 10 messages a day. Wine-devel is 3020 messages, that's around 36 messages a day Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: REMOVE ME
by Shachar Shemesh 25 Mar '03

25 Mar '03

Javier López wrote: > Hello, please wanted that they removed me of his list of post office, > since he is something very disagreeable, arrive approximately 20 to me > at 30 daily e-mail and no longer I support it, my square is fulled. > Please Remove ME OF ITS LIST! Hi Javier, In order to be removed, please send an email to wine-patches-request(a)winehq.org with a subject of "unsubscribe", and follow the instructions from there. Everyone else - I think it's time to update the counters on the web site. They are horribly out of date. Wine has experienced a wonderful expansion over the past year, but this means that we can no longer claim that wine-devel is 25 msg/day (more like 35msg/day on my unofficial counting), nor wine-patches 8msg/day (more like 20msg/day). This growth is really impressive, but we really need to update the counters accordingly. Shachar P.S. I have been walking around with the feeling that wine is reaching it's growth flex point (where development suddenly accelerates) for quite some time. Comparing the numbers claimed on wine-patches to the real numbers shows over 100% of growth in the amounts of fixes people send in. This shows that we are finally heading torwards the so desired beta stage..... -- Shachar Shemesh Open Source integration consultant Home page & resume - http://www.shemesh.biz/

2 1

WineHQ redesign - TODO
by Jeremy Newman 24 Mar '03

24 Mar '03

Here's whats left to be done before I can take the site live. This is a call to action. Send me any new content or changes to existing content, you would like to see on the site. - These empty pages need content. Some of the content can be pulled off the old pages, and moved to these new pages. + HowTo + Troubleshooting + Developer Hints + Sending Patches + Resources - These pages need to be updated. Dimi, I think you did some of them. Are the ones I have the latest. + To Do Lists + Supported Applications List + FAQ - These non-PHP pages need to be updated to the new design (after the update) The downside is they will not use the themes support. I may just give them a generic simple look. + Search Results Pages + Documentation That's about it. Almost there! -- _ _ WebGeek/SysAdmin CodeWeavers -= http://www.codeweavers.com | \| |_____ __ ___ __ __ _ _ _ -= http://www.dracowulf.com | .` / -_) | | / ' \/ _` | ' \ -= mailto:jnewman@codeweavers.com |_|\_\___|\_/\_/|_|_|_\__,_|_||_| -= ICQ: 1711553 Yahoo: laxdragon

3 7

Re: Janitorial W->A cleanup objects/metafile.c dlls/gdi/mfdrv/init.c
by Huw D M Davies 24 Mar '03

24 Mar '03

On Sun, Mar 23, 2003 at 05:43:39PM -0700, Tony Lambregts wrote: > This one was required more that a mop and pail. In the end what I had to do > is convert MF_CreateMetaHeaderDisk to unicode. > > One burning question I have at this point is the relative merits of using > RtlCreateUnicodeStringFromAsciiz vs MultiByteToWideChar > > Change Log: convert MF_CreateMetaHeaderDisk to unicode and W->A clean up > > Files Changed: objects/metafile.c dlls/gdi/mfdrv/init.c > > -- > > Tony Lambregts > Index: objects/metafile.c > =================================================================== > RCS file: /home/wine/wine/objects/metafile.c,v > retrieving revision 1.57 > diff -u -r1.57 metafile.c > --- objects/metafile.c 27 Feb 2003 21:09:45 -0000 1.57 > +++ objects/metafile.c 24 Mar 2003 00:49:27 -0000 > @@ -54,6 +54,9 @@ > #include "global.h" > #include "wownt32.h" > #include "wine/debug.h" > +#include "file.h" > +#include "winternl.h" > +#include "wine/unicode.h" > > WINE_DEFAULT_DEBUG_CHANNEL(metafile); > > @@ -62,7 +65,7 @@ > { > DWORD dw1, dw2, dw3; > WORD w4; > - CHAR filename[0x100]; > + WCHAR filename[MAX_PATHNAME_LEN]; > } METAHEADERDISK; > #include "poppack.h" This will break compatibility with 16bit metafiles where the mf handle is a global memory handle to the above structure. See the comment at the top of the file (hint, that's why this structure has elements dw1,2,3) Now you could create a new struct for 32bit only use if you want... Huw. -- Huw Davies huw(a)codeweavers.com

2 1

[Fwd] [announce] QEMU x86 emulator version 0.1
by Lionel Ulmer 24 Mar '03

24 Mar '03

Hi all, People wanting to experiment running Wine and X86 programs on PPC could try to test this. Be warned that it's not very polished on PPC yet. This implements what was discussed here (being that to run Wine/X86 on PPC it's better to run all user space emulated). Lionel PS for mailing list moderators : Fabrice bcc'ed the wine mailing list Saturday but as the mail did not appear today, I am forwarding it, so you may reject his original mail if he still is in the moderator queue. ----- Forwarded message from Fabrice Bellard <fabrice.bellard(a)free.fr> ----- Date: Sun, 23 Mar 2003 21:46:47 +0100 From: Fabrice Bellard <fabrice.bellard(a)free.fr> Subject: [announce] QEMU x86 emulator version 0.1 To: undisclosed-recipients: ; Hi, The first release of the QEMU x86 emulator is available at http://bellard.org/qemu/. QEMU achieves a fast user space Linux x86 emulation on x86 and PowerPC Linux hosts by using dynamic translation. Its main goal is to be able to run the Wine project on non-x86 architectures. Fabrice. ----- End forwarded message ----- -- Lionel Ulmer - http://www.bbrox.org/

1 0

Re: WineHQ Idea
by Dimitrie O. Paun 24 Mar '03

24 Mar '03

On 20 Mar 2003, Jeremy Newman wrote: [I've Cc'ed wine-devel since I've just reposted the questions there] > On Thu, 2003-03-20 at 15:57, Dimitrie O. Paun wrote: > > I was looking at the main page of the new WineHQ, and I was thinking > > of the following changes: > > 1. The menu at the bottom of the main "About" box is mainly > > duplicating the the left-side menu. Let's get rid of it. > > In this case I think the duplication is good. From a newbie aspect, the > first place they will read is the text on the home page. And the extra > clarification helps. This is a good point, but I feel that the benefit is not worth the cost. It takes up a lot of space, and really the _same_ options are available on the _same_ page. What kind of newbie are we talking about that can read "News" in one place, but can't read the exact same word 2 inches to the right? We are light years clean / simpler navigation than the old site, lets not exagerate. > > 2. Move the theme selector somewhere else, like another box on > > on the left, below "Developemnt" > > Yeah, for this beta, its there for now, I think I will make a > "Preferences" link somewhere in the nav. That's cool. > > 3. In place of the "Change Theme" box, let's have an "Announcements" > > box (like the KDE/GNOME/etc pages) where we can place the > > latest and greatest things, such as Wine releases, News releases, > > interviews, etc. > > See, that would be duplication. We already have news. It's WWN. Adding > announcements that don't get updated as often as WWN seems lame. Leave > that to other news sites. I beg to differ. WWN is more like a magazine. It is wandeerful, and has a good purpose, but that it's not for announcement. People don't wait a month to read the latest news, they watch TV or read the newspaper. The WWN appears weekly (sometime lest often), and is concerned mainly with development topics). An Announcement section would be updated whenever something important (from a user standpoint) happens: -- A new Wine version is released -- A new WWN is released -- An important event happened in the community So the two differ in all aspects (WWN vs. Announcements) 1. Audience: Developers vs. Users 2. Update Strategy: Weekly vs. Real Time 3. Content Focus: Development Issues vs. Events And the proof is in the pudding: most major project sites have different sections for the two. See www.gnome.org, www.kde.org, www.gimp.org, etc. For better or worse, people _expect_ things organized in a certain way. Like the "File" menu to the left. Even if we think our idea are better, we should follow the Principle of Least Surprise in these matters, unless we can make a _strong_ case against it. In this instance, it seems to me it makes sense to follow the status quo. -- Dimi.

4 12

Another minor bug
by Steven Edwards 24 Mar '03

24 Mar '03

I dont have time to patch this right now but maybe someone else does. When building import libs on mingw because we have to link to libwine in winebuild for wine_get_cs winebuild cant find libwine.dll. $ make PATH="../libs/unicode:$PATH" ../tools/winebuild/winebuild -o advapi32/advapi32. spec.def --def advapi32/advapi32.spec make: *** [advapi32/advapi32.spec.def] Error 128 Thanks Steven

1 0

re: Wine and glibc 3.2.x
by Dan Kegel 24 Mar '03

24 Mar '03

davide.giannotti(a)itsplanet.com wrote: > Ok, i recently compiled and upgraded to glibc 3.2.1 and there's no way to make > wine work. There's thread related bug. > New Red Hat, Suse and Mandrake will be shipped with this new version of glibc, > so i think that's a serious bug. We were all quite concerned about it until somebody reported a workaround; see http://www.winehq.com/hypermail/wine-devel/2003/02/0260.html The workaround is to give the command export LD_ASSUME_KERNEL=2.2.5 before running Wine (and probably before running configure, too). (This is documented in each distro's beta release notes, e.g. http://distro.ibiblio.org/pub/Linux/distributions/redhat/beta/phoebe/en/os/… ) Have you tried this yet? What CPU and OS are you using? > Configure cannot even check that libc are reentrant, i'm not a glibc expert > but there's some error with _errno and _errno_location. > I tried to apply a patch i found in the patch mailing list, but it didn't work > either. > ( http://www.winehq.com/hypermail/wine-patches/2003/01/0338.html ) That patch was bogus, it is not the right fix. The right fix is for Wine to adapt to the new threading model in glibc2.3 (not 3.2, I think), which is far superior to the old one. See http://www.kegel.com/c10k.html#threads.nptl > So, consider that every linux distribution will be shipped with the new glibc, > and that there will be really a few windows programs that can work without > thread support.... well... i'd think about give priority to solve this one. The changes needed are deep. Alexandre has started on them, but given the workaround, it can probably wait a bit. See also http://www.winehq.com/hypermail/wine-devel/2003/02/0252.html http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=83254 http://redhat.ifsic.univ-rennes1.fr/_rawhide/glibc-devel-2.3.1-51.i386.html -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

4 12

nvidia crashes?
by Mike Hearn 24 Mar '03

24 Mar '03

Hi, Often when a program fails, I'll get a crash inside libGLcore (with the nvidia drivers), backtrace looks like: (gdb) bt #0 0x40e0a208 in __nvsym12888 () from /usr/lib/libGLcore.so.1 #1 0x00001a76 in ?? () #2 0x4202b162 in exit () from /lib/i686/libc.so.6 #3 0x400ab79f in ExitProcess () at ../../scheduler/process.c:1440 #4 0x0100279b in ?? () #5 0x400a95a6 in start_process () at ../../scheduler/process.c:566 #6 0x400ad8bd in call_on_thread_stack (func=0x400a936c) at ../../scheduler/sysdeps.c:107 so I think it's hooking into the exit chain. I'm not sure why it'd crash like this, I haven't touched my video configuration for a while, and everything else seems stable. Is there any way to stop wine from loading opengl related code? thanks -mike -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

2 1

Re: windres: serious bug
by Dimitrie O. Paun 24 Mar '03

24 Mar '03

On March 21, 2003 05:55 am, Nick Clifton wrote: > Just to be clear ... Dimitrie, please could you try Ian's patch and > provide us with feedback as to how well it works. This would not > violate copyright restrictions (provided that you do not post any > code), and since you are actually using this tool, you are the one > most like likey to be able to verify that the patch is working > properly. Well, certainly. To be honest, the situation is a bit more complicated. I haven't been doing any active work on the Mozilla port, my interest in the port is as a starting base for a port to Wine. This may sound odd, but for various reasons (of which just being cool is not least important), I'd like to compile the Win32 port of Mozilla under Wine in Linux. Needless to say, such ports are not trivial, but I set out to make them a lot simpler, so that we make it practical for people to port their Win32 app to Linux via Winelib. To that end I started created a MinGW-compatible build environment in Wine. Thus, porting to Wine will become a two step process: first port to MinGW, then port to Wine. It is easy to see that this approach is a lot more evolutionary, and the steps are simpler. Moreover, you have intermediate working code (the mingw port) which is also very important, not to mention that smaller number of things that change from under you in each step (in the mingw port, you only have to deal with the build tools changing, while the wine port, given that I can provide mingw-compatible tools in Wine, it's just the OS that changes). Ideally, if everything works according to the plan, the above process looks like so: A. Port MSVC/BCC app to MinGW 1. Create GNU Makefiles 2. Deal with difference between cl/bcc and gcc 3. Get working versions of the app under MinGW B. Port from MinGW to Wine 1. Copy source code to a Linux box, run dos2unix on it 2. Change #include directives from #include "some\dir\file.h" to #include "some/dir/file.h" 3. Change file/dir name capitalization to match the one on disk NOTE: Changed (2) & (3) are scriptable, and we already have a tool that takes care of them. Most importantly, they are portable between all ports so a common source code can be maintained. Needless to say, this is paramount, few people have the resources to maintain different sources. 4. Change the Makefile as follows: + ifndef WINE CC = gcc CXX = g++ WRC = windres + else + CC = winegcc + CXX = wineg++ + WRC = wrc + endif Again this change is portable between ports, so a common build system can be maintained. The winegcc/wineg++ tools already work, but they are not ready. They mainly lack -shared support for generating DLLs, but they already proved useful in porting a number of apps (http://24.103.33.114/wine/Winelib-Apps.html) or toolkits (http://www.dssd.ca/wine/Wine-Fun.html#wxwindows). This should give people a better idea why I think command line compatibility between tools is important. However, to get back to the topic of this message, I was interested in the Mozilla port to MinGW only as a starting point form my efforts toward a Winelib port. As such I haven't actually worked on it, so I don't have the environment handy to test the changes. I've posted the patch to the Mozilla bug, and hopefully someone will give it a try. If not, I'll test it, but it will take a little while to get everything up to speed. Another way is to post a test .rc file that was experiencing the problem before, would that be useful? -- Dimi.

2 4

Thunking?
by Mike Hearn 24 Mar '03

24 Mar '03

Hi, Does anybody know what could cause this error? err:thunk:_loadthunk (commctrl.dll, Cctl1632_ThunkData16, comctl32.dll): Unable to load 'commctrl.dll', error 2 I checked, I don't haev comctrl.dll anywhere. I'm trying to get IE6 to work on an "out-of-the-box" Wine install, ie trying to move to a completely WineHQ setup rather than the winehq/crossover setup I was using before. I was under the impression that thunking was only used for 32/16 bridging, and IE6 is a 32bit app, so I don't really understand why it's trying to load this library using LoadLibrary16... does anybody have some tips? thanks -mike -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

2 2

Error in CVS
by Vilppa Salt 24 Mar '03

24 Mar '03

When running ./configure with latest cvs Wine: <snip> config.status: creating dlls/ctl3d/Makefile config.status: creating dlls/d3d8/Makefile config.status: creating dlls/d3dim/Makefile config.status: creating dlls/d3dx8/Makefile config.status: creating dlls/dciman32/Makefile config.status: creating dlls/ddraw/Makefile config.status: creating dlls/devenum/Makefile config.status: creating dlls/dinput/Makefile config.status: creating dlls/dinput8/Makefile config.status: creating dlls/dmusic/Makefile config.status: error: cannot find input file: dlls/dmusic/Makefile.in --- Vilppa- Sunpoint.net ilmoittaa: Sunpoint.net tarjoaa kaikille rekisteröityneille käyttäjilleen kuukausimaksuttoman Internet -yhteyden (pvm). http://www.sunpoint.net/SunAds/click.htm?mode=footer&id=71&jump=http%3A%2F%…

3 2

Janitorial W->A dlls/gdi/printdrv.c (help!)
by Tony Lambregts 24 Mar '03

24 Mar '03

I have been banging my head against this one for a while and need some feedback about a problem I am having. I have attached the patch to convert StartDocA to call StartDocW instead of the other way around. This patch results with StartDocW looking as follows INT WINAPI StartDocW(HDC hdc, const DOCINFOW* doc) { INT ret = 0; DC *dc = DC_GetDCPtr( hdc ); TRACE("DocName = '%s' Output = '%s' Datatype = '%s'\n", debugstr_w(doc->lpszDocName), debugstr_w(doc->lpszOutput), debugstr_w(doc->lpszDatatype)); if(!dc) return SP_ERROR; if (dc->funcs->pStartDoc) ret = dc->funcs->pStartDoc( dc->physDev, doc ); GDI_ReleaseObj( hdc ); return ret; } The problem I am having is with this line. if (dc->funcs->pStartDoc) ret = dc->funcs->pStartDoc( dc->physDev, doc ); With my patch in place I get the following error printdrv.c: In function `StartDocW': printdrv.c:82: warning: passing arg 2 of pointer to function from incompatible pointer type so obviously dc->funcs->pStartDoc points to a function that expects DOCINFOA* as its second parameter but I am at a loss on what to do. I have tried to trace down where "DC_GetDCPtr( hdc )" gets this information but I just ended up confused. Please help! -- Tony Lambregts Index: printdrv.c =================================================================== RCS file: /home/wine/wine/dlls/gdi/printdrv.c,v retrieving revision 1.30 diff -u -u -r1.30 printdrv.c --- printdrv.c 22 Nov 2002 22:16:53 -0000 1.30 +++ printdrv.c 23 Mar 2003 20:36:11 -0000 @@ -48,6 +48,7 @@ #include "gdi.h" #include "heap.h" #include "file.h" +#include "winternl.h" WINE_DEFAULT_DEBUG_CHANNEL(print); @@ -58,7 +59,7 @@ /****************************************************************** - * StartDocA [GDI32.@] + * StartDocW [GDI32.@] * * StartDoc calls the STARTDOC Escape with the input data pointing to DocName * and the output data (which is used as a second input parameter).pointing at @@ -67,13 +68,14 @@ * * Note: we now do it the other way, with the STARTDOC Escape calling StartDoc. */ -INT WINAPI StartDocA(HDC hdc, const DOCINFOA* doc) +INT WINAPI StartDocW(HDC hdc, const DOCINFOW* doc) { INT ret = 0; DC *dc = DC_GetDCPtr( hdc ); TRACE("DocName = '%s' Output = '%s' Datatype = '%s'\n", - doc->lpszDocName, doc->lpszOutput, doc->lpszDatatype); + debugstr_w(doc->lpszDocName), debugstr_w(doc->lpszOutput), + debugstr_w(doc->lpszDatatype)); if(!dc) return SP_ERROR; @@ -83,32 +85,27 @@ } /************************************************************************* - * StartDocW [GDI32.@] + * StartDocA [GDI32.@] * */ -INT WINAPI StartDocW(HDC hdc, const DOCINFOW* doc) +INT WINAPI StartDocA(HDC hdc, const DOCINFOA* doc) { - DOCINFOA docA; - INT ret; - - docA.cbSize = doc->cbSize; - docA.lpszDocName = doc->lpszDocName ? - HEAP_strdupWtoA( GetProcessHeap(), 0, doc->lpszDocName ) : NULL; - docA.lpszOutput = doc->lpszOutput ? - HEAP_strdupWtoA( GetProcessHeap(), 0, doc->lpszOutput ) : NULL; - docA.lpszDatatype = doc->lpszDatatype ? - HEAP_strdupWtoA( GetProcessHeap(), 0, doc->lpszDatatype ) : NULL; - docA.fwType = doc->fwType; - - ret = StartDocA(hdc, &docA); - - if(docA.lpszDocName) - HeapFree( GetProcessHeap(), 0, (LPSTR)docA.lpszDocName ); - if(docA.lpszOutput) - HeapFree( GetProcessHeap(), 0, (LPSTR)docA.lpszOutput ); - if(docA.lpszDatatype) - HeapFree( GetProcessHeap(), 0, (LPSTR)docA.lpszDatatype ); - + DOCINFOW docW; + int ret; + UNICODE_STRING DocName, Output, Datatype; + + docW.cbSize = doc->cbSize; + RtlCreateUnicodeStringFromAsciiz(&DocName, doc->lpszDocName); + RtlCreateUnicodeStringFromAsciiz(&Output, doc->lpszOutput ); + RtlCreateUnicodeStringFromAsciiz(&Datatype, doc->lpszDatatype ); + docW.lpszDocName = DocName.Buffer; + docW.lpszOutput = Output.Buffer; + docW.lpszDatatype = Datatype.Buffer; + docW.fwType = doc->fwType; + ret = StartDocW(hdc, &docW); + RtlFreeUnicodeString(&DocName); + RtlFreeUnicodeString(&Output); + RtlFreeUnicodeString(&Datatype); return ret; }

2 3

Re: Janitorial W->A cleanup objects/metafile.c dlls/gdi/mfdrv/init.c
by Dmitry Timoshkov 24 Mar '03

24 Mar '03

"Tony Lambregts" <tony_lambregts(a)telusplanet.net> wrote: > This one was required more that a mop and pail. In the end what I had to do is > convert MF_CreateMetaHeaderDisk to unicode. > > One burning question I have at this point is the relative merits of using > RtlCreateUnicodeStringFromAsciiz vs MultiByteToWideChar MultiByteToWideChar uses Rtl* functions internally and using ntdll APIs directly should give a slightly better performance. RtlCreateUnicodeStringFromAsciiz also is supposed to hide the internals of the conversion and help to avoid bugs and typos. > @@ -62,7 +65,7 @@ > { > DWORD dw1, dw2, dw3; > WORD w4; > - CHAR filename[0x100]; > + WCHAR filename[MAX_PATHNAME_LEN]; Please do not increase the buffer size if there is no real need for it. MAX_PATHNAME_LEN = 1024. It's better though to replace 0x100 by MAX_PATH IMO. > } METAHEADERDISK; > #include "poppack.h" > > @@ -350,9 +353,9 @@ > ERR("Not a disk based metafile\n"); > return NULL; > } > - mhd = (METAHEADERDISK *)((char *)mh + sizeof(METAHEADER)); > + mhd = (METAHEADERDISK *)((WCHAR *)mh + sizeof(METAHEADER)); Wrong. > @@ -377,8 +380,8 @@ > sizeof(METAHEADER) + sizeof(METAHEADERDISK)); > mh->mtType = METAFILE_DISK; > size = HeapSize( GetProcessHeap(), 0, mh ); > - mhd = (METAHEADERDISK *)((char *)mh + sizeof(METAHEADER)); > - strcpy(mhd->filename, filename); > + mhd = (METAHEADERDISK *)((WCHAR *)mh + sizeof(METAHEADER)); Wrong again. -- Dmitry.

2 2

ImageList - my findings
by Vitaliy Margolen 24 Mar '03

24 Mar '03

For past few days I was trying to figure out what is the problem with corrupt bitmaps. Here is my findings: 1. _read_bitmap does is not work right. The for() loop where it's restructuring original bitmap from multi-row into single-row. 2. Windows creates DIBSection to keep original bitmap so it could be saved as is. This is not used that often. However development tools do use it. For example: Delphi. I have few questions before making any hacking: - Why do we use single row bitpams versus multi-row like native? - Why we not creating DIBSection? -- Best regards, Vitaliy Margolen

4 5

RE: Janitorial W->A cleanup objects/metafile.c dlls/gdi/mfdrv/init.c
by Rolf Kalbermatter 24 Mar '03

24 Mar '03

This is a multi-part message in MIME format. --------------030003030306020205040907 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit >This one was required more that a mop and pail. In the end what I had to do is >convert MF_CreateMetaHeaderDisk to unicode. > >One burning question I have at this point is the relative merits of using >RtlCreateUnicodeStringFromAsciiz vs MultiByteToWideChar Well, when using MultiByteToWideChar you usually format into a buffer allocated on the stack whereas RtlCreateUnicodeStringFromAsciiz seems to allocate a buffer on the heap which you later free. The first is somewhat faster as no memory management calls are caused, but as Alexandre has pointed out, the current Wine code is at places quite stack intense which over time could lead to serious problems if Wine is extended with even more functions allocating much more Unicode buffers on the stack. So the question is really one about a little performance gain vs. code which has moderate stack requirements. Personally I think it is ok to allocate once a Unicode buffer on the stack in the high level API to convert ANSI to Unicode, provided the code path further down doesn't go back and forth between ANSI and Unicode conversions. But in general we should probably try in the future to get those buffers more often allocated dynamically for two reasons: 1) Just as a single buffer on the stack in a high level API once doesn't cause extreme stack usage, does the same single allocation of a buffer on the heap not cause a very noticable performance hit. 2) With proper dynamic buffer allocations we can get rid of many buffer length limitations. A stack buffer is always fixed length and can fail fataly if a parameter is entered which causes buffer overflow. So the code needs to do extra checks. Dynamic allocated buffers can be as long as necessary and do not necessarily have buffer overflow issues. Rolf Kalbermatter CIT Engineering Nederland BV tel: +31 (070) 415 9190 Treubstraat 7H fax: +31 (070) 415 9191 2288 EG Rijswijk http://www.citengineering.com Netherlands mailto:rolf.kalbermatter@citeng.com

1 0

Clipboard between applications
by Ferenc Wagner 24 Mar '03

24 Mar '03

Hello! I'm unable to move the contents of the clipboard between applications. At the end you find an annotated --debugmsg +clipboard log (with a call for IsSelectionOwner inserted into CloseClipboard). In short, the copying application can read the clipboard, but the other one can't. Seems like the x11drv/clipboard.c data isn't shared between the threads. Copying between two notepad.exe.so-s works, but through the X selection only (guess from the logs; the IsSelectionOwner status is 1 (ie. S_PRIMARY) during that process). Is it a mis(configuration|understanding) on my side, or isn't this functionality implemented? Thanks: Feri. ### Application startup: trace:clipboard:OpenClipboard ((nil))... trace:clipboard:OpenClipboard returning 1 trace:clipboard:EmptyClipboard () trace:clipboard:GetOpenClipboardWindow () trace:clipboard:X11DRV_AcquireClipboard Grabbed X selection, owner=(00000000) trace:clipboard:CloseClipboard () trace:clipboard:X11DRV_IsSelectionOwner status: 3 fixme:font:WineEngCreateFontInstance Untranslated charset 138 ### Copy to selection: trace:clipboard:OpenClipboard (0x2007a)... trace:clipboard:OpenClipboard returning 1 trace:clipboard:EmptyClipboard () trace:clipboard:GetOpenClipboardWindow () trace:clipboard:SetClipboardData (0000000D, 0x403a2f4a) ! trace:clipboard:GetOpenClipboardWindow () trace:clipboard:SetClipboardData (00000001, 0x403a099a) ! trace:clipboard:GetOpenClipboardWindow () trace:clipboard:CloseClipboard () trace:clipboard:X11DRV_IsSelectionOwner status: 3 ### Paste selection (other application) trace:clipboard:OpenClipboard (0x20065)... trace:clipboard:OpenClipboard returning 1 trace:clipboard:X11DRV_IsSelectionOwner status: 0 [...it fails...] ### Paste selection (application that made to copy) trace:clipboard:OpenClipboard (0x2007a)... trace:clipboard:OpenClipboard returning 1 trace:clipboard:CLIPBOARD_EnumClipboardFormats Next available format 13 trace:clipboard:IsClipboardFormatAvailable (000D)- ret(1) trace:clipboard:GetClipboardData (0000000D) trace:clipboard:CLIPBOARD_RenderText UNICODETEXT -> UNICODETEXT trace:clipboard:CLIPBOARD_RenderFormat enter format=13 trace:clipboard:X11DRV_IsSelectionOwner status: 3 trace:clipboard:GetClipboardData returning 0x4039ec92 (type 13) trace:clipboard:CloseClipboard () trace:clipboard:X11DRV_IsSelectionOwner status: 3 [...success...]

2 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel