wine-devel

wine-devel@winehq.org

9 participants
84458 discussions

wine and services ..
by Lars Segerlund 19 Mar '03

19 Mar '03

I have asked a before about NT services, and about the support for them in wine, does wine have any support for NT services ? I'm getting errors on some code which I have written for NT and it runs on NT 2k xp , and it seem's that there is no support for services. If I wanted to get started on an implementation, how difficult and where would I look ? It seem's that wined should be able to handle stuff like this ? / regards, Lars Segerlund.

2 1

Re: TreeView notifications fix (take 2)
by Dimitrie O. Paun 19 Mar '03

19 Mar '03

On March 19, 2003 09:08 am, Mike Hearn wrote: > As per Dimis suggestion, here is a more streamlined version of the > patch. > > ChangeLog: > > - Make IsWindowUnicode check dialog wndprocs Excellent! Now, in the light of this new finding, we have to reasses the listview situation. Did you get a chance to rerun Drew's tests for the listview? -- Dimi.

2 1

Re: TreeView notifications fix
by Dmitry Timoshkov 19 Mar '03

19 Mar '03

"Mike Hearn" <mike(a)theoretic.com> wrote: > ChangeLog: > - Make the change notifications respect unicode vs ansi. > - TVN_SELCHANGINGW, > + infoPtr->bNtfUnicode ? TVN_SELCHANGINGA : TVN_SELCHANGINGW, Shouldn't this be reversed? -- Dmitry.

5 12

[RFC] windres' -I option
by Dimitrie O. Paun 19 Mar '03

19 Mar '03

Hi folks, For the past few month, I've been working on having better interoperability between MinGW, and Wine (http://www.winehq.org). By this I mean the ability to maintain a single build system capable of building apps for either environment. Needless to say, this is a worthy goal, as it allows Windows-only apps to seamlessly build as Linux-native apps. This is a complex problem, but for the purpose of this email I will only focus on windres. As you probably already know, the Wine project has it's own resource compiler (wrc). For obvious reasons, it is quite desirable to have wrc and windres be command line compatible. To this end, I've modified wrc to the point where we support all but *one* of windres' options: -I. This option is used in windres to specify the input format, while in wrc it's used to specify include directories. The wrc semantics has a lot on it's side: it is the de-facto standard in the Unix world for specifying include dirs, and it is even compatible with MS's rc. Given the overwhelming inclination to use -I as an include dir specifier, I think it would be better if we could align windres to this standard. My proposal is simple: rename -I to something else (I suggest -J), and introduce -I as a synonym for --include-dir. Now, I realize this is a controversial change -- what about backwards compatibility? Luckily, the situation is not as bad as it might seem. Firstly, this option does not seem to be used all that often in practice. Second, the nature of the option allows for a simple scheme. That is, with -I now used for include directories, we can try to match the 3 possible old values (res, rc, coff). If they match, we consider it a input format specifier, issue a deprecation warning, and behave in the old fashion. Otherwise, consider the input an include directory. But what if one want to specify 'res' or 'coff' as an include dir? Well, apart from the fact that this is _very_ unlikely, all they have to do is to prefix those values with './': that is ./res or ./coff. But I guess this is already too much talk and too little action. Here is a patch that implements the above, and updates the documentation. ChangeLog Rename the -I option to -J. Introduce -I as synonym for --include-dir. Index: binutils/windres.c =================================================================== RCS file: /cvs/src/src/binutils/windres.c,v retrieving revision 1.13 diff -u -r1.13 windres.c --- binutils/windres.c 5 May 2002 23:25:27 -0000 1.13 +++ binutils/windres.c 17 Mar 2003 07:14:16 -0000 @@ -110,8 +110,7 @@ #define OPTION_DEFINE 150 #define OPTION_HELP (OPTION_DEFINE + 1) -#define OPTION_INCLUDE_DIR (OPTION_HELP + 1) -#define OPTION_LANGUAGE (OPTION_INCLUDE_DIR + 1) +#define OPTION_LANGUAGE (OPTION_HELP + 1) #define OPTION_PREPROCESSOR (OPTION_LANGUAGE + 1) #define OPTION_USE_TEMP_FILE (OPTION_PREPROCESSOR + 1) #define OPTION_NO_USE_TEMP_FILE (OPTION_USE_TEMP_FILE + 1) @@ -122,8 +121,8 @@ { {"define", required_argument, 0, OPTION_DEFINE}, {"help", no_argument, 0, OPTION_HELP}, - {"include-dir", required_argument, 0, OPTION_INCLUDE_DIR}, - {"input-format", required_argument, 0, 'I'}, + {"include-dir", required_argument, 0, 'I'}, + {"input-format", required_argument, 0, 'J'}, {"language", required_argument, 0, OPTION_LANGUAGE}, {"output-format", required_argument, 0, 'O'}, {"preprocessor", required_argument, 0, OPTION_PREPROCESSOR}, @@ -140,7 +139,7 @@ static void res_init PARAMS ((void)); static int extended_menuitems PARAMS ((const struct menuitem *)); -static enum res_format format_from_name PARAMS ((const char *)); +static enum res_format format_from_name PARAMS ((const char *, int)); static enum res_format format_from_filename PARAMS ((const char *, int)); static void usage PARAMS ((FILE *, int)); static int cmp_res_entry PARAMS ((const PTR, const PTR)); @@ -588,7 +587,7 @@ /* Convert a string to a format type, or exit if it can't be done. */ static enum res_format -format_from_name (name) +format_from_name (name, int exit_on_error) const char *name; { const struct format_map *m; @@ -597,7 +596,7 @@ if (strcasecmp (m->name, name) == 0) break; - if (m->name == NULL) + if (m->name == NULL && exit_on_error) { non_fatal (_("unknown format type `%s'"), name); fprintf (stderr, _("%s: supported formats:"), program_name); @@ -779,6 +778,7 @@ char *input_filename; char *output_filename; enum res_format input_format; + enum res_format input_format_tmp; enum res_format output_format; char *target; char *preprocessor; @@ -828,12 +828,12 @@ output_filename = optarg; break; - case 'I': - input_format = format_from_name (optarg); + case 'J': + input_format = format_from_name (optarg, 1); break; case 'O': - output_format = format_from_name (optarg); + output_format = format_from_name (optarg, 1); break; case 'F': @@ -868,7 +868,16 @@ verbose ++; break; - case OPTION_INCLUDE_DIR: + case 'I': + /* for backward compatibility, should be removed in the future */ + input_format_tmp = format_from_name (optarg, 0); + if (input_format_tmp != RES_FORMAT_UNKNOWN) + { + fprintf (stderr, _("Option -I is deprecated for setting the input format, please use -J instead.\n")); + input_format = input_format_tmp; + break; + } + if (preprocargs == NULL) { quotedarg = quot (optarg); Index: binutils/doc/binutils.texi =================================================================== RCS file: /cvs/src/src/binutils/doc/binutils.texi,v retrieving revision 1.30 diff -u -r1.30 binutils.texi --- binutils/doc/binutils.texi 24 Feb 2003 16:20:28 -0000 1.30 +++ binutils/doc/binutils.texi 17 Mar 2003 07:14:22 -0000 @@ -2569,7 +2569,7 @@ non-option argument, then @command{windres} will write to standard output. @command{windres} can not write a COFF file to standard output. -@item -I @var{format} +@item -J @var{format} @itemx --input-format @var{format} The input format to read. @var{format} may be @samp{res}, @samp{rc}, or @samp{coff}. If no input format is specified, @command{windres} will @@ -2597,6 +2597,7 @@ to use, including any leading arguments. The default preprocessor argument is @code{gcc -E -xc-header -DRC_INVOKED}. +@item -I @var{directory} @item --include-dir @var{directory} Specify an include directory to use when reading an @code{rc} file. @command{windres} will pass this to the preprocessor as an @option{-I} -- Dimi.

1 0

Re: Wine crashes and floods shell with garbage
by Vilppa Salt 19 Mar '03

19 Mar '03

>Anyone else has this problem? > >[mrok@mrok cdrom]# wine setup >[mrok@mrok cdrom]# fixme:ntdll:MODULE_AllocModRef Trying to load second >.EXE >file: E:AutoRun.exe >fixme:ntdll:MODULE_AllocModRef Trying to load second .EXE file: >E:AutoRun.exe >fixme:ntdll:MODULE_AllocModRef Trying to load second .EXE file: >E:AutoRun.exe >@wine client error:0: T++Â€B `BÃ@ >`BfBÅÃœh@3ÅŒ@#Ã€Ãœh@+Å3ÅŒ >@wine client error:0: T++Â€B `BÃ@ >`BfBÅÃ«h@3ÅŒ @?@#ÄÃ«h@+Å3ÅŒ >@wine client error:0: T++Â€B `BÃ@ >`BfBÄÅ®h@3ÅŒ @?@#ÂŽÅ®h@+Å3ÅŒ >@wine client error:0: T++Â€B `BÃ@ >`BfBÂ°Ãh@3ÅŒ @?@#Ãh@+Å3ÅŒ >@wine client error:0: T++Â€B `BÃ@ >`BfBÂµh@3ÅŒ @?@#Âµh@+Å3ÅŒ >@wine client error:0: T++Â€B `BÃ@ >`BfBÅh@3ÅŒ @?@#lÅh@+Å3ÅŒ >@wine client error:0: T++Â€B `BÃ@ >`BfBhh@3ÅŒ @?@#Th@+Å3ÅŒ >@wine client error:0: T++Â€B `BÃ@ >`BfBPh@3ÅŒ @?@#<h@+Å3ÅŒ >@wine client error:0: T++Â€B `BÃ@ >`BfB8mh@3ÅŒ @?@#$mh@+Å3ÅŒ >@wine client error:0: T++Â€B `BÃ@ `BfB >[h@3ÅŒ @?@#[h@+Å3ÅŒ >@wine client error:0: T++Â€B `BÃ@ >`BfIh@3ÅŒ @? @#ÃŽHh@+Å3ÅŒ >... > >Looks like this happens when wine tries to run another process. Any >ideas >how to fix it? Yes, I've had it. When trying to run Tribes 2 PC version that happens. I also think that it is because .exe tries to launch another exe file. When running "wine SIERRAUP.EXE" the program checks for updates from a web site and then tries to launch "tribes2.exe -online" and crashes with similar symptoms. Those errors always begin with T++ and after that comes some random garbage. No ideas how to fix it. --- Vilppa- Sunpoint.net ilmoittaa: Sunpoint.net tarjoaa kaikille rekisteröityneille käyttäjilleen kuukausimaksuttoman Internet -yhteyden (pvm). http://www.sunpoint.net/SunAds/click.htm?mode=footer&id=71&jump=http%3A%2F%…

1 0

Re: wine/tools/winebuild winebuild.man.in utils.c ...
by Dimitrie O. Paun 18 Mar '03

18 Mar '03

On March 18, 2003 12:30 am, Alexandre Julliard wrote: > [...] also to make specification of an entry point link name optional. Yay! Does this mean that we can transform entries that are of the form ... X(...) X to just ... X(...) ? :) -- Dimi.

3 3

Re: Fwd: Test Header
by Alexandre Julliard 18 Mar '03

18 Mar '03

Jon <jon_p_griffiths(a)yahoo.com> writes: > Finally, all references to stdout have been removed - this allows the tests > to be built with msvcrt or libc and work. This in turn allows developers to > check that c library differences (e.g. printf formatting) won't affect the > test results, without rebooting to rebuild/re-run the tests under native > windows. It also means you can manually call _chkstk when implementing > undocumented calls to ensure that you have the parameters and calling > convention correct (a coming patch implements this function for builtin > msvcrt). > > Note we have to define __NO_INLINE__ when we make the tests, since otherwise > our non-stdout referencing calls get mapped straight back to referencing > stdout by the glibc headers, and msvcrt will blow up trying to write to a non > existant fd. This is wrong; if you link with msvcrt you have to use msvcrt headers, and then everything works fine, including references to stdout. If you mix glibc and msvcrt you are in trouble. -- Alexandre Julliard julliard(a)winehq.com

3 4

Re: Open Source MFC Replacement WRT Wine?
by thomas.mertes＠gmx.at 18 Mar '03

18 Mar '03

On Wed, 18 Oct 2000, Francois Gouget wrote: > On Wed, 18 Oct 2000, Andrew Lynch wrote: > > > As seen on SourceForge: > > > > "The Open Foundation Classes (OFC) are a frameset of > [...] > > http://sourceforge.net/projects/ofc/ > [...] > > This project could potentially solve that problem by > > replacing MFC with a open source/free equivalent. > > > > Has anyone heard anything further on this? > > > > Opinions? Comments? Discussion? > > I went to their web site on SourceForge and AFAICS there's not much: > nothing in CVS, no released files, no bug reports. It looks like they > are just starting up so it is understandable. I wish them well. > > If their project does take off I think we should provide them with > the necessary support so that it compiles out of the box with Winelib. > Then maybe some of the Wine folks could be interested in contributing > but that's up for individual developpers to decide. > > But first: > Show me the (at least some) code! I looked there, and found some code (just a little bit, but at least some code). If you are wondering: I checked Google for "open source MFC", found this mail and checked the link (http://sourceforge.net/projects/ofc/). After that I could not resist replying to this mail. I don't know, if there is developing activity going on in the OFC project. The last check in is 5 Months ago. But I think now is the time for First Contact (C). Greetings Thomas Mertes -- +++ GMX - Mail, Messaging & more http://www.gmx.net +++ Bitte lächeln! Fotogalerie online mit GMX ohne eigene Homepage!

1 0

error when running wine..
by JGraham 18 Mar '03

18 Mar '03

has anyone gotten this message "err:module:get_registry_value Invalid load order module-type L"so", ignored"? it's been happening for me on current cvs builds. I have a clean fake windows and registry. so, i shouldn't be getting it.. thanks.

3 2

Re: Widl Fixes
by Ove Kaaven 18 Mar '03

18 Mar '03

fre, 2003-03-07 kl. 19:49 skrev Jon: > This patch addresses some issues with widl. After applying the patch all .idl > files should be regenerated. These fixes are needed before my ocidl.idl can > be added. The last two lines of the changelog aren't seen in the wild; I > found them only when adding ocidl to my tree. Could you explain the reason behind the last line, "Don't dump full struct/enum definitions in prototypes", since this shouldn't happen in any case. When a prototype is emitted, the parameter type is supposed to be defined, or not; if it's not defined, t->defined is FALSE, and if it's defined, t->written should be TRUE, either of which should lead to the "else" clause which doesn't dump the full struct/enum definition. If t->written isn't TRUE, why isn't it? (And if there's a good reason for it after all, it would be cleaner to say "if (t->defined && !t->written && structs)" instead of adding a new "if (structs)" inside) > There is one remaining bug in widl which I haven't yet tracked down; someone > more knowledgable with widl may want to look at it: > > If objidl.idl is compiled with '-b' but without '-h', the resulting header > contains garbage ("[][][][][][][][][]" - generated by write_array() just > after IPropertyStorage_Stat_Stub) in the generated header. With both flags > (the default for Wine) however, the output is correct. I thought I had fixed such occurrences. If your widl is properly recompiled, then I'm not sure why it happens. > Also, it would be nice if widl handled function pointers as method args... I didn't think RPC supported this. The MS IDL I've seen just uses that cpp_quote #if 0 ... else trick to define structures with these, and I saw no need for widl to be smarter about it than MIDL is, considering that function pointers doesn't map cleanly to RPC anyway. Besides, it would be nice if our .idl files stayed compatible with MIDL.

2 4

Re: TreeView notifications fix
by John K. Hohm 18 Mar '03

18 Mar '03

> Well, WinAmp seems to use CreateWindowExW to create the window, but I > can't find where the window class is registered, it doesn't seem to > appear in a +class trace anywhere. The string name is "#32770", so maybe > it's internal. Indeed, here is a list of system classes: Class Description ---------- -------------------------------------------------------------- ComboLBox The class for the list box contained in a combo box. DDEMLEvent Windows NT/Windows 2000/Windows XP: The class for Dynamic Data Exchange Management Library (DDEML) events. Message Windows 2000/Windows XP: The class for a message-only window. #32768 The class for a menu. #32769 The class for the desktop window. #32770 The class for a dialog box. #32771 The class for the task switch window. #32772 Windows NT/Windows 2000/Windows XP: The class for icon titles.

2 1

Wine crashes and floods shell with garbage
by Rok Mandeljc 17 Mar '03

17 Mar '03

Anyone else has this problem? [mrok@mrok cdrom]# wine setup [mrok@mrok cdrom]# fixme:ntdll:MODULE_AllocModRef Trying to load second .EXE file: E:\AutoRun.exe fixme:ntdll:MODULE_AllocModRef Trying to load second .EXE file: E:\AutoRun.exe fixme:ntdll:MODULE_AllocModRef Trying to load second .EXE file: E:\AutoRun.exe @wine client error:0: T++\¤B `BÄ@ `BfBřýh@3ż@#äýh@+Ŕ3ż @wine client error:0: T++\¤B `BÄ@ `BfBŕëh@3ż @?@#Ěëh@+Ŕ3ż @wine client error:0: T++\¤B `BÄ@ `BfBČŮh@3ż @?@#´Ůh@+Ŕ3ż @wine client error:0: T++\¤B `BÄ@ `BfB°Çh@3ż @?@#Çh@+Ŕ3ż @wine client error:0: T++\¤B `BÄ@ `BfBµh@3ż @?@#µh@+Ŕ3ż @wine client error:0: T++\¤B `BÄ@ `BfBŁh@3ż @?@#lŁh@+Ŕ3ż @wine client error:0: T++\¤B `BÄ@ `BfBhh@3ż @?@#Th@+Ŕ3ż @wine client error:0: T++\¤B `BÄ@ `BfBPh@3ż @?@#<h@+Ŕ3ż @wine client error:0: T++\¤B `BÄ@ `BfB8mh@3ż @?@#$mh@+Ŕ3ż @wine client error:0: T++\¤B `BÄ@ `BfB [h@3ż @?@#[h@+Ŕ3ż @wine client error:0: T++\¤B `BÄ@ `BfIh@3ż @? @#ôHh@+Ŕ3ż ... Looks like this happens when wine tries to run another process. Any ideas how to fix it?

2 1

Segfaults in RtlTryEnterCriticalSection ?
by Sylvain Petreolle 17 Mar '03

17 Mar '03

What information could be usefull to debug a segfault in RtlTryEnterCriticalSection ? Since March beginning I have segfaults into programs that used to run before. Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 8192 (LWP 8925)] 0x400ba904 in RtlTryEnterCriticalSection (crit=0x40240570) at ../../include/winbase.h:1918 1918 __asm__ __volatile__( ".byte 0x64\n\tmovl 0x24,%0" : "=r" (ret) ); (gdb) bt #0 0x400ba904 in RtlTryEnterCriticalSection (crit=0x40240570) at ../../include/winbase.h:1918 #1 0x4009355c in TryEnterCriticalSection (crit=0x40240570) at ../../memory/heap.c:814 #2 0x400b15f3 in __pthread_mutex_trylock (mutex=0x4212b180) at ../../scheduler/pthread.c:320 #3 0x42073999 in calloc () from /lib/i686/libc.so.6 #4 0x410c69e7 in s8790 () from /usr/X11R6/lib/modules/dri/fglrx_dri.so (gdb) list - 1908 { 1909 DWORD ret; 1910 __asm__ __volatile__( ".byte 0x64\n\tmovl 0x20,%0" : "=r" (ret) ); 1911 return ret; 1912 } 1913 1914 extern inline DWORD WINAPI GetCurrentThreadId(void); 1915 extern inline DWORD WINAPI GetCurrentThreadId(void) 1916 { 1917 DWORD ret; gdb) disass $pc-32 $pc+32 Dump of assembler code from 0x400ba8e4 to 0x400ba924: 0x400ba8e4 <RtlTryEnterCriticalSection+32>: or $0x74,%al 0x400ba8e6 <RtlTryEnterCriticalSection+34>: or %ecx,0x24348bc8(%ecx) 0x400ba8ec <RtlTryEnterCriticalSection+40>: leave 0x400ba8ed <RtlTryEnterCriticalSection+41>: ret $0x4 0x400ba8f0 <RtlTryEnterCriticalSection+44>: mov $0x1,%eax 0x400ba8f5 <RtlTryEnterCriticalSection+49>: lock xadd %eax,(%edx) 0x400ba8f9 <RtlTryEnterCriticalSection+53>: incl 0x8(%esi) 0x400ba8fc <RtlTryEnterCriticalSection+56>: mov $0x1,%ecx 0x400ba901 <RtlTryEnterCriticalSection+61>: jmp 0x400ba8e7 <RtlTryEnterCriticalSection+35> 0x400ba903 <RtlTryEnterCriticalSection+63>: nop 0x400ba904 <RtlTryEnterCriticalSection+64>: mov %fs:0x24,%eax 0x400ba90a <RtlTryEnterCriticalSection+70>: mov %eax,0xc(%esi) 0x400ba90d <RtlTryEnterCriticalSection+73>: movl $0x1,0x8(%esi) 0x400ba914 <RtlTryEnterCriticalSection+80>: jmp 0x400ba8fc <RtlTryEnterCriticalSection+56> 0x400ba916 <RtlTryEnterCriticalSection+82>: mov %esi,%esi 0x400ba918 <RtlLeaveCriticalSection>: push %ebp 0x400ba919 <RtlLeaveCriticalSection+1>: mov %esp,%ebp 0x400ba91b <RtlLeaveCriticalSection+3>: mov 0x8(%ebp),%ecx 0x400ba91e <RtlLeaveCriticalSection+6>: push %ebx 0x400ba91f <RtlLeaveCriticalSection+7>: mov 0x8(%ecx),%eax 0x400ba922 <RtlLeaveCriticalSection+10>: dec %eax 0x400ba923 <RtlLeaveCriticalSection+11>: call 0x400ba928 <RtlLeaveCriticalSection+16> End of assembler dump. ===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight Spam ! EuroCauce: http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus, in "Matrix". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

3 3

Re: winedos / Speed up RM software interrupt handling
by Alexandre Julliard 17 Mar '03

17 Mar '03

Jukka Heinonen <jhei(a)iki.fi> writes: > This patch speeds up software interrupts in real mode > considerably, in addition to making interrupt handling simpler > (at least in my opinion). Instead of throwing an exception, > vm86 handler calls winedos callback as is done in case of > protected mode software interrupts. I think it would be cleaner to make __wine_enter_vm86 simply return in that case and let winedos deal with that. We don't want the signal handling to have to know about winedos if possible. -- Alexandre Julliard julliard(a)winehq.com

3 4

Re: Re Resend fix for ArrangeCtrlPositions in commdlg
by Tony Lambregts 17 Mar '03

17 Mar '03

Maxime Bellengé wrote: > Here is the good one attached. Sorry for the trouble. > Please discard the previous one. > > a+ > > ChangeLog: > - Fix how the size of the dialog is computed and the child component > placed. > This one looks line wrapped as well (sorry) -- Tony Lambregts

3 2

Determining dll imports in dlls
by Brad Campbell 17 Mar '03

17 Mar '03

G'day all, I'm using wine in a small control system to run a gui win32 program. I had an idea that I could determine what dll's this program used and only including the wine.dll.so files that were required to run this program. I started by doing a strings on the .exe file and using that to determine which .dlls it referenced. I thought I could use the same process to determine which dll's were then referenced by the dll's the .exe pulled in. Plus including the core dll's by default. Am I missing something, or will this work ? I'm in the process of developing a batch file to do it for me, is there a more accurate way of determining which dll's a dll references than doing a text search for dll names in the binary? -- Brad.... /"\ \ / ASCII RIBBON CAMPAIGN X AGAINST HTML MAIL / \

4 9

Re: DPRINTF->TRACE dlls/ddraw/dsurface/main.c
by Lionel Ulmer 17 Mar '03

17 Mar '03

Just to nitpick, in most of your patches, you have this : > if (TRACE_ON(ddraw)) { > - DPRINTF(" Real caps are : "); DDRAW_dump_DDSCAPS2(&our_caps); DPRINTF("\n"); > + TRACE(" Real caps are : "); DDRAW_dump_DDSCAPS2(&our_caps); TRACE("\n"); > } As we use 'TRACE' now and not 'DPRINTF', the 'TRACE_ON' constructs could be removed. But well, one could say that it optimizes stuff to not do the test thrice :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/

4 4

Re: Oleaut32 Debug Messages
by Dimitrie O. Paun 17 Mar '03

17 Mar '03

On March 11, 2003 05:49 pm, Jon wrote: > - if (debugout) MESSAGE("%lx",*arg); > + if (debugout) TMSG2("%lx",*arg); This is just too ugly! Please don't do such code uglification to save a few bytes. Beyond that, why isn't this file using the standard TRACE macro? MESSAGEs should be very rare, and are intended for the user, as such there's no need to compile them out, ever. -- Dimi.

7 17

Re: Re Resend fix for ArrangeCtrlPositions in commdlg
by Alexandre Julliard 16 Mar '03

16 Mar '03

Maxime Bellengé <maxime.bellenge(a)laposte.net> writes: > Here is the good one attached. Sorry for the trouble. > Please discard the previous one. Please don't send two copies of the patch in your mails. If you can't make your mailer inline properly then don't inline at all, simply attach it. A wrapped patch is completely useless, inlined or not. -- Alexandre Julliard julliard(a)winehq.com

1 0

W->A dlls/commdlg/fontdlg.c
by Tony Lambregts 16 Mar '03

16 Mar '03

On Dimi's Janitorial page he has the entry for: dlls/commdlg/fontdlg.c: comdlg32: ChooseFontW: illegal call to HEAP_strdupWtoA When I look at the actual call I see that it is inside a comment block (#if 0... #endif) Although the actual implentation of ChooseFontW does not make direct W->A calls, this whole setup for ChooseFont(A/W) is IMO a mess and just not right. BOOL WINAPI ChooseFontW(LPCHOOSEFONTW lpChFont) { CHOOSEFONTA cf_a; LOGFONTA lf_a; CHAR style_a[LF_FACESIZE]; cf_a.lpLogFont = &lf_a; cf_a.lpszStyle = style_a; if (ChooseFontWtoA(lpChFont, &cf_a) == FALSE) { COMDLG32_SetCommDlgExtendedError(CDERR_MEMALLOCFAILURE); return FALSE; } if (ChooseFontA(&cf_a) == FALSE) { if (cf_a.lpTemplateName != NULL) HeapFree(GetProcessHeap(), 0, (LPSTR)(cf_a.lpTemplateName)); return FALSE; } ChooseFontAtoW(&cf_a, lpChFont); return TRUE; } I would appreciate Any comments about this. -- Tony Lambregts

2 3

Treeview problem?
by Mike Hearn 16 Mar '03

16 Mar '03

Hi, Could somebody please explain why this patch : http://www.winehq.com/hypermail/wine-patches/2003/02/0107.html for fixing the treeview wasn't applied? The author said there is a test case that shows this is what NT does, so I'm wondering what needs to be done to it to make it acceptable. thanks -mike

1 0

Re: DSOUND: buffer underrun & sound chunks left out
by Tony Lambregts 16 Mar '03

16 Mar '03

Jerry Ji wrote: > This patch fix two problem: > 1. the improper play position return by DSOUND_PrimaryGetPosition - beffer > underrun, > 2. and the notify mechanics we used - sound data skipped. > > Please refer to the comment for the first problem. > > DSOUND_CheckEvent(IDirectSoundBufferImpl *dsb, int len) original use current > play position and the count of data TO BE played to check if a notify should > be generated. That's to say, an application may be notified before the data > at the desired offset really played. Since the application got the notify > that the data in it's demand region is useless (played), it might call > IDirectSoundBufferImpl_Lock to lock this region, which contains useful data, > IDirectSoundBufferImpl_Lock will handle the conflict by cancelling the > region by default. > > NOTE: > There are still problems with DSBPN_OFFSETSTOP event. If the buffer's state > is STATE_STOPPED, my patch will set the event each time DSOUND_PerformMix > called by the timer! I know it's a bad idea, so if anyone have a better > solution, please re-patch it. > > ChangeLog: > - Fixed buffer underrun & sound chunks left out. > First off thankyou for your contribution Your patch is not in the right format.ie: it can not be read inline and Alexandre can't do "cat raw_mail | patch -p0" [...] ------=_NextPart_000_0089_01C2EC19.AE973D80 Content-Type: application/octet-stream; name="patch.diff" [....] - if (playpos) This->last_playpos =3D *playpos;=0A= + if (playpos) {=0A= + This->last_playpos =3D This->playpos;=0A= + This->playpos =3D *playpos;=0A= + }=0A= [....] Please see section 5.2.1 Inline attachments with Outlook Express. at the following link. http://www.winehq.org/Docs/wine-devel/style-notes.shtml -- Tony Lambregts

1 0

[RFC] 16 bit functions
by Dimitrie O. Paun 16 Mar '03

16 Mar '03

Hi folks, I was just thinking that it would be nice if a we had a simple naming rule for 16 bit functions: "A function is 16 bit if and only if it's name ends in 16." This way, we can have more reliable tools for detecting 32-16 bit cross calls (unfortunately, winapi_check fails in many instances for this check). Most 16 bit functions already adhere to this naming convention, but there are still a few that don't. Alexandre, would renaming such functions be acceptable? If so, I can add yet another janitorial task... -- Dimi.

2 3

Re: Resend of the Fix for ArrangeCtrlPositions in commdlg
by Tony Lambregts 16 Mar '03

16 Mar '03

Maxime Bellengé wrote: > As requested by Alexandre, I send the patch with more comments. > > I have made several test cases under windows and taken screenshot to > compare with wine. If someone is interested in seeing them, send me a > mail. > > ChangeLog: > - Fix how the size of the dialog is computed and the child component > placed. > > Something is wrong here... You have two patches here. The patch with the comments got line wrapped (Looks like part of your signature in mozilla) and the patch that was attached does not contain the comments. -- Tony Lambregts

1 0

bitmap corruption
by Mike Hearn 16 Mar '03

16 Mar '03

if anybody wishes to tackle a fun bug, take a look at the imagelist control in commctrl32 - it corrupts masks, giving some nasty visual corruption esp on toolbar icons, but i've also seen it in winrar. i suspect the _read_bitmap function doesn't do 1bit images correctly, but didn't really manage to find out. i might have another crack tomorrow, but in case somebody is looking for a job.... :)

2 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel