wine-devel

wine-devel@winehq.org

10 participants
84459 discussions

Re: dlls/user: w[v]snprintf[A|W] fixes
by David Laight 27 Oct '02

27 Oct '02

> > > Changelog: > > * dlls/user/wsprintf.c Jaco Greeff <jaco(a)puxedo.org> > > - Changed the wsprintf[A|W] and wvsprintf[A|W] functions to > > determine the size of the destination buffer before writing > > to it. Previously the size was hardcoded to 1024 bytes. > > The size is supposed to be hardcoded to 1024, that's how wsprintf > works. You can't make it dynamic since the buffer is allocated by the > application. Seems to me (from info in a later post) that M$ wsprintf uses an internal temporary buffer that has a size of 1024 - thus resticting the user to a buffer size of 1024, The actual size of the user buffer cannot be determined - hence the common 'buffer overflow' issues with sprintf. The C standard now includes snprintf() where the application passes in the length of the target buffer. I guess M$ might follow :-) Some systems also have an asprintf() routine which will malloc() a buffer that the caller must free(). David -- David Laight: david(a)l8s.co.uk

1 0

Segmentation Fault
by Kye Lewis 27 Oct '02

27 Oct '02

Hi, Not really sure if this is the right place to post this, but as i'm signed up to it; My version of wine has suddenly started Seg Faulting on startup. The last thing I tried with wine was netmeeting. This is with cvs version from 26th October at about 2:00 Australian Eastern Standard Time ( not sure what that is GMT - it was about 5 hours before posting this message ) Any help would be appreciated. Thanks, Kye Lewis kyethespy(a)liquid2k.com

3 5

Re: dlls/user: w[v]snprintf[A|W] fixes
by Jaco Greeff 27 Oct '02

27 Oct '02

On 26 Oct 2002 14:57:53 -0700, Alexandre Julliard <julliard(a)winehq.com> wrote : > The size is supposed to be hardcoded to 1024, that's how wsprintf > works. You can't make it dynamic since the buffer is allocated by the > application. >From MSDN: "Pointer to a buffer to receive the formatted output. The maximum size of the buffer is 1024 bytes." The question I need to ask myself now is what function reference did I compare this one to when I searched there?

1 0

[RFC] creating Wine's own 'assert' variant
by Lionel Ulmer 26 Oct '02

26 Oct '02

Hi all, Currently, Wine's code is full of 'asserts'. The problem I have with that if that when such an assert is reached, only the thread being asserted is aborted, but Wine is not 'shut down' properly. Moreover, if I want the debugger to be launched on assert, I would need first to start the application with the debugger and add a breakpoint on some libc internal function. So, don't you think it would be better to have our own 'wine_assert' macro / function that could be configurable (ie abort or start the debugger) and that would also shut-down Wine properly ? Lionel -- Lionel Ulmer - http://www.bbrox.org/

4 5

Re: interrupts in when in NT version
by John K. Hohm 26 Oct '02

26 Oct '02

> Tough all safedisc programs depend on this, I have decided not to make an > official patch. The reason is that additional info is needed for a proper > fix. Safedisc depends on that EXCEPTION_ACCESS_VIOLATION is returned on an > int 0x01 call. But it should be checked what exceptions are raised on > different windows versions when int 0x01 is called. And maybe the same should > be done with other interrupts. > It would be good if somebody could make that test program. Else I will keep > the non proper fix. You may think me a rube, but I just made a test program that calls an arbitrary interrupt and prints the exception information. I don't set up any registers, so perhaps it generates an exception when it ought not in some cases, but anyone else is free to improve it. Source and a VC6-compiled MSVCRT-using version, along with results for all 255 interrupts on Windows XP Professional, is here: http://petra.trnty.edu/~jhohm/intexcep.zip

2 1

Re: dlls/user: w[v]snprintf[A|W] fixes
by Alexandre Julliard 26 Oct '02

26 Oct '02

"Jaco Greeff" <jaco(a)puxedo.org> writes: > Changelog: > * dlls/user/wsprintf.c Jaco Greeff <jaco(a)puxedo.org> > - Changed the wsprintf[A|W] and wvsprintf[A|W] functions to > determine the size of the destination buffer before writing > to it. Previously the size was hardcoded to 1024 bytes. The size is supposed to be hardcoded to 1024, that's how wsprintf works. You can't make it dynamic since the buffer is allocated by the application. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: msvcrt: printf family (Bug #321)
by Alexandre Julliard 26 Oct '02

26 Oct '02

"Jaco Greeff" <jaco(a)puxedo.org> writes: > * dlls/msvcrt/file.c Jaco Greeff <jaco(a)puxedo.org> > - Allow for the processing of %S and %C format specifiers as per > bug #321 > - Code duplicated/shared between dlls/user/wsprintf.c, > dlls/shlwapi/wsprintf.c and now dlls/msvcrt/file.c That's not correct. wsprintf is not a normal printf, it lacks a lot of features so it's not good enough for msvcrt. We either need a full printf implementation in msvcrt, or we need to patch the %S/%C in the format string and call the libc printf. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: DSTRICT: commdlg
by Dimitrie O. Paun 26 Oct '02

26 Oct '02

On October 26, 2002 11:14 am, Matthew Davison wrote: > - hInst = GetWindowLongA( lpofn->hwndOwner, GWL_HINSTANCE ); > + hInst = (HINSTANCE)(ULONG_PTR)GetWindowLongA( lpofn->hwndOwner, GWL_HINSTANCE ); Why can't you cast here directly to HINSTANCE? -- Dimi.

2 1

Control Panel Application does not start
by Stefan Leichter 26 Oct '02

26 Oct '02

Hello, i am currently tracking down a problem with a program (Nokia PC Suite 4; NclConf.exe) that is unable to start its control panel application. The control panel application should be started by the rundll32.exe. It does not get started because of the path in the filename. The applet is searched in the correct directory but it does not get found because the path was not stripped from the filename. So a filename with path is compared to the filename without path read from the directoy. This will never match. I have attached a logfile with the relevant line (i hope). Will please someone be so kind and look at it and tell me what ithe reason for the problem is. Thanks Stefan -------------------------------------------------------------------------------------------------------------------------- 0831f930:Call shell32.Control_RunDLL(00020025,00400000,40370bb5,0000000a) ret=00401380 0831f930:Call kernel32.LoadLibraryA(403d0028 "\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"") ret=409bb0f4 trace:dosfs:DOSFS_GetFullName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" (last=1) trace:string:lstrcpynA (0x406d1c50, "/wine_app/wine_app", 1024) trace:string:lstrcpynA (0x406d1c63, "Programme/Gemeinsame Dateien/Nokia/NCLTools", 1005) trace:string:lstrcpynW (0x406d2056, L"PROG~1F2\\GEME~SR3\\NOKIA\\NCLTOOLS", 1021) trace:dosfs:DOSFS_FindUnixName /wine_app/wine_app/Programme/Gemeinsame Dateien/Nokia/NCLTools,L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" trace:dosfs:DOSFS_ToDosFCBFormat (L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"", 0x406d1b78) trace:dosfs:DOSFS_OpenDir "/wine_app/wine_app/Programme/Gemeinsame Dateien/Nokia/NCLTools" trace:dosfs:DOSFS_ReadDir Read: long_name: L".", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"." trace:dosfs:DOSFS_ReadDir Read: long_name: L"..", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L".." trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_I.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_I.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_D.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_D.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_E.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_E.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_F.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_F.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_G.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_G.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_N.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_N.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_S.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_S.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NCLCONF_SV.HLP", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NCLCONF_SV.HLP" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NclConf.exe", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NclConf.exe" trace:dosfs:DOSFS_ReadDir Read: long_name: L"NclConf.cpl", short_name: (null) trace:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" -- L"NclConf.cpl" warn:dosfs:DOSFS_FindUnixName L"\"C:\\Programme\\Gemeinsame Dateien\\Nokia\\NCLTools\\NclConf.cpl\"" not found in '/wine_app/wine_app/Programme/Gemeinsame Dateien/Nokia/NCLTools' warn:module:MODULE_LoadLibraryExA Failed to load module 'C:\WINDOWS\SYSTEM32'; error=2 0831f930:Ret kernel32.LoadLibraryA() retval=00000000 ret=409bb0f4 0831f930:Call kernel32.FreeLibrary(00000000) ret=409bb088 0831f930:Ret kernel32.FreeLibrary() retval=00000000 ret=409bb088 0831f930:Ret shell32.Control_RunDLL() retval=00000001 ret=00401380

4 7

Re: DSTRICT: commdlg
by Dimitrie O. Paun 26 Oct '02

26 Oct '02

On October 26, 2002 11:14 am, Matthew Davison wrote: > - chf32a->hInstance=chf16->hInstance; > + chf32a->hInstance=(HINSTANCE)(ULONG_PTR)chf16->hInstance; Shouldn't we have a HINSTANCE_32 macro, for uniformity? -- Dimi.

2 1

Re: DSTRICT: commdlg
by Dimitrie O. Paun 26 Oct '02

26 Oct '02

On October 26, 2002 11:14 am, Matthew Davison wrote: > - bRet = DialogBoxIndirectParam16( hInst, lfs->hDlgTmpl16, lpofn->hwndOwner, > + bRet = DialogBoxIndirectParam16( (HINSTANCE16)LOWORD(hInst), lfs->hDlgTmpl16, lpofn->hwndOwner, And here we should have a HINSTANCE_16 macro... -- Dimi.

1 0

Re: DSTRICT: commdlg
by Dimitrie O. Paun 26 Oct '02

26 Oct '02

On October 26, 2002 11:14 am, Matthew Davison wrote: > - FillRect(hDC, &lpp->old3angle, GetClassLongA( hwnd, GCL_HBRBACKGROUND)); > + FillRect((HDC)hDC, &lpp->old3angle, (HBRUSH)GetClassLongA( hwnd, GCL_HBRBACKGROUND)); This is not right. At that point, hDC should be a HDC, if it's not, you have to modify the code around it. Such casting should happen in the WindowProc, all functions should work with the proper type. Alexandre, please do not apply the patch in this form: it silence warnings, and it makes it very difficult to properly correct the code in the future. -- Dimi.

1 0

Re: interrupts in when in NT version
by Zsolt Rizsanyi 26 Oct '02

26 Oct '02

I have forgotten to cc this discussion to wine-devel. But who is interested can catch up from this mail. On Saturday 26 October 2002 14:07, Eric Pouech wrote: > > > > Could somebody answer/test if calling interrupt int 0x01 is allowed > > > > from a win32 program in WinNT environment? I would pretty like to > > > > know that! > > > > > > I don't think it is > > > > Should I write then a patch, which would deny calling of int 0x01 from > > win32 code when winver is NT? > > Would that be applied? > > the rule of thumb is: if there's a program which depends on this to be > implemented, then yes patch will be applied > otherwise, leave it as it is Tough all safedisc programs depend on this, I have decided not to make an official patch. The reason is that additional info is needed for a proper fix. Safedisc depends on that EXCEPTION_ACCESS_VIOLATION is returned on an int 0x01 call. But it should be checked what exceptions are raised on different windows versions when int 0x01 is called. And maybe the same should be done with other interrupts. It would be good if somebody could make that test program. Else I will keep the non proper fix. > > > it was allowed on Win9x, and is used in this context IIRC as a ring 3 > > > to ring 0 transition code (how to create a cheap call gate) > > > > How good it would be if I could understand what you are speaking about :( > > But could you explain what a call gate is? > > If it is too long, then dont bother tough... > > I'll try to make it short > context: > - i386 have 4 levels of privilege => ring 3 (less privilege) up to ring > 0 > - certain operations are only allowed at ring 0 (or 1) > - user code runs in ring 3 > - kernel code runs in ring 0 (to be exact, NT had been designed to have > kernel in ring 0, and device drivers in ring 1, but this has been > altered - some drivers run in ring 0 too) > - you can always call into a less priviledged level (ring 0 => ring 3 > for example) > - the other way around requires what is known as call gates (ring 0 for > example defines the "entry points" in some way) > - most of the interrupt handlers run in ring 0 > > what the safedisc code was doing was: > 0/ code is running in ring 3 > 1/ install an interrupt handler for division by zero (IIRC) > 2/ trigger the division > 3/ have the interrupt handler called, but this is done in ring 0, even > if the code has been loaded from a user space program. here, in the > interrupt handler, you can do any ring 0 operation you want > > that's why I called it a cheap call gate (no real call gate has been > installed, and the code run in ring 0 isn't decided by the kernel but > the app) > > NT doesn't allow this to run. step 1 is not allowed (only the kernel can > decide to change an interrupt handler, which makes lots of sense) Thanks for the detailed explanation. And for completeness I will include here the explanation of Laurent Pinchart why a safedisc program calls int 0x01 : > - the last attempt to detect a debugger uses int 0x01 (enter SMM/ICE mode), > which checks if an external hardware emulator is connected to the > processor. I haven't been able to understand what the code is supposed to > do. Regards Zsolt

1 0

Re: shlfileoperation
by Uwe Bonnes 26 Oct '02

26 Oct '02

>>>>> "Dietrich" == Dietrich Teickner <Dietrich_Teickner(a)t-online.de> writes: Dietrich> Hi, I am a Odin programmer (wine for os/2). I have in Dietrich> shlfileop 3 FO_ operations full imlemented. It's tested in Dietrich> Odin. Can anyone implement and test this patch in wine ? I Dietrich> have also one test programm, if nessesary. Please send the test program. And please state how to handle your patch with regard to wine-gpl and wine-x11 license. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Loading program icon
by Peter Andersson 26 Oct '02

26 Oct '02

Hi, How do you read the icon of a windows application? Please tell me how to do it inside wine/windows-environment, and possibly independent of wine/win (the raw way). Can someone give me a hint? //Peter

1 0

Re: Listview Z0 (roll-up patch)
by David D. Hagood 26 Oct '02

26 Oct '02

Well, a cvs up -C and rebuild, and things are find here at home. I'll have to see what is up with my machine at work Monday...

1 0

Re: Listview Z0 (roll-up patch)
by David D. Hagood 25 Oct '02

25 Oct '02

Dimitrie O. Paun wrote: > > The algorithm has been: start a new series when Alexandre has committed > the previous one. So, for example, because I've started the Z-series > last night, that means that Alexandre already committed the X-series. > So the only outstanding patch not committed to CVS is Z0. I don't see a > need for a roll-up patch ;) > > That helps, but also leaves me with a conundrum - when I do a CVS update on my machine at work, and rebuild wine (make clean, make depend, make, su, wipe wine directories in /usr/local, make install, exit, run Mng4) I get the listview crash on "Along the way". I haven't been updating my machine at home, which had the patches applied, so I thought the patches were not in CVS. I will do a cvs up -C and rebuild here at home, and see what I get.

1 0

Status Report: -DSTRICT
by Michael Stefaniuc 25 Oct '02

25 Oct '02

Hello, status reports seems to be pretty popular this day so here is mine regarding compiling wine with -DSTRICT. Below is the amount of warnings we get when removing -DWINE_NO_STRICT: dll real total ------------------------------ commdlg 21 63 gdi 128 273 ntdll 148 178 ole32 16 38 shell32 120 155 user 450 839 winmm/wavemap 7 40 winmm 104 145 winsock 14 42 x11drv 60 79 ------------------------------ total 1068 1852 "real" is the number of warning for which real work is need to be done, the rest up to "total" are warnings of the type "int format, HANDLE arg". And to fix this beasts just grab http://people.redhat.com/mstefani/wine/fixpointerarg.pl and do: cd wine/dlls/$dll_in_work make clean make 2>&1 | fixpointerarg.pl and you should be done. Happy hacking bye michael P.S.: a request from Eric: please let him finish the 32bit - 16bit separation of winmm. After that is yours. -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: DSTRICT: LZexpand
by Michael Stefaniuc 25 Oct '02

25 Oct '02

It seems to look good and i'm very happy about it: i almost can't see that stuff anymore. bye michael On Sat, Oct 26, 2002 at 12:05:16AM +0100, Matthew Davison wrote: > This is my first patch to wine so if it is wrong please dont chew me up > anyway, here goes. > > ChangeLog: > Made LZexpand compile with DSTRICT defined. > -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: Listview Z0 (roll-up patch)
by David D. Hagood 25 Oct '02

25 Oct '02

For those of us who are a little behind on the patches, would it be possible to get a roll-up patch of all diffs from the CVS MAIN branch? Also, what is the status of CVS vs. the patches - what patches have been applied?

4 5

Re: Known listview bugs (take 2)
by Jeff Smith 25 Oct '02

25 Oct '02

Just a couple of days ago, the problem with native (W95-OSR2.1) regedit was that changing keys in the tree kept piling up new items in the listview. It was quite interesting seeing multiple (Default) values for a key :-). Now (12 hours ago anyways) it is always blank. When I click on where the values should be (highlight them), sometimes they will show up then. It seems something is not being refreshed that should be. Maybe I'll get a chance to dig in later today if nothing has been uncovered by then. -- Jeff S. >From: Greg Turner <gmturner007(a)ameritech.net> > >On Friday 25 October 2002 07:35 am, Dimitrie O. Paun wrote: > > On October 25, 2002 02:36 am, Greg Turner wrote: > > > So, I know this has been discussed before... but I can't recall: is > > > native (W98) regedit expected to work right now? For me, it doesn't. > > > > Well, I don't have that application, so you'll need to help debug > > it if you want it working :). First step is a --debugmsg +listview. > > If you think that's relevant, a screenshot too. > >ok, I'll do this tonight, and maybe even try to drill in a little deeper >if I can figure anything interesting out. FYI, I think this problem >existed before your listvew work started, so its probably not your >doing. > >BTW, thanks for your ongoing work, listviews feel much better lately! > >-- >gmt _________________________________________________________________ Unlimited Internet access -- and 2 months free! Try MSN. http://resourcecenter.msn.com/access/plans/2monthsfree.asp

2 1

interrupts in when in NT version
by Zsolt Rizsanyi 25 Oct '02

25 Oct '02

Hi! I have Laurent Pinchart's safedisc patch applied and working for a while now. (and it works perfectly). But the recent interrupt changes tend to cause cvs conflicts and to break it. This patch is supposed to work only if winver is nt40 so very probably this applies only to NT. What the patch relies on is that the interrupt handling code (which was INSTR_EmulateInstruction before the changes), return EXCEPTION_ACCESS_VIOLATION if interrupt 0x01 is called (if I understand it correctly). This was done with the next patches: Index: dlls/ntdll/signal_i386.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/signal_i386.c,v retrieving revision 1.46 diff -u -p -r1.46 signal_i386.c --- dlls/ntdll/signal_i386.c 12 Sep 2002 22:07:03 -0000 1.46 +++ dlls/ntdll/signal_i386.c 24 Oct 2002 10:13:36 -0000 @@ -729,6 +729,7 @@ static void do_segv( CONTEXT *context, i { EXCEPTION_RECORD rec; DWORD page_fault_code = EXCEPTION_ACCESS_VIOLATION; + DWORD priv_instr_code = EXCEPTION_PRIV_INSTRUCTION; #ifdef CR2_sig /* we want the page-fault case to be fast */ @@ -758,8 +759,8 @@ static void do_segv( CONTEXT *context, i case T_SEGNPFLT: /* Segment not present exception */ case T_PROTFLT: /* General protection fault */ case T_UNKNOWN: /* Unknown fault code */ - if (INSTR_EmulateInstruction( context )) return; - rec.ExceptionCode = EXCEPTION_PRIV_INSTRUCTION; + if (INSTR_EmulateInstruction( context, &priv_instr_code )) return; + rec.ExceptionCode = priv_instr_code; break; case T_PAGEFLT: /* Page fault */ #ifdef CR2_sig Index: memory/instr.c =================================================================== RCS file: /home/wine/wine/memory/instr.c,v retrieving revision 1.19 diff -u -p -r1.19 instr.c --- memory/instr.c 23 Oct 2002 22:24:10 -0000 1.19 +++ memory/instr.c 24 Oct 2002 10:14:08 -0000 @@ -397,7 +397,7 @@ static void INSTR_outport( WORD port, in * * Emulate a privileged instruction. Returns TRUE if emulation successful. */ -BOOL INSTR_EmulateInstruction( CONTEXT86 *context ) +BOOL INSTR_EmulateInstruction( CONTEXT86 *context, DWORD *exception_code ) { int prefix, segprefix, prefixlen, len, repX, long_op, long_addr; SEGPTR gpHandler; @@ -685,6 +685,29 @@ BOOL INSTR_EmulateInstruction( CONTEXT86 break; /* Unable to emulate it */ case 0xcd: /* int <XX> */ +<<<<<<< instr.c + if (long_op) + { + ERR("int 0x%02x from 32-bit code is not supported.\n", instr[1]); + if (instr[1] == 0x01) + *exception_code = EXCEPTION_ACCESS_VIOLATION; + break; /* Unable to emulate it */ + } + else + { + FARPROC16 addr = INT_GetPMHandler( instr[1] ); + WORD *stack = get_stack( context ); + /* Push the flags and return address on the stack */ + *(--stack) = LOWORD(context->EFlags); + *(--stack) = context->SegCs; + *(--stack) = LOWORD(context->Eip) + prefixlen + 2; + add_stack(context, -3 * sizeof(WORD)); + /* Jump to the interrupt handler */ + context->SegCs = HIWORD(addr); + context->Eip = LOWORD(addr); + } + return TRUE; +======= if(!Dosvm.EmulateInterruptPM && !DPMI_LoadDosSystem()) ERR("could not initialize interrupt handling\n"); else { @@ -693,6 +716,7 @@ BOOL INSTR_EmulateInstruction( CONTEXT86 return TRUE; } break; /* Unable to emulate it */ +>>>>>>> 1.19 case 0xcf: /* iret */ if (long_op) The second one is pretty ugly since I have not resolved the cvs conflict (I'm waiting for your input :), but the important part is this: + if (long_op) + { + ERR("int 0x%02x from 32-bit code is not supported.\n", instr[1]); + if (instr[1] == 0x01) + *exception_code = EXCEPTION_ACCESS_VIOLATION; + break; /* Unable to emulate it */ + } Here is the EXCEPTION_ACCESS_VIOLATION is returned if interrupt 0x01 is called. This was good when interrupts from 32-bit code were not supported. But now we need a special case for this. I think that on NT calling 0x01 is forbidden. But I have not tested this (and will not, because I dont have windows devel tools - I just want to run my Longman Dictionary :) I would like if this could be fixed properly and that would work with the safedisk patch, if thats possible. Thanks Zsolt

5 4

Re: [linux-audio-dev] Fwd: Opinions on running VST or DirectX plugins on Linux in real time
by Kjetil S. Matheussen 25 Oct '02

25 Oct '02

On 23 Oct 2002, Benno Senoner wrote: > I contacted the author of the VQF plugin about opinions of running > windows plugins under Linux. He is not subscribed to LAD so he told me > to forward this mail to the list. > cheers, > Benno > Interesting. But one idea I just got... Could it be possible to overcome all problems mentioned just by simply adding jack-support to the wine-server? Then someone could make a simple windows-program for chaining directx and vst plug-ins. I dont know how the wine-server works though, so please shout out if its not possible. > On Tue, 22 Oct 2002, Benno Senoner wrote: > > > We are currently discussing about the possibility to run VST or > DirectX audio > > plugins on Linux in real time. > > I remember you wrote an xmms plugin that allowed to run the windows > VQF plugin > > under Linux using wine & co. > > <snip> > > It would be cool if you could write on the linux-audio-dev list about > > experiences in that field. > > I am afraid I will have to keep this short as I'm really busy at the > moment. I also am a long way from being an audio expert or wine so I > doubt > my experiences will be of much use to you hence I didn't subscribe to > the > list . Feel free to forward this to the audio-dev list and cc me on it > if > you wish > > First, the solution I used for the VQF plugin was extremly clunky. There > was no way of letting the plugin run inside XMMS without causing > segfaults. They simply did not merge well no matter what I tried. > > I suspect but never proved that it was how WINE has to lay out it's > memory > to be able to mimic how Windows sees things like segments. The layout is > drastically different to how a Linux app normally sees things. By the > time > a VQF plugin could be loaded, the two very differnet approaches to > managing memory simply did not work well together > > In the end, the solution used was this; > > 1. At XMMS start, fork and exec an application that uses libwine to load > the windows DLL. Communicate with the parent through pipes, sockets > or > shared memory > > 2. Start up XMMS as normal > > 3. The plugin just implements stub functions for every routine a plugin > is > meant to implement and communicates the information to the child > > This had a number of issues. First, it was difficult to get information > from the plugin. It opened the sound device directly itself which meant > that visualisation data was not available. > > At one point, this was resolved by hacking wine itself to write the PCM > data to a named pipe rather than playing to a device but needless to > say, > it was too ugly to live and couldn't really be distributed easily. (I > considered it unreasonable to get users to patch and compile WINE just > to > play a piece of music, visualisations weren't that important). > > If I had a nice plugin, what I would try to do is set up two unamed > pipes > at application start to a child application using libwine. One pipe for > writing would send commands and one pipe for reading would take PCM > data. > I don't know how viable this is for you. > > > I'm not a windows / wine expert but commonsense says me it should be > > possibile to run these windows plugins under Linux in real time with > small > > buffer sizes in order to get low response times (low latency). > > I would be inclined to go the other way. With the above solution, I > would > try and buffer as much data as humanly possible to try and avoid the > overhead of calling wine constantly. For example, I would try and get 10 > seconds worth of data from the windows plugin before starting to play > anything. Once I had the PCM data, it would not matter if the plugin > could > not make real time contraints. > > > It should be possible to let wine handle the GUI stuff . (if word and > excel > > runs then it should be able to run plugin GUIs too). > > It can, but remember that if you are trying to use this plugin with a > normal application, you are likely to run into a lot of trouble. At > least > I did, but this was a few years back. Things might be different now > > I imagine you already have checked out how avifile loads it's plugins. > When I last looked at it (a few years back), it was using a stripped > down > version of WINE to just load the plugins and get the function pointers. > It > might be worth checking into. > > -- > Mel Gorman > MSc Student, University of Limerick > http://www.csn.ul.ie/~mel > > > > >

4 5

Re: Resubmitted - Prefereable GetDateFormatW fix
by Dimitrie O. Paun 25 Oct '02

25 Oct '02

On October 25, 2002 12:39 pm, Medland, Bill wrote: > (Sorry Dimi; it has to be an attachment to stop the mailer wrapping it) No, it doesn't, as long as you set up your mail to not wrap. Or, alternatively, just add it as text/plain, so it is displayed inline. But actually inlining it is better, because people can reply to it, and easily quote the portion of interest. -- Dimi.

1 0

How can an app detect it's running under WINE?
by Alberto Massari 25 Oct '02

25 Oct '02

Hi everybody, I am working on making our software (Stylus Studio, http://www.stylusstudio.com) run under WINE, if this is feasible. To achieve this, I have already implemented a bunch of APIs (the application is built against the UNICODE version of the Win32 APIs) and fixed some bugs I hit (I already mailed the first patch to wine-patches(a)winehq.com). However, I would feel better if I could detect I am running under WINE and gracefully disable some functionalities that are not yet fully supported; is there any way to achieve this? Is there a WIN32 API (like, say, GetVersionEx) that can return a string like "Windows 2000 (WINE)" or is WINE trying to be as stealth as possible? Thanks in advance, Alberto ------------------------------- Alberto Massari eXcelon Corp. http://www.StylusStudio.com

4 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel