wine-devel

wine-devel@winehq.org

10 participants
84459 discussions

Re: [Q] CreateProcess for Batch files
by us＠the-edmeades.demon.co.uk 23 Jul '02

23 Jul '02

>I don't think we want to check extensions this way. We should simply >hand off all command lines we cannot execute another way to the >command interpreter (which could be made configurable so you can use >native cmd.exe if you have it). Isnt this what Windows uses the COMSPEC env var for? Surely we should (by default) set the COMSPEC env var to wcmd, and if someone wants to change it to the real cmd.exe then they can. If I remember rightly, a simple C pgm which issues system("fred.bat") fails, (cant remember what happens if you system a .exe though). This would then leave a change to the CreateProcess and varients to recognize bat pgms to launch the program defined in comspec by. Interestingly windows2000 seems to honour comspec, and .bat extensions are registered as 'batfile' (in registry) which in turn has a default handler of %1 %* which means internally it must recognize .bat extensions itself. Jason

1 0

Threading on Solaris
by Francois Gouget 23 Jul '02

23 Jul '02

Hi, Some time ago I did some tests of Wine on Solaris x86 and found that there is a problem with the way we handle threads due to the differences between the Linux and Solaris threading models. These differences are also relevant for Solaris Sparc and probably many other Unices. Unfortunately I don't have time to work on it anymore so I created a bug report in Bugzilla where I tried to dump the relevant information, including a patch to illustrate the issues and the start of a fix. I hope it will be useful to someone... maybe Gregg who has been doing a lot of Solaris work recently. http://bugs.winehq.com/show_bug.cgi?id=904 -- Francois Gouget fgouget(a)codeweavers.com

1 0

Re: ShellExecute patch
by Duane Clark 23 Jul '02

23 Jul '02

Steven Edwards wrote: >> I guess I am not sure what the problem is with WinExec. Originally >> ShellExecuteEx used CreateProcessA and ShellExecute used WinExec, >> which simply calls CreateProcessA. I could certainly directly call >> CreateProcessA if that is preferable. > > > Yes, I tried to do that once before but could not get it to work > quite right as I am still learning how to program. Mingw cant import > from the Win16 api so CreateProcess needs to be used if we want to > have shell32 for testing under mingw or use under ReactOS. Hmm, the WinExec looks fairly easy but the WinExec16 appears to be a bit more difficult to handle. Perhaps it could be handled more easily with some sort of ifdef around those parts? Any suggestions?

4 6

builtin winininet causes segfault - ie6
by Sylvain Petreolle 23 Jul '02

23 Jul '02

running ie6 with wininet causes a segfault for now. launching it under winedbg reveals that the fault he wants to display when it crashes is an unimplemented function : wininet.dll.GetUrlCacheEntryInfoExW. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

Re: China developing Wind
by shaw 23 Jul '02

23 Jul '02

> Did you read this: > http://slashdot.org/article.pl?sid=02/07/19/2116234&mode=thread&tid=99 > > Are they using WINE? Do they know about WINE? It sure would help if they > work on the WINE source base :) > > Roland > > > I'm chinese,I'm tring my best to patch wine for supporting inputting chinse,though I'm newbie to Xlib programming and XIM. I know nothing about this news.

1 0

wininet http test blocks
by Sylvain Petreolle 23 Jul '02

23 Jul '02

Hi, running make test blocks on wininiet http test. two behaviours : - running separate after 'make testclean', go in dlls/wininet and 'make test' runs ok. - running 'make testclean' and 'make test' in main directory to launch all tests just stops when starting wininet test and doesn't write anything more. comments ? ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

ShellExecute again
by Duane Clark 23 Jul '02

23 Jul '02

Here is a much improved version (I hope), in case anyone wants to comment on it. I did a lot more testing this time, mainly by writing a test program where I tried as many combinations as I could think of. Tested on WinNT and wine using Word2000, WordPad and wine's notepad. Things tested: ShellExecute ShellExecuteEx with SEE_MASK_CLASSNAME with several combinations of fixed and replaced parameters supplying lpDirectory supplying both lpFile and lpParameters supplying only lpFile and getting the registry command from the file extension. Also tested with the pkzip installer, which uses this method to invoke MSI. testing of both open and print commands Some things not yet tested. SEE_MASK_IDLIST and SEE_MASK_INVOKEIDLIST, since I have not figured out how these IDLists work yet (I don't know how to put that in my test program). The URL handling, since ..mumble.. I can't install either IE or Mozilla in Wine. Same problem as Boris Reisig mentioned a few days ago... I also plan to try to copy the WinExec16 stuff over, but that is not in here yet. Index: dlls/shell32/shellord.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/shellord.c,v retrieving revision 1.99 diff -u -r1.99 shellord.c --- dlls/shell32/shellord.c 3 Jul 2002 21:07:36 -0000 1.99 +++ dlls/shell32/shellord.c 23 Jul 2002 02:29:56 -0000 @@ -926,192 +926,6 @@ { FIXME("0x%08lx 0x%08lx stub\n",x,z); return 0; } -/************************************************************************* - * ShellExecuteEx [SHELL32.291] - * - */ -BOOL WINAPI ShellExecuteExAW (LPVOID sei) -{ if (SHELL_OsIsUnicode()) - return ShellExecuteExW (sei); - return ShellExecuteExA (sei); -} -/************************************************************************* - * ShellExecuteExA [SHELL32.292] - * - * placeholder in the commandline: - * %1 file - * %2 printer - * %3 driver - * %4 port - * %I adress of a global item ID (explorer switch /idlist) - * %L ??? path/url/current file ??? - * %S ??? - * %* all following parameters (see batfile) - */ -BOOL WINAPI ShellExecuteExA (LPSHELLEXECUTEINFOA sei) -{ CHAR szApplicationName[MAX_PATH],szCommandline[MAX_PATH],szPidl[20]; - LPSTR pos; - int gap, len; - STARTUPINFOA startup; - PROCESS_INFORMATION info; - - WARN("mask=0x%08lx hwnd=0x%04x verb=%s file=%s parm=%s dir=%s show=0x%08x class=%s incomplete\n", - sei->fMask, sei->hwnd, debugstr_a(sei->lpVerb), - debugstr_a(sei->lpFile), debugstr_a(sei->lpParameters), - debugstr_a(sei->lpDirectory), sei->nShow, - (sei->fMask & SEE_MASK_CLASSNAME) ? debugstr_a(sei->lpClass) : "not used"); - - ZeroMemory(szApplicationName,MAX_PATH); - if (sei->lpFile) - strcpy(szApplicationName, sei->lpFile); - - ZeroMemory(szCommandline,MAX_PATH); - if (sei->lpParameters) - strcpy(szCommandline, sei->lpParameters); - - if (sei->fMask & (SEE_MASK_CLASSKEY | SEE_MASK_INVOKEIDLIST | SEE_MASK_ICON | SEE_MASK_HOTKEY | - SEE_MASK_CONNECTNETDRV | SEE_MASK_FLAG_DDEWAIT | - SEE_MASK_DOENVSUBST | SEE_MASK_FLAG_NO_UI | SEE_MASK_UNICODE | - SEE_MASK_NO_CONSOLE | SEE_MASK_ASYNCOK | SEE_MASK_HMONITOR )) - { - FIXME("flags ignored: 0x%08lx\n", sei->fMask); - } - - /* launch a document by fileclass like 'Wordpad.Document.1' */ - if (sei->fMask & SEE_MASK_CLASSNAME) - { - /* FIXME: szCommandline should not be of a fixed size. Plus MAX_PATH is way too short! */ - /* the commandline contains 'c:\Path\wordpad.exe "%1"' */ - HCR_GetExecuteCommand(sei->lpClass, (sei->lpVerb) ? sei->lpVerb : "open", szCommandline, sizeof(szCommandline)); - /* FIXME: get the extension of lpFile, check if it fits to the lpClass */ - TRACE("SEE_MASK_CLASSNAME->'%s'\n", szCommandline); - } - - /* process the IDList */ - if ( (sei->fMask & SEE_MASK_INVOKEIDLIST) == SEE_MASK_INVOKEIDLIST) /*0x0c*/ - { - SHGetPathFromIDListA (sei->lpIDList,szApplicationName); - TRACE("-- idlist=%p (%s)\n", sei->lpIDList, szApplicationName); - } - else - { - if (sei->fMask & SEE_MASK_IDLIST ) - { - pos = strstr(szCommandline, "%I"); - if (pos) - { - LPVOID pv; - HGLOBAL hmem = SHAllocShared ( sei->lpIDList, ILGetSize(sei->lpIDList), 0); - pv = SHLockShared(hmem,0); - sprintf(szPidl,":%p",pv ); - SHUnlockShared(pv); - - gap = strlen(szPidl); - len = strlen(pos)-2; - memmove(pos+gap,pos+2,len); - memcpy(pos,szPidl,gap); - - } - } - } - - TRACE("execute:'%s','%s'\n",szApplicationName, szCommandline); - - if (szCommandline[0]) { - strcat(szApplicationName, " "); - strcat(szApplicationName, szCommandline); - } - - ZeroMemory(&startup,sizeof(STARTUPINFOA)); - startup.cb = sizeof(STARTUPINFOA); - - if (! CreateProcessA(NULL, szApplicationName, - NULL, NULL, FALSE, 0, - NULL, sei->lpDirectory, - &startup, &info)) - { - BOOL failed = TRUE; - - if ((!sei->lpVerb)||(!strcasecmp(sei->lpVerb,"open"))) - { - LPSTR ext = PathFindExtensionA(szApplicationName); - CHAR key[1023]; - CHAR buffer[1023]; - CHAR cmdline[1023]; - DWORD size; - - sprintf(key,"Software\\Classes\\%s",ext); - size = 1023; - if (!RegQueryValueA(HKEY_LOCAL_MACHINE,key,buffer,&size)) - { - sprintf(key,"Software\\Classes\\%s\\shell\\%s\\command", buffer, - (sei->lpVerb)?sei->lpVerb:"open"); - size = 1023; - if (!RegQueryValueA(HKEY_LOCAL_MACHINE,key,buffer,&size)) - { - sprintf(cmdline,"%s \"%s\"",buffer,szApplicationName); - if (CreateProcessA(NULL,cmdline, NULL, NULL, FALSE, 0, - NULL, sei->lpDirectory, &startup, &info)) - failed = FALSE; - } - } - } - - if (failed) - { - sei->hInstApp = GetLastError(); - return FALSE; - } - } - - sei->hInstApp = 33; - - if(sei->fMask & SEE_MASK_NOCLOSEPROCESS) - sei->hProcess = info.hProcess; - else - CloseHandle( info.hProcess ); - CloseHandle( info.hThread ); - return TRUE; -} -/************************************************************************* - * ShellExecuteExW [SHELL32.293] - * - */ -BOOL WINAPI ShellExecuteExW (LPSHELLEXECUTEINFOW sei) -{ SHELLEXECUTEINFOA seiA; - DWORD ret; - - TRACE("%p\n", sei); - - memcpy(&seiA, sei, sizeof(SHELLEXECUTEINFOA)); - - if (sei->lpVerb) - seiA.lpVerb = HEAP_strdupWtoA( GetProcessHeap(), 0, sei->lpVerb); - - if (sei->lpFile) - seiA.lpFile = HEAP_strdupWtoA( GetProcessHeap(), 0, sei->lpFile); - - if (sei->lpParameters) - seiA.lpParameters = HEAP_strdupWtoA( GetProcessHeap(), 0, sei->lpParameters); - - if (sei->lpDirectory) - seiA.lpDirectory = HEAP_strdupWtoA( GetProcessHeap(), 0, sei->lpDirectory); - - if ((sei->fMask & SEE_MASK_CLASSNAME) && sei->lpClass) - seiA.lpClass = HEAP_strdupWtoA( GetProcessHeap(), 0, sei->lpClass); - else - seiA.lpClass = NULL; - - ret = ShellExecuteExA(&seiA); - - if (seiA.lpVerb) HeapFree( GetProcessHeap(), 0, (LPSTR) seiA.lpVerb ); - if (seiA.lpFile) HeapFree( GetProcessHeap(), 0, (LPSTR) seiA.lpFile ); - if (seiA.lpParameters) HeapFree( GetProcessHeap(), 0, (LPSTR) seiA.lpParameters ); - if (seiA.lpDirectory) HeapFree( GetProcessHeap(), 0, (LPSTR) seiA.lpDirectory ); - if (seiA.lpClass) HeapFree( GetProcessHeap(), 0, (LPSTR) seiA.lpClass ); - - return ret; -} static LPUNKNOWN SHELL32_IExplorerInterface=0; /************************************************************************* Index: dlls/shell32/shlexec.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/shlexec.c,v retrieving revision 1.3 diff -u -r1.3 shlexec.c --- dlls/shell32/shlexec.c 31 May 2002 23:25:52 -0000 1.3 +++ dlls/shell32/shlexec.c 23 Jul 2002 02:29:56 -0000 @@ -23,6 +23,7 @@ #include <stdlib.h> #include <string.h> +#include <stdio.h> #include <unistd.h> #include <ctype.h> #include <assert.h> @@ -30,6 +31,7 @@ #include "windef.h" #include "winerror.h" #include "winreg.h" +#include "heap.h" #include "shellapi.h" #include "shlobj.h" #include "shlwapi.h" @@ -37,6 +39,7 @@ #include "wine/winbase16.h" #include "shell32_main.h" +#include "undocshell.h" #include "wine/debug.h" @@ -45,16 +48,19 @@ /* this function is supposed to expand the escape sequences found in the registry * some diving reported that the following were used: * + %1, %2... seem to report to parameter of index N in ShellExecute pmts - + + %* seem to report to all parameter (or all remaining, ie after removing - * the already used %1 %2...) - * + %L seems to be %1 as long filename followed by the 8+3 variation - * + %l unknown - * + %S unknown - * + %I unknown + * %1 file + * %2 printer + * %3 driver + * %4 port + * %I adress of a global item ID (explorer switch /idlist) + * %L seems to be %1 as long filename followed by the 8+3 variation + * %S ??? + * %* all following parameters (see batfile) */ -static void argify(char* res, int len, const char* fmt, const char* lpFile) +static BOOL argify(char* res, int len, const char* fmt, const char* lpFile) { char xlpFile[1024]; + BOOL done = FALSE; while (*fmt) { @@ -67,25 +73,71 @@ *res++ = '%'; break; case '1': - if (SearchPathA(NULL, lpFile, ".exe", sizeof(xlpFile), xlpFile, NULL)) + case '*': + if (!done || (*fmt == '1')) { - strcpy(res, xlpFile); - res += strlen(xlpFile); - } - else - { - strcpy(res, lpFile); - res += strlen(lpFile); + if (SearchPathA(NULL, lpFile, ".exe", sizeof(xlpFile), xlpFile, NULL)) + { + strcpy(res, xlpFile); + res += strlen(xlpFile); + } + else + { + strcpy(res, lpFile); + res += strlen(lpFile); + } } break; default: FIXME("Unknown escape sequence %%%c\n", *fmt); } fmt++; + done = TRUE; } else *res++ = *fmt++; } *res = '\0'; + return done; +} + +/************************************************************************* + * SHELL_ExecuteA [Internal] + * + */ +static HINSTANCE SHELL_ExecuteA(char *lpCmd, LPSHELLEXECUTEINFOA sei, BOOL is32) +{ + STARTUPINFOA startup; + PROCESS_INFORMATION info; + HINSTANCE retval = 31; + + TRACE("Execute %s from directory %s\n", lpCmd, sei->lpDirectory); + ZeroMemory(&startup,sizeof(STARTUPINFOA)); + startup.cb = sizeof(STARTUPINFOA); + startup.dwFlags = STARTF_USESHOWWINDOW; + startup.wShowWindow = sei->nShow; + if (is32) + { + if (CreateProcessA(NULL, lpCmd, NULL, NULL, FALSE, 0, + NULL, sei->lpDirectory, &startup, &info)) + { + retval = (HINSTANCE)33; + if(sei->fMask & SEE_MASK_NOCLOSEPROCESS) + sei->hProcess = info.hProcess; + else + CloseHandle( info.hProcess ); + CloseHandle( info.hThread ); + } + else if ((retval = GetLastError()) >= (HINSTANCE)32) + { + FIXME("Strange error set by CreateProcess: %d\n", retval); + retval = (HINSTANCE)ERROR_BAD_FORMAT; + } + } + else + retval = WinExec16(lpCmd, sei->nShow); + + sei->hInstApp = retval; + return retval; } /************************************************************************* @@ -102,7 +154,7 @@ * command (it'll be used afterwards for more information * on the operation) */ -static HINSTANCE SHELL_FindExecutable(LPCSTR lpFile, LPCSTR lpOperation, +static HINSTANCE SHELL_FindExecutable(LPCSTR lpPath, LPCSTR lpFile, LPCSTR lpOperation, LPSTR lpResult, LPSTR key) { char *extension = NULL; /* pointer to file extension */ @@ -129,7 +181,7 @@ return 2; /* File not found. Close enough, I guess. */ } - if (SearchPathA(NULL, lpFile, ".exe", sizeof(xlpFile), xlpFile, NULL)) + if (SearchPathA(lpPath, lpFile, ".exe", sizeof(xlpFile), xlpFile, NULL)) { TRACE("SearchPathA returned non-zero\n"); lpFile = xlpFile; @@ -287,7 +339,7 @@ */ static unsigned dde_connect(char* key, char* start, char* ddeexec, const char* lpFile, - int iCmdShow, BOOL is32) + LPSHELLEXECUTEINFOA sei, BOOL is32) { char* endkey = key + strlen(key); char app[256], topic[256], ifexec[256], res[256]; @@ -327,7 +379,7 @@ if (!hConv) { TRACE("Launching '%s'\n", start); - ret = (is32) ? WinExec(start, iCmdShow) : WinExec16(start, iCmdShow); + ret = SHELL_ExecuteA(start, sei, is32); if (ret < 32) { TRACE("Couldn't launch\n"); @@ -358,7 +410,10 @@ return ret; } -static HINSTANCE execute_from_key(LPSTR key, LPCSTR lpFile, INT iShowCmd, BOOL is32) +/************************************************************************* + * execute_from_key [Internal] + */ +static HINSTANCE execute_from_key(LPSTR key, LPCSTR lpFile, LPSHELLEXECUTEINFOA sei, BOOL is32) { char cmd[1024] = ""; LONG cmdlen = sizeof(cmd); @@ -380,15 +435,14 @@ if (RegQueryValueA(HKEY_CLASSES_ROOT, key, param, &paramlen) == ERROR_SUCCESS) { TRACE("Got ddeexec %s => %s\n", key, param); - retval = dde_connect(key, cmd, param, lpFile, iShowCmd, is32); + retval = dde_connect(key, cmd, param, lpFile, sei, is32); } else { /* Is there a replace() function anywhere? */ cmd[cmdlen] = '\0'; argify(param, sizeof(param), cmd, lpFile); - - retval = (is32) ? WinExec(param, iShowCmd) : WinExec16(param, iShowCmd); + retval = SHELL_ExecuteA(param, sei, is32); } } else TRACE("ooch\n"); @@ -396,96 +450,6 @@ return retval; } -static HINSTANCE SHELL_Execute(HWND hWnd, LPCSTR lpOperation, LPCSTR lpFile, - LPCSTR lpParameters, LPCSTR lpDirectory, - INT iShowCmd, BOOL is32) -{ - HINSTANCE retval = 31; - char old_dir[1024]; - char cmd[1024]; - - TRACE("(%04x,'%s','%s','%s','%s',%x)\n", - hWnd, lpOperation ? lpOperation:"<null>", lpFile ? lpFile:"<null>", - lpParameters ? lpParameters : "<null>", - lpDirectory ? lpDirectory : "<null>", iShowCmd); - - if (lpFile == NULL) return 0; /* should not happen */ - if (lpOperation == NULL) /* default is open */ - lpOperation = "open"; - - if (lpDirectory) - { - GetCurrentDirectoryA(sizeof(old_dir), old_dir); - SetCurrentDirectoryA(lpDirectory); - } - - /* First try to execute lpFile with lpParameters directly */ - strcpy(cmd, lpFile); - if (lpParameters) - { - strcat(cmd, " "); - strcat(cmd, lpParameters); - } - - retval = (is32) ? WinExec(cmd, iShowCmd) : WinExec16(cmd, iShowCmd); - - /* Unable to execute lpFile directly - Check if we can match an application to lpFile */ - if (retval < 32) - { - char lpstrProtocol[256]; - - cmd[0] = '\0'; - retval = SHELL_FindExecutable(lpFile, lpOperation, cmd, lpstrProtocol); - - if (retval > 32) /* Found */ - { - TRACE("%s/%s => %s/%s\n", lpFile, lpOperation, cmd, lpstrProtocol); - if (*lpstrProtocol) - retval = execute_from_key(lpstrProtocol, lpFile, iShowCmd, is32); - else - retval = (is32) ? WinExec(cmd, iShowCmd) : WinExec16(cmd, iShowCmd); - } - else if (PathIsURLA((LPSTR)lpFile)) /* File not found, check for URL */ - { - LPSTR lpstrRes; - INT iSize; - - lpstrRes = strchr(lpFile, ':'); - iSize = lpstrRes - lpFile; - - TRACE("Got URL: %s\n", lpFile); - /* Looking for ...protocol\shell\lpOperation\command */ - strncpy(lpstrProtocol, lpFile, iSize); - lpstrProtocol[iSize] = '\0'; - strcat(lpstrProtocol, "\\shell\\"); - strcat(lpstrProtocol, lpOperation); - strcat(lpstrProtocol, "\\command"); - - /* Remove File Protocol from lpFile */ - /* In the case file://path/file */ - if (!strncasecmp(lpFile, "file", iSize)) - { - lpFile += iSize; - while (*lpFile == ':') lpFile++; - } - - retval = execute_from_key(lpstrProtocol, lpFile, iShowCmd, is32); - } - /* Check if file specified is in the form www.??????.*** */ - else if (!strncasecmp(lpFile, "www", 3)) - { - /* if so, append lpFile http:// and call ShellExecute */ - char lpstrTmpFile[256] = "http://" ; - strcat(lpstrTmpFile, lpFile); - retval = ShellExecuteA(hWnd, lpOperation, lpstrTmpFile, NULL, NULL, 0); - } - } - if (lpDirectory) - SetCurrentDirectoryA(old_dir); - return retval; -} - /************************************************************************* * FindExecutableA [SHELL32.@] */ @@ -512,7 +476,7 @@ SetCurrentDirectoryA(lpDirectory); } - retval = SHELL_FindExecutable(lpFile, "open", lpResult, NULL); + retval = SHELL_FindExecutable(lpDirectory, lpFile, "open", lpResult, NULL); TRACE("returning %s\n", lpResult); if (lpDirectory) @@ -530,14 +494,204 @@ } /************************************************************************* + * ShellExecuteExA32 [Internal] + */ +BOOL WINAPI ShellExecuteExA32 (LPSHELLEXECUTEINFOA sei, BOOL is32) +{ + CHAR szApplicationName[MAX_PATH],szCommandline[MAX_PATH],szPidl[20],fileName[MAX_PATH]; + LPSTR pos; + int gap, len; + char lpstrProtocol[256]; + LPCSTR lpFile,lpOperation; + HINSTANCE retval = 31; + char cmd[1024]; + BOOL done; + + TRACE("mask=0x%08lx hwnd=0x%04x verb=%s file=%s parm=%s dir=%s show=0x%08x class=%s\n", + sei->fMask, sei->hwnd, debugstr_a(sei->lpVerb), + debugstr_a(sei->lpFile), debugstr_a(sei->lpParameters), + debugstr_a(sei->lpDirectory), sei->nShow, + (sei->fMask & SEE_MASK_CLASSNAME) ? debugstr_a(sei->lpClass) : "not used"); + + sei->hProcess = (HANDLE)NULL; + ZeroMemory(szApplicationName,MAX_PATH); + if (sei->lpFile) + strcpy(szApplicationName, sei->lpFile); + + ZeroMemory(szCommandline,MAX_PATH); + if (sei->lpParameters) + strcpy(szCommandline, sei->lpParameters); + + if (sei->fMask & ((SEE_MASK_CLASSKEY & ~SEE_MASK_CLASSNAME) | + SEE_MASK_INVOKEIDLIST | SEE_MASK_ICON | SEE_MASK_HOTKEY | + SEE_MASK_CONNECTNETDRV | SEE_MASK_FLAG_DDEWAIT | + SEE_MASK_DOENVSUBST | SEE_MASK_FLAG_NO_UI | SEE_MASK_UNICODE | + SEE_MASK_NO_CONSOLE | SEE_MASK_ASYNCOK | SEE_MASK_HMONITOR )) + { + FIXME("flags ignored: 0x%08lx\n", sei->fMask); + } + + /* process the IDList */ + if ( (sei->fMask & SEE_MASK_INVOKEIDLIST) == SEE_MASK_INVOKEIDLIST) /*0x0c*/ + { + SHGetPathFromIDListA (sei->lpIDList,szApplicationName); + TRACE("-- idlist=%p (%s)\n", sei->lpIDList, szApplicationName); + } + else + { + if (sei->fMask & SEE_MASK_IDLIST ) + { + pos = strstr(szCommandline, "%I"); + if (pos) + { + LPVOID pv; + HGLOBAL hmem = SHAllocShared ( sei->lpIDList, ILGetSize(sei->lpIDList), 0); + pv = SHLockShared(hmem,0); + sprintf(szPidl,":%p",pv ); + SHUnlockShared(pv); + + gap = strlen(szPidl); + len = strlen(pos)-2; + memmove(pos+gap,pos+2,len); + memcpy(pos,szPidl,gap); + } + } + } + + if (sei->fMask & SEE_MASK_CLASSNAME) + { + /* launch a document by fileclass like 'WordPad.Document.1' */ + /* the Commandline contains 'c:\Path\wordpad.exe "%1"' */ + /* FIXME: szCommandline should not be of a fixed size. Plus MAX_PATH is way too short! */ + HCR_GetExecuteCommand(sei->lpClass, (sei->lpVerb) ? sei->lpVerb : "open", szCommandline, sizeof(szCommandline)); + /* FIXME: get the extension of lpFile, check if it fits to the lpClass */ + TRACE("SEE_MASK_CLASSNAME->'%s', doc->'%s'\n", szCommandline, szApplicationName); + + cmd[0] = '\0'; + done = argify(cmd, sizeof(cmd), szCommandline, szApplicationName); + if (!done && szApplicationName[0]) + { + strcat(cmd, " "); + strcat(cmd, szApplicationName); + } + retval = SHELL_ExecuteA(cmd, sei, is32); + if (retval > 32) + return TRUE; + else + return FALSE; + } + + /* We set the default to open, and that should generally work. + But that is not really the way the MS docs say to do it. */ + if (sei->lpVerb == NULL) + lpOperation = "open"; + else + lpOperation = sei->lpVerb; + + /* Else, try to execute the filename */ + TRACE("execute:'%s','%s'\n",szApplicationName, szCommandline); + + strcpy(fileName, szApplicationName); + lpFile = fileName; + if (szCommandline[0]) { + strcat(szApplicationName, " "); + strcat(szApplicationName, szCommandline); + } + + retval = SHELL_ExecuteA(szApplicationName, sei, is32); + if (retval > 32) + return TRUE; + + /* Else, try to find the executable */ + cmd[0] = '\0'; + retval = SHELL_FindExecutable(sei->lpDirectory, lpFile, lpOperation, cmd, lpstrProtocol); + if (retval > 32) /* Found */ + { + if (szCommandline[0]) { + strcat(cmd, " "); + strcat(cmd, szCommandline); + } + TRACE("%s/%s => %s/%s\n", szApplicationName, lpOperation, cmd, lpstrProtocol); + if (*lpstrProtocol) + retval = execute_from_key(lpstrProtocol, szApplicationName, sei, is32); + else + retval = SHELL_ExecuteA(cmd, sei, is32); + } + else if (PathIsURLA((LPSTR)lpFile)) /* File not found, check for URL */ + { + LPSTR lpstrRes; + INT iSize; + + lpstrRes = strchr(lpFile, ':'); + /* PathIsURLA probably should fail on strings without a ':', but it doesn't */ + if (lpstrRes) + iSize = lpstrRes - lpFile; + else + iSize = strlen(lpFile); + + TRACE("Got URL: %s\n", lpFile); + /* Looking for ...protocol\shell\lpOperation\command */ + strncpy(lpstrProtocol, lpFile, iSize); + lpstrProtocol[iSize] = '\0'; + strcat(lpstrProtocol, "\\shell\\"); + strcat(lpstrProtocol, lpOperation); + strcat(lpstrProtocol, "\\command"); + + /* Remove File Protocol from lpFile */ + /* In the case file://path/file */ + if (!strncasecmp(lpFile, "file", iSize)) + { + lpFile += iSize; + while (*lpFile == ':') lpFile++; + } + retval = execute_from_key(lpstrProtocol, lpFile, sei, is32); + } + /* Check if file specified is in the form www.??????.*** */ + else if (!strncasecmp(lpFile, "www", 3)) + { + /* if so, append lpFile http:// and call ShellExecute */ + char lpstrTmpFile[256] = "http://" ; + strcat(lpstrTmpFile, lpFile); + retval = ShellExecuteA(sei->hwnd, lpOperation, lpstrTmpFile, NULL, NULL, 0); + } + + if (retval <= 32) + { + sei->hInstApp = retval; + return FALSE; + } + + sei->hInstApp = 33; + return TRUE; +} + + +/************************************************************************* * ShellExecute [SHELL.20] */ HINSTANCE16 WINAPI ShellExecute16( HWND16 hWnd, LPCSTR lpOperation, LPCSTR lpFile, LPCSTR lpParameters, LPCSTR lpDirectory, INT16 iShowCmd ) { - return (HINSTANCE16)SHELL_Execute(hWnd, lpOperation, lpFile, - lpParameters, lpDirectory, iShowCmd, FALSE ); + SHELLEXECUTEINFOA sei; + HANDLE hProcess = 0; + + sei.cbSize = sizeof(sei); + sei.fMask = 0; + sei.hwnd = hWnd; + sei.lpVerb = lpOperation; + sei.lpFile = lpFile; + sei.lpParameters = lpParameters; + sei.lpDirectory = lpDirectory; + sei.nShow = iShowCmd; + sei.lpIDList = 0; + sei.lpClass = 0; + sei.hkeyClass = 0; + sei.dwHotKey = 0; + sei.hProcess = hProcess; + + ShellExecuteExA32 (&sei, FALSE); + return (HINSTANCE16)sei.hInstApp; } /************************************************************************* @@ -546,9 +700,87 @@ HINSTANCE WINAPI ShellExecuteA(HWND hWnd, LPCSTR lpOperation,LPCSTR lpFile, LPCSTR lpParameters,LPCSTR lpDirectory, INT iShowCmd) { + SHELLEXECUTEINFOA sei; + HANDLE hProcess = 0; + TRACE("\n"); - return SHELL_Execute( hWnd, lpOperation, lpFile, lpParameters, - lpDirectory, iShowCmd, TRUE ); + sei.cbSize = sizeof(sei); + sei.fMask = 0; + sei.hwnd = hWnd; + sei.lpVerb = lpOperation; + sei.lpFile = lpFile; + sei.lpParameters = lpParameters; + sei.lpDirectory = lpDirectory; + sei.nShow = iShowCmd; + sei.lpIDList = 0; + sei.lpClass = 0; + sei.hkeyClass = 0; + sei.dwHotKey = 0; + sei.hProcess = hProcess; + + ShellExecuteExA32 (&sei, TRUE); + return sei.hInstApp; +} + +/************************************************************************* + * ShellExecuteEx [SHELL32.291] + * + */ +BOOL WINAPI ShellExecuteExAW (LPVOID sei) +{ + if (SHELL_OsIsUnicode()) + return ShellExecuteExW (sei); + return ShellExecuteExA32 (sei, TRUE); +} + +/************************************************************************* + * ShellExecuteExA [SHELL32.292] + * + */ +BOOL WINAPI ShellExecuteExA (LPSHELLEXECUTEINFOA sei) +{ + return ShellExecuteExA32 (sei, TRUE); +} + +/************************************************************************* + * ShellExecuteExW [SHELL32.293] + * + */ +BOOL WINAPI ShellExecuteExW (LPSHELLEXECUTEINFOW sei) +{ + SHELLEXECUTEINFOA seiA; + DWORD ret; + + TRACE("%p\n", sei); + + memcpy(&seiA, sei, sizeof(SHELLEXECUTEINFOA)); + + if (sei->lpVerb) + seiA.lpVerb = HEAP_strdupWtoA( GetProcessHeap(), 0, sei->lpVerb); + + if (sei->lpFile) + seiA.lpFile = HEAP_strdupWtoA( GetProcessHeap(), 0, sei->lpFile); + + if (sei->lpParameters) + seiA.lpParameters = HEAP_strdupWtoA( GetProcessHeap(), 0, sei->lpParameters); + + if (sei->lpDirectory) + seiA.lpDirectory = HEAP_strdupWtoA( GetProcessHeap(), 0, sei->lpDirectory); + + if ((sei->fMask & SEE_MASK_CLASSNAME) && sei->lpClass) + seiA.lpClass = HEAP_strdupWtoA( GetProcessHeap(), 0, sei->lpClass); + else + seiA.lpClass = NULL; + + ret = ShellExecuteExA(&seiA); + + if (seiA.lpVerb) HeapFree( GetProcessHeap(), 0, (LPSTR) seiA.lpVerb ); + if (seiA.lpFile) HeapFree( GetProcessHeap(), 0, (LPSTR) seiA.lpFile ); + if (seiA.lpParameters) HeapFree( GetProcessHeap(), 0, (LPSTR) seiA.lpParameters ); + if (seiA.lpDirectory) HeapFree( GetProcessHeap(), 0, (LPSTR) seiA.lpDirectory ); + if (seiA.lpClass) HeapFree( GetProcessHeap(), 0, (LPSTR) seiA.lpClass ); + + return ret; } /************************************************************************* @@ -560,7 +792,25 @@ HINSTANCE WINAPI ShellExecuteW(HWND hwnd, LPCWSTR lpOperation, LPCWSTR lpFile, LPCWSTR lpParameters, LPCWSTR lpDirectory, INT nShowCmd) { - FIXME(": stub\n"); - return 0; + SHELLEXECUTEINFOW sei; + HANDLE hProcess = 0; + + TRACE("\n"); + sei.cbSize = sizeof(sei); + sei.fMask = 0; + sei.hwnd = hwnd; + sei.lpVerb = lpOperation; + sei.lpFile = lpFile; + sei.lpParameters = lpParameters; + sei.lpDirectory = lpDirectory; + sei.nShow = nShowCmd; + sei.lpIDList = 0; + sei.lpClass = 0; + sei.hkeyClass = 0; + sei.dwHotKey = 0; + sei.hProcess = hProcess; + + ShellExecuteExW (&sei); + return sei.hInstApp; }

1 0

[Q] CreateProcess for Batch files
by Uwe Bonnes 23 Jul '02

23 Jul '02

Hallo, the Xilix Webpack Flow in one case tries to create a process with a batch file as argument: 09846d58:Call kernel32.CreateProcessA(00000000,403efee8 "ChipView.bat -f adcswitch.ngd -uc adcswitch.ucf -dev XC2C256-7-TQ144",00000000,00000000,00000001,00000000,00000000,00000000,405e6444,405e6434) ret=40605429 09846d58:Ret kernel32.CreateProcessA() retval=00000000 ret=406054290 What is a good way to implement batch handling in wine? Start wcmd and hand itthe batch file name and arguments? Expand and handle it in scheduler/process.c? Comments welcome! Btw: This Chipview batch file only expands environment variables, sets library pathes and calls java. I tried to use the native linux jre, but the programm put up a message that it couldn't read some file, which is obvious there. %XILINX%\java\nt\jre1.2.2\bin\java -mx64m -ss4M -classpath ".;%XILINX%\chipviewer\lib\ChipViewer.jar;%XILINX%\chipviewer\lib\jaxp.jar;%XILINX%\chipviewer\lib\parser.jar;%XILINX%\java\nt\jre1.2.2\lib\rt.jar"com.xilinx.chipviewer.pgms.main.ChipViewer -XILINX %XILINX% %1 %2 %3 %4 %5 %6 Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 2

Double DECL_GLOBAL_CONSTRUCTOR in latest CVS
by Uwe Bonnes 22 Jul '02

22 Jul '02

Hallo, copiling a recent CVS, I got: gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall -mpreferred-stack-boundary=2 -fPIC -D__WINE__ -D_REENTRANT -I/usr/X11R6/include -o mouse/main.o mouse/main.c mouse/main.c:217: warning: `mousedev' defined but not used ld -r device.o dinput_main.o joystick/linux.o joystick/linuxinput.o keyboard/main.o mouse/main.o -o dinput.dll.tmp.o keyboard/main.o: In function `DECL_GLOBAL_CONSTRUCTOR': /home/bon/tmp/wine/compile/wine/dlls/dinput/keyboard/main.c(.text+0x380): multiple definition of `DECL_GLOBAL_CONSTRUCTOR' joystick/linuxinput.o(.text+0x550):/home/bon/tmp/wine/compile/wine/dlls/dinput/joystick/linuxinput.c: first defined here make: *** [dinput.dll.tmp.o] Fehler 1 Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

China developing Windows clone
by Roland 22 Jul '02

22 Jul '02

Did you read this: http://slashdot.org/article.pl?sid=02/07/19/2116234&mode=thread&tid=99 Are they using WINE? Do they know about WINE? It sure would help if they work on the WINE source base :) Roland

2 1

Re: PATCH: SetParent optimization
by Alexandre Julliard 22 Jul '02

22 Jul '02

Marcus Meissner <meissner(a)suse.de> writes: > Lotus Notes R5 5.0.10 has a Details Popup Window which stays over the > normal Lotus window usually. > > If it is started and the focus leaves this window, Lotus reparents > to the toplevel window, using "SetWindowLong(hwnd, GWL_HWNDPARENT, > toplevelhwnd);" and later does "BringWindowToTop(toplevelhwnd);". Probably SetWindowLong(GWL_HWNDPARENT) should not do a full SetParent, but just set the window owner. Looks like this needs more testing under Windows to find out exactly what it's supposed to do. -- Alexandre Julliard julliard(a)winehq.com

2 1

Put WINE into the donation directory?
by Roland 22 Jul '02

22 Jul '02

Here is an open source donation directory: http://slashdot.org/articles/02/07/21/1813204.shtml?tid=117 How about adding WINE into it? Roland

1 0

Winsock 2 functions
by Peter Lord 22 Jul '02

22 Jul '02

I'm trying to get a java application running under wine. Amazingly (at least to me :-) ), the application gets a fair way through loading lots of classes as it goes. But, the stumbling block is when the application starts to use network operations, specifically WPUCompleteOverlappedRequest and WSAAddressToStringA. Right now, these are unimplimented and the java app crashes when trying to call them. Before I start looking into these in more detail (I've really no idea what overlapped I/O is all about ...), does anyone plan to implement these in the near future ? Oh, BTW, before you ask... the java app loads a native windows dll as part of its functionality, so I can't use the Linux jvm :-( Cheers, Pete

2 2

Re: Resent: Partial PeekNamedPipe Implementation
by Alexandre Julliard 22 Jul '02

22 Jul '02

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > wine/server/pipe.c, wine/server/named_pipe.c: xxx_get_info > Return the number of bytes available for reading > wine/dlls/kernel/sync.c: PeekNamedPipe > Use get_file_info to get the number of bytes available for reading I don't think it's a good idea to overload get_file_info that way. You should retrieve the pipe file descriptor and do the FIONREAD on the client side. We will need the file descriptor anyway to implement the full peek functionality. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: Errors running winapi_extract --stub-statistics
by Patrik Stridvall 22 Jul '02

22 Jul '02

> I think this is because the module name is no longer in the > .spec file. Lines > 71-73 of winapi_extract look for "name" in the .spec file, > which no longer > exists. Should we be using the file name as the module name? Correct. Patch for this and other problem with winapi_extract coming soon.

4 3

Re: Makedll.rules.in
by Gregg Mattinson 22 Jul '02

22 Jul '02

Oops.. This patch fixes the linking of tests, but it breaks..well..all the .dlls, atleast for me. So, my question is, why does the $(MODULE).so rule in Makedll.rules.in contain $(LDDLLFLAGS)? Until I submitted this patch, that variable was not defined in the makefiles for the .dlls, and the dlls appeared to work fine. Now that this flag is defined, the .dlls don't work, but the tests do work. Should LDDLLFLAGS be removed from the $(MODULE).so rule? What is LDDLLFLAGS defined to on Linux? I only have a Solaris box here to test on, so my insight into the problem is limited. Any insight would be appreciated. Thanks, Gregg >From: Gregg Mattinson <gm138242(a)opcom-mail.canada.sun.com> >Subject: Makedll.rules.in >To: wine-patches(a)winehq.com >Date: Fri, 19 Jul 2002 10:39:22 -0400 (EDT) > >Changelog: dlls/Makedll.rules.in > - Added LDDLLFLAGS to Makedll.rules.in so that tests get linked properly > >Gregg Mattinson >Co-op Developer >Sun Microsystems of Canada

2 1

Broken forwards in .spec files
by Patrik Stridvall 22 Jul '02

22 Jul '02

When I, with the help of Francois, fixed the statistics for forwarded functions in winapi_extract I notice that a few of the forwards in the .spec files are broken. winapi_check now checks for broken forward when it is run. However I'm not sure how the broken forwards are best fixed, so what I why I'm asking for people on the list with the appropriete knowledge to fix them. crtdll.spec: forward is broken: _strdec => msvcrt._strdec crtdll.spec: forward is broken: _strinc => msvcrt._strinc crtdll.spec: forward is broken: _strncnt => msvcrt._strncnt crtdll.spec: forward is broken: _strnextc => msvcrt._strnextc crtdll.spec: forward is broken: _strninc => msvcrt._strninc crtdll.spec: forward is broken: _strspnp => msvcrt._strspnp msvcrt20.spec: forward is broken: __seh_longjmp_unwind@4 => msvcrt.__seh_longjmp_unwind msvcrt20.spec: forward is broken: _mtlock => msvcrt._mtlock msvcrt20.spec: forward is broken: _mtunlock => msvcrt._mtunlock msvcrt20.spec: forward is broken: _tccpy => msvcrt._tccpy msvcrt20.spec: forward is broken: _tclen => msvcrt._tclen msvcrt20.spec: forward is broken: _tcschr => msvcrt._tcschr msvcrt20.spec: forward is broken: _tcsclen => msvcrt._tcsclen msvcrt20.spec: forward is broken: _tcscmp => msvcrt._tcscmp msvcrt20.spec: forward is broken: _tcscspn => msvcrt._tcscspn msvcrt20.spec: forward is broken: _tcsdec => msvcrt._tcsdec msvcrt20.spec: forward is broken: _tcsicmp => msvcrt._tcsicmp msvcrt20.spec: forward is broken: _tcsinc => msvcrt._tcsinc msvcrt20.spec: forward is broken: _tcslwr => msvcrt._tcslwr msvcrt20.spec: forward is broken: _tcsnbcnt => msvcrt._tcsnbcnt msvcrt20.spec: forward is broken: _tcsncat => msvcrt._tcsncat msvcrt20.spec: forward is broken: _tcsnccat => msvcrt._tcsnccat msvcrt20.spec: forward is broken: _tcsnccmp => msvcrt._tcsnccmp msvcrt20.spec: forward is broken: _tcsnccnt => msvcrt._tcsnccnt msvcrt20.spec: forward is broken: _tcsnccpy => msvcrt._tcsnccpy msvcrt20.spec: forward is broken: _tcsncicmp => msvcrt._tcsncicmp msvcrt20.spec: forward is broken: _tcsncmp => msvcrt._tcsncmp msvcrt20.spec: forward is broken: _tcsncpy => msvcrt._tcsncpy msvcrt20.spec: forward is broken: _tcsncset => msvcrt._tcsncset msvcrt20.spec: forward is broken: _tcsnextc => msvcrt._tcsnextc msvcrt20.spec: forward is broken: _tcsnicmp => msvcrt._tcsnicmp msvcrt20.spec: forward is broken: _tcsninc => msvcrt._tcsninc msvcrt20.spec: forward is broken: _tcsnset => msvcrt._tcsnset msvcrt20.spec: forward is broken: _tcspbrk => msvcrt._tcspbrk msvcrt20.spec: forward is broken: _tcsrchr => msvcrt._tcsrchr msvcrt20.spec: forward is broken: _tcsrev => msvcrt._tcsrev msvcrt20.spec: forward is broken: _tcsset => msvcrt._tcsset msvcrt20.spec: forward is broken: _tcsspn => msvcrt._tcsspn msvcrt20.spec: forward is broken: _tcsspnp => msvcrt._tcsspnp msvcrt20.spec: forward is broken: _tcsstr => msvcrt._tcsstr msvcrt20.spec: forward is broken: _tcstok => msvcrt._tcstok msvcrt20.spec: forward is broken: _tcsupr => msvcrt._tcsupr shell32.spec: forward is broken: StrNCpyW => shlwapi.StrNCpyW

1 0

RE: regsvr32 with multiple arguments
by Medland, Bill 22 Jul '02

22 Jul '02

> -----Original Message----- > From: Andriy Palamarchuk [mailto:apa3a@yahoo.com] > Sent: Monday, July 22, 2002 7:41 AM > To: Medland, Bill; Wine devel (E-mail) > Subject: Re: regsvr32 with multiple arguments > > > > --- "Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > > Did I miss something? > > > > Yesterday when I ran regsvr32 with multiple > > arguments it registered each > > one. Today it only registers the first. Yesterday > > it popped up a > > MessageBox with the result; today it puts the result > > on stdout. > > > > Does this make sense to anyone? > > Yes, the day before you used the native one, now you > are using the built-in. And didn't I feel a fool when I looked at the code and realised it (when I got home) > Thanks for the patch. My pleasure. > > Andriy > > __________________________________________________ > Do You Yahoo!? > Yahoo! Health - Feel better, live better > http://health.yahoo.com > Bill

1 0

Bug 434 Update/shot in the dark
by Rick Romero 22 Jul '02

22 Jul '02

Referring to bug: http://bugs.winehq.com/show_bug.cgi?id=434 Under normal circumstances the mouse button doesn't get released in certain applications. These include, Macromedial Flash 5, MS Visual Foxpro 5/6, and Adobe Illustrator 8. I'm working with FoxPro 5. (I have a demo app in the bug report) In *MY* testing, I've noticed that the following command allows the mouse button to be released. wine --debugmsg +scroll,+event,+toolbar,+gdi,+heap vfp.exe If, while running under this command, I _hold_ the mouse button down - longer than a 'click', it will not be released. This seems like a timing issue to me, and started after functions were moved into the wineserver. Not that I know anything about how Wine is setup, but could the 'buttonup' be 'lost', or sent out of sequence, causing it to not be executed? And that sequence is slowed by the debug message enough, that a longer 'buttondown' duration is needed before the bug shows up? Where would be the best place to insert a delay, or extend the timing for a single click (So only the mouseclick function is 'slowed')? I'm sure this isn't the best bug report ever sent, but any suggestions would be appreciated. ;) Rick -- -- Rick Romero IT Manager Valeo, Inc. ph: 262.695.4841 Sussex, WI. fax: 262.695.4850 Rick(a)valeoinc.com

1 0

regsvr32 with multiple arguments
by Medland, Bill 22 Jul '02

22 Jul '02

Did I miss something? Yesterday when I ran regsvr32 with multiple arguments it registered each one. Today it only registers the first. Yesterday it popped up a MessageBox with the result; today it puts the result on stdout. Does this make sense to anyone? Bill

2 1

Re: [Bug 889] - WINPOS_GetWinOffset() yields wrong offset
by Uwe Bonnes 22 Jul '02

22 Jul '02

>>>>> "wine-bugs" == wine-bugs <wine-bugs(a)winehq.com> writes: wine-bugs> http://bugs.winehq.com/show_bug.cgi?id=889 ------- Additional wine-bugs> Comments From tony_lambregts(a)telusplanet.net 2002-07-21 09:59 wine-bugs> ------- I am not that familiar with wine internals either, wine-bugs> but if you submit a patch to wine_patches(a)winehq.com, I'm wine-bugs> sure that if there is something wrong with it someone will wine-bugs> point it out. No, it happens that patches get silently dropped... Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 3

configure broken
by Gerald Pfeifer 22 Jul '02

22 Jul '02

The following patch has broken configure revision 1.320 date: 2002/07/19 03:16:51; author: julliard; state: Exp; lines: +210 -80 Gregg Mattinson <gm138242(a)scot.canada.sun.com> - X11/extensions/shape.h requires X11/Xutil.h. - X11/XKBlib.h requires X11/Xlib.h. - net/if.h requires sys/socket.h. - netinet/ip.h requires sys/socket.h and sys/in_systm.h. - resolv.h requires sys/socket.h. which now fails to properly set HAVE_NET_IF_H on FreeBSD 4.6, even though there we *do* have /usr/include/sys/socket.h. This is, because on BSD one must not #include <sys/socket.h> without having #included <sys/types.h> before. Something like the following should fix this problem: Index: configure.ac =================================================================== RCS file: /home/wine/wine/configure.ac,v retrieving revision 1.61 diff -u -3 -p -r1.61 configure.ac --- configure.ac 20 Jul 2002 20:17:13 -0000 1.61 +++ configure.ac 22 Jul 2002 06:58:49 -0000 @@ -983,7 +983,10 @@ AC_HEADER_STAT() dnl *** Check for net/if.h AC_CHECK_HEADERS(net/if.h,,, - [#if HAVE_SYS_SOCKET_H + [#if HAVE_SYS_TYPES_H + # include <sys/types.h> + #endif + #if HAVE_SYS_SOCKET_H # include <sys/socket.h> #endif]) Gerald

1 0

Re: Warcraft 3 : success and woes ( part 2 )
by Mark Hannessen 21 Jul '02

21 Jul '02

on Sat, 20 Jul 2002 10:08:15 Jesse Allen Wrote: > The attachment seems to not have gotten to the list (yet?) > Could you send directly to me? The one with the diffed registry. Can't you just just "cut paste" it into a mail and send it to the mailinglist? I'd love to try it too ! ( and i guess many more ) Mark Hannessen

1 0

Re:IE 5.01 setup cant download? [ie5setup.exe]
by Sylvain Petreolle 21 Jul '02

21 Jul '02

see wine bug #626 (http://bugs.winehq.com/show_bug.cgi?id=626) or at appdb #25 (http://appdb.winehq.com/appview.php?appId=25) ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

1 0

WINPOS_GetWinOffset (Better Patch)
by Anthony Tuininga 21 Jul '02

21 Jul '02

With respect to this bug (#889) I followed the trail a little bit further as I noticed that "hot spots" on an image (like buttons) would fade in and out when the window wasn't at the top left of the screen. The trail led to the file dlls/x11drv/winpos.c. It is making a call to MapWindowPoints() which in turn calls WINPOS_GetWinOffset(). If I eliminate the call to MapWindowPoints() in the function expose_window() at line 290, (and restore the original version of windows/winpos.c) everything works beautifully. The window draws itself properly and the buttons work as expected. I am not all that familiar with Wine code, though, so can anyone think of a good reason why this code ought to be there? Should I submit a patch? And if so, can anyone point me to the method required for doing so? Thanks. Anthony

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel