wine-devel

wine-devel@winehq.org

2 participants
84470 discussions

Re: Avoid crash
by P. Christeas 16 Jul '02

16 Jul '02

Dominik Strasser wrote: > I had a crash where This->pTypeInfo was 0. > I didn't investigate the real culprit. > > Changelog: avoid crash on NULL pointer I read your patch; I didn't investigate it either. I think you should put the test inside the ITypeInfo_Release() fn. Your patch may solve this case, but what happens when that fn is mis-called from somewhere else? This is a general matter of programming style. Moreover, you could add some TRACE or warning point. There was a conversation on what to do in such cases (where we could handle a NULL, but M$ may not). I suggest: warn and try to go on..

1 0

Re: SHLWAPI ole32 (delay-load of dlls)
by juergen.schmied＠debitel.net 16 Jul '02

16 Jul '02

The LoadLibrary call comes from the implementation of DelayLoad ;-). ------------x8----------- http://www.microsoft.com/MSJ/1298/win32/win321298.htm When the application runs, a call to a delay-loaded function actually calls the __delayLoadHelper function instead. This function references the special table I mentioned previously, and knows to call LoadLibrary followed by GetProcAddress. Once the address of the delay-loaded function is obtained, __delayLoadHelper fixes up calls to this function so that future calls go directly to the delay-loaded function. Note that other functions in the same DLL will still have to be fixed up the first time you call them. Also, you can specify the /DelayLoad linker switch multiple times, once for every DLL that you want to delay-load. ------------x8----------- juergen Jon Griffiths <jon_p_griffiths(a)yahoo.com> schrieb: > Hi, > > The following (shortened) trace from native SHLWAPI v6 shows that > StrRetToBufA is implemented using LoadLibrary/GetProcAddress to call > CoTaskMemFree, even though ole32 is imported by this version. > > 08073b00:CALL xpshlwapi.790: StrRetToBufA(<unknown, check > return>08073b00 > 08073b00:Call kernel32.LoadLibraryA(70bf2c30 "ole32.dll") > ret=70c29f2a > 08073b00:Ret kernel32.LoadLibraryA() retval=40a99000 ret=70c29f2a > 08073b00:Call kernel32.GetProcAddress(40a99000,70c2a412 > "CoTaskMemFree") ret=70c2a027 > 08073b00:Call ole32.CoTaskMemFree(403979e0) ret=70bfa1e2 > 08073b00:Ret ole32.CoTaskMemFree() retval=00000001 ret=70bfa1e2 > 08073b00:RET xpshlwapi.790: > StrRetToBufA(405c6c3c,00000000,405c6d4c,00000100) retval = 00000000 > ret=4001d283 > > If you still want to link directly in this case, ignore the patch > "SHLWAPI ole32" and apply the one below instead. This one just > removes winreg.h from shlwapi_main.c. > > Cheers, > Jon >

2 1

Re: Bug Fix: WM_GETTEXT should return NULL string if LB_GETCURSEL is LB_ERR
by Carl Sopchak 16 Jul '02

16 Jul '02

On Monday, July 15, 2002 10:15 pm, wine-devel-request(a)winehq.com wrote: > > If VC does have a "one correct way", while gcc doesn't, shouldn't we > > prefer the VC correct one? > > No - you should the one that is in the C standard. > > > In this case '0' should be ok under ALL circumstances. > (Unless M$ have completely stuffed their compiler) > > > David I'd have to agree with David, that the code should work under all circumstances. So, should this be modified, and another patch submitted? I'd be happy to do that, if it makes life easier... (Reiterating: I'm no C guru, and I know less about unicode, so let me know "the best way", and I'll be happy to change it if needed...) Once again, the code in question: if (unicode) { LPWSTR lpText = (LPWSTR)lParam; lpText[0] = '\0'; } else { LPSTR lpText = (LPSTR)lParam; lpText[0] = '\0'; } return 0; Carl

1 0

Re: PATCH: [Bug 671] Valve Hammer Editor does not run - recursion in buddySupperClassWndProc
by Dimitrie O. Paun 16 Jul '02

16 Jul '02

On June 5, 2002 12:31 am, Guy L. Albertelli wrote: > Ok, the loop was due to constant setting of the buddy wndproc because the > retrieve of the wndproc did not match. The match failed because the > application > program added a wndproc (its own) to the buddy window. The fix will be > submitted to wine-patches. Hmm, I see. But with this fix, it means that you can not change the wndproc of the buddy once set. This can not be right... Also, you broke the UDM_SETBUDDY. I this the correct fix is to add the flag as a property on the buddy, not on the UpDown... -- Dimi.

3 2

Re: SHBrowseForFolderW
by Uwe Bonnes 16 Jul '02

16 Jul '02

>>>>> "Jon" == Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes: Jon> ChangeLog: Jon Griffiths <jon_p_griffiths(a)yahoo.com> Jon> +dlls/shell32/shell32.spec,dlls/shell32/brsfolder.c Implement Jon> SHBrowseForFolderW Where's the patch? :-) Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: __sparc__ not defined with Forte C
by Alexandre Julliard 16 Jul '02

16 Jul '02

Gregg Mattinson <gm138242(a)scot.canada.sun.com> writes: > ChangeLog: dlls/ntdll/signal_sparc.c include/basetsd.h > include/wine/port.h server/context_sparc.c > - __sparc__ is not defined with Forte C, but __sparc is defined with both Forte > and GCC. Same goes for __sun__ If __sparc and __sun work for all compilers we should use them everywhere, no need to try to support other forms. Otherwise it should be done with a configure test like we do for __i386__. > - Forte C doesn't like @function. Replaced it with 2. This needs a configure test. A #ifdef SUNPRO_C is almost always the wrong thing to do. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: About VirtualQueryEx hack
by Eric Pouech 15 Jul '02

15 Jul '02

> > I have a hack for VirtualQueryEx for Linux, but Alexandre will never > > accept it (but if someone needs it, I can provide it) > > May you post it to me ? cc'ing wine-devel if others are interested of course, it'll only work on linux (but it wouldn't be too hard to make it work on other OSes) (you need to run tools/make_request after applying the patch and before re-configuring and re-compiling) A+ Name: vqex ChangeLog: added implementation for VirtualQueryEx (linux only) License: X11 GenDate: 2002/07/15 18:59:12 UTC ModifiedFiles: memory/virtual.c server/Makefile.in server/protocol.def AddedFiles: server/virtual.c =================================================================== RCS file: /home/cvs/cvsroot/wine/wine/memory/virtual.c,v retrieving revision 1.80 diff -u -u -r1.80 virtual.c --- memory/virtual.c 3 Jul 2002 21:10:44 -0000 1.80 +++ memory/virtual.c 10 Jul 2002 21:46:31 -0000 @@ -1243,15 +1243,42 @@ * Number of bytes returned in information buffer */ DWORD WINAPI VirtualQueryEx( - HANDLE handle, /* [in] Handle of process */ - LPCVOID addr, /* [in] Address of region */ - LPMEMORY_BASIC_INFORMATION info, /* [out] Address of info buffer */ - DWORD len /* [in] Size of buffer */ ) + HANDLE handle, /* [in] Handle of process */ + LPCVOID addr, /* [in] Address of region */ + LPMEMORY_BASIC_INFORMATION pinfo, /* [out] Address of info buffer */ + DWORD len /* [in] Size of buffer */ ) { + int res; + MEMORY_BASIC_INFORMATION info; + if (MapProcessHandle( handle ) == GetCurrentProcessId()) - return VirtualQuery( addr, info, len ); - ERR("Unsupported on other process\n"); - return 0; + return VirtualQuery( addr, pinfo, len ); + + if (addr >= (void*)0xc0000000) return 0; + + SERVER_START_REQ( query_virtual_memory_info ) + { + req->handle = handle; + req->addr = ROUND_ADDR( addr, page_mask ); + + res = wine_server_call_err( req ); + if (!res) + { + info.State = reply->state; + info.Protect = VIRTUAL_Win32Flags[reply->protect]; + info.AllocationProtect = VIRTUAL_Win32Flags[reply->protect_other]; + info.Type = reply->type; + info.BaseAddress = reply->base_address; + info.AllocationBase = reply->alloc_base; + info.RegionSize = reply->size; + } + } + SERVER_END_REQ; + if (res) return 0; + + len = min(len, sizeof(info)); + memcpy(pinfo, &info, len); + return len; } Index: server/Makefile.in =================================================================== RCS file: /home/cvs/cvsroot/wine/wine/server/Makefile.in,v retrieving revision 1.33 diff -u -u -r1.33 Makefile.in --- server/Makefile.in 9 May 2002 04:31:40 -0000 1.33 +++ server/Makefile.in 14 Jul 2002 17:00:22 -0000 @@ -39,6 +39,7 @@ trace.c \ unicode.c \ user.c \ + virtual.c \ window.c PROGRAMS = wineserver Index: server/protocol.def =================================================================== RCS file: /home/cvs/cvsroot/wine/wine/server/protocol.def,v retrieving revision 1.39 diff -u -u -r1.39 protocol.def --- server/protocol.def 2 Jun 2002 21:22:22 -0000 1.39 +++ server/protocol.def 10 Jul 2002 21:44:11 -0000 @@ -1038,6 +1038,21 @@ @END +/* query a process virtual memory */ +@REQ(query_virtual_memory_info) + obj_handle_t handle; /* handle to the process */ + void* addr; /* address where to look at */ +@REPLY + int state; + int protect; + int protect_other; + int type; + void* base_address; + void* alloc_base; + int size; +@END + + /* Create a file mapping */ @REQ(create_mapping) int size_high; /* mapping size */ --- /dev/null Thu Jan 1 01:00:00 1970 +++ server/virtual.c Wed Jul 10 23:31:31 2002 @@ -0,0 +1,103 @@ +#include "config.h" +#include "wine/port.h" + +#include <assert.h> +#include <stdio.h> +#include <stdlib.h> +#include <unistd.h> + +#include "process.h" +#include "request.h" + +static void query_virtual_memory_info(struct process* process, unsigned base, + struct query_virtual_memory_info_reply* reply) +{ + char buffer[MAX_PATH]; + FILE* file = NULL; + unsigned alloc_base = 0; + unsigned size = 0; + unsigned start, end; + unsigned vprot; + +#ifdef linux + if (process->thread_list) + { + sprintf(buffer, "/proc/%d/maps", process->thread_list->unix_pid); + file = fopen(buffer, "r"); + } +#endif + if (!file) + { + set_error(STATUS_NOT_SUPPORTED); + return; + } + + while (fgets(buffer, sizeof(buffer) - 1, file)) + { +#ifdef linux + char prot[5]; + unsigned shift, minor, major; + /* 407ac000-407ae000 rw-p 00007000 */ + + if (sscanf(buffer, "%x-%x %4s %08x %x:%x", &start, &end, prot, &shift, &major, &minor) != 6) + { + if (sscanf(buffer, "%x-%x %4s", &start, &end, prot) != 3) continue; + shift = 0; + major = minor = 0; + } + + vprot = 0; + if (prot[0] == 'r') vprot |= VPROT_READ; + if (prot[1] == 'w') vprot |= VPROT_WRITE; + if (prot[2] == 'x') vprot |= VPROT_EXEC; + if (prot[3] == 'p') vprot |= VPROT_WRITECOPY; +#endif + + if (end <= base) + continue; + if (base < start) + { + size = start - alloc_base; + goto noMap; + } + if (base < end) + { + alloc_base = start; + size = end - start; + + reply->state = MEM_COMMIT; /* FIXME: hard to tell MEM_RESERVE */ + reply->protect = vprot; + reply->protect_other = reply->protect; /* FIXME: hard to guesss */ + + reply->type = (major && minor) ? MEM_MAPPED : 0; /* FIXME */ + goto final; + } + alloc_base = end; + } + + size = 0xffff0000 - alloc_base; + + noMap: + reply->state = MEM_FREE; + reply->protect = 0; + reply->protect_other = 0; + reply->type = 0; + final: + reply->base_address = (LPVOID)base; + reply->alloc_base = (LPVOID)alloc_base; + reply->size = size - (base - alloc_base); + + fclose(file); + return; +} + +/* query information about a part of the memory */ +DECL_HANDLER(query_virtual_memory_info) +{ + struct process* process; + + if (!(process = get_process_from_handle( req->handle, PROCESS_VM_READ ))) + return; + + query_virtual_memory_info(process, (unsigned)req->addr, reply); +}

1 0

Printing
by Ann and Jason Edmeades 15 Jul '02

15 Jul '02

I am trying to test my program which does a simple print preview in VB but cant get that far yet. Setup: CUPS HPLJ4 setup (CUPS+GIMP-print v4.2.0) When I run the program and it starts accessing the printer (GetCompatibleDC/FindPrinterInfo?) it complains about AFM fonts. I tried adding /usr/share/fonts/afms/adobe to the afmdirs in the config file and although I get different trace, I get the same message. Reading the winehq guide to printing it doesnt mention anything about setting up afmdirs and I read that wine should be able to do it itself for Type 1 fonts, but I have no idea where this is going wrong. I've hunted dejanews (goole groups) and although I can find lots of hits on these messages I couldnt find anything clear. Questions... 1. Should I need to install AFM fonts - 4.7.2.1.4 of http://www.winehq.com/Docs/wine-user/printing.shtml implies not. However this implies I need a PPD file for my printer, but 4.7.2.1.1 implies there is no further configuration required. The 'funny' side is I dont care too much about the printing just yet - I just want to be able to query the dimensions to test the rest of mq code!! Jason An edited --debugmsg follows: Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: Could not stat /cdrom (No such file or directory), ignoring drive D: err:font:AddFontFileToList Unable to load font file "/home/edmeades/c/windows/Fonts/modern.fon" err = 2 err:font:AddFontFileToList Unable to load font file "/home/edmeades/c/windows/Fonts/roman.fon" err = 2 err:font:AddFontFileToList Unable to load font file "/home/edmeades/c/windows/Fonts/script.fon" err = 2 fixme:win32:PE_CreateModule Security directory ignored trace:psdrv:PSDRV_Init (0x4167d000, 0x00000001, (nil)) trace:psdrv:PSDRV_GlyphListInit glyphList will initially hold 2048 glyph names warn:psdrv:ReadAFMDir /usr/share/ghostscript/fonts: No such file or directory trace:psdrv:ReadAFMFile /usr/share/fonts/afms/adobe/phvbo8an.afm : : Working through some afm files, occasional Unicodify Glyph 'merge' not in Adobe Glyph List type messgae : warn:psdrv:PSDRV_AddAFMtoList Ignoring duplicate FontName 'AvantGarde-Demi' trace:psdrv:AddBuiltinAFMs Ignoring built-in font AvantGarde-Demi warn:psdrv:PSDRV_AddAFMtoList Ignoring duplicate FontName 'AvantGarde-DemiOblique' trace:psdrv:AddBuiltinAFMs Ignoring built-in font AvantGarde-DemiOblique : : Repeated for a number of fonts : trace:psdrv:PSDRV_DumpFontList Family 'Helvetica' trace:psdrv:PSDRV_DumpFontList FontName 'Helvetica-Narrow-BoldOblique' (228 glyphs) - 'AdobeStandardEncoding' encoding: trace:psdrv:PSDRV_DumpFontList FontName 'Helvetica-Bold' (228 glyphs) - 'AdobeStandardEncoding' encoding: trace:psdrv:PSDRV_DumpFontList FontName 'Helvetica-Narrow-Bold' (228 glyphs) - 'AdobeStandardEncoding' encoding: etc : : Repeated for a number of families : trace:psdrv:PSDRV_FindPrinterInfo 'HPLJ4' trace:print:DrvGetPrinterData16 printer HPLJ4 trace:print:DrvGetPrinterData16 profile 0x1 trace:print:DrvGetPrinterData16 lpType 0x405c5ec0 trace:print:DrvGetPrinterData16 printer HPLJ4 trace:print:DrvGetPrinterData16 profile 0x1 trace:print:DrvGetPrinterData16 lpType 0x405c5ec0 trace:psdrv:PSDRV_ParsePPD file '/var/tmp/3d31e093d6bf6' trace:psdrv:PSDRV_ParsePPD NickName = 'HP LaserJet 4L, CUPS+GIMP-print v4.2.0' trace:psdrv:PSDRV_ParsePPD LanguageLevel = 2 trace:psdrv:PSDRV_ParsePPD ColorDevice = 0 trace:psdrv:PSDRV_ParsePPD LandscapeOrientation = 90 trace:psdrv:PSDRV_ParsePPD Can't find Windows page type for 'COM10' - using 256 trace:psdrv:PSDRV_ParsePPD Using Windows bin type 256 for 'Standard' trace:psdrv:PSDRV_ParsePPD Using Windows bin type 257 for 'Manual' trace:psdrv:PSDRV_ParsePPD Using Windows bin type 258 for 'MultiPurpose' trace:psdrv:PSDRV_ParsePPD Using Windows bin type 259 for 'Upper' trace:psdrv:PSDRV_ParsePPD Using Windows bin type 260 for 'Lower' trace:psdrv:PSDRV_ParsePPD Using Windows bin type 261 for 'LargeCapacity' trace:psdrv:PSDRV_ParsePPD DefaultResolution = 300 err:psdrv:PSDRV_PPDGetNextTuple Error in line '*CloseUI *stpBrightness '? trace:psdrv:PSDRV_ParsePPD 'Letter' aka 'Letter' (1) invoked by '<</PageSize[612 792]/ImagingBBox null>>setpagedevice' trace:psdrv:PSDRV_ParsePPD Area = 18.00,12.00 - 594.00, 780.00 trace:psdrv:PSDRV_ParsePPD Dimension = 612.00 x 792.00 trace:psdrv:PSDRV_ParsePPD 'Legal' aka 'Legal' (5) invoked by '<</PageSize[612 1008]/ImagingBBox null>>setpagedevice' trace:psdrv:PSDRV_ParsePPD Area = 18.00,12.00 - 594.00, 996.00 trace:psdrv:PSDRV_ParsePPD Dimension = 612.00 x 1008.00 trace:psdrv:PSDRV_ParsePPD 'Executive' aka 'Executive' (7) invoked by '<</PageSize[522 756]/ImagingBBox null>>setpagedevice' trace:psdrv:PSDRV_ParsePPD Area = 18.00,12.00 - 504.00, 744.00 trace:psdrv:PSDRV_ParsePPD Dimension = 522.00 x 756.00 trace:psdrv:PSDRV_ParsePPD 'Statement' aka 'Manual' (6) invoked by '<</PageSize[396 612]/ImagingBBox null>>setpagedevice' trace:psdrv:PSDRV_ParsePPD Area = 18.00,12.00 - 378.00, 600.00 trace:psdrv:PSDRV_ParsePPD Dimension = 396.00 x 612.00 trace:psdrv:PSDRV_ParsePPD 'A4' aka 'A4' (9) invoked by '<</PageSize[595 842]/ImagingBBox null>>setpagedevice' trace:psdrv:PSDRV_ParsePPD Area = 18.00,12.00 - 577.00, 830.00 trace:psdrv:PSDRV_ParsePPD Dimension = 595.00 x 842.00 trace:psdrv:PSDRV_ParsePPD 'C5' aka 'C5' (28) invoked by '<</PageSize[459 649]/ImagingBBox null>>setpagedevice' trace:psdrv:PSDRV_ParsePPD Area = 18.00,12.00 - 441.00, 637.00 trace:psdrv:PSDRV_ParsePPD Dimension = 459.00 x 649.00 trace:psdrv:PSDRV_ParsePPD 'C6' aka 'C6' (31) invoked by '<</PageSize[323 459]/ImagingBBox null>>setpagedevice' trace:psdrv:PSDRV_ParsePPD Area = 18.00,12.00 - 305.00, 447.00 trace:psdrv:PSDRV_ParsePPD Dimension = 323.00 x 459.00 trace:psdrv:PSDRV_ParsePPD 'DL' aka 'DL' (27) invoked by '<</PageSize[311 623]/ImagingBBox null>>setpagedevice' trace:psdrv:PSDRV_ParsePPD Area = 18.00,12.00 - 293.00, 611.00 trace:psdrv:PSDRV_ParsePPD Dimension = 311.00 x 623.00 trace:psdrv:PSDRV_ParsePPD 'COM10' aka 'Commercial 10' (256) invoked by '<</PageSize[297 684]/ImagingBBox null>>setpagedevice' trace:psdrv:PSDRV_ParsePPD Area = 18.00,12.00 - 279.00, 672.00 trace:psdrv:PSDRV_ParsePPD Dimension = 297.00 x 684.00 trace:psdrv:PSDRV_ParsePPD INPUTSLOTS '(null)' Name 'Automatically Select' (15) Invocation '(null)' trace:psdrv:PSDRV_ParsePPD INPUTSLOTS 'Standard' Name 'Standard' (256) Invocation '<</MediaClass(Standard)>>setpagedevice' trace:psdrv:PSDRV_ParsePPD INPUTSLOTS 'Manual' Name 'Manual' (257) Invocation '<</MediaClass(Manual)>>setpagedevice' trace:psdrv:PSDRV_ParsePPD INPUTSLOTS 'MultiPurpose' Name 'Tray 1' (258) Invocation '<</MediaClass(MultiPurpose)>>setpagedevice' trace:psdrv:PSDRV_ParsePPD INPUTSLOTS 'Upper' Name 'Tray 2' (259) Invocation '<</MediaClass(Upper)>>setpagedevice' trace:psdrv:PSDRV_ParsePPD INPUTSLOTS 'Lower' Name 'Tray 3' (260) Invocation '<</MediaClass(Lower)>>setpagedevice' trace:psdrv:PSDRV_ParsePPD INPUTSLOTS 'LargeCapacity' Name 'Tray 4' (261) Invocation '<</MediaClass(LargeCapacity)>>setpagedevice' trace:psdrv:PSDRV_FindPrinterInfo No 'Paper Size' for printer 'HPLJ4' trace:psdrv:PSDRV_FindPrinterInfo No 'FontSubTable' for printer 'HPLJ4' trace:psdrv:PSDRV_CreateDC (WINEPS HPLJ4 LPT1: (nil)) To use WINEPS you need to install some AFM files. fixme:winspool:AddPrinterW DocumentPropertiesW on printer 'L"HPLJ4"' fails trace:psdrv:PSDRV_FindPrinterInfo 'HPLJ4' trace:psdrv:PSDRV_CreateDC (WINEPS HPLJ4 LPT1: (nil)) To use WINEPS you need to install some AFM files. err:winspool:AddPrinterW DocumentPropertiesW on printer 'L"HPLJ4"' failed! err:winspool:CUPS_LoadPrinters printer 'HPLJ4' not added by AddPrinterA (error 1797) trace:psdrv:PSDRV_FindPrinterInfo 'HPLJ4' trace:psdrv:PSDRV_CreateDC (WINEPS HPLJ4 LPT1: (nil)) To use WINEPS you need to install some AFM files. trace:psdrv:PSDRV_FindPrinterInfo 'HPLJ4' trace:psdrv:PSDRV_CreateDC (WINEPS HPLJ4 LPT1: (nil)) To use WINEPS you need to install some AFM files. trace:psdrv:PSDRV_Init (0x4167d000, 0x00000000, 0x1)

2 1

Re: Eliminate bogus error messages
by Guy L. Albertelli 14 Jul '02

14 Jul '02

I hate it when the debugging code sneaks out of the house!! Thanks Michael for catching that. Alexandre, please use this version instead Thanks, Guy ----- Original Message ----- From: "Guy L. Albertelli" <galberte(a)neo.lrun.com> To: "Wine Patches" <wine-patches(a)winehq.com> Sent: Sunday, July 14, 2002 12:19 PM Subject: Eliminate bogus error messages > This eliminate ERR messages for messages greater than 0x7fff which are > application dependent message. > > Note Listview and UpDown are not included because they are currently under > repair in my tree. Those fixes will be coming later. > > License: X11 > > Changelog: > Guy Albertelli <<galberte(a)neo.lrun.com>> > > dlls/comctl32/animate.c,comboex.c,datetime.c, > flatsb.c,header.c,hotkey.c,ipaddress.c,monthcal.c, > progress.c,rebar.c,status.c,tab.c,toolbar.c,tooltips.c, > trackbar.c,treeview.c > - Don't issue error message if message number in application > range. >

1 0

Re: Eliminate bogus error messages
by Michael Stefaniuc 14 Jul '02

14 Jul '02

Hello! On Sun, Jul 14, 2002 at 12:19:13PM -0400, Guy L. Albertelli wrote: > This eliminate ERR messages for messages greater than 0x7fff which are > application dependent message. > > Note Listview and UpDown are not included because they are currently under > repair in my tree. Those fixes will be coming later. > > License: X11 > > Changelog: > Guy Albertelli <<galberte(a)neo.lrun.com>> > > dlls/comctl32/animate.c,comboex.c,datetime.c, > flatsb.c,header.c,hotkey.c,ipaddress.c,monthcal.c, > progress.c,rebar.c,status.c,tab.c,toolbar.c,tooltips.c, > trackbar.c,treeview.c > - Don't issue error message if message number in application > range. Index: dlls/comctl32/tab.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/tab.c,v retrieving revision 1.69 diff -u -r1.69 tab.c --- dlls/comctl32/tab.c 20 Jun 2002 22:45:29 -0000 1.69 +++ dlls/comctl32/tab.c 14 Jul 2002 16:04:57 -0000 @@ -1755,6 +1755,8 @@ */ bkgnd = comctl32_color.clrBtnFace; corner = comctl32_color.clrBtnFace; + bkgnd = 0x00c0c000; /* GLA */ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + corner = 0x0000c0c0; /* GLA */ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Are you sure that this should go in? Makes the tabs in the Minolta Dimage Image Viefer have the color lightblue/tourquoise. Without this (and also with the native comctrl32 or in Windows) the tabs are lightgray. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: Fixing a regression test ...
by Duane Clark 14 Jul '02

14 Jul '02

Paul Millar wrote: > ChangeLog: > Replace references to D: (which might not exist) with C: (which we > assume does) > > Index: dlls/kernel/tests/path.c > =================================================================== > RCS file: /home/wine/wine/dlls/kernel/tests/path.c,v > retrieving revision 1.6 > diff -u -r1.6 path.c > --- dlls/kernel/tests/path.c 5 Jul 2002 01:22:28 -0000 1.6 > +++ dlls/kernel/tests/path.c 12 Jul 2002 18:03:17 -0000 > @@ -673,9 +673,9 @@ > ok(lstrcmpiA(SHORTFILE,strptr)==0, > "GetLongPathNameA returned part '%s' instead of '%s'",strptr,SHORTFILE); > /* Otherwise insert the missing leading slash */ > - sprintf(tmpstr,"D:%s\\%s",SHORTDIR,SHORTFILE); > + sprintf(tmpstr,"C:%s\\%s",SHORTDIR,SHORTFILE); > ok(GetFullPathNameA(tmpstr,MAX_PATH,tmpstr1,&strptr),"GetFullPathNameA failed"); > - sprintf(tmpstr,"D:\\%s\\%s",SHORTDIR,SHORTFILE); > + sprintf(tmpstr,"C:\\%s\\%s",SHORTDIR,SHORTFILE); > ok(lstrcmpiA(tmpstr,tmpstr1)==0, > "GetLongPathNameA returned '%s' instead of '%s'",tmpstr1,tmpstr); > ok(lstrcmpiA(SHORTFILE,strptr)==0, Actually, the purpose of that particular test was to check the behavior when the supplied path is on a different drive from the current drive. The current drive is presumably C:. But the test should have tested for the existence of drive D: before using it.

2 3

Re: winedbg font selection
by Carl Sopchak 14 Jul '02

14 Jul '02

On Saturday, July 13, 2002 01:01 pm, wine-devel-request(a)winehq.com wrote: > "Carl Sopchak" <carl.sopchak(a)cegis123.com> wrote: > > It not only doesn't save the setting between runs, it's not saved between > > popping it up in the same run! In fact, changing the setting DOES NOT > > change the font! (At least on my system: current cvs, red hat 7.3) > > It's OK on mine, Slakware 8.0 with almost up-to-date CVS with freetype > 2.0.6 and X 4.1.0 > > > Version or environment dependent problem ? It turns out that the fonts listed on this panel do not all work on my machine. I'm not sure (nor do I really care) where the font list comes from, but some selections do not seem to be available. I found one that works, and I'm all set. Thanks to those that helped... Carl

1 0

Re: SetMenu compatibility issue
by Rob - 14 Jul '02

14 Jul '02

Sorry, please disregard this patch. It causes problems with programs that specify a menu in the window class definition, because CreateWindow calls SetMenu. I believe the IsWindowVisible condition in SetMenu should be replaced with a "Is this window fully created yet", but I don't know a safe way to do that. Rob McClinton _________________________________________________________________ MSN Photos is the easiest way to share and print your photos: http://photos.msn.com/support/worldwide.aspx

1 0

IOPL Error?
by David A. Bartmess 13 Jul '02

13 Jul '02

I'm not sure where to post this question... Please be gentle <grin> I'm trying to run Office10 winword.exe (a full installation on my D: drive) under Mandrake Linux 8.2 from a Windows XP Pro installation drive. The command I'm using is wine -dll ntdll,msvcrt=builtin /mnt/win_d/"Program Files"/Microsoft/Office/Office10/winword.exe The window frame opens up, but then I get a small window that just says "IOPL not enabled Error". I'm a programmer (13 years), so if you need anything like debug text, no problem, just tell me. Can anyone help? If I can get Office XP working, then I'll be set, and WON'T HAVE TO USE WINDOWS! <GRIN> -- David A. Bartmess Software Configuration Manager / Sr. Software Developer eDingo Enterprises http://edingo.net But one should not forget that money can buy a bed but not sleep, finery but not beauty, a house but not a home, medicine but not health, luxuries but not culture, sex but not love and amusements but not happiness.

2 1

Re: PATCH: FlushFileBuffers / serial
by Rein Klazes 13 Jul '02

13 Jul '02

On Fri, 12 Jul 2002 23:22:13 +0200, you wrote: > + /* MSDN says: If hFile is a handle to a communications device, > + * the function only flushes the transmit buffer. > + */ > + ret = (tcdrain( serial->obj.fd ) != -1); Hmm, doesn't that mean you should use tcflush() instead? Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

Re: SHLWAPI ole32 (delay-load of dlls)
by Alexandre Julliard 13 Jul '02

13 Jul '02

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes: > I should clarify. Versions 6 and higher (XP+) of SHLWAPI are linked > via delayed import to ole32. This is a change from previous versions > because versions 5xs and below could be installed on installations > that didn't have ole32 installed. SHLWAPI used to come with IE, and > as such it was an add on to v3.1+, where sometimes ole32.dll was not > available. The latest versions require ole32, however if Wine is > running as a previous version it should _not_ be a requirement that > this dll be installed. I don't see any need for being compatible that way. Wine always comes with ole32 so it's perfectly acceptable to depend on it, as long as our builtin ole32 does what we need. We just have to make sure that it works with existing native ole32 dlls too, for instance by avoiding imports of functions that only exist in the latest versions; but making it work with a non-existing ole32 is not necessary. > If we should > directly link with ole32 then we should probably remove the FIXME > from Makefile.in. If we follow this path, we should eventually also > link with the other DLLs that version 6 delay loads instead of being > optional as before: apphelp, mlang, comctl32, mpr, msi, setupapi, > userenv, winmm etc. If both the native and builtin versions of these dlls implement what we need, and if you can import them without creating circular dependencies, then yes they should definitely be imported instead of using explicit function pointers. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: SHLWAPI ole32 (delay-load of dlls)
by Jürgen Schmied 13 Jul '02

13 Jul '02

(deleted) > Ifwe should directly link with ole32 then we should probably remove the FIXME from Makefile.in. > If we follow this path, we should eventually also link with the other DLLs that version 6 delay > loads instead of being optional as before: apphelp, mlang, comctl32, mpr, msi, setupapi, > userenv, winmm etc. These are a bit to much dlls whats not on every system. Delay loading ole32 just needs a >= win95 version of ole32 so it shouldn't any problem. The other dlls are (except comctl32) are a problem because we can't expect them to be here. If there is no ole32 wine loads the built in as a fallback. I think it's safe to do a delay loading there. juergen > Cheers, > Jon > > Alexandre Julliard <julliard(a)winehq.com> wrote: > "Jürgen Schmied" writes: > > > This is not completely right. shlwapi loads ole32 per delay-load what > > means nearly its linking against it. We don't have anything similar at > > the moment. I don't think we should do anyting by function pointers. > > Maybe we could generate stubs during the build process to implement > > delay loading. It don't looks to hard to implement. > > It's already implemented, you just have to list them as DELAYIMPORTS > instead of IMPORTS in the makefile. > > -- > Alexandre Julliard > julliard(a)winehq.com > > > "Don't wait for the seas to part, or messiahs to come; > Don't you sit around and waste this chance..." - Live > > jon_p_griffiths(a)yahoo.com > > > Do You Yahoo!? > New! SBC Yahoo! Dial - 1st Month Free & unlimited access --- juergen.schmied(a)debitel.net

1 0

HeapWalk generated FIXME
by Lanny DeVaney 12 Jul '02

12 Jul '02

Excuse the newby question, but it appears HeapWalk in memory/heap.c calls RtlWalkHeap in dlls/ntdll/heap.c and this in turn is generating fixme messages (lots of them since it appears this is called in a loop.) Can someone enlighten me as to what the problem is, and why one would see the "not fully compatible" fixme messages from RtlWalkHeap. Thanks, Lanny DeVaney

1 0

AppDB: great news !
by Andreas Mohr 12 Jul '02

12 Jul '02

Hi all, I just wanted to let you know that the appliation database (http://appdb.codeweavers.com) just managed to reach 1000 entries !! I think that's a really great thing :-) -- "My attitude is, everybody should try competing with Microsoft once in their life. Once." - Marc Andreessen, former Netscape lead employee, in a "browser wars" interview

3 2

Re: Crash in SHELL32_ParseNextElement
by Gregg Mattinson 12 Jul '02

12 Jul '02

No. I came across this crash a few weeks ago when testing an application. Unfortunatly, I can't even remember what caused it to crash. I just remember adding this small change and that fixed things. Gregg >From: "Jürgen Schmied" <juergenschmied(a)lycos.de> >To: Gregg Mattinson <gm138242(a)opcom-mail.canada.sun.com>, wine-devel(a)winehq.com >Date: Fri, 12 Jul 2002 18:03:17 +0200 >MIME-Version: 1.0 >Subject: Re: Crash in SHELL32_ParseNextElement >CC: wine-devel(a)winehq.com >Content-transfer-encoding: 7BIT >Content-description: Mail message body > >Im about to do a major update to the shellfolder stuff. Are you aware of any other >probkems? > >juergen > >On 12 Jul 2002 at 10:11, Gregg Mattinson wrote: > >> ChangeLog: dlls/shell32/shlfolder.c >> - Initialized the pidlOut variable in SHELL32_ParseNextElement to prevent a >> crash in some cases. >> >> Gregg Mattinson >> Co-op Developer >> Sun Microsystems of Canada >> >> > > >--- >juergen.schmied(a)debitel.net >

1 0

Re: SHLWAPI ole32 (delay-load of dlls)
by Jürgen Schmied 12 Jul '02

12 Jul '02

This is not completely right. shlwapi loads ole32 per delay-load what means nearly its linking against it. We don't have anything similar at the moment. I don't think we should do anyting by function pointers. Maybe we could generate stubs during the build process to implement delay loading. It don't looks to hard to implement. juergen On 11 Jul 2002 at 21:05, Jon Griffiths wrote: > Hi, > > SHLWAPI updates continued. > > This patch removes the need for direct linking to ole32, which is > only ever late bound by the real SHLWAPI. > > For fear of patch conflicts with myself, I haven't included a patch > to Makefile.in to remove the import and the FIXME. I'll send this in > a later patch, if need be. > > > ChangeLog: > > Jon Griffiths <jon_p_griffiths(a)yahoo.com> > > +dlls/shlwapi/shlwapi_main.c dlls/shlwapi/string.c > Remove the need to directly link to ole32. > > > ===== > "Don't wait for the seas to part, or messiahs to come; > Don't you sit around and waste this chance..." - Live > > jon_p_griffiths(a)yahoo.com > > __________________________________________________ > Do You Yahoo!? > Sign up for SBC Yahoo! Dial - First Month Free > http://sbc.yahoo.com --- juergen.schmied(a)debitel.net

2 1

Re: Crash in SHELL32_ParseNextElement
by Jürgen Schmied 12 Jul '02

12 Jul '02

Im about to do a major update to the shellfolder stuff. Are you aware of any other probkems? juergen On 12 Jul 2002 at 10:11, Gregg Mattinson wrote: > ChangeLog: dlls/shell32/shlfolder.c > - Initialized the pidlOut variable in SHELL32_ParseNextElement to prevent a > crash in some cases. > > Gregg Mattinson > Co-op Developer > Sun Microsystems of Canada > > --- juergen.schmied(a)debitel.net

1 0

RE: Any advice on how to debug this?
by Medland, Bill 12 Jul '02

12 Jul '02

> -----Original Message----- > From: Guy L. Albertelli [mailto:galberte@neo.lrun.com] > Sent: Thursday, July 11, 2002 5:13 PM > To: Medland, Bill; Wine devel (E-mail) > Subject: Re: Any advice on how to debug this? > > > > ----- Original Message ----- > From: "Medland, Bill" <Bill.Medland(a)accpac.com> > To: "Wine devel (E-mail)" <wine-devel(a)winehq.com> > Sent: Tuesday, July 09, 2002 5:51 PM > Subject: Any advice on how to debug this? > > > > Any suggestions would be appreciated. > > > > The application runs reasonably with builtin > comctl32/commctrl but there > are > > some alignment issues which I suspect might be corrected by > using the > native > > one. > > > Bill, > > Can you document the alignment issues for me with Bugzilla. > Screen shots are > fine. Traces with "+relay,+message,+tid,+win" are also great > for finding > these type of problems. Is the application available in a > demo version?? > > Guy > > Will comply Also I am in the process of fixing it. (Yesterday's submission was part and yesterday's question about HEADER was the other; I will continue today. Bill

1 0

Re: Items with size 0
by Dmitry Timoshkov 12 Jul '02

12 Jul '02

"Gregg Mattinson" <gm138242(a)scot.canada.sun.com> wrote: > +#ifndef __SUNPRO_C > THREADINFO ti[0]; > +#endif > } SYSTEM_PROCESS_INFORMATION; At least this one can be replaced by [1] for now, since it currently is not used in Wine and according to the Nebbett's book has very different layout. -- Dmitry.

1 0

Re: Fix nasty little bug in InitializeGenericSF
by Joshua Thielen 12 Jul '02

12 Jul '02

Joshua Thielen wrote: > This patch fixes a little bug that caused heap corruption (ouch!) when > running the Finale 2002 installer. > Urg! I'm sorry, I just noticed that Rein fixed this on Tuesday. I just wasted a lot of time. Josh

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel