wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

'Runtime Error 429', and $ offered for a fix
by Sean Russell 09 Jul '02

09 Jul '02

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello all, I originally posted this to c.e.ms-windows.wine, but I wanted to cross post it to the developers list in the hopes of attracting the proper attention. I appologise if it is inappropriate to offer money for solutions, in this list. My wife is an author. For the past eight months, she's been happily working exclusively on Linux with OpenOffice. She just recently accepted a job doing some tech writing; the application she is to document is a Windows application, made (apparently) predominantly of VB. This application fails to run under a recent Wine. I'm considering two options: (a) Buy a copy of Windows and VMWare, and (b) donate the money I'd spend to a Wine Guru or the Wine project instead, to get the application running. I'd MUCH rather give my money to the Wine project, but this is only an option if I can reasonably hope for a quick turn-around. I'm trying desperately from having to give money to Redmond and incidentally having to maintain a Windows install on her computer :-( Windows would cost me $100, $150 with VMWare. I'll happily donate that to the Wine project, or a Wine developer. It isn't a lot, I know, but if anybody is willing to take this on, please let me know. If it looks like a simple fix, then fine. If it looks like a lot of work, then just let me know and I'll grab a copy of VMWare. I don't have the sourcecode for the application. If you're interested in taking a look at this, email me at 'ser at germane dash software dot com', and I'll send you console dumps, Wine versions, etc. The basic error that the Windows dialog gives us is: Runtime Error '429' ActiveX component can't create object Thanks, sincerely. Sean - --- SER -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) iD4DBQE9KKOyP0KxygnleI8RAhrWAJiTIgHSli8/GDlIdLKlqMMHBTjyAJoCQV2y 0zty1Z52wQ8TVML1Fn/C5g== =NtZe -----END PGP SIGNATURE-----

2 1

MS' hidden API
by Zhang Shu 09 Jul '02

09 Jul '02

Dear wine developers, I have one question on the development of wine. Long(one or two years) ago I've heard that Microsoft got some hidden APIs in their products of various windows, and they use these APIs in their own applications. I wonder if this is still a problem on their recent product like windows XP. If it is, I guess wine will not be able to run such MS applications which uses hidden APIs. Is this right? And, is wine designed(or its goal is) to run all applications(including MS product and non-MS product) that runs on windows? Please forgive me if this problem has appeared in the past. I just joined this list a couple of days ago. Thank you. Regards, -- Zhang Shu

10 10

wine source doubts
by Preetham 09 Jul '02

09 Jul '02

Hi All: I am a newbie to wine. I have a few queries. 1. I downloaded the wine source from cvs, however, is there any document as to where i can start lookin into the code.? 2. Where is the program(wine loader) that loads a .ece file located in the source. Appriciate the help. Regards, Preetham

2 1

One more try at bug 829 (same surface corruption)
by Tony Lambregts 09 Jul '02

09 Jul '02

After talking with Lionel Ulmer offline I came up with the following patch for bug 829. It includes a hopefully more clear comment of when the corruption can occure and a better set of rules. Change log: fix same surface corruption when no flags are set and areas are the same size Tony Lambregts tony_lambregts(a)telusplanet.net Index: dib.c =================================================================== RCS file: /home/wine/wine/dlls/ddraw/dsurface/dib.c,v retrieving revision 1.11 diff -u -r1.11 dib.c --- dib.c 28 Jun 2002 17:32:25 -0000 1.11 +++ dib.c 9 Jul 2002 03:57:37 -0000 @@ -351,6 +351,7 @@ int bpp, srcheight, srcwidth, dstheight, dstwidth, width; int x, y; LPBYTE dbuf, sbuf; + BOOL SameSurfaceOK = TRUE; TRACE("(%p)->(%p,%p,%p,%08lx,%p)\n", This,rdst,src,rsrc,dwFlags,lpbltfx); @@ -474,6 +475,18 @@ sbase = (BYTE*)sdesc.lpSurface+(xsrc.top*sdesc.u1.lPitch)+xsrc.left*bpp; xinc = (srcwidth << 16) / dstwidth; yinc = (srcheight << 16) / dstheight; + SameSurfaceOK = ((src != iface)|| + (sbase >= dbuf)|| + (xdst.top > xsrc.bottom)||(xdst.left > xsrc.right)||(xdst.right < xsrc.left)); + + /* + A little explination: Screen coruption can occure if the following set of circumstances is true + + 1.) Both the source and destination are the same surface. -->(src != iface) + 2.) The start of the source is less than the destination . -->(sbase >= dbuf) + 3.) There is overlap. -->(xdst.top < xsrc.bottom)&&(xdst.left < xsrc.right)(xdst.right < xsrc.left) + This is fixed in the case where no flags are set and the areas are the same size. + */ if (!dwFlags) { /* No effects, we can cheat here */ @@ -482,11 +495,29 @@ /* No stretching in either direction. This needs to be as * fast as possible */ sbuf = sbase; - for (y = 0; y < dstheight; y++) { - memcpy(dbuf, sbuf, width); - sbuf += sdesc.u1.lPitch; - dbuf += ddesc.u1.lPitch; - } + if (SameSurfaceOK) { + for (y = 0; y < dstheight; y++) { + memcpy(dbuf, sbuf, width); + sbuf += sdesc.u1.lPitch; + dbuf += ddesc.u1.lPitch; + } + } else { + sbuf += (sdesc.u1.lPitch*dstheight); + dbuf += (ddesc.u1.lPitch*dstheight); + if (xdst.top == xsrc.top) { /* Are the source and destination on the same line? */ + for (y = 0; y < dstheight; y++) { + sbuf -= sdesc.u1.lPitch; + dbuf -= ddesc.u1.lPitch; + memmove(dbuf, sbuf, width); + } + } else { + for (y = 0; y < dstheight; y++) { + sbuf -= sdesc.u1.lPitch; + dbuf -= ddesc.u1.lPitch; + memcpy(dbuf, sbuf, width); + } + } + } } else { /* Stretching in Y direction only */ for (y = sy = 0; y < dstheight; y++, sy += yinc) { @@ -544,6 +575,10 @@ } } else if (dwFlags & (DDBLT_KEYSRC | DDBLT_KEYDEST | DDBLT_KEYSRCOVERRIDE | DDBLT_KEYDESTOVERRIDE)) { DWORD keylow, keyhigh; + + if (!SameSurfaceOK) { + FIXME("\tSoure and destination surfaces are the same and could cause display problems\n"); + } if (dwFlags & DDBLT_KEYSRC) { keylow = sdesc.ddckCKSrcBlt.dwColorSpaceLowValue;

1 0

Re: SHLWAPI wsprintf - with patch this time
by Alexandre Julliard 09 Jul '02

09 Jul '02

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes: > +dlls/shlwapi/wsprintf.c dlls/user/wsprintf.c > Add decimal double (%f) format specifier to *printf functions. These functions are not supposed to handle %f. If you need %f you have to use the real sprintf, not the wsprintf variants. -- Alexandre Julliard julliard(a)winehq.com

1 0

malloc, heapalloc, etc
by John Lightsey 08 Jul '02

08 Jul '02

Hi all, I've been playing around with the wininet dll to get a windows app I developed running, and I've written a patch that fixes the problems with wininet that I've noticed, but it's an ugly fix and I'd like to get a little clarification about how heap memory is being used in Wine. In dlls/wininet/internet.c InternetOpenUrlA() malloc() is used to put together the HTTP host header in hostreq. The pointer is then passed to HttpAddRequestHeadersA() which creates a buffer with HeapAlloc, copies the contents pointed to by hostreq to it then frees the buffer with HeapFree. Control then passes back to InternetOpenUrlA which does not call free() on the hostreq pointer. So, my question is which is the encouraged way of doing things? HeapAlloc and HeapFree or malloc and free? Also, is the fact that free() was not called on hostreq a bug, or am I missing something? Please be gentle....I'm a Perl programmer, not a C programmer.

2 1

about programming books
by Andreas Mohr 08 Jul '02

08 Jul '02

Hi all, I just created http://wine.codeweavers.com/fom-meta/cache/831.html to list all the Windows programming books I own (16 books ! ;-) I'd be happy if some other people could add an entry, too. That way we'd have an amazing information resource whenever needed. Hmm, I just hope you've got editing capabilities on this page. If you're unable to add something, then please tell me. (or just edit an entry in some FOM category where you're able to edit it, I'll move it there then) Of course I will add more details of the books to the page once I feel bored (actually a separate page per book within a sub category per author would probably be better). Thanks ! -- Microsoft Licensing 6.0: "Pay us now in advance, so that we can own you later."

1 0

Support for 24bpp when DDBLT_KEYSRC etc are set
by Tony Lambregts 08 Jul '02

08 Jul '02

I am working on implementing the flags under DDBLTFX (Bug 841) and in order to do so I needed to understand how the current code worked. While researching this I came up with this patch for the flags DDBLT_KEYSRC/DDBLT_KEYDEST and company. This patch should be faster then the current code since the switch statement is outside the loop. It also adds support for 24bpp colour. The problem that I have with this is that it assumes stretching in both the x and y directions but from what I understand stretching should only be done if the flag DDBLTFX is set and has the operation DDBLTFX_ARITHSTRETCHY in dwDDFX. Is that right or can Marcus Meissner or Lionel Ulmer explain this to me. Change log: added support for 24bpp when the flags DDBLT_KEYSRC/DDBLT_KEYDEST and company are set. Tony Lambregts tony_lambregts(a)telusplanet.net Index: dib.c =================================================================== RCS file: /home/wine/wine/dlls/ddraw/dsurface/dib.c,v retrieving revision 1.11 diff -u -r1.11 dib.c --- dib.c 28 Jun 2002 17:32:25 -0000 1.11 +++ dib.c 8 Jul 2002 19:02:35 -0000 @@ -561,28 +561,54 @@ keyhigh = lpbltfx->ddckDestColorkey.dwColorSpaceHighValue; } - for (y = sy = 0; y < dstheight; y++, sy += yinc) { - sbuf = sbase + (sy >> 16) * sdesc.u1.lPitch; #define COPYROW_COLORKEY(type) { \ - type *s = (type *) sbuf, *d = (type *) dbuf, tmp; \ - for (x = sx = 0; x < dstwidth; x++, sx += xinc) { \ - tmp = s[sx >> 16]; \ - if (tmp < keylow || tmp > keyhigh) d[x] = tmp; \ - } \ - break; } + type *s = (type *) sbuf, *d = (type *) dbuf, tmp; \ + for (y = sy = 0; y < dstheight; y++, sy += yinc) { \ + (LPBYTE)s = sbase + (sy >> 16) * sdesc.u1.lPitch; \ + for (x = sx = 0; x < dstwidth; x++, sx += xinc) { \ + tmp = s[sx >> 16]; \ + if (tmp < keylow || tmp > keyhigh) d[x] = tmp; \ + } \ + (LPBYTE)d += ddesc.u1.lPitch; \ + } \ + break; } - switch (bpp) { - case 1: COPYROW_COLORKEY(BYTE) - case 2: COPYROW_COLORKEY(WORD) - case 4: COPYROW_COLORKEY(DWORD) - default: - FIXME("%s color-keyed blit not implemented for bpp %d!\n", - (dwFlags & DDBLT_KEYSRC) ? "Source" : "Destination", bpp*8); - ret = DDERR_UNSUPPORTED; - goto error; - } - dbuf += ddesc.u1.lPitch; + switch (bpp) { + case 1: COPYROW_COLORKEY(BYTE) + case 2: COPYROW_COLORKEY(WORD) + case 4: COPYROW_COLORKEY(DWORD) + case 3: { + int last_sy = -1; + for (y = sy = 0; y < dstheight; y++, sy += yinc) { + sbuf = sbase + (sy >> 16) * sdesc.u1.lPitch; + if ((sy >> 16) == (last_sy >> 16)) { + /* this sourcerow is the same as last sourcerow - + * copy already stretched row + */ + memcpy(dbuf, dbuf - ddesc.u1.lPitch, width); + } else { + LPBYTE s,d = dbuf; + for (x = sx = 0; x < dstwidth; x++, sx+= xinc) { + DWORD pixel; + + s = sbuf+3*(sx>>16); + pixel = (s[0]<<16)|(s[1]<<8)|s[2]; + d[0] = (pixel>>16)&0xff; + d[1] = (pixel>> 8)&0xff; + d[2] = (pixel )&0xff; + d+=3; + } + } + dbuf += ddesc.u1.lPitch; + last_sy = sy; + } + break;} + default: + FIXME("%s color-keyed blit not implemented for bpp %d!\n", + (dwFlags & DDBLT_KEYSRC) ? "Source" : "Destination", bpp*8); + ret = DDERR_UNSUPPORTED; + goto error; } #undef COPYROW_COLORKEY dwFlags &= ~(DDBLT_KEYSRC | DDBLT_KEYDEST | DDBLT_KEYSRCOVERRIDE | DDBLT_KEYDESTOVERRIDE);

1 0

RE: Wine ODBC compatibilty
by Medland, Bill 08 Jul '02

08 Jul '02

> -----Original Message----- > From: James Juran [mailto:jamesjuran@alumni.psu.edu] > Sent: Friday, June 28, 2002 3:43 PM > To: Robert Damen > Cc: 'wine-devel(a)winehq.com' > Subject: Re: Wine ODBC compatibilty > > > Robert Damen wrote: > > > > Wine, > > I found this address on your website, if it is the > wrong address for > > these types of questions - Sorry!. > > > > I was wondering weather you could answer a question I have > about support for > > Microsoft Office applications. > > The question is about weather wine can emulate (or has its > own version of) > > the "ODBC Data Sources (32bit)" application found in > > c:\windows\Control Panel\ODBC Data Sources > > This application is used to set up DSN drivers for ODBC > access on Access and > > Excel. > > An example of one of the drivers that this application > handles is the MyODBC > > 3.51 windows driver. > > The "ODBC Data Sources" application in the control panel merely > manipulates registry entries. If all you need to do is set > them up, you > can do that easily with regedit. > > If you're wondering if they will work after you set them up, someone > else will have to answer that question :-) > > -- > James Juran > jamesjuran(a)alumni.psu.edu > To the best of my knowledge there is no such application, and it would be strange if there were. The WINE ODBC32 module is merely a wrapper around any suitable Linux ODBC module. For example we use unixODBC. Thus the WINE ODBC module has no real need to access the registry since all the work is being done by the Linux ODBC module. The way that the Linux ODBC module is configure depends upon which one you use. The unixODBC module, for example, uses a odbc.ini and odbcinst.ini file to store its configuration information. Although it does have a graphical configuration tool, with plugins for some database drivers, I prefer to edit the files by hand. That being said, it may be necessary to add some information to the registry for some ODBC-based applications. I do know that Crystal Reports directly accesses the registry for ODBC information rather than asking ODBC itself. HTH Bill

1 0

Re: Question about --debugmsg +snoop
by Massimo 08 Jul '02

08 Jul '02

So if I understand well there's no way now to snoop a single DLL, even putting it in ~/.wine/config ?

1 0

Borland linker and VirtualQuery
by Vassilis Virvilis 08 Jul '02

08 Jul '02

Halo, The attached patch (resurrected from) wine-users through google searching fixes indeed the borland command line tools (version 5.5.1 freely downloadable on the internet). Given that I am not familiar with the win32 API, this patch looks hackish and special cased (admitted also by its author, Gerard Patel) but still it is too useful. Since this question has never surfaced to wine-devel I would like to ask what is required for the patch to become acceptable. If it is something doable I will give it a try, otherwise I will file a report in the wine bugzilla database. Any way thanks in adavance. .Bill

1 0

Question about --debugmsg +snoop
by Massimo 08 Jul '02

08 Jul '02

Is there a way to activate +snoop only for selected dll ??? I think that would help me to find AutoCAD 2000 access violation on startup, isolating the dll where it happens. As stated few msg before, it starts up good with +snoop, but it crashes on very beginning without +snoop. Regards Max

3 4

warcraft 3
by Bobby Bingham 08 Jul '02

08 Jul '02

After buying Warcraft 3, and reading on the mailing list that the beta had worked under wine, I decided to try the final version under wine. It installed fine, but won't run. Or rather, when I try to run it, it prints this out, and just sits there: fixme:cdrom:CDROM_GetIdeInterface CD-ROM device with major ID 11 not supported fixme:cdrom:CDROM_GetIdeInterface CD-ROM device with major ID 11 not supported fixme:midi:OSS_MidiInit Synthesizer support MIDI in. Not supported yet (please report) I don't know much about the various debug messages, but if I run it with --debugmsg +relay, i see thousands upon thousands of lines like this: 0809c7f8:Call ntdll.dll.RtlEnterCriticalSection(403e0534) ret=40bf1e46 0809c7f8:Ret ntdll.dll.RtlEnterCriticalSection() retval=00000000 ret=40bf1e46 over and over, with these occasionally interspersed: 0809c7f8:Call kernel32.dll.GetTickCount() ret=40bf2013 0809c7f8:Ret kernel32.dll.GetTickCount() retval=00001f07 ret=40bf2013 now, how would one go about debugging this. It doesn't seem as convenient as just crashing in one specific function and bringing up the debugger ... Thanks, Bobby Bingham

3 4

Re: Apps that installs VBA
by Massimo 08 Jul '02

08 Jul '02

Looking in wine dir (~/c/windows) I found the 'missing' fsivba.dll. I think it should have been placed in ~/c/windows/system, or system32, not in ~/c/windows... I think there's again some problem with path handling or something like that, as it was with missing '\\' in the system.reg files some times ago. That problem caused also misplacement of some files, because of the malformed path. Regards Max

1 0

RE: WINE
by Steven Edwards 08 Jul '02

08 Jul '02

I'm forwarding a copy of this to wine-devel and reactos-kernel. The way that I have been doing it is to work out of the WINE tree to and submit changes back to them. I try to take a snapshot of the current WINE tree every few months and that then becomes the -stable branch for ReactOS. If there is a bug in the ReactOS wine any patch needs to be wrapped in a #ifdef __REACTOS__ that way it will be easy for us to submit patches back to wine. The long term goal is to make all of the WINE dlls upgrade able at anytime. So if you have a idea about a better way to do it then please let me know. Our branch is a little odd because it was not tagget right when they first committed it to CVS. It doesnt really matter to much about the version numbers though because we know where changes have been made on the ReactOS side by the #ifdefs. Thanks Steven --- Jurgen Van Gael <jurgen.vangael(a)student.kuleuven.ac.be> wrote: > Hi Steven, > > I set up my box here in France, and am starting to > code again. My > question: > I am not that experienced with forking etc ... So > should I modify the > dll's in the reactos tree and submit patches, diffs > or new files to > reactos, or do I submit all my work to WINE? > > Jurgen __________________________________________________ Do You Yahoo!? Sign up for SBC Yahoo! Dial - First Month Free http://sbc.yahoo.com

1 0

Apps that installs VBA
by Max 07 Jul '02

07 Jul '02

Installing AutoCAD 14, I get everytimes an error telling that VBA (visual basic for applications) cannot be installed (the messagebox tells a very very meaningful 'error 18' (sigh) and aborts VBA setup). As I've seen that someone is working on visual basic apps (maybe Ann and Jason Edmeades ?), does someone have an idea of the solution ? Regards Max

3 5

Re: Suggested bitmap coords resolve
by Andreas Mohr 07 Jul '02

07 Jul '02

On Sun, Jun 23, 2002 at 06:18:13PM +0300, P. Christeas wrote: > This patch resolves some trouble with bitmap drawing (DIBs), when the y-axis > uses negative mapping (LPtoDP). This makes Aut0CaD r. 14 usable under wine. > Please note bug #720, which was closed by this patch and note any problems w. > the patch. > > The second patch is a simple suggestion about a NULL handler. IMHO all NULLs > coming from external programs-libs should be handled in a prog. In that case, > a NULL causes no harm, but I guess my 'early test' may introduce a minor > speedup. "Am I right?" No, IMO this is not correct. If Windows doesn't handle NULLs, then we shouldn't either. How are we supposed to detect problems with our API implementation if all we ever do is handle every single problem gracefully ? That way we'll never find out about that grave implementation problem of ours leading to a NULL value... -- "My attitude is, everybody should try competing with Microsoft once in their life. Once." - Marc Andreessen, former Netscape lead employee, in a "browser wars" interview

2 1

Wrote an graphical wine.config frontend
by Clemens Eisserer 06 Jul '02

06 Jul '02

Hi Wine-Hackers! I wrote an graphical tool to make the administrations of the config-file easier for those windosen. Currently its only an prototype and isnt very stable. Its written in Java, compiled into native-Unix-binaries and it uses java-gtk as gui-toolkit. Its nearly as fast as C++ but coding is much easier and faster. I added a screenhot, and I hope that nobody's angry about the big download-size :-( My problem is that I dontknow all the wine.config options avaible, I've just implemented all active and all not active (;) options, only the program-specific setting are still not implemented and they wont be implemented in the near future. So is there an overview avaible, which explains all the options aviable in the config? Thx , Linuxhippy

1 0

Graphical Configuration-Tool for wine.conf
by Clemens Eisserer 06 Jul '02

06 Jul '02

Hi! I'm one of two web-masters of www.linux-wine.de . Many people in our forum asked for a graphical frontend to the wine.config. And because google didnt find anything, I've just wrote a prototype. Its written in Java, is compiled to a native-Linux program via gcj and uses java-gtk as toolkit. It is nearyl as fast as a C++ program, but coding is much faster und easier. And (for all GNU-fanatics) its fully GPL-compatible.... My problem is, that I dont know all options of the config-file. Till now I only implemented the options which stands in my wine-config, including the ;-Entries. Only the specific-program settings are not iplemented, its too hard to make this part GUI-based (I'm so sorry, but my english is terrible). Is there somewhere an overview over all avaible options? Is such a tool already avaible, or an existing codebase? Please note that Jine (Jawy after the rewrite) isnt ready for use. O.K it does work, but the code is awful and I'm currently working on a rewrite. May I ask wine-questions for this tool at this list? Thx , Linuxhippy

2 1

Strange behaviour -- app starts only with --debugmsg+snoop
by Max 06 Jul '02

06 Jul '02

AutoCAD again ! After finally R14 runs fine, i'm trying with AutoCAD 2000. Setup goes ok (besides usual VBA problem). Starting with 'wine acad' gives a very early error of unhandled access violation. I tried to start it with --debugmsg +snoop to see what happened and, surprise, app starts up quite good. It then hangs much later, but that's another problem. So the question : how it's possible that requesting snoop messages bypasses the initial access violation ? I think that snoop adds only a thunk to calls on native dlls.... Any suggestion appreciated ! Regards Max

3 2

Re: The filedlg95 behaviour
by Ann and Jason Edmeades 06 Jul '02

06 Jul '02

This leads to an interesting question. The MSDN states (edited for w2k behaviour but others are teh same): Initial Dir: Pointer to a null terminated string that can specify the initial directory. The algorithm for selecting the initial directory varies on different platforms. Windows 2000: ------------- If lpstrFile contains a path, that path is the initial directory. Otherwise, lpstrInitialDir specifies the initial directory. If lpstrInitialDir is NULL and the current directory contains any files of the specified filter types, the initial directory is the current directory. Otherwise, if the application has used an Open or Save As dialog box in the past, the path most recently used is selected as the initial directory. However, if an application is not run for a long time, its saved selected path will be discarded. *****> Otherwise, the initial directory is the personal files directory of the current user. Otherwise, the initial directory is the Desktop folder. Questions... Windows has the 'personal files' directory set to My Documents - That is why when doing this patch I implemented it that way. If you are saying you would prefer the home directory to be this, then why dont we make the Personal Files registry key always point to the users home directory? We either have complete compatibility eg. files go in ~ which is the Unix methodology, but windows apps looking in \My Documents directly would work, or we can try to slightly unix-ify the windows way and use ~ as the My Documents directory. I'm not convinced a patch should be submitted unless this is addressed. I have no problems assuming my change is not 100% correct, but we dont want a bounce of patches where someone tries to swap it back later to fix a specific unix app. BTW It is not a registry key directly which changes the behaviour, moreover which version of windows is trying to be emulated by Wine at that time. Regards, Jason

1 0

Re: wine/ dlls/dsound/dsound_main.c dlls/x11drv/x1 ...
by Steven Edwards 06 Jul '02

06 Jul '02

> Log message: > No need to call GetModuleFileName16 now that > GetModuleFileNameA > handles 16-bit tasks. With this patch I can now build dsound on Mingw if I import ntdll. Are there going to be other places like this where the A/W function can be used rather then the 16? Thanks Steven __________________________________________________ Do You Yahoo!? Sign up for SBC Yahoo! Dial - First Month Free http://sbc.yahoo.com

2 2

Re: ShellExecute placeholder patch
by Eric Pouech 06 Jul '02

06 Jul '02

Duane Clark a écrit : > > As the comment to ShellExecute states, there can be placeholders in > commandlines retrieved from the registry. For example, MS Installer has > this string: [snip] Hi Duane, It would be better IMO to merge actually ShellExecute and ShellExecuteEx Most of what you need is already in ShellExecute but not in ShellExecuteEx (of course, ShellExecute should call ShellExecuteEx, but this isn't done yet) A+

2 2

The filedlg95 behavior
by Duane Clark 06 Jul '02

06 Jul '02

I was hoping to perhaps provoke discussion of the new behavior of the file dialog. Prior to this patch: http://www.winehq.com/hypermail/wine-cvs/2002/06/0028.html the default behavior was to start the open file dialog in the current directory. After the patch, the default behavior is to start in the C:\My Documents directory, though this can be changed with a registry key. While this is the default behavior on Windows, I am not sure that wine should copy this behavior so precisely. I personally think that the old behavior was better. I would think that very few Linux users would actually use the C:\My Documents directory. But perhaps my own preferences are coloring my views. I think the command line oriented nature of Linux would call for a occasional differences in behavior. Duane

2 2

RegEnumValueA bugs and patch in dlls/advapi32/registry.c
by Max 05 Jul '02

05 Jul '02

Well, finally found and corrected a bug that made AutoCAD R14 hang... I guess some other apps could have the same problem solved, but had no time to test more :) In RegEnumValueA, when the size for requested data buffer is too small, function should return an error (as it does), but also return correct buffer size (as it doesn't). Found in AutoCAD; it asked for a reistry key value, got error, and then looped forever trying to get val with wrong buffer size. I guess, but had no time yet to check, that this problem could happen somwhere else in Registry.c, I'll check it out next days. With this patch, finally AutoCAD R14 is perfectly usable in wine, even without a native windows installed ! Here the patch : --- dlls/advapi32/registry.c Sat Jul 6 01:29:08 2002 +++ /home/massimo/wine-patches/registry.c Sat Jul 6 01:35:32 2002 @@ -1157,6 +1157,9 @@ RtlUnicodeToMultiByteSize( &len, info->Name, info->NameLength ); if (len >= *val_count) { + /* CHANGELOG : 04.07.2002 by Max + MUST RETURN REQUESTED CORRECT BUFFER SIZE, NOT ONLY TELL IT'S WRONG */ + *val_count = len + 1 ; status = STATUS_BUFFER_OVERFLOW; goto done; } @@ -1174,6 +1177,9 @@ { if (len > *count) { + /* CHANGELOG : 04.07.2002 by Max + MUST RETURN REQUESTED CORRECT BUFFER SIZE, NOT ONLY TELL IT'S WRONG */ + *count = len+1 ; status = STATUS_BUFFER_OVERFLOW; goto done; } I'll just post it to wine-patches too. Regards Max

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel