wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Problem in winpos.c which ends in a infinite loop
by Christian Costa 29 May '02

29 May '02

Hi everyone, I tried to install the game Zork : Grand Inquisitor ( probably a win16 app) and the installer crashed. With the debugger, I Obtained the attached log. As you can see 1) CreateWindowExA is called (9170) 2) X11DRV_CreateWindow send the WM_CREATE message to the window (9168) 3) the window procedure of the app is executed (9162) and call SetForegroundWindow (9161) 4) WINPOS_SetActiveWindows is then called (9160) and send the WM_QUERYNEWPALETTE (9159) 5) When the windows procedure receive the message (9153), it call SetForegroundWindow (9152) 6) return to 4 Commenting the lines (see attached diff) in winpos.c wich send the WM_QUERYNEWPALETTE avoids the infinite loop and makes the installer work. The installer runs perfectly under Windows 98. It seems that the app's windows procedure does not expect a WM_QUERYNEWPALETTE message. If someone that knows this code well have an idea... else I will report this bug to bugzilla. Ciao, Christian 9084 0x40698fe2 (CallWindowProcW+0xb2(func=0x40ec0412, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2831] in user32.dll.so) (ebp=405d428c) 9085 0x406a8e77 (call_window_proc+0xd7(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1368] in user32.dll.so) (ebp=405d42e8) 9086 0x406a9ab1 (SendMessageTimeoutW+0xe1(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x405d436c) [message.c:1738] in user32.dll.so) (ebp=405d4348) 9087 0x406a9d37 (SendMessageW+0x37(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0) [message.c:1818] in user32.dll.so) (ebp=405d437c) 9088 0x40691780 (WINPOS_SetActiveWindow+0x230(hWnd=0x10021, fMouse=0x0, fChangeFocus=0x1) [winpos.c:1282] in user32.dll.so) (ebp=405d43d4) 9089 0x406909fa (SetForegroundWindow+0x7a(hwnd=0x10021) [winpos.c:762] in user32.dll.so) (ebp=405d43f0) 9090 0x0040535d (splash.exe..text+0x435d in H:\splash\splash.exe) (ebp=405d4644) 9091 0x406924dd (WINPROC_CallWndProc+0x8d(proc=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:183] in user32.dll.so) (ebp=405d4674) 9092 0x40698989 (WINPROC_CallProc32WTo32A+0xc9(func=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2616] in user32.dll.so) (ebp=405d469c) 9093 0x40698fe2 (CallWindowProcW+0xb2(func=0x40ec0412, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2831] in user32.dll.so) (ebp=405d46d0) 9094 0x406a8e77 (call_window_proc+0xd7(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1368] in user32.dll.so) (ebp=405d472c) 9095 0x406a9ab1 (SendMessageTimeoutW+0xe1(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x405d47b0) [message.c:1738] in user32.dll.so) (ebp=405d478c) 9096 0x406a9d37 (SendMessageW+0x37(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0) [message.c:1818] in user32.dll.so) (ebp=405d47c0) 9097 0x40691780 (WINPOS_SetActiveWindow+0x230(hWnd=0x10021, fMouse=0x0, fChangeFocus=0x1) [winpos.c:1282] in user32.dll.so) (ebp=405d4818) 9098 0x406909fa (SetForegroundWindow+0x7a(hwnd=0x10021) [winpos.c:762] in user32.dll.so) (ebp=405d4834) 9099 0x0040535d (splash.exe..text+0x435d in H:\splash\splash.exe) (ebp=405d4a88) 9100 0x406924dd (WINPROC_CallWndProc+0x8d(proc=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:183] in user32.dll.so) (ebp=405d4ab8) 9101 0x40698989 (WINPROC_CallProc32WTo32A+0xc9(func=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2616] in user32.dll.so) (ebp=405d4ae0) 9102 0x40698fe2 (CallWindowProcW+0xb2(func=0x40ec0412, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2831] in user32.dll.so) (ebp=405d4b14) 9103 0x406a8e77 (call_window_proc+0xd7(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1368] in user32.dll.so) (ebp=405d4b70) 9104 0x406a9ab1 (SendMessageTimeoutW+0xe1(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x405d4bf4) [message.c:1738] in user32.dll.so) (ebp=405d4bd0) 9105 0x406a9d37 (SendMessageW+0x37(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0) [message.c:1818] in user32.dll.so) (ebp=405d4c04) 9106 0x40691780 (WINPOS_SetActiveWindow+0x230(hWnd=0x10021, fMouse=0x0, fChangeFocus=0x1) [winpos.c:1282] in user32.dll.so) (ebp=405d4c5c) 9107 0x406909fa (SetForegroundWindow+0x7a(hwnd=0x10021) [winpos.c:762] in user32.dll.so) (ebp=405d4c78) 9108 0x0040535d (splash.exe..text+0x435d in H:\splash\splash.exe) (ebp=405d4ecc) 9109 0x406924dd (WINPROC_CallWndProc+0x8d(proc=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:183] in user32.dll.so) (ebp=405d4efc) 9110 0x40698989 (WINPROC_CallProc32WTo32A+0xc9(func=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2616] in user32.dll.so) (ebp=405d4f24) 9111 0x40698fe2 (CallWindowProcW+0xb2(func=0x40ec0412, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2831] in user32.dll.so) (ebp=405d4f58) 9112 0x406a8e77 (call_window_proc+0xd7(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1368] in user32.dll.so) (ebp=405d4fb4) 9113 0x406a9ab1 (SendMessageTimeoutW+0xe1(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x405d5038) [message.c:1738] in user32.dll.so) (ebp=405d5014) 9114 0x406a9d37 (SendMessageW+0x37(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0) [message.c:1818] in user32.dll.so) (ebp=405d5048) 9115 0x40691780 (WINPOS_SetActiveWindow+0x230(hWnd=0x10021, fMouse=0x0, fChangeFocus=0x1) [winpos.c:1282] in user32.dll.so) (ebp=405d50a0) 9116 0x406909fa (SetForegroundWindow+0x7a(hwnd=0x10021) [winpos.c:762] in user32.dll.so) (ebp=405d50bc) 9117 0x0040535d (splash.exe..text+0x435d in H:\splash\splash.exe) (ebp=405d5310) 9118 0x406924dd (WINPROC_CallWndProc+0x8d(proc=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:183] in user32.dll.so) (ebp=405d5340) 9119 0x40698989 (WINPROC_CallProc32WTo32A+0xc9(func=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2616] in user32.dll.so) (ebp=405d5368) 9120 0x40698fe2 (CallWindowProcW+0xb2(func=0x40ec0412, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2831] in user32.dll.so) (ebp=405d539c) 9121 0x406a8e77 (call_window_proc+0xd7(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1368] in user32.dll.so) (ebp=405d53f8) 9122 0x406a9ab1 (SendMessageTimeoutW+0xe1(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x405d547c) [message.c:1738] in user32.dll.so) (ebp=405d5458) 9123 0x406a9d37 (SendMessageW+0x37(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0) [message.c:1818] in user32.dll.so) (ebp=405d548c) 9124 0x40691780 (WINPOS_SetActiveWindow+0x230(hWnd=0x10021, fMouse=0x0, fChangeFocus=0x1) [winpos.c:1282] in user32.dll.so) (ebp=405d54e4) 9125 0x406909fa (SetForegroundWindow+0x7a(hwnd=0x10021) [winpos.c:762] in user32.dll.so) (ebp=405d5500) 9126 0x0040535d (splash.exe..text+0x435d in H:\splash\splash.exe) (ebp=405d5754) 9127 0x406924dd (WINPROC_CallWndProc+0x8d(proc=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:183] in user32.dll.so) (ebp=405d5784) 9128 0x40698989 (WINPROC_CallProc32WTo32A+0xc9(func=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2616] in user32.dll.so) (ebp=405d57ac) 9129 0x40698fe2 (CallWindowProcW+0xb2(func=0x40ec0412, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2831] in user32.dll.so) (ebp=405d57e0) 9130 0x406a8e77 (call_window_proc+0xd7(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1368] in user32.dll.so) (ebp=405d583c) 9131 0x406a9ab1 (SendMessageTimeoutW+0xe1(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x405d58c0) [message.c:1738] in user32.dll.so) (ebp=405d589c) 9132 0x406a9d37 (SendMessageW+0x37(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0) [message.c:1818] in user32.dll.so) (ebp=405d58d0) 9133 0x40691780 (WINPOS_SetActiveWindow+0x230(hWnd=0x10021, fMouse=0x0, fChangeFocus=0x1) [winpos.c:1282] in user32.dll.so) (ebp=405d5928) 9134 0x406909fa (SetForegroundWindow+0x7a(hwnd=0x10021) [winpos.c:762] in user32.dll.so) (ebp=405d5944) 9135 0x0040535d (splash.exe..text+0x435d in H:\splash\splash.exe) (ebp=405d5b98) 9136 0x406924dd (WINPROC_CallWndProc+0x8d(proc=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:183] in user32.dll.so) (ebp=405d5bc8) 9137 0x40698989 (WINPROC_CallProc32WTo32A+0xc9(func=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2616] in user32.dll.so) (ebp=405d5bf0) 9138 0x40698fe2 (CallWindowProcW+0xb2(func=0x40ec0412, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2831] in user32.dll.so) (ebp=405d5c24) 9139 0x406a8e77 (call_window_proc+0xd7(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1368] in user32.dll.so) (ebp=405d5c80) 9140 0x406a9ab1 (SendMessageTimeoutW+0xe1(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x405d5d04) [message.c:1738] in user32.dll.so) (ebp=405d5ce0) 9141 0x406a9d37 (SendMessageW+0x37(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0) [message.c:1818] in user32.dll.so) (ebp=405d5d14) 9142 0x40691780 (WINPOS_SetActiveWindow+0x230(hWnd=0x10021, fMouse=0x0, fChangeFocus=0x1) [winpos.c:1282] in user32.dll.so) (ebp=405d5d6c) 9143 0x406909fa (SetForegroundWindow+0x7a(hwnd=0x10021) [winpos.c:762] in user32.dll.so) (ebp=405d5d88) 9144 0x0040535d (splash.exe..text+0x435d in H:\splash\splash.exe) (ebp=405d5fdc) 9145 0x406924dd (WINPROC_CallWndProc+0x8d(proc=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:183] in user32.dll.so) (ebp=405d600c) 9146 0x40698989 (WINPROC_CallProc32WTo32A+0xc9(func=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2616] in user32.dll.so) (ebp=405d6034) 9147 0x40698fe2 (CallWindowProcW+0xb2(func=0x40ec0412, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2831] in user32.dll.so) (ebp=405d6068) 9148 0x406a8e77 (call_window_proc+0xd7(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1368] in user32.dll.so) (ebp=405d60c4) 9149 0x406a9ab1 (SendMessageTimeoutW+0xe1(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x405d6148) [message.c:1738] in user32.dll.so) (ebp=405d6124) 9150 0x406a9d37 (SendMessageW+0x37(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0) [message.c:1818] in user32.dll.so) (ebp=405d6158) 9151 0x40691780 (WINPOS_SetActiveWindow+0x230(hWnd=0x10021, fMouse=0x0, fChangeFocus=0x1) [winpos.c:1282] in user32.dll.so) (ebp=405d61b0) 9152 0x406909fa (SetForegroundWindow+0x7a(hwnd=0x10021) [winpos.c:762] in user32.dll.so) (ebp=405d61cc) 9153 0x0040535d (splash.exe..text+0x435d in H:\splash\splash.exe) (ebp=405d6420) 9154 0x406924dd (WINPROC_CallWndProc+0x8d(proc=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:183] in user32.dll.so) (ebp=405d6450) 9155 0x40698989 (WINPROC_CallProc32WTo32A+0xc9(func=0x404cc0, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2616] in user32.dll.so) (ebp=405d6478) 9156 0x40698fe2 (CallWindowProcW+0xb2(func=0x40ec0412, hwnd=0x10021, msg=0x30f, wParam=0x0, lParam=0x0) [winproc.c:2831] in user32.dll.so) (ebp=405d64ac) 9157 0x406a8e77 (call_window_proc+0xd7(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1368] in user32.dll.so) (ebp=405d6508) 9158 0x406a9ab1 (SendMessageTimeoutW+0xe1(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x405d658c) [message.c:1738] in user32.dll.so) (ebp=405d6568) 9159 0x406a9d37 (SendMessageW+0x37(hwnd=0x10021, msg=0x30f, wparam=0x0, lparam=0x0) [message.c:1818] in user32.dll.so) (ebp=405d659c) 9160 0x40691780 (WINPOS_SetActiveWindow+0x230(hWnd=0x10021, fMouse=0x0, fChangeFocus=0x1) [winpos.c:1282] in user32.dll.so) (ebp=405d65f4) 9161 0x406909fa (SetForegroundWindow+0x7a(hwnd=0x10021) [winpos.c:762] in user32.dll.so) (ebp=405d6610) 9162 0x00404b62 (splash.exe..text+0x3b62 in H:\splash\splash.exe) (ebp=405d697c) 9163 0x406924dd (WINPROC_CallWndProc+0x8d(proc=0x404cc0, hwnd=0x10021, msg=0x1, wParam=0x0, lParam=0x405d6d24) [winproc.c:183] in user32.dll.so) (ebp=405d69ac) 9164 0x40698ed2 (CallWindowProcA+0xb2(func=0x404cc0, hwnd=0x10021, msg=0x1, wParam=0x0, lParam=0x405d6d24) [winproc.c:2795] in user32.dll.so) (ebp=405d69e0) 9165 0x406a8ea3 (call_window_proc+0x103(hwnd=0x10021, msg=0x1, wparam=0x0, lparam=0x405d6d24, unicode=0x0) [message.c:1372] in user32.dll.so) (ebp=405d6a3c) 9166 0x406a9c0d (SendMessageTimeoutA+0xed(hwnd=0x10021, msg=0x1, wparam=0x0, lparam=0x405d6d24, flags=0x0, timeout=0xffffffff, res_ptr=0x405d6ac0) [message.c:1786] in user32.dll.so) (ebp=405d6a9c) 9167 0x406a9d87 (SendMessageA+0x37(hwnd=0x10021, msg=0x1, wparam=0x0, lparam=0x405d6d24) [message.c:1829] in user32.dll.so) (ebp=405d6ad0) 9168 0x409b7702 (X11DRV_CreateWindow+0x572(hwnd=0x10021, cs=0x405d6d24, unicode=0x0) [window.c:1005] in x11drv.dll.so) (ebp=405d6b44) 9169 0x4068bd20 (WIN_CreateWindowEx+0x590(cs=0x405d6d24, classAtom=0xc00d, type=0x2) [win.c:1154] in user32.dll.so) (ebp=405d6c0c) 9170 0x4068c17e (CreateWindowExA+0x14e(exStyle=0x0, className=0x411b3c, windowName=0x41c60d50, style=0x80880000, x=0x0, y=0x0, width=0x400, height=0x300, parent=0x0, menu=0x0, instance=0x400000, data=0x0) [win.c:1309] in user32.dll.so) (ebp=405d6d60) 9171 0x00405cd1 (splash.exe..text+0x4cd1 in H:\splash\splash.exe) (ebp=405d6e90) 9172 0x400ca01b (start_process+0x24b [process.c:526] in libntdll.dll.so) (ebp=405d6f38) 9173 0x400ce257 (call_on_thread_stack+0x27(func=0x400c9dd0) [sysdeps.c:105] in libntdll.dll.so) (ebp=405d6ff4) 9174 0x400ce410 (SYSDEPS_CallOnStack+0x14 in libntdll.dll.so) (ebp=00000000) Index: winpos.c =================================================================== RCS file: /home/wine/wine/windows/winpos.c,v retrieving revision 1.133 diff -u -r1.133 winpos.c --- winpos.c 25 May 2002 22:16:13 -0000 1.133 +++ winpos.c 29 May 2002 17:38:49 -0000 @@ -1278,8 +1278,10 @@ PERQDATA_SetActiveWnd( pOldActiveQueue->pQData, 0 ); /* send palette messages */ + /* if (hWnd && SendMessageW( hWnd, WM_QUERYNEWPALETTE, 0, 0L)) SendMessageW( HWND_BROADCAST, WM_PALETTEISCHANGING, (WPARAM)hWnd, 0 ); + */ /* if prev wnd is minimized redraw icon title */ if( IsIconic( hwndPrevActive ) ) WINPOS_RedrawIconTitle(hwndPrevActive);

2 2

RE: Stripping of whitespaces at the end of lines
by Patrik Stridvall 29 May '02

29 May '02

> Enforcing 'no space before the non-blank char on every line' is > orders of magniture more difficult than 'indentation is 4 space' Is it? find . -name \*.c | xargs perl -ne '/^\s*/ && $& =~ / / && do { print }' compared to find . -name \*.c | xargs perl -ne '!/^(?: )*/ && do { print }' Of course both will fail on Wine style function header comments but then you got what you asked for above. Anyway. I fully agree what you (Dimitrie) that the point of indentation is to make it human readable not easy for tools to verify. In fact I think I agree with almost everything you have said on the subject. So for once we agree. :-)

1 0

Quick question on the Cygwin/Mingw port
by Steven Edwards 29 May '02

29 May '02

Hola, I'm on the road traveling till Monday so I sent the question here rather then cygwin support because I figured someone here has to have a little cygwin and mingw experience. I'm using cygwin to host my mingw WINE devel with --target=mingw --host-mingw --build=mingw -mno-cygwin and -fnative-struct and it is still linking to cygwin1.dll. I don't really understand whats going on because it doesn't seem to be using any of the exports from cygwin1.dll but if I try to test the dlls/programs/tools on another box it bitches about missing the dll. If anyone has any insight please let me know or just send this to /dev/null Thanks Steven "Every revolution was once a thought in one man's mind" - Ralph Waldo Emerson

3 3

Use of wine RPC implementation for TAPI 2 client ?
by Yann Dirson 29 May '02

29 May '02

We're investigating the implementation of a TAPI 2 client lib on Linux. Wine looks like one of the projects with an implementation of DCE/MS-RPC. What's the status of this RPC implementation, in terms of specs coverage, and stability ? Do you have an MIDL compiler ? Regards, -- Yann Dirson <Yann.Dirson(a)fr.alcove.com> http://www.alcove.com/ Technical support manager Responsable de l'assistance technique Senior Free-Software Consultant Consultant senior en Logiciels Libres Debian developer (dirson(a)debian.org) Développeur Debian

2 1

More regression errors ...
by Paul Millar 29 May '02

29 May '02

Hi, I've noticed that amongst last night's slew of patches, Mehmet's regression tests were applied without his patches that correct wine's behaviour. Wine now fails regression tests on all platforms. If his patches are delayed for some reason, could/should we use todo_wine to acknowledge that these failures are known? If so, I've attached a trivial patch to do this for the tests that failed for me ... ChangeLog: Mark failing regression tests as todo Cheers, ---- Paul Millar

2 1

Re: [Bug 722] Changed - GDI.EXE
by Andriy Palamarchuk 29 May '02

29 May '02

--- Johan Gill <johane(a)lysator.liu.se> wrote: > On Tue, 28 May 2002 wine-bugs(a)winehq.com wrote: > > > Some rights wouldn't hurt btw. > > + > > + > > + ------- Additional Comments From > Speeddymon(a)yahoo.com 2002-05-28 15:14 ------- > > + Send an email to wine-bugs(a)winehq.com asking > someone to give you additional > > + BugZilla priveleges so that you may work on bug > 722 > > So here's an offical request for privileges. Done. Official congratulations with new privileges :-) Andriy __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com

1 0

Main window size difference
by Guy L. Albertelli 29 May '02

29 May '02

Has anyone else noticed that the size of main windows under Windows is much different than under Wine. As an example, using the Tab control test program (from the ControlSpy series). Under Windows the overall size appears to be about 819x564. Under Wine it is about 505x268. (I may be off by 1 or 2 pixels, but not 30% to 40%.) And yes my screen resolution under both systems is 1024x768. This obviously makes doing pixel matching, or even item layout matching difficult. Guy Albertelli <<galberte(a)neo.lrun.com>>

2 1

Re: Idea for people with priveleges
by Andriy Palamarchuk 29 May '02

29 May '02

--- Dustin Navea <speeddymon(a)yahoo.com> wrote: > Anyone that can modify the layout of the BugZilla > site > should take this into consideration: > > People with priveleges as you know can pretty much > do > what they need to with a bug, i.e. if it is resolved > and the person working on it forgot to set it as > resolved, anyone with preveleges can do that. But, > what about if we havent heard from the reporter in a > while and we need to knock the bug out, our only > option is to ask the reporter if it has been > resolved, > tell them to try it with a recent wine build and to > try some of the things mentioned in the comments, > and > then mark it as resolved and them after that mark it > as closed, so it is shown as closed and not resolved > on the bug list... > > why not give people with priveleges the ability to > close it without resolving it, so that they only > have > to make 1 post instead of 2? Plus that way we have > bugs that are actually resolved marked so, and ones > that we are unsure of marked as closed but can > always > be reopened... Why do you want to close such bug in the first place? IMHO it is Ok to put the bug in the RESOLVED state and wait some time if the original reporter provides feedback or more information will become available. Keeping the bug in RESOLVED state will insure that somebody will look at the bug one more time. Is this too many steps? >From Bugzilla docs: "QA looks at resolved bugs and to make sure the appropriate action has been taken. If they agree, the bug is marked VERIFIED. Bugs remain in this state until the product ships, at which time the bug is marked CLOSED." Currently we do not have one more "verification layer" for bugs. Andriy __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com

1 0

Something's wrong with hypermail
by Johan Gill 29 May '02

29 May '02

I've noticed that selecting 'Next message' in the web interface to the mailinglists sometimes skips messages. For example, take a look at my latest messages to wine-patches. Standing at the second 'PATCH: DirectSound', the next message is said to be 'Re: RESUBMIT: PATCH: DirectSound'. Hang on...this is the case for my mmioAdvance patch also! Ok, so my patches seem to confuse the interface :/ /Johan Gill, johane(a)lysator.liu.se

1 0

Re: some other playsound fixes
by Alexandre Julliard 29 May '02

29 May '02

Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > typedef struct tagWINE_PLAYSOUND { > - HANDLE hThread; > - HANDLE hReadyEvent; > - BOOL bStop; > - LPCWSTR pszSound; > - HMODULE hMod; > - DWORD fdwSound; > - BOOL bLoop; > - BOOL bAlloc; > + volatile BOOL bLoop : 1, > + bAlloc : 1; > + LPCWSTR pszSound; > + HMODULE hMod; > + DWORD fdwSound; > + struct tagWINE_PLAYSOUND* lpNext; > } WINE_PLAYSOUND, *LPWINE_PLAYSOUND; If you need to make variables volatile, something is wrong with the synchronization, and volatile is the wrong fix (especially on a bit field where updates can't be atomic). What is this supposed to fix? -- Alexandre Julliard julliard(a)winehq.com

2 1

Second current CVS compile failure
by Guy L. Albertelli 29 May '02

29 May '02

After bypassing previous error, got this one: gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall -fPIC -D__WINE_ _ -D_REENTRANT -I/usr/X11R6/include -o information.o information.c ld -r comcat_main.o factory.o manager.o register.o information.o -o comcat.dll.tmp.o strip --strip-unneeded comcat.dll.tmp.o LD_LIBRARY_PATH="../../library:../../unicode:$LD_LIBRARY_PATH" ../../tools/winebuild/winebuild -fPIC -D__WINE__ -sym comcat.dll.tmp.o -o comcat.spec.c -spec ./comcat.spec -L../../dlls -lole32 -ladvapi32 -lkernel32 gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall -fPIC -D__WINE_ _ -D_REENTRANT -I/usr/X11R6/include -o comcat.spec.o comcat.spec.c LD_LIBRARY_PATH="../../library:../../unicode:$LD_LIBRARY_PATH" ../../tools/winebuild/winebuild -fPIC -D__WINE__ -o comcat.dll.dbg.c -debug -C. comcat_main.c factory.c manager.c register.c information.c gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall -fPIC -D__WINE_ _ -D_REENTRANT -I/usr/X11R6/include -o comcat.dll.dbg.o comcat.dll.dbg.c gcc -shared -Wl,-Bsymbolic comcat.spec.o comcat_main.o factory.o manager.o register.o information.o comcat.dll.dbg.o -o omcat.dll.so -L../../dlls -L../../library -lwine -L../../ole -lwine_uuid -l m information.o: In function `COMCAT_GetCategoryDesc': /home/albertel/t1/wine/dlls/comcat/information.c:392: undefined reference to `swprintf' collect2: ld returned 1 exit status make[2]: *** [comcat.dll.so] Error 1 Guy Albertelli <<galberte(a)neo.lrun.com>>

2 1

RFC - patch for psapi and missing imports on Mingw target
by Steven Edwards 29 May '02

29 May '02

This kind of a dirty hack but just a idea and it shouldn't have a effect on cygwin as it will use the win32api package also. Mabey a better name then MINGW_IMPORTS can be used. This patch allows psapi.dll to be (almost) built. Mingws libkernel32.a doesn't contain the import information for the toolhelp APIs. Instead it models Visual Studio 6 and implents them in libth32.a. Does anyone know if this has changed in Visual Studio .NET? If so then I will submit a patch to mingw for the Win32api. If not, then I belive using libth32.a is the most proper way. Would a better solution be for me to make the make implib rule and just use wines libkernel32.a? I havent really looked at doing it because NTDLL, MSVCRT,GDI,USER and KERNEL32 are not targets of my port and may contain exports lacking on a Windows host. The only bug after this patch is - psapi_main.o(.text+0x1248):psapi_main.c: undefined reference to `wine_server_cal l' Thanks Steven "Every revolution was once a thought in one man's mind" - Ralph Waldo Emerson cvs diff -u Makedll.rules.in Index: Makedll.rules.in =================================================================== RCS file: /home/wine/wine/dlls/Makedll.rules.in,v retrieving revision 1.27 diff -u -r1.27 Makedll.rules.in --- Makedll.rules.in 22 May 2002 21:32:49 -0000 1.27 +++ Makedll.rules.in 29 May 2002 05:32:10 -0000 @@ -35,7 +35,7 @@ # Rules for .dll files $(MODULE): $(OBJS) $(MODULE).dbg.o $(SPEC_DEF) Makefile.in - $(DLLWRAP) $(DLLWRAPFLAGS) --def $(SPEC_DEF) --implib $(MODULE:.dll=.a) -o $@ $(OBJS) $(MODULE).dbg.o -L$(DLLDIR) $(DELAYIMPORTS:%=-l%) $(IMPORTS:%=-l%) $(ALL_LIBS) + $(DLLWRAP) $(DLLWRAPFLAGS) --def $(SPEC_DEF) --implib $(MODULE:.dll=.a) -o $@ $(OBJS) $(MODULE).dbg.o -L$(DLLDIR) $(DELAYIMPORTS:%=-l%) $(IMPORTS:%=-l%) $(MINGW_IMPORTS) $(ALL_LIBS) $(SPEC_DEF): $(WINEBUILD) cvs diff -u Makefile.in Index: Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/psapi/Makefile.in,v retrieving revision 1.11 diff -u -r1.11 Makefile.in --- Makefile.in 11 May 2002 23:06:34 -0000 1.11 +++ Makefile.in 29 May 2002 05:33:48 -0000 @@ -4,6 +4,7 @@ VPATH = @srcdir@ MODULE = psapi.dll IMPORTS = kernel32 ntdll +MINGW_IMPORTS = -lth32 LDDLLFLAGS = @LDDLLFLAGS@ SYMBOLFILE = $(MODULE).tmp.o

1 0

Current CVS compile failure
by Guy L. Albertelli 29 May '02

29 May '02

Using the current CVS I get the following errors compiling Cdrom.c. My Linux version is a pretty stock 2.2.12 (yes it is old). Have we terminated support for older versions?? gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall -fPIC -D__WINE_ _ -D_NTSYSTEM_ -DBINDIR="\"/usr/local/bin\"" -DETCDIR="\"/usr/local/etc\"" -D_REENTRANT -I/usr/X11R6/include -o cdrom.o cdrom.c cdrom.c:83: `CDROM_PACKET_SIZE' undeclared here (not in a function) cdrom.c: In function `CDROM_GetIdeInterface': cdrom.c:119: `SG_EMULATED_HOST' undeclared (first use in this function) cdrom.c:119: (Each undeclared identifier is reported only once cdrom.c:119: for each function it appears in.) cdrom.c: In function `CDROM_ScsiPassThroughDirect': cdrom.c:1071: storage size of `sense' isn't known cdrom.c:1097: `CGC_DATA_WRITE' undeclared (first use in this function) cdrom.c:1100: `CGC_DATA_READ' undeclared (first use in this function) cdrom.c:1103: `CGC_DATA_NONE' undeclared (first use in this function) cdrom.c:1109: `CDROM_SEND_PACKET' undeclared (first use in this function) cdrom.c:1071: warning: unused variable `sense' cdrom.c: In function `CDROM_ScsiPassThrough': cdrom.c:1134: storage size of `sense' isn't known cdrom.c:1167: `CGC_DATA_WRITE' undeclared (first use in this function) cdrom.c:1170: `CGC_DATA_READ' undeclared (first use in this function) cdrom.c:1173: `CGC_DATA_NONE' undeclared (first use in this function) cdrom.c:1179: `CDROM_SEND_PACKET' undeclared (first use in this function) cdrom.c:1134: warning: unused variable `sense' make[2]: *** [cdrom.o] Error 1 I did a search and some of these symbols didn't show up till 2.2.16 or later. Guy Albertelli <<galberte(a)neo.lrun.com>>

1 0

Re: Font patch
by Dmitry Timoshkov 29 May '02

29 May '02

"Dustin Navea" <speeddymon(a)yahoo.com> wrote: > This basically just adds Aliases for some of MS's > Default Fonts to the wine default config... fixes bug > #721... There is no need to add aliases to the config file. Config file should provide replacements for basic system fonts only, common aliases are handled by graphics/x11drv/xfont.c, XFONT_LoadAliases(). In the case of the client-side rendered fonts, there is some font aliasing code too. Probably it should be enhanced though. -- Dmitry.

1 0

Re: [Bug] #724 found! Someone needs to fix it?
by Andreas Mohr 28 May '02

28 May '02

On Tue, May 28, 2002 at 04:08:46PM -0500, Boris Reisig wrote: > Ive been downloading the latest CVS of wine and I have noticed that when doing a clean install of wine on a drive without windows, I have noticed that wine couldnt install Word '97 viewer, Office '97 setup, Excel '97 viewer.[Make sure you have a clean temp directory too] I have done *alot* of CVS regression thanks to Andriy Palamarchuk. This was the following error. > > err:font:ReadFontDir Can't open directory "/c/windows/Fonts" > err:module:PE_fixup_imports Modules (file) MSSETUP.dll (which is needed by E:\~MSSETUP.T\~msstfqf.t\acmsetup.exe) not found. > > So I have tracked it down to wine/files/profile.c May 11,2002 17:59:41 CDT. [http://www.winehq.com/hypermail/wine-cvs/2002/05/0092.html] > > If I CVS before that date/time, The applications work fine. Hope this helps someone to possible fix it? ---------------------------- revision 1.67 date: 2002/05/11 22:59:41; author: julliard; state: Exp; lines: +11 -5 Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> Make PROFILE_GetString account for default value in all cases. ---------------------------- Sounds like it's me then :-\ Argl. I really wonder how this could have broken it... Maybe via some unrelated function that uses the same profile function that I patched... Run wine --debugmsg +relay,+profile MyPrg.exe &>/tmp/wine.log before and after that patch , bzip2 or gzip wine.log and mail them to me. Thanks ! -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://mohr.de.tt

1 0

dinput keyboard patch
by arjen＠blehq.org 28 May '02

28 May '02

Why is my patch not committed?

1 0

Request for small build system change
by Steven Edwards 28 May '02

28 May '02

When I use cygwin or msys to build wine/tools I need to link to wrc and wmc to libberty.a. I've tried to write a little fix for it but havent had much luck and still have a few other things I am working on. Thanks Steven "Every revolution was once a thought in one man's mind" - Ralph Waldo Emerson

1 0

CoGetClassObject and multiple servers requested
by Medland, Bill 28 May '02

28 May '02

(I guess this is for Marcus) I thought I had heard something about Local Server COM being in place now but when I went to try it with our product I saw no attempt to do it (error message about CLSCTX_LOCAL_SERVER registered but not supported). So I looked at CoGetClassObject and I see that the Remote_CoGetClassObject (which I presume is attempting to do the LOCAL_SERVER) is only called if a local server is requested and an inproc server or handler is not. Is there a good reason why the Remote_CoGetClassObject is not called on failure to detect a registered inproc server or handler (which the existing structure of the function supported)? Bill

2 1

Why start a COM local server twice?
by Medland, Bill 28 May '02

28 May '02

Is this an oversight or a deliberate policy? Remote_CoGetClassObject creates the local server process and hands over to create_marshalled_proxy If create_marshalled_proxy can't immediately find the pipe then it will create the process again. Is it safe to drop the first one? How about the second? It looks to me as if Remote_CoGetClassObject is the only place that calls create_marshalled_proxy so I presume we can remove either. Bill

2 1

AppDB: A call for moderation ;-P
by Dustin Navea 28 May '02

28 May '02

After looking at the appdb, and seeing all these seemingly random posts for help and the replies, i.e. using winex over wine for games... I decided to call for some moderation and cleanup on the AppDB. I think that the appdb needs several things done to it to make it more functional and "user-friendly": 1) It needs moderators! 2) It needs to be threaded, i.e. different topics are actually separate, the replies dont just get mixed up with everyone else's... 3) The application owner should be the one that posts screenshots and determines the useability of the app/game/whatever under _wine_, not winex or anything else... 4) It needs links to Bugzilla so people aren't making posts for help that either go unanswered or get an answer that doesn't help them... For #1, the people that have priveleges on bugzilla, and the application owners should be moderators... For #2, the forums would have to be rewritten, but believe me, it would definitely enhance the readability and appeal of the site For #3, It would make it so that people can know at a glance whether their program will work or not, and also lets users contact the person in charge of that program's board for assistance in getting it to work under their copy of wine... For #4, For anything that the application owner can't figure out, or if the user would rather talk to one of the developers beforehand, the links would definitely be a help... say a link at the top of each page: For help with <insert name of app here>, check out Bugzilla at http://bugs.winehq.com Comments appreciated -Dustin __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com

3 2

Bug 717 - Was Re: [Bug 717] Changed - StarCraft Icons not created by wineshelllink
by Dustin Navea 28 May '02

28 May '02

--- wine-bugs(a)winehq.com wrote: > http://bugs.winehq.com/show_bug.cgi?id=717 > > *** shadow/717 Sun May 26 12:09:57 2002 > --- shadow/717.tmp.5845 Sun May 26 20:43:23 2002 > *************** > *** 149,151 **** > --- 149,158 ---- > > ------- Additional Comments From > Speeddymon(a)yahoo.com 2002-05-26 12:09 ------- > Changing CC's > + > + ------- Additional Comments From apa3a(a)yahoo.com > 2002-05-26 20:43 ------- > + Advise to discuss this issue on wine-devel. Not > everybody reviews Bugzilla logs. > + > + One more approach - if a target of a shell link > does not exist create a dummy > + target with some "UNKNOWN" icon, which will be > replaced later. I like this > + approach more. > \ No newline at end of file Here it is. Well, after looking at the code, I found out that it does create a key in RunOnce to create the icon after reboot, but the icon never gets created, I didn't do much investigation into why, but I do believe that the initialization of wine doesn't read RunOnce and so therefore the icons never get created. Also, after some more investigation, I found out that StarCraft.exe and StarEdit.exe don't get created until after the Windows Start Menu links get copied, so what needs to be done is either implement the runonce reading in wine init, or create an initscript that reads it and creates the icons with wineshelllink upon reboot, OR we can force icon extraction to be delayed somehow until after all other files have been extracted... I personally like the 2nd idea best, as it is 1) the easiest and 2) actually goes with the trace message of "Deferring Icon Creation to Reboot"... Actually, The 2nd idea could even go into the initscript that is posted in bugzilla already, its under one of the early bugs, the one about being able to double click the exe and it runs... -Dustin __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com

1 0

shlwapi shreg tests failed
by Sylvain Petreolle 28 May '02

28 May '02

../../programs/winetest/runtest -q -P wine -M shlwapi.dll -T ../.. -p tests/shlwapi_test tests/shreg.c && touch tests/shreg.ok tests/shreg.c:125: Test failed: (21,20) tests/shreg.c:145: Test failed: (21,20) (both are in test_SHQUeryValueEx) ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

2 8

Re: Improvement for GetTimeZoneInformation
by Huw D M Davies 28 May '02

28 May '02

On Mon, May 27, 2002 at 11:12:07PM -0400, Vincent Béron wrote: > I need some help to finish this implementation. I don't have access to > an english version of Windows NT4 or 2K or XP, so I couldn't finish the > array of the timezones. COuld somebody help me a bit on this one? I'm > planning on actually writing the equivalence in Unix timezones, so you > only need to give me the names of the Windows timezones. I have a small > program to help you if you need it. > > Changelog: > - Improves the implementation of GetTimeZoneInformation. Missing some > Windows timezone names. In Windows there's a whole load of TimeZone information under \HLKM\Software\Microsoft\Windows\CurrentVersion\Time Zones I expect we should read the data from there rather than hardcode it; all we'd need to add would be a lookup table of Unix TZ names. Huw.

1 0

Re: Time related functions patches (bug #725)
by Vincent Béron 28 May '02

28 May '02

Note to self: read the docs thoroughly before submitting a patch. These 2 patches replace the similarly named patches in the parent message. There was a slight problem in the daylight saving part. Changelog: - Fix LocalFileTimeToFileTime (was offset if daylight was active). - Fix FileTimeToLocalFileTime (the case when timegm is absent was wrong, and gave different results than timegm). Vincent diff -urN wine-orig/files/dos_fs.c wine-pas-compilé/files/dos_fs.c --- wine-orig/files/dos_fs.c Thu May 23 16:36:46 2002 +++ wine-pas-compilé/files/dos_fs.c Sun May 26 21:20:25 2002 @@ -2174,11 +2174,14 @@ { struct tm *xtm; DWORD remainder; + time_t utctime; - /* convert from local to UTC. Perhaps not correct. FIXME */ - time_t unixtime = DOSFS_FileTimeToUnixTime( localft, &remainder ); - xtm = gmtime( &unixtime ); - DOSFS_UnixTimeToFileTime( mktime(xtm), utcft, remainder ); + /* Converts from local to UTC. */ + time_t localtime = DOSFS_FileTimeToUnixTime( localft, &remainder ); + xtm = gmtime( &localtime ); + utctime = mktime(xtm); + if(xtm->tm_isdst > 0) utctime-=3600; + DOSFS_UnixTimeToFileTime( utctime, utcft, remainder ); return TRUE; } diff -urN wine-orig/files/dos_fs.c wine-pas-compilé/files/dos_fs.c --- wine-orig/files/dos_fs.c Thu May 23 16:36:46 2002 +++ wine-pas-compilé/files/dos_fs.c Sun May 26 21:20:25 2002 @@ -2193,7 +2193,7 @@ LPFILETIME localft ) { DWORD remainder; - /* convert from UTC to local. Perhaps not correct. FIXME */ + /* Converts from UTC to local. */ time_t unixtime = DOSFS_FileTimeToUnixTime( utcft, &remainder ); #ifdef HAVE_TIMEGM struct tm *xtm = localtime( &unixtime ); @@ -2203,14 +2203,13 @@ DOSFS_UnixTimeToFileTime( localtime, localft, remainder ); #else - struct tm *xtm,*gtm; - time_t time1,time2; + struct tm *xtm; + time_t time; - xtm = localtime( &unixtime ); - gtm = gmtime( &unixtime ); - time1 = mktime(xtm); - time2 = mktime(gtm); - DOSFS_UnixTimeToFileTime( 2*time1-time2, localft, remainder ); + xtm = gmtime( &unixtime ); + time = mktime(xtm); + if(xtm->tm_isdst > 0) time-=3600; + DOSFS_UnixTimeToFileTime( 2*unixtime-time, localft, remainder ); #endif return TRUE; }

1 0

Re: SafeDisc-1 semi-cleaned note...
by Laurent Pinchart 28 May '02

28 May '02

> > The second one has been written by Alexandre to fix the process > > suspension at creation time. Once again I'd like to hear from him to know > > what he doesn't like about the code, as he's the one who wrote it :-) > > And I would also like to see this patch converted/ported to the current cvs > wine. Because the init_event has gone, and so most of the code in this > patch does not pertain. > > I tried to do it myself, but have failed... So for now I cant update my > wine for the current cvs version (though I would like to :) I've just had a look at the code and I can't see a way to merge the patch. Alexandre, could you have a look at that ? It seems that you removed the init_event cause it wasn't needed anymore, but it is by SafeDisc. Or can you think about another way to fix that ? Thanks in advance. Laurent Pinchart

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel