wine-devel

wine-devel@winehq.org

10 participants
84459 discussions

X11DRV_DIB_[Get/Set]ImageBits in 1, 4 and 8 bit X modes.
by David Hammerton 22 Feb '02

22 Feb '02

Hi, I'm presently modifying the X11DRV dibsection code for slight speed improvements using shared memory pixmaps and the like. Im into the "clean up and make it work on all systems" stage of thing, and I have a question. Do people ever worry about what happens if the user is running in a 1, 4 or 8 bit X mode? This has some wacky code, which I am unable to test on my machine (or any machine around).. So i'm implementing what I think _should_ do the trick - but I have no idea if it will work.. Is it a big issue? Any suggestions to the problem? Thanks, David -- David Hammerton programmer and support TransGaming Technologies Inc. http://www.transgaming.com david(a)transgaming.com

4 3

Re: Fix spec definition for dplayx ordinal variable
by Alexandre Julliard 21 Feb '02

21 Feb '02

"Peter Hunnisett" <peter(a)transgaming.com> writes: > gdwDPlaySPRefCount is an exported ordinal variable might as well declare it as > such. Note that this creates a copy of the variable, so you can no longer reference it from the C code. I'm not sure this is what you meant to do. -- Alexandre Julliard julliard(a)winehq.com

2 2

Re: GetStdHandle Problem
by Ignasi Villagrasa 21 Feb '02

21 Feb '02

If there's a problem in Wine to get this function work, I'd like to know if, apart from updating Wine, I can do any change in the source code in order to make the program work. In addition, I'd like to know which libraries should I add to the linker process to get the symbols resolved ? Should I add msvcrt library ? Should I add ncurses library ? what about kernel, ntdll, wine, wine_unicode (These are the libraries tha resolve symbols by now) ? or Where could I find this information ? Thanks in advance. Ignasi Villagrasa.

2 1

db2html-winehq
by Philipp Wollermann 21 Feb '02

21 Feb '02

Hi everybody, I'm new to wine-development but I have used it for a long time now. :) Because I'm using the Crux 0.92 Linux distribution (which doesn't come with db2html, db2pdf etc.) I've used the db2html-winehq script which works quite well. Why isn't it used normally, but only in the make_winehq script? Perhaps someone could change configure.ac so, that it detects if the user has db2html and decides which one to use? I've made a patch for this script so it supports openjade/jade and the Crux distribution. Should I send it to the wine-patches mailinglist? Could someone tell me where to get these db2html etc. scripts? Philipp Wollermann

1 0

Re: Help tracing WINE funcion..
by Rick Romero 21 Feb '02

21 Feb '02

On Thu, 2002-02-21 at 10:18, lawson_whitney(a)juno.com wrote: > On 21 Feb 2002, Rick Romero wrote: > > > Hi all, > > > > I need some assistance.. I'm trying to trace a problem. The quick > > description is when I run the Visual FoxPro 5 development environment, > > and I click in a 'edit' window (like when you bring your program up, to > > edit it) the screen freezes. > > > > when I ran wine --debugmsg +win vfp.exe, my last line of trace is: > > trace:win:EVENT_Capture (0x20021) > > > > Where the heck is the code that calls setcapture for Foxpro? I didn't > > think I needed to, but do I have to get into those spec files also? > > > > Is there somewhere, other than what grep returns, that would call that > > function? I'm definately not an expert here, but I *think* I should be > > able to trace a function on my own :) > > Err, yes. The app, or a native dll used by the app can call SetCapture > itself, unless I misread the .spec files. > > > > My wine is cvs build 2/20/2002, using fake_windows. > > > > Any suggestions would be appreciated. (Should I send this to > > wine-devel?) > > > You might try if you get any joy out of --debugmsg +snoop Nope. No joy :/ > > Or try winedbg and set a breakpoint. That's probably beyond me.. but I have some time :) Thanks Rick > Lawson > ---oof--- > > > _______________________________________________ > wine-users mailing list > wine-users(a)winehq.com > http://www.winehq.com/mailman/listinfo/wine-users -- Rick Romero IT Manager ph: 262.685.4841 Valeo, Inc. fax: 262.695.4850 rick(a)valeoinc.com

1 0

License change impact on other open-source projects
by Andriy Palamarchuk 21 Feb '02

21 Feb '02

Sorry to cross post this message, but I want to attract attention developers from other OS projects which use Wine and I'm not sure they are subscribed to wine-license. We discussed a lot how the license change will affect commercial contributors but we did not mention other open-source projects. Can you, guys, give your opinion about the matter? I'm curious how this will affect you. Anyone from ODIN? If you can, please respond to wine-license. Regards, Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Yahoo! Sports - Coverage of the 2002 Olympic Games http://sports.yahoo.com

2 1

Need help tracing WINE function.
by Rick Romero 21 Feb '02

21 Feb '02

Hi all, I need some assistance.. I'm trying to trace a problem. The quick description is when I run the Visual FoxPro 5 development environment, and I click in a 'edit' window (like when you bring your program up, to edit it) the screen freezes. when I ran wine --debugmsg +win vfp.exe, my last line of trace is: trace:win:EVENT_Capture (0x20021) then the window freezes. So I saw that SetCapure() called EventCapture() in input.c, and I'm trying to trace what all (yikes!) calls SetCapture() I started with [rick@pc99 wine]$ grep -nri --include *.c setcapture * to get all the c files with SetCapture(). So after a day of picking and choosing, I've added more traces to EVERYTHING that the grep command outputs (basically): controls/button.c:234: TRACE_(win)("Calling SetCapture in button.c\n"); controls/button.c:235: SetCapture( hWnd ); controls/button.c:236: TRACE_(win)("Done with SetCapture in button.c\n"); controls/combo.c:1197: TRACE_(win)("Calling SetCapture (combo.c)\n"); controls/combo.c:1198: SetCapture(lphc->hWndLBox); controls/combo.c:1778: TRACE_(win)("Calling SetCapture (combo.c2)\n"); controls/combo.c:1779: SetCapture( hWnd ); controls/combo.c:1808: TRACE_(win)("Calling SetCapture (combo.c3)\n"); controls/combo.c:1809: SetCapture(lphc->hWndLBox); controls/edit.c:4324: TRACE_(edit)("About to SetCapture - edit.c\n"); controls/edit.c:4325: SetCapture(hwnd); controls/edit.c:4326: TRACE_(edit)("Done with SetCapture - edit.c\n"); <snipped> I havn't touched the spec files yet, but everywhere setcapture() is called, I added a trace. Mostly TRACE_(win), but sometimes 'win' wouldn't take even with DECLARE_DEBUG_CHANNEL(win); (IIRC, everything under /dlls/ was that way). So now if I run notepad I get: wine --debugmsg +win,+shell,+edit,+header,+accel notepad.exe trace:win:WINPOS_WindowFromPoint found child 10022 trace:edit:EditWndProc_common 32 bit W : WM_MOUSEACTIVATE: hwnd=00010022, wParam=00010021, lParam=02010001 trace:edit:EditWndProc_common 32 bit W : WM_LBUTTONDOWN: hwnd=00010022, wParam=00000001, lParam=002f0041 trace:edit:EDIT_WM_LButtonDown About to SetCapture - edit.c trace:win:SetCapture Calling Event_Capture trace:win:EVENT_Capture (0x10022) Window #!! -Maybe? trace:win:EVENT_Capture About to Return from Event Capture!!! Prev(0) Wnd(65570) I assume what I'm looking for is the WM_LBUTTONDOWN. Looks good. So I run FoxPro: wine --debugmsg +win,+shell,+edit,+header,+accel ../DevStudio/vfp/vfp.exe trace:win:RDW_Paint Released Window pointer --rdw_paint() painting.c trace:win:SetCapture Calling Event_Capture trace:win:EVENT_Capture (0x20021) Window #!! -Maybe? trace:win:EVENT_Capture About to Return from Event Capture!!! Prev(0) Wnd(131105) Where the heck is the code that calls SetCapture for Foxpro? I didn't think I needed to, but do I have to get into those spec files also? Is there somewhere, other than the .c files grep returns, that would call that function? I'm definately not an expert here, but I *think* I should be able to trace a function on my own :) My wine is cvs build 2/20/2002, using fake_windows. Any suggestions would be appreciated. Rick -- Rick Romero IT Manager ph: 262.685.4841 Valeo, Inc. fax: 262.695.4850 rick(a)valeoinc.com

1 0

Odin CVS repository
by Sander van Leeuwen 21 Feb '02

21 Feb '02

Today we made some changes to make it possible for Linux CVS clients to log in. CVSROOT=:pserver:guest@www.netlabs.org:/netlabs.cvs/odin32 User: guest Password: readonly Sander

1 0

using windows libraries
by Michael Zayats 21 Feb '02

21 Feb '02

suppose I have pure mathematic (without system calls) library - either static or dynamic, how can I convert it to Linux, without loss of the speed, i.e. by converting and not layering. I have no source code for it of course. with best regards, Michael Zayats

1 0

Article about Wine license
by Roland 20 Feb '02

20 Feb '02

http://desktoplinux.com/articles/AT9068852873.html

2 1

[Fwd: Re: Oh yeah, the docu...]
by Tony Lambregts 20 Feb '02

20 Feb '02

Tony Lambregts wrote: [Snip] > Ok so its just the online doc thats not up to date. Thanks. > > http://www.winehq.com/Docs/wine-user/configuring.shtml > > also looks like the the following are also not up to date. > > http://www.winehq.com/Docs/winedoc-sgml.tgz > http://www.winehq.com/Docs/winedoc-pdf.tgz VERY OLD > http://www.winehq.com/Docs/winedoc-ps.tgz VERY OLD > > and I would suspect that these too. (did not actually download) > > http://www.winehq.com/Docs/wine-set-html.tgz > http://www.winehq.com/Docs/winedoc-html.tgz [snip] Since my last post on usenet I did download these and they are out of date too. IMHO www.winehq.com/Docs should be updated at each snapshot. Tony Lambregts

2 1

License change vote results
by Alexandre Julliard 20 Feb '02

20 Feb '02

Folks, Here is the summary of the votes I received in answer to the request to switch to a copyleft-style license: Agree Disagree Indifferent All votes: 76 (70%) 15 (14%) 17 (16%) Contributors: 39 (66%) 7 (12%) 13 (22%) Contrib. weighted: 59 (64%) 13 (14%) 20 (22%) The first line counts all the votes I received. The second line counts the votes of all people/companies who contributed some code to the project. The last line counts all contributors again but with each being given 1, 2, or 3 votes depending on the importance of his contributions (this evaluation is obviously a bit subjective, but I think the overall trend is clear). The obvious result of this vote is that my previous conclusion was wrong: there is clearly widespread support in the community for a copyleft-style license. With 2 out of 3 contributors in favor of the switch, and less than 15% opposed to it, it's clear that we are going to proceed with the change. We now have to decide the implementation details, like the exact license used, whether to require copyright assignments, etc. My suggestion is that we create a separate mailing list to discuss that, to avoid drowning wine-devel under yet another license flame war. -- Alexandre Julliard julliard(a)winehq.com

11 15

Re:GetStdHandle Problem
by Ignasi Villagrasa 20 Feb '02

20 Feb '02

2 1

Re:GetStdHandle Problem
by Ignasi Villagrasa 20 Feb '02

20 Feb '02

Thanks for answering at first to Eric Pouech. Referred to several points: >did you try to run your program with wineconsole ? >(wineconsole /usr/client/mcc_gnu/cmpm/cmpmgnu /B100 /Oaaaa-1.ovl) I don't know about this executable. I don't find wineconsole file anywhere in wine installation. >Does your program use global objects, which initialization code could invoke the >GetStdHandle functions ? Perhaps I'm going wrong in any of the steps I'm following. I'll explain what I'm trying to do.When I began to migrate this console based programs I wanted to migrate them entirely to Linux without using Wine. I could think of this because my Win32 console programs are designed in native C and C++ and most of its calls are related to ANSI C, and so the migration remains simplified. Console management is platform specific however. I use Win32 console API, and use structures such as INPUT_RECORD. So I'm using Event.KeyEvent.uChar.AsciiChar and Event.KeyEvent.wVirtualScanCode to get and manage keyboard inputs. So it's difficult for me to migrate these calls to, for instance, a ncurses layer, because I must redefine the complete user interface. So I thought of winelib library in order to integrate this part of the programs without changing source code. What I want is add to my program winelib the same way I'm adding other libraries. I don't want to run the program as a Win32 native one, but as a Linux native one. So the steps I followed are: - I installed wine package, getting it from codeweavers. - I added the include files in my source code in order to compile the programs. - I created spec file as wine documents. - I compiled it as documented. - I added the resulting .c file to my makefile. - I compiled all the modules. - I added then following libraries to my makefile linker step: -lkernel -lntdll -lwine -lwine_unicode. Tell me if that's all right. - I linked and created the executable without problems. So, as far as I know, the only place where I call GetStdHandle is in my console module and for displaying and keyboard interface purposes. conhanout = GetStdHandle(STD_OUTPUT_HANDLE); conhanin = GetStdHandle(STD_INPUT_HANDLE); I don't know if the programs may have any additional implicit call to this function. >does your program use AllocConsole or FreeConsole ? No. My program doesn't call explicitly to AllocConsole or FreeConsole. Thanks in advance. Ignasi Villagrasa.

2 1

Re: Small changes to notepad - 2
by Alexandre Julliard 20 Feb '02

20 Feb '02

Andriy Palamarchuk <apa3a(a)yahoo.com> writes: > Q: Is my changelog automatically added to the > ChangeLog file in the notepad directory? If not, > should I update this file manually or we do not need > to use the local file at all? We don't need to use it, all the changes are listed in the main changelog anyway. In fact it should probably be removed. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: mt locks, fix _sopen for msvcrt
by Alexandre Julliard 20 Feb '02

20 Feb '02

"Peter Hunnisett" <peter(a)transgaming.com> writes: > * dlls/msvcrt/Makefile.in, dlls/msvcrt/console.c, dlls/msvcrt/exit.c, > dlls/msvcrt/file.c, dlls/msvcrt/heap.c, dlls/msvcrt/locale.c, > dlls/msvcrt/main.c, dlls/msvcrt/msvcrt.h, dlls/msvcrt/msvcrt.spec, > [new]dlls/msvcrt/lock.c, include/Makefile.in, [new]include/msvcrt/mtdll.h > Peter Hunnisett <peter(a)transgaming.com> > Add _lock,_unlock and header file for them. > Convert all msvcrt locks over to use _lock and _unlock > Explictly make msvcrt compile with multithreaded option > Fix flag handling in _sopen. Add W->A call for new _swopen Isn't mtdll.h supposed to be an internal header? If so, it should be in dlls/msvcrt, not in include/msvcrt. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Small changes to notepad
by Andriy Palamarchuk 20 Feb '02

20 Feb '02

This patch, submitted on Feb 15 was not applied, but other patch - "Notepad2. Command line processing" was. These two patches are independent from each other. If the patch was not understood as duplication and was not applied for some other reason I'd like to know why. Thanks, Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Yahoo! Sports - Coverage of the 2002 Olympic Games http://sports.yahoo.com

2 2

Concerning the boot procedure for renaming/deleting files
by Gerhard W. Gruber 20 Feb '02

20 Feb '02

Something not to do with licencing, I hope that poeple have time for this as well. :) I've submitted a patch that is the preliminary for processing the files that are installed with a setup in order to be deleted/renamed when windows boots. The files are now entered into the registry as I have seen how it is done on NT4.0. I have now some questions regarding this. 1.) When I verified this with a testprogram on NT I noticed that the MoveFileEx code enters the names like this \??\D:\test.exe[0] !\??\D:\Test_renamed.exe[0] [0] Does anybody know what the \??\ stands for and wether the '1' for the renaming entry has some function? I coudn't find anything regarding this and I hardcoded this as to now. 2.) I've looked into the program winebootup from Andreas Morh and I could finish this (at least regarding the boot processing for now). BUt I don't see the advantage of having a seperate program that does some stuff that should be done when a wine process starts up. When I check if there is something to process this takes a trivially small time, so performance can't be the issue. I don't really like the idea of having a seperate program for this because in my opinion it belongs into the wine startup code to do this sort of work. Also I think that this will lead to additional questions because people will install programms and then wonder why it doesn't work after successfull installation, so they will ask whats wrong (and I gues this will happen again and again). Furthermore I bet that most people may forget about this secondary program that is needed to run because setup is not done that often once a system is set up properly so people might tend to forget about it. The other thing could be that this secondary program will substitute the startupe program in which case there is no need for a second program in the first place. Any opinions on how to best integrate the boot processing?

3 5

Re: License change vote results
by Roger Fujii 20 Feb '02

20 Feb '02

> CodeWeavers as a single entity did receive one vote.) If we had stuffed > the ballot box as Brett suggested, the votes would have > been more lopsided, believe me. So, you're saying that it WAS possible that it could have been stuffed. Remember that the criteria was not given out when the results were posted (which is why I asked in the first place), so there was no way of knowing what the numbers meant. As it is, I think the criteria is flawed in the sense that it discounts major contributers (codeweavers and transgaming) and enhances the votes of minor ones - the ones who are least effected by a license switch (and, IMHO, the ones that understand the issues/mechanisms of licenses the least). As the argument for X11/BSD is a philosophical/commercial one, it's not unfair to say that if you discount commerical entities, you will have the effect of discounting the X11/BSD count. > I think Dimi and others have been remarkably patient, all > things considered. Being on the other side of the issue, I can say that Dimi is not a saint on the matter either - at least Brett sometimes will substantiate what he says. -r

2 1

Re: Notepad2. Command line processing
by lawson_whitney＠juno.com 20 Feb '02

20 Feb '02

On Fri, 15 Feb 2002, Andriy Palamarchuk wrote: > I *think* this patch does not depend on my previous > patch. > > Changelog: > - implemented parsing of file name, passed in command > line, loading new file on startup. This fixes bug 407 > Did you notice in testing this patch that notepad can not save a file? Never mind bug 407, that is the Real Bug that renders notepad unusable. :-). I guess this is not an urgent bug, I can use joe, jed, vi (elvis, vim) or emacs if I need to change a file. Lawson Illigitimati non carborundum.

4 3

Re: License change vote results
by Roger Fujii 20 Feb '02

20 Feb '02

Alexandre Julliard <julliard(a)winehq.com> wrote: > The obvious result of this vote is that my previous conclusion was > wrong: there is clearly widespread support in the community for a > copyleft-style license. With 2 out of 3 contributors in favor of the > switch, and less than 15% opposed to it, it's clear that we are going > to proceed with the change. As a curiosity, what % of the voters are affiliated with codeweavers? I realize that they are a significant contributer, but as you are using the word "community", it's fair to ask a) how big that number is in total b) if there are large components in that number, they should be at least quantified. -r

8 7

MIDL replacement?
by Phillip Schmitz 20 Feb '02

20 Feb '02

Some time ago there was talk of using an (msrpc/com) idl compiler and idl files to replace some of the complexity of the current COM implementation details (I imagine the main advantage would be that winelib programs might be able to use COM stuff without having to generate stubs etc using MIDL). Rather than starting from scratch people recommended finding an existing (corba) idl compiler and hacking that. Has anyone taken up the challenge? I had a look at the freedce idl compiler but I can't get it to compile. Not that I want to invite another round of "my license is better than your license" but should this be distributed independently of wine so as to avoid license problems or what could one base it on if distributed with wine (if wine was rewritten to depend on its availability this would make things tricky... ) Also, while on the topic of MIDL it seems that the emitted code contains marshaling hints/info in special strings - does wine currently understand these? (undocumented of course but not that messy - people writing their own custom DCOM-over-other-transports stuff managed to work them out quite quickly - I'm sure working with people from Microsoft Research helped though :) Would it need to be a drop-in replacement for MIDL? I suppose not but I'm not sure how much easier that would be (I know com-idl is a moving target with COM+ and new attributes etc but plain COM should be sufficient for most). Anyway - this is the result of a few days research and may all be in vain - those with more experience with COM and its implementation in wine should (if required) shoot me down now before I continue wasting my time. Phillip Trainee wine-devel lurker who marvels at the endurance of people using/implementing COM in C. PS I don't know if it is worthwhile starting a separate effort to make a "free" MIDL replacement regardless - what do people writing windows code with mingw etc do if they want to use COM?

2 1

cd programs && make install
by lawson_whitney＠juno.com 20 Feb '02

20 Feb '02

Good day! Maybe this is a local misconfiguration (only I doubt it) or maybe I am going about it wrong,...maybe I deleted winetest.pm myself and can't remember... cd `dirname winetest/__install__` && make install make[1]: Entering directory `/oof/Wine-20020122/programs/winetest' [ -d /usr/local/bin ] || mkdir -p /usr/local/bin /usr/bin/install -c winetest.so /usr/local/bin/winetest.so cd /usr/local/bin && rm -f winetest && ln -s wine winetest [ -d /usr/local/lib ] || mkdir -p /usr/local/lib /usr/bin/install -c -m 644 wine.pm /usr/local/lib/wine.pm /usr/bin/install: wine.pm: No such file or directory make[1]: *** [install] Error 1 make[1]: Leaving directory `/oof/Wine-20020122/programs/winetest' make: *** [winetest/__install__] Error 2 Lawson "Beware of bugs in the above code; I have only proved it correct, not tried it." -- Donald Knuth ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/web/.

2 1

RMS, Univerial Themes, Slashdot, and Wine
by Tim R. 20 Feb '02

20 Feb '02

Hi, This post, http://mail.gnome.org/archives/foundation-list/2002-February/msg00015.html to some GNOME mailing list got /.ed recently. Quoting from the post: >It might also be useful to organize a specific joint project, >something that would improve the coherence of a GNU/Linux system >which uses parts of both GNOME and KDE. The idea that occurred to me >was to work on unifying theme definitions, so that a user can define >a theme just once and have it work with both GNOME and KDE. Perhaps >others will have a better suggestion. I would love to see something like this happen. However, IMHO, I think something like this should be more than just KDE and GNOME. I would like to see something like that as a more or less Linux (and BSD, etc), or X11 standard. It seems to me that Wine could benifit from something like this. Basicly, Wine is just a Unix/X11 toolkit that happens to have the same API as MS Windows and includes a binary loader right? Or am I completely off base here? Anyway, GNOME programs tend to look and feel like GNOME programs, KDE programs tend to look and feel like KDE programs, and Wine programs tend to look and feel like Windows programs. So could something like this work for Wine? Could Wine programs inherit their look and feel from some kind of universal theme? That would surely help the Windows programs integrate into the X desktop. So I guess I'm asking, would this work for Wine, and if so, is anyone interested in doing it? If the first answer is yes but the second is no, could anyone provide me with some pointers for getting involved with doing some a project myself? (Both the work on Wine, and on GNOME/Gtk/KDE/Qt/etc.) Also some of the replies to RMS's post suggested this was an itch none of the GNOME people felt like scratching, because none of them used KDE programs. I thought perhaps the Wine people would feel more like scratching this itch, because most of you probably use Wine programs along side of atleast either KDE or GNOME applications, if not both. Sorry if this has been a bit off topic, or if I don't really know what I'm talking about. --Tim Ringenbach

1 0

Bye
by Gerard Patel 20 Feb '02

20 Feb '02

Ring down the curtains, the farce is over ;-) I will unsubscribe from wine lists in a few days. If anyone of the contributors has a problem with the few lines of code I wrote for Wine, they should not hesitate to send me a mail in my personal inbox, I'll try to understand what I was trying to do and if I succeed I'll explain :-) And if among the seven who voted against the changes there are enough people aventurous (I did not participate to the 'vote'), I'd be interested to hear from them and discuss a contribution to a new project under a x11 like license. As wine-license seems to be a continuation of the gpl/bsd flamewar :-//, I'd prefer to talk about a x11 project elsewhere... Thanks to all on this list who helped me. Good luck to the Wine guys for their 1.0 version. Gerard PS : And ah, well, as a parting note for Alexandre Julliard : there is a problem with your patch made on Revision 1.22 / (download) - [select for diffs] , Fri Sep 14 00:24:40 2001 UTC (5 months ago) by julliard Branch: MAIN Changes since 1.21: +8 -13 lines Diff to previous 1.21 Make sure that HWND comparisons are always done with full 32-bit handles. You included this (hardly related) change in dlls/x11drv/window.c, line 524: while (prev && !(GetWindowLongW( prev, GWL_STYLE ) & WS_VISIBLE)) prev = GetWindow( prev, GW_HWNDPREV ); This is triggering a regression in one of my test apps, webferret (www.webferret.com). The option window has its tabs covering each other. I can work around with this patch : --- winpos.c.orig Tue Dec 18 02:27:43 2001 +++ winpos.c Thu Jan 10 18:08:16 2002 @@ -880,7 +880,7 @@ if (get_whole_window(wndPtr)) /* don't do anything if X window not created yet */ { Display *display = thread_display(); - + int zorder = !(winpos->flags & SWP_NOZORDER); if (!(winpos->flags & SWP_SHOWWINDOW) && (winpos->flags & SWP_HIDEWINDOW)) { /* clear the update region */ @@ -895,10 +895,11 @@ TRACE( "unmapping zero size win %x\n", winpos->hwnd ); TSXUnmapWindow( display, get_whole_window(wndPtr) ); } + else if (winpos->flags & SWP_SHOWWINDOW) zorder = TRUE; wine_tsx11_lock(); if (bChangePos) - X11DRV_sync_whole_window_position( display, wndPtr, !(winpos->flags & SWP_NOZORDER) ); + X11DRV_sync_whole_window_position( display, wndPtr, zorder); else { struct x11drv_win_data *data = wndPtr->pDriverData;ü as far as I can understand your code and what the app is doing, your new code updates the ordering of the X window but there is a case missing when child windows are shown using for instance ShowWindow. But of course you'll have a better patch :-)

4 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel