wine-devel

wine-devel@winehq.org

10 participants
84459 discussions

Re: _dev_t for MSVCRT
by Marcus Meissner 21 Nov '01

21 Nov '01

On Tue, Nov 20, 2001 at 10:16:14PM +0100, Uwe Bonnes wrote: > Changelog: > include/msvcrt/sys/types: > _dev_t in a unsigned integer > -- > Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de > > Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt > --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- > Index: wine/include/msvcrt/sys/types.h > =================================================================== > RCS file: /home/wine/wine/include/msvcrt/sys/types.h,v > retrieving revision 1.2 > diff -u -r1.2 types.h > --- wine/include/msvcrt/sys/types.h 2001/10/22 18:59:24 1.2 > +++ wine/include/msvcrt/sys/types.h 2001/11/20 19:44:21 > @@ -15,7 +15,7 @@ > #endif > > > -typedef unsigned short _dev_t; > +typedef unsigned _dev_t; Dann sollte da aber 'unsigned int' stehen ;) Ciao, Marcus

1 1

Re: (no subject) (msvcrt.getenv)
by Francois Gouget 20 Nov '01

20 Nov '01

On Tue, 20 Nov 2001, Uwe Bonnes wrote: > > Changelog: > dlls/msvcrt/environ.c: MSVCRT_getenv > Compare for the length of the key and return NULL in case of failure Good catch. Another thing to keep in mind: IIRC environment strings are not case sensitive on Windows. This means that normally getenv("PATH")==getenv("path") and that putenv("Path") would overwrite that same environment variable... This does not appear to be the case in the current code. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Dieu dit: "M-x Lumière". Et la lumière fut.

1 0

winsock2.h
by lawson_whitney＠juno.com 20 Nov '01

20 Nov '01

Good day! To try debugging techniques for winelib apps, I had in mind to make a winelib app with an intentional segment fault, and found that _my_ winelib app will no longer compile. (gcc-2.95.3, glibc-2.2.3, current wine CVS). Please, it needs unistd.h so it can comfortably log to syslog. running winemaker on it again didn't help. checking for wrc... /usr/local/bin/wrc updating cache ./config.cache creating ./config.status creating Make.rules creating Makefile creating launcher Configure finished. Do 'make' to build the project. [whit@giftie wlp]$ make gcc -c -g -O2 -fPIC -D_REENTRANT -DWINELIB -I. -I/usr/local/include/wine -o t oj2.o toj2.c In file included from /usr/local/include/wine/winsock2.h:30, from /usr/local/include/wine/windows.h:39, from toj2.h:29, from toj2.c:19: /usr/local/include/wine/winsock.h:886: conflicting types for `gethostname' /usr/include/unistd.h:734: previous declaration of `gethostname' make: *** [toj2.o] Error 1 [whit@giftie wlp]$ I would be glad of a bit of advice thanks, Lawson Constants aren't, and variables won't.

2 4

Civilization2 segment register troubles
by Jukka Heinonen 20 Nov '01

20 Nov '01

Hi. I noticed that Civilization 2 has several problems under Wine. First, the game wants to access memory using segment register value zero, which causes protection exception since that is not allowed in protected mode. Second problem is that the game uses segment register value 0xf8, which Wine does not like. If I drop null-pointer protection [call to DOSMEM_Init(TRUE)], emulate cmp and mov commands so that they work even if using segment register value zero [added stuff to memory/instr.c] and make Wine accept segment register value 0xf8 [by hacking INSTR_ReplaceSelector], Civilization 2 starts to work without any problems. There are several possible reasons why the above changes make the game work: Wine corrupts segment registers somewhere, Civilization 2 wants to use privileged commands and Windows emulates them or the game runs in VM86 mode under Windows. So, I would like to get some ideas what should be done with Wine in order to get the game working. Oh, the above modifications fix protection faults that happen when the game tries to access the following addresses: 0x22, 0xc8, 0xf6, 0xf07c and 0xf0aa. P.S. Civilization 2 seems to work almost perfectly but it is painfully slow. I am pretty certain that I know the reason for this, but I would like to get the game working under official Wine before trying to make it run faster. -- Jukka Heinonen <http://www.iki.fi/jhei/>

2 2

Re: Patches for FreeBSD 5.x compilation
by Alexandre Julliard 20 Nov '01

20 Nov '01

Steve Kargl <sgk(a)troutmask.apl.washington.edu> writes: > What I questioned was the criticism that FreeBSD was guilty > of namespace pollution. Alexandre isn't the only wine > developer who made this statement (check usenet). The header > files in question are implementation dependent and can > contain any variable name or #define or typedef. The fact is > that both wine and FreeBSD have struct thread in implementation > header files. AFAICT, neither is incorrect. The Wine headers that define struct thread are only used inside Wine; the FreeBSD headers are used by applications, no matter how much you argue they are internal headers. So the situation is very different. > But, to have > a wine developer emphatically state that FreeBSD needs to > fix its system header files is somewhat surprising. Why is > it surprising to me? Because this reminds me a company here > in Seattle. I couldn't care less whether FreeBSD fixes its headers or not; we will need to work around the problem in Wine in any case. I was simply expressing the opinion that changing this would make FreeBSD better. I'm certainly not demanding that the FreeBSD guys fix it, if they feel exporting struct thread is a good idea it's their choice. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: LibaudioIO Patch for Solaris
by eric pouech 20 Nov '01

20 Nov '01

Robert Lunnon wrote: > > Attached find files for libaudioio patch for audio on solaris 7 > > winmm.diff - Only the makefile patch is significant wavemap, just contains > some extra debugging traces > > libaudioio.tar, libaudioio goes under winmm > > base.diff, Patches to configure.in and Makefile.in to better support Solaris > and Libaudioio > > config.h.in added HAVE_SOLARIS and HAVE_LIBAUDIOIO and added a way for force > a 32 bit mmap. a few comments : - why do you add the libaudioio lib to winmm ? it should only be linked against the libaudioio (or whatever) driver... winmm should be independant of any driver... - in the libaudioio subdir: + you shouldn't use C++ comment. wine is a C project + it would a good idea to remove any reference to OSS in libaudioio... + I don't think that libaudioio supports midi... so, the preferred way to handle this would be to create a driver which doesn't export the midMessage and modMessage, and to get rid of midi.c and midipatch.c (same for mixMessage/mixer.c and auxMessage/aux.c) (it seems midi.c and mixer.c are protected by non existent HAVE_LIBAUDIO_MIDI and HAVE_LIBAUDIOIO_MIXER which are defined nowhere) + so the driver should only be made of the wave.c part and oss.c (which should be renamed to IMO) + anyway, I think that the libaudioio subdir should be named against the name of the DLL, which is audioio (eventually, since it's a wine only DLL, and to prevent DLL name collisions, I'd call it wineaudioio(.drv) - I don't see any reasons to define HAVE_SOLARIS... this is a wrong practice for system dependancies anyway A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

1 0

Re: Patches for FreeBSD 5.x compilation
by Alexandre Julliard 20 Nov '01

20 Nov '01

Steve Kargl <sgk(a)troutmask.apl.washington.edu> writes: > Can you please explain how this is namespace pollution on the > part of the OS? AFAIK, <sys/user.h> is not specified by any > Standard (ISO C89, C90, or C99). <sys/user.h> can include > any (unprotected) variable name. Yes of course it can, but the fact that this isn't explicitly forbidden by some standard doesn't mean it's good practice or that it doesn't pollute the namespace. sys/user.h is also legally allowed to do "#define if else"; that doesn't make it a good idea. > If an application includes > <sys/user.h>, then the application should be prepared to > deal with conflicts. Great, then you need to fix all applications every time someone feels like exporting a new symbol from user.h. Of course user.h is a pretty obscure header so it's no big deal, but it would be easier to avoid exporting stuff under such common names as "struct thread". -- Alexandre Julliard julliard(a)winehq.com

4 4

interesting comment about WINE from MS
by Igor 20 Nov '01

20 Nov '01

As far as WINE and Mono are concerned, I'm just not sure whether these organizations will end up being able to produce satisfactory products. The real problem is this: it is not good enough for WINE to run some Windows apps. If the general public is going to consume it, it must run all Windows apps. Windows 2000/XP has a significant level of POSIX compliancy, but many developers just don?t write their apps with these standards in mind. You'll find pieces of code everywhere in third party apps which run statements like if (WINVER==4.0 && GrokTheBIOSForSomeACPIGoo()), which have not been tested to see whether they will run on non-Windows/x86 platforms. In fact, Microsoft has had to put in significant time and effort to insure that older Win32 applications originally written to run in Win95 will run in NT." original article is here http://www.osnews.com/story.php?news_id=314

1 0

Implementation of TB_REPLACEBITMAP
by Marco Bizzarri 20 Nov '01

20 Nov '01

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all. I'm trying to provide an implementation of TB_REPLACEBITMAP Included is the patch I've done to record the bitmaps which are provided to the toolbar and to replace them when the message arrives. Even though the number of buttons displayed is correct, the output is otherwise garbled. I would appreciate any suggestion on this topic. The platform is a RH Linux 6.2. wine is from CVS (20/11/2001) - -- Marco Bizzarri - Responsabile Tecnico - Icube S.r.l. Sede: Via Ridolfi 15 - 56124 Pisa (PI), Italia E-mail: m.bizzarri(a)icube.it WWW: www.icube.it Tel: (+39) 050 97 02 07 Fax: (+39) 050 31 36 588 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://quantumlab.net/pine_privacy_guard/ iD8DBQE7+oUXXhfyAQQVoaIRAudsAJ9QEbPYChk0YpTonozvkjUge4HtjACgl8cg A87v4vPHKOeeCgj6LpW18dw= =J2rq -----END PGP SIGNATURE-----

1 0

audio.c fault reproduction
by Simon Britnell 20 Nov '01

20 Nov '01

I downloaded and ran the QuickTime installer and the Pajama Sam demo last PM. I have reproduced the problem with Pajama Sam (it seems that ends of samples are either not playing or being overwritten), but I can't get QuickTimePlayer.exe to do anything at all. I'll investigate the Pajama Sam problems over the remainder of the week. __________________________________________________ Do You Yahoo!? Yahoo! GeoCities - quick and easy web site hosting, just $8.95/month. http://geocities.yahoo.com/ps/info1

2 1

RE: MIDL and COM
by Patrik Stridvall 20 Nov '01

20 Nov '01

> On 16 Nov 2001, Alexandre Julliard wrote: > > > Ove Kaaven <ovehk(a)ping.uio.no> writes: > > > > > But can the machine-generated sources that MIDL outputs > be put into the > > > official Wine source? > > > > I'd prefer not. If we want to use .idl files we'll have to come up > > with our own compiler, and then we can put the .idl source > in the tree > > and compile it at build time. > > Hmm. Even when using flex and bison, it sounds like a fair amount of > work... wonder who would volunteer? There already are a multitude of open souce (GPL and otherwise) CORBA .idl compilers. Of course Wine have probably slightly different requirements but I should guess that we could save 90% of the work compared to writing it from scratch. Alexandre: Is a GPL:ed (or possible different licenced) .idl compiler acceptable? > > > And how about source IDL files? Can we put into Wine IDL > extracted from > > > real Windoze .tlb files with a tool like oleview.exe, or > IDL parsed from > > > MIDL-generated Windows SDK .h files, like objidl.h, with a script? > > > > No, anything generated from a Windows file is copyrighted by > > Microsoft, so we cannot distribute it. We need to rewrite > these files > > from scratch, just like we do for the normal headers. > > Now where are all the usual non-lawyers on this list who > would argue that > API definitions, like prototypes in header files (which of > course IDL, as > a formalized API spec format, is all about), cannot be copyrighted? > Oh well... I'm here. :-) Well, I wouldn't really go quite that far. The API definitions in themselves can't be copyrighted, true. But a specific way of expressing them is, so compiling any Microsoft file will generate create a derived work copyrighted by Microsoft as the main rule. However it is not quite that easy, since only the specific expression is protected, the compilation result is only a derived work if it still contains any protected expression. In light of this you could argue that since, I presume, MIDL removes whitespace and commments which is IIRC the only really expression, since the rest the API defintions are just facts, that the MIDL compiled files just contains facts not any part of the protected expression. However that is a little thin line to walk, since there is quite of lack of real cases in the area, so I would recommend that we do as Alexandre suggest. Beside having the real .idl files in the Wine tree might be useful for other things as well.

1 0

Re: MIDL and COM
by Alexandre Julliard 20 Nov '01

20 Nov '01

Ove Kaaven <ovehk(a)ping.uio.no> writes: > Problem 1: MIDL-generated code. > midl.exe is Microsoft's IDL compiler, it reads .idl files which describe > RPC and COM interface, from which it generates .c files, .h files, and > typelibs. (It is possible to find copies of midl.exe floating on the net, > as some people have put together "COM kits" for Borland C++ that contains > midl.exe and some standard .idl files and put them on the web) > > But can the machine-generated sources that MIDL outputs be put into the > official Wine source? I'd prefer not. If we want to use .idl files we'll have to come up with our own compiler, and then we can put the .idl source in the tree and compile it at build time. > And how about source IDL files? Can we put into Wine IDL extracted from > real Windoze .tlb files with a tool like oleview.exe, or IDL parsed from > MIDL-generated Windows SDK .h files, like objidl.h, with a script? No, anything generated from a Windows file is copyrighted by Microsoft, so we cannot distribute it. We need to rewrite these files from scratch, just like we do for the normal headers. > Problem 2: RPCSS > rpcss.exe is the place that keeps track of which process owns which RPC > endpoints, exported COM objects, and object activation tables. > The IRunningObjectTable interface, for example, is managed by rpcss.exe, > and keeps track of certain kinds of COM objects on the computer, so that > other processes can connect to running COM objects. We probably don't want > Wine to have to run a separate process for this? If not, can we put this > kind of COM stuff into the wineserver? I'd prefer having a separate process, at least in the first stage. -- Alexandre Julliard julliard(a)winehq.com

2 1

audio.c regression on Nov. 10th
by Ori Pessach 19 Nov '01

19 Nov '01

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Despite my previous report on this, something did break in audio.c between November 9th and November 10th. I checked out a version from 11/09/2001, and it works. I updated just audio.c with -D 11/10/2001, and Humongous Entertainment games don't recognize the sound card anymore. There have been substantial changes to audio.c during those 24 hours - enough to confuse diff, as a matter of fact. I'll look into it, but I wanted to report this first. The reason I thought earlier that the problem went away was that I had a sticky date on audio.c that I wasn't aware of. Ori Pessach -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: http://www.oripessach.com iD8DBQE7+VXUzA/uWWyw6uQRAmkHAJ94A+IW82jXdhhLl6ODWaUs7I+SwACg16oT FIIymJ5xAP6eNc+5GlbQ3SU= =zHkd -----END PGP SIGNATURE----- _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com

2 1

Re: Patches for FreeBSD 5.x compilation
by Alexandre Julliard 19 Nov '01

19 Nov '01

Francois Gouget <fgouget(a)free.fr> writes: > I guess that one day Alexandre is going to argue that Linux should > stop polluting the namespace with 'struct user'... Well, struct user is the only reason for including sys/user.h, so I guess it can be considered acceptable; but anything else defined in there (like struct user_regs_struct on Linux) is namespace pollution too IMO. And if there comes a day when the server is managing users, the corresponding struct will definitely be named struct user, not struct wine_unique_prefix_0918274_user or whatever (and note that we don't really need user.h even on Linux, we could just as well hardcode the offset). -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Patches for FreeBSD 5.x compilation
by Alexandre Julliard 19 Nov '01

19 Nov '01

Steve Kargl <sgk(a)troutmask.apl.washington.edu> writes: > FreeBSD isn't polluting the namespace. <sys/user.h> is a > a non-standard header file. It's still made available to applications, and there is really no reason for exporting internal kernel names this way. At least it could be renamed or put inside #ifdef _KERNEL. The alternative is of course to avoid sys/user.h, or play with #defines on the Wine side; but prefixing our structures with wine_ is not a solution. -- Alexandre Julliard julliard(a)winehq.com

4 4

Re: Fix to audio.c 1.46 loop problem + choppy sound
by Michael Stefaniuc 19 Nov '01

19 Nov '01

On Fri, Nov 16, 2001 at 07:59:20PM -0800, Simon Britnell wrote: > This patch should fix a loop playing failure reported > by Eric and a problem with choppy sound I experienced > playing total annihilation Hmm ... this patch horrible breaks the sound in Quicktime. The sound is now (audio.c 1.47) practicaly nonexistand: every 5-7 seconds you hear something for about 1/2 seconds. Before that (audio.c 1.45,1.46) the sound was choppy and played at 4/5 of the normal speed whereas with audio.c 1.44 the sound plays perfect. I'm using Quicktime 5.02 standalone in the german version. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.de Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: Patches for FreeBSD 5.x compilation
by Alexandre Julliard 19 Nov '01

19 Nov '01

Francois Gouget <fgouget(a)free.fr> writes: > Renaming struct thread it the right thing to do though. Why > doesn't changing thread to wine_thread in request.h work? No, the right thing is to fix the FreeBSD headers to stop polluting the namespace. struct thread is a perfectly valid identifier for an application to use (and we are certainly not the only application using it). -- Alexandre Julliard julliard(a)winehq.com

2 1

Kdevelop and Wine
by Chuck Fischer 19 Nov '01

19 Nov '01

Hello, I'm new to Linux, Kdevelop and Wine. I've been given the task of getting a Windows application to run on *nix. After some surfing I found KDevelop and Wine. I would like to use KDevelop to build my Windows app with WineLib. Can this be done? Has it been done? What do I need to do to get it to work? Also, are there any plans or thoughts about integrating WineLib with KDevelop? TIA, Chuck

2 1

Re: Build failure due to winsock.h changes, specifically htonl
by Gerald Pfeifer 19 Nov '01

19 Nov '01

On Thu, 15 Nov 2001, Francois Gouget wrote: > Yes. This one is actually simple to solve: do not include > 'winsock2.h'. AFAICT including 'winsock2.h' is not necessary since 1.66 > (2000/08/31) when get_socket_event and FD_MAX_EVENTS where removed. > I am working on the other compilation problems... I just performed a cvs update and now was able to again build Wine on FreeBSD 4.4 due to your latest changes. Thanks a lot! Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.dbai.tuwien.ac.at/~pfeifer/

1 0

readdir broken when called from wine
by Lionel Elie Mamane 19 Nov '01

19 Nov '01

Hi, After "upgrading" from Wine-20010418 to Wine-20011004 (self-compiled from tarballs), suddenly it didn't find my "C:\Windows" any more. Worked before, same 'puter, config files, etc (TM). Tried with CVS version. Nope. I recruited Andreas Mohr on #WineHQ for help, we ruled out the obvious (yes, the directory exists, here is my config file, no, I don't confuse root and non-root, ...), and got down to add traces and dug in the code. So, for some reason, the readdir calls from files/dos_fs.c:DOSFS_ReadDir() report success (ie return non-NULL), but the directory entry name returned (dirent->d_name) is always the empty string (*(dirent->d_name)=='\0')! So I checked if readdir worked generally on my system, it does, this program does the expected thing: int main(void) {//Tst code DIR *mydir; struct dirent *entr; mydir = opendir("/"); while ((entr = readdir(mydir))) { TRACE("Dir_entry: %s\n", entr->d_name); } closedir(mydir); } I even went the extra mile and compiled it with exactly the same options (minus the various -I's) as dos_fc.c gets in wine, it works. Then, I added that code snippet (without the "int main(void)", obviously) to wine's main(). Worked. So I went down the stack of called functions, putting that same snippet in each function to see when it breaks: It works "up to" (or down to?) loader/main.c:MAIN_MainInit(). That function calls files/directory.c:DIR_Init(), and there, it doesn't work (ie name is always empty string) in DIR_Init(). After DIR_Init() returns, it still works in MAIN_MainInit(). I tried to find a difference between these files, but they get compiled with the same compile options, combined by "ld -r" along with other .o's in files/files.o, resp. loader/loader.o, and the two latter go in libntdll.so. What could be the difference that makes readdir "break"? I've put the test code snippet just before the call to DIR_Init in MAIN_MainInit, and just after variable declaration in DIR_Init, so it's not a function that DIR_Init calls that "breaks havoc". Well... We're lost there. No idea. Anyone of you? Anyway, here's some info on my system, just giving random info, I don't really know which one will be useful: Pentium III 500 / 440BX motherboard SuSE 6.4 distrib "base" with several self-compiled "add-ons", "upgrades", and some newer SuSE RPM's installed (from 7.0, 7.1 or 7.2). Along the latter (newer RPM than SuSE 6.4), the glibc... glibc-2.2-9 Linux 2.2.20 (Was using .19 when problem started) Soundblaster AWE32 3Com NIC (3C905B) Adaptec SCSI controller (AHA-3950U2) gcc 2.95.2 GNU ld 2.9.5 binutils-2.9.5.0.24-30 Err... What more??? Any additional info useful? Just ask. (except r00t password, "of course" ;-> ) Thank you for your time, -- Lionel Elie Mamane RFC 1991 (PGP 2.x) 2048 bits Key Fingerprint (KeyID: 20C897E9): 85CF 986F 263E 8CD0 80FD 4B8C F5F9 C17D OpenPGP DH/DSS 4096/1024 Key Fingerprint (KeyID: 3E7B4B73): 9DAD 3131 3ADA F50B D096 002A B1C4 7317 3E7B 4B73

3 3

Query on ActiveX components support from Wine.
by Ganesh.S 19 Nov '01

19 Nov '01

Hi, Is it possible to run an application that uses MSGrid ActiveX component and other database related components. My application was developed in VB6.0 which uses Microsoft Access in the backend. When I run the application the datas are not comming. Also few of the screens are not coming up saying that can't load the ActiveX component and the application gets killed. Is there any patch or solution for this. Can you suggest me the solution for this. thanks in advance, with regards, Ganesh.S Success is the progressive Realisation of a Worthy Goal. HCL Peripherals

1 0

Re: misc. code fixes
by Alexandre Julliard 19 Nov '01

19 Nov '01

Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> writes: > - make listbox.c use reasonable bounds checking That's a completely gratuitous change, it makes absolutely no difference to the code. If you like your way better you are free to use it on your own code; but please don't go around "fixing" other people's code like this. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Patches for FreeBSD 5.x compilation
by Francois Gouget 19 Nov '01

19 Nov '01

On Sun, 18 Nov 2001, Steve Kargl wrote: > The following patches are required to compile > the latest wine sources on FreeBSD 5.x. Note, I have a patch that I think should fix this compilation problem. I sent it on the 15th but it got loast without a trace so I resent it today (search for 'Solaris and FreeBSD compilation fixes (fwd)'). > Index: wine/dlls/wsock32/socket.c > =================================================================== > RCS file: /home/wine/wine/dlls/wsock32/socket.c,v > retrieving revision 1.16 > diff -u -r1.16 socket.c > --- wine/dlls/wsock32/socket.c 2001/11/14 21:26:23 1.16 > +++ wine/dlls/wsock32/socket.c 2001/11/18 18:42:14 > @@ -42,6 +42,7 @@ > #include <stdio.h> > #include <stdlib.h> > #include <unistd.h> > +#include <sys/socket.h> > #ifdef HAVE_SYS_SOCKIO_H > # include <sys/sockio.h> > #endif This should have a #ifdef HAVE_SYS_SOCKET_H around it. See my patch. > Index: wine/include/winsock.h > =================================================================== > RCS file: /home/wine/wine/include/winsock.h,v > retrieving revision 1.37 > diff -u -r1.37 winsock.h > --- wine/include/winsock.h 2001/11/14 21:26:24 1.37 > +++ wine/include/winsock.h 2001/11/18 18:42:17 > @@ -894,14 +894,10 @@ > struct WS(servent)* WINAPI WS(getservbyport)(int,const char*); > int WINAPI WS(getsockname)(SOCKET,struct WS(sockaddr)*,int*); > int WINAPI WS(getsockopt)(SOCKET,int,int,char*,int*); > -u_long WINAPI WS(htonl)(u_long); > -u_short WINAPI WS(htons)(u_short); > unsigned long WINAPI WS(inet_addr)(const char*); > char* WINAPI WS(inet_ntoa)(struct WS(in_addr)); > int WINAPI WS(ioctlsocket)(SOCKET,long,u_long*); > int WINAPI WS(listen)(SOCKET,int); > -u_long WINAPI WS(ntohl)(u_long); > -u_short WINAPI WS(ntohs)(u_short); > int WINAPI WS(recv)(SOCKET,char*,int,int); > int WINAPI WS(recvfrom)(SOCKET,char*,int,int,struct WS(sockaddr)*,int*); > int WINAPI WS(send)(SOCKET,const char*,int,int); This will break Winelib. I guess this was to fix the compilation errors in 'server/trace.c'. In that case I think a better solution is to not include 'winsock2.h' at all in server/trace.c since it appears to no longer be needed. > Index: wine/server/context_i386.c > =================================================================== > RCS file: /home/wine/wine/server/context_i386.c,v > retrieving revision 1.18 > diff -u -r1.18 context_i386.c > --- wine/server/context_i386.c 2001/07/11 17:30:59 1.18 > +++ wine/server/context_i386.c 2001/11/18 18:42:55 > @@ -20,9 +20,6 @@ > #ifdef HAVE_SYS_PARAM_H > # include <sys/param.h> > #endif > -#ifdef HAVE_SYS_USER_H > -# include <sys/user.h> > -#endif What is the problem with 'sys/user.h' ? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Demander si un ordinateur peut penser revient à demander si un sous-marin peut nager.

2 2

Re: Excessive redraw in Lotus Notes with Wine 20011108
by Glenn Schrader 19 Nov '01

19 Nov '01

Toby Haynes wrote: >I've just compiled up Wine 20011108 and given it a little testing. QuickTime >installer works fine and QuickTime player comes up, although it wants to be >fullscreen most of the time (something to do with strange mouse click handling >I think). SameTime installer runs (at least for version 1.5) although I can't >get the actual program to start (Unhandled exception). > >Lotus Notes 5.0.4 also appears to run fine with this build (I couldn't reply to >messages with the October WINE release) but there is one headache-inducing >problem. When composing a message or editing a document, the screen redraws for >every letter. It does this pretty quickly but the effect is that the screen >flashes as I type. It's bad enough that I type with my eyes closed to avoid >looking at the screen and edit any mistakes I make at the end. It's not a >problem at other times such as reading messages or browsing databases - only >editing seems to suffer from this. > >Setting double-buffer visuals doesn't seem to help. Managed or desktop >configurations both suffer from this. > >Does anyone have any clues as to settings to tweak to minimise/stop this >happening? I'd rather not go back to 20010326 (my stable backup build) but I >will if I can't solve this problem. > >Thanks, >Toby Haynes > I have been having a similar problem with a different app. Try the attached patch and see if it helps. --- Glenn Schrader Index: painting.c =================================================================== RCS file: /home/wine/wine/windows/painting.c,v retrieving revision 1.61 diff -u -r1.61 painting.c --- painting.c 2001/10/16 21:58:59 1.61 +++ painting.c 2001/11/18 22:48:09 @@ -345,23 +345,12 @@ TRACE("hrgnUpdate = %04x, \n", hrgnUpdate); - if (GetClassLongA( hwnd, GCL_STYLE ) & CS_PARENTDC) - { - /* Don't clip the output to the update region for CS_PARENTDC window */ - if( hrgnUpdate ) - DeleteObject(hrgnUpdate); - lps->hdc = GetDCEx( hwnd, 0, DCX_WINDOWPAINT | DCX_USESTYLE | - (bIcon ? DCX_WINDOW : 0) ); - } - else - { - if( hrgnUpdate ) /* convert to client coordinates */ - OffsetRgn( hrgnUpdate, wndPtr->rectWindow.left - wndPtr->rectClient.left, - wndPtr->rectWindow.top - wndPtr->rectClient.top ); - lps->hdc = GetDCEx(hwnd, hrgnUpdate, DCX_INTERSECTRGN | - DCX_WINDOWPAINT | DCX_USESTYLE | (bIcon ? DCX_WINDOW : 0) ); - /* ReleaseDC() in EndPaint() will delete the region */ - } + if( hrgnUpdate ) /* convert to client coordinates */ + OffsetRgn( hrgnUpdate, wndPtr->rectWindow.left - wndPtr->rectClient.left, + wndPtr->rectWindow.top - wndPtr->rectClient.top ); + lps->hdc = GetDCEx(hwnd, hrgnUpdate, DCX_INTERSECTRGN | + DCX_WINDOWPAINT | DCX_USESTYLE | (bIcon ? DCX_WINDOW : 0) ); + /* ReleaseDC() in EndPaint() will delete the region */ TRACE("hdc = %04x\n", lps->hdc);

1 0

Re: readdir broken when called from wine
by Gerard Patel 18 Nov '01

18 Nov '01

At 08:17 PM 18/11/2001 +0100, you wrote: >After "upgrading" from Wine-20010418 to Wine-20011004 (self-compiled >from tarballs), suddenly it didn't find my "C:\Windows" any >more. Worked before, same 'puter, config files, etc (TM). Tried with >CVS version. <snip> >What could be the difference that makes readdir "break"? Take a look at the 'cvs-regression' file in the documentation directory. Gerard

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel