wine-devel

wine-devel@winehq.org

10 participants
84459 discussions

linking in .lib files
by Chris Dawson 08 Nov '01

08 Nov '01

Is it possible to link in .lib files using winelib and winemaker? If possible, what switch do I give winemaker? My application when compiled under Windows linked in a .lib file and I would rather not modify the source code. I've tried using the -l switch, but this is obviously only for *nix libraries even when compiling with winelib. Or, other suggestions to resolve all the undefined reference errors? Thanks in advance, Chris

3 4

[PROBLEM REPORT] Focus problem for mdi children
by Gerard Patel 08 Nov '01

08 Nov '01

Mdi child window activation is broken since ChangeSet ID: 10050857000162942344322801 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard@wine2. 01/11/06 17:28:20 Modified files: dlls/ttydrv : wnd.c dlls/x11drv : winpos.c include : winpos.h windows : message.c winpos.c Log message: Window activation cleanups. The change that broke it is : --- /opt/cvs-commit/wine/dlls/x11drv/winpos.c 2001/10/22 19:08:34 1.31 +++ /opt/cvs-commit/wine/dlls/x11drv/winpos.c 2001/11/06 22:28:19 1.32 @@ -955,8 +955,7 @@ ShowCaret(winpos->hwnd); } - if (!(winpos->flags & SWP_NOACTIVATE)) - WINPOS_ChangeActiveWindow( winpos->hwnd, FALSE ); + if (!(winpos->flags & SWP_NOACTIVATE)) SetActiveWindow( winpos->hwnd ); /* And last, send the WM_WINDOWPOSCHANGED message */ Cause of the problem : the WM_CHILDACTIVATE message is not sent anymore, so the mdi children are not activated (caption does not change color, more annoyingly the active child is not set). The problem can be seen with Eudora or ForteFreeAgent. Using this patch : --- winpos.c.orig Wed Nov 7 10:41:32 2001 +++ winpos.c Thu Nov 8 00:44:29 2001 @@ -955,7 +955,20 @@ ShowCaret(winpos->hwnd); } - if (!(winpos->flags & SWP_NOACTIVATE)) SetActiveWindow( winpos->hwnd ); + if (!(winpos->flags & SWP_NOACTIVATE)) + { + SetActiveWindow( winpos->hwnd ); + if (!(wndPtr = WIN_FindWndPtr(winpos->hwnd))) return FALSE; + + /* child windows get WM_CHILDACTIVATE message */ + if( (wndPtr->dwStyle & (WS_CHILD | WS_POPUP)) == WS_CHILD ) + { + WIN_ReleaseWndPtr(wndPtr); + SendMessageA(winpos->hwnd, WM_CHILDACTIVATE, 0, 0L); + } + else + WIN_ReleaseWndPtr(wndPtr); + } /* And last, send the WM_WINDOWPOSCHANGED message */ seems to fix the problem. It may be too simple though :-) Gerard

1 0

Re: [PROBLEM REPORT] Focus problem for mdi children
by Alexandre Julliard 08 Nov '01

08 Nov '01

Gerard Patel <gerard.patel(a)nerim.net> writes: > Using this patch : > --- winpos.c.orig Wed Nov 7 10:41:32 2001 > +++ winpos.c Thu Nov 8 00:44:29 2001 > @@ -955,7 +955,20 @@ > ShowCaret(winpos->hwnd); > } > > - if (!(winpos->flags & SWP_NOACTIVATE)) SetActiveWindow( winpos->hwnd ); > + if (!(winpos->flags & SWP_NOACTIVATE)) > + { > + SetActiveWindow( winpos->hwnd ); > + if (!(wndPtr = WIN_FindWndPtr(winpos->hwnd))) return FALSE; > + > + /* child windows get WM_CHILDACTIVATE message */ > + if( (wndPtr->dwStyle & (WS_CHILD | WS_POPUP)) == WS_CHILD ) > + { > + WIN_ReleaseWndPtr(wndPtr); > + SendMessageA(winpos->hwnd, WM_CHILDACTIVATE, 0, 0L); > + } > + else > + WIN_ReleaseWndPtr(wndPtr); > + } > > /* And last, send the WM_WINDOWPOSCHANGED message */ > > > seems to fix the problem. It may be too simple though :-) No actually it's pretty much the right thing. I have applied a slightly simplified version of your patch, thanks for the report. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: RtlNtStatusToDosError issue
by Alexandre Julliard 07 Nov '01

07 Nov '01

"Bill Medland" <medbi01_1(a)accpac.com> writes: > What is the correct solution? To choose a status at random that translates > to ERROR_LOCK_VIOLATION? Yes. (but it's OK to pick one that makes some sense ;-) -- Alexandre Julliard julliard(a)winehq.com

1 0

RtlNtStatusToDosError issue
by Bill Medland 07 Nov '01

07 Nov '01

Can I solve this through documentation or do I have to use debug? I am implementing the LockFile stuff based on what Alexandre did to the CorelWine last year. Currently I have it returning error codes such as ERROR_LOCK_VIOLATION. However that causes RtlNtStatusToDosError to complain about not recognising it (no big surprise) during the server call. What is the correct solution? To choose a status at random that translates to ERROR_LOCK_VIOLATION? Bill

1 0

What's happened to www.winehq.com/ident
by Bill Medland 07 Nov '01

07 Nov '01

Anyone know what has happened to the LXR stuff? I used to use it to find where files are implemented but now the symbols don't seem to be indexed any longer. Bill

1 0

[EXPERIMENTAL PATCH]: Winsock2
by Martin Wilck 07 Nov '01

07 Nov '01

Hi, this patch tries to implement a small part of the extended Winsock 2 functionality in Wine. It is very experimental, I have only made sure everything compiles. It is _NOT_ intended for people to try and run. I am submitting this patch because I am pretty new to Wine hacking and I'd appreciate some Wine gurus to audit this for obvious stupidity, style incompatiblities, etc. Features implemented: - WSAAccept(), including callback functionality. - WSASocket(): support for dwFlags parameter. The real difficult stuff will follow when I start looking into WSARecv(), WSASend(), and WSAGetOverlappedResults(). Thus it'd be nice if someone pointed out my misconceptions before I put real work into the latter. Thanks & regards, Martin -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck@Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy Index: dlls/winsock/socket.c =================================================================== RCS file: /home/wine/wine/dlls/winsock/socket.c,v retrieving revision 1.65 diff -u -r1.65 socket.c --- dlls/winsock/socket.c 2001/10/14 16:25:47 1.65 +++ dlls/winsock/socket.c 2001/11/07 16:36:53 @@ -154,6 +154,7 @@ int WS_dup_pe(struct protoent* p_pe, int flag); int WS_dup_se(struct servent* p_se, int flag); int WINAPI WSOCK32_getpeername(SOCKET s, ws_sockaddr *name, int *namelen); +int WINAPI WSOCK32_getsockname(SOCKET s, ws_sockaddr *name, int *namelen); typedef void WIN_hostent; typedef void WIN_protoent; @@ -938,6 +939,131 @@ } /*********************************************************************** + * WSAAccept (WS2_32.26) + */ +SOCKET WINAPI WSAAccept(SOCKET s, + ws_sockaddr* addr, + LPINT addrlen32, + LPCONDITIONPROC cond_cb, + DWORD cb_data ) +{ + + /* Code copied largely from WSOCK32_accept() */ + /* FIXME: Can we simply call WSOCK32_accept() instead ? */ + /* I wasn't sure because of the AsyncSelect stuff at the end, + which presumably should only be called if the connection is accepted */ + + SOCKET as; + int fd = _get_sock_fd(s); + unsigned omask; + + TRACE("%04x cond=%08x data=%08x\n", (UINT16) s, (UINT) cond_cb, (UINT) cb_data); + + if (fd == -1) + { + SetLastError(WSAENOTSOCK); + return INVALID_SOCKET; + } + + if (_is_blocking(s)) + { + /* block here */ + do_block(fd, 5); + _sync_sock_state(s); /* let wineserver notice connection */ + /* retrieve any error codes from it */ + SetLastError(_get_sock_error(s, FD_ACCEPT_BIT)); + /* FIXME: care about the error? */ + } + + close(fd); + + SERVER_START_REQ( accept_socket ) + { + req->lhandle = s; + req->access = GENERIC_READ|GENERIC_WRITE|SYNCHRONIZE; + req->inherit = TRUE; + set_error( SERVER_CALL() ); + as = (SOCKET)req->handle; + } + SERVER_END_REQ; + + if (!as) + { + SetLastError(WSAENOTSOCK); + return INVALID_SOCKET; + } + + if (cond_cb) + { + /* We need our own buffers for Caller and Callee addresses. */ + /* FIXME: large enough / too large ? */ + const int SOCKADDR_LEN=128; + INT caller_len = SOCKADDR_LEN, callee_len = SOCKADDR_LEN; + char _caller_addr[SOCKADDR_LEN], _callee_addr[SOCKADDR_LEN]; + ws_sockaddr *caller_addr = (ws_sockaddr*) _caller_addr; + ws_sockaddr *callee_addr = (ws_sockaddr*) _callee_addr; + WSABUF caller_buf = { 0, _caller_addr }; + WSABUF callee_buf = { 0, _callee_addr }; + WSABUF callee_data_buf = { 0, NULL }; + GROUP group = 0; + int cb_result; + + WSOCK32_getpeername (as, caller_addr, &caller_len); + WSOCK32_getsockname (as, callee_addr, &callee_len); + caller_buf.len = caller_len; + callee_buf.len = callee_len; + + TRACE ("Calling callback\n"); + cb_result = cond_cb (&caller_buf, /* Caller ID */ + NULL, /* Caller data unsupported */ + NULL, NULL, /* QOS unsupported */ + &callee_buf, /* Callee id */ + &callee_data_buf, /* Callee data unsupported */ + &group, /* Group unsupported */ + cb_data); + + switch (cb_result) + { + case CF_ACCEPT: + TRACE ("Connection accepted\n"); + break; + case CF_REJECT: + closesocket (as); + TRACE ("Connection refused\n"); + SetLastError (WSAECONNREFUSED); + return INVALID_SOCKET; + case CF_DEFER: + TRACE ("Connection deferred\n"); + SERVER_START_REQ (set_socket_deferred) + { + req->handle = s; + req->deferred = as; + SERVER_CALL (); + } + SERVER_END_REQ; + SetLastError (WSATRY_AGAIN); + return INVALID_SOCKET; + default: + WARN ("Invalid return value\n"); + SetLastError (WSAEINVAL); + return INVALID_SOCKET; + } + + if (addrlen32 && addr && *addrlen32 >= caller_len) + memcpy (addr, caller_addr, caller_len); + + } else + WSOCK32_getpeername (as, addr, addrlen32); + + omask = _get_sock_mask( s ); + if (omask & FD_WINE_SERVEVENT) + ws2_async_accept(s, as); + + return as; +} + + +/*********************************************************************** * bind (WS2_32.2) */ int WINAPI WSOCK32_bind(SOCKET s, const ws_sockaddr* name, int namelen) @@ -1016,7 +1142,21 @@ */ INT WINAPI WSOCK32_closesocket(SOCKET s) { + SOCKET deferred; TRACE("socket %08x\n", s); + + /* Close a deferred socket if present */ + SERVER_START_REQ ( get_socket_deferred ) + { + req->handle = s; + SERVER_CALL (); + deferred = req->deferred; + } + SERVER_END_REQ; + + if (deferred) + WSOCK32_closesocket (deferred); + if (CloseHandle(s)) return 0; return SOCKET_ERROR; } @@ -2898,10 +3038,24 @@ g, dwFlags) are ignored. */ - TRACE("af=%d type=%d protocol=%d protocol_info=%p group=%d flags=0x%lx\n", + SOCKET s; + + TRACE("af=%d type=%d protocol=%d protocol_info=%p group=%d flags=0x%lx\n", af, type, protocol, lpProtocolInfo, g, dwFlags ); - return ( WSOCK32_socket (af, type, protocol) ); + s = WSOCK32_socket (af, type, protocol); + + if (dwFlags && s != INVALID_SOCKET) + { + SERVER_START_REQ ( set_socket_flags ) + { + req->handle = s; + req->flags = dwFlags; + SERVER_CALL(); + } + SERVER_END_REQ; + } + return s; } Index: dlls/winsock/ws2_32.spec =================================================================== RCS file: /home/wine/wine/dlls/winsock/ws2_32.spec,v retrieving revision 1.13 diff -u -r1.13 ws2_32.spec --- dlls/winsock/ws2_32.spec 2001/10/02 17:46:59 1.13 +++ dlls/winsock/ws2_32.spec 2001/11/07 16:36:53 @@ -38,7 +38,7 @@ 23 stdcall socket(long long long) WSOCK32_socket 24 stdcall WSApSetPostRoutine(ptr) WSApSetPostRoutine 25 stub WPUCompleteOverlappedRequest -26 stub WSAAccept +26 stdcall WSAAccept(long ptr ptr ptr long) WSAAccept 27 stub WSAAddressToStringA 28 stub WSAAddressToStringW 29 stdcall WSACloseEvent(long) WSACloseEvent Index: include/winsock2.h =================================================================== RCS file: /home/wine/wine/include/winsock2.h,v retrieving revision 1.10 diff -u -r1.10 winsock2.h --- include/winsock2.h 2001/10/02 17:46:59 1.10 +++ include/winsock2.h 2001/11/07 16:36:54 @@ -225,10 +225,44 @@ CHAR* buf; } WSABUF, *LPWSABUF; -typedef struct _OVERLAPPED * LPWSAOVERLAPPED; typedef HANDLE WSAEVENT; + +typedef struct _WSAOVERLAPPED { + DWORD Internal; + DWORD InternalHigh; + DWORD Offset; + DWORD OffsetHigh; + WSAEVENT hEvent; +} WSAOVERLAPPED, *LPWSAOVERLAPPED; + +#define WSA_IO_PENDING (WSAEWOULDBLOCK) +#define WSA_IO_INCOMPLETE (WSAEWOULDBLOCK) +#define WSA_INVALID_HANDLE (WSAENOTSOCK) +#define WSA_INVALID_PARAMETER (WSAEINVAL) +#define WSA_NOT_ENOUGH_MEMORY (WSAENOBUFS) +#define WSA_OPERATION_ABORTED (WSAEINTR) + +#define WSA_INVALID_EVENT ((WSAEVENT)NULL) +#define WSA_MAXIMUM_WAIT_EVENTS (MAXIMUM_WAIT_OBJECTS) +#define WSA_WAIT_FAILED ((DWORD)-1L) +#define WSA_WAIT_EVENT_0 ((DWORD)0) +#define WSA_WAIT_TIMEOUT ((DWORD)0x102L) +#define WSA_INFINITE ((DWORD)-1L) + +/* + * WinSock 2 extension -- manifest constants for WSASocket() + */ +#define WSA_FLAG_OVERLAPPED 0x01 +#define WSA_FLAG_MULTIPOINT_C_ROOT 0x02 +#define WSA_FLAG_MULTIPOINT_C_LEAF 0x04 +#define WSA_FLAG_MULTIPOINT_D_ROOT 0x08 +#define WSA_FLAG_MULTIPOINT_D_LEAF 0x10 + typedef unsigned int GROUP; +/* FIXME: We don't support QOS */ +typedef DWORD QOS, *LPQOS; + typedef void CALLBACK (*LPWSAOVERLAPPED_COMPLETION_ROUTINE) ( DWORD dwError, @@ -237,7 +271,27 @@ DWORD dwFlags ); +/* + * WinSock 2 extension -- manifest constants for return values of the condition function + */ +#define CF_ACCEPT 0x0000 +#define CF_REJECT 0x0001 +#define CF_DEFER 0x0002 +/* FIXME: The lpCallerData / lpCalleeData arguments are unsupported */ +typedef int CALLBACK (*LPCONDITIONPROC) +( + LPWSABUF lpCallerId, + LPWSABUF lpCallerData, + LPQOS lpSQOS, + LPQOS lpGQOS, + LPWSABUF lpCalleeId, + LPWSABUF lpCalleeData, + GROUP *g, + DWORD dwCallbackData +); + + /* Function declarations */ int WINAPI WSAEnumNetworkEvents(SOCKET s, WSAEVENT hEventObject, LPWSANETWORKEVENTS lpNetworkEvents); int WINAPI WSAEventSelect(SOCKET s, WSAEVENT hEventObject, long lNetworkEvents); @@ -251,6 +305,9 @@ LPWSAPROTOCOL_INFOA lpProtocolInfo, GROUP g, DWORD dwFlags); INT WINAPI ioctlsocket(SOCKET s, LONG cmd, ULONG *argp); + +/* FIXME: omitted the deviating WIN64 declaration */ +SOCKET WINAPI WSAAccept(SOCKET,ws_sockaddr*,LPINT,LPCONDITIONPROC,DWORD); #include "poppack.h" Index: server/protocol.def =================================================================== RCS file: /home/wine/wine/server/protocol.def,v retrieving revision 1.16 diff -u -r1.16 protocol.def --- server/protocol.def 2001/10/24 00:23:26 1.16 +++ server/protocol.def 2001/11/07 16:36:55 @@ -661,6 +661,31 @@ handle_t event; /* event object */ @END +/* Set Winsock2 flags */ +@REQ(set_socket_flags) + handle_t handle; /* handle to the socket */ + unsigned int flags; /* Winsock2 flags */ +@END + +/* Get Winsock2 flags */ +@REQ(get_socket_flags) + handle_t handle; /* handle to the socket */ +@REPLY + unsigned int flags; /* Winsock2 flags */ +@END + +/* Get deferred socket to be accept()ed later, for WSAAccept() */ +@REQ(get_socket_deferred) + handle_t handle; /* handle to the socket */ +@REPLY + handle_t deferred; /* deferred socket */ +@END + +/* Set deferred socket to be accept()ed later, for WSAAccept() */ +@REQ(set_socket_deferred) + handle_t handle; /* handle to the socket */ + handle_t deferred; /* deferred socket */ +@END /* Get socket event parameters */ @REQ(get_socket_event) Index: server/sock.c =================================================================== RCS file: /home/wine/wine/server/sock.c,v retrieving revision 1.21 diff -u -r1.21 sock.c --- server/sock.c 2001/10/05 19:45:45 1.21 +++ server/sock.c 2001/11/07 16:36:55 @@ -47,6 +47,8 @@ unsigned int pmask; /* pending events */ struct event *event; /* event object */ int errors[FD_MAX_EVENTS]; /* event errors */ + unsigned int flags; /* Winsock 2 socket flags */ + handle_t deferred; /* deferred socket to be accept()ed later */ }; static void sock_dump( struct object *obj, int verbose ); @@ -324,6 +326,8 @@ sock->hmask = 0; sock->pmask = 0; sock->event = NULL; + sock->flags = 0; + sock->deferred = 0; sock_reselect( sock ); clear_error(); return &sock->obj; @@ -342,36 +346,51 @@ GENERIC_READ|GENERIC_WRITE|SYNCHRONIZE,&sock_ops); if (!sock) return NULL; - /* Try to accept(2). We can't be safe that this an already connected socket - * or that accept() is allowed on it. In those cases we will get -1/errno - * return. - */ - slen = sizeof(saddr); - acceptfd = accept(sock->obj.fd,&saddr,&slen); - if (acceptfd==-1) { - sock_set_error(); - release_object( sock ); - return NULL; - } - if (!(acceptsock = alloc_object( &sock_ops, -1 ))) - { - release_object( sock ); - return NULL; + + if (sock->deferred) { + + /* If a previous WSAAccept() deferred accepting this request, try it again. */ + /* We do this no matter if called through accept() or WSAAccept(), */ + /* because this is the way Windows does it, too. */ + + acceptsock = (struct sock*)get_handle_obj(current->process,sock->deferred, + GENERIC_READ|GENERIC_WRITE|SYNCHRONIZE,&sock_ops); + sock->deferred = 0; + } else { + /* Try to accept(2). We can't be safe that this an already connected socket + * or that accept() is allowed on it. In those cases we will get -1/errno + * return. + */ + slen = sizeof(saddr); + acceptfd = accept(sock->obj.fd,&saddr,&slen); + if (acceptfd==-1) { + sock_set_error(); + release_object( sock ); + return NULL; + } + if (!(acceptsock = alloc_object( &sock_ops, -1 ))) + { + release_object( sock ); + return NULL; + } + + /* newly created socket gets the same properties of the listening socket */ + fcntl(acceptfd, F_SETFL, O_NONBLOCK); /* make socket nonblocking */ + acceptsock->obj.fd = acceptfd; + acceptsock->state = FD_WINE_CONNECTED|FD_READ|FD_WRITE; + if (sock->state & FD_WINE_NONBLOCKING) + acceptsock->state |= FD_WINE_NONBLOCKING; + acceptsock->mask = sock->mask; + acceptsock->hmask = 0; + acceptsock->pmask = 0; + acceptsock->event = NULL; + acceptsock->flags = sock->flags; + acceptsock->deferred = 0; } - /* newly created socket gets the same properties of the listening socket */ - fcntl(acceptfd, F_SETFL, O_NONBLOCK); /* make socket nonblocking */ - acceptsock->obj.fd = acceptfd; - acceptsock->state = FD_WINE_CONNECTED|FD_READ|FD_WRITE; - if (sock->state & FD_WINE_NONBLOCKING) - acceptsock->state |= FD_WINE_NONBLOCKING; - acceptsock->mask = sock->mask; - acceptsock->hmask = 0; - acceptsock->pmask = 0; - acceptsock->event = NULL; if (sock->event && !(sock->mask & FD_WINE_SERVEVENT)) - acceptsock->event = (struct event *)grab_object( sock->event ); - + acceptsock->event = (struct event *)grab_object( sock->event ); + sock_reselect( acceptsock ); clear_error(); sock->pmask &= ~FD_ACCEPT; @@ -589,3 +608,37 @@ release_object( &sock->obj ); } +DECL_HANDLER(get_socket_deferred) +{ + struct sock *sock; + + sock=(struct sock*)get_handle_obj(current->process,req->handle,GENERIC_READ|GENERIC_WRITE|SYNCHRONIZE,&sock_ops); + req->deferred = sock->deferred; +} + +DECL_HANDLER(set_socket_deferred) +{ + struct sock *sock; + + sock=(struct sock*)get_handle_obj(current->process,req->handle,GENERIC_READ|GENERIC_WRITE|SYNCHRONIZE,&sock_ops); + + sock->deferred = req->deferred; + release_object (&sock->obj); +} + +DECL_HANDLER(get_socket_flags) +{ + struct sock *sock; + + sock=(struct sock*)get_handle_obj(current->process,req->handle,GENERIC_READ|GENERIC_WRITE|SYNCHRONIZE,&sock_ops); + req->flags = sock->flags; +} + +DECL_HANDLER(set_socket_flags) +{ + struct sock *sock; + + sock=(struct sock*)get_handle_obj(current->process,req->handle,GENERIC_READ|GENERIC_WRITE|SYNCHRONIZE,&sock_ops); + sock->flags = req->flags; +} +

3 3

Re: SystemParametersInfo
by Alexandre Julliard 07 Nov '01

07 Nov '01

Andriy Palamarchuk <apa3a(a)yahoo.com> writes: > Changed system parameters won't be reset back to X > settings? Not if they are changed permanently; if we want them to be reset then we simply should not set them and always query X. Basically there are many possibilities: 1) get and set in registry, ignore X 2) get and set in registry, if nothing in registry get default value from X 3) always get from X, ignore registry, do nothing on set 4) always get from X, ignore registry, set X value on set (not recommended) and there are even more combinations if you differentiate setting permanently/temporarily. There is no single right answer, it all depends on what the parameter does. IMO most cases should do 1), but there can be exceptions. > One case which comes to mind when such integration > would be useful is system parameter which shows > whether mouse buttons are swapped. Left-handed person > can configure mouse after he ran Wine the first time, > or the settings can be changed temporarily. We need a > way to find out the system setting was changed and > don't rely on saved value. In this case I don't think we should query X at all, since if the buttons are swapped at the X level this is transparent for us. Otherwise the buttons will get swapped twice... -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: SystemParametersInfo
by Alexandre Julliard 07 Nov '01

07 Nov '01

Andriy Palamarchuk <apa3a(a)yahoo.com> writes: > I'm going to initialize system parameters from X > settings only on the first wine process startup, so > all other wine processes for the same wine server can > see the changes made by the first process. The X settings should probably be loaded lazily just like the rest. Just check if the registry key exists already to find out if you need to get the value from X. Another possibility is to have the X driver set the registry values on startup; this may actually be cleaner since then you don't need to add new calls to the USER driver. Also I'm not convinced there are many cases where we actually need to get proper values from X; what cases do you have in mind? > Other issue is fixed with this approach - the values > in registry are not changed back to X settings on > startup of new Wine process. > > Alexandre, the submitted patch is not affected by this > issue because none of the system parameters there is > initialized from X settings. > > Do you have any other concerns about the patch? Not really; a few minor issues but I'll fix them when committing the patch. -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: SystemParametersInfo
by Alexandre Julliard 07 Nov '01

07 Nov '01

Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> writes: > On Mon, Nov 05, 2001 at 06:20:24AM -0800, Andriy Palamarchuk wrote: > > Is there any way to check: > > 1) whether Wine process is the first process started > > for current Wine server? > Heh, I should really know ;-) > CLIENT_IsBootThread(). No, this shouldn't be used from user32 (besides it won't really do what you want). Why do you need this at all? -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: What does user mean?
by Alexandre Julliard 06 Nov '01

06 Nov '01

"Bill Medland" <medbi01_1(a)accpac.com> writes: > I am working on the server code (adding the byte locking stuff) and down in > the select/thread/object stuff I keep coming across the term "user" which > seems to be synonymous with object. What is it supposed to mean? Why is an > object a user? How does it relate to a physical person or a windows process > or whatever? In that context "user" means an object that is a user of the select facilities. It has nothing to do with Unix users or anything else, it's purely internal to the select routines. -- Alexandre Julliard julliard(a)winehq.com

1 0

What does user mean?
by Bill Medland 06 Nov '01

06 Nov '01

I am working on the server code (adding the byte locking stuff) and down in the select/thread/object stuff I keep coming across the term "user" which seems to be synonymous with object. What is it supposed to mean? Why is an object a user? How does it relate to a physical person or a windows process or whatever? Bill

1 0

Re: queries on internals...
by Alexandre Julliard 06 Nov '01

06 Nov '01

Francois Gouget <fgouget(a)free.fr> writes: > only returns one. I was also wondering how to best fix that. Since it is > a Winelib application and not a part of Wine I don't know if > implementing strsep in library/port.c is the best solution: shouldn't we > be able to compile regapi on Windows? In addition to that Wine itself > does not use strsep. I would like Alexandre's opinion on that :-) Just fix regapi so that it doesn't require strsep. There is no good reason to require it. -- Alexandre Julliard julliard(a)winehq.com

1 0

Extra info in scrollbar can be an handle.
by Marco Bizzarri 06 Nov '01

06 Nov '01

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all. We have an application which crashes when trying to access the Window Long info in a scrollbar. After some tracking, it looked like the issue was that in some cases the wExtra data can contain an handle rather than a pointer. The included patch solves the problem by making an explicit GlobalLock, and returning that value. I'm not sure this is the correct solution, so comments are welcome. wine is from the latest cvs - -- Marco Bizzarri - Responsabile Tecnico - Icube S.r.l. Sede: Via Ridolfi 15 - 56124 Pisa (PI), Italia E-mail: m.bizzarri(a)icube.it WWW: www.icube.it Tel: (+39) 050 97 02 07 Fax: (+39) 050 31 36 588 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://quantumlab.net/pine_privacy_guard/ iD8DBQE759zoXhfyAQQVoaIRApoGAJwOhVqzWtvYCz1oHZTcYSCYeCDQ6wCePBE3 DJ/zoeclED29BCnaC+9Ya8E= =rU+H -----END PGP SIGNATURE-----

1 0

Re: RTS/CTS
by lawson_whitney＠juno.com 06 Nov '01

06 Nov '01

On Tue, 6 Nov 2001, Mike McCormack wrote: > > Hi Lawson, > > good detective work! > > i don't think DSR/DTR flow control is supported by termios at all (at > least not in Linux), so here's a patch to ignore it. > > Mike > Okay, that passes the smoke test, and also looks right to me. Thanks. Did you forget a ChangeLog? Lawson Big fleas have little fleas upon their backs to bite 'em. And little fleas have smaller fleas and so on, infinitem.

1 0

Re: Winsock2 & overlapped IO
by Mike McCormack 06 Nov '01

06 Nov '01

Hi Ove, >Hm, by the way, when are you going to implemented overlapped >ConnectNamedPipe? That might make my rpcrt4 wait-for-connection code a bit >cleaner, so I don't have to spawn a separate thread per named pipe, and >worse, use TerminateThread to cancel the wait... OK. i'll have a look at it. Having a full time job, a part time job and a girlfriend to take care of kind of eats into my time though :-) >The challenges for winsock2 should be pretty much the same as those for >implementing something like ReadFileEx (which you've probably already >done) and the above-mentioned overlapped ConnectNamedPipe. Yeah, ReadFileEx is pretty much complete. Perhaps i'll have a look into overlapped sockets too... don't hold your breath though ;-) Mike btw. nice work on OLE/InstallShield stuff ------------------------------------------ mailto:Mike_McCormack@start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

1 0

RTS/CTS
by lawson_whitney＠juno.com 06 Nov '01

06 Nov '01

Good day! A couple of wine-users have said Wine doesn't work RTS/CTS right any more, so I did a +comm,+file trace of juno, and was rewarded with this: trace:comm:SetCommState handle 224, ptr 0x403f0578 trace:comm:SetCommState bytesize 8 baudrate 115200 fParity 0 Parity 0 stopbits 1 trace:comm:SetCommState ~IXON ~IXOFF trace:comm:SetCommState CRTSCTS trace:comm:SetCommState ~CRTSCTS Does something look wrong about that, or am I just seeing it crosseyed? In GetCommState we have this: if (port.c_cflag & CRTSCTS) { lpdcb->fDtrControl = DTR_CONTROL_ENABLE; lpdcb->fRtsControl = RTS_CONTROL_ENABLE; lpdcb->fOutxCtsFlow = 1; lpdcb->fOutxDsrFlow = 1; } else And in SetCommState this: if ( lpdcb->fOutxCtsFlow || lpdcb->fRtsControl == RTS_CONTROL_ENABLE ) { port.c_cflag |= CRTSCTS; TRACE("CRTSCTS\n"); } if (lpdcb->fDtrControl == DTR_CONTROL_ENABLE) { port.c_cflag &= ~CRTSCTS; TRACE("~CRTSCTS\n"); } So I guess if you want to turn off CRTSCTS, GetCommState(handle, lpdcb); SetCommState(handle, lpdcb); would about do it. I don't know what fDtrControl is 'spoze to do, but shutting off flow control entirely seems a bit extreme. Juno apparently asks for it by name, CRTSCTS was not on when it did GetCommState, but it asked for flow control, too. Lawson panic: detected rogue system administrator!! ---cut here

1 0

Re: SystemParametersInfo
by Andreas Mohr 05 Nov '01

05 Nov '01

On Mon, Nov 05, 2001 at 06:20:24AM -0800, Andriy Palamarchuk wrote: > Please, review the new version of SystemParametersInfo > implementation. > > Is there any way to check: > 1) whether Wine process is the first process started > for current Wine server? Heh, I should really know ;-) CLIENT_IsBootThread(). > 2) whether Windows application runs under Wine or > Windows? Eh ? I don't quite understand the logic behind this. Could you elaborate ? -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

2 2

Re: Duplicated StrRetToStr functions in shell32
by Guy L. Albertelli 05 Nov '01

05 Nov '01

Francois, The reason that these routines were duplicated is that the builtin shell32 cannot find StrRetToBuf{A|W} in some of the native versions of shlwapi.dll. This dependency prohibited testing with builtin vs. native shlwapi. The change was submitted to winehq about 8/28 and committed soon thereafter. Guy ----- Original Message ----- From: "Francois Gouget" <fgouget(a)free.fr> To: <wine-patches(a)winehq.com> Sent: Wednesday, October 31, 2001 11:46 PM Subject: Duplicated StrRetToStr functions in shell32 > > Shell32 contains StrRetToStrNA and StrRetToStrNW which are almost > identical to StrRetToBufA and StrRetToBufW. Since shell32 already > imports shlwapi it seems like we should just call the latter functions! > That way I won't have to fix the "0x%p" thing twice. > > > Changelog: > > * dlls/shell32/shellstring.c > > Implement StrRetToStrN{A,W} by calling shlwapi.StrRetToBuf{A,W} > instead of duplicating the code > > > > -- > Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ > I haven't lost my mind, it's backed up on tape around here somewhere... >

3 2

Winsock2 & overlapped IO
by Martin Wilck 05 Nov '01

05 Nov '01

Hello, I have started porting a software product of our company from NT to Linux using Wine. Part of this software is an agent which implements a proprietary protocol implemented with Winsock 2. In particular, it uses the Winsock 2 feature of "Overlapped IO" on sockets, with user-supplied callbacks that are called when data is received on a socket etc. Browsing through the Wine Winsock code, I saw that this part of Winsock2 is obviously unimplemented. Q: Has anybody worked on this already? Is there existing code somewhere? Q: Can you give an estimate if implementation of these features would require substantial changes in core wine code (something I'd like to avoid)? Q: Can you give me guidance on what part of the functionality would live in the wine server and what in the client? Regards, Martin -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck@Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy

1 0

The Corel Wine LockFile code
by Medland, Bill 04 Nov '01

04 Nov '01

Just enquiring. Why isn't the CorelWine locking code in the Wine tree? Is it merely because no-one has had the time, need or desire or is there something unacceptable about the way that they did it? (Also as a side issue it appears to me that it isn't going to work if the file is on a Windows machine because it looks to me like the fcntl stuff doesn't get handled by smbfs; any comments?) Bill

2 1

ImageList_Write stub
by j.m.maurer 04 Nov '01

04 Nov '01

Hello Wine Developers! For a while now I want to use Delphi under Wine, which works for 99%. The one thing that is missing seems to be the implementation of ImageList::Write which prevents opening of Forms which contain an ImageList control. The output Wine gives is: -- fixme:imagelist:ImageList_Write empty stub! While searching through winehq.com I came across the URL http://www.winehq.com/WineAPI/ImageList_Write.html which describes that ImageList::Write is indeed not implemented due to the fact that IStream32::Write is not implemented.... Is implementing these functions a particular difficult task or has nobody had any spare time to do it yet? I have no knowlegde whatsoever of the structure of Wine or the Windows API, but I have some spare time and some code skills... Does anyone have any hints on this issue? Bye! Marc Maurer Please CC a reply to me, since I can't subscribe to this mailinglist, due to an unknown low level error reported by mailman :-)

2 1

minimise/maximise causes crash in 20011004
by mdew 02 Nov '01

02 Nov '01

warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d021b warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3a7 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3c0 is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d04eb warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3a7 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3c0 is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40729933 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4072994c is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d04eb warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3a7 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3c0 is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40710e43 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40710e5c is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40710e43 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40710e5c is not inside heap warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40729933 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4072994c is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d00b3 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3a7 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3c0 is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heapwarn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40729933 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4072994c is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d00b3 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3a7 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4071d3c0 is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d0d97 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f123f is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x406f1258 is not inside heap warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:gdi:GDI_GetObjPtr Invalid handle 0 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40729933 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4072994c is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x40729933 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4072994c is not inside heap warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d08e7 warn:heap:HEAP_ValidateInUseArena Heap 411d0000: invalid in-use arena magic for 411d030b warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b48 is not inside heap warn:heap:HEAP_IsRealArena Heap 0x411d0000: block 0x4c0b61 is not inside heap warn:gdi:GDI_GetObjPtr Invalid handle 20003e warn:gdi:GDI_GetObjPtr Invalid handle 20003e warn:gdi:GDI_GetObjPtr Invalid handle 20003e warn:gdi:GDI_GetObjPtr Invalid handle 20003e warn:gdi:GDI_GetObjPtr Invalid handle 20003e warn:gdi:GDI_GetObjPtr Invalid handle 20003e <wine crash> causing this crash was just the act of minimising/maximising channel windows in mirc.

1 0

Yet again: audio.c stuff
by Simon Britnell 02 Nov '01

02 Nov '01

I've posted a substantial patch to audio.c which reorganises the code to make it a little easier to follow. It's been tested against HomeWorld and HalfLife. It works against homeworld with MIN_SLEEP_TIME 100, but not with MIN_SLEEP_TIME <=50. Feel free to set MIN_SLEEP_TIME to 0 to remove the minimum sleep time. The other thing the patch does is makes notifications dependant on bytes played rather than time elapsed. Should be a win overall. I'm still having no luck with tracking the actual race condition which causes HomeWorld to fail. I've not tried the patch you sent to fix the callback notification problem yet. I'll let you know when I do. __________________________________________________ Do You Yahoo!? Find a job, post your resume. http://careers.yahoo.com

1 0

RE: LockFile - any words of warning?
by Medland, Bill 01 Nov '01

01 Nov '01

Thanks, but > -----Original Message----- > From: Rein Klazes [mailto:rklazes@xs4all.invalid] > Sent: Wednesday, October 31, 2001 9:32 AM > To: Bill Medland > Cc: wine-devel(a)winehq.com > Subject: Re: LockFile - any words of warning? > > > On Wed, 31 Oct 2001 08:31:11 -0800, you wrote: > > > I am going to have to implement the LockFile/UnlockFile > functions. Does > > anyone have any words of warning? (Like it ain't as easy > as calling fcntl) > > Have a look at Corel's wine tree, where it is implemented. Please excuse my ignorance; how do I get at the Corel tree?

3 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel