wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Re: Colour problems with latest DIB fix
by Gerard Patel 30 Oct '01

30 Oct '01

At 12:53 PM 29/10/2001 -0800, you wrote: >> Anyway, the attached patch is displaying the failing picture correctly. >> What do you think ? > > If I apply your patch, then I see that the red and blue are exchanged >when I run vnc as: > vncserver :1 -geometry 800x600 -depth 16 -pixelformat bgr565 Could you explain a bit more what you are doing ? I would like to try the same but I don't see how to do it. Also, if you use vnc to test, did you consider the possibility that vnc could have a bug somewhere ? > Without the patch everything is fine. I also checked the formula and >I see nothing wrong with it (as long as you are on a little endian >computer, but you don't have a big endian x86, do you? ;-). Never heard that Amd is doing that :-) > So the question is why doesn't it work on your system. Can you run >The Sims (I assume it's with that the problem happens) with a +bitmap >trace? Then look for cases where either the bmp or the dib has >"depth=24". Then check the masks to see if they make sense. For example, >do they match what you know of your X server. You may also put a trace >in Convert_888_to_565_reverse and check that it is invoked at the right >time. Do they have a bgr888 dib (unsupported in windows AFAIK, but, >except for 1 or 2 shortcuts, supported in Wine)? Maybe it is the DIB >masks that are wrong. That's a bit involved for this evening :-/ > Also it would be great if you could run my test application and check >whether it displays fine. The line to watch for is the sixth line >(rgb888 dib to 565 rgb/bgr bmp and back). I had (of course) a number of problems with your app. First on my current computer - a Mandrake 8, with Xfree 4, your procedure ran fine until it tried to link the thing and then it reported that WinMain was missing. I changed in your code 'main' to 'WinMain' and all was well. I tried then to do the same on my other computer (Suse 6.1 with Xfree 3.3 and a hand-compiled glibc 2.1.3). No joy. Configure always failed with libwine.so failing to find symbols like dlclose and the like. I did not figure out what is happening, I just copied the binary from my other box and it worked. As for the results, what I see is 11 lines of 13 blocks of 4 colors : black, red, green, blue. I guess that when you speak of red and blue exchanged, you mean that in one of these blocks the red and blue lines are exchanged, right ? What is strange is that on both of my computers the display of your app is the same with or without my patch. No line exchanged that I can see. > As for The Sims, if you can also check the -debugmsg +bitmap output >and make sure it's coherent. I don't have The Sims... I use a little freeware app that is not available from the internet anymore, unfortunately :-/. And again, that's a bit complex for today. I'll try later. Gerard

2 1

Re:problems with dde, I think...
by Eric Pouech 30 Oct '01

30 Oct '01

> I can get the "library" window to show up when running wine, and the initial > "quick tip" window, but when I click the close button of the tip window wine > encounters an exception. I believe the exception is in user32.dll, in the > ddeuninitialize16 function. This is going from my memory of the one time I was > able to attach to the wine process to catch the exception. well you have to be sure of that... you can always trace with -debugmsg +dde,+relay and see what gives (and post the 100 lines before the exception is thrown) > I attempted copying the kernel32, user32 dll's from a win98 machine into my wine > dir, but this did not help. never do that. native kernel, user and gdi DLL won't work under wine. A+ --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) The future will be better tomorrow, Vice President Dan Quayle ____________________________________________________________ Faites un voeu et puis Voila ! www.voila.fr Avec Voila Mail, consultez vos e-mails sur votre mobile Wap.

1 0

problems with dde, I think...
by Josh Duncan 30 Oct '01

30 Oct '01

Hi all, I'm a little new to the list, so please be forgiving if I'm asking old questions. I've tried to do some research on the net and list archives to see if my questions have been answered before. I'm trying to run a program called Logos, which is a reference system for Biblical texts and other various study materials. It has a two-(independent)-windowed type interface, with a list of reference materials in one window("library"), and a workspace-type window containing subwindows with the texts of individual books. I can get the "library" window to show up when running wine, and the initial "quick tip" window, but when I click the close button of the tip window wine encounters an exception. I believe the exception is in user32.dll, in the ddeuninitialize16 function. This is going from my memory of the one time I was able to attach to the wine process to catch the exception. I attempted copying the kernel32, user32 dll's from a win98 machine into my wine dir, but this did not help. after doing this, I could not run winedbg either, as it exits giving me the following error: err:win32:PE_fixup_imports No implementation for kernel32.dll.0(wine_get_unix_file_name) imported from winedbg, setting to 0xdeadbeef This error occurs even after removing the two dlls. If anyone can give me advice about how to fix this, I'll try to post up the winedbg results of running the program(backtrace, et al) I know that some people have mentioned dde being broken between apps, I don't know if this is the case for this app, because when I was able to do a winedbg "walk process" it only listed one w-process, with 4 w-threads running. I have attached my wine config file, any advice would be greatly appreciated. (Also, if this email should have gone to the wine-users list, please let me know) I'm using the wine-20011029.i386.rpm from LinuxEasy, linked off of the winehq.org download page. sincerely, Josh Duncan not that it matters, but a pic of the two windows I can produce are at http://www.msmd.net/logos.jpg I'd try and show a pic of the other window, but the system gets so unstable that it can hard-lockup the machine, I think this is a cpu-spinning-in-signal handler problem but I couldn't get you a log right now to prove it.

1 0

Re: problem with virtualdub.
by Roger Fujii 29 Oct '01

29 Oct '01

Nerijus Baliunas wrote: > On Mon, 29 Oct 2001 17:04:51 +0000 Gerard Patel <gerard.patel(a)nerim.net> wrote: > > GP> The web site says that this executable is compressed with a tool called UPX. This > GP> seems to be the reason for the problem, as the original program is compiled with > GP> Ms VC++ - not a very exotic tool. > You can unpack it with upx, even under Linux - http://upx.sourceforge.net/. well, this indeed seems to be part of the problem. Decompressing it makes it go further, but still dies. > GP> I tried a hack for that and virtualdub got further; however, I see that it is > GP> trying to load avicap32.dll and this is not going to work - even under Linux > I remember I was able to start Virtual Dub with wine (maybe a year ago), but don't > remember if it worked. BTW, just yesterday TAKESHIMA Hidenori added stub for avicap32. really? Doesn't seem to be in cvs yet... Looks like it's getting upset about not finding StdChannelMask, but this is just a guess. -r

1 0

(no subject)
by Simon Britnell 29 Oct '01

29 Oct '01

I had an idea for using poll or select (rather than calculating expected play time and using a timeout) in audio.c The idea is to have a thread that sits on a select and dispatches a synthetic wine event (ie. we'd make up a WM_DSP_READY event) when the select returns. wodPlayer could then do an infinite wait and the select could be turned on or off when starting and ending playing. >From my relatively naive view a generic mechanism like this (ie. one that converts async IO selects into wine events) would be a good feature to have from a performance and code tidiness point of view. One caveat is that we'd need to ensure nothing evil happened if somebody sent the synthetic event from somewhere other than the select waiter. Comments? Am I missing something? __________________________________________________ Do You Yahoo!? Make a great connection at Yahoo! Personals. http://personals.yahoo.com

1 0

Re: problem with virtualdub.
by Gerard Patel 29 Oct '01

29 Oct '01

At 05:17 PM 26/10/2001 -0400, you wrote: > >there seems to be a funky problem with virtualdub >(http://virutaldub.sourceforge.net). Get differing >results between solaris and linux, but both seems to >fail before the app comes up. > >Under solaris, it seems like something is screwed up >with the loader - when it tries to load the binary, >it dies in dump_exports because what's at pe_exports >is just garbage. Not sure where it's dying under >linux (probably the same place) - don't have a devel >environment there (yet). > >Nothing unusual seems to happen before it gets there >(both solaris/linux binaries run sol.exe and other stuff just fine). >My suspicion is that the IMAGE_DIRECTORY_ENTRY_EXPORT data isn't pointing to what >wine thinks is there, but would like someone who knows more >about the loader to say something.... > >can anyone help shed more light onto this? > >-r > Yes, I have looked at this application. It loads fine under Windows - however, both dependancy walker and the Nt quick viewer are not happy with it (one displays that there is a format error in the exe, the other loops and finally crashes) The web site says that this executable is compressed with a tool called UPX. This seems to be the reason for the problem, as the original program is compiled with Ms VC++ - not a very exotic tool. I think that a fix could be to detect a corrupted header in dump_exports and to not try to display anything if numberoffunctions is not coherent with the export section size. I tried a hack for that and virtualdub got further; however, I see that it is trying to load avicap32.dll and this is not going to work - even under Linux ;:-) Gerard

2 1

Re: Colour problems with latest DIB fix
by Gerard Patel 29 Oct '01

29 Oct '01

At 02:18 PM 21/10/2001 -0700, you wrote: > >Johan Gill wrote: >> >> Since the big DIB fix, red and blue are exchanged in some cases, >> for example in the install program for The Sims. >> >> This happens in both depth 16 and depth 24. > > Could you give me some more information about your X server (version, >driver)? I see a very similar problem with my X server : 4.03 that comes with my Mandrake 8, graphic card is a Sis 6326. I had tested your patch before it was committed BTW but I failed to notice the problem :-/ Anyway, the attached patch is displaying the failing picture correctly. What do you think ? Gerard

2 1

struct thread in server/thread.h
by Gerald Pfeifer 29 Oct '01

29 Oct '01

In server/thread.h we have a definition of struct thread. Unfortunately, though, this clashes with struct thread as defined in /usr/include/sys/thread.h on FreeBSD 5.x and probably other systems (Solaris) as well. How should this be addressed? Would any of you mind fixing this? (If it's okay to just rename struct thread to struct winethread, I'm volunteering to handle that, else it'd be great could one of the experts have a look!) Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.dbai.tuwien.ac.at/~pfeifer/

1 0

Wine and Starcraft
by geschrader 29 Oct '01

29 Oct '01

I've been pecking away attempting to track down why the current wine build won't run Starcraft. When it starts up I get the effect that I playfully refer to as the TSOD (Technicolor Screen Of Death). What I've found is that if all of the references to gdi_display in X11DRV_DDHAL_SetPalEntries( ) are replaced with thread_display( ) then it actually starts up and looks pretty good. However, the keyboard and mouse don't work so this is at best a partial fix. I'm pretty sure that this is on the right track since X11DRV_XF86DGA2_CreatePalette( ) uses thread_display( ) to make the palette that is eventually given to X11DRV_DDHAL_SetPalEntries( ). The only other function in dlls/x11drv/x11ddraw.c that uses gdi_display is X11DRV_DDHAL_DestroyPalette( ). Should thread_display( ) be used there also? How is gdi_display related to the display returned by thread_display( )? Both are used in quite a few places but they're obviously not the same thing. Can anybody give me some hints on what might be happening with the keyboard and mouse? Thanks much, ges

1 0

FindWindow, WaitforSingleObject and Deadlock
by Uwe Bonnes 28 Oct '01

28 Oct '01

Hallo, I reported before, some applications of the quicklogic suite starts some watchdog application and hangs at this state. I tracked this down to the following sequence of events: - master application starts, sets up an event and resets the event - master application starts the watchdog - as soon as CreateProcess return, the Master application calls WaitForSingleObject with infinite timeout on that event - watchdog application starts and calls FindWindow. This is translated in a GetWindowText Call and finally SendMessageW (WM_GETTEXT) is called - Master application never awakes from waiting for the WaitForSingleObject Event and so never processes the SendMessage and Findwindow in the watchdog never returns I found two things relates to this deadlock in the API description: For WaitForSingleObject: "Use caution when calling the wait functions and code that directly or indirectly creates windows. If a thread creates any windows, it must process messages. Message broadcasts are sent to all windows in the system. A thread that uses a wait function with no time-out interval may cause the system to become deadlocked" so the latter behaviour seems right. But GetWindowText seems to expect such a deadlock: "If the target window is owned by the current process, GetWindowText causes a WM_GETTEXT message to be sent to the specified window or control. If the target window is owned by another process and has a caption, GetWindowText retrieves the window caption text. If the window does not have a caption, the return value is a null string. This behavior is by design. It allows applications to call GetWindowText without hanging if the process that owns the target window is hung." Sending the WM_GETTEXT only for local windows in the FindWindow loop makes the application continue and at some point the event is triggered. How should wine handle that case? Sould the caption be stored on the server? I it perhaps already? Bye Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Free Software: If you contribute nothing, expect nothing --

1 0

wine nolonger accepts mIRC dcc's
by mdew 27 Oct '01

27 Oct '01

when someone attempts to send you a file... i receive this in my status window. [06:12] DCC Get of sample_files.zip from Joe_dude: * Break: at one stage, wine+mirc did work..

1 1

WINE and Haxial programs
by haxial 27 Oct '01

27 Oct '01

Hi There My company produces a few programs that run on Windows and MacOS. Some of the users of these programs have been experimenting using WINE to run the programs on Linux. This is what they have been saying: "the KDX server runs FLAWLESSLY, 100% perfect, better than solitaire runs" However, there is one caveat to the above: I'm told that text input doesn't work when running KDX using WINE on Linux. I was wondering if I would be able to work with WINE developers in making KDX run perfectly on Linux using WINE. I think you would find this to be an easier task than usual because KDX only uses a *minimal* amount of windoze APIs. For example, KDX implements it's own GUI, it does not use the windoze API for that. Also, KDX even implements it's own graphics routines, it does not use the windoze GDI functions (except for the final step of getting the images onto the screen). KDX loads no obscure DLL's, it's just a single .exe file. It does not use MDI or any crap like that. It does not access the registry. It does not use MFC. So I think it would be much easier for WINE than your average windoze program. Which probably explains why it's already running well, except there is some bug, probably a minor little thing, that is preventing text input from working. The website is: http://www.haxial.com Thanks.

1 0

ReadFile behaviour on COMs
by Mike McCormack 27 Oct '01

27 Oct '01

Hey Uwe, There is still a number of problems with the COMM code that i am slowly fixing. They are: * comm ports opened without FILE_FLAG_OVERLAPPED don't use (any) read and write timeouts (patch in the works) * comm timeouts don't work 100% correctly * WaitCommEvent only works for EV_RXCHAR (difficult to solve correctly) Sounds like your problem might be related to #2. There are a few special cases for the values in the COMMTIMEOUTS structure that aren't being dealt with at the moment. Could you please post a -debugmsg +file,+comm trace and i'll have a look at it on Monday. Additionally, if the software is available online somewhere, please post a link to it. Mike ps. when you say the right byte, you mean the first byte, right? > Hallo, > > somebody showed me an application speaking to a device > connected to the serial port. The application failed after some > successfull communication steps. As the protocoll is available > in some other (open source programm) we could see that the > program requested two bytes from the device , but ReadFile only > delivered one byte (with that byte beeing the right one of the > expected two byte sequence). > > I suspect ReadFile to be the culprit. While the api description > tells to read all requested bytes ( beside of real errors), our > implementation happilies returns fewer bytes than requested. In > the case of COM devices, all timeouts of the SetCommTimeout > structure should be checked two. > > Anyone with an implementaion for that? > > Bye > -- > Uwe Bonnes ------------------------------------------ mailto:Mike_McCormack@start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

1 0

problem with virtualdub.
by Roger Fujii 26 Oct '01

26 Oct '01

there seems to be a funky problem with virtualdub (http://virutaldub.sourceforge.net). Get differing results between solaris and linux, but both seems to fail before the app comes up. Under solaris, it seems like something is screwed up with the loader - when it tries to load the binary, it dies in dump_exports because what's at pe_exports is just garbage. Not sure where it's dying under linux (probably the same place) - don't have a devel environment there (yet). Nothing unusual seems to happen before it gets there (both solaris/linux binaries run sol.exe and other stuff just fine). My suspicion is that the IMAGE_DIRECTORY_ENTRY_EXPORT data isn't pointing to what wine thinks is there, but would like someone who knows more about the loader to say something.... can anyone help shed more light onto this? -r

1 0

Re: none
by Alexandre Julliard 26 Oct '01

26 Oct '01

Andriy Palamarchuk <apa3a(a)yahoo.com> writes: > Ok, how about this: > Each system parameter has "is_loaded" flag which shows > whether the parameter is loaded or not. Parameters, > stored directly in SysParametersInfo are loaded from > registry only when they are requested and the flag is > "false", after the loading the flag is set to "true". > On interprocess notification of the parameter change > the corresponding parameter flag is set to "false". > The parameter will be reloaded when it is requested > the next time. Yes, something like this would work. > Are there any existing implementations of > communication between Wine processes I can use as an > example? You want to use some variant of SendMessage in this case, probably a broadcast SendNotifyMessage with an internal message code (adding a WM_WINE_ case in dlls/user/message.c). > Do you still think it is better don't affect X > settings from Wine? Yes. > While we are on this - what about other my patch - > "hello5.c"? It fixes a warning and an error message I > got when I tried to compile hello5.c. The error depends on the compiler version. You should check the DUMMYUNIONNAME defines if you want to make it work for all platforms. I'm not sure it's worth the trouble though. -- Alexandre Julliard julliard(a)winehq.com

1 0

(no subject)
by Andriy Palamarchuk 26 Oct '01

26 Oct '01

Alexandre Julliard wrote: > Andriy Palamarchuk <apa3a(a)yahoo.com> writes: > > >>Do you think it is better to do lazy loading for most >>parameters? >> > > Yes definitely. Ok, how about this: Each system parameter has "is_loaded" flag which shows whether the parameter is loaded or not. Parameters, stored directly in SysParametersInfo are loaded from registry only when they are requested and the flag is "false", after the loading the flag is set to "true". On interprocess notification of the parameter change the corresponding parameter flag is set to "false". The parameter will be reloaded when it is requested the next time. Parameters, backed by GetSystemMetrics are processed differently. These parameters are always loaded. They are reloaded right away on interprocess change notification. We can't do lazy loading because GetSystemMetrics returns its values from system metrics array and we don't want to complicate this function. I'm going to implement the flags as a bit array. Index constants for this array will be defined separately. >>I'll think about it more. Originally I planned to >>broadcast change notification across processes and use >>the reload function in other process to refresh values >>from registry. The problem with this approach is when >>a parameter is changed without saving. >> > > A possibility could to create a volatile registry branch to save > parameters that aren't permanently saved. This way they would be > accessible from other processes. Thank you for the idea. Are there any existing implementations of communication between Wine processes I can use as an example? Disregard the patches "SystemParametersInfo / GetSystemMetrics", "SPI_GET/SETBORDER". I'll implement the discussed above changes and resubmit them. Do you still think it is better don't affect X settings from Wine? Please let me know. While we are on this - what about other my patch - "hello5.c"? It fixes a warning and an error message I got when I tried to compile hello5.c. Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Make a great connection at Yahoo! Personals. http://personals.yahoo.com

1 0

ReadFile behaviour on COMs
by Uwe Bonnes 26 Oct '01

26 Oct '01

Hallo, somebody showed me an application speaking to a device connected to the serial port. The application failed after some successfull communication steps. As the protocoll is available in some other (open source programm) we could see that the program requested two bytes from the device , but ReadFile only delivered one byte (with that byte beeing the right one of the expected two byte sequence). I suspect ReadFile to be the culprit. While the api description tells to read all requested bytes ( beside of real errors), our implementation happilies returns fewer bytes than requested. In the case of COM devices, all timeouts of the SetCommTimeout structure should be checked two. Anyone with an implementaion for that? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

(no subject)
by Mike McCormack 26 Oct '01

26 Oct '01

Hi Andreas, i had a bit more free time, so i tracked down the rendering problem in NetTerm a bit more. The problem occurs after SelectVisRgn16 is called with the same region as that currently selected in the DC. (eg. dc->hVisRgn == hrgn ). I made a dodgy patch to fix the problem by incrementing the reference count of the region in this case, but i don't know how to fix it properly, because i don't know much about region handling. With the dodgy patch, NetTerm's windows paints properly. Perhaps perhaps you or somebody has a better way to fix the problem? Mike Andreas Mohr wrote: > On Tue, Oct 09, 2001 at 11:35:39AM +1000, Mike McCormack wrote: > > > > Hi All, > > > > i'm trying to solve a comms problem in NetTerm > > http://www.securenetterm.com/ but i've run into another problem. > > > > The rendering in NetTerm fails almost completely. I > > Yep, I strongly suspect a reference count problem here, too. > ------------------------------------------ mailto:Mike_McCormack@start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

1 0

Re: cursor visibility problem
by Alexandre Julliard 25 Oct '01

25 Oct '01

Ove Kaaven <ovehk(a)ping.uio.no> writes: > In Alexandre's new windowing architecture, we have in > dlls/x11drv/window.c, line 119, this: > > attr->cursor = X11DRV_GetCursor( display, GlobalLock16(GetCursor()) ); > > Problem: what if ShowCursor(FALSE) is called to hide the cursor *before* > the window was created? Yup, GetCursor still returns the current (arrow) > cursor, so the new window gets associated with a visible cursor, though > the app would expect the cursor to remain hidden. Yes, cursor handling has some problems right now. It also needs to be a lot more clever about setting the cursor on child windows, and not walk the full list of top-level windows on every SetCursor. It will be fixed eventually, but it's not my top priority right now. -- Alexandre Julliard julliard(a)winehq.com

1 0

cursor visibility problem
by Ove Kaaven 25 Oct '01

25 Oct '01

In Alexandre's new windowing architecture, we have in dlls/x11drv/window.c, line 119, this: attr->cursor = X11DRV_GetCursor( display, GlobalLock16(GetCursor()) ); Problem: what if ShowCursor(FALSE) is called to hide the cursor *before* the window was created? Yup, GetCursor still returns the current (arrow) cursor, so the new window gets associated with a visible cursor, though the app would expect the cursor to remain hidden. Diablo II is currently known to suffer from this problem... it has too many cursors visible. I haven't come up with a very clean solution to this... ideas?

1 0

winelib works only in debugmsg mode
by Guilherme Kunz 25 Oct '01

25 Oct '01

Hi, I have compiled a program with mfc using winemaker and when a run the program "./dlg" show a messagebox "Could not get address of WinMain", i am linking the mfc static mode. but when i run "./dlg --debugmsg +all &> debug.log" the program run right. gcc 2.96.85 kernel 2.2.19 Any idea ?? Thank you. Guilherme Kunz

1 0

Re: wine/memory virtual.c
by Alexandre Julliard 25 Oct '01

25 Oct '01

Ove Kaaven <ovehk(a)ping.uio.no> writes: > Well, though I haven't tested it yet (working on other stuff right now), > if it works for you, it'll work for me. I haven't really tested it either, but I'll commit it and we'll see... -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: wine/memory virtual.c
by Alexandre Julliard 25 Oct '01

25 Oct '01

Alexandre Julliard <julliard(a)winehq.com> writes: > It's used at least in debug events, so yes it's possible that the > debugger will try to use the handle to read the file. Probably better > to close it completely when on removable media; and we'll need to do > this for dlls too. I'll try to come up with something. OK how about this? Index: loader/pe_image.c =================================================================== RCS file: /opt/cvs-commit/wine/loader/pe_image.c,v retrieving revision 1.99 diff -u -r1.99 pe_image.c --- loader/pe_image.c 2001/10/02 17:49:20 1.99 +++ loader/pe_image.c 2001/10/24 19:39:21 @@ -667,6 +667,12 @@ if (nt->FileHeader.Characteristics & IMAGE_FILE_DLL) { + if (hFile) + { + UINT drive_type = GetDriveTypeA( wm->short_filename ); + /* don't keep the file handle open on removable media */ + if (drive_type == DRIVE_REMOVABLE || drive_type == DRIVE_CDROM) hFile = 0; + } SERVER_START_REQ( load_dll ) { req->handle = hFile; Index: scheduler/process.c =================================================================== RCS file: /opt/cvs-commit/wine/scheduler/process.c,v retrieving revision 1.162 diff -u -r1.162 process.c --- scheduler/process.c 2001/10/03 18:40:10 1.162 +++ scheduler/process.c 2001/10/24 19:39:22 @@ -327,6 +327,17 @@ lstrcpynA( main_exe_name, full_argv0, sizeof(main_exe_name) ); } + if (main_exe_file) + { + UINT drive_type = GetDriveTypeA( main_exe_name ); + if (drive_type == DRIVE_REMOVABLE || drive_type == DRIVE_CDROM) + { + /* don't keep the file handle open on removable media */ + CloseHandle( main_exe_file ); + main_exe_file = 0; + } + } + /* Retrieve entry point address */ entry = (LPTHREAD_START_ROUTINE)((char*)current_process.module + PE_HEADER(current_process.module)->OptionalHeader.AddressOfEntryPoint); Index: server/process.c =================================================================== RCS file: /opt/cvs-commit/wine/server/process.c,v retrieving revision 1.70 diff -u -r1.70 process.c --- server/process.c 2001/07/14 00:50:30 1.70 +++ server/process.c 2001/10/24 19:39:22 @@ -788,8 +788,9 @@ /* signal the end of the process initialization */ DECL_HANDLER(init_process_done) { - struct file *file; + struct file *file = NULL; struct process *process = current->process; + if (!process->init_event) { fatal_protocol_error( current, "init_process_done: no event\n" ); @@ -798,11 +799,10 @@ process->exe.base = req->module; process->exe.name = req->name; - if (req->exe_file && (file = get_file_obj( current->process, req->exe_file, GENERIC_READ ))) - { - if (process->exe.file) release_object( process->exe.file ); - process->exe.file = file; - } + if (req->exe_file) file = get_file_obj( current->process, req->exe_file, GENERIC_READ ); + if (process->exe.file) release_object( process->exe.file ); + process->exe.file = file; + generate_startup_debug_events( current->process, req->entry ); set_event( process->init_event ); release_object( process->init_event ); -- Alexandre Julliard julliard(a)winehq.com

2 1

ddraw fullscreen-app problem in latest CVS
by TAKESHIMA Hidenori 25 Oct '01

25 Oct '01

I can run some full-screen app in 2001/10/20 cvs. but, in the latest cvs, wine may crash in creating the fullscreen-primary surface... (I don't know why, but since wine-server protocol has been updated?????) ddrawtst.c is a minimal test program that crashes the latest cvs. My environment is: debian2.3-woody, XFree86-4.1.0-7. No permission to access /dev/kmem directly.

1 0

Re: Registry: Recursive key delete patch
by Gerard Patel 24 Oct '01

24 Oct '01

At 02:52 PM 24/10/2001 -0400, you wrote: > > This patch permits the recursive deletion of registry >keys that also contain subkeys. <snip> I think that the MSDN article about RegDeleteKey states that this is a win9x specific behaviour. Gerard

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel