wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Why is this wrong?
by Bill Medland 23 Jul '01

23 Jul '01

The code of "perfect_graphics" (attached) gives my system problems. The visible aspect of the problem is that the text in our application's listview doesn't get drawn properly. By experimentation I have narrowed it down to when perfect_graphics was edited. I observe that our application works correctly under the two following cases: 1. When the body of the function is removed and the value is hard-coded to true 2. When the "inline" is removed (which is the fix I am proposing and will submit in a moment) Since I do not like working without understanding I would like to know: Is there something wrong with the use of "inline" in this context? Or is there clearly something wrong with my build environment? Or is everyone else as confused by it as me? TIA Bill begin 600 e1 M+RHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ M*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ*BHJ#0H@*B @(" @(" @(" @<&5R M9F5C=%]G<F%P:&EC<PT*("H-"B J($9A=F]R(&-O<G)E8W1N97-S(&]R('-P M965D/PT*("HO#0IS=&%T:6,@:6YL:6YE(&EN="!P97)F96-T7V=R87!H:6-S M*'9O:60I#0I[#0H@(" @<W1A=&EC(&EN="!P97)F96-T(#T@+3$[#0H@(" @ M:68@*'!E<F9E8W0@/3T@+3$I#0H@(" @>PT*"4A+15D@:&ME>3L-"@EC:&%R M(&)U9F9E<ELR,%T[#0H)+RH@9&5F875L="!V86QU92 J+PT*"7!E<F9E8W0@ M/2 P.PT*"6EF*"%296=/<&5N2V5Y02A(2T597TQ/0T%,7TU!0TA)3D4L(")3 M;V9T=V%R95Q<5VEN95Q<5VEN95Q<0V]N9FEG7%QX,3%D<G8B+" F:&ME>2DI M#0H)>PT*"2 @("!$5T]21"!T>7!E+"!C;W5N=" ]('-I>F5O9BAB=69F97(I M.PT*"2 @("!I9B@A4F5G475E<GE686QU945X02AH:V5Y+" B4&5R9F5C=$=R M87!H:6-S(BP@,"P@)G1Y<&4L(&)U9F9E<BP@)F-O=6YT*2D-"B @(" @(" @ M(" @('L-"B @(" @(" @(" @(" @("!C:&%R(&-H(#T@8G5F9F5R6S!=.PT* M(" @(" @(" @(" @(" @('!E<F9E8W0@/2 H8V@@/3T@)WDG('Q\(&-H(#T] M("=9)R!\?"!C:" ]/2 G="<@?'P@8V@@/3T@)U0G('Q\(&-H(#T]("<Q)RD[ M#0H@(" @(" @(" @("!]#0H)(" @(%)E9T-L;W-E2V5Y*&AK97DI.PT*"7T- @"B @("!]#0H@(" @<F5T=7)N('!E<F9E8W0[#0I]#0IY ` end

1 0

Re: Executable permissions on .exe/.com files
by Alexandre Julliard 23 Jul '01

23 Jul '01

Bernhard Rosenkraenzer <bero(a)redhat.de> writes: > Since some people will probably want to use BINFMT_MISC or similar > functionality to run wine transparently, I think we need the possibility > to set executable permissions on wine-generated (e.g. by "wine setup.exe") > .exe/.com files. > > This patch implements this (optionally - new configure switch). I have applied it, but without the configure switch. I think it should be OK to always set the permissions, and if it turns out to cause trouble we should add a run-time option, not a compile-time one. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: implement BuildCommDCB16 using BuildCommDCB
by lawson_whitney＠juno.com 23 Jul '01

23 Jul '01

On Mon, 23 Jul 2001 16:59:35 +1000 Mike McCormack <mike_mccormack(a)start.com.au> writes: > This is a multi-part message in MIME format > > ------=_NextPart_000_80675836 > Content-Type: text/plain; charset="us-ascii" > Content-Transfer-Encoding: 7bit > > > This (untested) patch completes the COMM16 code seperation. The > COMM16 > code can now be moved into USER (i think). > > Mike Juno 1.49 finds no fault with this, but AFAICS from a comm trace, the app doesn't use the DCB functions, so this is not such a conclusive test. Anybody else have any 16 bit comms apps? Lawson ---oof--- > ChangeLog: > rewrite BuildCommDCB16 to depend on BuildCommDCB, not vice-versa > ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

Still problems with snoop
by Uwe Bonnes 23 Jul '01

23 Jul '01

Hallo, some days ago I reported early crashes when running with the snoop debug option. E.g. vc98 msedv.exe is a good example. Running with "+snoop" crashes early. Running with "-snoop=devshl" lets the program succeed much further. Running without snoop gets even substancial further. So I think there must be something wrong with snoop. I tried to look hard at relay32/snoop.c, but didn't see anything fishy. So perhaps somebody else has some idea what's going wrong. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 2

Re: PATCH: msvcrt.ungetc
by Alexandre Julliard 23 Jul '01

23 Jul '01

Marcus Meissner <marcus(a)jet.franken.de> writes: > --- include/msvcrt/stdio.h 2001/05/07 18:18:34 1.2 > +++ include/msvcrt/stdio.h 2001/07/21 12:43:43 > @@ -72,6 +72,7 @@ > int _charbuf; > int _bufsiz; > char* _tmpfname; > + int _ungetc; > } MSVCRT(FILE); You cannot do that, the FILE structure has to remain binary compatible. -- Alexandre Julliard julliard(a)winehq.com

2 1

RE: Microsoft source code releases - a danger to Wine?
by Patrik Stridvall 22 Jul '01

22 Jul '01

> There'a a legal doctrine whose name I can remember (I'm too young for > senior moments!) ... "inevitable contamination" or something It is call "inevitable disclosure" I think. > like that. > The basic idea is that someone who had been exposed to > Microsoft source > code and then worked on Wine within a given period of time would be > assumed to have used knowledge gained from that exposure. I believe > that the burden would be on that person or the Wine project to show > the opposite. For that person, perhaps. IIRC the doctrine of "inevitable disclosure" it on a little shaky ground as it is eventhough some Judges have use it so far, it is NOT 100% established doctrine. As far as the Wine project is concerned, you will have to stretch the doctrine pretty far since the Wine project can't possibly know what a patch submittor has done before unless he tells us himself. > This is what I'm really worried about. Some well-meaning hacker takes > "Advanced Operating System Theory" at a Microsoft-beholden university > and then makes a contribution to Wine. (The more I think about it, > I'm surprised Microsoft isn't trying harder to expose more people to > their code and license.) Sure, we probaly need to make others more aware of that, but that primarily concerns them, not us. > Fair use? We don't need stinking fair use! After all, that might > interfere with corporate earnings reports. (I'm too old to become a > communist!) And favouring fair use have what to do with communism? It is entirely possible to have a capitalistic society without Intellectuall Property (IP) at all or with very weak IP (strong fair use). > > That said, nothing I can see appears to restrict someone > who has accepted > > their license from answering explicit questions we might > have, so long as > > they are not doing so for hire (thus 'commercially'), and > so long as they > > don't distribute source code. A fair bit of useful > knowledge might be > > gained in that way, albeit slowly. > > > > > Now you're really scaring me! Why? Any violation is primarily their problem and extending derived work over a verbal description is stretching far to far. This has already been established by actual court case.

2 1

RE: Microsoft source code releases - a danger to Wine?
by Patrik Stridvall 22 Jul '01

22 Jul '01

> > Worse yet: If we coincidentally use similar code to theirs, > how can we > > prove we haven't looked at their code? If I were paranoid, > I'd say the > > single purpose of releasing the source was to get wine in trouble. > > It's not paranoia when they really are out to get you! Perhaps not, but do you really have proof that they are out to get you? :-) Seriously, I think you should calm down, getting to upset will do you no good. > IANAL, but distribution has been limited enough to this point > that they > would probably have to show some plausible manner in which > the exposure > could have occured. That's why I think wider distribution increases > the vigilance required. The burden of proof is still on Microsoft, not us.

1 0

RE: Microsoft source code releases - a danger to Wine?
by Patrik Stridvall 22 Jul '01

22 Jul '01

> On Sat, 21 Jul 2001, Ian Pilcher wrote: > > > This leads me to wonder if anyone's ever thought of taking steps to > > protect Wine from "contamination" by Microsoft IP (legally, > not tech- > > nically :-). > > What can we do about that? Since none of the people involved > is going to > have a look at the actual M$ source, how are we supposed to know if a > patch posted on the list is taken from them? We can't and we don't have to. The burden of proof is on Microsoft. Of course it is a civil cases and the proof need only be on preponderence of evidence but it still their burden primarily. > Worse yet: If we coincidentally use similar code to theirs, how can we > prove we haven't looked at their code? If I were paranoid, I'd say the > single purpose of releasing the source was to get wine in trouble. First of all: We know who submitted a patch since that information is in the CVS log, so unless they can prove that Alexandre should have realized the person submitting the patch, submitted code not copyrighted by that person, the burden fall on that person and that person alone. If that person can't be identified through the e-mail adress to bad for Microsoft. If he can they will have to drag him to court, not the Wine project. Sure Microsoft probably can ask the Wine remove the offending code and sue us if we don't, but since we in fact also are a victim of the submitters misrepresentation I think any reasonable judge would: 1. Require that Microsoft prove that the code is theirs. This might be a little difficult without providing the actual code to the Wine project and requiring any developer of the Wine project to taint him self by signing a NDA with Microsoft would probably not required by the court. So the reasonable cause of action would for Microsoft to release the code without a license that could taint us or pay for an independent 3rd party to review and establish this. 2. Require that Microsoft provide a patch to remove the offending code from the current CVS. Note that we also are a victim so requiring more would probably be considered unreasonable. Why should we pay for (in money or effort) somebody elses crime or legal liabillity against Microsoft. All in all I think the Judge would be rather annoyed that Microsoft didn't try to solve this problem without him. In short, while IANAL, if Microsoft (or somebody) feels that some code in the CVS is copyrighted by them we should simple require that. 1. Prove it to us, without any risk of taint, or to some independent 3rd party at their expense. 2. Provide a patch against the current CVS that removes the offending code preferable made by the same 3rd party as above at their expense. 3. Require that the 3rd party sign a statement under perjury that the patch removes the offending code and only the offending code. Remember we are also a victim under such an event and requiring more would probably not be look on favourable by the courts.

1 0

Proposed config file change
by Andreas Mohr 21 Jul '01

21 Jul '01

Hi all, I've been thinking for a rather long while now that the config file has a rather poor format. Several settings are pretty misplaced, and it tends to get chaotic. Let me just suggest something different: [COMM\\ParallelPorts] "Lpt1" = "..." "ppdev_378" = "..." [COMM\\SerialPorts] [COMM\\RASAPI] [COMM\\TAPI] [COMM\\WININET] [COMM\\WINSOCK] [DLLs\\Overrides] [File\\Drive x] [File\\General] "Windows" = "..." "System" = "..." "Temp" = "..." "Path" = "..." "ShowDirSymlinks" = "..." [File\\Registry] "LoadGlobalRegistryFiles" = "Y" "LoadHomeRegistryFiles" = "Y" "LoadWindowsRegistryFiles" = "Y" "WritetoHomeRegistryFiles" = "Y" "SaveOnlyUpdatedKeys" = "Y" "Profile" = "c:\\windows\\Profiles\\Administrator" [Graphics] "GraphicsDriver" = "x11drv" "WineLook" = "Win95" [Graphics\\DirectX] [Graphics\\Fonts] ;See a couple of examples for russian users below "Resolution" = "96" "Default" = "-adobe-helvetica-" "DefaultFixed" = "fixed" "DefaultSerif" = "-adobe-times-" "DefaultSansSerif" = "-adobe-helvetica-" [Graphics\\OpenGL] [Graphics\\Printing\\afmdirs] [Graphics\\Printing\\Spooler] "FILE:" = "tmp.ps" "LPT1:" = "|lpr" "LPT2:" = "|gs -sDEVICE=bj200 -sOutputFile=/tmp/fred -q -" "LPT3:" = "/dev/lp3" [Graphics\\Screen\\ttydrv] ;"Drivers" = "tty" ;"XtermProg" = "nxterm" ;"InitialRows" = "25" ;"InitialColumns" = "80" ;"TerminalType" = "nxterm" [Graphics\\Screen\\x11drv] ... [Sound\\DSOUND] "EmulatedDriver" = "..." [Sound\\WinMM] "Drivers" = "wineoss.drv" "WaveMapper" = "msacm.drv" "MidiMapper" = "midimap.drv" [wine] "ShellLinker" = "wineshelllink" [wine\\Clipboard] "ClearAllSelections" = "0" "PersistentSelection" = "1" [wine\\Ports] ;"read" = "0x779,0x379,0x280-0x2a0" ; "write" = "0x779,0x379,0x280-0x2a0" [wine\\Spy] "Exclude" = "WM_SIZE;WM_TIMER;" This has the advantage that it has a very basic structure (COMM, DLLs, File, Sound, Wine), and you always know where to start searching. I haven't spent much thought on whether it's really "right" and, most importantly, extensible, though. Comments ? -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

1 0

Re: glibc bug mmap/malloc
by Alexandre Julliard 21 Jul '01

21 Jul '01

Andreas Mohr <a.mohr(a)mailto.de> writes: > I mean, come on: why did they bother to implement malloc() at all > if the resulting architecture is THAT broken ? It's not broken, it just doesn't play well with programs like Wine that muck around with the process address space. But it's a perfectly reasonable (if not optimal) implementation for "normal" Unix apps. -- Alexandre Julliard julliard(a)winehq.com

2 1

Wine doesn't seem to like TrueType fonts.
by David Hagood 21 Jul '01

21 Jul '01

Has anybody else seen this behavior: I have a directory of TrueType fonts that I can point xfs to. When I have that directory in the fontlist, wine ALWAYS regenerates the font cache on every start (thus slowing Wine down immensely). Remove the TrueType directory from the font table, and all is well: Wine will regenerate the font cache once, and then use the font cache from there on.

1 0

Marshaling
by Daniel Walker 21 Jul '01

21 Jul '01

From what I've read when someone creates a custom interface for COM, an IDL file is generated, then the MIDL compiler uses the IDL file to create proxy and stub code that works with the standard COM RPC functionality.. So under some (most) circumstances wine's COM implementation would only have to facilitate the sending and recieving of the marshaled data .. Not to minimize the work involved .. The standard marshaling would have to do all the generic COM interfaces like IUnknown, IStorage, IStream (I think). Even though full implementations of those would be available . But most components would have custom interfaces so they would also have their own marshaling code .. If I'm 100% correct then , I guess, there wouldn't be a need for the type information. Yet it exists .. Unless the type info is used for something other than marshaling. Daniel Walker

2 1

Re: more misc fixes
by Alexandre Julliard 20 Jul '01

20 Jul '01

Patrik Stridvall <ps(a)leissner.se> writes: > OK. So what you really what is exactly the opposite of what I tried to do? Yep ;-) > You want all 16-bit exported function prototypes moved from the .h > files to the implementing .c file in all cases that is is possible (ie Wine > compiles without errors or warnings)? Exactly; but note that in most cases the prototype is not even needed at all. I don't want all 16-bit C files to start with a bunch of prototypes either, this would just be unnecessary duplication; only the functions that are actually called from elsewhere in the file should be prototyped IMO. > Do you also want the types and structures moved as well? > That will often not be possible, but do you want it > despite this in the cases where it is possible? Wherever possible it would be a good thing yes. -- Alexandre Julliard julliard(a)winehq.com

3 2

UNC
by Bill Medland 20 Jul '01

20 Jul '01

Is anyone doing anything on UNC filenames? (In particular I am interested in GetFileAttributes) Bill

2 1

Re: attempting to load mIRC32 5.91 using latest wine cvs
by mdew 20 Jul '01

20 Jul '01

On Thu, 19 Jul 2001 11:05:55 +0200 Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: > >>>>> "mdew" == mdew <rpbrown(a)xtra.co.nz> writes: > > mdew> mdew@storm:~$ /usr/local/bin/wine fake_windows/mIRC/mirc32.exe > mdew> FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock > mdew> FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock > mdew> err:module:BUILTIN32_dlopen failed to load .so lib for builtin > mdew> x11drv.dll: /usr/lib/libwine_tsx11.so: undefined symbol: > mdew> XF86DGAGetViewPortSize Could not load graphics driver 'x11drv' > > Either get an newer X-Server with DGA capabilities, or configure and compile > on your system. i do...in fact, i downloaded an older version of wine (20010510) which works fine... Im running Debian Sid which comes with XFree86 4.0.3 and using the Nvidia openGL drivers.. dga works in all apps i use (mplayer, quake3, MAME) just not the latest cvs of wine.

1 0

Re: COMM16: use overlapped I/O not service thread
by lawson_whitney＠juno.com 20 Jul '01

20 Jul '01

On Fri, 20 Jul 2001, Mike McCormack wrote: > > Hi, > > i've tested this patch a little... with wfw3.1 terminal, i can type AT > and receive OK from my modem, but i'm not supremely confident about > it. If somebody :-) could test it and review it a bit i'd be > grateful... > > Mike > > ChangeLog: > Replace service thread with ReadFileEx/WriteFileEx for COMM16. > > So as not to damn it with faint praise, my 16 bit app sent a response, and received 0 messages successfully. I _think_ it is OK, there shouldn't have been any messages for it to receive. Lawson ---oof--- ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

Re: COMM16: use overlapped I/O not service thread
by lawson_whitney＠juno.com 20 Jul '01

20 Jul '01

On Fri, 20 Jul 2001 12:33:23 +1000 Mike McCormack <mike_mccormack(a)start.com.au> writes: > This is a multi-part message in MIME format > > ------=_NextPart_000_53222353 > Content-Type: text/plain; charset="us-ascii" > Content-Transfer-Encoding: 7bit > > > Hi, > > i've tested this patch a little... with wfw3.1 terminal, i can type > AT > and receive OK from my modem, but i'm not supremely confident about > it. If somebody :-) could test it and review it a bit i'd be > grateful... > > Mike > > ChangeLog: > Replace service thread with ReadFileEx/WriteFileEx for COMM16. > > If you get this, my 16 bit comms app can at least send mail with your patch. It aint much, but it is a bit more than terminal.exe talking to a modem. Lawson --- Somebody, somebody has to, you see, So she picked out two somebodies, Sally and me. - T.S.G. ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

1 0

RE: more misc fixes
by Patrik Stridvall 19 Jul '01

19 Jul '01

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Ah. You are right, I orginally meant to add it in a > > different file (wine/obj_base16.h perhaps) but I didn't > > think it would matter since other 16 bit interface like > > IStream16 and IStorage16 is in wine/obj_*.h already. > > Perhaps they should be move out as well? > > > > If so to where? wine/obj_*16.h or perhaps the DLLs > directories if possible? > > The DLL directories definitely; and if possible in the .c file where > they are needed, to make it clear they must not be used from the > outside. Ah, yes. The implementing .c file, thats an idea. Like in dlls/lzexpand/lzexpand_main.c, I guess you mean? > > In addition (as I hinted in 5.) requiring all non-static functions > > to have a .h file declaration is good policy for any application > > including Wine. Hint, if a function isn't static somebody else > > should use it otherwise some else is wrong, ie it really should > > be static after all. > > All 16-bit API functions must be treated as if they were static. Well we could actually make them truely static with a little trickery and a corrensponding change of winebuild. Idea: #define DECLARE_ENTRY_POINT16(module, function) \ void *module##_p##function = (void *) &function /* After the includes */ static void Foo(void *, int); DECLARE_ENTRY_POINT16(BAR, Foo); /* ... */ static void Foo(void *, int) { /* ... */ } It is probably not worth the trouble though. > They > cannot be because of the spec file reference, but ideally no code > should ever call a 16-bit API, it should use the corresponding 32-bit > API. Adding prototypes and a header file is only going to encourage > using these functions which is not what we want. OK. So what you really what is exactly the opposite of what I tried to do? You want all 16-bit exported function prototypes moved from the .h files to the implementing .c file in all cases that is is possible (ie Wine compiles without errors or warnings)? Do you also want the types and structures moved as well? That will often not be possible, but do you want it despite this in the cases where it is possible?

1 0

RE: Lots of #defines OK?
by Patrik Stridvall 19 Jul '01

19 Jul '01

> Patrik Stridvall wrote: > > Not really, but as an alternative solution you could has a structure > > instead of an array like: > > > > typedef struct { > > GLYPHNAME A; > > GLYPHNAME AE; > > GLYPHNAME AEacute; > > GLYPHNAME AEsmall; > > /* ... */ > > } GLYPHNAMES; > > > > Perhaps this is better since it doesn't use the preprocessor. > > I not thought of that -- neat idea. What is the downside of using the > preprocessor, however? Well, the preprocessor "pollutes" the namespace in a way that is sometimes bad and my solution gives IMHO a slightly nicer syntax. Is this case in don't think it matters so much though, your orginal solution is fine, in fact is the standard solution in C to the problem you have AFAIK. My suggestion is really just brainstorming to give you hopefully a different perspective of the issue. Also note that your solution is not possible with languages that don't have pointer aritmetics that C, fortunately or unluckily depending on how you see it, have.

2 1

Re: more misc fixes
by Alexandre Julliard 19 Jul '01

19 Jul '01

Patrik Stridvall <ps(a)leissner.se> writes: > Ah. You are right, I orginally meant to add it in a > different file (wine/obj_base16.h perhaps) but I didn't > think it would matter since other 16 bit interface like > IStream16 and IStorage16 is in wine/obj_*.h already. > Perhaps they should be move out as well? > > If so to where? wine/obj_*16.h or perhaps the DLLs directories if possible? The DLL directories definitely; and if possible in the .c file where they are needed, to make it clear they must not be used from the outside. > In addition (as I hinted in 5.) requiring all non-static functions > to have a .h file declaration is good policy for any application > including Wine. Hint, if a function isn't static somebody else > should use it otherwise some else is wrong, ie it really should > be static after all. All 16-bit API functions must be treated as if they were static. They cannot be because of the spec file reference, but ideally no code should ever call a 16-bit API, it should use the corresponding 32-bit API. Adding prototypes and a header file is only going to encourage using these functions which is not what we want. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: more misc fixes
by Patrik Stridvall 19 Jul '01

19 Jul '01

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Index: wine/include/wine/obj_base.h > > =================================================================== > > RCS file: /home/wine/wine/include/wine/obj_base.h,v > > retrieving revision 1.40 > > diff -u -u -r1.40 obj_base.h > > --- wine/include/wine/obj_base.h 2001/05/07 18:15:40 1.40 > > +++ wine/include/wine/obj_base.h 2001/07/19 14:50:28 > > @@ -34,6 +34,8 @@ > > #include "wtypes.h" > > #include "guiddef.h" > > > > +#include "wine/windef16.h" > > This is wrong; Win32 header files must not include 16-bit ones. Ah. You are right, I orginally meant to add it in a different file (wine/obj_base16.h perhaps) but I didn't think it would matter since other 16 bit interface like IStream16 and IStorage16 is in wine/obj_*.h already. Perhaps they should be move out as well? If so to where? wine/obj_*16.h or perhaps the DLLs directories if possible? > Also please avoid adding more 16-bit headers in include/wine, there > are already too many of them. Well that was the idea at first but at least of the new ones are was needed in more that one directory some I ended up adding all of them there. But sure I can move the ones that are not use in more of one directory to that directory, I'm just a little worried that since the wine/*16.h header are 16-bit "mirrors" of the corresponding 32-bit files that functions from other DLLs happends to end up there as well. Microsoft seems have mixed headers and DLLs without much thought especially as far as OLE is concerned. Sure we can have several .h files with the same name in different DLL directories as far as functions are concerned since 16-bit functions shouldn't call across different DLLs anyway, but duplicating types and such are not a very good idea. But sure I can examine the files more carefully and see if it is possible and of course we can add it to a DLL directory first and then move it to include/wine if is because nessary in the future. > These headers (when they are really > necessary) belong in their respective dll directory. And BTW your new > lzexpand16.h is an example of a header file that is *not* necessary. Nessary for compiling Wine no, clearly not since it already compiles. However IMO all exported functions whether they are 16-bit or 32-bit and whether they are actually uses by other files or not should have declarations in some header file. For 32-bit it must obviously be so because of Winelib. The undocumented functions is of course not strictly nessary but I see not reason not to have them as a Wine extension that can be ported to Windows eventually in order to have the same source on both Unix and Windows. For 16-bit is seems that you disagree. Well, the advantages that I can think of for doing it for 16-bit as well is the following. 1. It makes it much easier for developer to add calls across files between 16-bit functions or move functions between files if the infrastructure is alreay in place. 2. It makes it possible to see related 16-bit functions together in a .h file instead of having to search the .c files. 3. It makes it possible go through each 16-bit .h file compare it with Windows and add the missing functions in the .h files and when somebody in the future runs winapi_check (or whatever) it is possible to present a list of what is not yet implemented. Sure the .spec contains that information as well in some meaning but it misses which functions that are actually listed in the 16-bit header files and thus likely to actually be used by real applications. 4. Since some of the 16-bit exported functions must be declared in some .h since it is used in some of file than it was declared, it is be much easier to require all 16-bit export function to be declared since it is difficult to tell which that are (or will be) really needed. 5. There is nothing unreasonable to require every non-static function let alone functions that are exported by either Win16 or Win32 to have a declaration in some .h files. Indeed tools like lint (at least on Solaris) have flags to check for this. In short trying to only add the 16-bit functions that are stricly nessary to .h files is more trouble than it is worth, especially compare to the advantages that having all of them .h files. In addition (as I hinted in 5.) requiring all non-static functions to have a .h file declaration is good policy for any application including Wine. Hint, if a function isn't static somebody else should use it otherwise some else is wrong, ie it really should be static after all. But OK. You think that there are too many 16-bit files in include/wine. No problem. I will try to avoid it if at all possible.

1 0

Re: more misc fixes
by Alexandre Julliard 19 Jul '01

19 Jul '01

Patrik Stridvall <ps(a)leissner.se> writes: > Index: wine/include/wine/obj_base.h > =================================================================== > RCS file: /home/wine/wine/include/wine/obj_base.h,v > retrieving revision 1.40 > diff -u -u -r1.40 obj_base.h > --- wine/include/wine/obj_base.h 2001/05/07 18:15:40 1.40 > +++ wine/include/wine/obj_base.h 2001/07/19 14:50:28 > @@ -34,6 +34,8 @@ > #include "wtypes.h" > #include "guiddef.h" > > +#include "wine/windef16.h" This is wrong; Win32 header files must not include 16-bit ones. Also please avoid adding more 16-bit headers in include/wine, there are already too many of them. These headers (when they are really necessary) belong in their respective dll directory. And BTW your new lzexpand16.h is an example of a header file that is *not* necessary. -- Alexandre Julliard julliard(a)winehq.com

1 0

RE: Lots of #defines OK?
by Patrik Stridvall 19 Jul '01

19 Jul '01

> I would like to get rid of the "hardcoded" offset into the glyph name > array and replace it with a macro ('GN_exclam', for example). > Each font > data file could then simply include a header that gets > regenerated when- > ever the glyphlist is changed -- eliminating the current > requirement to > regenerate all the font data. > > Anyone see any problems with this? (There are currently 1258 built-in > glyph names.) Not really, but as an alternative solution you could has a structure instead of an array like: typedef struct { GLYPHNAME A; GLYPHNAME AE; GLYPHNAME AEacute; GLYPHNAME AEsmall; /* ... */ } GLYPHNAMES; Perhaps this is better since it doesn't use the preprocessor. However I'm not sure if all C compilers supports 1258 structure members. Another possible problem is alignment on some platforms if you must be able for iterate over it and use it as and array. Of course you can simply have a seperate array of pointers like: GLYPHNAMES glyphnames = { /* ... */ }; GLYPHNAME *pGlyphnames[] = { &glyphnames.A; &glyphnames.AE; &glyphnames.AEacute; &glyphnames.AEsmall; /* ... */ };

2 1

Lots of #defines OK?
by Ian Pilcher 19 Jul '01

19 Jul '01

I'm giving some thought to cleaning up the data structures used by the PostScript driver. Any significant change here will require that the glyph list and font data be regenerated. This is not particularly difficult, but it would be easier if I could remove the dependency of the font data on the glyph name array. Each glyph's metrics include a pointer to its name, and all of the built-in glyph names are in a single array named PSDRV_AGLGlyphNames (in dlls/wineps/data/agl.c). So the metrics for a glyph look like this: { 33, 0x0021, 600, PSDRV_AGLGlyphNames + 907, { 236, -15, 364, 572 }, NULL /* exclam */ } I would like to get rid of the "hardcoded" offset into the glyph name array and replace it with a macro ('GN_exclam', for example). Each font data file could then simply include a header that gets regenerated when- ever the glyphlist is changed -- eliminating the current requirement to regenerate all the font data. Anyone see any problems with this? (There are currently 1258 built-in glyph names.) Thanks! -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

1 0

attempting to load mIRC32 5.91 using latest wine cvs
by mdew 19 Jul '01

19 Jul '01

mdew@storm:~$ /usr/local/bin/wine fake_windows/mIRC/mirc32.exe FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock err:module:BUILTIN32_dlopen failed to load .so lib for builtin x11drv.dll: /usr/lib/libwine_tsx11.so: undefined symbol: XF86DGAGetViewPortSize Could not load graphics driver 'x11drv' err:heap:HEAP_GetPtr Invalid heap 00000000! err:heap:HEAP_GetPtr Invalid heap 00000000! err:heap:HEAP_GetPtr Invalid heap 00000000! err:module:BUILTIN32_LoadLibraryExA loaded .so but dll display.dll still not found fixme:console:SetConsoleCtrlHandler (0x546e60,1) - no error checking or testing yet FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock err:module:BUILTIN32_dlopen failed to load .so lib for builtin x11drv.dll: /usr/lib/libwine_tsx11.so: undefined symbol: XF86DGAGetViewPortSize Could not load graphics driver 'x11drv' FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock err:module:BUILTIN32_dlopen failed to load .so lib for builtin x11drv.dll: /usr/lib/libwine_tsx11.so: undefined symbol: XF86DGAGetViewPortSize Could not load graphics driver 'x11drv' err:module:BUILTIN32_LoadLibraryExA loaded .so but dll display.dll still not found err:module:BUILTIN32_LoadLibraryExA loaded .so but dll display.dll still not found err:heap:HEAP_GetPtr Invalid heap 00000000! err:heap:HEAP_GetPtr Invalid heap 00000000! err:heap:HEAP_GetPtr Invalid heap 00000000! err:module:BUILTIN32_LoadLibraryExA loaded .so but dll display.dll still not found err:module:BUILTIN32_LoadLibraryExA loaded .so but dll display.dll still not found err:heap:HEAP_GetPtr Invalid heap 00000000! err:heap:HEAP_GetPtr Invalid heap 00000000! spews this message out many times (then quits)..., using the same wine config ..as always.. Using Debian Sid x86 (gcc-2.95.4-XFree86-4.0.3)

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel