wine-devel

wine-devel@winehq.org

9 participants
84457 discussions

The Muncher project.
by Josh Walker 12 Feb '01

12 Feb '01

I aplolgize for the spelling. I never was any good at english. The muncher project is the implmentation of wine into a very very unique distro of linux and used as a true windows clone. I know, it's not a good name for a project, but it's the best I could come up with after spinning around in a desk chair for five minutes. I also know that this isn't the first time anyone has come up with the idea either, but this is differnt. I have an implentation scheme. I came up with the idea while working on an mp3 player for my car (which also runs linux) There are two HDs in my car stereo. The first is a small 512M drive running linux with all the core compents to make xmms work. The second drive is the mp3 drive, an 8GB removable with FAT32 on it so I can swap it into a windows box too. The mall Linux drive does all the work. It struck me one day that wouldn't it be cool at have a real windows interface for wine. I mean, you can hack the system as much as you can, but when it comes to it, the explorer start bar and all of the activeX do-hickies like control panel and My computer are owned by microsoft. So I devised a plan to make Linux look, run, smell, feel, and act like windows. The goal is to fool my mom by swapping the OS and seeing if she notices. The system works muck like the mp3 player in my car. Two partitons, one is the linux "Macrokenrel" which does all the behind the scenes stuff and the a fat32 partition, which holds the windows files and that the user only sees. The Macrokenel will be a linux partition that has the ability to boot, starts the devices, and then run the neccary core files. The big ones are X, FVWM95, the gnome desktop (Just the desktop, no icons, or panels, no virtual displays, nothing crazy... yet), and wine. Using glade, I will write little replacements for the ActiveX compents that are missing, (My computer, Control panel, etc) GTK will handle the windows "theme" as far as widgets go and fvwm95 is small, sleek, and gives you the right window dressings and a start button. I have here a compiled list of what I plan to add. CORE: Main Kernel -> Linux 2.4.1, USB and harware support big plus/framebuffer for startup screen http://www.kernel.org/ Dos support -> DosEMU 1.0.1 with FreeDOS .98, depending on dos support under wine http://www.dosemu.org/ http://www.freedos.org/ Windows support -> Wine, the latest http://www.winehq.org/ Graphic Display -> Xfree86 4.0.2 more graphics cards, the better font server http://www.xfree86.org DirectX -> Transgameing Explorer(GUI) -> modded FVWM95/Gnome desktop combo ftp://mitac11.uia.ac.be/html-test/fvwm95.html http://www.gnome.org Explorer(filelister) -> gmc (was Midnight Commander, swallowed by Gnome) http://www.gnome.org Explorer(Browser) -> Mozilla (activeX compent, full browser) http://www.iol.ie/~locka/mozilla/mozilla.htm http://www.mozilla.org/ DO-HICKIES & THINGAMABOBS: These are small apps that are written in gtk (possably quick glide apps) that mimic the function of native windows apps. My Computer -> GTK do-hickie that looks like My Computer Launches gmc and the contol panel do-hiokie. System -> GTK do-hickie that will list devices that are valid in /dev in a windows format, intermixed with kernal modules and stuff from kudzu. Network Neighborhood -> LinNeighborhood/Samba http://www.bnro.de/~schmidjo/ Trash -> Gnome's trash Display Properties -> GTK do-hickie that edits xf86config, xscreensaver, and fvwmrc is a windows fimilar way Dial-up Networking -> working for an ISP, I know this thing foreward and backwards do-hickie that writes chat/pppd scripts, easy! Control Panel -> Ugh! Do what WinME does. Make it simple unless you want complex. Start with date/time, internet options, display, printers, and totaly ignore add/remove programs for now. Complex will have date/time, display, fonts, internet options keyboard, modems, mouse, network, passwords, printers regonal settings, scedualed tasks, system Date/Time -> simple GTK app internet options -> working for an ISP know this foreward amd backwards too edits chat/pppd scripts Printers -> Wrapper for redhat's printtool w/ tweaks add/remove programs -> not gonna touch this with a 10 foot pole. maybe later fonts -> links to the font dirs in X keyboard -> edits keyboard properties and Xkeyboard settings who's config file escapes me for the moment. modems -> chat script tweaking mouse -> gtk app that pays with mouse bindings network -> know this back and foreward too, grabbs info from the loaded kernel modules passwords -> password wrapper for xdm, gdm, *dm password thingies regonal settings -> sets loocale varible sceduled tasks -> wrapper for editing the chrontab It's a big task, but I have faith in myself. I'm going to be build a "base system" tomarrow (Ceryix 133, 40M ram, Sound Blaster, Matrox graphics card, and a 814M HD) Feel free to comment. I have no web page on the porject yet, I don't want to call attention to myself in case it turns out to be a bigger project that I intended. Maybe we can use a form of this as a DirectX-compatible only OS that can just run games. Look out X-box ^_^ -Halkun

1 0

Small DDraw problem
by Lionel Ulmer 12 Feb '01

12 Feb '01

Hi all, After seeing the reports on cemw of Grim Fandango not working anymore, I decided to check it out. Install worked fine, but the game did not work. It stopped just after doing a SetCooperativeLevel. After some checkings, the error came from there (file dlls/ddraw/ddraw/main.c) : HRESULT WINAPI Main_DirectDraw_SetCooperativeLevel(LPDIRECTDRAW7 iface, HWND hwnd, DWORD cooplevel) { (....) if ((This->cooperative_level & DDSCL_EXCLUSIVE) && (cooplevel & DDSCL_EXCLUSIVE)) return DDERR_EXCLUSIVEMODEALREADYSET; (....) } Grim Fandango did the following : fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x4039a090)->(00000138,00000051) - DDSCL_FULLSCREEN DDSCL_ALLOWMODEX DDSCL_EXCLUSIVE (...) fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x4039a090)->(00000138,00000011) - DDSCL_FULLSCREEN DDSCL_EXCLUSIVE I wonder if this test is really needed ? My interpretation of the 'DDERR_EXCLUSIVEMODEALREADYSET' error was that ANOTHER application already used this flag, not that it was already set for the current application. Anyway, removing this test fixed Grim Fandango. It now starts fine, except for some palette problems. If you agree, I will submit a patch that removes this test :-) Lionel PS: I found out that Grim Fandango eats up my X auto repeat (I need to do a 'xset r on' after)... I thought that this was removed in recent Wine versions ?

4 3

Explorer/shell question.
by Rob Landley 12 Feb '01

12 Feb '01

I don't personally use windows, but I have a lot of friends who do. I just showed a friend 98lite.net (which has apparently gone commercial in the last year or two; I was actually looking for the list of instructions the used to have on how to replace the 98 I.E. based explorer with the 95 filesystem only explorer and delete I.E. from the system). Unfortunately, the 95 explorer, being MS intellectual property, can't be included with 98lite, they have to have a copy of 95 (pre OSR 2.5) lying around. I vaguely remembered this list discussing cloning the filesystem explorer months and months back, so my next thought was to wander over to winehq and see if you guys had cloned the filesystem explorer in such a way it could potentially be cleaned up and used to browse the filesystem so I.E. can be deleted. I didn't find one here, so I'm guessing the outcome of said discussion was "no, we aren't going to do that", but it seemed to be a question worth asking anyway. So: has anybody simply cloned the 95 explorer yet? Would the clone run under windows itself? How deeply does it have its tentacles into the guts of the rest of the system? Where would I go to look for such a thing? Rob __________________________________________________ Do You Yahoo!? Get personalized email addresses from Yahoo! Mail - only $35 a year! http://personal.mail.yahoo.com/

3 2

Re: Novell filesystem support
by gerard patel 12 Feb '01

12 Feb '01

At 01:44 PM 12/2/01 +1200, you wrote: <snip> >program, by writting into the users maildir. How this is done is >under novel you can Create files in directorys that you cannot see(if >that permisson is greated to you). But you can't do this under unix. >So the need to implement file i/o for novell files arises. Why not just give the Scan file right to the user ? Certainly more simple, and this is not a very serious security breakage IMO. Gerard

3 3

Fix to OpenGL for BadMatch issue with Alice
by Gavriel State 12 Feb '01

12 Feb '01

Hi Lionel, I recently remembered that I hadn't mentioned the below patch to you. This is something that we put in the last TG patch to fix an issue with Alice, but I'm not sure if the problem in question is the fault of the Wine OpenGL code or an issue with NVidia's OpenGL driver (I haven't really tried it on other drivers yet). Alice creates a rendering window, then walks through the pixel formats for that window's DC using DescribePixelFormat. The current implementation of DescribePixelFormat simply creates a new visual for each pixel format by calling glXChooseVisual. Under the NVidia libGL, at least, this creates a new visual even if there's already a visual that matches the requested parameters. Once we try to create a wgl context, the previous implementation was picking one of the newly created visuals, and initializing the glX context with that. An instant later, we get an X BadMatch error, since the rendering window that Alice is using was created with the default X11DRV visual, not the visual that was created by DescribePixelFormat. The patch below is a simple fix to just always use the X11DRV visual when creating contexts. Ideally we would somehow recreate the X11DRV window with the new visual, but I suspect that will have to wait for significant restructuring of the X11DRV. I didn't notice until later that you'd done a similar hack in X11DRV_ChoosePixelFormat, forcing the visual there to be the default. We could do the same thing for X11DRV_DescribePixelFormat as well, or we could simply drop most of the visual management code in graphics/x11drv/opengl.c and use my patch below. What's your preference? -Gav Index: wine/dlls/opengl32/wgl.c diff -u wine/dlls/opengl32/wgl.c:1.1.1.3 wine/dlls/opengl32/wgl.c:1.3 --- wine/dlls/opengl32/wgl.c:1.1.1.3 Tue Jan 23 12:12:23 2001 +++ wine/dlls/opengl32/wgl.c Tue Jan 23 12:23:42 2001 @@ -78,6 +78,8 @@ X11DRV_PDEVICE *physDev; XVisualInfo *vis; Wine_GLContext *ret; + int num; + XVisualInfo template; TRACE("(%08x)\n", hdc); @@ -88,8 +90,9 @@ physDev = (X11DRV_PDEVICE *)dc->physDev; - /* First, get the visual for the choosen pixel format */ - vis = physDev->visuals[physDev->current_pf - 1]; + /* First, get the visual in use by the X11DRV */ + template.visualid = XVisualIDFromVisual(X11DRV_GetVisual()); + vis = XGetVisualInfo(display, VisualIDMask, &template, &num); if (vis == NULL) { ERR("NULL visual !!!\n"); @@ -299,7 +302,7 @@ return ret->func; } else { - ERR("Extension defined in the OpenGL library but NOT in opengl_ext.c... Please report (lionel.ulmer(a)free.fr) !\n"); + ERR("Extension %s defined in the OpenGL library but NOT in opengl_ext.c... Please report (lionel.ulmer(a)free.fr) !\n", lpszProc); return NULL; } } -- Gavriel State, CEO TransGaming Technologies Inc. http://www.transgaming.com gav(a)transgaming.com

1 0

Novell filesystem support
by Simeon Pilgrim 12 Feb '01

12 Feb '01

Hello, I have been making Wine support Novell Bindery calls via the ncplib, so that I can get Pegasus mail to do mhs mail. But i've hit the brick wall, novell file operations on a window -> unix -> novell file system dose not work very well. So what needs to happen is make Wine know about other file system types other than dos / windows / unix. What I was thinking is, there must be some system that windows uses to register extra file systems and then use supplied functions for read/write/etc operations. Dose Wine also support this system, or should it be made to do this? If this is in place where in the code should I look for references. If it is not supported, is it something that is should be supported in the future( i.e. a clean implementation ) or is an ugly little hack ok. If doing a hack, what structures should I add the extra information to, what structures should I not touch. p.s. sorry if this has been brought up before, I found it hard to search the archives. Regards, Simeon Pilgrim ------------------------------------------------------------- Simeon Pilgrim 27 Nazareth Avenue System Test Engineer PO Box 8011 Allied Telesyn Research Christchurch 8034 (An Allied Telesyn Group company) New Zealand phone +64 3 377 8900 fax +64 3 377 8870 -------------------------------------------------------------

2 2

[Fwd: Eyes requested]
by Ian Pilcher 12 Feb '01

12 Feb '01

Ian Pilcher wrote: > > Can anyone comment on whether using alloca will mess up Wine? (Jon's > comment seems to imply that he avoids alloca on general principles, > rather than for Wine-specific reasons.) Does Wine use exceptions? > Never mind. Upon further review, alloca looks like a bad idea all the way around. (God forbid C should actually include a feature that makes someone's life easier!) -- ======================================================================== Ian Pilcher pilcher(a)concentric.net ========================================================================

1 0

Eyes requested
by Ian Pilcher 12 Feb '01

12 Feb '01

Attached is a patch to implement EnumPrinterDataEx (which should let everyone be happy about where the PostScript driver's font substitution table goes). Since this is the first time I've implemented a "real" Win32 API, rather than just doing internal tweaking, I may have missed something that's glaringly obvious to the more experienced. Before I send this to wine- patches, I'd appreciate it if some folks would take a quick look and let me know what they think. Thanks! -- ======================================================================== Ian Pilcher pilcher(a)concentric.net ======================================================================== --- ../wine-20010203cvs/include/winspool.h Sun Feb 11 21:46:34 2001 +++ include/winspool.h Sun Feb 11 14:59:53 2001 @@ -763,6 +763,25 @@ DECL_WINELIB_TYPE_AW(PPROVIDOR_INFO_1) DECL_WINELIB_TYPE_AW(LPPROVIDOR_INFO_1) +typedef struct _PRINTER_ENUM_VALUESA { + LPSTR pValueName; + DWORD cbValueName; + DWORD dwType; + LPBYTE pData; + DWORD cbData; +} PRINTER_ENUM_VALUESA, *PPRINTER_ENUM_VALUESA; + +typedef struct _PRINTER_ENUM_VALUESW { + LPWSTR pValueName; + DWORD cbValueName; + DWORD dwType; + LPBYTE pData; + DWORD cbData; +} PRINTER_ENUM_VALUESW, *PPRINTER_ENUM_VALUESW; + +DECL_WINELIB_TYPE_AW(PRINTER_ENUM_VALUES) +DECL_WINELIB_TYPE_AW(PPRINTER_ENUM_VALUES) + /* DECLARATIONS */ INT WINAPI DeviceCapabilitiesA(LPCSTR pDevice,LPCSTR pPort,WORD fwCapability, LPSTR pOutput, LPDEVMODEA pDevMode); @@ -1082,6 +1101,14 @@ BOOL WINAPI DeletePrintProvidorW(LPWSTR pName, LPWSTR pEnvironment, LPWSTR pPrintProvidorName); #define DeletePrintProvidor WINELIB_NAME_AW(DeletePrintProvidor) + +DWORD WINAPI EnumPrinterDataExA(HANDLE hPrinter, LPCSTR pKeyName, + LPBYTE pEnumValues, DWORD cbEnumValues, + LPDWORD pcbEnumValues, LPDWORD pnEnumValues); +DWORD WINAPI EnumPrinterDataExW(HANDLE hPrinter, LPCWSTR pKeyName, + LPBYTE pEnumValues, DWORD cbEnumValues, + LPDWORD pcbEnumValues, LPDWORD pnEnumValues); +#define EnumPrinterDataEx WINELIB_NAME_AW(EnumPrinterDataEx) --- ../wine-20010203cvs/dlls/winspool/winspool.drv.spec Sun Feb 11 21:46:34 2001 +++ dlls/winspool/winspool.drv.spec Sun Feb 11 14:59:53 2001 @@ -80,6 +80,10 @@ @ stub EnumPrintProcessorDatatypesW @ stub EnumPrintProcessorsA @ stub EnumPrintProcessorsW +@ stub EnumPrinterDataA +@ stdcall EnumPrinterDataExA(long str ptr long ptr ptr) EnumPrinterDataExA +@ stdcall EnumPrinterDataExW(long wstr ptr long ptr ptr) EnumPrinterDataExW +@ stub EnumPrinterDataW @ stdcall EnumPrinterDriversA(str str long ptr long ptr ptr) EnumPrinterDriversA @ stdcall EnumPrinterDriversW(wstr wstr long ptr long ptr ptr) EnumPrinterDriversW @ stdcall EnumPrintersA(long ptr long ptr long ptr ptr) EnumPrintersA --- ../wine-20010203cvs/dlls/winspool/info.c Sun Feb 11 21:46:34 2001 +++ dlls/winspool/info.c Sun Feb 11 21:36:19 2001 @@ -2561,3 +2561,322 @@ return GetPrinterDataExW(hPrinter, PrinterDriverDataW, pValueName, pType, pData, nSize, pcbNeeded); } + +/* + * The Win32 doc says that RegCloseKey and HeapFree can fail, but it's hard to + * imagine why either of them would. And what is the calling function supposed + * to do about it anyway? + */ + +#define REGCLOSEKEY(X) \ +{ \ + DWORD ret; \ + \ + ret = RegCloseKey (X); \ + if (ret != ERROR_SUCCESS) \ + WARN ("RegCloseKey returned %li\n", ret); \ +} + +#define HEAPFREE(X,Y,Z) \ +{ \ + if (HeapFree ((X), (Y), (Z)) == 0) \ + WARN ("HeapFree failed with code %li\n", GetLastError ()); \ +} + +/******************************************************************************* + * EnumPrinterDataExW [WINSPOOL.197] + */ +DWORD WINAPI EnumPrinterDataExW(HANDLE hPrinter, LPCWSTR pKeyName, + LPBYTE pEnumValues, DWORD cbEnumValues, + LPDWORD pcbEnumValues, LPDWORD pnEnumValues) +{ + HKEY hkPrinter, hkSubKey; + DWORD ret, dwIndex, cValues, cbMaxValueNameLen, + cbValueNameLen, cbMaxValueLen, cbValueLen, + cbBufSize, dwType; + LPWSTR lpValueName; + HANDLE hHeap; + PBYTE lpValue; + PPRINTER_ENUM_VALUESW ppev; + + TRACE ("%08x %s\n", hPrinter, debugstr_w (pKeyName)); + + if (pKeyName == NULL || *pKeyName == 0) + return ERROR_INVALID_PARAMETER; + + ret = WINSPOOL_GetOpenedPrinterRegKey (hPrinter, &hkPrinter); + if (ret != ERROR_SUCCESS) + { + TRACE ("WINSPOOL_GetOpenedPrinterRegKey (%08x) returned %li\n", + hPrinter, ret); + return ret; + } + + ret = RegOpenKeyExW (hkPrinter, pKeyName, 0, KEY_READ, &hkSubKey); + if (ret != ERROR_SUCCESS) + { + REGCLOSEKEY (hkPrinter); + TRACE ("RegOpenKeyExW (%08x, %s) returned %li\n", hPrinter, + debugstr_w (pKeyName), ret); + return ret; + } + + REGCLOSEKEY (hkPrinter); + + ret = RegQueryInfoKeyW (hkSubKey, NULL, NULL, NULL, NULL, NULL, NULL, + &cValues, &cbMaxValueNameLen, &cbMaxValueLen, NULL, NULL); + if (ret != ERROR_SUCCESS) + { + REGCLOSEKEY (hkSubKey); + TRACE ("RegQueryInfoKeyW (%08x) returned %li\n", hkSubKey, ret); + return ret; + } + + TRACE ("RegQueryInfoKeyW returned cValues = %li, cbMaxValueNameLen = %li, " + "cbMaxValueLen = %li\n", cValues, cbMaxValueNameLen, cbMaxValueLen); + + if (cValues == 0) /* empty key */ + { + REGCLOSEKEY (hkSubKey); + *pcbEnumValues = *pnEnumValues = 0; + return ERROR_SUCCESS; + } + + ++cbMaxValueNameLen; /* allow for trailing '\0' */ + lpValueName = alloca (cbMaxValueNameLen * sizeof (WCHAR)); + if (lpValueName == NULL) + { + ERR ("Failed to allocate %li bytes on stack\n", + cbMaxValueNameLen * sizeof (WCHAR)); + REGCLOSEKEY (hkSubKey); + return ERROR_OUTOFMEMORY; + } + + hHeap = GetProcessHeap (); + if (hHeap == (HANDLE) NULL) + { + ERR ("GetProcessHeap failed\n"); + REGCLOSEKEY (hkSubKey); + return ERROR_OUTOFMEMORY; + } + + lpValue = HeapAlloc (hHeap, 0, cbMaxValueLen); + if (lpValue == NULL) + { + ERR ("Failed to allocate %li bytes from process heap\n", cbMaxValueLen); + REGCLOSEKEY (hkSubKey); + return ERROR_OUTOFMEMORY; + } + + TRACE ("pass 1: calculating buffer required for all names and values\n"); + + cbBufSize = cValues * sizeof (PRINTER_ENUM_VALUESW); + + TRACE ("%li bytes required for %li headers\n", cbBufSize, cValues); + + for (dwIndex = 0; dwIndex < cValues; ++dwIndex) + { + cbValueNameLen = cbMaxValueNameLen; cbValueLen = cbMaxValueLen; + ret = RegEnumValueW (hkSubKey, dwIndex, lpValueName, &cbValueNameLen, + NULL, NULL, lpValue, &cbValueLen); + if (ret != ERROR_SUCCESS) + { + HEAPFREE (hHeap, 0, lpValue); + REGCLOSEKEY (hkSubKey); + TRACE ("RegEnumValueW (%li) returned %li\n", dwIndex, ret); + return ret; + } + + TRACE ("%s [%li]: name needs %li bytes, data needs %li bytes\n", + debugstr_w (lpValueName), dwIndex, + (cbValueNameLen + 1) * sizeof (WCHAR), cbValueLen); + + cbBufSize += (cbValueNameLen + 1) * sizeof (WCHAR); + cbBufSize += cbValueLen; + } + + TRACE ("%li bytes required for all %li values\n", cbBufSize, cValues); + + *pcbEnumValues = cbBufSize; + *pnEnumValues = cValues; + + if (cbEnumValues < cbBufSize) /* buffer too small */ + { + HEAPFREE (hHeap, 0, lpValue); + REGCLOSEKEY (hkSubKey); + TRACE ("%li byte buffer is not large enough\n", cbEnumValues); + return ERROR_MORE_DATA; + } + + TRACE ("pass 2: copying all names and values to buffer\n"); + + ppev = (PPRINTER_ENUM_VALUESW) pEnumValues; /* array of structs */ + pEnumValues += cValues * sizeof (PRINTER_ENUM_VALUESW); + + for (dwIndex = 0; dwIndex < cValues; ++dwIndex) + { + cbValueNameLen = cbMaxValueNameLen; cbValueLen = cbMaxValueLen; + ret = RegEnumValueW (hkSubKey, dwIndex, lpValueName, &cbValueNameLen, + NULL, &dwType, lpValue, &cbValueLen); + if (ret != ERROR_SUCCESS) + { + HEAPFREE (hHeap, 0, lpValue); + REGCLOSEKEY (hkSubKey); + TRACE ("RegEnumValueW (%li) returned %li\n", dwIndex, ret); + return ret; + } + + cbValueNameLen = (cbValueNameLen + 1) * sizeof (WCHAR); + memcpy (pEnumValues, lpValueName, cbValueNameLen); + ppev[dwIndex].pValueName = (LPWSTR) pEnumValues; + pEnumValues += cbValueNameLen; + + /* return # of *bytes* (including trailing \0), not # of chars */ + ppev[dwIndex].cbValueName = cbValueNameLen; + + ppev[dwIndex].dwType = dwType; + + memcpy (pEnumValues, lpValue, cbValueLen); + ppev[dwIndex].pData = pEnumValues; + pEnumValues += cbValueLen; + + ppev[dwIndex].cbData = cbValueLen; + + TRACE ("%s [%li]: copied name (%li bytes) and data (%li bytes)\n", + debugstr_w (lpValueName), dwIndex, cbValueNameLen, cbValueLen); + } + + HEAPFREE (hHeap, 0, lpValue); + REGCLOSEKEY (hkSubKey); + return ERROR_SUCCESS; +} + +/******************************************************************************* + * EnumPrinterDataExA [WINSPOOL.196] + * + * The observant will note that this function returns ASCII strings in Unicode- + * sized buffers (for value names and values of type REG_SZ, REG_EXPAND_SZ, and + * REG_MULTI_SZ). This is what Windows 2000 does. + * + */ +DWORD WINAPI EnumPrinterDataExA(HANDLE hPrinter, LPCSTR pKeyName, + LPBYTE pEnumValues, DWORD cbEnumValues, + LPDWORD pcbEnumValues, LPDWORD pnEnumValues) +{ + INT len; + LPWSTR pKeyNameW; + DWORD ret, dwIndex, dwBufSize; + HANDLE hHeap; + LPSTR pBuffer; + + TRACE ("%08x %s\n", hPrinter, pKeyName); + + if (pKeyName == NULL || *pKeyName == 0) + return ERROR_INVALID_PARAMETER; + + len = MultiByteToWideChar (CP_ACP, 0, pKeyName, -1, NULL, 0); + + pKeyNameW = alloca (len * sizeof (WCHAR)); + if (pKeyNameW == NULL) + { + ERR ("Failed to allocate %li bytes on stack\n", + (LONG) len * sizeof (WCHAR)); + return ERROR_OUTOFMEMORY; + } + + if (MultiByteToWideChar (CP_ACP, 0, pKeyName, -1, pKeyNameW, len) == 0) + { + TRACE ("MultiByteToWide Char (%s, %i) failed with code %li\n", pKeyName, + len, GetLastError ()); + return GetLastError (); + } + + ret = EnumPrinterDataExW (hPrinter, pKeyNameW, pEnumValues, cbEnumValues, + pcbEnumValues, pnEnumValues); + if (ret != ERROR_SUCCESS) + { + TRACE ("EnumPrinterDataExW returned %li\n", ret); + return ret; + } + + if (*pnEnumValues == 0) /* empty key */ + return ERROR_SUCCESS; + + dwBufSize = 0; + for (dwIndex = 0; dwIndex < *pnEnumValues; ++dwIndex) + { + PPRINTER_ENUM_VALUESW ppev = + &((PPRINTER_ENUM_VALUESW) pEnumValues)[dwIndex]; + + if (dwBufSize < ppev->cbValueName) + dwBufSize = ppev->cbValueName; + + if (dwBufSize < ppev->cbData && (ppev->dwType == REG_SZ || + ppev->dwType == REG_EXPAND_SZ || ppev->dwType == REG_MULTI_SZ)) + dwBufSize = ppev->cbData; + } + + TRACE ("Largest Unicode name or value is %li bytes\n", dwBufSize); + + hHeap = GetProcessHeap (); + if (hHeap == (HANDLE) NULL) + { + ERR ("GetProcessHeap failed\n"); + return ERROR_OUTOFMEMORY; + } + + pBuffer = HeapAlloc (hHeap, 0, dwBufSize); + if (pBuffer == NULL) + { + ERR ("Failed to allocate %li bytes from process heap\n", dwBufSize); + return ERROR_OUTOFMEMORY; + } + + for (dwIndex = 0; dwIndex < *pnEnumValues; ++dwIndex) + { + PPRINTER_ENUM_VALUESW ppev = + &((PPRINTER_ENUM_VALUESW) pEnumValues)[dwIndex]; + + len = WideCharToMultiByte (CP_ACP, 0, ppev->pValueName, + ppev->cbValueName / sizeof (WCHAR), pBuffer, dwBufSize, NULL, + NULL); + if (len == 0) + { + HEAPFREE (hHeap, 0, pBuffer); + TRACE ("WideCharToMultiByte (%s, %li) failed with code %li\n", + debugstr_w (ppev->pValueName), dwBufSize, GetLastError ()); + return GetLastError (); + } + + memcpy (ppev->pValueName, pBuffer, len); + + TRACE ("Converted '%s' from Unicode to ASCII\n", pBuffer); + + if (ppev->dwType != REG_SZ && ppev->dwType != REG_EXPAND_SZ && + ppev->dwType != REG_MULTI_SZ) + continue; + + len = WideCharToMultiByte (CP_ACP, 0, (LPWSTR) ppev->pData, + ppev->cbData / sizeof (WCHAR), pBuffer, dwBufSize, NULL, NULL); + if (len == 0) + { + HEAPFREE (hHeap, 0, pBuffer); + TRACE ("WideCharToMultiByte (%s, %li) failed with code %li\n", + debugstr_w ((LPWSTR) ppev->pData), dwBufSize, + GetLastError ()); + TRACE (" (only first string of REG_MULTI_SZ printed)\n"); + return GetLastError (); + } + + memcpy (ppev->pData, pBuffer, len); + + TRACE ("Converted '%s' from Unicode to ASCII\n", pBuffer); + TRACE (" (only first string of REG_MULTI_SZ printed)\n"); + } + + HEAPFREE (hHeap, 0, pBuffer); + return ERROR_SUCCESS; +} + +#undef REGCLOSEKEY +#undef HEAPFREE

2 2

Re: Novell filesystem support
by gerard patel 12 Feb '01

12 Feb '01

At 12:41 PM 12/2/01 +1200, you wrote: >Hello, > >I have been making Wine support Novell Bindery calls via the >ncplib, so that I can get Pegasus mail to do mhs mail. But i've hit >the brick wall, novell file operations on a window -> unix -> novell >file system dose not work very well. <snip> What is not working in file operations ? I have my news messages with a reader working under Wine stored on a 4.10 file server since years. It's not exactly fast but I have yet to lose data. Gerard

1 0

Re: No implementation for shlwapi.dll.0(StrRetToBufA)
by gerard patel 11 Feb '01

11 Feb '01

At 01:11 AM 11/2/01 -0800, you wrote: > But I'm not behind a modem. I'm behind a DSL so the above really >doesn't matter much. > I know I could just as well use my ISP's mail server and maybe I'll >change my configuration one day. But it seems to me that the MAPS DUL is >treating innocent users as criminals, especially when they say "and use >the equipment you're authorized to use." This means in their eyes I'm >not allowed to connect to anyone's mail server myself since they are not >part of the 'equipment I'm allowed to use'. I see this as an undue >restriction of my freedom and this is what I think is wrong with >MAPS DUL. They are allowing only regular mail servers. What's so surprising or immoral here ? Allowing others the right to use your property is not an all or nothing proposition; as an (hypothetical) example, I can refuse in general the right to people to use a way on my land, but allow an association to organize a walking at a specified date. That Mr X travels on my property as a member of this association does not give him the right to come any way and any times he chooses. > I'm more favorable to other forms of Spam prevention like MAPS RSS >and ORBS. At least in these cases the servers being blocked are at a >minimum guilty of negligence (by being open relays). > In contrast, people using MAPS DUL are discriminating against >individuals just because some might be spammers (they don't even claim >there is a larger proportion of spammers among them). What if a big >chain store refused to let you in because some statistics says you >belong to a population group with a higher percentage of shop-lifters. >'But of course, feel free to shop on the web, it's more convenient >anyway'. It's discrimination just the same and, IMO, the wrong way to >tackle the problem. I had just last week a real-life experience with this kind of setup: >Received: from unknown-fn4p2i6 ([192.76.183.3]) > by mail1.asi.fr (8.11.0/8.11.0) with SMTP id f1AKZmN32007 (...) >Message-Id: <200102102035.f1AKZmN32007(a)mail1.asi.fr> (...) >Subject: CAN YOU ADVERTISE TO OVER 20 MILLION E-MAIL ADDRESSES? I won't give you the detail on how to use a Paypal account after which I would (eventually) get a Web address to download the evil stuff ;-). Very probably a complete crook. As you see, I get this interesting proposal from an IP address (192.76.183.3) that is not responding to a nslookup query. So I guess it's probably a rogue mail server on ADSL. Now, I have sent a mail to abuse(a)verio.com, but I am not sure it will do much good : this guy has probably registered under a false name and with a stolen credit card, so after he get kicked out by verio (if it happens at all...) he will just get another IP address from another ISP (or the same) and get back at its game. IMHO the main problem is that this kind of mail server is almost anonymous. Not as much as with relay mail, but my ISP takes care of that. If there was a regular Internet domain for the mail server, there would be *some* serious business information and as such some responsability. Gerard

3 2

Current Directory Strangely Affects Behaviour of Applications
by Alan Chandler 11 Feb '01

11 Feb '01

I am trying to debug a game called Grand Prix Legends, running on wine with the transgaming patch. If just spent all day getting nowhere in winedbg because I couldn't get hold of what the game was doing. If I cd to the directory in which the game is installed (ie ~/win/sierra/gpl) and then run wine gpl.exe The program starts and fills the whole of my screen with a single black window. It sits there until I move the mouse, at which time it exits. I have just discovered that if I cd to the root of my c: drive (ie ~/win) and then run wine c:\\sierra\\gpl\\gpl.exe The program starts and I get a 640x480 window with the correct startup screen (I have "Desktop" = "640x480" in my config file). It is NOT managed (even though I have "Managed" = "Y" in my config file). However the program appears to partially work - in that a) The program responds to the mouse when I click on the correct parts of the screen, b) It runs a race with computer AI cars when I tell it too. Can anyone suggest why this subtle change might exist? [As an aside, the colours seem to be the negative of what they should be - but it could just be a completely wrong pallette, the program should respond to the keyboard, but all keys affect the underlying console window in which the game was started, and there is a multiplayer option where it should (at least) detect that I have a TCP/IP connection, but doesn't - can anyone say, are these known limitations of the transgaming patch?] Lastly, is the transgaming patch likely to be folded into the up to date CVS versions of wine anytime soon. Alan alan(a)chandlerfamily.org.uk http://www.chandler.u-net.com

2 3

Re: No implementation for shlwapi.dll.0(StrRetToBufA)
by gerard patel 11 Feb '01

11 Feb '01

At 02:36 PM 11/2/01 +0100, you (I) wrote: >I had just last week a real-life experience with this kind of setup: > <snip> Err, I was wrong, it was probably not an ADSL user, but I don't think it affects the issue : too many mail servers with no control is not good (not until they pay me for the right to spam me :-)) Btw, I wonder if the wine-devel list is not used as a spam resource; since I changed my ISP (6 weeks ago) I only posted my mail address on this list (on cemw or for web surfing I used my old address) and I got the same awful stuff as before only 4 days after my old mail box expired :-/// I remember also (a long time ago) a spam with CC'ed the whole wine-devel subscriber list I think :-) Gerard

1 0

Re: No implementation for shlwapi.dll.0(StrRetToBufA) (fixed)
by David D. Hagood 11 Feb '01

11 Feb '01

I hadn't tried setting an explicit override for shlwapi in the DLLoverrides. Silly me, it never occurred to me that I could ADD MY OWN DLLs. However, I noticed that shlwapi is not in the default configuration for Wine. Perhaps somebody who isn't an Anonymous Coward as far as the CVS server goes should add it? To Francois: thanks for the quick turn-around. Kinda late over there, isn't it?

1 0

No implementation for shlwapi.dll.0(StrRetToBufA)
by David D. Hagood 10 Feb '01

10 Feb '01

I've tried to install several programs under Wine (the most recent being Delorme's AAA MapNGo V6.0) and I consistently get this error: err:win32:fixup_imports No implementation for shlwapi.dll.0(StrRetToBufA) imported from shell32.dll, setting to 0xdeadbeef err:win32:fixup_imports No implementation for shlwapi.dll.0(StrRetToBufW) imported from shell32.dll, setting to 0xdeadbeef Always followed by the app calling StrRetToBufW and dying. It looks to me like this function does exist in the code. I've tried forcing my system to use the native DLL, to use the Wine DLL, to no avail. Any pointers on where to go from here? fixme:pthread_kill_other_threads_np err:win32:fixup_imports No implementation for shlwapi.dll.0(StrRetToBufA) imported from shell32.dll, setting to 0xdeadbeef err:win32:fixup_imports No implementation for shlwapi.dll.0(StrRetToBufW) imported from shell32.dll, setting to 0xdeadbeef fixme:pthread_kill_other_threads_np Console: Making console complex (creating an xterm)... fixme:pthread_kill_other_threads_np fixme:pthread_kill_other_threads_np fixme:pthread_kill_other_threads_np fixme:pthread_kill_other_threads_np Warning: locale not supported by C library, locale unchanged

2 2

Re: Benchmark hell...
by Iris Fischer 09 Feb '01

09 Feb '01

Hi there, I found your benchmark... it wasn´t exactly what I was looking for, but do you maybe have an idea on how I can find information about the demand for wine in Canada, or North America on the internet? I´m writing my thesis on importing german wine to Canada and need to go over the demand part too of course. Would be great if you could help me. You can contact me at fischer_iris(a)hotmail.com Thanks a lot, sincerely IRIS FISCHER

6 6

LDT
by Sandie 08 Feb '01

08 Feb '01

Hello i'm french (so i may make some mistakes) I m interested in wine but it is not the main goal of my mail, I would like to know how to change the ldt under linux,because I heard that wine uses this function to run windows program,so if someone Can explain me how to change it or just tell where to get doc it would be nice! Thank you for your help! Please answer me at nicoobzz(a)free.fr

3 2

Problem with Pager control
by Guy L. Albertelli 07 Feb '01

07 Feb '01

While working on ComboEx with the 1/29/2001 CVS, IE4 no longer displays its menu bar. (Well, not really a menu bar, it is a Rebar with a Pager as the child and a Toolbar as a child of the Pager. The Toolbar buttons are the "menu" items.) If I revert the Pager code to the 12/29/2000 version (very limited functionality) then the "menu" appears and is usable. If you need traces, I can provide them. This is with preinstalled copy of IE4. Thanks, Guy Albertelli <<galberte(a)neo.lrun.com>>

2 1

RE: Reverse engineering court decision
by Patrik Stridvall 07 Feb '01

07 Feb '01

> Patrik Stridvall wrote: > > > > > One intresting aspect concerning Wine is the > > DRM (Digital Rights Management) that Slashdot > > reported that Microsoft are going to add to Windows. > > > > If we implement it is Wine we are not trying to circumvent > > it quite the opposite we are trying to to make it possible > > enforce it. ;-) > > > > Of course a one line patch making a critical function > > always return TRUE or something might be able to disable > > it for people that don't like it. :-) > > DO IT! I think we currently have other more important thing to do for Wine 1.0. > What are they going to say, that because you can > change the code > that you are aiding in circumventing copyright protection. It is actually much more intresting than that. Let for arguments sake say that we do it they sue us and the courts rule that it is legal. In that case if the full implementation is legal what about a partial implementation or a buggy implementation? If we have a function CheckIfAllowed that are implemented as FIXME("stub"); return TRUE will it make it a circumvention device. What if CheckIfAllowed is incorrectly used (intentally or by misstake) making things that are not authorized possible? What if we have a full implementation and somebody distributes a one line patch that disable any protection Is that patch a circumvention device? What if somebody says on the mailing list that if you make CheckIfAllowed return TRUE it will disable the protected. Is that _sentence_ a circumvention device? What somebody says that it is really easy to disable just look in the source code? Is that _sentence_ a circumvention device? What if somebody writes a perl script that takes parts of the Wine code and generates and compiles a tools useful for circumvention. Is that perl script a circumvention device? The point that I'm trying to make is that if any program that does Digital Rights Managagement is legal as open source it is without any problem possible make a device that circumvents these rights. This is the logical problem with DMCA unless it is totally draconian, ie everything even remotely related is forbidden, it is almost useless since even with a arbitrary line somewhere you can use whatever is legal and step by step, using steps that are themselves legal transform it to something that are on the other side of the arbitrary line. If law was mathematics this would be sufficient proof that DMCA is logical inconsistant since it would mean that some actions were both legal and illegal. In short no arbitrary line is possible either everything even remotely related is illegal or nothing is illegal. > If they go after > you then you know for sure that they have the poorest of intentions. Well, we already know that their only intention is more profit, so this will not really help us derive anything new.

3 2

Re: debugger fix
by Ulrich Weigand 07 Feb '01

07 Feb '01

I wrote: > Eric Pouech wrote: > > > > Could you send me the libwinspool.drv.so file that objcopy > > > is choking on? I'd like to look whether there's something > > > strange with that. > > here it is... (I've used libpsapi.so instead, because it's smaller, but > > effects are the same) > > Well, one difference I see is that yours has a .rel.stabs section, > while mine doesn't. Now I don't quite understand why stabs need > to be relocated, but I guess this could be a source of confusion. > In any case, after I strip the stabs data using objcopy --strip-debug, > I can subsequently use objcopy -N without problems. > > The problem might be caused by the objcopy -L step not correctly > updating the debug info. Could you try adding a --debugging > argument to objcopy in both localize_imports and strip_imports? No, it's definitely a problem with the .rel.stabs section. In fact, *every* invocation of objcopy that leaves the .rel.stabs section in its output fails -- even a simple identical copy. (Note that if you *remove* the .rel.stabs section, it works -- this is why a normal 'strip' works ...) The reason for this is that objcopy relies on the bfd library to assign the file offsets of the sections in the output file. Unfortunately, the automatic assignment is done only for sections that are part of a segment (i.e. loaded into memory), and also for *those* sections outside of segments that are *not* reloc sections ... For reloc sections outside of segments, like the .rel.stabs section, no automatic file offset assignment is performed. Instead, the upper layers must do this themselves, which e.g. the linker does in its final_link step. The objcopy tool, however, never does. This leads to an invalid file offset being used when writing out the .rel.stabs section, which causes the abort. As a side note: I've tried using the --debugging argument, which basically recreates the debug sections from scratch instead of copying them, and this fails completely with my toolchain -- it runs into an endless loop. The reason for this is apparently a compiler bug in gcc 2.95.2 that miscompiles a routine from objcopy by converting a recursive function call into tail recursion in an invalid way ... I still don't understand why your toolchain creates a .rel.stabs section in the first place. Could you check at which point this is created first (as, ld, ld -shared)? Bye, Ulrich -- Dr. Ulrich Weigand weigand(a)informatik.uni-erlangen.de

2 4

RE: Reverse engineering court decision
by Patrik Stridvall 06 Feb '01

06 Feb '01

> Patrik, that was probably one of the most well-written > arguments I have > heard against the DMCA. Thank you, my immidiate reaction when proof reading it was that it was not entirely clear but I didn't feel I had time to improve it more. The arguement is not really water tight it assumes that you legally can reverse engineer, implement and publish an existing Digital Rights Managagement scheme. All of this is possible because of the duality between the rights management and circumvention. Any attempt to partition the set of devices in two parts will fail since you mathematically will be able to prove that they are equal and thus the arbitrary line chosen in the beginning doesn't really exist. However note that there are three solutions to the problem. 1. The DMCA protects nothing and are totally meaningless. 2. The DMCA are logically inconsistant and thereby null and void. 3. The DMCA will forbid digital rights management without authorization as well. The only thing that can save you is if you can pry a crack in it somewhere by find some kind of allowed digital rights management or circumvention because of some other reason, like constitional issues. If you even have one crack, then only possible case is 1, because of the reason given above. Note that 3 would mean that making an exact copy of some a device will be illegal if it contained any kind of digital right mangagement, thereby granting it a perpetual patent protection if it was hardware alternativly perpetual copyright protection if it was software. This kind of argument are not really new, however the arguments I have seen used it when talking about protected works. I'm talking about _devices_ that are authorized to "play" such works. Not being an expert on constitional issues I will say nothing more than that I think it would be unlikely that it is not so. > Too bad probably only Wine > developers will see it. I don't think it would be a useful argument to use in court it is much to abstract for normal Judges to understand. Better stick to constitional issue I think. > Ever thought of becoming a lawyer? ;-) No, I hate lawyers. :-) BTW, concerning reverse engineering any law against reverse engineering will have similar logical problems as DMCA since if some things are legal to reverse engineer it will be possible to using a similar step by step method transform this to something of the other side of any arbitrary line. Fortunately no such law exists AFAIK.

1 0

RE: Reverse engineering court decision
by Patrik Stridvall 06 Feb '01

06 Feb '01

> On Tue, 6 Feb 2001, Patrik Stridvall wrote: > > > > Patrik, > > > > > > You are most likely correct. Eventually the court system > > > will get their > > > head out of their ass and figure this out. > > > > I hope so. > > There's optimism for you - they've had their heads there for > years, why > change now? They're just getting comfortable... What do you mean? Who are getting comfortable? The courts? > > > At the moment it > > > seems to me > > > like its way up in there and they are going "Damn, it's > dark in here". > > > > Well, since the DMCA IMHO is logically inconsistant, that > is not very > > suprising. I interpret Judge Kaplan opinion in the DeCSS as "I don't > > really understand this, but if I blame it on Congress and give the > > plaintiff the victory I will probably look less a fool in > the eyes of > > my peers". > > Perhaps. Some of the Slashdot comments on the matter won't > have helped, > though... With peers I was refering to fellow and especially superior court Judges not just anybody that criticized him. What Judge Kaplan basicly said was this is, judging from the letter of the law, what Congress meant and if if they didn't mean this, they should have put it more clearly and if so it is their fault not mine. Shifting blame is quite popular in all sectors of society. :-) > > > Even my dad could easily see the argument that > > > restricting someone from writing a program is really > really braindead > > > (although he has done coding way back in the day). His > > > response was that > > > eventually the court system will figure it out and it'll be > > > over and done > > > with. Seems to be much the same as your response. > > > > Yes, approximately, but don't forget that in the worst case laws can > > be changed and in the meantime enforcing it will be close to > > impossible. > > Indeed. It'll probably survive for a while, but with more and > more holes > being cut... More holes? It is already has holes big as barn doors. :-) One intresting aspect concerning Wine is the DRM (Digital Rights Management) that Slashdot reported that Microsoft are going to add to Windows. If we implement it is Wine we are not trying to circumvent it quite the opposite we are trying to to make it possible enforce it. ;-) Of course a one line patch making a critical function always return TRUE or something might be able to disable it for people that don't like it. :-)

2 1

Re: psdrv: map Courier New to Courier
by Ian Pilcher 06 Feb '01

06 Feb '01

Huw D M Davies wrote: > > Great! Well the Windows 2000 PS driver stores the font sub table > under the value name "TTFontSubTable" in the printer driver's > PrinterDriverData registry key. To do this we need to implement > Get/SetPrinterData (if you give me a couple of days I'll do it). The > data associated with TTFontSubTable is just a set of 2n \0 > terminated strings the final one terminated by 2 \0 > (i.e. REG_MULTISZ). The actual configuring should go on in the > printer setup property sheet. Hmmm, fancy learning a little of the > Win32 api? > I just spent some time poking around in the Registry of my Windows 2000 system. Neither "TTFontSubTable" or "FontSubTable" appears anywhere. (I have printers installed that use both the Adobe and Microsoft Post- Script drivers.) In fact, when I searched on "Helvetica" the only things I found that looked like font substitution tables were under HKCU\Software\Microsoft\ Shared Tools\Font Mapping and HKLM\SOFTWARE\Microsoft\Windows NT\ CurrentVersion\FontSubstitutes. Another point of interest -- none of the printer properties dialogs seem to allow me to configure the font substitution, even though I have "TrueType Font: Substitute with Device Font" set in the Advanced Options of the Apple LaserWriter 12/640 PS driver. > > OK, I've just submitted G|SetPrinterData implementations to > wine-patches - please use these instead of direct Reg apis. (it should > make life easier anyway. > > You basically want > > HANDLE hprn; > OpenPrinterA("Wine PostScript Driver", &hprn, NULL); > SetPrinterDataA(hprn, "FontSubTable" /*or whatever*/, REG_MULTI_SZ, pData, size); > ClosePrinter(hprn); > > where pData is a list of \0 terminated strings that make up the table, > finally terminated by a double \0. > > Reading the data back is almost the same using GetPrinterDataA So is "FontSubTable" what we want to use? It should be easy enough for me to have the driver use GetPrinterData and set up a simple array when it is initialized. (Although it does seem a little weird to have the driver calling OpenPrinter; is this OK?) > > I think we should also allow the Wine config file to override what's > > in the registry. > > Not really convinced about this. I'd like to move all of the psdrv > stuff out of the config file (which afterall is just a bit of the > registry) into its correct place under > HKLM\System\CurrentControlSet\Control\Printers\Print > The configuration should all be done via a GUI control. Two points: 1) How can a user get this information into the Registry until the GUI control is written? (I hope you weren't thinking that this is some- think I'm capable of doing. Me stupid procedural guy; OO GUI stuff make head feel oogey!) 2) Just because people use Wine to run Windows applications, doesn't mean that they've bought into the "everything should be GUI" philosophy; some of us actually *like* ASCII configuration files. > > In the old style, I would have suggested something of the form: > > > > Windows Font = X LFD, PostScript font name > > > > This would seem to be relatively straightforward to implement, and it > > would bring a small measure of sanity to the area. (I currently have > > both 'MS Sans Serif' and 'Ms Sans Serif' fonts, because the X server and > > the PostScript driver don't agree on what the font should be called!) > > This should all be a lot easier when I get a FreeType engine bolted on > to gdi. Then psdrv,x11drv,ttydrv(?) will all have access to the same > data and thus consistancy should not be a problem. I actually see a manual font configuration as a *very* small step in this direction. At least it will let Wine control it's view of what fonts are available, rather than trying to make intelligent guesses based on the X font list and the PostScript driver. It does assume a certain intelligence on the user's part; mapping the core Windows fonts to X fonts that aren't installed on the system would be "bad", but it shouldn't be too hard to supply a reasonable default configuration. -- ======================================================================== Ian Pilcher pilcher(a)concentric.net ========================================================================

2 4

RE: Misc / Unicode
by Patrik Stridvall 06 Feb '01

06 Feb '01

> > I know this comes from from someone who just forgot to put > a trailing > > '\0'. But still. > > Sounds like a job for winapi_check ;-) Yes. However it will not be so easy since winapi_check doesn't have a complete C parser. It currently skips these kind of lines, so don't hold your breath. > BTW, Is Alexandre away? I should guess so. > I haven't seen any cvs commits for a week... Neither have I.

1 0

Re: Misc / Unicode
by Dmitry Timoshkov 06 Feb '01

06 Feb '01

"Francois Gouget" <fgouget(a)free.fr> wrote: > <rant> > I checked the other cases and I have this question. Why does everyone > use 0 instead of '\0', 0 instead of FALSE, and '\0' instead of NULL? MS > even does the reverse and uses NULL in places where '\0' or 0 would have > been more appropriate. Man, if you know what you're doing prove it and > use the appropriate form: either 0, '\0' or NULL. > I know this comes from from someone who just forgot to put a trailing > '\0'. But still. > </rant> IMO it doesn't matter in the most cases, if you do not mix pointer data type (NULL) and others. '\0' == 0, and even better to use 0, because it automatically get casted by the compiler to the appropriate data type.

1 0

Re: Misc / Unicode
by Jon Griffiths 06 Feb '01

06 Feb '01

> I know this comes from from someone who just forgot to put a trailing > '\0'. But still. Sounds like a job for winapi_check ;-) BTW, Is Alexandre away? I haven't seen any cvs commits for a week... Jon -- "Don't wait for the seas to part, or messiahs to come, Dont you sit around and waste this chance ..." -Live tntjpgriff(a)tsnxt.co.uk , jon_p_griffiths(a)yahoo.com

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel