wine-devel

wine-devel@winehq.org

84463 discussions

Re: [PATCH v2 0/3] MR310: mf: Fix several reference leaks.
by Nikolay Sivov (＠nsivov) 27 Jun '22

27 Jun '22

On Mon Jun 27 07:57:50 2022 +0000, Rémi Bernon wrote: > I think the test failure may come from a missing the > `video_renderer_release_presenter_services` call, though I haven't > really investigated that aspect of the problem. If it's the case, > perhaps it should be added to `video_renderer_initialize` too. > The issue with the testbot and 32bit apps is that the way `Initialize` > is currently written it create a second video renderer before releasing > the previously created one. This requires another d3d device > initialization, which often fails from address space exhaustion, so > releasing the previous renderer first was resolving the issue (and the > reference leak also probably made it worse). Ok, that's probably fine then. This release should happen only in "!`EVR_SHUT_DOWN`" branch, it's fine to move releasing part of `video_renderer_initialize` right there, because it's not going to be used outside of `Initialize()`. Having another helper _uninitialize() is also an option to keep method body easier to read. Note that with current patch you have returns while holding a lock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/310#note_2756

1 0

[PATCH 0/5] MR321: win32u: menu conversion
by Jacek Caban (＠jacek) 27 Jun '22

27 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/321

2 5

Re: [PATCH v3 0/1] MR306: reg: Add REG_QWORD support to 'add'. - approved
by Hugh McMaster (＠hmc) 27 Jun '22

27 Jun '22

This merge request was approved by Hugh McMaster. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/306

1 0

[PATCH 0/1] MR320: riched20/tests: Test for ITextDocument::Undo and ITextDocument::Redo.
by Jinoh Kang (＠iamahuman) 27 Jun '22

27 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/320

2 1

Re: [PATCH v2 0/3] MR310: mf: Fix several reference leaks.
by Rémi Bernon (＠rbernon) 27 Jun '22

27 Jun '22

On Mon Jun 27 07:52:49 2022 +0000, Nikolay Sivov wrote: > This is already done in video_renderer_initialize(). Maybe it's not > triggered on shutdown? I think the test failure may come from a missing the `video_renderer_release_presenter_services` call, though I haven't really investigated that aspect of the problem. If it's the case, perhaps it should be added to `video_renderer_initialize` too. The issue with the testbot and 32bit apps is that the way `Initialize` is currently written it create a second video renderer before releasing the previously created one. This requires another d3d device initialization, which often fails from address space exhaustion, so releasing the previous renderer first was resolving the issue (and the reference leak also probably made it worse). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/310#note_2750

1 0

Re: [PATCH v2 0/3] MR310: mf: Fix several reference leaks.
by Nikolay Sivov (＠nsivov) 27 Jun '22

27 Jun '22

Nikolay Sivov (@nsivov) commented about dlls/mf/evr.c: > + renderer->mixer = NULL; > + } > + > + if (renderer->presenter) > + { > + video_renderer_release_presenter_services(renderer); > + IMFVideoPresenter_Release(renderer->presenter); > + renderer->presenter = NULL; > + } > + > + if (renderer->device_manager) > + { > + IUnknown_Release(renderer->device_manager); > + renderer->device_manager = NULL; > + } > + This is already done in video_renderer_initialize(). Maybe it's not triggered on shutdown? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/310#note_2749

1 0

[PATCH 0/17] MR319: d2d1: Initial implementation of effect properties handling
by Nikolay Sivov (＠nsivov) 27 Jun '22

27 Jun '22

-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/319

1 0

[PATCH 0/1] MR316: wbemprox: Use return length from NtQuerySystemInformationEx().
by Brendan Shanks (＠bshanks) 27 Jun '22

27 Jun '22

The return length is unlikely to change between the two NtQuerySystemInformationEx calls, but it's possible, and it's more correct to parse the entries with the length from the call where the data was returned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/316

3 2

[PATCH 0/5] MR318: light.msstyles: Add Vista+ button parts.
by Zhiyi Zhang (＠zhiyi) 27 Jun '22

27 Jun '22

These theme parts are queried by Qt5 applications. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/318

2 5

[PATCH 0/6] MR317: uxtheme/tests: Test that DrawThemeBackgroundEx() is at ordinal 47.
by Zhiyi Zhang (＠zhiyi) 27 Jun '22

27 Jun '22

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/317

2 6

[PATCH 0/6] MR265: kernelbase: Implement PrefetchVirtualMemory.
by Jinoh Kang (＠iamahuman) 26 Jun '22

26 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/265

3 9

[PATCH v5 0/1] MR296: nsiproxy.sys: Add static ARP entries which are always present on Windows.
by Paul Gofman (＠gofman) 26 Jun '22

26 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53175 Split off from MR https://gitlab.winehq.org/wine/wine/-/merge_requests/286. -- v5: nsiproxy.sys: Add static ARP entries which are always present on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/296

3 3

[PATCH v4 0/9] MR272: d3dx10: Add D3DX10CreateThreadPump implementation.
by Piotr Caban (＠piotr) 26 Jun '22

26 Jun '22

The GetWorkItemCount implementation may look strange. It's done this way because of how WaitForAllItems is implemented. Alternative solution is to introduce separate counter for GetWorkItemCount. -- v4: d3dx10/tests: Add D3DX10CreateThreadPump tests. d3dx10: Add ID3DX10ThreadPump:PurgeAllItems implementation. d3dx10: Add ID3DX10ThreadPump:GetQueueStatus implementation. d3dx10: Add ID3DX10ThreadPump:WaitForAllItems implementation. d3dx10: Add ID3DX10ThreadPump:ProcessDeviceWorkItems implementation. d3dx10: Add ID3DX10ThreadPump:GetWorkItemCount implementation. d3dx10: Add ID3DX10ThreadPump:AddWorkItem implementation. d3dx10: Add D3DX10CreateThreadPump stub. d3dx10/tests: Fix texture leak in check_resource_data. https://gitlab.winehq.org/wine/wine/-/merge_requests/272

2 9

[PATCH 0/2] MR314: ntdll/tests: Preserve EFLAGS across syscall on x64.
by Jinoh Kang (＠iamahuman) 26 Jun '22

26 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/314

2 2

[PATCH v3 0/9] MR272: d3dx10: Add D3DX10CreateThreadPump implementation.
by Piotr Caban (＠piotr) 26 Jun '22

26 Jun '22

The GetWorkItemCount implementation may look strange. It's done this way because of how WaitForAllItems is implemented. Alternative solution is to introduce separate counter for GetWorkItemCount. -- v3: d3dx10/tests: Add D3DX10CreateThreadPump tests. d3dx10: Add ID3DX10ThreadPump:PurgeAllItems implementation. d3dx10: Add ID3DX10ThreadPump:GetQueueStatus implementation. d3dx10: Add ID3DX10ThreadPump:WaitForAllItems implementation. d3dx10: Add ID3DX10ThreadPump:ProcessDeviceWorkItems implementation. d3dx10: Add ID3DX10ThreadPump:GetWorkItemCount implementation. d3dx10: Add ID3DX10ThreadPump:AddWorkItem implementation. d3dx10: Add D3DX10CreateThreadPump stub. d3dx10/tests: Fix texture leak in check_resource_data. https://gitlab.winehq.org/wine/wine/-/merge_requests/272

6 34

[PATCH v2 0/1] MR282: ntdll: Set r11 on exit from syscall dispatcher on x64.
by Jinoh Kang (＠iamahuman) 26 Jun '22

26 Jun '22

-- v2: ntdll: Set r11 on exit from syscall dispatcher on x64. https://gitlab.winehq.org/wine/wine/-/merge_requests/282

2 2

[PATCH v2 0/5] MR307: dnsapi: Fix wow64 translation.
by Zebediah Figura (＠zfigura) 26 Jun '22

26 Jun '22

-- v2: ntdll: Add some documentation for ntdll_umbstowcs() and ntdll_wcstoumbs(). dnsapi: Return a double-null-terminated string from DnsQueryConfig(DnsConfigSearchList). dnsapi: ntdll_umbstowcs() deals in characters, not bytes. dnsapi: Clarify that Windows does not implement DnsQueryConfig(DnsConfigSearchList). https://gitlab.winehq.org/wine/wine/-/merge_requests/307

4 6

[PATCH v4 0/2] MR296: nsiproxy.sys: Add static ARP entries which are always present on Windows.
by Paul Gofman (＠gofman) 25 Jun '22

25 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53175 Split off from MR https://gitlab.winehq.org/wine/wine/-/merge_requests/286. -- v4: Apply 1 suggestion(s) to 1 file(s) https://gitlab.winehq.org/wine/wine/-/merge_requests/296

4 3

[PATCH 0/5] MR242: winegstreamer: Don't try using src_getrange_cb input buffer.
by Rémi Bernon (＠rbernon) 25 Jun '22

25 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/242

3 13

[PATCH v3 0/1] MR296: nsiproxy.sys: Add static ARP entries which are always present on Windows.
by Paul Gofman (＠gofman) 25 Jun '22

25 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53175 Split off from MR https://gitlab.winehq.org/wine/wine/-/merge_requests/286. -- v3: nsiproxy.sys: Add static ARP entries which are always present on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/296

3 3

[PATCH 0/1] MR312: winex11.drv: Increment configure_serial in X11DRV_WindowPosChanged() even if...
by Paul Gofman (＠gofman) 25 Jun '22

25 Jun '22

Once we reached that place where sync_window_position() is called (or not called if window is about to be minimized or maximized) the old in-flight X_ConfigureNotify do not make sense anymore. sync_window_position() does that unconditionally but if we don't call it for minimize / maximize we should probably discard them regardless. An example of the failing scenario which this patch is fixing is the following: 1. App calls SetWindowPos() with some size, X_ConfigureNotify is in flight; 2. App calls ShowWindow(SW_MAXIMIZE), old X_ConfigureNotify is still in flight; sync_window_position() is not called and configure_serial is not updated; 3. Now X_ConfigureNotify from p.1 arrives and it gets processed like WM is changing window size back, that confuses the app and since the reaction on the new app's SetWindowPos / maximizing is also delayed and then X events triggered by p. 2. also arribe later. That may cause endless loop with non-functional window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/312

2 1

[PATCH] po: Update Dutch translation.
by Floris Renaud 24 Jun '22

24 Jun '22

Signed-off-by: Floris Renaud <jkfloris(a)dds.nl> --- po/nl.po | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/po/nl.po b/po/nl.po index bf4ff469379..8e3074e26e5 100644 --- a/po/nl.po +++ b/po/nl.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2022-04-15 18:10+0200\n" +"PO-Revision-Date: 2022-06-25 00:15+0200\n" "Last-Translator: Floris Renaud <jkfloris(a)dds.nl>\n" "Language-Team: Dutch\n" "Language: nl\n" @@ -16455,10 +16455,8 @@ msgstr "&DWORD-waarde" #: programs/regedit/regedit.rc:52 programs/regedit/regedit.rc:105 #: programs/regedit/regedit.rc:128 -#, fuzzy -#| msgid "&DWORD Value" msgid "&QWORD Value" -msgstr "&DWORD-waarde" +msgstr "&QWORD-waarde" #: programs/regedit/regedit.rc:53 programs/regedit/regedit.rc:106 #: programs/regedit/regedit.rc:129 @@ -17017,16 +17015,12 @@ msgid "Collapse" msgstr "Invouwen" #: programs/regedit/regedit.rc:178 -#, fuzzy -#| msgid "Adds a new 32-bit value" msgid "Adds a new 64-bit value" -msgstr "Een nieuwe 32-bit waarde toevoegen" +msgstr "Een nieuwe 64-bit waarde toevoegen" #: programs/regedit/regedit.rc:221 -#, fuzzy -#| msgid "Edit DWORD" msgid "Edit QWORD" -msgstr "DWORD waarde bewerken" +msgstr "QWORD waarde bewerken" #: programs/regsvr32/regsvr32.rc:33 msgid "" -- 2.36.1

1 0

[PATCH] Suppress below message, with fix mojibake for japanese filename in LANG=ja_JP.SJIS environment. "err:environ:init_unix_codepage unrecognized charset 'SJIS'"
by Yoshiji Emoto 24 Jun '22

24 Jun '22

In past I sent patch for "dlls/winex11.drv/window.c" is not needed. Cancel it please. Signed-off-by: Yoshiji Emoto <alumina.from.ceramix(a)gmail.com> --- dlls/ntdll/unix/env.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/ntdll/unix/env.c b/dlls/ntdll/unix/env.c index a71df03966f..90035f683e7 100644 --- a/dlls/ntdll/unix/env.c +++ b/dlls/ntdll/unix/env.c @@ -270,6 +270,7 @@ static const struct { const char *name; UINT cp; } charset_names[] = { "ISO88599", 28599 }, { "KOI8R", 20866 }, { "KOI8U", 21866 }, + { "SJIS", 932 }, { "TIS620", 28601 }, { "UTF8", CP_UTF8 } }; -- 2.35.2

1 0

[PATCH] po: Update Lithuanian translation.
by Aurimas Fišeras 24 Jun '22

24 Jun '22

1 0

[PATCH 0/2] MR308: Add "wine/str.h", use "wine/heap.h" and it in winemenubuilder
by Davide Beatrici (＠davidebeatrici) 24 Jun '22

24 Jun '22

I originally wanted to add these utils into `unicode.h`, but it cannot be used with msvcrt headers. This prompted the creation of a new header called `str.h`. The name is generic and broad, but the file may grow to contain more general stuff in the future. The rationale behind writing the UTF helpers is mainly to solve, at least in part, the complexity. `WideCharToMultiByte()` and `MultiByteToWideChar()` in particular are quite dangerous as they treat the buffer size as bytes for `char` (8 bits) and as number of characters for `WCHAR` (16 bits). There are already several wrappers around the codebase, mine should be able to replace them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/308

3 12

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel