wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

[PATCH v3 0/1] MR296: nsiproxy.sys: Add static ARP entries which are always present on Windows.
by Paul Gofman (＠gofman) 25 Jun '22

25 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53175 Split off from MR https://gitlab.winehq.org/wine/wine/-/merge_requests/286. -- v3: nsiproxy.sys: Add static ARP entries which are always present on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/296

3 3

[PATCH 0/1] MR312: winex11.drv: Increment configure_serial in X11DRV_WindowPosChanged() even if...
by Paul Gofman (＠gofman) 25 Jun '22

25 Jun '22

Once we reached that place where sync_window_position() is called (or not called if window is about to be minimized or maximized) the old in-flight X_ConfigureNotify do not make sense anymore. sync_window_position() does that unconditionally but if we don't call it for minimize / maximize we should probably discard them regardless. An example of the failing scenario which this patch is fixing is the following: 1. App calls SetWindowPos() with some size, X_ConfigureNotify is in flight; 2. App calls ShowWindow(SW_MAXIMIZE), old X_ConfigureNotify is still in flight; sync_window_position() is not called and configure_serial is not updated; 3. Now X_ConfigureNotify from p.1 arrives and it gets processed like WM is changing window size back, that confuses the app and since the reaction on the new app's SetWindowPos / maximizing is also delayed and then X events triggered by p. 2. also arribe later. That may cause endless loop with non-functional window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/312

2 1

[PATCH] po: Update Dutch translation.
by Floris Renaud 24 Jun '22

24 Jun '22

Signed-off-by: Floris Renaud <jkfloris(a)dds.nl> --- po/nl.po | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/po/nl.po b/po/nl.po index bf4ff469379..8e3074e26e5 100644 --- a/po/nl.po +++ b/po/nl.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2022-04-15 18:10+0200\n" +"PO-Revision-Date: 2022-06-25 00:15+0200\n" "Last-Translator: Floris Renaud <jkfloris(a)dds.nl>\n" "Language-Team: Dutch\n" "Language: nl\n" @@ -16455,10 +16455,8 @@ msgstr "&DWORD-waarde" #: programs/regedit/regedit.rc:52 programs/regedit/regedit.rc:105 #: programs/regedit/regedit.rc:128 -#, fuzzy -#| msgid "&DWORD Value" msgid "&QWORD Value" -msgstr "&DWORD-waarde" +msgstr "&QWORD-waarde" #: programs/regedit/regedit.rc:53 programs/regedit/regedit.rc:106 #: programs/regedit/regedit.rc:129 @@ -17017,16 +17015,12 @@ msgid "Collapse" msgstr "Invouwen" #: programs/regedit/regedit.rc:178 -#, fuzzy -#| msgid "Adds a new 32-bit value" msgid "Adds a new 64-bit value" -msgstr "Een nieuwe 32-bit waarde toevoegen" +msgstr "Een nieuwe 64-bit waarde toevoegen" #: programs/regedit/regedit.rc:221 -#, fuzzy -#| msgid "Edit DWORD" msgid "Edit QWORD" -msgstr "DWORD waarde bewerken" +msgstr "QWORD waarde bewerken" #: programs/regsvr32/regsvr32.rc:33 msgid "" -- 2.36.1

1 0

[PATCH] Suppress below message, with fix mojibake for japanese filename in LANG=ja_JP.SJIS environment. "err:environ:init_unix_codepage unrecognized charset 'SJIS'"
by Yoshiji Emoto 24 Jun '22

24 Jun '22

In past I sent patch for "dlls/winex11.drv/window.c" is not needed. Cancel it please. Signed-off-by: Yoshiji Emoto <alumina.from.ceramix(a)gmail.com> --- dlls/ntdll/unix/env.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/ntdll/unix/env.c b/dlls/ntdll/unix/env.c index a71df03966f..90035f683e7 100644 --- a/dlls/ntdll/unix/env.c +++ b/dlls/ntdll/unix/env.c @@ -270,6 +270,7 @@ static const struct { const char *name; UINT cp; } charset_names[] = { "ISO88599", 28599 }, { "KOI8R", 20866 }, { "KOI8U", 21866 }, + { "SJIS", 932 }, { "TIS620", 28601 }, { "UTF8", CP_UTF8 } }; -- 2.35.2

1 0

[PATCH] po: Update Lithuanian translation.
by Aurimas Fišeras 24 Jun '22

24 Jun '22

1 0

[PATCH 0/2] MR308: Add "wine/str.h", use "wine/heap.h" and it in winemenubuilder
by Davide Beatrici (＠davidebeatrici) 24 Jun '22

24 Jun '22

I originally wanted to add these utils into `unicode.h`, but it cannot be used with msvcrt headers. This prompted the creation of a new header called `str.h`. The name is generic and broad, but the file may grow to contain more general stuff in the future. The rationale behind writing the UTF helpers is mainly to solve, at least in part, the complexity. `WideCharToMultiByte()` and `MultiByteToWideChar()` in particular are quite dangerous as they treat the buffer size as bytes for `char` (8 bits) and as number of characters for `WCHAR` (16 bits). There are already several wrappers around the codebase, mine should be able to replace them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/308

3 12

Re: [PATCH v4 0/1] MR303: win32u: Don't report cloned monitors in EnumDisplayMonitors(). - approved
by Alexandre Julliard (＠julliard) 24 Jun '22

24 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/303

1 0

Re: [PATCH v2 0/1] MR309: wow64: Report the correct size for SystemLogicalProcessorInformationEx. - approved
by Alexandre Julliard (＠julliard) 24 Jun '22

24 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/309

1 0

Re: [PATCH v2 0/1] MR293: winedbg: Clarify options specific to GDB proxy mode. - approved
by Alexandre Julliard (＠julliard) 24 Jun '22

24 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/293

1 0

Re: [PATCH v2 0/3] MR311: win32u: menu conversion - approved
by Alexandre Julliard (＠julliard) 24 Jun '22

24 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/311

1 0

Re: [PATCH v2 0/1] MR304: mshtml: Enable CSS grid layout. - approved
by Alexandre Julliard (＠julliard) 24 Jun '22

24 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/304

1 0

Re: [PATCH v3 0/4] MR271: win32u: Move rawinput APIs. - approved
by Alexandre Julliard (＠julliard) 24 Jun '22

24 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/271

1 0

Re: [PATCH v5 0/5] MR255: d3d11: Fix reporting of some format caps. - approved
by Alexandre Julliard (＠julliard) 24 Jun '22

24 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/255

1 0

[PATCH 0/5] MR307: dnsapi: Fix wow64 translation.
by Zebediah Figura (＠zfigura) 24 Jun '22

24 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/307

5 9

[PATCH v3 0/1] MR303: win32u: Don't report cloned monitors in EnumDisplayMonitors().
by Arek Hiler (＠ivyl) 24 Jun '22

24 Jun '22

Based on: ca39b1c22dfa ("user32: Don't report mirrored slave monitors in EnumDisplayMonitors.") 2affb854e524 ("user32: Change slave to a more neutral word.") Which seems to got lost during: 318673405c62 ("win32u: Move NtUserEnumDisplayMonitors implementation from user32.") Fixes regression with Elite Dangerous launcher freezing when cloned displays are present. Signed-off-by: Arkadiusz Hiler <ahiler(a)codeweavers.com> CC: @zhiyi @jacek -- v3: win32u: Don't report cloned monitors in EnumDisplayMonitors(). https://gitlab.winehq.org/wine/wine/-/merge_requests/303

4 3

[tools] testbot/web: The task failures list is read-only.
by Francois Gouget 24 Jun '22

24 Jun '22

Manually adding and removing task failures is not supported. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/web/FailureDetails.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/web/FailureDetails.pl b/testbot/web/FailureDetails.pl index f39af5ac91..ae4ccb4041 100644 --- a/testbot/web/FailureDetails.pl +++ b/testbot/web/FailureDetails.pl @@ -167,7 +167,7 @@ sub GenerateBody($) { print "<h2><a name='TaskFailures'></a>Task Failures</h2>\n"; my $TaskFailuresBlock = new TaskFailuresBlock($self->{Item}->TaskFailures, $self); - $TaskFailuresBlock->SetReadWrite(0) if (!$self->{RW}); + $TaskFailuresBlock->SetReadWrite(0); $TaskFailuresBlock->GenerateList(); } } -- 2.30.2

1 0

[tools] testbot/UpdateFailures: Truncate the bug status and description if needed.
by Francois Gouget 24 Jun '22

24 Jun '22

They have to fit otherwise Failure::Validate() will prevent saving to the database. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/bin/UpdateFailures.pl | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/testbot/bin/UpdateFailures.pl b/testbot/bin/UpdateFailures.pl index 7c89b7b99b..f324cca280 100755 --- a/testbot/bin/UpdateFailures.pl +++ b/testbot/bin/UpdateFailures.pl @@ -157,6 +157,7 @@ foreach my $FailureId (@FailureIds) # Update the failures bug information my $Bugs = CollectBugInfo([keys %$BugIds]); +my ($MaxStatusLen, $MaxDescriptionLen); foreach my $FailureId (@FailureIds) { my $Failure = $Failures->GetItem($FailureId); @@ -167,9 +168,19 @@ foreach my $FailureId (@FailureIds) { my $Resolution = $Bug->{Resolution} || " ---"; $Resolution = $Resolution eq " ---" ? "" : " $Resolution"; - $Failure->BugStatus("$Bug->{Status}$Resolution"); + if (!defined $MaxStatusLen) + { + my $PropertyDescriptor = $Failure->GetPropertyDescriptorByName("BugStatus"); + $MaxStatusLen = $PropertyDescriptor->GetMaxLength(); + } + $Failure->BugStatus(substr("$Bug->{Status}$Resolution", 0, $MaxStatusLen)); + } + if (!defined $MaxDescriptionLen) + { + my $PropertyDescriptor = $Failure->GetPropertyDescriptorByName("BugDescription"); + $MaxDescriptionLen = $PropertyDescriptor->GetMaxLength(); } - $Failure->BugDescription($Bug->{Description}); + $Failure->BugDescription(substr($Bug->{Description}, 0, $MaxDescriptionLen)); } else { -- 2.30.2

1 0

[tools] testbot: Sort failures on their notes as a last resort.
by Francois Gouget 24 Jun '22

24 Jun '22

Sometimes a bug is spread across multiple failures and the Notes field normally describes what each one corresponds to. Sorting on the Notes field as a last resort typically ensures that all the parts are in an order that makes sense. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/WineTestBot/Failures.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/testbot/lib/WineTestBot/Failures.pm b/testbot/lib/WineTestBot/Failures.pm index 21b1610ca9..4a65374988 100644 --- a/testbot/lib/WineTestBot/Failures.pm +++ b/testbot/lib/WineTestBot/Failures.pm @@ -50,11 +50,11 @@ sub Compare($$) # Sort deleted entries last my %StatusOrders = ("deleted" => 1); - my $Cmp = ($StatusOrders{$self->GetColValue("BugStatus")} || 0) <=> ($StatusOrders{$B->GetColValue("BugStatus")} || 0) || + return ($StatusOrders{$self->GetColValue("BugStatus")} || 0) <=> ($StatusOrders{$B->GetColValue("BugStatus")} || 0) || $self->GetColValue("ErrorGroup") cmp $B->GetColValue("ErrorGroup") || $self->GetColValue("TestUnit") cmp $B->GetColValue("TestUnit") || - $self->GetColValue("BugDescription") cmp $B->GetColValue("BugDescription"); - return $Cmp + $self->GetColValue("BugDescription") cmp $B->GetColValue("BugDescription") || + $self->GetColValue("Notes") cmp $B->GetColValue("Notes"); } sub BugId($;$) -- 2.30.2

1 0

[tools] testbot: Treat regular expression warnings as errors.
by Francois Gouget 24 Jun '22

24 Jun '22

In particular do so when validating failures so errors are caught when the failure is created / modified. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/lib/WineTestBot/Failures.pm | 1 + testbot/lib/WineTestBot/LogUtils.pm | 10 ++++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/testbot/lib/WineTestBot/Failures.pm b/testbot/lib/WineTestBot/Failures.pm index 4a65374988..dee8b68558 100644 --- a/testbot/lib/WineTestBot/Failures.pm +++ b/testbot/lib/WineTestBot/Failures.pm @@ -104,6 +104,7 @@ sub Validate($) my ($Field, $Name) = @$Pair; my $RegExp = $self->$Field; my $ErrMessage = eval { + use warnings FATAL => qw(regexp); if ($RegExp and "" =~ /$RegExp/) { return "The $Name regular expression should not match empty strings"; diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm index 99941b54a1..651c1d0a47 100644 --- a/testbot/lib/WineTestBot/LogUtils.pm +++ b/testbot/lib/WineTestBot/LogUtils.pm @@ -1391,7 +1391,10 @@ sub MatchLogFailures($$) { # Ignore failures that don't apply to this configuration my $ConfigRegExp = $Failure->ConfigRegExp; - my $Match = eval { !$ConfigRegExp or $ConfigName =~ /$ConfigRegExp/ }; + my $Match = eval { + use warnings FATAL => qw(regexp); + !$ConfigRegExp or $ConfigName =~ /$ConfigRegExp/; + }; next if (!$Match); my $UnitFailures = $FailureTree{$Failure->ErrorGroup}->{$Failure->TestUnit} ||= []; @@ -1413,7 +1416,10 @@ sub MatchLogFailures($$) foreach my $UnitFailure (@$UnitFailures) { my $RegExp = $UnitFailure->FailureRegExp; - my $Match = eval { $RegExp and $Line =~ /$RegExp/ }; + my $Match = eval { + use warnings FATAL => qw(regexp); + $RegExp and $Line =~ /$RegExp/; + }; next if (!$Match); my $LineFailures = $Group->{Failures}->{$ErrIndex} ||= []; -- 2.30.2

1 0

[PATCH v2 0/1] MR306: reg: Add REG_QWORD support to 'add'.
by Nikolay Sivov (＠nsivov) 24 Jun '22

24 Jun '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: reg: Add REG_QWORD support to 'add'. https://gitlab.winehq.org/wine/wine/-/merge_requests/306

2 2

[PATCH 0/3] MR311: win32u: menu conversion
by Jacek Caban (＠jacek) 24 Jun '22

24 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/311

4 5

[PATCH 0/1] MR304: mshtml: Enable CSS grid layout.
by Arek Hiler (＠ivyl) 24 Jun '22

24 Jun '22

This helps with Final Fantasy XIV launcher not rendering correctly under Wine. The login form should be to the right of the news section but due to grid layout being unsupported it renders below and requires scrolling to be accessed which is non-obvious. The CSS grid is not fully implemented in Gecko version we are using. https://bugzilla.mozilla.org/show_bug.cgi?id=1217086 + bugs it depends on seems to be representative of the state of the implementation in version ~47. Looks like it's mostly some nesting cases that were still being implemented. The only real problem seems to require a very specific setup https://bugzilla.mozilla.org/show_bug.cgi?id=1316649 but we still may want to pick up the fix for it for wine-gecko. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/304

3 2

[PATCH] maintainers: Remove myself as maintainer.
by Andrew Eikum 24 Jun '22

24 Jun '22

Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> --- I'm moving on to another job opportunity. I'm happy to discuss the audio modules. MAINTAINERS | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index c60a383b3b9..c5f560b2617 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -36,7 +36,7 @@ F: dlls/ntdll/signal_arm* F: programs/winedbg/be_arm* Audio I/O -M: Andrew Eikum <aeikum(a)codeweavers.com> +P: Andrew Eikum <coldpie(a)fastmail.com> F: dlls/dsound/ F: dlls/mmdevapi/ F: dlls/winealsa.drv/ @@ -104,7 +104,6 @@ F: dlls/dpwsockx/ DirectShow M: Zebediah Figura <z.figura12(a)gmail.com> -P: Andrew Eikum <aeikum(a)codeweavers.com> F: dlls/amstream/ F: dlls/devenum/ F: dlls/mciqtz32/ @@ -188,7 +187,6 @@ F: dlls/jscript/ Joystick input M: Rémi Bernon <rbernon(a)codeweavers.com> -P: Andrew Eikum <aeikum(a)codeweavers.com> F: dlls/dinput*/ F: dlls/windows.gaming.input/ F: dlls/winebus.sys/ @@ -196,7 +194,7 @@ F: dlls/winexinput.sys/ F: dlls/xinput*/ Media format conversion -M: Andrew Eikum <aeikum(a)codeweavers.com> +P: Andrew Eikum <coldpie(a)fastmail.com> F: dlls/*.acm/ F: dlls/msacm32/ @@ -252,7 +250,6 @@ F: dlls/ole32/storage32.h F: dlls/ole32/tests/storage32.c OLE Typelibs -P: Andrew Eikum <aeikum(a)codeweavers.com> P: Huw Davies <huw(a)codeweavers.com> F: dlls/oleaut32/typelib.c @@ -388,7 +385,6 @@ F: dlls/xmllite/ THE REST M: Alexandre Julliard <julliard(a)winehq.org> P: Alex Henrie <alexhenrie24(a)gmail.com> -P: Andrew Eikum <aeikum(a)codeweavers.com> P: Huw Davies <huw(a)codeweavers.com> P: Jacek Caban <jacek(a)codeweavers.com> P: Esme Povirk <esme(a)codeweavers.com> -- 2.36.1

1 0

[PATCH v2 0/1] MR296: nsiproxy.sys: Add static ARP entries which are always present on Windows.
by Paul Gofman (＠gofman) 24 Jun '22

24 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53175 Split off from MR https://gitlab.winehq.org/wine/wine/-/merge_requests/286. -- v2: nsiproxy.sys: Add static ARP entries which are always present on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/296

3 3

[PATCH v2 0/1] MR303: win32u: Don't report cloned monitors in EnumDisplayMonitors().
by Arek Hiler (＠ivyl) 24 Jun '22

24 Jun '22

Based on: ca39b1c22dfa ("user32: Don't report mirrored slave monitors in EnumDisplayMonitors.") 2affb854e524 ("user32: Change slave to a more neutral word.") Which seems to got lost during: 318673405c62 ("win32u: Move NtUserEnumDisplayMonitors implementation from user32.") Fixes regression with Elite Dangerous launcher freezing when cloned displays are present. Signed-off-by: Arkadiusz Hiler <ahiler(a)codeweavers.com> CC: @zhiyi @jacek -- v2: win32u: Don't report cloned monitors in EnumDisplayMonitors(). https://gitlab.winehq.org/wine/wine/-/merge_requests/303

4 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel