wine-devel

wine-devel@winehq.org

84463 discussions

Start a nNew thread

[PATCH 0/2] MR282: ntdll: Set r11 on exit from syscall dispatcher on x64.
by Jinoh Kang (＠iamahuman) 20 Jun '22

20 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/282

2 2

[PATCH 0/3] MR281: A few fixes in xmllite
by David Kahurani (＠kahurani) 20 Jun '22

20 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/281

2 3

[PATCH 0/1] MR280: include: Add definition of ScriptPlaceOpenType().
by Jactry Zeng (＠jactry) 20 Jun '22

20 Jun '22

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/280

3 2

[PATCH 0/2] MR269: ntdll: Respect zero_bits when mapping a builtin or native PE file.
by Brendan Shanks (＠bshanks) 20 Jun '22

20 Jun '22

Without the changes, the test passes or fails based on the binutils version being used. v2.35 (used on the Debian 11 testbot) gives 64-bit DLLs an image base under 4GB, and the test always passes. On a system with binutils 2.37 or later, 64-bit DLLs are based above 4GBs, and the test will fail. The map_view() change fixes native DLLs, and virtual_map_section() for builtin DLLs. I wasn't sure how to test a native DLL. This showed up under Wow64 when running the 64-bit Notepad++ installer (a 32-bit EXE), which runs 32-bit regsvr32 to register a 64-bit DLL. regsvr32 calls LoadLibraryExW() with LOAD_LIBRARY_AS_IMAGE_RESOURCE, which was returning a truncated pointer to the DLLs base address. Accessing this then crashed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/269

3 3

[PATCH 0/1] MR277: cmd: Handle lines with just spaces in bracket blocks.
by Bernhard Übelacker (＠bernhardu) 20 Jun '22

20 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51599 This patch attempts to ignore lines with just spaces inside bracket blocks like it does already for completely empty lines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/277

3 4

[PATCH 0/1] MR279: d3drm: IDirect3DRMMeshBuilder3 Optimize fake success
by Alistair Leslie-Hughes (＠alesliehughes) 20 Jun '22

20 Jun '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/279

2 1

[PATCH 0/9] MR278: d2d1: Partially implement effect registration parsing.
by Nikolay Sivov (＠nsivov) 19 Jun '22

19 Jun '22

This slightly reworks xmllite integration comparing to earlier patches, and add a proper forward to CreateEffect(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/278

3 9

[PATCH v4 1/8] server: Actually set initial status in set_async_direct_result handler.
by Jinoh Kang 19 Jun '22

19 Jun '22

Commit 15483b1a126 (server: Allow calling async_handoff() with status code STATUS_ALERTED., 2022-02-10) introduced the set_async_direct_result handler which calls async_set_initial_status(). However, the async_set_initial_status() call does nothing since async->terminated is set, leaving the async in a confusing state (unknown_status = 1 but pending/completed). So far, this issue is unlikely to have been a problem in practice for the following reasons: 1. async_set_initial_status() would have unset unknown_status, but it remains set instead. This is usually not a problem, since unknown_status is usually ever read by code paths effectively unreachable for non-device (e.g. socket) asyncs. It would still potentially allow set_async_direct_result to be called multiple times, but it wouldn't actually happen in practice unless something goes wrong. 2. async_set_initial_status() would have set initial_status; however, it is left with the default value STATUS_PENDING. If the actual status is something other than that, the handler closes the wait handle and async_satisfied (the only realconsumer of initial_status) would never be called anyway. For reasons above, this issue is not effectively observable or testable. Nonetheless, the current code does leave the async object in an inconsistent state. Fix this by removing the !async->terminated check in async_set_initial_status(). Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- Notes: v1 -> v2: no changes v2 -> v3: no changes v3 -> v4: reuse async_set_initial_status() per feedback server/async.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/server/async.c b/server/async.c index 7d0ff10f7a4..e92d4583c1e 100644 --- a/server/async.c +++ b/server/async.c @@ -303,11 +303,8 @@ struct async *create_async( struct fd *fd, struct thread *thread, const async_da void async_set_initial_status( struct async *async, unsigned int status ) { assert( async->unknown_status ); - if (!async->terminated) - { - async->initial_status = status; - async->unknown_status = 0; - } + async->initial_status = status; + async->unknown_status = 0; } void set_async_pending( struct async *async ) -- 2.34.1

3 10

[PATCH v2 0/1] MR274: winedbg: Fix typos in manpage.
by Jinoh Kang (＠iamahuman) 19 Jun '22

19 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v2: winedbg: Fix typos in manpage. https://gitlab.winehq.org/wine/wine/-/merge_requests/274

2 1

[PATCH 0/1] MR274: winedbg: Fix typos in manpage.
by Jinoh Kang (＠iamahuman) 18 Jun '22

18 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/274

3 2

[PATCH 0/1] MR276: include: Add _tcsto[u]ll declarations.
by Daniel Lehman (＠dlehman25) 18 Jun '22

18 Jun '22

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/276

2 1

[PATCH 0/4] MR275: ntdll: Plumb zero_bits parameter from virtual_map_section to virtual_map_builtin_module.
by Brendan Shanks (＠bshanks) 18 Jun '22

18 Jun '22

When running a 32-bit EXE in Wow64 mode with a fairly full address space, a builtin DLL may be loaded above the 4GB line. This is due to virtual_map_builtin_module calling virtual_map_image with zero_bits hardcoded to 0. virtual_map_section is called with the correct zero_bits, this patch propagates that parameter down through load_builtin, find_builtin_dll, open_builtin_pe_file, and virtual_map_builtin_module. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/275

2 4

[PATCH v2 0/9] MR272: d3dx10: Add D3DX10CreateThreadPump implementation.
by Piotr Caban (＠piotr) 18 Jun '22

18 Jun '22

The GetWorkItemCount implementation may look strange. It's done this way because of how WaitForAllItems is implemented. Alternative solution is to introduce separate counter for GetWorkItemCount. -- v2: d3dx10/tests: Add D3DX10CreateThreadPump tests. d3dx10: Add ID3DX10ThreadPump:PurgeAllItems implementation. d3dx10: Add ID3DX10ThreadPump:GetQueueStatus implementation. d3dx10: Add ID3DX10ThreadPump:WaitForAllItems implementation. d3dx10: Add ID3DX10ThreadPump:ProcessDeviceWorkItems implementation. d3dx10: Add ID3DX10ThreadPump:GetWorkItemCount implementation. d3dx10: Add ID3DX10ThreadPump:AddWorkItem implementation. d3dx10: Add D3DX10CreateThreadPump stub. d3dx10/tests: Fix texture leak in check_resource_data. https://gitlab.winehq.org/wine/wine/-/merge_requests/272

2 9

[PATCH 0/8] MR272: d3dx10: Add D3DX10CreateThreadPump implementation.
by Piotr Caban (＠piotr) 18 Jun '22

18 Jun '22

4 11

How to identify the primary battery (for Wine)
by Alex Henrie 18 Jun '22

18 Jun '22

Hi Sebastian, I've been working to improve battery status reporting for applications running on Wine on Linux. However, we Wine developers are not sure what the best way is to determine which battery is the computer's primary battery. Could you take a look at https://gitlab.winehq.org/wine/wine/-/merge_requests/134 and leave a comment there or on the wine-devel mailing list? Thanks in advance, -Alex

4 6

[PATCH v2 0/1] MR273: ntdll/tests: Add more tests for \Device\NamedPipe\ root directory.
by Jinoh Kang (＠iamahuman) 18 Jun '22

18 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v2: ntdll/tests: Add more tests for \Device\NamedPipe\ root directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/273

2 1

[PATCH 0/1] MR273: ntdll/tests: Add more tests for \Device\NamedPipe\ root directory.
by Jinoh Kang (＠iamahuman) 18 Jun '22

18 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/273

2 1

Re: [PATCH v2 0/5] MR257: d3dx: Add support for ID3DX10ThreadPump parameter in D3DX10CreateTexture* functions
by Piotr Caban (＠piotr) 18 Jun '22

18 Jun '22

On Sat Jun 18 11:22:29 2022 +0000, Matteo Bruni wrote: > Any particular reason the new test isn't inside the for loop right above > so to check every test_image[] with the thread pump? It will be added in next set of patches that implements D3DX10CreateThreadPump so it also tests thread pump implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/257#note_2310

1 0

[PATCH] ntdll: Implement NtQueryVolumeInformationFile FileFsFullSizeInformation.
by Michal Suchanek 18 Jun '22

18 Jun '22

Some programs refuse to write to disk when they cannot determine there is enough disk space. Implement the ntdll subfunction for it. Signed-off-by: Michal Suchanek <msuchanek(a)suse.de> --- dlls/ntdll/tests/file.c | 8 +------- dlls/ntdll/unix/file.c | 24 ++++++++++++++++++++++-- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index 106413a83fc..ede578081fc 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/ntdll/tests/file.c @@ -1289,7 +1289,7 @@ static void test_file_full_size_information(void) /* Assume No Quota Settings configured on Wine Testbot */ res = pNtQueryVolumeInformationFile(h, &io, &ffsi, sizeof ffsi, FileFsFullSizeInformation); - todo_wine ok(res == STATUS_SUCCESS, "cannot get attributes, res %lx\n", res); + ok(res == STATUS_SUCCESS, "cannot get attributes, res %lx\n", res); res = pNtQueryVolumeInformationFile(h, &io, &fsi, sizeof fsi, FileFsSizeInformation); ok(res == STATUS_SUCCESS, "cannot get attributes, res %lx\n", res); @@ -1305,8 +1305,6 @@ static void test_file_full_size_information(void) ok(fsi.BytesPerSector == 512, "[fsi] BytesPerSector expected 512, got %ld\n",fsi.BytesPerSector); ok(fsi.SectorsPerAllocationUnit == 8, "[fsi] SectorsPerAllocationUnit expected 8, got %ld\n",fsi.SectorsPerAllocationUnit); - todo_wine - { ok(ffsi.TotalAllocationUnits.QuadPart > 0, "[ffsi] TotalAllocationUnits expected positive, got negative value 0x%s\n", wine_dbgstr_longlong(ffsi.TotalAllocationUnits.QuadPart)); @@ -1324,14 +1322,10 @@ static void test_file_full_size_information(void) "[ffsi] CallerAvailableAllocationUnits error fsi:0x%s, ffsi: 0x%s\n", wine_dbgstr_longlong(fsi.AvailableAllocationUnits.QuadPart), wine_dbgstr_longlong(ffsi.CallerAvailableAllocationUnits.QuadPart)); - } /* Assume file system is NTFS */ - todo_wine - { ok(ffsi.BytesPerSector == 512, "[ffsi] BytesPerSector expected 512, got %ld\n",ffsi.BytesPerSector); ok(ffsi.SectorsPerAllocationUnit == 8, "[ffsi] SectorsPerAllocationUnit expected 8, got %ld\n",ffsi.SectorsPerAllocationUnit); - } CloseHandle( h ); } diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c index cc8bf0c6e82..c2586ca39d8 100644 --- a/dlls/ntdll/unix/file.c +++ b/dlls/ntdll/unix/file.c @@ -6630,9 +6630,29 @@ NTSTATUS WINAPI NtQueryVolumeInformationFile( HANDLE handle, IO_STATUS_BLOCK *io break; case FileFsFullSizeInformation: - FIXME( "%p: full size info not supported\n", handle ); - status = STATUS_NOT_IMPLEMENTED; + { + FILE_FS_FULL_SIZE_INFORMATION *info = buffer; + struct statfs stfs; + unsigned long sector_size = 512; + + if (length < sizeof(FILE_FS_FULL_SIZE_INFORMATION)) + { + status = STATUS_INFO_LENGTH_MISMATCH; + break; + } + + status = STATUS_UNSUCCESSFUL; + if (!fstatfs( fd, &stfs )) + { + info->TotalAllocationUnits.QuadPart = stfs.f_blocks; + info->CallerAvailableAllocationUnits.QuadPart = stfs.f_bavail; + info->ActualAvailableAllocationUnits.QuadPart = stfs.f_bfree; + info->SectorsPerAllocationUnit = stfs.f_bsize / sector_size; + info->BytesPerSector = sector_size; + status = STATUS_SUCCESS; + } break; + } case FileFsObjectIdInformation: FIXME( "%p: object id info not supported\n", handle ); -- 2.36.1

1 0

Wine staging 7.11 release
by Alistair Leslie-Hughes 18 Jun '22

18 Jun '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.11 (542 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * faudio: Send NOTIFY_CUESTOP when Stop is called. * dwmapi: Fill rateRefresh/rateCompose and qpcRefreshPeriod of DWM_TIMING_INFO from DwmGetCompositionTimingInfo(). * dwmapi: Return S_OK from DwmFlush(). Added: * None Updated: * None Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

[PATCH 0/2] MR270: include: Add interface declarations in dxgidebug.idl
by Biswapriyo Nath (＠Biswa96) 17 Jun '22

17 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/270

2 2

Gitlab transition roadmap
by Alexandre Julliard 17 Jun '22

17 Jun '22

Folks, Here's my current roadmap for the transition to Gitlab. Feedback and help are welcome. In particular, it would be nice if people would volunteer to update the documentation, I'm no good at that. - Make gitlab.winehq.org the canonical git repository, setup mirroring to source.winehq.org. - Refine behavior of mailing list gateway, possibly send output to separate list. - Update Wiki documentation (SubmittingPatches etc.), define signoff policy, document the new workflow. - Implement bot to automatically assign reviewers based on the MAINTAINERS file. - Make testbot work directly from MRs instead of mailing list patches. Integrate test reports with Gitlab CI. - Import Gitlab sources and build our own version, to enable making changes to the code. - Work with respective maintainers to plan if/when/how to move other Wine projects to Gitlab: - tools (done) - website (done) - wine-gecko (done) - wine-mono - wine-staging - vkd3d - appdb - bugzilla - fontforge - Require MRs for all patches, retire the source.winehq.org/patches tracker (direct links to old patches must of course be preserved). - Retire the gitweb browser, redirect to Gitlab. - Investigate moving the Wiki to Gitlab. - Investigate switching to the Gitlab bug tracker. -- Alexandre Julliard julliard(a)winehq.org

5 5

[PATCH v3 0/4] MR233: win32u: Partially move raw input APIs.
by Zebediah Figura (＠zfigura) 17 Jun '22

17 Jun '22

-- v3: win32u: Move NtUserGetRawInputBuffer from user32. win32u: Move NtUserGetRawInputData from user32. user32: Correctly fill the RAWINPUT structure on WoW64. user32/tests: Add some more tests related to the RAWINPUT structure. https://gitlab.winehq.org/wine/wine/-/merge_requests/233

4 7

Re: [PATCH v2 0/5] MR257: d3dx: Add support for ID3DX10ThreadPump parameter in D3DX10CreateTexture* functions - approved
by Alexandre Julliard (＠julliard) 17 Jun '22

17 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/257

1 0

Re: [PATCH v2 0/1] MR249: include: Emit CFI directives when building on Mac with gcc. - approved
by Alexandre Julliard (＠julliard) 17 Jun '22

17 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/249

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel