wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Start a nNew thread

Re: [PATCH v2 0/8] MR250: win32u: user32 conversion - approved
by Alexandre Julliard (＠julliard) 15 Jun '22

15 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/250

1 0

Re: [PATCH v2 0/3] MR251: cryptnet: - approved
by Alexandre Julliard (＠julliard) 15 Jun '22

15 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/251

1 0

[PATCH v3 0/9] MR180: misc: Fixes and workarounds for UAF warnings. (GCC12)
by Rémi Bernon (＠rbernon) 15 Jun '22

15 Jun '22

The mscoree one is a genuine UAF bug, other are more arguably false positive but GCC doesn't like freed pointer value to be used in any way. -- v3: server: Avoid using pointer value after realloc. d3drm: Avoid using pointer value after free. dsound: Avoid using pointer value after free. notepad: Avoid using pointer value after free. msi: Avoid using pointer value after free. user32/tests: Workaround use after free warnings. oleaut32/tests: Workaround use after free warnings. mshtml/tests: Avoid using pointer value after free. mscoree: Avoid using pointer after free. https://gitlab.winehq.org/wine/wine/-/merge_requests/180

3 10

Re: [PATCH v2 0/1] MR245: iphlpapi: Return ERROR_NO_DATA from GetIpNetTable() if no entries are found. - approved
by Alexandre Julliard (＠julliard) 15 Jun '22

15 Jun '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/245

1 0

[PATCH v3 0/1] MR134: ntdll: Don't hard-code the battery and AC adapter names on Linux
by Alex Henrie (＠alexhenrie) 15 Jun '22

15 Jun '22

Look through all of the devices in /sys/class/power_supply and take the statistics from the first battery and the first AC adapter. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52831 Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> -- v3: ntdll: Don't hard-code the battery and AC adapter names on Linux https://gitlab.winehq.org/wine/wine/-/merge_requests/134

4 5

[PATCH v4 0/3] MR247: uiautomationcore: Add basic IAccessible2 support.
by Connor McAdams (＠cmcadams) 15 Jun '22

15 Jun '22

I'm not sure if there's a 'correct' way to import headers from another project, so this might need some work. -- v4: uiautomationcore: Add basic IAccessible2 support. https://gitlab.winehq.org/wine/wine/-/merge_requests/247

3 5

[PATCH v4 0/6] MR228: d3dx: improvements to texture creation functions
by Piotr Caban (＠piotr) 15 Jun '22

15 Jun '22

- support HRESULT parameter in D3DX10CreateTextureFrom* - implement D3DX10CreateAsyncTextureProcessor -- v4: d3dx10/tests: Add D3DX10CreateAsyncTextureProcessor tests. d3dx10: Add D3DX10CreateAsyncTextureProcessor implementation. d3dx10: Add D3DX10CreateAsyncTextureProcessor stub. d3dx10: Exit early on volume textures in D3DX10CreateTextureFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/228

3 8

[PATCH v3 0/3] MR247: uiautomationcore: Add basic IAccessible2 support.
by Connor McAdams (＠cmcadams) 15 Jun '22

15 Jun '22

I'm not sure if there's a 'correct' way to import headers from another project, so this might need some work. -- v3: uiautomationcore: Add basic IAccessible2 support. ia2comproxy: Introduce new proxy stub DLL for IAccessible2. include: Import IAccessible2 headers. https://gitlab.winehq.org/wine/wine/-/merge_requests/247

3 6

Re: [PATCH v4 0/7] MR212: d3d11: Create dxgi resource objects for textures and buffers. - approved
by Zebediah Figura (＠zfigura) 15 Jun '22

15 Jun '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/212

1 0

[PATCH] include: Remove duplicate ICodecAPI::GetParameterValues function
by Andrew Eikum 15 Jun '22

15 Jun '22

Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> --- include/icodecapi.idl | 1 - 1 file changed, 1 deletion(-) diff --git a/include/icodecapi.idl b/include/icodecapi.idl index 7954b3fc2f6..dc31daf2e2c 100644 --- a/include/icodecapi.idl +++ b/include/icodecapi.idl @@ -42,7 +42,6 @@ interface ICodecAPI : IUnknown HRESULT GetParameterRange ([in] const GUID *api, [out] VARIANT *min, [out] VARIANT *max, [out] VARIANT *delta); HRESULT GetParameterValues ([in] const GUID *api, [out, size_is(,*count)] VARIANT **values, [out] ULONG *count); - HRESULT GetParameterValues ([in] const GUID *api, [out, size_is(,*count)] VARIANT **values, [out] ULONG *count); HRESULT GetDefaultValue ([in] const GUID *api, [out] VARIANT *value); HRESULT GetValue ([in] const GUID *api, [out] VARIANT *value); -- 2.36.1

1 0

[PATCH 0/1] MR249: include: Emit CFI directives when building on Mac with gcc.
by Stefan Dösinger (＠stefan) 15 Jun '22

15 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53157 Building with FSF gcc on mac is possible and the only way to get a --without-mingw build since clang does not support -mabi=ms. (Some hacks are needed to build winemac.drv.so though.) Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> --- No, FSF gcc on macos does not define __GCC_HAVE_DWARF2_CFI_ASM. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/249

3 3

[tools 0/6] Known failures tracking
by Francois Gouget 15 Jun '22

15 Jun '22

This patchset provides support for tracking known failures in the TestBot results. The main goal is to avoid false positives but there are some side benefits as well: * The job reports sent to developers link to the relevant WineHQ bugs which gives them more exposure and may help get them fixed faster. * The failure details pages will eventually link to all the tasks where the failure happened, which could be valuable to find patterns. * The failure page tracks when it was last seen. This simplifies spotting bugs which are fixed and could be closed. (Or failures where the regular expression needs to be updated / fixed) The patchset mostly follows the scheme described in bug 48912: https://bugs.winehq.org/show_bug.cgi?id=48912 There are some differences though: * The bug envisionned this scheme purely as a blacklist to avoid false positives. The implementation can certainly be used in this way but it is not limited to failures that cause false positives. Tracking other failures can provide the side benefits mentionned above. The only limit is the maintenance work required to track more failures. * As a consequence the FailureBlacklist class was renamed to Failure, and the FailureBlacklistUses was renamed to TaskFailures since it links Tasks with the related Failures. * The FailureBlacklistVMs purpose is not really described in the bug but I think the goal was to provide a way to deckare that the failure is expected to only happen on specific test configurations. Instead the Failures class has a ConfigRegExp regular expression which specifies which test configurations the failure applies to. The test 'configuration name' is of the form 'VM:logfile' which allows matching specific Windows versions (thanks to the TestBot VM naming scheme), specific Windows locales (part of the VM name), specific bitnesses (part of the log filename), or specific Wine locales (part of the log filename). For instance: ^w8 -> all Windows 8 VMs :exe -> all Windows tests (exe32.report and exe64.report) ^w10.*_ja.*: -> all Windows 10 Japanese test configurations win|wow -> all Wine test configurations (win32.report, ...) (win|wow).*_fr -> French Wine test configurations * Changes in FailureBlacklists -> Failures - Primary key: (Bug, TestModule, TestUnit) -> Id Some issues generate quite a few failures. So in case trying to match them all results in a regular expression that's too long (either because of the database limit or for readability), this change makes it possible to add multiple Failure objects to track them all. - TestModule -> ErrorGroup The .errors files split the errors in groups. Each group corresponds to a test module, but extra errors (too much output, missing summary lines, etc) are in a separate group. So I renamed TestModule to ErrorGroup as a reminder to the coder that this is meant to match the .errors group names, not just test modules. - Name -> (BugStatus, BugDescription) Instead of having a name describing the failure, this patchset uses the corresponding WineHQ bug description. The TestBot also retrieves the bug status which allows checking that closed bugs dont happen anymore, or open bugs that should be closed. - LastUsed -> (LastNew, LastOld) The LastUse field was split into LastNew and LastOld to track whether the failure would cause false positives without the known failures support. * Changes in FailureBlacklistUses -> TaskFailures - (Bug, TestModule, TestUnit) -> FailureId This is a consequence of the Failure primary key change described above. - () -> (TaskLog) This allows tracking which task log the failure was found in. This is quite important for Wine tasks since they run all the test configurations in just one task. - () -> (NewCount, OldCount) This provides a count of matching failures and whether they would have been tagged as old or new without this patchset. This provides a quick way to know whether there is the same number of failures every time or whether the number of failures changes from one run to the next. It also provides a quick way to know how many failures to look for when jumping to the log. Francois Gouget (6): testbot: Add tables to track the test failures. testbot/web: Add pages to add, edit and show known failures. testbot: Match the failures with the test logs. testbot/web: Link job details to the related known failures. testbot/WineSendLog: Take into account the known failures. testbot/UpdateFailures: Add a script to refresh the failures' bug information. testbot/bin/UpdateFailures.pl | 192 ++++++ testbot/bin/WineSendLog.pl | 78 ++- testbot/ddl/update47.sql | 33 + testbot/ddl/winetestbot.sql | 32 + testbot/doc/INSTALL.txt | 5 + testbot/doc/winetestbot-schema.dia | 852 +++++++++++++++++++++--- testbot/lib/WineTestBot/CGI/PageBase.pm | 1 + testbot/lib/WineTestBot/Config.pm | 6 +- testbot/lib/WineTestBot/Failures.pm | 184 +++++ testbot/lib/WineTestBot/Jobs.pm | 6 + testbot/lib/WineTestBot/LogUtils.pm | 180 ++++- testbot/lib/WineTestBot/TaskFailures.pm | 120 ++++ testbot/lib/WineTestBot/Tasks.pm | 4 + testbot/web/FailureDetails.pl | 119 ++++ testbot/web/FailuresList.pl | 160 +++++ testbot/web/JobDetails.pl | 54 +- testbot/web/WineTestBot.css | 3 + 17 files changed, 1907 insertions(+), 122 deletions(-) create mode 100755 testbot/bin/UpdateFailures.pl create mode 100644 testbot/ddl/update47.sql create mode 100644 testbot/lib/WineTestBot/Failures.pm create mode 100644 testbot/lib/WineTestBot/TaskFailures.pm create mode 100644 testbot/web/FailureDetails.pl create mode 100644 testbot/web/FailuresList.pl -- 2.30.2

1 6

[PATCH v4 0/1] MR190: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail).
by Jinoh Kang (＠iamahuman) 15 Jun '22

15 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52673 Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v4: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail). https://gitlab.winehq.org/wine/wine/-/merge_requests/190

3 2

[PATCH v3 0/6] MR228: d3dx: improvements to texture creation functions
by Piotr Caban (＠piotr) 15 Jun '22

15 Jun '22

- support HRESULT parameter in D3DX10CreateTextureFrom* - implement D3DX10CreateAsyncTextureProcessor -- v3: d3dx10/tests: Add D3DX10CreateAsyncTextureProcessor tests. d3dx10: Add D3DX10CreateAsyncTextureProcessor implementation. d3dx10: Add D3DX10CreateAsyncTextureProcessor stub. d3dx10: Exit early on volume textures in D3DX10CreateTextureFromMemory. d3dx10/tests: Add D3DX10CreateTextureFromMemory HRESULT argument tests. d3dx10: Don't ignore HRESULT parameter in D3DX10CreateTextureFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/228

3 9

[PATCH 0/8] MR250: win32u: user32 conversion
by Jacek Caban (＠jacek) 15 Jun '22

15 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/250

4 14

[PATCH v2 0/3] MR247: uiautomationcore: Add basic IAccessible2 support.
by Connor McAdams (＠cmcadams) 15 Jun '22

15 Jun '22

I'm not sure if there's a 'correct' way to import headers from another project, so this might need some work. -- v2: uiautomationcore: Add basic IAccessible2 support. ia2comproxy: Introduce new proxy stub DLL for IAccessible2. include: Import IAccessible2 headers. https://gitlab.winehq.org/wine/wine/-/merge_requests/247

4 8

[PATCH 0/3] MR247: uiautomationcore: Add basic IAccessible2 support.
by Connor McAdams (＠cmcadams) 15 Jun '22

15 Jun '22

I'm not sure if there's a 'correct' way to import headers from another project, so this might need some work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/247

3 8

[PATCH 0/3] MR251: cryptnet:
by Hans Leidekker (＠hans) 15 Jun '22

15 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/251

2 3

[PATCH v2 0/6] MR228: d3dx: improvements to texture creation functions
by Piotr Caban (＠piotr) 15 Jun '22

15 Jun '22

- support HRESULT parameter in D3DX10CreateTextureFrom* - implement D3DX10CreateAsyncTextureProcessor -- v2: d3dx10/tests: Add D3DX10CreateAsyncTextureProcessor tests. d3dx10: Add D3DX10CreateAsyncTextureProcessor implementation. d3dx10: Add D3DX10CreateAsyncTextureProcessor stub. d3dx10: Exit early on volume textures in D3DX10CreateTextureFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/228

3 17

[PATCH v2 0/1] MR190: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail).
by Jinoh Kang (＠iamahuman) 15 Jun '22

15 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52673 Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v2: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail). https://gitlab.winehq.org/wine/wine/-/merge_requests/190

3 2

Re: [PATCH v2 0/1] MR248: winhttp: Release object on allocation failure. - closed
by Hans Leidekker (＠hans) 15 Jun '22

15 Jun '22

This merge request was closed by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/248

1 0

[PATCH 0/1] MR248: winhttp: Release object on allocation failure.
by Hans Leidekker (＠hans) 15 Jun '22

15 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/248

2 1

[PATCH v2 0/1] MR134: ntdll: Don't hard-code the battery and AC adapter names on Linux
by Alex Henrie (＠alexhenrie) 15 Jun '22

15 Jun '22

Look through all of the devices in /sys/class/power_supply and take the statistics from the first battery and the first AC adapter. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52831 Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> -- v2: ntdll: Don't hard-code the battery and AC adapter names on Linux https://gitlab.winehq.org/wine/wine/-/merge_requests/134

4 5

[PATCH 0/1] MR245: iphlpapi: Return ERROR_NO_DATA from GetIpNetTable() if no entries are found.
by Paul Gofman (＠gofman) 15 Jun '22

15 Jun '22

Fixes SCP: Secret Laboratory crash on launch after recent game update. Windows normally returns some entries even if there is no active network connection. I however was able to test no data case on the up to date Windows 10 by disabling all the network adapters and clearing arp cache with 'arp -d *'. So GetIpNetTable() returns ERROR_INSUFFICIENT_BUFFER when called without buffer (first time in test) with some excessive buffer size. But then when called with the buffer it returns ERROR_NO_DATA and sets number of entries in the table to 0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/245

3 2

[PATCH v3 1/5] d2d1/tests: Add more test xml.
by Ziqing Hui 15 Jun '22

15 Jun '22

Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com> --- dlls/d2d1/tests/d2d1.c | 120 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 112 insertions(+), 8 deletions(-) diff --git a/dlls/d2d1/tests/d2d1.c b/dlls/d2d1/tests/d2d1.c index bc662b4f8ae..970706bc569 100644 --- a/dlls/d2d1/tests/d2d1.c +++ b/dlls/d2d1/tests/d2d1.c @@ -99,6 +99,17 @@ L"<?xml version='1.0'?> \ </Effect> \ "; +static const WCHAR *effect_xml_inputs_attribute = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <Inputs min='1' max='10' deadbeef='abcdef'/> \ + </Effect> \ +"; + static const WCHAR *effect_xml_without_version = L"<Effect> \ <Property name='DisplayName' type='string'/> \ @@ -170,6 +181,90 @@ L"<?xml version='1.0'?> \ </Effect> \ "; +static const WCHAR *effect_xml_wrong_type = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string' value='TestEffect'/> \ + <Property name='Author' type='uint32' value='32'/> \ + <Property name='Category' type='string' value='Test'/> \ + <Property name='Description' type='string' value='Test effect.'/> \ + <Inputs/> \ + </Effect> \ +"; + +static const WCHAR *effect_xml_duplicate_property = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <Property name='Description' type='string'/> \ + <Inputs/> \ + </Effect> \ +"; + +static const WCHAR *effect_xml_lower_case_effect = +L"<?xml version='1.0'?> \ + <effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <Inputs/> \ + </effect> \ +"; + +static const WCHAR *effect_xml_lower_case_property = +L"<?xml version='1.0'?> \ + <Effect> \ + <property name='DisplayName' type='string'/> \ + <property name='Author' type='string'/> \ + <property name='Category' type='string'/> \ + <property name='Description' type='string'/> \ + <Inputs/> \ + </Effect> \ +"; + +static const WCHAR *effect_xml_lower_case_inputs = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <inputs/> \ + </Effect> \ +"; + +static const WCHAR *effect_xml_min_max_inputs_a = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <Property name='MinInputs' type='uint32' value='1'/> \ + <Property name='MaxInputs' type='uint32' value='2'/> \ + <Inputs/> \ + </Effect> \ +"; + +static const WCHAR *effect_xml_min_max_inputs_b = +L"<?xml version='1.0'?> \ + <Effect> \ + <Property name='DisplayName' type='string'/> \ + <Property name='Author' type='string'/> \ + <Property name='Category' type='string'/> \ + <Property name='Description' type='string'/> \ + <Inputs> \ + <Property name='Min' type='uint32' value='1'/> \ + <Property name='Max' type='uint32' value='2'/> \ + </Inputs> \ + </Effect> \ +"; + + static const DWORD test_vs[] = { #if 0 @@ -10604,10 +10699,11 @@ static void test_effect_register(BOOL d3d11) } xml_tests[] = { - {effect_xml_a, S_OK}, - {effect_xml_b, S_OK}, - {effect_xml_c, S_OK}, - {effect_xml_minimum, S_OK}, + {effect_xml_a, S_OK}, + {effect_xml_b, S_OK}, + {effect_xml_c, S_OK}, + {effect_xml_minimum, S_OK}, + {effect_xml_inputs_attribute, S_OK}, {effect_xml_without_version, HRESULT_FROM_WIN32(ERROR_NOT_FOUND)}, {effect_xml_without_inputs, E_INVALIDARG}, {effect_xml_without_name, E_INVALIDARG}, @@ -10615,6 +10711,13 @@ static void test_effect_register(BOOL d3d11) {effect_xml_without_category, E_INVALIDARG}, {effect_xml_without_description, E_INVALIDARG}, {effect_xml_without_type, E_INVALIDARG}, + {effect_xml_wrong_type, E_INVALIDARG}, + {effect_xml_duplicate_property, E_INVALIDARG}, + {effect_xml_lower_case_effect, HRESULT_FROM_WIN32(ERROR_NOT_FOUND)}, + {effect_xml_lower_case_property, HRESULT_FROM_WIN32(ERROR_NOT_FOUND)}, + {effect_xml_lower_case_inputs, HRESULT_FROM_WIN32(ERROR_NOT_FOUND)}, + {effect_xml_min_max_inputs_a, E_INVALIDARG}, + {effect_xml_min_max_inputs_b, HRESULT_FROM_WIN32(ERROR_NOT_FOUND)}, }; const D2D1_PROPERTY_BINDING binding[] = @@ -10926,10 +11029,11 @@ static void test_effect_properties(BOOL d3d11) } system_property_tests[] = { - {effect_xml_a, L"TestEffectA", effect_author, effect_category, effect_description, 1, 1}, - {effect_xml_b, L"TestEffectB", effect_author, effect_category, effect_description, 1, 1}, - {effect_xml_c, L"TestEffectC", effect_author, effect_category, effect_description, 1, 1}, - {effect_xml_minimum, L"", L"" ,L"", L"", 0, 0}, + {effect_xml_a, L"TestEffectA", effect_author, effect_category, effect_description, 1, 1}, + {effect_xml_b, L"TestEffectB", effect_author, effect_category, effect_description, 1, 1}, + {effect_xml_c, L"TestEffectC", effect_author, effect_category, effect_description, 1, 1}, + {effect_xml_minimum, L"", L"" ,L"", L"", 0, 0}, + {effect_xml_inputs_attribute, L"", L"" ,L"", L"", 0, 0}, }; if (!init_test_context(&ctx, d3d11)) -- 2.25.1

2 6

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel